cps.git
4 months agoAdd new k6 test profile for running edurance tests 41/139341/8
halil.cakal [Wed, 6 Nov 2024 15:05:22 +0000 (15:05 +0000)]
Add new k6 test profile for running edurance tests

- assign a profile name to the existing k6 tests (kpi)
- add control which profile is run using k6 config file
- both test profiles can run in parallel

Issue-ID: CPS-2464

Change-Id: I9fea13f12e2da46bd55b4315c68209843c1abe06
Signed-off-by: halil.cakal <halil.cakal@est.tech>
4 months ago[k6] Lower load for legacy async batch operation test 00/139400/2
danielhanrahan [Wed, 13 Nov 2024 18:07:48 +0000 (18:07 +0000)]
[k6] Lower load for legacy async batch operation test

Legacy async batch operation test is failing and reporting zero
as result due to timeouts in the test.

- Lower total batch requests to 100 instead of 1000
- Limit the number of kafka messages per batch to 200 instead of 1000
  to avoid timeout issues.

Issue-ID: CPS-2274
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I06c04173ca1ed0f3580df6a73b5d647ab7ed0c71

4 months agoFixing dmi plugin version in NCMP 05/139405/3
mpriyank [Fri, 15 Nov 2024 15:21:53 +0000 (15:21 +0000)]
Fixing dmi plugin version in NCMP

- Fallback to previous stable version of NCMP in order to stabilize the
  CPS-NCMP CSIT issue so that we are not blocked in our development
- Note : Issue at DMI plugin is still investigated

Issue-ID: CPS-2503
Change-Id: I060c89e927465f16ef979e45f18f98fe605d5b7f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
4 months agoMerge "Support alternate Id interface for ncmp inventory /ch/cmhandles endpoint"
Priyank Maheshwari [Fri, 15 Nov 2024 10:36:04 +0000 (10:36 +0000)]
Merge "Support alternate Id interface for ncmp inventory /ch/cmhandles endpoint"

4 months agoMerge "[k6] Output git build info in k6 log"
Toine Siebelink [Thu, 14 Nov 2024 08:29:18 +0000 (08:29 +0000)]
Merge "[k6] Output git build info in k6 log"

4 months agoMerge "Hashmark support in 3gpp objects"
Toine Siebelink [Wed, 13 Nov 2024 14:48:49 +0000 (14:48 +0000)]
Merge "Hashmark support in 3gpp objects"

4 months ago[k6] Output git build info in k6 log 97/139397/1
danielhanrahan [Wed, 13 Nov 2024 12:57:50 +0000 (12:57 +0000)]
[k6] Output git build info in k6 log

- output build info in k6 log using actuator endpoint
- use quiet output while pulling images for less log noise

Issue-ID: CPS-2445
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4464b70650828c842c94677dddcc4d112f9758e0

4 months agoFix for cps-master-merge-java job after removing oParent 96/139396/1
sourabh_sourabh [Wed, 13 Nov 2024 13:42:42 +0000 (13:42 +0000)]
Fix for cps-master-merge-java job after removing oParent

- Added ecom repo. configuration into cps-aggregator
- Explicitly set onap.nexus.url

Issue-ID: CPS-2496
Change-Id: I010f97ea438bfbaa9cde81ef1a5cc9839b0d1121
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
4 months agoFix for cps-master-merge-java job after removing oParent 94/139394/1
sourabh_sourabh [Wed, 13 Nov 2024 12:54:17 +0000 (12:54 +0000)]
Fix for cps-master-merge-java job after removing oParent

Issue-ID: CPS-2496
Change-Id: I94eef4006b8c96db2c9d350c3330edf98924099c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
4 months agoSupport alternate Id interface for ncmp inventory /ch/cmhandles endpoint 27/139327/7
seanbeirne [Tue, 5 Nov 2024 10:21:30 +0000 (10:21 +0000)]
Support alternate Id interface for ncmp inventory /ch/cmhandles endpoint

Issue-ID: CPS-2481
Change-Id: I8a200495be1afb9a4f256127f886bed78c77f653
Signed-off-by: seanbeirne <sean.beirne@est.tech>
4 months agoMerge "Configure Maven Profile for Performance Tests"
Toine Siebelink [Tue, 12 Nov 2024 17:29:09 +0000 (17:29 +0000)]
Merge "Configure Maven Profile for Performance Tests"

4 months agoHashmark support in 3gpp objects 59/139359/2
egernug [Fri, 8 Nov 2024 13:34:00 +0000 (13:34 +0000)]
Hashmark support in 3gpp objects

NCMP should cut off the part after the # of an alternateid
and use only the first part in CPS match check, but send the complete request to the DMI plugin.

Issue-ID: CPS-2485

Change-Id: Icc1442f2be9545036619043692c3559ffadecb0d
Signed-off-by: egernug <gerard.nugent@est.tech>
4 months agoMerge "Add index to yang_resource for faster registration"
Toine Siebelink [Tue, 12 Nov 2024 10:03:42 +0000 (10:03 +0000)]
Merge "Add index to yang_resource for faster registration"

4 months agoMerge "CM Data Notifications RTD"
Toine Siebelink [Mon, 11 Nov 2024 16:56:43 +0000 (16:56 +0000)]
Merge "CM Data Notifications RTD"

4 months agoConfigure Maven Profile for Performance Tests 74/139374/2
sourabh_sourabh [Mon, 11 Nov 2024 16:40:59 +0000 (16:40 +0000)]
Configure Maven Profile for Performance Tests

- Enhance: Define global property for maven-resources-plugin and maven-failsafe-plugin version.
- Updated Maven configuration to include performance test cases
- Enable performance test inclusion in build with include-performance profile
- Configured build to run all performance tests with include-performance profile

Issue-ID: CPS-2491
Change-Id: Iecedfc0fce9ce8ed2bfab00784d22eb53cacd18a
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
4 months agoMerge "Support Alternate-Id for CPS-E05 data batch interface"
Priyank Maheshwari [Mon, 11 Nov 2024 11:59:46 +0000 (11:59 +0000)]
Merge "Support Alternate-Id for CPS-E05 data batch interface"

4 months agoCM Data Notifications RTD 61/139361/2
mpriyank [Fri, 8 Nov 2024 11:01:59 +0000 (11:01 +0000)]
CM Data Notifications RTD

- Added RTD for CM Data Notifications and left a note about the key
  usage.

Issue-ID: CPS-2436
Change-Id: Id1592c85009b945d1785350d54ae8884fcc8bebd
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
4 months agoAdd index to yang_resource for faster registration 64/139364/1
danielhanrahan [Wed, 30 Oct 2024 11:19:40 +0000 (11:19 +0000)]
Add index to yang_resource for faster registration

This doubles registration speed by adding a DB index
for yang resource module_name and revision.

Issue-ID: CPS-2478
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I747ac3c8d4a524082b08ab44417e913b163207ce

4 months agoMerge "Cm Avc Event to have same key"
Toine Siebelink [Thu, 7 Nov 2024 09:59:25 +0000 (09:59 +0000)]
Merge "Cm Avc Event to have same key"

4 months agoMerge "Removing ONAP O-Parent as parent from CPS"
Toine Siebelink [Thu, 7 Nov 2024 09:57:13 +0000 (09:57 +0000)]
Merge "Removing ONAP O-Parent as parent from CPS"

4 months agoMerge "XML content support on get a node"
Priyank Maheshwari [Wed, 6 Nov 2024 10:54:19 +0000 (10:54 +0000)]
Merge "XML content support on get a node"

4 months agoMerge "Change the dmi address source from dmi-service-name to dmi-data-service-name...
Sourabh Sourabh [Wed, 6 Nov 2024 10:48:53 +0000 (10:48 +0000)]
Merge "Change the dmi address source from dmi-service-name to dmi-data-service-name for writeDataJob"

4 months agoChange the dmi address source from dmi-service-name to dmi-data-service-name for... 63/139263/6
egernug [Thu, 24 Oct 2024 10:14:46 +0000 (11:14 +0100)]
Change the dmi address source from dmi-service-name to dmi-data-service-name for writeDataJob

-Change implementation to convert datanode to yang model
-Change to resolve service name consistent with other implementations

Issue-ID: CPS-2455

Change-Id: I9cbe494b8c37eb963c42abee1ac5f04a3f695d07
Signed-off-by: egernug <gerard.nugent@est.tech>
4 months agoSupport Alternate-Id for CPS-E05 data batch interface 04/139304/4
seanbeirne [Mon, 21 Oct 2024 15:18:27 +0000 (16:18 +0100)]
Support Alternate-Id for CPS-E05 data batch interface

Issue-ID: CPS-2274
Change-Id: I75163bc7943fca5cbbe8c24601a2dfc184a9e6cc
Signed-off-by: seanbeirne <sean.beirne@est.tech>
4 months agoRemoving ONAP O-Parent as parent from CPS 65/139265/11
sourabh_sourabh [Thu, 24 Oct 2024 13:24:54 +0000 (14:24 +0100)]
Removing ONAP O-Parent as parent from CPS

- Fixed checkstyle and license validation.
- Updated checkstyle configuration (`onap-java-style.xml` and `check-license.xml`) to ensure compatibility with Maven Checkstyle Plugin version 3.3.1
- Removed obsolete properties causing build failures.
- Improved code style rules to meet ONAP Java guidelines.
- Vulnerabilities scan are now configured on parent pom.xml
- Fixed all code style.

Issue-ID: CPS-2470
Change-Id: I1e72af604415aa7587cbe1dff471ed0323e29aa3
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
4 months agoXML content support on get a node 55/137555/78
Rudrangi Anupriya [Fri, 1 Nov 2024 18:46:58 +0000 (00:16 +0530)]
XML content support on get a node

Here to bring Support for XML Response Entity In GET A NODE

- Made changes in components.yml to support contentType as
   application/xml
- Add ContentTypeInheadr in cpsDataV2.yml to support application/xml
- Add contentTypeInHeader parameter to accept xml  in
    DataRestController.java
- Implemented Logic to convert DataMaps To XML Data
- written testcase for above changes made

Issue-ID: CPS-2280
Change-Id: Ibe7ffb66ccbb03703626132c6d5c2eade0e7ab4b
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
4 months agoRefactor module synch task 23/139323/1
halil.cakal [Mon, 4 Nov 2024 17:47:55 +0000 (17:47 +0000)]
Refactor module synch task

- improve readablity of ModuleSyncTasks

Issue-ID: CPS-2474

Change-Id: Ib0342e8fad00b431a293c5095fe54f4917f7a51b
Signed-off-by: halil.cakal <halil.cakal@est.tech>
4 months agoMerge "[Module Sync] Always update states at end of batch"
Toine Siebelink [Mon, 4 Nov 2024 17:21:56 +0000 (17:21 +0000)]
Merge "[Module Sync] Always update states at end of batch"

4 months agoCm Avc Event to have same key 21/139321/1
mpriyank [Mon, 4 Nov 2024 15:59:58 +0000 (15:59 +0000)]
Cm Avc Event to have same key

- incoming Cm Avc Event from DMI Plugin is consumed and forwarded to
  target topic
- the key from source topic to be used in the target topic while
  forwarding
- with same key the ordering of the message will be preserved
- NOTE: the RTD related changes will be a separate patchset

Issue-ID: CPS-2436
Change-Id: Ie692663706b378022ec0d621d92ca5054bad8d1b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
4 months agoMerge "Verify LCM events during registration"
Daniel Hanrahan [Mon, 4 Nov 2024 15:47:48 +0000 (15:47 +0000)]
Merge "Verify LCM events during registration"

4 months agoVerify LCM events during registration 05/139305/12
mpriyank [Fri, 25 Oct 2024 08:55:22 +0000 (09:55 +0100)]
Verify LCM events during registration

- verifying the LCM state transition to ADVISED and then to READY state
  during cm handle registration
- enhanced the base kafka test container to be thread safe
- changed the auto offset reset policy for integration test to latest
  (default) from earliest
- added retry mechanism to poll for the records

Issue-ID: CPS-2468
Change-Id: Iabe603e1f5dd985899f04f5ace5d082acef7567a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
4 months agoMerge "Add docker compose deployment for endurance tests"
Lee Anjella Macabuhay [Mon, 4 Nov 2024 13:56:18 +0000 (13:56 +0000)]
Merge "Add docker compose deployment for endurance tests"

4 months ago[Module Sync] Always update states at end of batch 19/139319/1
danielhanrahan [Fri, 1 Nov 2024 17:35:21 +0000 (17:35 +0000)]
[Module Sync] Always update states at end of batch

This commit moves the state update code into the 'finally'
block, so that state updates are always sent for the handles
that finished syncing, even if an exception occurred.
This commit also fixes a typo in cmHandleStatePerCmHandle.

Issue-ID: CPS-2474
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic25608a5772c0873fe0d0f8aca8d70bcda51d94a

4 months agoMerge "[Module Sync] Log state changes after persistence"
Priyank Maheshwari [Mon, 4 Nov 2024 12:42:06 +0000 (12:42 +0000)]
Merge "[Module Sync] Log state changes after persistence"

5 months ago[Module Sync] Log state changes after persistence 08/139308/5
danielhanrahan [Fri, 25 Oct 2024 15:28:17 +0000 (16:28 +0100)]
[Module Sync] Log state changes after persistence

Currently, module sync will output messages such as:
  "cm-handle-1 is now in READY state"
before the state change is persisted to the DB. If an exception
occurs, the new state may not be persisted, which makes debugging
hard due to misleading log entries. This commit moves the logging to
the LCM state handler immediately after the change is persisted.

- Move logging of state changes to LcmEventsCmHandleStateHandler.
- Remove unused code in LcmEventsCmHandleStateHandler.
- Add tests of state change logging.
- Update the main test showing the bug to instead show expected
  behaviour, but disable test for now using @Ignore.

Issue-ID: CPS-2474
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I58646af6df95e07e69ca525744713a7c01c25e41

5 months agoAdd docker compose deployment for endurance tests 11/139311/2
halil.cakal [Thu, 31 Oct 2024 10:37:13 +0000 (10:37 +0000)]
Add docker compose deployment for endurance tests

- add new config file containing env variables for endurance test
- add notes to describe how to run and stop it

Note 1: Existing docker-compose deployment won't be affected by this
changes
Note 2: Both docker-compose can be deployed simultaneously without any
issue

Issue-ID: CPS-2463

Change-Id: I15936718dda2f31a5077b9c36eded21c1a85dfcd
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 months agoChanging git-info plugin phase 07/139307/1
mpriyank [Wed, 30 Oct 2024 17:21:20 +0000 (17:21 +0000)]
Changing git-info plugin phase

- get-git-info plugin to generate the output during validate phase
  instead of package phase for it to be part of cps-application jar

Issue-ID: CPS-2445
Change-Id: Ibdd1eea8e3e4cb58d6b16ef47b0d158dc1f842a9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 months agoMerge "Fix failing CSIT and add unit test proving the bug"
Toine Siebelink [Tue, 29 Oct 2024 18:32:52 +0000 (18:32 +0000)]
Merge "Fix failing CSIT and add unit test proving the bug"

5 months agoMerge "Add metadata related to builds and commits"
Toine Siebelink [Tue, 29 Oct 2024 18:01:09 +0000 (18:01 +0000)]
Merge "Add metadata related to builds and commits"

5 months agoMerge "[k6] Increase timeouts after DMI stub changes"
Daniel Hanrahan [Tue, 29 Oct 2024 10:09:29 +0000 (10:09 +0000)]
Merge "[k6] Increase timeouts after DMI stub changes"

5 months agoMerge "Support Alternate-Id for CPS-E05 id-searches and searchCmHandleIds"
Daniel Hanrahan [Tue, 29 Oct 2024 10:06:43 +0000 (10:06 +0000)]
Merge "Support Alternate-Id for CPS-E05 id-searches and searchCmHandleIds"

5 months ago[k6] Increase timeouts after DMI stub changes 98/139298/1
danielhanrahan [Sat, 26 Oct 2024 02:18:11 +0000 (03:18 +0100)]
[k6] Increase timeouts after DMI stub changes

This commit changes k6 setup and teardown timeouts to 20 minutes.
This fixes current test failures due to time-outs.

Issue-ID: CPS-2410
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifdbf26ed1669cdb3a2fc9afb551308757511281b

5 months agoSupport Alternate-Id for CPS-E05 id-searches and searchCmHandleIds 92/139092/14
seanbeirne [Tue, 3 Sep 2024 14:27:28 +0000 (15:27 +0100)]
Support Alternate-Id for CPS-E05 id-searches and searchCmHandleIds

Issue-ID: CPS-2402
Issue-ID: CPS-2383
Change-Id: I5dd3132b70b401bf2f50f77c2c131d5d34aa0c0a
Signed-off-by: seanbeirne <sean.beirne@est.tech>
5 months agoFix failing CSIT and add unit test proving the bug 67/139267/4
danielhanrahan [Thu, 24 Oct 2024 16:11:57 +0000 (17:11 +0100)]
Fix failing CSIT and add unit test proving the bug

It was determined that one CSIT is intermittently failing due
to a CM-handle being deleted while module sync is in progress,
which causes the whole batch operation to fail. Even CM-handles
that did sync will not go into READY state, despite the logs
saying otherwise. This commit reproduces the issue in a unit test,
and prevents the issue in the CSIT by changing test order. Also,
errors during module sync tasks are reported at ERROR level.
(The actual bug fix will be addressed in another patch.)

Issue-ID: CPS-2474
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7e0d617cbd48d8fd1fad036079fbd876ee21d8a8

5 months ago[k6] Update tests for DMI stub changes for modules 93/139293/1
danielhanrahan [Fri, 25 Oct 2024 13:34:19 +0000 (14:34 +0100)]
[k6] Update tests for DMI stub changes for modules

It is needed to update k6 tests due to changes made in
the DMI stub for dynamic module generation:

- Increase setup timeout to 30 minutes
- Use 5 module set tags: tagA to tagE
- Update module search to look for module100

Issue-ID: CPS-2410
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I17830e4d858883743476d297af90d1ceaba1eb44

5 months agoRemove note about TBDMT from Documentation 66/139266/1
ToineSiebelink [Thu, 24 Oct 2024 14:09:46 +0000 (15:09 +0100)]
Remove note about TBDMT from Documentation

Issue-ID: CPS-2433
Change-Id: Ia791cd7214eec08d2209469b82f56a04de42868c
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
5 months agoMerge "Added arcitecture tests for CPS (REST and service and RI)"
Toine Siebelink [Thu, 24 Oct 2024 13:15:58 +0000 (13:15 +0000)]
Merge "Added arcitecture tests for CPS (REST and service and RI)"

5 months agoMerge "Update deployment docs for load balancer config"
Lee Anjella Macabuhay [Thu, 24 Oct 2024 12:12:29 +0000 (12:12 +0000)]
Merge "Update deployment docs for load balancer config"

5 months agoAdded arcitecture tests for CPS (REST and service and RI) 19/139219/7
leventecsanyi [Thu, 17 Oct 2024 12:59:49 +0000 (14:59 +0200)]
Added arcitecture tests for CPS (REST and service and RI)

  - added Base class and extracted common method for 3pp checks
  - added ArchTests for cps REST and cps service

Issue-ID: CPS-2423
Change-Id: Icf70b79d1397b002d75ec5c8761775dfd7a6c6d9
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
5 months agoAdd multi-threaded Integration Test for Module Sync 27/139227/6
ToineSiebelink [Thu, 17 Oct 2024 13:08:58 +0000 (14:08 +0100)]
Add multi-threaded Integration Test for Module Sync

- Add tests for multi threaded scenarios around module sync
- Disabled ModuleSyncWatchdog timer using long delay and interval
- Call Module Sync method as needed for more control
  (sometimes it needs to be triggered twice like retry use cases as designed)
- Improve NCMP performance test setup (consistent naming etc.)
- Rename some production code method names to better reflect functionality
- Disabled intermittent failing test for create cm handle as it is not asserting the correct message
- Improved Code Coverage ModuleSyncWatchdog

Issue-ID: CPS-2462
Change-Id: Ia907af77d2037309f1bbb73ea671679b788bab9e
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
5 months agoRefactor: Improve code quality and compliance with SonarQube standards 57/139257/2
sourabh_sourabh [Wed, 23 Oct 2024 14:12:41 +0000 (15:12 +0100)]
Refactor: Improve code quality and compliance with SonarQube standards

- Consolidated multiple `if` statements to enhance readability and maintainability.
- Replaced traditional `instanceof` checks followed by casting with the new pattern matching syntax for improved type safety and clarity.
- Removed unnecessary casts and streamlined code in `addYangLeafList` and `addDataNodeFromNormalizedNode` methods.

Issue-ID: CPS-1957
Change-Id: I46696dc184b6b3c3d0fe3a6bd12267a4e0d76193
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
5 months agoUpdate deployment docs for load balancer config 56/139256/2
danielhanrahan [Wed, 23 Oct 2024 08:04:58 +0000 (09:04 +0100)]
Update deployment docs for load balancer config

Issue-ID: CPS-2415
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I27be67ec9e71e4c6006ef80aa78152f9d1784958

5 months agoAdd metadata related to builds and commits 07/139207/7
mpriyank [Wed, 16 Oct 2024 10:59:49 +0000 (11:59 +0100)]
Add metadata related to builds and commits

- removing the build-info goal from the existing spring-boot-maven-plugin
- adding git-commit-id-maven-plugin to expose the git related info using
  actuator/info endpoint
- adding the dateFormat to git plugin to make it same as the build-info
- cleaning up a duplicate dependency in cps-ncmp-rest-stub module

Issue-ID: CPS-2445
Change-Id: Id7179a81361718d293b7b31f50c1adbdd2ad4302
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 months agoResize cps expectation 59/139259/1
halil.cakal [Wed, 23 Oct 2024 14:51:56 +0000 (15:51 +0100)]
Resize cps expectation

- set expectation to 70 (cmhanldes/second) for discovery case

Issue-ID: CPS-2350

Change-Id: I3d0f9f5e20de87f79ebbe569c7905f4eefed35e8
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 months agoMerge "Enable 2 minute initial module processing delay"
Toine Siebelink [Mon, 21 Oct 2024 10:40:18 +0000 (10:40 +0000)]
Merge "Enable 2 minute initial module processing delay"

5 months agoEnable 2 minute initial module processing delay 30/139230/1
danielhanrahan [Fri, 18 Oct 2024 11:38:12 +0000 (12:38 +0100)]
Enable 2 minute initial module processing delay

Issue-ID: CPS-2403
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I614313461bd36ca351a8d42d9683b88460090b50

5 months agoUpdate SpotBugs dependency 29/139229/1
danielhanrahan [Fri, 18 Oct 2024 10:19:04 +0000 (11:19 +0100)]
Update SpotBugs dependency

- update spotbugs to 4.8.6
- remove old findbugs dependency (spotbugs replaces findbugs)
- remove an unused SupressFBWarnings

Issue-ID: CPS-2458
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: If9d5571ae4293a2653a117a988414af2452647c0

5 months agoRelease Stage 7 for 3.5.4 26/139226/5
seanbeirne [Thu, 17 Oct 2024 15:49:30 +0000 (16:49 +0100)]
Release Stage 7 for 3.5.4

Issue-ID: CPS-2457
Change-Id: Id9a267c587f16f3fb5edb558b33cd0003864ed93
Signed-off-by: seanbeirne <sean.beirne@est.tech>
5 months agoRelease Stage 6 for 3.5.4 24/139224/2
seanbeirne [Thu, 17 Oct 2024 15:37:00 +0000 (16:37 +0100)]
Release Stage 6 for 3.5.4

Issue-ID: CPS-2457
Change-Id: I9aa7265d8179c55a71a7722e3ef42c44b0f8dbfe
Signed-off-by: seanbeirne <sean.beirne@est.tech>
5 months agoRelease Stage 5 for 3.5.4 23/139223/2
seanbeirne [Thu, 17 Oct 2024 15:30:38 +0000 (16:30 +0100)]
Release Stage 5 for 3.5.4

Issue-ID: CPS-2457
Change-Id: I8bc9b2588539b64a6c8de936b6df97111665f1ed
Signed-off-by: seanbeirne <sean.beirne@est.tech>
5 months agoRelease notes and documentation updates for 3.5.4 22/139222/2
danielhanrahan [Thu, 17 Oct 2024 13:55:49 +0000 (14:55 +0100)]
Release notes and documentation updates for 3.5.4

- Release notes update
- Update openapi info.version to 3.5.4
- Update scheduled-tasks docs to reflect changes in retry mechanism
- Update deployment docs to update configurable timer parameters
- Remove unused locked-module-sync.sleep-time-ms

Issue-ID: CPS-2457
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ieb559bbfe348848c4b8669410861edfeeb6c9bf3

5 months agoRefactor and Optimize ModuleSyncWatchdog for Improved Lock Handling and Queue Management 08/139208/4
sourabh_sourabh [Thu, 17 Oct 2024 07:22:56 +0000 (08:22 +0100)]
Refactor and Optimize ModuleSyncWatchdog for Improved Lock Handling and Queue Management

- Enhanced logging for populateWorkQueueIfNeeded and resetPreviouslyLockedCmHandles
methods, improving clarity and error handling.
- Improved readability and maintainability of the locking mechanism with
  Hazelcast's FencedLock.
- Optimized error handling in catch blocks, logging detailed exception messages and stack
traces for better troubleshooting.
- Refined lock acquisition and release flow, with clear log messages for both successful
and failed lock operations, ensuring safe handling of Hazelcast distributed locks.

Issue-ID: CPS-2403
Change-Id: Ie089f36a817d4965782235b51ee987ef054516b1
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
5 months agoMerge "Update documentation related to hazelcast"
Toine Siebelink [Wed, 16 Oct 2024 16:07:56 +0000 (16:07 +0000)]
Merge "Update documentation related to hazelcast"

5 months agoUpdate documentation related to hazelcast 95/139195/3
mpriyank [Mon, 14 Oct 2024 12:44:31 +0000 (13:44 +0100)]
Update documentation related to hazelcast

- removed old entries of data structures which are removed now.
- updated the documentation to correctly reflect our infrastructure
  startegy related to hazelcast.
- fixed few NB comments on the merged patch.

Issue-ID: CPS-2408
Change-Id: Id7ce4ac695ad94742490ac5d2be89cd23ffda3e5
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 months agoMerge "Add missing duplication test in integration test suite"
Sourabh Sourabh [Wed, 16 Oct 2024 12:33:02 +0000 (12:33 +0000)]
Merge "Add missing duplication test in integration test suite"

5 months agoMerge "Added additional logging"
Daniel Hanrahan [Wed, 16 Oct 2024 09:21:31 +0000 (09:21 +0000)]
Merge "Added additional logging"

5 months agoAdd missing duplication test in integration test suite 03/139203/1
ToineSiebelink [Tue, 15 Oct 2024 17:01:30 +0000 (18:01 +0100)]
Add missing duplication test in integration test suite

- Added test for  ModuleSerive.createSchemaSetFromModules()
- Unintendedly Updated one swagger file in docs because
1) DT team forgot to update the relevant file
2) Gers committed pom update to automatically update swagger files
3) I ran 'mvn install'

Issue-ID: CPS-2399
Change-Id: I33261c32bbca58ff21aff3cde9588617199f104c
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
5 months agoAdded additional logging 00/139200/5
sourabh_sourabh [Tue, 15 Oct 2024 11:11:16 +0000 (12:11 +0100)]
Added additional logging

- Added logging for non existing xpath while updating data notes and its
  decendants.

Issue-ID: CPS-2403
Change-Id: I1ecaf2aed77aec8d266f6a758fe80ee96717d9c7
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
5 months agoMerge "add documentaiton for cps-and-ncmp deployment"
Priyank Maheshwari [Tue, 15 Oct 2024 10:20:31 +0000 (10:20 +0000)]
Merge "add documentaiton for cps-and-ncmp deployment"

5 months agoadd documentaiton for cps-and-ncmp deployment 81/139181/5
halil.cakal [Wed, 9 Oct 2024 16:33:19 +0000 (17:33 +0100)]
add documentaiton for cps-and-ncmp deployment

- the optimum percentage of the JVM allocation documented
- remove anchorDataCache from the documentation
  since no more used

Issue-ID: CPS-2180

Change-Id: Ie1b8c43136a38f8da5a865493bed1df030a497d6
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 months agoMerge "Copy Swagger file to docs folder"
Toine Siebelink [Mon, 14 Oct 2024 12:13:35 +0000 (12:13 +0000)]
Merge "Copy Swagger file to docs folder"

5 months agoMerge "use one hazelcast instance per jvm"
Lee Anjella Macabuhay [Thu, 10 Oct 2024 12:51:40 +0000 (12:51 +0000)]
Merge "use one hazelcast instance per jvm"

5 months agouse one hazelcast instance per jvm 30/139130/5
mpriyank [Tue, 10 Sep 2024 15:12:28 +0000 (16:12 +0100)]
use one hazelcast instance per jvm

- updated all the cache(distributed datastructures) to use the same instance config now.
- there will be just one instance per JVM now
- Better cleanup of hz instance in the testware
- Refactored the testware to verify the configs
- Expected Impact on lowering the memory usage, less number of TCP
  communications between members
- NOTE: we need to do a full regression as the changes impacts all the
  use cases which involves cache

Issue-ID: CPS-2408
Change-Id: I7564992a9990f44ef3defb4f50cb7d094cad7b92
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 months agoCopy Swagger file to docs folder 82/139182/1
egernug [Thu, 10 Oct 2024 09:11:27 +0000 (10:11 +0100)]
Copy Swagger file to docs folder

To avoid manual copy/paste errors updates to docs folder for RTD are generated and copied when compiling CPS

Issue-ID: CPS-2332

Change-Id: I1a64f7cc74a82341403f8125adc5216ef046429c
Signed-off-by: egernug <gerard.nugent@est.tech>
5 months agoMerge "Autodiscover cps-and-ncmp containers when load balancing"
Daniel Hanrahan [Thu, 10 Oct 2024 09:53:47 +0000 (09:53 +0000)]
Merge "Autodiscover cps-and-ncmp containers when load balancing"

5 months agoMerge "Added architecture tests to validate ONLY NCMP REST/Service dependencies"
Sourabh Sourabh [Wed, 9 Oct 2024 15:09:11 +0000 (15:09 +0000)]
Merge "Added architecture tests to validate ONLY NCMP REST/Service dependencies"

5 months agoAdded architecture tests to validate ONLY NCMP REST/Service dependencies 03/139003/17
leventecsanyi [Mon, 23 Sep 2024 14:01:03 +0000 (16:01 +0200)]
Added architecture tests to validate ONLY NCMP REST/Service dependencies

  - removed old tests and added new test cases for the NCMP controller and service layers
  - other dependencies will be added in later commits

Issue-ID: CPS-2422
Change-Id: Iabc4b53e9414477cf3d0b2e1e5a03ba8b4995169
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
5 months agoMerge "Added K6 script test to check a throughput of CPS kafka consumer"
Daniel Hanrahan [Wed, 9 Oct 2024 11:22:46 +0000 (11:22 +0000)]
Merge "Added K6 script test to check a throughput of CPS kafka consumer"

5 months agoMerge "Implementation of Data validation feature in Create a Node API"
Toine Siebelink [Wed, 9 Oct 2024 09:37:42 +0000 (09:37 +0000)]
Merge "Implementation of Data validation feature in Create a Node API"

5 months agoAutodiscover cps-and-ncmp containers when load balancing 72/139172/4
halil.cakal [Mon, 7 Oct 2024 15:48:05 +0000 (16:48 +0100)]
Autodiscover cps-and-ncmp containers when load balancing

- remove hard-coded container names from load balancer(nginx) and
  prometheus

Issue-ID: CPS-2437

Change-Id: Ia64b949c2eb3e4d67e123b046e66d5bfdda2c801
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 months agoFine tune JVM parameters for cps-and-ncmp 97/138997/6
halil.cakal [Mon, 23 Sep 2024 10:05:16 +0000 (11:05 +0100)]
Fine tune JVM parameters for cps-and-ncmp

- limit the total memory with 2G
- set heap memory 75% of the total RAM

Issue-ID: CPS-2180

Change-Id: Ia8a6c2bd40866052caba4f332ac563e1ed829212
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 months agoImplementation of Data validation feature in Create a Node API 76/138676/28
Arpit Singh [Fri, 9 Aug 2024 06:53:49 +0000 (12:23 +0530)]
Implementation of Data validation feature in Create a Node API

Added support to validate JSON/XML data without the need of persisting
it in the databse.
 - added "dryRunInQuery" flag as a new query parameter
 - added new method as part of CpsDataService layer to perform data
   validation
 - added new method in yang parser "validateData" to validate
   data without persisting it

Issue-ID: CPS-2361
Change-Id: I43dd33cc6120576d0fac606d5c4b0168d107311d
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
5 months agoMerge "Policy Executor: handle errors, part 2 (fighting between IntelliJ and Checksty...
Sourabh Sourabh [Tue, 8 Oct 2024 15:51:01 +0000 (15:51 +0000)]
Merge "Policy Executor: handle errors, part 2 (fighting between IntelliJ and Checkstyle best practices)"

5 months agoMerge "Re-adjust cps expectations"
Lee Anjella Macabuhay [Mon, 7 Oct 2024 14:08:34 +0000 (14:08 +0000)]
Merge "Re-adjust cps expectations"

5 months agoMerge "RTD update for delta API 2"
Priyank Maheshwari [Mon, 7 Oct 2024 08:42:08 +0000 (08:42 +0000)]
Merge "RTD update for delta API 2"

6 months agoBump CPS to 3.5.4-SNAPSHOT 22/139122/1
mpriyank [Fri, 4 Oct 2024 15:59:40 +0000 (16:59 +0100)]
Bump CPS to 3.5.4-SNAPSHOT

- bump cps to 3.5.4-SNAPSHOT
- updated release notes

Issue-ID: CPS-2434
Change-Id: I3d5e6f37711bb29b61b598cc5af57ecfdc35cbba
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 months ago[CPS] Step-3: OSLO release changes 21/139121/1
sourabh_sourabh [Fri, 4 Oct 2024 15:23:06 +0000 (16:23 +0100)]
[CPS] Step-3: OSLO release changes

- cps maven stage docker yaml is created for release 3.5.3

Issue-ID:CPS-2434

Change-Id: I4048b9f54b9c0b0eb433fef9d9c403d54c39bc35
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
6 months ago[CPS] Step-2: OSLO release changes 20/139120/2
sourabh_sourabh [Fri, 4 Oct 2024 15:09:08 +0000 (16:09 +0100)]
[CPS] Step-2: OSLO release changes

- cps maven stage master yaml is created for release 3.5.3

Issue-ID:CPS-2434
Change-Id: I5353eb64252b3e071b5203d931f0f646ef290c13
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
6 months ago[CPS] OSLO release changes 18/139118/3
sourabh_sourabh [Fri, 4 Oct 2024 13:35:32 +0000 (14:35 +0100)]
[CPS] OSLO release changes

- Updated open api for cps, ncmp and policy apis.
- Updated release notes with bus and features.

Issue-ID: CPS-2434
Change-Id: Ib4d80f3939b6e267f228177c817e43832a9384db
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
6 months agoMerge "[BUG] Fix memory leak related to using arrays in Hibernate"
Lee Anjella Macabuhay [Fri, 4 Oct 2024 12:11:17 +0000 (12:11 +0000)]
Merge "[BUG] Fix memory leak related to using arrays in Hibernate"

6 months agoRevert "[1/2] Move Swagger API to docs folder" 35/139135/2
Lee Anjella Macabuhay [Thu, 3 Oct 2024 13:47:14 +0000 (13:47 +0000)]
Revert "[1/2] Move Swagger API to docs folder"

This reverts commit b76392e2d1629d4eb67b10c450cdd954ef678966.

Reason for revert: Release blocker

Change-Id: Ic477dbaaad34992c8f440981d92f12b977cdf96e
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
6 months agoRTD update for delta API 2 65/137565/25
Arpit Singh [Mon, 6 May 2024 14:42:52 +0000 (20:12 +0530)]
RTD update for delta API 2

 - Documentation update for Delta Feature and Delta API 1
 - Added documentation for API 2: Delta between anchor
   and JSON payload

Issue-ID: CPS-2212
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Id74cd930ce48e5cb414aa62c5381b79675346a37

6 months ago[BUG] Fix memory leak related to using arrays in Hibernate 13/139113/5
danielhanrahan [Wed, 2 Oct 2024 20:31:04 +0000 (21:31 +0100)]
[BUG] Fix memory leak related to using arrays in Hibernate

The use of arrays like String[] instead of Collection<String> in
JpaRepository methods is causing a memory leak, most likely due to a
bug in the hypersistence-utils dependency which provides the feature.
Note code using arrays in JDBC (via jdbcTemplate) is not affected.

This patch removes most uses of arrays in Java, except one needed for
FragmentPrefetchRepository using JDBC setArray(), which is safe.

Issue-ID: CPS-2430
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I94f8c3d4c8c32ebe0978c08d3226a196a95bf3b9

6 months agoRevert "Fix inputSpec for openapi code gen" 34/139134/3
Lee Anjella Macabuhay [Thu, 3 Oct 2024 13:46:59 +0000 (13:46 +0000)]
Revert "Fix inputSpec for openapi code gen"

This reverts commit 4baa75b06dcfb9365a8ea5cde03d77d7f21fa01c.

Reason for revert: Release blocker

Change-Id: I6156461de64dcec41e3f84cbd0cf90f63938bea6
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
6 months agoRevert "CI: Add test (silent) checkov scan as part of the verify process" 16/139116/1
Jessica Wagantall [Thu, 3 Oct 2024 16:08:35 +0000 (09:08 -0700)]
Revert "CI: Add test (silent) checkov scan as part of the verify process"

This reverts commit c8e2b3383830395bb4bc37371a9c6119a316cb53.

Issue-ID: CIMAN-33
Change-Id: I5120097ad05394e3667a868c4b7edd44ef1aa070
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 months agoPolicy Executor: handle errors, part 2 34/139034/10
ToineSiebelink [Tue, 1 Oct 2024 17:40:39 +0000 (18:40 +0100)]
Policy Executor: handle errors, part 2
(fighting between IntelliJ and Checkstyle best practices)

- non-2xx responses are processed using web client exceptions
- handle unknown host exception
- upgraded spotbugs (checkstyle and related mvn plugin)
- fixed some small spotbugs due to upgrade
- added commented instructions in docker compose to enable debugging
- added some environment variables for policy executor configuration
- extract out Sleeper in stub service to achieve 100% coverage
- added cause to Policy Executor exceptions where applicable
- ignored (new) spotbug rule about catch NPE because of issue in 3pp
- ignored (new) spotbug rule about \n in string due to multiline string block

Issue-ID: CPS-2412
Change-Id: I6835a73320c436cbeea12cc7a06f15899eec7bf1
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
6 months agoAdded K6 script test to check a throughput of CPS kafka consumer 40/139040/4
sourabh_sourabh [Mon, 30 Sep 2024 10:13:30 +0000 (11:13 +0100)]
Added K6 script test to check a throughput of CPS kafka consumer

- Added new K6 script to produce cm avc enents. (It is not a part
  regular automated tests)
- Added a json resource (avc event)

Issue-ID: CPS-2329
Change-Id: I6446bc120382257c5039df17fd34b84b7c6f6550
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
6 months agoRe-adjust cps expectations 38/139038/3
halil.cakal [Fri, 27 Sep 2024 13:43:00 +0000 (14:43 +0100)]
Re-adjust cps expectations

- aligning cps expectation for new plots

Issue-ID: CPS-2350

Change-Id: I5b300c4f5432bf2bdfe8a8b0d52b2ce60bd338d6
Signed-off-by: halil.cakal <halil.cakal@est.tech>
6 months agoUpdate JIRA and Wiki links host name from wiki.onap.org to lf-onap.atlassian.net 95/139095/10
sourabh_sourabh [Wed, 2 Oct 2024 15:37:47 +0000 (16:37 +0100)]
Update JIRA and Wiki links host name from wiki.onap.org to lf-onap.atlassian.net

Issue-ID: CPS-2432
Change-Id: I53f380a4fe0968d1ec9f1393651c7c43f03d0d95
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
6 months agoMerge "BugFix: 500 Server error when upgrade and service restart with data in DB"
Sourabh Sourabh [Mon, 30 Sep 2024 11:10:19 +0000 (11:10 +0000)]
Merge "BugFix: 500 Server error when upgrade and service restart with data in DB"