Parshad Patel [Fri, 8 Mar 2019 08:09:57 +0000 (17:09 +0900)]
Increase test coverage for plugins-event-carrier
Add basic JUnit test cases for plugins-event-carrier-restserver
Issue-ID: POLICY-1513
Change-Id: I36e41bd05be71c44eb9e94350f4614437b0d205b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Liam Fallon [Wed, 6 Mar 2019 13:58:47 +0000 (13:58 +0000)]
Merge "Increase test coverage for plugins-event"
Parshad Patel [Wed, 27 Feb 2019 01:37:57 +0000 (10:37 +0900)]
Increase test coverage for plugins-event
Add JUnit test cases for plugins-event-carrier-websocket
Issue-ID: POLICY-1513
Change-Id: I5f2a8dacfff4c14cf4a24e9258b5a551cecc1489
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Pamela Dragosh [Fri, 1 Mar 2019 13:13:00 +0000 (13:13 +0000)]
Merge "Increase test coverage for plugins-executor-mvel"
Pamela Dragosh [Fri, 1 Mar 2019 13:12:11 +0000 (13:12 +0000)]
Merge "Increase test coverage for plugins-executor-jruby"
Pamela Dragosh [Fri, 1 Mar 2019 12:56:58 +0000 (12:56 +0000)]
Merge "Use Alpine as base docker image"
Pamela Dragosh [Thu, 28 Feb 2019 19:27:27 +0000 (19:27 +0000)]
Merge "Increase test coverage for plugins-executor-jython"
Jorge Hernandez [Thu, 28 Feb 2019 17:49:41 +0000 (17:49 +0000)]
Merge "Fix checkstyle problems on sonar fix"
Liam Fallon [Thu, 28 Feb 2019 17:09:18 +0000 (17:09 +0000)]
Merge "Update INFO.yaml Liam's email"
Pamela Dragosh [Thu, 28 Feb 2019 15:31:19 +0000 (10:31 -0500)]
Update INFO.yaml Liam's email
est.tech
Issue-ID: POLICY-1556
Change-Id: I1088e64016a15161ec979bf8de1af35835fa3c83
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Tue, 26 Feb 2019 14:39:32 +0000 (14:39 +0000)]
Fix checkstyle problems on sonar fix
A sonar fix brought in some minor checkstyle issues. This
review fixes those.
Issue-ID: POLICY-1535
Change-Id: I4f9d66ffc0a4fcc8901d7e18bfb21a1d1cf135b7
Signed-off-by: liamfallon <liam.fallon@est.tech>
Hengye [Thu, 28 Feb 2019 08:03:50 +0000 (08:03 +0000)]
Use Alpine as base docker image
change docker base image from ubuntu 16.04 to Alpine 3.9
Issue-ID: POLICY-1555
Change-Id: Ia21f5e8185bd26f4b04276eed204ac358f655a59
Signed-off-by: Hengye <yehui.wang@est.tech>
ning.xi [Thu, 28 Feb 2019 03:01:19 +0000 (03:01 +0000)]
Increase test coverage for plugins-executor-jython
Add junit test cases into apex-pdp/plugins/plugins-executor-jython
Issue-ID: POLICY-1523
Change-Id: I2545a9cefc6b4b9a53200b98081ddd8bc8274b40
Signed-off-by: ning.xi <ning.xi@est.tech>
shaoqiu [Thu, 28 Feb 2019 02:56:02 +0000 (02:56 +0000)]
Increase test coverage for plugins-executor-jruby
Add junit test cases into apex-pdp/plugins/plugins-executor-jruby
Issue-ID: POLICY-1523
Change-Id: I2ed06a69cf991d744aa5c4c69f605fdf1dca6524
Signed-off-by: shaoqiu <tim.huang@est.tech>
Hengye [Thu, 28 Feb 2019 02:32:56 +0000 (02:32 +0000)]
Increase test coverage for plugins-executor-mvel
Add junit test cases into apex-pdp/plugins/plugins-executor-mvel
Issue-ID: POLICY-1523
Change-Id: I74d47974a326c7fbd53a0b7d88262ef1dbd54c8c
Signed-off-by: Hengye <yehui.wang@est.tech>
Jorge Hernandez [Wed, 27 Feb 2019 14:55:59 +0000 (14:55 +0000)]
Merge "Fix sonar code smell"
Jorge Hernandez [Tue, 26 Feb 2019 19:20:22 +0000 (19:20 +0000)]
Merge "Increase test coverage for plugins-event"
Parshad Patel [Tue, 26 Feb 2019 02:06:52 +0000 (11:06 +0900)]
Increase test coverage for plugins-event
Add basic JUnit test cases for plugins-event-carrier-jms
Issue-ID: POLICY-1513
Change-Id: I68fa36bc988745108014f47a57fc02bc2ceed0c7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Pamela Dragosh [Mon, 25 Feb 2019 20:03:28 +0000 (20:03 +0000)]
Merge "sonar:reduce number of method param"
Arindam Mondal [Wed, 20 Feb 2019 07:28:26 +0000 (16:28 +0900)]
sonar:reduce number of method param
Changes done according to sonar recommendation.
Issue-ID: POLICY-1535
Change-Id: I57a608e4db1b67959cbabe23e7fe0b1aa91e30cd
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
liamfallon [Sat, 23 Feb 2019 20:01:28 +0000 (20:01 +0000)]
Fix checkstyle errors on tests
Issue-ID: POLICY-1513
Change-Id: Id61df043adf398a0493916f6116ff5858c60fb29
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 22 Feb 2019 17:30:59 +0000 (17:30 +0000)]
Change versions of Zookeeper and C3P0
This review changes the versions of Zookeeper and C3P0 to
resolve security issues.
It also merges the context test utils module into the context test because that
module was misplaced and put an incompatible Zookeeper dependency in the
APEX context module.
Issue-ID: POLICY-1540
Change-Id: I86048ae1fc8b818611f423d6fd1f4a9fcc3f76f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
Hengye [Thu, 21 Feb 2019 09:24:25 +0000 (09:24 +0000)]
correct a typo in doc APEX User Manual
Issue-ID: POLICY-1523
Change-Id: I44675a5119170ab724926ba08a3bfceefda31b57
Signed-off-by: Hengye <yehui.wang@est.tech>
Parshad Patel [Wed, 20 Feb 2019 02:38:16 +0000 (11:38 +0900)]
Increase test coverage for apex-pdp/plugins
Add basic JUnit test cases for plugins-event-carrier-kafka
Issue-ID: POLICY-1513
Change-Id: I009547115705496a850a9609416cdf71f52fb936
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Arindam Mondal [Mon, 18 Feb 2019 09:27:51 +0000 (18:27 +0900)]
Fix sonar code smell
Issue-ID: POLICY-1523
Change-Id: I24f9fe5811bb93597efe79c98572c5249e74026c
Signed-off-by: arindamm <arind.mondal@samsung.com>
liamfallon [Tue, 5 Feb 2019 17:37:24 +0000 (17:37 +0000)]
Fix bug with Apex rejecting HTTP 2xx responses
APEX rejects all HTTP responses except 200. This change accepts
any HTTP 2xx response code as a valid response.
Issue-ID: POLICY-1289
Change-Id: Ief681ba4dac1ef3ff5f257dd931569bd2274d017
Signed-off-by: liamfallon <liam.fallon@est.tech>
ramverma [Fri, 18 Jan 2019 15:17:12 +0000 (15:17 +0000)]
Fix version warning in apex pom
Change-Id: Ia3b7fa204fb8564b679a4416fcc0f70fa0a9a54f
Issue-ID: POLICY-1074
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
liamfallon [Tue, 15 Jan 2019 15:54:45 +0000 (15:54 +0000)]
Fix crashing unit tests in Apex
Issue-ID: POLICY-1403
Change-Id: Ie9d2cc46f3daf4d6b2eb2774a8be8c35e0c45754
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 15 Jan 2019 10:59:15 +0000 (10:59 +0000)]
Update comment to check Sonar build issue
Issue-ID: POLICY-1403
Change-Id: I87ebf85dbbe8544e38666e8e793a8e1cbbcfc7c6
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 11 Jan 2019 10:51:50 +0000 (10:51 +0000)]
Use parent version of Eclipselink
Issue-ID: POLICY-1360
Change-Id: I33d8cef3f5d273c0c2a93ecda321205316aea6de
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 9 Jan 2019 13:30:23 +0000 (14:30 +0100)]
Fix context clearing on model upgrade
Existing context is cleared when a model upgrade is carried out
on an Apex PDP. The clear() method is called in error on the
Apex engine during the upgrade.
This change also has some small updates to the DecisionMaker example,
which is used to test this feature.
Issue-ID: POLICY-1395
Change-Id: I547a3a60712d1572d9daadf5eab4afcae2a5c321
Signed-off-by: liamfallon <liam.fallon@est.tech>
Parshad Patel [Wed, 26 Dec 2018 05:54:59 +0000 (14:54 +0900)]
Rename test classes in apex-pdp/services
Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I951f4e30736144010d69a0fb3b9181f7fee76013
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Liam Fallon [Fri, 21 Dec 2018 17:26:57 +0000 (17:26 +0000)]
Merge "Rename test classes in apex-pdp/model,core"
Parshad Patel [Fri, 21 Dec 2018 06:36:35 +0000 (15:36 +0900)]
Rename test classes in apex-pdp/model,core
Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I6cb8d09799d7abd1b50ead1edbc4986649ad4ba7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Thu, 20 Dec 2018 14:27:09 +0000 (14:27 +0000)]
Merge "Add SSL keystore/truststore to Apex package"
liamfallon [Wed, 19 Dec 2018 18:29:05 +0000 (18:29 +0000)]
Add SSL keystore/truststore to Apex package
Issue-ID: POLICY-1222
Change-Id: I4409b88d1a9439492f9aac6c3b971bae7dc04b19
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 19 Dec 2018 17:48:47 +0000 (17:48 +0000)]
Add example policy for HTTPS
Added an example of how to configure HTTPS for an Apex policy.
Issue-ID: POLICY-1222
Change-Id: Iea8a8accac32f6d25c64a8324e202ad5e6221c7a
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Wed, 19 Dec 2018 14:13:57 +0000 (14:13 +0000)]
Merge "Add Java property parameters for HTTPS"
liamfallon [Tue, 18 Dec 2018 17:18:45 +0000 (17:18 +0000)]
Add Java property parameters for HTTPS
Issue-ID: POLICY-1222
Change-Id: I4a683cf2f52e7f1d28164954f84d0744b5ca7e9c
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 18 Dec 2018 11:40:39 +0000 (11:40 +0000)]
Remove unused @throws warnings
Previous checkstyle fixes rationalised the
exceptions thrown by methods, however the javadoc
comments were not updated. This review updates them.
Issue-ID: POLICY-1263
Change-Id: I2746f30e76018ec4d0f1e74a6a415979b7874329
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sat, 15 Dec 2018 09:47:58 +0000 (09:47 +0000)]
Fix sonar test renaming issues
Renaming tests introduced Sonar issues:
- Tests where coverage was <80% flagged as they are new code
- Support test classes with names ending in "Test" flagged
becasue they did not contain test cases
Issue-ID: POLICY-1263
Change-Id: I17a4b27b2952a4978fab1c76579a013478b60ae1
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 11 Dec 2018 20:58:57 +0000 (20:58 +0000)]
Add period after inheritDoc
Issue-ID: POLICY-1074
Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Tue, 11 Dec 2018 15:50:07 +0000 (15:50 +0000)]
Merge "Remove unused parameter from test data"
liamfallon [Sat, 8 Dec 2018 11:31:30 +0000 (11:31 +0000)]
Remove unused parameter from test data
The "restRequestTimeout" parameter is not used in the current
version of Apex, it was replaced by the "requestorTimeout" paramter.
However, the parameter remained in the JSON data files.
Also updated to improve output of messages during unit test.
This review also sets the Jersey injection dependendy scope to "test"
Issue-ID: POLICY-1074
Change-Id: I75f495f571c8101310bd1eaec01a305318346cd9
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Tue, 11 Dec 2018 00:32:30 +0000 (00:32 +0000)]
Merge "Support HTTP headers in REST Client"
liamfallon [Fri, 7 Dec 2018 22:28:49 +0000 (22:28 +0000)]
Fix checkstyle issues
Some minor line length and formatting checkstyle warnings fixed.
Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sat, 8 Dec 2018 11:27:17 +0000 (11:27 +0000)]
Support HTTP headers in REST Client
Fixed REST client plugin to supprot HTTP headers and add unit
test to plugin.
Change-Id: I6a71ab7f83ed2126b8600bb5e586f971dbdacdc0
Issue-ID: POLICY-1222
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Thu, 6 Dec 2018 16:33:15 +0000 (16:33 +0000)]
Merge "Fix bugs in context flushing"
Jorge Hernandez [Thu, 6 Dec 2018 14:42:18 +0000 (14:42 +0000)]
Merge "Support HTTP headers in REST Requestor"
liamfallon [Wed, 5 Dec 2018 17:38:40 +0000 (17:38 +0000)]
Fix bugs in context flushing
The context flushing support in the context distributor can throw a
concurrent exception when a lot of context is active and a flush takes
place. This fix introduces proper synchronized access to the album maps.
In addition, there was an incorrect cast in the call to the persist() method
of the persistor.
Change-Id: I6594ffed83a0b34251a0c5c7893d4abb17437fd4
Issue-ID: POLICY-1380
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 4 Dec 2018 22:36:39 +0000 (22:36 +0000)]
Support HTTP headers in REST Requestor
Change-Id: Iea4211e7d3324f5ea6244f45c91241a4067d8d33
Issue-ID: POLICY-1222
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Mon, 3 Dec 2018 22:48:10 +0000 (22:48 +0000)]
Add unit test for Java executor
Code coverage in the Apex-PDP plugins is very low. JUnit coverage will be
increased for the Plugins over the Dublin design timeline.
Issue-ID: POLICY-1379
Change-Id: Ie70ab5a9be650818cb330ec5be2a89a5db6153c5
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Mon, 3 Dec 2018 19:41:57 +0000 (19:41 +0000)]
Merge "Fix checkstyle/sonar issues"
Pamela Dragosh [Mon, 3 Dec 2018 15:25:38 +0000 (15:25 +0000)]
Merge "Rename test classes in apex-pdp"
liamfallon [Mon, 3 Dec 2018 14:35:21 +0000 (14:35 +0000)]
Fix checkstyle/sonar issues
Remove unused imports
Add @FunctionalInterface annotation
Reduce the complexity of some methods
Change-Id: If519c31b113233361fbb935121fe6494263ac957
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sun, 2 Dec 2018 19:35:23 +0000 (19:35 +0000)]
Use Parent Eclipselink
Issue-ID: POLICY-1360
Change-Id: I99a9e7bf60590fd0da5d7ba001e8ab322623fee6
Signed-off-by: liamfallon <liam.fallon@est.tech>
Parshad Patel [Fri, 30 Nov 2018 11:15:11 +0000 (20:15 +0900)]
Rename test classes in apex-pdp
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Thu, 29 Nov 2018 15:56:19 +0000 (15:56 +0000)]
Merge "Fixing issues in apex documents"
ramverma [Thu, 29 Nov 2018 13:47:30 +0000 (13:47 +0000)]
Fixing issues in apex documents
Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83
Issue-ID: POLICY-1280
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Pamela Dragosh [Thu, 29 Nov 2018 14:16:14 +0000 (14:16 +0000)]
Merge "Rename test classes in apex-pdp/model/basic-model"
Parshad Patel [Wed, 28 Nov 2018 07:53:33 +0000 (16:53 +0900)]
Rename test classes in apex-pdp/model/basic-model
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: Ia90e0ea73af16f6cde37692e98f1c4afc408dd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Mon, 26 Nov 2018 17:15:31 +0000 (17:15 +0000)]
Merge "Fix sonar issue cli codegen"
Krishnakumar Jinka [Sat, 24 Nov 2018 17:53:57 +0000 (02:53 +0900)]
Fix sonar issue cli codegen
Modify CodeGeneratorCliEditor to use param object for sonar issue fix
Add javadoc for the method addEventDecl Method. Modify meth
declaration. Run formatter
Issue-ID: POLICY-1251
Change-Id: I4f95e868c047f54dff9cf991e8f4f60e8954c788
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
Pamela Dragosh [Fri, 23 Nov 2018 19:46:05 +0000 (14:46 -0500)]
Create label for architecture to ref
Creating a label so other documentation in the architecture
section can reference this PDP engine documentation.
Issue-ID: POLICY-1163
Change-Id: Ida9caba405e36675f65843b1d49e79175634fa02
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Tue, 20 Nov 2018 15:59:50 +0000 (15:59 +0000)]
Refactor Apex benchmark tests
Apex performance tests are refactored and reorganised
to be all in the one place and to be coherent.
A test REST server that can generate events in batches
is introduced and this can be configured to respond to REST
calls from Apex with various batch sizes that can be varied
for performance tests.
Actual performance tests are added for the various executors
in Apex.
Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08
Issue-ID: POLICY-812
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Parshad Patel [Tue, 20 Nov 2018 05:46:45 +0000 (14:46 +0900)]
Rename test classes in apex-pdp
Make test classes name consistence under auth, model, plugins, testsuits, tools projects
Issue-ID: POLICY-1263
Change-Id: I49ec9a9f5b457d6381e693de2c04ec0268ad1b02
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Parshad Patel [Fri, 16 Nov 2018 11:59:14 +0000 (20:59 +0900)]
Rename test classes in apex-pdp
Make test classes name consistence by putting 'Test' at end
Issue-ID: POLICY-1263
Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
liamfallon [Thu, 15 Nov 2018 22:07:45 +0000 (22:07 +0000)]
Fix timing and move tests
The timings on the REST test are too short and time out on ONAP Jenkins
The tests of the Apex service and Apex model upgrade are not
benchmark tests so are moved to Integration.
Issue-ID: POLICY-1251
Change-Id: I2672d01042b33fe0cce5223005295e3b1aa26e7a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 15 Nov 2018 15:43:17 +0000 (15:43 +0000)]
Fix checkstyle warnings in AxState/Codegen
Recent checkins introduced some very minor checkstyle warnings, this
review fixes those.
Change-Id: Ie7784ad22a748017e1647be0e23dc9d3fe100cf0
Issue-ID: POLICY-1251
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Thu, 15 Nov 2018 14:36:02 +0000 (14:36 +0000)]
Merge "Use param obj for contxt album decln"
Jorge Hernandez [Thu, 15 Nov 2018 14:35:08 +0000 (14:35 +0000)]
Merge "Refactored Asynchronous tests to integration"
liamfallon [Wed, 14 Nov 2018 17:01:39 +0000 (17:01 +0000)]
Refactored Asynchronous tests to integration
Moved the tests of asynchronous and synchronous inputs and outputs
for Apex from benchmark tests to integration tests which is where
they should be. Also the tests were amended to use the common
integration test data.
Change-Id: Id2d098b0a7d70c50dbb4547b0386cc7bcf6245a9
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
kris.jinka [Thu, 15 Nov 2018 02:26:38 +0000 (11:26 +0900)]
Use param obj for contxt album decln
Modify code generator cli editor to use param object
for the sonar issue fix
Issue-ID: POLICY-1251
Change-Id: I3efbdbe2ce7c16702508b9f1f36ecbb9b1e12856
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
kris.jinka [Tue, 13 Nov 2018 01:45:42 +0000 (10:45 +0900)]
Use param obj for policymodel AxState
Define AxStateParams object for parameters input
Fix sonar issue about more than 7 parameters in method
Modify the builder approach as suggested in review
Issue-ID: POLICY-1251
Change-Id: Ic11b8cc2a4aed5394c5450fed4f0702c4ad9eda4
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
liamfallon [Sat, 10 Nov 2018 00:39:12 +0000 (00:39 +0000)]
Clean up eclipse and document warnings
Parent versions in some POMs only called on the test profile
were incorrect
Warnings in Eclipse on POM including from outside its project
are fixed
Some checkstyle fixes
Some javadoc warnings fixed
Issue-ID: POLICY-954
Change-Id: I640bc842dc79a9fa580015abb9a76c84a7845efe
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 6 Nov 2018 12:02:46 +0000 (12:02 +0000)]
Refactor unit test data
There were many copies of test policies and examples
strewn through the Apex unit tests. This change cleans
up the unit tests so that a single version of all example
policies is used in all tests.
Also added a new relative file root command line parameter
to Apex to allow the root of relative paths in configuration
files to be set.
Apologies for the size of this review but unfortunately
all of this must be done in one shot.
Issue-ID: POLICY-1252
Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 1 Nov 2018 14:59:21 +0000 (14:59 +0000)]
Upgrade Jython for security, add doc warning
Upgrading Jython to use a full release version. This will probably
noit remove security problem but upgrades Jython to the most popular
version.
A warning is added telling developers to check extra pcakages in the
Jython plugin documentation.
Issue-ID: POLICY-1065
Change-Id: I83275204c1905bd48dd5ea58e98dcbbd9c47195f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 31 Oct 2018 16:35:54 +0000 (16:35 +0000)]
Set new master version for Dublin
Issue-ID: POLICY-1232
Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
ramverma [Wed, 24 Oct 2018 19:14:02 +0000 (20:14 +0100)]
Fix refering to snapshot in policy/apex-pdp
Issue-ID: POLICY-1213
Change-Id: I9187462aa470cff6ca7adc750c8a666bf8e15429
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
ramverma [Tue, 23 Oct 2018 15:58:34 +0000 (16:58 +0100)]
Adding stability test plan of apex-pdp
Change-Id: I41e1237c350b9cceca2b80db3fc9dcccf1173a66
Issue-ID: POLICY-817
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Jorge Hernandez [Fri, 19 Oct 2018 13:35:36 +0000 (13:35 +0000)]
Merge "Add utility packages to Apex docker image"
liamfallon [Fri, 19 Oct 2018 12:46:41 +0000 (13:46 +0100)]
Add utility packages to Apex docker image
Add zip/curl/ping/vi to the image for debugging
Issue-ID: POLICY-812
Change-Id: I31b156aedd1500ef0ae50a45354f033b057dc7e4
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 19 Oct 2018 11:03:35 +0000 (12:03 +0100)]
Fix bug to allow JSON arrays of events
Apex should allow JSON arrays of events to be processed, processing
the array of events as they come in. This review changes the Apex
JSON array handling to allow arrays of JSON events to be processed.
Arrays of events are required to perform Apex pewrformance tests.
Change-Id: I08ddc9659414bd076fbaa250182335d6f38473e6
Issue-ID: POLICY-812
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
mmis [Mon, 8 Oct 2018 14:54:36 +0000 (15:54 +0100)]
Added documentation for readthedocs
Issue-ID: POLICY-1161
Change-Id: I8a3ac2b8fbfccacd04cfd5cb3bc649d9674ec59b
Signed-off-by: mmis <michael.morris@ericsson.com>
Pamela Dragosh [Mon, 8 Oct 2018 20:19:31 +0000 (16:19 -0400)]
Upgrade to release policy/common
1.3.0 is released.
Change-Id: I2da787ab3203ef7eba5f50aa4bff30c76f1c6cd4
Issue-ID: POLICY-1189
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Mon, 8 Oct 2018 14:58:34 +0000 (15:58 +0100)]
Remove Sonar Vulnerabilit
The coverage review for teh Apex engine introduced a
vulnerability flag in Sonar. This review fixes that
vulnerability
Change-Id: Ie90c61a22c79604513ff2393a768a22ec9542484
Issue-ID: POLICY-1034
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Pamela Dragosh [Mon, 8 Oct 2018 11:59:25 +0000 (11:59 +0000)]
Merge "Unit test for Apex engine"
liamfallon [Sat, 6 Oct 2018 12:33:26 +0000 (13:33 +0100)]
Unit test for Apex engine
Coverage for unit test of engie state and state machine handling.
Added coverage of the facade and executor context classes
Added coverage for executors
Added coverage for the remainder of the core engine
Issue-ID: POLICY-1034
Change-Id: I85c66005dfdffdf2b4ee5672473a3ae4823d0d9c
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 5 Oct 2018 22:33:00 +0000 (23:33 +0100)]
JUnit for apex Admin Protocol listener
Added coverage for this package.
i
Issue-ID: POLICY-1034
Change-Id: I2e4b51983eec245eb9f105587d15f853656ce35a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
ramverma [Fri, 5 Oct 2018 14:36:11 +0000 (15:36 +0100)]
Fix sonar bugs in apex-pdp
Change-Id: I1ab9b9d9b0b8d1655301959d7d6b9ab3cc87eba3
Issue-ID: POLICY-954
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
liamfallon [Fri, 5 Oct 2018 12:28:30 +0000 (13:28 +0100)]
Set pretty print on JSON creation
Pretty printing was set off, making debugging of JSON
messages more difficult.
Issue-ID: POLICY-954
Change-Id: Ifcc32cdba822f2bfc105c99cc3dc85ee05a89f6f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 4 Oct 2018 06:06:41 +0000 (07:06 +0100)]
Fix creation of sub Avro items
When an Avro object is created, nested sub avro objects
are not created automatically. This change allows
invocation of a method to create sub objects of Avro
objects.
Issue-ID: POLICY-954
Change-Id: Ie510867f2631ba6a8c6f5452c08aef5db67e8997
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 3 Oct 2018 14:22:53 +0000 (15:22 +0100)]
Add unit test for core events and context
This code is covered by feature testing but does not
show up in Sonar. These unit tests give coverage on engine
modules.
Issue-ID: POLICY-1034
Change-Id: Ib7a288bcb9729ec88346cc8047e38f3a58f9a97c
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 2 Oct 2018 13:57:43 +0000 (14:57 +0100)]
Add Unit Test for Admin Protocol messages
Issue-ID: POLICY-1034
Change-Id: Ie07d5036ab328ab51843694a3b2a6bac87920f2e
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Mon, 1 Oct 2018 17:19:50 +0000 (18:19 +0100)]
Add JUnit for test concepts
JUnit test for test concepts.
Issue-ID: POLICY-1034
Change-Id: Ia2cd896272d4278d842d19d21237edcdca54a1f8
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Mon, 1 Oct 2018 14:05:58 +0000 (15:05 +0100)]
Refactor monitoring REST tests to remove PowerMock
Removed PowerMock from tests becasue coverage of PowerMock is not counted
by JaCoCO. It was easier to remove PowerMock than to try and hack the build
get PowerMock coverage counted.
Issue-ID: POLICY-1034
Change-Id: Ifc3e1ff93b2bfcb5619a5af6dec320d2de992f87
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 28 Sep 2018 21:48:30 +0000 (22:48 +0100)]
Unit test for client monitoring
Coverage for the client monitoring module.
Issue-ID: POLICY-1034
Change-Id: I6bb6dab26ce0572923c3d451a3b5f4745d40d088
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 28 Sep 2018 13:26:40 +0000 (14:26 +0100)]
Add JUnit for cli-codegen
The cli-codegen tool did not have any unit tests.
Issue-ID: POLICY-1034
Change-Id: If9d3924adea703b165b360e314ea3cb417a91d21
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Fri, 28 Sep 2018 11:11:59 +0000 (12:11 +0100)]
Add unit test for core distribution
JUnit for the batch deployer and deploy facade.
Issue-ID: POLICY-1034
Change-Id: I3959578ba8666d64b48bbe4ee9aeab27b92d77ae
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 27 Sep 2018 21:42:56 +0000 (22:42 +0100)]
Unit test for core deployment
This module was not covered by unit test.
Issue-ID: POLICY-1034
Change-Id: I700d43c0bde58c2b236f46994f380e20116418d9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Code Review / policy / apex-pdp.git / log