Mohammad Salehe [Fri, 8 Feb 2019 16:34:41 +0000 (11:34 -0500)]
Implement voluntaryReleaseLock retry logic
Add retry logic for voluntaryReleaseLock inside atomicPut
Change-Id: Iedb474c673541f3f79d4ae4ee76e15f14a387ed7
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:33:35 +0000 (11:33 -0500)]
Use executePut lock ordinal parameter
Use executePut lock ordinal instead of directly setting
timestamp in query string
Change-Id: Ide09e983f7a8cb363568c4123ebce57b9bb0c6d9
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:29:08 +0000 (11:29 -0500)]
Return correct value on lockref dequeue exception
If we can not dequeue the lock reference, we should not return
same result, so the caller can try again
Change-Id: I10c2923849b837253e3ef86da077b221f9607e13
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:25:38 +0000 (11:25 -0500)]
More detailed error messages for lock references
Change-Id: Id2be5f781e95e2252b6e8cafecc0fd18f2ed5366
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:23:33 +0000 (11:23 -0500)]
Add "ORDER BY" to top of lock queue checks
Add explicit "ORDER BY" to top of lock queue check queries
Change-Id: Ibb985d21283cd952e609b8fbb8d78194f5891d60
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:22:33 +0000 (11:22 -0500)]
Check for lockref validity while guarding it
Lock references are not unique until the guard is updated, so
in case of contention, we might not be able to use the lock
reference we have. We should abort so the caller can try again
Change-Id: I52cfb8c6979cced81dd20f4ef9b55b79121f121f
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:19:35 +0000 (11:19 -0500)]
Use query parameters instead of string concat
Change-Id: I477368dec2fe2ea994f02ed90822ee9dc6656945
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Sun, 30 Dec 2018 02:40:46 +0000 (21:40 -0500)]
Calculate standard deviation in stats
Calculate standard deviation correctly in
stats in SamplerHistogramTimeMeasure
Change-Id: I1448cf219872987ce348bbd6e70d6ac5ac99bdc2
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 16:45:25 +0000 (11:45 -0500)]
Indicate failure in createLockReference
We may not be able to create a lock reference temporarily.
We should indicate that by returning null, so the caller
can try again
Change-Id: If83567d64fd077b1a8eb39f66b8292c0ba6adefd
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 8 Feb 2019 17:03:55 +0000 (12:03 -0500)]
Add retry logic for createLockRef in atomicPut
createLockRef might fail because of Cassandra LWT failures.
atomicPut should keep retrying until success.
Change-Id: I044cb9277e17d19d7ffd4a02936f9eb6d8487bd3
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Chandan Ghosh [Fri, 1 Feb 2019 10:24:42 +0000 (15:54 +0530)]
Added testcase for updateOnboardApp method
Added testcase for updateOnBoardApp method
Issue-ID: MUSIC-305
Change-Id: Iff497e243935ee42538623da48a8969a295307fc
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Chandan Ghosh [Fri, 1 Feb 2019 10:14:34 +0000 (15:44 +0530)]
Added testcase for deleteOnboardApp service method
Added testcase for deleteOnboardApp service method
Issue-ID: MUSIC-305
Change-Id: I05a4a30cbff33bbc48f908b6e68086c7ed492a83
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Chandan Ghosh [Fri, 1 Feb 2019 09:48:20 +0000 (15:18 +0530)]
Added testcase for service layer RestAdmin api
Added testcase for service layer getOnboardedInfoSearch method
Issue-ID: MUSIC-305
Change-Id: If5ebc6969f3a4672b79e389147ec90de578596b0
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Tschaen, Brendan [Tue, 29 Jan 2019 17:02:13 +0000 (12:02 -0500)]
Increment version
Change-Id: I81eddadc40e104e30a5048032311053527c86695
Issue-ID: MUSIC-279
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Bharath Balasubramanian [Tue, 29 Jan 2019 14:30:30 +0000 (14:30 +0000)]
Merge "refactord RestMusicAdminAPI.java as per spring MVC" into dev-cassandra-only
Tschaen, Brendan [Tue, 22 Jan 2019 15:52:15 +0000 (10:52 -0500)]
Stabilize v3.2.1
Change-Id: Icf4bc3515b909e8fbec6fb6656ab1378033b60d8
Issue-ID: MUSIC-279
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Sandeep J [Mon, 21 Jan 2019 10:13:09 +0000 (15:43 +0530)]
refactord RestMusicAdminAPI.java as per spring MVC
refactored the class and updated unit test cases as per the code changes
Issue-ID: MUSIC-212
Change-Id: Id66854be3894d36e2c2b0a6d86c2f6bb29e48db6
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Tschaen, Brendan [Tue, 15 Jan 2019 20:23:00 +0000 (15:23 -0500)]
Build and install jar
Change-Id: I2ef5ddf0d41109e5b2c56dcc4654d9360299701c
Issue-ID: MUSIC-270
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Mohammad Salehe [Thu, 20 Dec 2018 03:32:27 +0000 (22:32 -0500)]
Implement first benchmarks
Implement simple benchmarks for 4 different put scenarios:
- Music Entry Consistency
- Music Eventual
- Music Sequential Consistent (Using LWT)
- Pure Consistent (Using LWT)
Change-Id: Ia4b989c640a198f03086e781450e79c8c43918df
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Thu, 20 Dec 2018 03:31:11 +0000 (22:31 -0500)]
Add retry logic for acquireLock in atomicPut
acquireLock might fail right after generating a
new lock reference because we are not making a SERIAL get.
atomicPut should keep retrying until it acquires the lock.
Change-Id: I7b0f85a0d0229e28a56cdd41ec69fcde8d8398fe
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Wed, 28 Nov 2018 00:07:34 +0000 (19:07 -0500)]
Add primary time measurements to MusicCore
Add time measurements to MusicCore.atomicPut and
dependent Cassandra execute path
Change-Id: I44455d7232e12d29a648c3d59d9aa102bf1ab232
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Tue, 27 Nov 2018 00:58:44 +0000 (19:58 -0500)]
Update .gitignore
Change-Id: I31b680cbf040f3b152df0b984a445341e9a20f16
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Tue, 27 Nov 2018 00:58:30 +0000 (19:58 -0500)]
Refactor Cassandra connection process
Refactor MusicUtil and CassaDataStore to make
Cassandra connection initialization process
more simple and readable
Change-Id: Ied7d3e82dc86dd7d35cd513b13ff0c865dd40b4b
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Tue, 27 Nov 2018 00:32:55 +0000 (19:32 -0500)]
Move runnable test classes
Move runnable test classes which are not actually
tests from src/test to src/main in order for maven
to include them in fat jar
Change-Id: Ib57db631b1c91ae796fa33becc9f06d05eef4219
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Tue, 27 Nov 2018 00:31:58 +0000 (19:31 -0500)]
Add shade plugin to maven pom.xml
Add shade plugin to maven pom.xml to be able to create fat jars
Change-Id: I2ed41cfee6a7fe088b4072fed11d04c36724c730
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Sat, 24 Nov 2018 00:37:13 +0000 (19:37 -0500)]
Remove unwanted line from pom.xml
Remove unwanted line which blocked including
classes starting with "Sample" in the target jars
Change-Id: I428e23e63feb348d19f16846b3625c82b49d252f
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Fri, 23 Nov 2018 17:07:27 +0000 (12:07 -0500)]
Implement time measurement utility
Added a TimeMeasure interface as a utility class
to be able to measure running time of specific parts
of code. Usually, this will be used for benchmarking.
Implemented SamplerHistogramTimeMeasurement that uses
reservior sampling to calculate percentiles of large
amount of data.
Also updated maven pom.xml:
- update java version from 1.7 to 1.8 to be able to use java 8
- update guava to 27.0 to use Stats Percentiles
- update cassandra java plugin version to 3.6 to fix guava dependency problem
Change-Id: I168432ff2e6f5507fedc1678684dd96608703e5a
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Wed, 7 Nov 2018 21:05:22 +0000 (16:05 -0500)]
Implement first comparison point tests
Implement ComparisonPoints1 benchmarks to
test 4 different put scenarios:
- Music Entry Consistency
- Music Eventual
- Music Sequential Consistent (Using LWT)
- Pure Consistent (Using LWT)
Change-Id: Id9052a0b14686be93189021e19f2dc293188c52b
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Bharath Balasubramanian [Thu, 20 Dec 2018 06:37:14 +0000 (06:37 +0000)]
Merge "added files to convert project to spring boot" into dev-cassandra-only
Sandeep J [Tue, 11 Dec 2018 14:29:13 +0000 (19:59 +0530)]
added files to convert project to spring boot
also made changes to pom to add required dependencies.
fix junit cases, upgrading to mockito 2.x
Issue-ID: MUSIC-212
Change-Id: Ieeeaa6d62e03e962534182183aae8ae838d93eba
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Tschaen, Brendan [Wed, 12 Dec 2018 18:47:54 +0000 (13:47 -0500)]
Read/Write locking implementation
Change-Id: I31fedd52e138c848bf12ed0be27c348f4f96bcb5
Issue-ID: MUSIC-262
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Mon, 3 Dec 2018 20:21:30 +0000 (15:21 -0500)]
Cassa lockstore return string for peekLock
Change-Id: I4384ed522e7849ba9ca355efa63a08512f11ccec
Issue-ID: MUSIC-222
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
srupane kondreddy [Wed, 28 Nov 2018 23:20:21 +0000 (18:20 -0500)]
music as a service impl v3
Change-Id: I7f96eaa48afed96d62ad7662139167e8a17d00d7
Issue-ID: MUSIC-204
Signed-off-by: srupane kondreddy <sk5300@research.att.com>
Tschaen, Brendan [Tue, 27 Nov 2018 22:29:52 +0000 (17:29 -0500)]
Add getLockQueue to music api
Change-Id: Ib7db75a2df76ee7dcca92d69d07c3b947736deab
Issue-ID: MUSIC-204
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Mohammad Salehe [Wed, 7 Nov 2018 20:56:21 +0000 (15:56 -0500)]
Improve timestamp and query handling
Add timeSlot parameter to CassaDataStore.executePut
to prevent inconsistent timestamps
Rename CassaDataStore.executeEventualGet and
CassaDataStore.executeCriticalPut to reflect
their real functionality
Use simple bound statement instead of
prepared queries to improve performance
Change-Id: I439c5279f1c8e645740a9650ab8807c5ffa1725a
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Mohammad Salehe [Wed, 7 Nov 2018 16:09:50 +0000 (11:09 -0500)]
Implement sequential lock references
Use guard column for sequential lock references
Move v2sTimeStampInMicroseconds as a static method to MusicUtil
Use v2sTimeStamp in CassaDataStore.executePut
Change-Id: I48b817c4bfe04ec50f5ad6e7cdc91b34fd607feb
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Tschaen, Brendan [Thu, 15 Nov 2018 15:31:53 +0000 (10:31 -0500)]
Revert "music core implemented as a service"
This reverts commit
7addd52dc73e6571028ca7f6a018e75ec1c9b0ca.
Change-Id: I0875ce10521363b8e17eb6cd2cf9d8848e572bea
Issue-ID: MUSIC-189
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
srupane kondreddy [Tue, 13 Nov 2018 20:27:24 +0000 (15:27 -0500)]
music core implemented as a service
Change-Id: I4075d0efb03bf2a153976354947be1329660c1f1
Issue-ID: MUSIC-148
Signed-off-by: srupane kondreddy <sk5300@research.att.com>
Mohammad Salehe [Wed, 7 Nov 2018 16:00:34 +0000 (11:00 -0500)]
Modify TestVotingApp and add extra update
Change-Id: I250cef00bbea068196f54f442ed7d47fe0dd4aab
Issue-ID: MUSIC-148
Signed-off-by: Mohammad Salehe <salehe@cs.toronto.edu>
Tschaen, Brendan [Tue, 6 Nov 2018 17:17:37 +0000 (12:17 -0500)]
Jar only version for now
Change-Id: I54a94e30da52ad9a01df13d16bbf790fb1245464
Issue-ID: MUSIC-149
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Tue, 6 Nov 2018 14:00:35 +0000 (09:00 -0500)]
Clean up readme
Ignore broken test cases related to locking
Change-Id: Ic54920647519255bfeb3cb59f5d36299e0d1984f
Issue-ID: MUSIC-148
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Mon, 5 Nov 2018 19:19:19 +0000 (14:19 -0500)]
Separate jar, ignore locking unit tests
Change-Id: I9ac45fc4dc93a8dad86ead9676129411ca8a5a26
Issue-ID: MUSIC-148
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Thu, 1 Nov 2018 19:28:02 +0000 (15:28 -0400)]
Fix property loading in jar
Change-Id: Idbadcf1d1ae6203b97f50b6659a929595cb53b20
Issue-ID: MUSIC-148
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Thu, 25 Oct 2018 15:48:14 +0000 (11:48 -0400)]
Update version number
Change-Id: I335b5eaaff720e1bde76eb3278ffb4cc2c17ea8b
Issue-ID: MUSIC-148
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Wed, 17 Oct 2018 00:22:35 +0000 (20:22 -0400)]
Include Cassandra locking
Change-Id: I085acf8336d5f27782ee12768846a5befd3ee60d
Issue-ID: MUSIC-148
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Thomas Nelson Jr [Sun, 14 Oct 2018 06:47:32 +0000 (02:47 -0400)]
Bug Fix to keep runcwl from failing.
Update to ensure container exits with a 0
Change-Id: I330a9488017303a6a3b08473bdedf43b9d65abd6
Issue-ID: MUSIC-147
Signed-off-by: Thomas Nelson <nelson24@nelson42.com>
Signed-off-by: Thomas Nelson Jr arthurdent3 <nelson24@att.com>
Thomas Nelson [Wed, 10 Oct 2018 18:34:07 +0000 (18:34 +0000)]
Merge "Added test file for NameSpace.java"
Bharath Balasubramanian [Wed, 10 Oct 2018 18:18:55 +0000 (18:18 +0000)]
Merge "Update to support Encrypted password"
Thomas Nelson [Wed, 10 Oct 2018 18:09:07 +0000 (18:09 +0000)]
Merge "Added test file for JsonNotifyClientResponse.java"
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Mon, 8 Oct 2018 18:29:46 +0000 (14:29 -0400)]
Update to support Encrypted password
in properties.
Update duplicate entries in pom file.
Add dependency
Fix Version
Change-Id: If427601841c14cb14232452b4ec8236e76075275
Issue-ID: MUSIC-146
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Thu, 4 Oct 2018 22:04:40 +0000 (18:04 -0400)]
Added fix for OOF issue.
Updated Pom files for Library version change.
Change-Id: Ibf10eba8923353010b66ac8496fb53815f3affc4
Issue-ID: MUSIC-143
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
Arundathi Patil [Sun, 30 Sep 2018 09:39:18 +0000 (15:09 +0530)]
Added test file for JsonNotifyClientResponse.java
to increase the coverage
Issue-ID: MUSIC-142
Change-Id: I582059e5544f3c092de832d54fcf0b5f15df62c0
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Sat, 29 Sep 2018 08:19:31 +0000 (13:49 +0530)]
Added test file for NameSpace.java
To increase the coverage
Issue-ID: MUSIC-141
Change-Id: I86c9e8bb0fdeb7dd3ea587cb8087e95fdbb567e3
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Sat, 29 Sep 2018 04:53:34 +0000 (10:23 +0530)]
Added test file for JSONObject.java
To increase the coverage
Issue-ID: MUSIC-140
Change-Id: Ic92c8a883d758341ab1ec11ad9bb0f062501fe79
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Bharath Balasubramanian [Tue, 18 Sep 2018 02:48:41 +0000 (02:48 +0000)]
Merge "Update distribution files to support helm charts"
Thomas Nelson Jr (arthurdent3) tn1381@att.com [Tue, 18 Sep 2018 02:35:25 +0000 (22:35 -0400)]
Update distribution files to support helm charts
Helm Charts require new Docker images.
Refined Cassandra and Cassandra cql loader.
Change-Id: Ie7726025afd63e256a43aef9f39d53c32c90c77b
Issue-ID: MUSIC-99
Signed-off-by: Thomas Nelson Jr (arthurdent3) tn1381@att.com <tn1381@att.com>
Thomas Nelson [Tue, 18 Sep 2018 02:15:32 +0000 (02:15 +0000)]
Merge "Add distribution management to pom"
Thomas Nelson [Tue, 18 Sep 2018 01:49:55 +0000 (01:49 +0000)]
Merge "MusicServiceException.java: Fixed sonar issues"
Thomas Nelson [Tue, 18 Sep 2018 01:48:22 +0000 (01:48 +0000)]
Merge "Move string literal to left of string comparison"
Tschaen, Brendan (bt054f) [Mon, 17 Sep 2018 18:46:29 +0000 (14:46 -0400)]
Add distribution management to pom
Change-Id: Ib3e17a547d0e8d4d71898293dd32013d987c14b0
Issue-ID: MUSIC-93
Signed-off-by: Tschaen, Brendan (bt054f) <bt054f@att.com>
Tschaen, Brendan (bt054f) [Mon, 17 Sep 2018 17:47:28 +0000 (13:47 -0400)]
Change pom for ONAP
Change-Id: Ifc2b12a4231a856d9b858458b2d39129d3be00a7
Issue-ID: MUSIC-93
Signed-off-by: Tschaen, Brendan (bt054f) <bt054f@att.com>
Arundathi Patil [Mon, 17 Sep 2018 11:05:31 +0000 (16:35 +0530)]
MusicServiceException.java: Fixed sonar issues
Link: https://sonar.onap.org/code?id=org.onap.music%3AMUSIC&selected=org.onap.music%3AMUSIC%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fmusic%2Fexceptions%2FMusicServiceException.java
Issue-ID: MUSIC-137
Change-Id: Ibb96c29aa17d7f8f42d1ceb5aa9581b2b250e2dc
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Sooriyaa [Wed, 12 Sep 2018 09:14:13 +0000 (14:44 +0530)]
Move string literal to left of string comparison
Move string literal to left of string comparison
Issue-ID: MUSIC-135
Change-Id: I622f2682e98c7927b66d11058da98c13b6b12942
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Thomas Nelson [Mon, 10 Sep 2018 16:24:27 +0000 (16:24 +0000)]
Merge "RestMusicQAPI.java: Fixed sonar issues"
Sooriyaa [Mon, 10 Sep 2018 07:10:03 +0000 (12:40 +0530)]
Adding a constant to remove duplicate string
Adding a constant to remove duplicate string
Issue-ID: MUSIC-133
Change-Id: I1c9e82cf210c2dd0f00bec53c95fa5281f368568
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Arundathi Patil [Thu, 6 Sep 2018 09:46:19 +0000 (15:16 +0530)]
RestMusicQAPI.java: Fixed sonar issues
Fixed sonar code-smells/issues across this file
Issue-ID: MUSIC-132
Change-Id: I8085caf301a46165675ff20a80b0fac1fbf885ff
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Thomas Nelson [Thu, 6 Sep 2018 15:57:06 +0000 (15:57 +0000)]
Merge "JsonNotification.java: Fixed sonar issue"
Thomas Nelson [Thu, 6 Sep 2018 15:56:25 +0000 (15:56 +0000)]
Merge "Removing the literal true boolean value"
Thomas Nelson [Thu, 6 Sep 2018 15:52:45 +0000 (15:52 +0000)]
Merge "Remove the unused import"
Thomas Nelson [Thu, 6 Sep 2018 15:52:12 +0000 (15:52 +0000)]
Merge "Added error log in MusicConditional class"
Thomas Nelson [Thu, 6 Sep 2018 15:44:05 +0000 (15:44 +0000)]
Merge "replaced stacktrace with error log"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:10:50 +0000 (23:10 +0000)]
Merge "RestMusicVersionAPI.java: Fixed sonar issue"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:07:22 +0000 (23:07 +0000)]
Merge "Remove the literal false boolean value"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:59 +0000 (23:06 +0000)]
Merge "Move string literal to left of string comparison"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:45 +0000 (23:06 +0000)]
Merge "Added bug fix reported in SonarQube for MusicUtil"
Bharath Balasubramanian [Wed, 5 Sep 2018 23:06:31 +0000 (23:06 +0000)]
Merge "Added fix for potential nullpointer exception"
Chandan Ghosh [Wed, 5 Sep 2018 07:13:02 +0000 (12:43 +0530)]
Added error log in MusicConditional class
Added error log in MusicConditional class where it was missing. Reported
in Sonar.
Issue-ID: MUSIC-129
Change-Id: I8d3102547015313520b67058312e4072f621ca34
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Sooriyaa [Wed, 5 Sep 2018 07:09:27 +0000 (12:39 +0530)]
Move string literal to left of string comparison
Move string literal to left of string comparison
Issue-ID: MUSIC-131
Change-Id: I210469c9c7e827df51f20fb7f580282a145b4464
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Chandan Ghosh [Wed, 5 Sep 2018 06:30:18 +0000 (12:00 +0530)]
replaced stacktrace with error log
Replaced stacktrace with error log. Reported in SonarQube.
Issue-ID: MUSIC-129
Change-Id: I54626e3b8d80cf7242cd1e67b627aa73266f1e8d
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Sooriyaa [Wed, 5 Sep 2018 06:29:47 +0000 (11:59 +0530)]
Remove the literal false boolean value
Remove the literal false boolean value
Issue-ID: MUSIC-130
Change-Id: I99f7168abc2d354919b2b01006b89ec26e762864
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Sooriyaa [Tue, 4 Sep 2018 10:04:31 +0000 (15:34 +0530)]
Remove the unused import
Remove the unused import
Issue-ID: MUSIC-128
Change-Id: Ic12deb0959761f2878fdf20b71e012ee3a0bac2e
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Arundathi Patil [Tue, 4 Sep 2018 06:16:27 +0000 (11:46 +0530)]
RestMusicVersionAPI.java: Fixed sonar issue
Fixed sonar code-smells/issues across this file.
Issue-ID: MUSIC-127
Change-Id: I8a79a09ce5ec8c0f7e6e0f664f570dc61a848040
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Chandan Ghosh [Tue, 4 Sep 2018 06:16:14 +0000 (11:46 +0530)]
Removed unused imports. added error log
Issue-ID: MUSIC-126
Change-Id: I1a73518da1c3d028ce9e8933def60c02b26482ff
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Sooriyaa [Tue, 4 Sep 2018 06:04:58 +0000 (11:34 +0530)]
Removing the literal true boolean value
Removing the literal true boolean value
Issue-ID: MUSIC-125
Change-Id: Id126541571cc3eb2475f064421b0baaeada8e0e7
Signed-off-by: Sooriyaa <soponraj@in.ibm.com>
Bharath Balasubramanian [Mon, 3 Sep 2018 20:37:18 +0000 (20:37 +0000)]
Merge "Added fix for potential nullpointerexception"
Bharath Balasubramanian [Mon, 3 Sep 2018 20:36:33 +0000 (20:36 +0000)]
Merge "MusicLockState.java: Fixed sonar issue"
Bharath Balasubramanian [Mon, 3 Sep 2018 20:35:59 +0000 (20:35 +0000)]
Merge "JsonDelete.java: Fixed sonar issue"
Arundathi Patil [Mon, 3 Sep 2018 10:24:13 +0000 (15:54 +0530)]
ProtocolSupport.java: fixed sonar issue
Fixed sonar code-smella/issues accross this file
Issue-ID: MUSIC-124
Change-Id: Iebfaae30d941761ffbe59920cf6301cf22daae44
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Mon, 3 Sep 2018 09:51:29 +0000 (15:21 +0530)]
MusicLockState.java: Fixed sonar issue
Fixed sonar code-smells/issues accross this file
Issue-ID: MUSIC-123
Change-Id: I7b288ea53029488e827f31c1dabd7ad276de97a2
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Mon, 3 Sep 2018 08:49:40 +0000 (14:19 +0530)]
JsonDelete.java: Fixed sonar issue
Fixed sonar issue, declare variable on seperate line.
Issue-ID: MUSIC-121
Change-Id: Idf2cdb49a7d021d275dea5685a77e98b9c94fe9e
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Chandan Ghosh [Mon, 3 Sep 2018 07:06:28 +0000 (12:36 +0530)]
Added fix for potential nullpointerexception
Added fix for potential nullpointerexception and added error log reported in sonarqube
Issue-ID: MUSIC-119
Change-Id: I13b3b13b1caa209c0f9ff9f19b38a62c4486c2fe
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Bharath Balasubramanian [Fri, 31 Aug 2018 17:38:46 +0000 (17:38 +0000)]
Merge "jsonSelect.java: Fixed sonar issue"
Arundathi Patil [Fri, 31 Aug 2018 16:40:59 +0000 (22:10 +0530)]
jsonSelect.java: Fixed sonar issue
Fixed sonar issue, either log or rethrow this error
Issue-ID: MUSIC-116
Change-Id: Iace6b3251a2b3b60cfd8ce99d6a0ed8ecf80fe02
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Fri, 31 Aug 2018 16:29:16 +0000 (21:59 +0530)]
JsonConditional.java: Fixed sonar issue
Fixed sonar issue, use transient keyword for variables.
Issue-ID: MUSIC-117
Change-Id: I9c8ef0b9fb3239c98a09058cf14019df095e440b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Chandan Ghosh [Wed, 29 Aug 2018 07:03:48 +0000 (12:33 +0530)]
Added fix for potential nullpointer exception
Added fix for potential nullpointerexception reported in sonarqube
Issue-ID: MUSIC-114
Change-Id: I6792a357534880fb85d353e2832b16aca2415c8b
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Chandan Ghosh [Tue, 28 Aug 2018 09:37:16 +0000 (15:07 +0530)]
Added bug fix reported in SonarQube for MusicUtil
Added bug fix reported in SonarQube for MusicUtil
Issue-ID: MUSIC-107
Change-Id: I6792a357505880fb85d353e3872b16aca2412c8b
Signed-off-by: Chandan Ghosh <cghosh12@in.ibm.com>
Arundathi Patil [Wed, 29 Aug 2018 06:42:26 +0000 (12:12 +0530)]
JsonNotification.java: Fixed sonar issue
Fixed sonar issue, remove unused import
Issue-ID: MUSIC-113
Change-Id: Ifddef7c3d317e47b525e676163b7d47f393465d8
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Bharath Balasubramanian [Tue, 28 Aug 2018 11:56:28 +0000 (11:56 +0000)]
Merge "JasonUpdate.java: Fixed sonar issue"
Bharath Balasubramanian [Tue, 28 Aug 2018 11:56:14 +0000 (11:56 +0000)]
Merge "MusicCore.java : Fixed sonar issue"
Arundathi Patil [Tue, 28 Aug 2018 07:21:42 +0000 (12:51 +0530)]
MusicConditional.java: Fixed sonar issue
Fixed sonar issue, null pointer exception could be thrown
Issue-ID: MUSIC-112
Change-Id: I2480634a270114c21d23dda72c381b7e9e389b18
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Code Review / music.git / log