Rich Tabedzki [Tue, 8 May 2018 15:27:50 +0000 (11:27 -0400)]
Provide support for properties encryption
Changes made:
* Implemented code to decrypt password field in property file
Change-Id: I97e5f93fd1f8383c1e2a1e6170489dc1db9d6337
Issue-ID: CCSDK-182
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Dan Timoney [Fri, 4 May 2018 19:20:02 +0000 (19:20 +0000)]
Merge "SLI provider needs Dynamic-ImportPackage"
Timoney, Dan (dt5972) [Fri, 4 May 2018 18:02:50 +0000 (14:02 -0400)]
SLI provider needs Dynamic-ImportPackage
The SLI provider package needs the option Dynamic-ImportPackage set in
its manifest to allow it to bypass normal OSGi classpath isolation.
Change-Id: I93be9ed111f72197db16f1b486b2102cbb9bbcdb
Issue-ID: CCSDK-268
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Thu, 3 May 2018 22:02:13 +0000 (22:02 +0000)]
Merge "TestSvcLogicLoader for windows"
Smokowski, Kevin (ks6305) [Thu, 3 May 2018 19:11:40 +0000 (19:11 +0000)]
TestSvcLogicLoader for windows
TestSvcLogicLoader fails when run against a machine running windows
Change-Id: I3687ac21c50cde10b1e8a0ed816b67d48c5e77f9
Issue-ID: CCSDK-266
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Smokowski, Kevin (ks6305) [Thu, 3 May 2018 18:38:16 +0000 (18:38 +0000)]
SetNodeExecutor nulling feature enhancement
Add special handling for clear a single array element or an entire array
Change-Id: Ica73e2af32f4a566219e1487504753276bc98aa2
Issue-ID: CCSDK-265
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Dan Timoney [Mon, 30 Apr 2018 15:06:10 +0000 (15:06 +0000)]
Merge "Roll versions step 2 : sli/core poms"
Timoney, Dan (dt5972) [Sun, 29 Apr 2018 22:45:28 +0000 (18:45 -0400)]
Roll versions step 2 : sli/core poms
Roll to next version for next release candidate.
Change-Id: I0a76316934afd79f4ecf3588453ed4d6e34fb615
Issue-ID: CCSDK-257
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Smokowski, Kevin (ks6305) [Wed, 25 Apr 2018 21:13:56 +0000 (21:13 +0000)]
add replaceAll to slistringutils
add replaceAll to slistringutils because it supports regular expressions and replace does not
Change-Id: Ibff7acd339103a6bb897d14ca3d31736a5b568ef
Issue-ID: CCSDK-253
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Timoney, Dan (dt5972) [Wed, 18 Apr 2018 06:22:24 +0000 (02:22 -0400)]
Fix release version
Fix release version in version.properties
Change-Id: I4d354ac42260a4dcd17f516a413c036b85086db3
Issue-ID: CCSDK-242
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Timoney, Dan (dt5972) [Tue, 10 Apr 2018 18:56:59 +0000 (14:56 -0400)]
URGENT : Add node executors
Need to register node executors on SvcServiceImpl start up. This
was broken inadvertantly during move to Aries blueprint.
NOTE : This is a sev 1 fix for APP-C. Please review and merge
ASAP.
Change-Id: Ic4ff7c91f2b46ed81fd78a35bf8ea9d37c098c68
Issue-ID: CCSDK-236
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Mon, 9 Apr 2018 16:26:33 +0000 (16:26 +0000)]
Merge "Fix EELF version"
Timoney, Dan (dt5972) [Fri, 6 Apr 2018 18:17:48 +0000 (14:17 -0400)]
Fix EELF version
Load version 1.0.0 of EELF, based on parent property setting
Change-Id: I5e936b651f07ad9af8e4b41c80bbfed98bb67faa
Issue-ID: CCSDK-235
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Thu, 5 Apr 2018 13:47:21 +0000 (13:47 +0000)]
Merge "URGENT : Install logback"
prakash.e [Thu, 5 Apr 2018 05:22:45 +0000 (10:52 +0530)]
code coverage for ccsdk sli DG nodes
Coverage improvement for SqlResourcePropertiesProviderImpl
https://jira.onap.org/browse/CCSDK-213?jql=project%20%3D%20CCSDK%20AND%20text%20~%20coverage
Issue-ID: CCSDK-213
Change-Id: Ibc26c319801204df8ab9c7b64a1774eae0c59bd0
Signed-off-by: prakash.e <prakash.e@huawei.com>
Timoney, Dan (dt5972) [Wed, 4 Apr 2018 19:58:26 +0000 (15:58 -0400)]
URGENT : Install logback
Install logback packages needed by EELF as part of
sli common package. This is urgently needed, since CCSDK
is not coming up clean without this fix.
Change-Id: I4f47e6146e45e36752454100186851af3eba7491
Issue-ID: CCSDK-235
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Wed, 28 Mar 2018 15:03:52 +0000 (15:03 +0000)]
Merge "Simplify enumeration handling"
Timoney, Dan (dt5972) [Sat, 24 Mar 2018 23:11:10 +0000 (19:11 -0400)]
Add unit tests for sli
Added unit tests for ccsdk/sli/core/sli
Change-Id: I0d2408c43b9e56a78f3e01e87985aedb6cad5953
Issue-ID: CCSDK-213
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Smokowski, Kevin (ks6305) [Tue, 27 Mar 2018 17:48:55 +0000 (17:48 +0000)]
Simplify enumeration handling
Use getName() on the java object instead of relying on a mapping file created by yang2props
Change-Id: Ie3405903af5211c019c93a9a0b49ba9159b0bbe2
Issue-ID: CCSDK-227
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Timoney, Dan (dt5972) [Wed, 21 Mar 2018 23:15:29 +0000 (19:15 -0400)]
Add unit tests for sli/provider
Add additional unit testing for configure node
Change-Id: I867fd1aae54e956bdbe8a2f2fd406b46304b4a91
Issue-ID: CCSDK-213
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Tue, 20 Mar 2018 18:27:58 +0000 (18:27 +0000)]
Merge "Register sliapi RPC implementation"
Timoney, Dan (dt5972) [Tue, 20 Mar 2018 18:00:22 +0000 (14:00 -0400)]
Register sliapi RPC implementation
When porting sliapi to use blueprints, neglected to update sliapiProvider
to register itself as RPC implementor.
Change-Id: I653ccf4db737e8745715d5e4b07352045c9c9c5e
Issue-ID: CCSDK-217
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Smokowski, Kevin (ks6305) [Fri, 16 Mar 2018 19:46:56 +0000 (19:46 +0000)]
Additional enum support
support enumerations containing whitespace
Change-Id: I91971a111e67e0faf757c954fb6658529e3020d2
Issue-ID: CCSDK-214
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Dan Timoney [Fri, 16 Mar 2018 18:10:32 +0000 (18:10 +0000)]
Merge "Add test cases for sli"
Timoney, Dan (dt5972) [Fri, 16 Mar 2018 17:58:47 +0000 (13:58 -0400)]
Add test cases for sli
Added test cases for sli in sli/core
Change-Id: Ic8614f199ae843a46ec3441f0ae247f065b33322
Issue-ID: CCSDK-213
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Smokowski, Kevin (ks6305) [Fri, 9 Mar 2018 21:05:19 +0000 (21:05 +0000)]
Check system property before environment variable
Allow system property to take precedence over environment variable when searching for the properties file
Change-Id: I1c6f7099551d814ca388f4694a0bb24409a7167b
Issue-ID: CCSDK-209
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Dan Timoney [Thu, 8 Mar 2018 21:20:35 +0000 (21:20 +0000)]
Merge "re-use parser instance"
Rich Tabedzki [Thu, 8 Mar 2018 14:50:22 +0000 (14:50 +0000)]
Fix sonar related items
Changes made:
* Optimized TerminatingCachedDataSource
* Added additional unit tests
Change-Id: I0a83c993898e2bee11b8d3c5df8f95b4b216e9b8
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Smokowski, Kevin (ks6305) [Mon, 5 Mar 2018 21:41:54 +0000 (16:41 -0500)]
re-use parser instance
add an additional logging statement and save memory
Change-Id: Idc8bdefb00ac61317cc38848dce670d76b6d89f7
Issue-ID: CCSDK-204
Signed-off-by: Smokowski, Kevin (ks6305) <ks6305@att.com>
Kevin Smokowski [Fri, 23 Feb 2018 20:51:21 +0000 (20:51 +0000)]
fix setnode null feature
short prefixes could cause bad behavior in the setnode null feature
Change-Id: I3876eaece8b8d695b0a98d8b5d69f955f2149402
Issue-ID: CCSDK-190
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Dan Timoney [Fri, 2 Mar 2018 20:48:11 +0000 (20:48 +0000)]
Merge "Favor interfaces"
Kevin Smokowski [Fri, 23 Feb 2018 18:09:55 +0000 (18:09 +0000)]
Favor interfaces
Favor using interfaces over concrete implementations
Change-Id: Ie7541eeefa69671cc7ed39fba37fdd2e24380770
Issue-ID: CCSDK-189
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Favor interfaces
Favor using interfaces over concrete implementations
Change-Id: Ie3b71833c0f31f67288430c25ca31ca07c0449e0
Issue-ID: CCSDK-189
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Dan Timoney [Fri, 2 Mar 2018 20:15:36 +0000 (20:15 +0000)]
Merge "Updated master database detection algorithm"
Rich Tabedzki [Fri, 2 Mar 2018 04:42:45 +0000 (04:42 +0000)]
Updated master database detection algorithm
Changes made:
* updated algorithm in DBResourceManager
* Updated CachedDataSource, JdbcDBCachedDataSource
* added new unit tests
Change-Id: I4f6bbeb3839f55d183d7e762743fbc9171b63b1a
Issue-ID: CCSDK-192
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Timoney, Dan (dt5972) [Thu, 1 Mar 2018 22:18:50 +0000 (17:18 -0500)]
Fix broken merge
Fix antlr compile error.
Change-Id: Ibe7c897e4de2d6d34f842fb89fc27d210f6c8c27
Issue-ID: CCSDK-175
Signed-off-by: Timoney, Dan (dt5972) <dt5972@att.com>
Dan Timoney [Mon, 26 Feb 2018 15:58:32 +0000 (10:58 -0500)]
Fixed antlr dependencies
Should depend on antlr4-runtime instead of antlr4 to avoid
unnecessary compile-time-only dependencies
Change-Id: I720628786676dfc81b4aadd4f3da752af2d92451
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 14 Feb 2018 19:28:47 +0000 (14:28 -0500)]
Fix install issues
Fixed issues in installation scripts
Change-Id: I4bd59ab16b55555ded8d9c2b0e8486d3df88fb44
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Rich Tabedzki [Wed, 14 Feb 2018 14:17:50 +0000 (14:17 +0000)]
Fixed Java Code Conventions issue
Changes made:
* corrected sonar related issue in CachedDataSource class
Change-Id: If84b9abcd115ad042f2cc0527b5ab8c8e12cae5a
Issue-ID: CCSDK-151
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Kevin Smokowski [Fri, 9 Feb 2018 21:36:38 +0000 (21:36 +0000)]
Reset MDC after invoking node
collapse get node into a common metho, reset MDC right before getting next node for certain executor
Change-Id: I85b1cf0dfd595deee42dc93f4095ecbc6c831998
Issue-ID: CCSDK-187
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Dan Timoney [Thu, 1 Feb 2018 21:57:00 +0000 (16:57 -0500)]
Upgrade sli/core to Nitrogen
Use Apache derby for dblib SingleFeatureTest
Change-Id: I6b41f7ede1a98b33824fceea9100e75c1ce8dda4
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Generalization of CCSDK core/utils framework
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Use Apache derby for dblib test
Use Apache derby for dblib SingleFeatureTest
Change-Id: Ie497557f162e203fa5c5c82c17ddc55ba0c11b38
Issue-ID: CCSDK-175
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Fri, 9 Feb 2018 15:28:31 +0000 (15:28 +0000)]
Merge "Iso8601 format fix"
Kevin Smokowski [Fri, 9 Feb 2018 15:14:01 +0000 (15:14 +0000)]
Iso8601 format fix
fix format in method asIso8601 in metric logger
Change-Id: I50de2397231ff8b298e3a75b3220315c255c26db
Issue-ID: CCSDK-186
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Kevin Smokowski [Fri, 9 Feb 2018 14:18:39 +0000 (14:18 +0000)]
CallNodeExecutor patch
Merging an old change that prevents a nullpointerexception when calledgraph is null
Change-Id: I936afec383fcf4ba98e1d9d0a00c0d1e492766ca
Issue-ID: CCSDK-185
Signed-off-by: Kevin Smokowski <ks6305@att.com>
Rich Tabedzki [Tue, 30 Jan 2018 21:18:21 +0000 (21:18 +0000)]
Upgrade sli/core to Nitrogen
Changes made:
* Updated JREFileResolver to retrieve data file from Bundle instead of InputStream.
Change-Id: Ib2f93378117afaa2501b870aba513a77073b462f
Issue-ID: CCSDK-175
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Rich Tabedzki [Fri, 5 Jan 2018 20:26:58 +0000 (20:26 +0000)]
Generalization of CCSDK core/utils framework
Changes made:
* Created generalized version of core/utils/dblib as core/utils/common
* Deprecated core/utils/dblib package
Change-Id: I0992c43910278fbe254674d1e39d7e4fcad0a592
Issue-ID: CCSDK-168
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Dan Timoney [Tue, 19 Dec 2017 19:36:21 +0000 (14:36 -0500)]
New sliPluginUtils methods
Add new sliPluginUtils methods to faciliate accessing data
in context memory (SvcLogicContext).
Change-Id: I70fe00fd60ac6da4804a41df0a2ef7c51e80f4a0
Issue-ID: CCSDK-158
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 19 Dec 2017 18:13:36 +0000 (13:13 -0500)]
Enhance health check
In HA environment, different types of health check are needed
for load balancers (which care about state of each node in cluster)
vs external applications (which case about state of entire cluster).
So, separate APIs are needed for these 2 types of needs.
Change-Id: I99cd21cef7a7e2b4b8c96c1f22c0d6210bb91e96
Issue-ID: CCSDK-157
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 19 Dec 2017 17:30:19 +0000 (12:30 -0500)]
Fix logging filters
Update logging filters package to handle X-Forwarded-For header and
to correct timestamp format.
Change-Id: I6b4dba94cc93d0936598a9b8cd568b6386a447a5
Issue-ID: CCSDK-155
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 18 Dec 2017 20:01:10 +0000 (15:01 -0500)]
Support additional IETF types
Support additional IETF types in MdsalHelper.
Change-Id: I1d0b4ab28645435d1ef72bc30a053d796aea44c8
Issue-ID: CCSDK-155
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 18 Dec 2017 16:58:35 +0000 (11:58 -0500)]
Service logic logging fixes
Update MetricLogger class to properly escape characters within body
of response. Also, used SvcLogicGraph.toString method to simplify
logging call.
Change-Id: I6bcaaf3c67032df041c6d37372016990ff0199d3
Issue-ID: CCSDK-152
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 5 Dec 2017 16:50:42 +0000 (11:50 -0500)]
SLI parser improvements
Update SLI parser to remove validation based on NODE_TYPE table, which
is no longer needed (was introduced prior to use of XSD schema
validation). Also, use checksums to avoid needless recompilation
if version being loaded already exists in database.
Change-Id: Idfcba94de8fb71b17d5e0c5e69e04dee266988b1
Issue-ID: CCSDK-152
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 21 Nov 2017 20:29:19 +0000 (15:29 -0500)]
Fix version.properties
Reset patch version in version.properties to zero
Change-Id: If331cd45026f27b1232621535b2d7facf3bbd387
Issue-ID: CIMAN-120
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 20 Nov 2017 20:10:26 +0000 (15:10 -0500)]
Update parent version
Parent version should be 1.2.0, not 1.2.1-SNAPSHOT
Change-Id: I678f264135223d45bb632df86d2854bbb51307e3
Issue-ID: CIMAN-120
Signed-off-by: Dan Timoney <dtimoney@att.com>
Jessica Wagantall [Sat, 18 Nov 2017 00:51:44 +0000 (16:51 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching. (part 2)
Change-Id: Ib9f7cf7f98feb159ce1b136a3cd792820c99e659
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jessica Wagantall [Fri, 17 Nov 2017 07:48:25 +0000 (23:48 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: Ifa47aa1d818d4a632afb02ec342124678ad855e1
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Rich Bennett [Wed, 15 Nov 2017 11:50:18 +0000 (06:50 -0500)]
Rm docs in repo consolidated w/ ccsdk/distribution
Change-Id: I573779aa46dfbf9f1c7956ecf0e4eedf16184417
Issue-ID: DOC-130
Signed-off-by: Rich Bennett <rb2745@att.com>
Dan Timoney [Thu, 9 Nov 2017 12:47:33 +0000 (12:47 +0000)]
Merge "Update version.properties"
Dan Timoney [Thu, 9 Nov 2017 12:30:49 +0000 (07:30 -0500)]
Update version.properties
Change version.properties to next release
Change-Id: I99fc70938511254d126a9220f4cef71fce551efe
Issue-ID: CCSDK-141
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Thu, 9 Nov 2017 12:14:12 +0000 (12:14 +0000)]
Merge "Roll version to 0.1.3-SNAPSHOT"
Dan Timoney [Wed, 8 Nov 2017 22:10:13 +0000 (17:10 -0500)]
Roll version to 0.1.3-SNAPSHOT
Roll to next snapshot version to prepare for release cut
Change-Id: I2a4c8395630b461314291bc8e0f83bf114a21f61
Issue-ID: CCSDK-141
Signed-off-by: Dan Timoney <dtimoney@att.com>
Morgan Richomme [Wed, 8 Nov 2017 07:53:23 +0000 (08:53 +0100)]
Fix Doc8 errors
JIRA: CCSDK-139
Change-Id: I5b48d4189ae9fdd72bb85a4d98be7798452249df
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
Dan Timoney [Wed, 25 Oct 2017 19:21:43 +0000 (15:21 -0400)]
Use version 0.1.0 of parent
Update to use version 0.1.0 (released version) of parent pom
Change-Id: I3b62a0cab11425ae9eb7e074aa1c23585aede1c4
Issue-ID: CCSDK-80
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 25 Oct 2017 18:08:31 +0000 (14:08 -0400)]
Add unit test case for PrintYangToProp
Add junit testing for PrintYangToProp
Change-Id: I8c377bb51c812ea9ead32d8e9d5ef871157162a8
Issue-ID: CCSDK-129
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 25 Oct 2017 16:04:26 +0000 (12:04 -0400)]
Fix parent tag in utils/provider
utils/provider parent should be utils, not ccsdk-sli-core. This was
breaking release build.
Change-Id: I3910189f9a989f93a0a8af4cb5a8512f0e9aca7a
Issue-ID: CCSDK-80
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 25 Oct 2017 00:19:45 +0000 (20:19 -0400)]
Fix release version
version.properties contains wrong setting for release version
Change-Id: Id76da3e2ad9009845e99ac1442cb66514733461c
Issue-ID: CCSDK-80
Signed-off-by: Dan Timoney <dtimoney@att.com>
Sheshi Chinthakayala [Wed, 18 Oct 2017 20:55:47 +0000 (15:55 -0500)]
added code to convert yang to properties
this code is used by dgbuilder to convert the yang to context property names
Change-Id: Ib53f57df6e8bd32a3a1b7ba6fa7854497c1f5c6c
Issue-ID: SDNC-81
Signed-off-by: Sheshi Chinthakayala <sc2914@att.com>
surya-huawei [Thu, 12 Oct 2017 06:18:42 +0000 (11:48 +0530)]
Add @Override annotation
*This is improve readability of source code
Issue-Id: CCSDK-117
Change-Id: I4bb73a6e4b440ae861045c7548a7e985d1fbf02c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Wed, 11 Oct 2017 15:01:38 +0000 (11:01 -0400)]
Add readthedocs info to sli/core
Add additional information to sli/core readthedocs documentation.
Change-Id: I9fe5e6185061ed6a05f373b6667f686e11d5f0aa
Issue-ID: CCSDK-107
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 10 Oct 2017 20:59:25 +0000 (16:59 -0400)]
Add readthedocs templates
Add readthedocs templates for sli/core
Change-Id: I2efaad7720997ef51c4dcb9036de5011bc6a1c4b
Issue-ID: CCSDK-107
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 3 Oct 2017 23:14:56 +0000 (23:14 +0000)]
Merge "SLI-API northbound add to docs"
Dan Timoney [Tue, 3 Oct 2017 13:35:52 +0000 (13:35 +0000)]
Merge "Add unit tests for dblib"
Dan Timoney [Tue, 3 Oct 2017 12:17:38 +0000 (08:17 -0400)]
Add unit tests for dblib
Add unit test case for dblib/provider, using MariaDB4J as database.
Change-Id: I18492595a9d54999c3d52b56ecfe33d0d2cae019
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
surya-huawei [Tue, 3 Oct 2017 10:39:04 +0000 (16:09 +0530)]
Add unit test for ccsdk/core
*Add a unit test for SliStringUtils
This is to test substring method of SliStringUtils
and improve code coverage
Issue-Id: CCSDK-106
Change-Id: I73c5af3b036a92fdcb1d3d1be7eb0b3abc44fd5a
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Mon, 2 Oct 2017 21:17:10 +0000 (17:17 -0400)]
Add test cases for MdsalHelper
Fix test case for loadProperties, and added test cases for IpAddress
types
Change-Id: Iabf182d32ae3937871dc9656105fdda0c1a9411f
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 2 Oct 2017 19:48:23 +0000 (15:48 -0400)]
Add test cases for MdsalHelper
Add test cases for MdsalHelper methods toBuilder() and toProperties().
This requires a Yang model, so added a copy of sliapi/model to sli, since
could not use sliapi directly otherwise would create circular
dependency (since sliapi depends on sli).
Change-Id: I4824afe250f93428c73dbeec9f4a4c36ee4f76e6
Issue-ID: CCSDK-106
Signed-off-by: Dan Timoney <dtimoney@att.com>
Brian Freeman [Thu, 28 Sep 2017 20:31:06 +0000 (20:31 +0000)]
SLI-API northbound add to docs
Issue-ID: CCSDK-107
Change-Id: Ic4a41466288229140ae3cad79e650d14c7877cc9
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Thu, 28 Sep 2017 13:03:22 +0000 (13:03 +0000)]
Merge "Added @Override annotation"
Dan Timoney [Thu, 28 Sep 2017 13:03:11 +0000 (13:03 +0000)]
Merge "Fix major sonar issue"
Brian Freeman [Thu, 28 Sep 2017 12:01:42 +0000 (12:01 +0000)]
Setup ReadTheDocs
Issue-ID: CCSDK-107
Change-Id: I6f09524c02f899bd4e6df82e6eda8e94518fe8ec
Signed-off-by: Brian Freeman <bf1936@att.com>
Dan Timoney [Thu, 28 Sep 2017 07:21:00 +0000 (07:21 +0000)]
Merge "Remove redundant casts"
surya-huawei [Thu, 28 Sep 2017 06:01:42 +0000 (11:31 +0530)]
Remove redundant casts
*Remove unnecessary cast to "CachedDataSource"
These unnecessary casting expressions maked the
code harder to read and understand
*Replace type specification with diamond operator
This is to reduce the verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: I6cd2f7d16886ffa6cc26e5dd300b8376705d9366
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
shashikanth [Wed, 27 Sep 2017 11:42:46 +0000 (17:12 +0530)]
Added @Override annotation
Fix major sonar issues in ccsdk/sli/core module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161
Add the "@Override" annotation above this method signature
Issue-Id:CCSDK-67
Change-Id: I233be3f88547049a5f78c438e87f2f8c0129df78
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Rich Tabedzki [Thu, 28 Sep 2017 03:00:10 +0000 (03:00 +0000)]
Refined DBLIB blueprint configuration
Changes made:
1. updated DBLibService definition by registering service on two interfaces:
a) javax.sql.DataSource
b) org.onap.ccsdk.sli.core.dblib.DbLibService
Change-Id: If187b07db83ebca5428c809a83f546d9178a2b7f
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
Dan Timoney [Wed, 27 Sep 2017 19:31:23 +0000 (19:31 +0000)]
Merge "Refinements to core"
surya-huawei [Tue, 26 Sep 2017 07:31:50 +0000 (13:01 +0530)]
Add unit test for SliStringUtils
*Made quotedOrNull method public
This is done for accessing this in ut
*Added a unit test for the SliStringUtils.quotedOrNull()
This is done for increasing code coverage
Issue-Id: CCSDK-106
Change-Id: I9d74c6645256227b23beded5179fbb28ac3d3c04
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
shashikanth [Wed, 27 Sep 2017 11:01:12 +0000 (16:31 +0530)]
Fix major sonar issue
Fix major sonar issues in ccsdk/sli/core module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=MAJOR|rules=squid%3AS1161
Add the "@Override" annotation above this method signature.
Issue-Id:CCSDK-67
Change-Id: Ie074574c7bbd2ca394d116e73aa6aab47ad5b8de
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Gaurav Agrawal [Wed, 27 Sep 2017 10:43:04 +0000 (16:13 +0530)]
Refinements to core
Changes includes:
1. Simplifying the test cases.
2. Critical Sonar issue fix for MdsalHelper
3. Critical sonar issue fix for SvcLogicServiceImpl
4. Use logger in-built formatting.
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL
Change-Id: Ib85637fcd2351970f8d96bf6b855db05cf7d9834
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Dan Timoney [Wed, 27 Sep 2017 07:53:31 +0000 (07:53 +0000)]
Merge "Use Long.toString instead"
Dan Timoney [Wed, 27 Sep 2017 07:47:35 +0000 (07:47 +0000)]
Merge "Some minor refinements in CCSDK SLI Core module"
Dan Timoney [Wed, 27 Sep 2017 07:47:00 +0000 (07:47 +0000)]
Merge "Remove hardcoded dependency versions"
Dan Timoney [Wed, 27 Sep 2017 07:44:46 +0000 (07:44 +0000)]
Merge "Fixes for SvcLogicActivator"
surya-huawei [Mon, 25 Sep 2017 09:26:04 +0000 (14:56 +0530)]
Use Long.toString instead
Major sonar issue in sli/core module
*Using static method to reduce
memory and cycles
Issue-Id: CCSDK-87
Change-Id: Iaf255892a4bd698934f865a707e54f8e740370ab
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Rich Tabedzki [Tue, 26 Sep 2017 17:19:32 +0000 (17:19 +0000)]
Updated DBLIB svc definition
Changes made:
1. updated DBLibService definition by adding javax.sql.DataSource
Change-Id: I5dd63a81420f451b0ce9bbbc878d351d62ccd819
Issue-ID: CCSDK-102
Signed-off-by: Rich Tabedzki <richard.tabedzki@att.com>
ramu.n [Mon, 25 Sep 2017 11:22:45 +0000 (16:52 +0530)]
Some minor refinements in CCSDK SLI Core module
*Remove useless braces while logging exception stack trace
*Register all DG nodes in SvcLogicParser Test file
Change-Id: I7916bec20e36e1def15c24806da2f7e01e79bf4b
Issue-Id: CCSDK-106
Signed-off-by: Ramu N <ramu.n@huawei.com>
Gaurav Agrawal [Mon, 25 Sep 2017 09:18:42 +0000 (14:48 +0530)]
Remove hardcoded dependency versions
Remove the hardcoded junit & common-lang version and rather take from parent pom.
Change-Id: Ibc71ff4b86a2fefc89365017f06333776cb2fed3
Issue-Id: CCSDK-105
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Mon, 25 Sep 2017 07:28:52 +0000 (12:58 +0530)]
Fixes for SvcLogicActivator
1. Convert tabs to 4 spaces.
2. Break lines to be less than 120 characters
3. Remove extraneous spaces/parenthesis & redundant assignments.
4. Use logger built-in string format.
5. Fix critical sonar issues.
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#resolved=false|severities=CRITICAL
Change-Id: Idb348f125e92f0e9be30847c41b385411220fd96
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
ramu.n [Sat, 23 Sep 2017 16:58:03 +0000 (22:28 +0530)]
Some minor refinements in CCSDK SLI Core module
Fix few Critical/Major sonar issues in CCSDK SLI Core module
* Define and throw a dedicated exception instead of using a generic one
* Either log or rethrow the exception
* Change "try" to a try-with-resources
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
Change-Id: I83dc1fb931b8021118e259c722f7dfbc1621dce8
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
Patrick Brady [Fri, 22 Sep 2017 16:41:20 +0000 (09:41 -0700)]
Changes to fix failing utils feature
Change-Id: I88d30aaf49da78008c62352d398323fbc0d4dd5b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-id: CCSDK-102
Dan Timoney [Fri, 22 Sep 2017 12:12:53 +0000 (12:12 +0000)]
Merge "Add "@Override" annotation"
Dan Timoney [Fri, 22 Sep 2017 12:09:12 +0000 (12:09 +0000)]
Merge "Resolved sonar issue."