ccsdk/sli/core.git
6 years agoRemove unused imports in java files 31/12031/2
Ryan Goulding [Tue, 12 Sep 2017 19:13:44 +0000 (15:13 -0400)]
Remove unused imports in java files

Code sanitation-- remove unused imports.

Issue-Id: SDNC-79
Change-Id: I5306a9b90f302086459fcac98d04f541ba7c79a4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
6 years agoFix Sonar issues 47/11647/3
surya-huawei [Mon, 11 Sep 2017 11:06:49 +0000 (16:36 +0530)]
Fix Sonar issues

Few major issues in sli/core module

Issue-id: CCSDK-67
Change-Id: Iad65b30a6b27814c1984d8db42d36f8569c5cb3f
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoMerge "Fix Blocker/Critical sonar issues"
Dan Timoney [Mon, 11 Sep 2017 20:25:48 +0000 (20:25 +0000)]
Merge "Fix Blocker/Critical sonar issues"

6 years agoRemove cast to DBResourceManager 99/11699/2
Dan Timoney [Mon, 11 Sep 2017 15:19:51 +0000 (11:19 -0400)]
Remove cast to DBResourceManager

Remove cast to DBResourceManager, which no longer works after
DbLibService is advertised via Aries Blueprint and which is no
longer needed after DbLibService interface exposes getConnection()
method.
Updated version number - seems like an older 0.1.1-SNAPSHOT without
DbLibService change is being used, so trying to see if bumping version will
help.

Change-Id: Ia411d1514bca396cc052f4f16eda6c79e0d13648
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoMerge "Expose getConnection from DblibSeervice"
Dan Timoney [Mon, 11 Sep 2017 15:15:31 +0000 (15:15 +0000)]
Merge "Expose getConnection from DblibSeervice"

6 years agoExpose getConnection from DblibSeervice 53/11453/2
Dan Timoney [Fri, 8 Sep 2017 22:52:46 +0000 (18:52 -0400)]
Expose getConnection from DblibSeervice

Exposed getConnection from DbLibService class so that it can be accessed
from OSGi client.  Prior to blueprint refactoring, this was accessible
by casting DbLibService as DBResourceManager, but that cast no longer
works if OSGi service is advertised by blueprint.  It's cleaner to expose
that method in the interface anyway.

Change-Id: I36ed7fe82b0393a952d307a1c79d1d8c0ba11dd4
Issue-ID: CCSDK-86
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoCleanup project's name in Sonar 91/11391/1
Jessica Wagantall [Fri, 8 Sep 2017 21:49:09 +0000 (14:49 -0700)]
Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: I73a561752044b0d1b03a1b52f4b432f4c3329269
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoMerge "Fix Sonar issues within SliPluginUtils module"
Dan Timoney [Fri, 8 Sep 2017 14:05:15 +0000 (14:05 +0000)]
Merge "Fix Sonar issues within SliPluginUtils module"

6 years agoFix Blocker/Critical sonar issues 13/10813/5
shashikanth [Thu, 7 Sep 2017 12:45:52 +0000 (18:15 +0530)]
Fix Blocker/Critical sonar issues

Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.onap.ccsdk.sli.core%3Accsdk-sli-core#severities=BLOCKER

Issue-Id: CCSDK-67
Change-Id: I9f1a7dc8144a2a3a777a2a4f24793bbf9317de33
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
6 years agoFix Sonar issues within SliPluginUtils module 97/10897/2
Arun S. Yerra [Thu, 7 Sep 2017 18:09:06 +0000 (11:09 -0700)]
Fix Sonar issues within SliPluginUtils module

Sonarqube report for SliPluginUtils identified some critical bugs. This fix will address these bugs.

Issue-Id: CCSDK-81

Change-Id: I9a1738c02f1364b17a0895b94f26c373e4a19f1f
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
6 years agoFix sonar blocker issues in ccsdk/core module 53/10953/1
Arun S. Yerra [Thu, 7 Sep 2017 23:21:23 +0000 (16:21 -0700)]
Fix sonar blocker issues in ccsdk/core module

Sonarqube report for CCSDK core identfied some blcoker issues. This fix addresses those bugs.

Issue-Id: CCSDK-84

Change-Id: Ie6ff19b7b0815a129f9809243e8e3eb0a64144ab
Signed-off-by: Arun S. Yerra <arun.yerra@huawei.com>
6 years agoMerge "Update dblib service name"
Dan Timoney [Thu, 7 Sep 2017 19:21:32 +0000 (19:21 +0000)]
Merge "Update dblib service name"

6 years agoUpdate dblib service name 03/10903/1
Dan Timoney [Thu, 7 Sep 2017 18:55:19 +0000 (14:55 -0400)]
Update dblib service name

Update name of dblib service to match the DbLibService interface name
rather than implemtation class (previous advertised name).

Change-Id: I999298c089e75fe3bd467241a473abcc04138852
Issue-ID: CCSDK-83
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoMerge "Fix SDNC service registration"
Dan Timoney [Thu, 7 Sep 2017 18:19:07 +0000 (18:19 +0000)]
Merge "Fix SDNC service registration"

6 years agoFix SDNC service registration 55/10855/1
Ryan Goulding [Thu, 7 Sep 2017 14:38:44 +0000 (10:38 -0400)]
Fix SDNC service registration

Fix the aaaUserName constant.

Change-Id: I4d9272e476874f6a7747970bc67f8f88ff803f21
Issue-Id: SDNC-54
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
6 years agoMerge "Fix service registration for SDNC"
Dan Timoney [Wed, 6 Sep 2017 23:16:05 +0000 (23:16 +0000)]
Merge "Fix service registration for SDNC"

6 years agoMerge "Enable surefire unit testing"
Dan Timoney [Wed, 6 Sep 2017 23:15:35 +0000 (23:15 +0000)]
Merge "Enable surefire unit testing"

6 years agoEnable surefire unit testing 27/10027/2
Marcus G K Williams [Fri, 1 Sep 2017 22:44:56 +0000 (15:44 -0700)]
Enable surefire unit testing

Issue-Id: CCSDK-67
Change-Id: I3d03ff1a3e312edd4af7ab69508760d2fe49be78
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoFix SDNC service registration 99/10599/1
Ryan Goulding [Wed, 6 Sep 2017 16:03:51 +0000 (12:03 -0400)]
Fix SDNC service registration

Convert the BundleActivator to a POJO provider, and do the service registration
through blueprint instead.

Issue-Id: SDNC-54
Change-Id: Ia5618ef443967803b31da1ac9e020d1092c3ab8d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
6 years agoFix service registration for SDNC 97/10597/1
Ryan Goulding [Wed, 6 Sep 2017 15:47:00 +0000 (11:47 -0400)]
Fix service registration for SDNC

sliPluginUtils was using a BundleActivator for Service Instantiation, which
is prone to heisenbugs due to indeterminate service instantiation logic.  This
removes the BundleActivator and instantiates services using blueprint.

Since dme2.properties are parsed using Properties instead of using a
ManagedService, the decision was to just keep them immutable.

Future work may involve making instance variables private in DME2, since
currently Dme2Test performs direct member access on DME2 instance variables
which is considered bad practices (violates encapsulation).

Issue-Id: SDNC-54
Change-Id: Ib1155565e04e9a95d222bc4028a0845d9d81bd82
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
6 years agoFix service registration for SDNC 31/7931/8
Ryan Goulding [Thu, 17 Aug 2017 20:15:39 +0000 (16:15 -0400)]
Fix service registration for SDNC

Addresses the inherit race conditions associated with the
BundleActivator abstraction.  From lessons learned in OpenDaylight
project, dependency injection and service injection via Aries Blueprint
is faster, more deterministic, and has better error messaging than
using BundleActivator(s).

This change addresses several aspects:
1) DBLIBResourceActivator is changed to DBLIBResourceProvider.
   This was done in order to imply that this is no longer an
   Activator or subclass of an Activator.  The class is a POJO.
2) DBLIBResourceProvider is split from a single monolithic method
   into several more manageable and better documented methods.
3) Documentation surrounding the resolution of the DB properties
   is added so that a developer can more easily identify the
   strategy (priority) used for resolving properties.
4) dblib-blueprint.xml is added.  This is used to register the
   configuration bean (DBLIBResourceProvider), and pass it as
   an argument to the actual Service (DBLIBResourceManager).
5) Tests are added to test the functionality and resolution of
   the properties file loading.

Issue-Id: SDNC-54
Change-Id: Ie9d5fb423ae7a67e9aec026c78321537399cc308
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
6 years agoMerge "Update mvn name in POM to CCSDK"
Dan Timoney [Fri, 1 Sep 2017 23:23:41 +0000 (23:23 +0000)]
Merge "Update mvn name in POM to CCSDK"

6 years agoUpdate mvn name in POM to CCSDK 11/10011/1
Marcus G K Williams [Fri, 1 Sep 2017 21:56:46 +0000 (14:56 -0700)]
Update mvn name in POM to CCSDK

Issue-Id: CCSDK-67
Change-Id: Ie0413cd3099cdebac81b0586789354a1c98d0a31
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoAdd missing implementation code 47/9747/1
Dan Timoney [Thu, 31 Aug 2017 19:28:01 +0000 (15:28 -0400)]
Add missing implementation code

Due to an error in .gitignore, code that is initially generated from
provider yang, but then customized was not submitted to gerrit.  This
in turn is causing the UnsupportedOperationException seen when sliapi
installs in odlsli container.

Change-Id: Iceec13b59e5e2bd6f0b868b548d300b76c7f7a38
Issue-ID: CCSDK-69
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRoll version to rule out staging issue 21/9521/2
Dan Timoney [Wed, 30 Aug 2017 20:22:00 +0000 (16:22 -0400)]
Roll version to rule out staging issue

Behavior observed in the odlsli docker container suggests that it might
be picking up an old build of 0.1.0-SNAPSHOT version of sli/core.  We
have observed this problem before due to issues with the Nexus staging
plugin.  This change bumps the version of sli/core to 0.1.1-SNAPSHOT and
comments out the staging plugin from the sli/core pom.xml to make sure
that the current build is picked up.  There will be a corresponding
change in ccsdk/distribution to change which version of sli/core is used
in the odlsli container

Change-Id: Ie3c2b4ff66191748df14240a69a7d461fc0d4639
Issue-ID: CCSDK-69
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoMerge "Change 2 sli/core unit tests to int. tests"
Dan Timoney [Tue, 29 Aug 2017 19:43:45 +0000 (19:43 +0000)]
Merge "Change 2 sli/core unit tests to int. tests"

6 years agoCleanup artifactId for ccsdk/sli/core 99/9099/2
Dan Timoney [Tue, 29 Aug 2017 12:41:38 +0000 (08:41 -0400)]
Cleanup artifactId for ccsdk/sli/core

ArtifactId for ccsdk/sli/core pom.xml should not be identical to that for
sdnc/core, otherwise import to Eclipse of both will be confusing.
Update parent tag in each module pom under ccsdk/sli/core to new
artifactId

Change-Id: Ia78a11dc4f82dfda8fd863167daa8e8f4951b6f5
Issue-ID: CCSDK-70
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoChange 2 sli/core unit tests to int. tests 77/8977/2
Marcus G K Williams [Mon, 28 Aug 2017 20:48:06 +0000 (13:48 -0700)]
Change 2 sli/core unit tests to int. tests

Change SvcLogicGraphExecutorTest and
SvcLogicParserTest to IT Tests because
they require outside dependencies (sql database).
This change enables running jobs without
skipping tests and futher enables SONAR scans
of unit tests.

Issue-Id: CCSDK-67
Change-Id: I74184b2f2d8cb5fcc7b065c3e2e859b85dd1630b
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoRemove license plugin 53/7653/1
Dan Timoney [Tue, 15 Aug 2017 20:21:10 +0000 (16:21 -0400)]
Remove license plugin

Remove license plugin from parent POMs.

Change-Id: Ia626a424dbb04511d5e31483134384efbe259fe7
Issue-ID: CCSDK-31
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix license headers 05/7605/1
Dan Timoney [Tue, 15 Aug 2017 13:55:50 +0000 (09:55 -0400)]
Fix license headers

Licence headers were accidentally updated incorrectly by previous update.
This commit restores the license headers for seed code to the wording from
the original seed code

Change-Id: Ie73bc836079be7eb1b310c472ee39b58ffeaa01c
Issue-ID: CCSDK-31
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoCompile against Carbon 17/7417/1
Dan Timoney [Sat, 12 Aug 2017 00:12:41 +0000 (20:12 -0400)]
Compile against Carbon

Update sli/core to compile against OpenDaylight Carbon SR1

Change-Id: Ibb4a3a4cfa64f0539b520f56f11d7bf1fce62357
Issue-ID: CCSDK-23
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRemove remaining references to openecomp 99/7399/1
Dan Timoney [Fri, 11 Aug 2017 19:57:21 +0000 (15:57 -0400)]
Remove remaining references to openecomp

Remove remaining references to openecomp from properties and sample files

Change-Id: I985bae5e80ae130ffb512c9574f13172252bf6f8
Issue-ID: CCSDK-11
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRemove openecomp documentation references 63/7363/1
Dan Timoney [Fri, 11 Aug 2017 15:26:18 +0000 (11:26 -0400)]
Remove openecomp documentation references

Removed openecomp references from site documentation.
Also, removed sample settings.xml files.  Latest direction from Linux
Foundation is that the settings.xml configs they provided on their Jenkins
will have no parameter settings - only server credentials.  So, our sample
settings.xml files are only misleading and hence should be removed.

Change-Id: I4f663973ac07b6d78dffb93aef478a81d2a4450c
Issue-ID: CCSDK-11
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRefactor sliPluginUtils package names 67/6867/1
Dan Timoney [Mon, 7 Aug 2017 19:02:16 +0000 (15:02 -0400)]
Refactor sliPluginUtils package names

Update Java package names from org.openecomp to org.onap

Issue: CCSDK-11
Change-Id: I7e318565197b5806f6a7d7131bd3118fbe9cf8e0
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoChange sliapi package names 79/6679/2
Dan Timoney [Thu, 3 Aug 2017 20:19:36 +0000 (16:19 -0400)]
Change sliapi package names

Change package names on ccsdk/sli/core/sliapi from org.openecomp.sdnc.* to org.onap.ccsdk.*

Issue: CCSDK-11
Change-Id: I152a884c4b418c48e5bebc09aaa470ee86cd46e7
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix unit tests 71/6671/1
Dan Timoney [Thu, 3 Aug 2017 18:55:32 +0000 (14:55 -0400)]
Fix unit tests

Corrected typo in jUnit test cases for SLI MdsalHelper class

Issue: CCSDK-57
Change-Id: Id014ed5f8855494daafd12aee436880d76c5a1fe
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRefactor dblib 11/6311/3
Dan Timoney [Thu, 27 Jul 2017 20:32:20 +0000 (16:32 -0400)]
Refactor dblib

Changed openecomp references in dblib, filters and sli to onap.  Note: these
must be committed together to get a clean compile.

Issue: CCSDK-11
Change-Id: Ibe0f64fb20f3ae9cdda2f7ea969ca722bbde0d15
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUpdate groupId to org.onap.ccsdk.sli 47/6147/1
Dan Timoney [Fri, 21 Jul 2017 14:45:06 +0000 (10:45 -0400)]
Update groupId to org.onap.ccsdk.sli

Update groupIds from org.openecomp.sdnc.core to org.onap.ccsdk.sli.core

Issue: CCSDK-11
Change-Id: I0646adab34a88244ab10dc0d2775643ce2bb974d
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix mvn deploy 41/6141/1
Dan Timoney [Fri, 21 Jul 2017 12:34:58 +0000 (08:34 -0400)]
Fix mvn deploy

Mvn deploy failed due to credentials issue.  Seems like distributionManagement section from parent pom was not processed correctly.  Copied that section to top level pom.xml

Issue: CCSDK-6
Change-Id: Ib508169bd3cc93ffd82aa0b865cea441b0e30c9b
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoPopulate seed code 97/5997/3
Dan Timoney [Tue, 18 Jul 2017 23:40:01 +0000 (19:40 -0400)]
Populate seed code

Add seed code for sli/core repository

Issue: CCSDK-6
Change-Id: Iaeb54c6135a94a6ffec0c7fd96505d72d18aeb00
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years agoInitial empty repository
Jessica Wagantall [Tue, 27 Jun 2017 21:35:09 +0000 (21:35 +0000)]
Initial empty repository