BharathS24 [Tue, 7 Aug 2018 06:00:20 +0000 (11:30 +0530)]
Sonar Minor issue
Move this constructor to comply with Java Code Conventions
Sonar Link : https://sonar.onap.org/issues?myIssues=true&open=AWEPiFEz-08if2a6xy_C&resolved=false
Location : src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTransactionDAO.java:L112
Issue-ID: DCAEGEN2-686
Change-Id: I47f08f63d12dc2d4f1246dcba2a4ed22e2488bae
Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
BharathS24 [Fri, 3 Aug 2018 15:09:44 +0000 (20:39 +0530)]
Sonar Minor issue
Move this constructor to comply with Java Code Conventions
Sonar Link : https://sonar.onap.org/issues?myIssues=true&open=AWEPiFEd-08if2a6xy-3&resolved=false
Location : src/main/java/org/onap/dcae/inventory/clients/DatabusControllerClient.java:L85
Change-Id: I418e842953c311a4284080837a2d4be178db4abf
Issue-ID: DCAEGEN2-652
Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
BharathS24 [Wed, 1 Aug 2018 06:24:46 +0000 (11:54 +0530)]
Sonar Minor issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link : https://sonar.onap.org/issues?myIssues=true&open=AWSYoWCJwGn37JfbvTzi&resolved=false
Location : src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java:L63
Change-Id: I63f664c345235a9e6a251170e9b165e6ff0936db
Issue-ID: DCAEGEN2-651
Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
Vijay Venkatesh Kumar [Fri, 27 Jul 2018 21:26:36 +0000 (21:26 +0000)]
Merge "Add INFO.yaml file"
BharathS24 [Fri, 27 Jul 2018 04:46:46 +0000 (10:16 +0530)]
Sonar Critical issue
Either log or rethrow this exception
Sonar link : https://sonar.onap.org/issues?myIssues=true&open=AWSYoWCawGn37JfbvTzk&resolved=false
Location : src/main/java/org/onap/dcae/inventory/exceptions/mappers/DBIExceptionMapper.java:L62
Change-Id: Ic2c2e1736acdcd60514e582f62a2de765d717508
Issue-ID: DCAEGEN2-634
Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
Jessica Wagantall [Fri, 4 May 2018 00:16:11 +0000 (17:16 -0700)]
Add INFO.yaml file
Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information
Change-Id: Ic4e0db436d57631e70408c1526e814fbbf77e298
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
BharathS24 [Thu, 26 Jul 2018 06:40:20 +0000 (12:10 +0530)]
Sonar minor issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link : https://sonar.onap.org/issues?myIssues=true&open=AWSYoWCawGn37JfbvTzj&resolved=false
Location : src/main/java/org/onap/dcae/inventory/exceptions/mappers/DBIExceptionMapper.java:L45
Change-Id: I079d1297ca7faf25ef7bf2aa7e716b96752a3d6c
Issue-ID: DCAEGEN2-636
Signed-off-by: BharathS24 <BS00493532@techmahindra.com>
Shadi Haidar [Fri, 13 Jul 2018 15:26:29 +0000 (11:26 -0400)]
InventoryAPI Syncup with ECOMP Logging
Issue-ID: DCAEGEN2-575
Change-Id: I9df025e3f8ddeb282f980758bdf1dc30491e0d01
Signed-off-by: Shadi Haidar <sh1986@att.com>
Jessica Wagantall [Thu, 5 Apr 2018 01:26:16 +0000 (18:26 -0700)]
Update docker tag convention
Update docker tagging convention to use:
v0.17.0-SNAPSHOT-YYYYMMDDTHHMMSSZ (for dev images)
v0.17.0-STAGING-YYYYMMDDTHHMMSSZ (for staging images)
Change-Id: I89bb50003c34a9b611e045c692705f03e57bd333
Issue-ID: CIMAN-132
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Lusheng Ji [Tue, 3 Apr 2018 02:50:25 +0000 (22:50 -0400)]
Fix docker tag based on CIMAN-132
Issue-ID: DCAEGEN2-206
Change-Id: I77e011fd61fa8947f20b1d3e05aab2cb64754287
Signed-off-by: Lusheng Ji <lji@research.att.com>
Michael Hwang [Wed, 28 Mar 2018 14:32:32 +0000 (10:32 -0400)]
Update hibernate-validator and jetty-util
Change-Id: I93beb063bf3a1e5394651065b42c3b5f1bc5407d
Issue-ID: DCAEGEN2-361
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Tue, 27 Mar 2018 14:34:21 +0000 (10:34 -0400)]
Upgrade httpcomponents to 4.5.5
Change-Id: I0cf9bb09fdf1a9563561556773a802ab970e9545
Issue-ID: DCAEGEN2-361
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Tue, 27 Mar 2018 14:17:38 +0000 (10:17 -0400)]
Use oparent 1.1.0
Change-Id: I33eab6a5926c171968a1770d783d59d5c1b53a73
Issue-ID: DCAEGEN2-422
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Thu, 22 Mar 2018 15:02:57 +0000 (11:02 -0400)]
Add unit tests to reach 50% coverage
Ripped out the dcae controller code which is no longer
needed.
Change-Id: I43906edb80bcd5e25445ec2a7175c6748b0ab2ae
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Issue-ID: DCAEGEN2-257
Lusheng Ji [Fri, 9 Mar 2018 16:42:15 +0000 (16:42 +0000)]
Merge "Sonar:Minor"
Lusheng Ji [Fri, 9 Mar 2018 16:42:05 +0000 (16:42 +0000)]
Merge "Sonar:Minor"
TECHMAHINDRA\BS00493532 [Tue, 6 Mar 2018 03:46:48 +0000 (09:16 +0530)]
Sonar:Minor
Remove this unused import 'java.sql.SQLException'
StringListArgument.java:L29
Sonar link : https://sonar.onap.org/issues?myIssues=true&resolved=false
Location : src/main/java/org/onap/dcae/inventory/dbthings/StringListArgument.java
Change-Id: Id3b3c6d449c13d2bdfa9523239c5768dd55a64c8
Issue-ID: DCAEGEN2-382
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Bharath Thiruveedula [Mon, 5 Mar 2018 18:40:51 +0000 (00:10 +0530)]
Fix Sonar Issue
Rename "jdbi" which hides the field declared at line 68
Link: https://sonar.onap.org/project/issues?id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFFX-08if2a6xy_T&resolved=false&severities=MAJOR
Change-Id: Iae7765c0d58be81b02977f2a3e9c300a8e4c757b
Issue-ID: DCAEGEN2-380
Signed-off-by: Bharath Thiruveedula <bharath_ves@hotmail.com>
TECHMAHINDRA\BS00493532 [Mon, 5 Mar 2018 05:09:16 +0000 (10:39 +0530)]
Sonar:Minor
Remove this unused import 'java.util.Locale'
DcaeServiceTypesApiServiceImpl.java:L45
Sonar link : https://sonar.onap.org/project/issues?id=org.onap.dcaegen2.platform%3Ainventory-api&myIssues=true&resolved=false
Location : src/main/java/io/swagger/api/impl/DcaeServiceTypesApiServiceImpl.java
Change-Id: I0de8e5db8a214506003239eb4d89c95fbb5e1253
Issue-ID: DCAEGEN2-365
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Tony Hansen [Wed, 14 Feb 2018 03:00:52 +0000 (03:00 +0000)]
Merge "sonar issue"
Tony Hansen [Wed, 14 Feb 2018 03:00:22 +0000 (03:00 +0000)]
Merge "sonar issue"
Tony Hansen [Wed, 14 Feb 2018 02:59:59 +0000 (02:59 +0000)]
Merge "sonar issue"
Tony Hansen [Wed, 14 Feb 2018 02:59:23 +0000 (02:59 +0000)]
Merge "sonar issue"
Snigdha Sucharita Patra [Tue, 13 Feb 2018 04:03:03 +0000 (09:33 +0530)]
sonar issue
Modifiers should be declared in the correct order
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFG6-08if2a6xy_o&resolved=false&severities=MINOR
Location:
src/.../inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-79
Change-Id: Idaa98367cb658c8ce6d1d4e026ad3762a30c25e0
Issue-ID: DCAEGEN2-333
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Tue, 13 Feb 2018 03:48:07 +0000 (09:18 +0530)]
sonar issue
Modifiers should be declared in the correct order
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFG6-08if2a6xy_n&resolved=false&severities=MINOR
Location:
src/.../inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-76
Change-Id: I8973b95dcacd81ad5343fc0248ff90b8c1eb35d8
Issue-ID: DCAEGEN2-332
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Tue, 13 Feb 2018 03:32:19 +0000 (09:02 +0530)]
sonar issue
Modifiers should be declared in the correct order
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFG5-08if2a6xy_m&resolved=false&severities=MINOR
Location:
src/main/java./inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-73
Change-Id: Ib7371864a47a7b5d6ee160083b4034a6fa17c65f
Issue-ID: DCAEGEN2-331
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Tue, 13 Feb 2018 03:09:48 +0000 (08:39 +0530)]
sonar issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFG5-08if2a6xy_l&resolved=false&severities=MINOR
Location:
src/main/java/inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-45
Change-Id: I45d24bbaaeafdbdefad43d320b09c5d913f133dc
Issue-ID: DCAEGEN2-330
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Vijay Venkatesh Kumar [Mon, 12 Feb 2018 17:52:25 +0000 (17:52 +0000)]
Merge "Update license text"
Vijay Venkatesh Kumar [Mon, 12 Feb 2018 17:30:05 +0000 (17:30 +0000)]
Merge "Sonar Minor fix"
Vijay Venkatesh Kumar [Mon, 12 Feb 2018 17:29:10 +0000 (17:29 +0000)]
Merge "Sonar Minor fix"
Vijay Venkatesh Kumar [Mon, 12 Feb 2018 17:22:54 +0000 (17:22 +0000)]
Merge "sonar issue"
Vijay Venkatesh Kumar [Mon, 12 Feb 2018 17:22:41 +0000 (17:22 +0000)]
Merge "sonar issue"
Lusheng Ji [Mon, 12 Feb 2018 16:04:43 +0000 (11:04 -0500)]
Update license text
Change-Id: I144caa01202a5159c9f7ae0aba170dce9b423e6b
Signed-off-by: Lusheng Ji <lji@research.att.com>
Issue-ID: DCAEGEN2-325
Pooja03 [Mon, 12 Feb 2018 11:02:19 +0000 (16:32 +0530)]
Sonar Minor fix
return the expression instead of assigning it to the temporary variable argument
Sonar Link:https://sonar.onap.org/project/issues?assignees=Pooja03&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWGBruv68TZzbCgU6dMs&resolved=false
Location:StringListArgument.java:L51
Change-Id: Ia53255061c794925b95742a8d167943a0cb7caf9
Issue-ID: DCAEGEN2-329
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Snigdha Sucharita Patra [Mon, 12 Feb 2018 10:26:02 +0000 (15:56 +0530)]
sonar issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFFW-08if2a6xy_M&resolved=false&severities=MINOR
Location:
src/.../org/onap/dcae/inventory/daos/InventoryDAOManager.java
Line No-65
Change-Id: Icab62d6a464ecbb12c312c95c23659f5bf9b2cc8
Issue-ID: DCAEGEN2-328
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 12 Feb 2018 10:02:35 +0000 (15:32 +0530)]
sonar issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Snigdha503415&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFFW-08if2a6xy_L&resolved=false&severities=MINOR
Location:
src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java
line No-63
Change-Id: I2fc43f956e3deef460752800df38f586243f4768
Issue-ID: DCAEGEN2-327
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Mon, 12 Feb 2018 06:22:44 +0000 (11:52 +0530)]
Sonar Minor fix
Move the constructor to comply with Java Code Conventions
Sonar Link:https://sonar.onap.org/project/issues?assignees=Pooja03&id=org.onap.dcaegen2.platform%3Ainventory-api&open=AWEPiFEV-08if2a6xy-w&resolved=false
Location:DCAEControllerClient.java:L216
Change-Id: Icecca34621dac211a5fc409363dae40a5c3c6944
Issue-ID: DCAEGEN2-326
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Tony Hansen [Fri, 9 Feb 2018 18:54:28 +0000 (18:54 +0000)]
Merge "sonar issue"
Tony Hansen [Fri, 9 Feb 2018 18:54:17 +0000 (18:54 +0000)]
Merge "Modifiers should be declared in the correct order"
Snigdha Sucharita Patra [Fri, 9 Feb 2018 10:30:46 +0000 (16:00 +0530)]
sonar issue
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MINOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTransactionDAO.java
Line No-129
Change-Id: I3e9dd8748048a48e9216f01b18454c49db12a4cb
Issue-ID: DCAEGEN2-324
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Fri, 9 Feb 2018 09:47:29 +0000 (15:17 +0530)]
Modifiers should be declared in the correct order
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MINOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTransactionDAO.java
Line No-126
Change-Id: I138543dca2ca1174068da18cfaa112c094ed3324
Issue-ID: DCAEGEN2-323
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Tony Hansen [Thu, 8 Feb 2018 15:38:52 +0000 (15:38 +0000)]
Merge "sonar Minor issues"
Tony Hansen [Thu, 8 Feb 2018 15:37:57 +0000 (15:37 +0000)]
Merge "sonar Minor issues"
Tony Hansen [Thu, 8 Feb 2018 15:35:58 +0000 (15:35 +0000)]
Merge "sonar Minor issues"
Snigdha Sucharita Patra [Thu, 8 Feb 2018 10:19:07 +0000 (15:49 +0530)]
sonar Minor issues
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MINOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTransactionDAO.java
Line No-123
Change-Id: Ibd913178e831ffccd2ea16d26ad0cfda831933f6
Issue-ID: DCAEGEN2-321
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Thu, 8 Feb 2018 09:26:44 +0000 (14:56 +0530)]
sonar Minor issues
Reorder the modifiers to comply with the Java Language Specification
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MINOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/clients/DCAEControllerClient.java
Line No-137
Change-Id: I2ae7e89be1e53fef8c0ad4206831c7a23f7e66f9
Issue-ID: DCAEGEN2-320
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Thu, 8 Feb 2018 07:07:12 +0000 (12:37 +0530)]
sonar Minor issues
Remove this unused import 'com.fasterxml.jackson.core.JsonProcessingException'
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=__me__%2CSnigdha503415
Location:
src/main/java/org/onap/dcae/inventory/LinkSerializer.java
Line No-24
Change-Id: I425a386a25e25e57120ca7ca61945ee2b7a32206
Issue-ID: DCAEGEN2-319
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Tony Hansen [Wed, 7 Feb 2018 15:33:51 +0000 (15:33 +0000)]
Merge "Sonar:Major"
Tony Hansen [Wed, 7 Feb 2018 15:33:13 +0000 (15:33 +0000)]
Merge "Sonar:Major"
Tony Hansen [Wed, 7 Feb 2018 15:32:41 +0000 (15:32 +0000)]
Merge "Sonar:Major"
Tony Hansen [Wed, 7 Feb 2018 15:31:32 +0000 (15:31 +0000)]
Merge "Sonar:Major"
Tony Hansen [Wed, 7 Feb 2018 15:30:38 +0000 (15:30 +0000)]
Merge "Sonar Major fix"
Pooja03 [Wed, 7 Feb 2018 10:24:23 +0000 (15:54 +0530)]
Sonar Major fix
Make the anonymous inner class a lambda in StringListArgument.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Pooja03
Location:StringListArgument.java:L48
Change-Id: I370a7efae998af0af9b625ec83433cd33439c8e8
Issue-ID: DCAEGEN2-318
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
TECHMAHINDRA\BS00493532 [Wed, 7 Feb 2018 09:12:04 +0000 (14:42 +0530)]
Sonar:Major
Add the @Override annotation above this method signature
DCAEServicesDAO.java:L45
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/org/onap/dcae/inventory/daos/DCAEServicesDAO.java
Change-Id: I2c3edd6e49f20937691fe49986481a58b7a01d9c
Issue-ID: DCAEGEN2-317
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
TECHMAHINDRA\BS00493532 [Wed, 7 Feb 2018 08:59:47 +0000 (14:29 +0530)]
Sonar:Major
Replace type specification with diamond operator
DcaeServicesApiServiceImpl.java:L336
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Change-Id: Iacbc9f6fefe15850beea5611915b936ba73ec57d
Issue-ID: DCAEGEN2-316
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
TECHMAHINDRA\BS00493532 [Wed, 7 Feb 2018 07:15:38 +0000 (12:45 +0530)]
Sonar:Major
Replace type specification with diamond operator
DcaeServicesApiServiceImpl.java:L305
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Change-Id: If46a8c533de9a33d244ef4b9a76c29195c691988
Issue-ID: DCAEGEN2-315
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
TECHMAHINDRA\BS00493532 [Wed, 7 Feb 2018 07:03:12 +0000 (12:33 +0530)]
Sonar:Major
Add the @Override annotation above this method signature
DCAEServicesComponentsMapsDAO.java:L37
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/org/onap/dcae/inventory/daos/DCAEServicesComponentsMapsDAO.java
Change-Id: I5fbba6f524b0bd29f155822f6601f2fdc2d7b5f8
Issue-ID: DCAEGEN2-314
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Tony Hansen [Tue, 6 Feb 2018 14:42:34 +0000 (14:42 +0000)]
Merge "Sonar Major fix"
Tony Hansen [Tue, 6 Feb 2018 14:39:57 +0000 (14:39 +0000)]
Merge "Sonar Major fix"
Tony Hansen [Tue, 6 Feb 2018 14:39:30 +0000 (14:39 +0000)]
Merge "Sonar Major fix"
Tony Hansen [Tue, 6 Feb 2018 14:38:40 +0000 (14:38 +0000)]
Merge "sonar Major issues"
Tony Hansen [Tue, 6 Feb 2018 14:37:46 +0000 (14:37 +0000)]
Merge "sonar Major issues"
Tony Hansen [Tue, 6 Feb 2018 14:37:01 +0000 (14:37 +0000)]
Merge "sonar Major issues"
Tony Hansen [Tue, 6 Feb 2018 14:36:16 +0000 (14:36 +0000)]
Merge "Sonar:Major"
Tony Hansen [Tue, 6 Feb 2018 14:35:37 +0000 (14:35 +0000)]
Merge "Sonar:Major"
TECHMAHINDRA\BS00493532 [Tue, 6 Feb 2018 09:48:16 +0000 (15:18 +0530)]
Sonar:Major
Replace type specification with diamond operator
DcaeServicesApiServiceImpl.java:L232
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Change-Id: I412690de378ff2ba550b2906d7a6861254ab83c7
Issue-ID: DCAEGEN2-313
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Pooja03 [Tue, 6 Feb 2018 09:48:05 +0000 (15:18 +0530)]
Sonar Major fix
Remove useless assignment to local variable columnName
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#severities=CRITICAL%2CMAJOR|resolved=false|assignees=Pooja03
Location:DcaeServicesGroupbyApiServiceImpl.java:L42
Change-Id: I9429dc91c7fdb08112f7b0baa89e7127c2261b75
Issue-ID: DCAEGEN2-310
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
TECHMAHINDRA\BS00493532 [Tue, 6 Feb 2018 09:31:52 +0000 (15:01 +0530)]
Sonar:Major
Add the @Override annotation above this method signature
DCAEServiceTypesDAO.java:L54
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTypesDAO.java
Change-Id: I0e306a23ebe31200c2e9a438e5f4f1da55eb53c9
Issue-ID: DCAEGEN2-312
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
TECHMAHINDRA\BS00493532 [Tue, 6 Feb 2018 08:55:20 +0000 (14:25 +0530)]
Sonar:Major
Replace type specification with diamond operator
DcaeServiceTypesApiServiceImpl.java:L153
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Change-Id: Ifa03875c154958004b41ed780f533f28093fa74e
Issue-ID: DCAEGEN2-311
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Snigdha Sucharita Patra [Tue, 6 Feb 2018 08:05:16 +0000 (13:35 +0530)]
sonar Major issues
Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Line No-108
Change-Id: I7a21f8c847cdbdfe17aa54919859ef60e265caf9
Issue-ID: DCAEGEN2-307
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Tue, 6 Feb 2018 06:28:33 +0000 (11:58 +0530)]
Sonar Major fix
Replace these toUpperCase() and equals() calls with a single equalsIgnoreCase() call in DcaeServiceTypesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=Pooja03
Location:DcaeServiceTypesApiServiceImpl.java:L123
Change-Id: I52479234b39cee0cdee01655c3cf3977a42103f4
Issue-ID: DCAEGEN2-308
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Tue, 6 Feb 2018 05:36:36 +0000 (11:06 +0530)]
Sonar Major fix
Replace these toUpperCase() and equals() calls with a single equalsIgnoreCase() call in DcaeServiceTypesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=Pooja03
Location:DcaeServiceTypesApiServiceImpl.java:L115
Change-Id: Ib4fc25a0882c28c7ff96637d84e52a0c274150f1
Issue-ID: DCAEGEN2-302
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Snigdha Sucharita Patra [Tue, 6 Feb 2018 05:14:15 +0000 (10:44 +0530)]
sonar Major issues
Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Line No-93
Change-Id: I5d7ec72053255053ebf2c0a434cb8461a703f299
Issue-ID: DCAEGEN2-306
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Tue, 6 Feb 2018 03:48:36 +0000 (09:18 +0530)]
sonar Major issues
Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServiceTypesApiServiceImpl.java
Line No-166
Change-Id: Ic08685f0f5a1feead8ea434263cd98ef7f5a5a6e
Issue-ID: DCAEGEN2-305
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Tony Hansen [Mon, 5 Feb 2018 20:40:10 +0000 (20:40 +0000)]
Merge "Add @Override annotation above method signature"
Tony Hansen [Mon, 5 Feb 2018 20:39:37 +0000 (20:39 +0000)]
Merge "Remove this redundant static qualifier"
Tony Hansen [Mon, 5 Feb 2018 20:37:27 +0000 (20:37 +0000)]
Merge "Sonar Major"
Tony Hansen [Mon, 5 Feb 2018 20:35:15 +0000 (20:35 +0000)]
Merge "sonar Major issues"
Tony Hansen [Mon, 5 Feb 2018 20:32:05 +0000 (20:32 +0000)]
Merge "sonar Major Using @Override annotation"
Tony Hansen [Mon, 5 Feb 2018 20:31:28 +0000 (20:31 +0000)]
Merge "sonar Major Using @Override annotation"
Tony Hansen [Mon, 5 Feb 2018 20:26:01 +0000 (20:26 +0000)]
Merge "Sonar Major fix"
Tony Hansen [Mon, 5 Feb 2018 20:25:03 +0000 (20:25 +0000)]
Merge "Sonar Major fix"
Snigdha Sucharita Patra [Mon, 5 Feb 2018 14:43:52 +0000 (20:13 +0530)]
sonar Major issues
Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServiceTypesApiServiceImpl.java
Line No:162
Change-Id: I2d3514753229c9c7a3c9fc005d26d55451f90603
Issue-ID: DCAEGEN2-303
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 5 Feb 2018 14:01:39 +0000 (19:31 +0530)]
sonar Major Using @Override annotation
Add the @Override annotation above this method signature
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServicesDAO.java
Line No-40
Change-Id: Ic1036c33e8de4ba994e3b3f81d1a70eab3a5e576
Issue-ID: DCAEGEN2-299
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Mon, 5 Feb 2018 06:27:48 +0000 (11:57 +0530)]
Sonar Major fix
Remove useless parentheses in DcaeServicesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=_me_%2CPooja03
Location:DcaeServicesApiServiceImpl.java:L214
Change-Id: I69cfc51a0e42516564c821ec5a0610c4cb3e7242
Issue-ID: DCAEGEN2-301
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Fri, 2 Feb 2018 09:42:07 +0000 (15:12 +0530)]
Sonar Major fix
Remove useless parentheses in DcaeServicesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=_me_%2CPooja03
Location:DcaeServicesApiServiceImpl.java:L139
Change-Id: I60ab8364871ffc2263e3ef94b0861c831171b756
Issue-ID: DCAEGEN2-298
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
TECHMAHINDRA\BS00493532 [Fri, 2 Feb 2018 06:32:37 +0000 (12:02 +0530)]
Remove this redundant static qualifier
Remove this redundant static qualifier
DCAEServiceObject.java
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/org/onap/dcae/inventory/dbthings/models/DCAEServiceObject.java
Change-Id: Ib4a38feca00aaf9282b4bc21407e35a7d613d9c7
Issue-ID: DCAEGEN2-297
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Snigdha Sucharita Patra [Thu, 1 Feb 2018 10:53:54 +0000 (16:23 +0530)]
sonar Major Using @Override annotation
Add the @Override annotation above this method signature
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServicesComponentsMapsDAO.java
Line No-42
Change-Id: I22a4e6f437986386fb3d3312466b0e9098704ffd
Issue-ID: DCAEGEN2-295
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Thu, 1 Feb 2018 10:41:11 +0000 (16:11 +0530)]
Sonar Major fix
resourcePath variable is already a string, there's no need to call toString method
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#severities=MAJOR|resolved=false|rules=squid%3AS1858
Change-Id: I5470b33aed3c8fd487c4d3687ee6f1d2de77abeb
Location:DatabusControllerClient.java:L51
Issue-ID: DCAEGEN2-296
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
TECHMAHINDRA\BS00493532 [Thu, 1 Feb 2018 10:36:24 +0000 (16:06 +0530)]
Add @Override annotation above method signature
Add the @Override annotation above this method signature
DCAEServiceTypesDAO.java
Sonar link : https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=BharathS24
Location : src/main/java/org/onap/dcae/inventory/daos/DCAEServiceTypesDAO.java
Change-Id: Ibb5bd4f8032e85b76c1fb71e8673ba196412ca12
Issue-ID: DCAEGEN2-294
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
TECHMAHINDRA\BS00493532 [Thu, 1 Feb 2018 09:05:23 +0000 (14:35 +0530)]
Sonar Major
Replace the type specification with the diamond operator
DcaeServicesApiServiceImpl.java
Sonar link : https://sonar.onap.org/issues/search#resolved=false|assignees=__me__%2CBharathS24
Location : src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Change-Id: I86abc7e42167783ade5dfc3a98fa05e19c5ca81b
Issue-ID: DCAEGEN2-290
Signed-off-by: TECHMAHINDRA\BS00493532 <BS00493532@techmahindra.com>
Pooja03 [Thu, 1 Feb 2018 06:40:13 +0000 (12:10 +0530)]
Sonar Major fix
Adding the @Override annotation above checkIfTableExists method signature in DCAEServiceComponentsDAO.java
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=_me_%2CPooja03
Location:DCAEServiceComponentsDAO.java:L39
Issue-ID: DCAEGEN2-288
Change-Id: I74eca3cb3d8b3d528ce462b1c0a8eda1ad574552
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Wed, 31 Jan 2018 05:46:33 +0000 (11:16 +0530)]
Sonar Major fix
Adding the @Override annotation above the createTable method signature in DCAEServiceComponentsDAO.java
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|rules=squid%3AS1161
Location:DCAEServiceComponentsDAO.java:L43
Change-Id: Ieca7421d424827f82dd662f8d5a097d8198a2dbe
Issue-ID: DCAEGEN2-289
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Lusheng Ji [Mon, 29 Jan 2018 18:27:00 +0000 (18:27 +0000)]
Merge "Sonar Major fix"
Lusheng Ji [Mon, 29 Jan 2018 18:26:53 +0000 (18:26 +0000)]
Merge "Sonar Major fix"
Pooja03 [Mon, 29 Jan 2018 12:16:34 +0000 (17:46 +0530)]
Sonar Major fix
Remove the unused context local variable
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR
Location:Bootstrap.java:L46
Change-Id: I3c59b7bc590fb9ba5e894e0dc584fc9d0026e209
Issue-ID: DCAEGEN2-285
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Mon, 29 Jan 2018 11:56:22 +0000 (17:26 +0530)]
Sonar Major fix
Replace the type specification in this constructor call with the diamond operator
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL%2CMAJOR
Location:DcaeServiceTypesApiServiceImpl.java:L96
Change-Id: If36e27e862ee2d8db4c2f2b9def49afa88cf9632
Issue-ID: DCAEGEN2-284
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 09:37:52 +0000 (15:07 +0530)]
sonar critical for Exception handling
Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-62
Change-Id: Id74f81284ac81e1f5e64b5549afc66cead7a8597
Issue-ID: DCAEGEN2-210
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 09:03:42 +0000 (14:33 +0530)]
sonar critical throw a dedicated exception
Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java
Line No-143
Change-Id: I52ecbd360bff6efa8906623ae7345ef694491d6b
Issue-ID: DCAEGEN2-215
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 06:16:37 +0000 (11:46 +0530)]
sonar critical throw a dedicated exception
Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java
Line No-134
Change-Id: I94f4d39fd55dc11c1459971074944fc2ff589cae
Issue-ID: DCAEGEN2-214
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Code Review / dcaegen2 / platform / inventory-api.git / log