RossC [Fri, 10 Jul 2020 14:28:29 +0000 (15:28 +0100)]
Pointing apex towards latest artifacts
Issue-ID: POLICY-2695
Change-Id: I28fd0e7e12a8f3e7ee192e40b99aaa2339aea24f
Signed-off-by: RossC <ross.carter@est.tech>
JvD_Ericsson [Tue, 7 Jul 2020 12:18:20 +0000 (13:18 +0100)]
Fix assertTrue SONAR issues in apex-pdp/contex and apex-pdp/core
Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/client apex-pdp/context and apex-pdp/core
Issue-ID: POLICY-2690
Change-Id: Ic1e69c75e5f8f887cac135b6728b007faf4b19a6
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
RossC [Thu, 9 Jul 2020 10:00:29 +0000 (11:00 +0100)]
Allowing configuration of truststore password
Issue-ID: POLICY-2633
Change-Id: Ic891ab55ded843e44b7998097949c1156c070657
Signed-off-by: RossC <ross.carter@est.tech>
JvD_Ericsson [Mon, 6 Jul 2020 09:37:04 +0000 (10:37 +0100)]
Fix assertTrue SONAR issues in apex-pdp
Replaced assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp auth
Issue-ID: POLICY-2690
Change-Id: Ica84f57f5a9048c33a2b641945a4376e60cf97c1
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Ram Krishna Verma [Mon, 6 Jul 2020 20:51:01 +0000 (20:51 +0000)]
Merge "Replace try/catch blocks with assertj - apex-pdp"
Jorge Hernandez [Mon, 6 Jul 2020 18:40:12 +0000 (18:40 +0000)]
Merge "Fix URL checking on REST plugins"
liamfallon [Mon, 6 Jul 2020 08:31:18 +0000 (09:31 +0100)]
Fix URL checking on REST plugins
The URL parameter must always be provided on the REST client carrier plugin
The URL parameter must always be provided on the REST requestor consumer
The URL parameter is not required on the REST requestor producer
This patch fixes the implementation to always checks the URL for existence on
the REST Client plugin. The current checks on the REST Requestor are correct
for the REST requestor plugin consumer and producer classes, so the checks
are not required in the REST Requestor parameters.
Issue-ID: POLICY-2692
Change-Id: I4e1534202002cf4a03bd159ac97b2a4f5b1746ab
Signed-off-by: liamfallon <liam.fallon@est.tech>
waynedunican [Mon, 6 Jul 2020 08:31:10 +0000 (09:31 +0100)]
Replace try/catch blocks with assertj - apex-pdp
Replaced try/catch blocks in apex-pdp with assertj assertions
Issue-ID: POLICY-2451
Change-Id: I83375b9e0f38d399b84bb68ce5d441e1cec73ef5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
a.sreekumar [Fri, 3 Jul 2020 10:08:04 +0000 (11:08 +0100)]
Fixing issue with policy chaining after CDS request failure in APEX
Change-Id: Id27343c21caaf69e30ee13076a2963c256fab55d
Issue-ID: POLICY-2687
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Tue, 30 Jun 2020 16:50:04 +0000 (17:50 +0100)]
Fixing ConcurrentModificationException during multiple policy deployment in APEX
Change-Id: Ib39e798d733727bdc676755b66adf2c499e618af
Issue-ID: POLICY-2655
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
ToineSiebelink [Tue, 30 Jun 2020 15:27:05 +0000 (16:27 +0100)]
Add tests for XPathReader
XPathReader had some SQ vulnerabilities whihch have been udpated in previous commit
This is just making sure same code is now covred by testware
Issue-ID: POLICY-2654
Change-Id: Ie40ee015b517b0cc3c5986a67513543653f53a61
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Jim Hahn [Tue, 30 Jun 2020 12:41:31 +0000 (12:41 +0000)]
Merge "Removed CDS simulator from apex-pdp"
Jim Hahn [Mon, 29 Jun 2020 16:34:58 +0000 (12:34 -0400)]
Removed CDS simulator from apex-pdp
As the simulator now resides in policy-models, the code for it is
no longer needed in apex-pdp. Deleted it.
Issue-ID: POLICY-2676
Change-Id: I8ae6c8d860a47e5e7ba0509c99e4e2676109de25
Signed-off-by: Jim Hahn <jrh3@att.com>
ToineSiebelink [Mon, 29 Jun 2020 11:24:38 +0000 (12:24 +0100)]
Fix SonarQube vulnerabilities
Added logging to handle file io boolean returns
Added security related settings to xml factories and builders
Issue-ID: POLICY-2654
Change-Id: Ibc0a01f978bfc446e1dc1f8ad952d1305a7b7178
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
a.sreekumar [Thu, 25 Jun 2020 15:48:15 +0000 (16:48 +0100)]
Fixing error with Main class name usage in APEX
Change-Id: I0da222e592e6e29f0afca4a1515d8f126fe91cbb
Issue-ID: POLICY-2623
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Liam Fallon [Thu, 25 Jun 2020 09:20:24 +0000 (09:20 +0000)]
Merge "Remove thread in JavascriptExecutor"
huaxing [Wed, 17 Jun 2020 05:34:10 +0000 (13:34 +0800)]
Remove thread in JavascriptExecutor
This change is basically a rollback of https://gerrit.onap.org/r/c/policy/apex-pdp/+/104230, with minor refactoring.
The problem that 104230 tried to address was supposed to be caused by https://jira.onap.org/browse/POLICY-2463.
With this rollback, apex-pdp increases performance and reduces memory usage.
Issue-ID: POLICY-2572
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I3a52d0ead0c1e530d218f9e3aba8b3eb5558abaf
Henry.Sun [Tue, 23 Jun 2020 05:58:44 +0000 (13:58 +0800)]
remove build warning with json dependency
Signed-off-by: Henry.Sun <henry.a.sun@est.tech>
Change-Id: Ieceb3e129620ced23552027e71fd09a2bd91acbe
Issue-ID: POLICY-2649
Ram Krishna Verma [Tue, 23 Jun 2020 13:17:20 +0000 (13:17 +0000)]
Merge "Updating all Apex dependencies"
liamfallon [Sun, 21 Jun 2020 20:52:55 +0000 (21:52 +0100)]
Remove apex-pdp Jackson security issue
We should use the managed version of jackson from policy-parent rather
than a specific apex-pdp version.
Also upgrade the version of Avro, avro 1.9.2 uses a newer somewhat more
secure version of Jackson.
Issue-ID: POLICY-1508
Change-Id: If32218816ae76cf3cf6ddc8980e3a37e7e2ffd19
Signed-off-by: liamfallon <liam.fallon@est.tech>
RossC [Mon, 22 Jun 2020 13:13:34 +0000 (14:13 +0100)]
Updating all Apex dependencies
Issue-ID: POLICY-2387
Change-Id: I6d9222cfe8841a4a4532d95dbc6f8b3f3d15ac87
Signed-off-by: RossC <ross.carter@est.tech>
liamfallon [Fri, 19 Jun 2020 16:04:51 +0000 (17:04 +0100)]
Changes for checkstyle 8.32
Issue-ID: POLICY-2188
Change-Id: I56bbf3aa3bd9e1ef433cc93ad2be0c54d141a2a5
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Mon, 15 Jun 2020 13:43:40 +0000 (13:43 +0000)]
Merge "Improve robustness of unit testing"
a.sreekumar [Fri, 12 Jun 2020 09:36:23 +0000 (10:36 +0100)]
Remove logback.xml files bundled as part of jar
Change-Id: I0c15bb6bddb00f5d1fa00ea48e570bc7c270c43d
Issue-ID: POLICY-2627
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
huaxing [Wed, 10 Jun 2020 06:58:34 +0000 (14:58 +0800)]
Improve robustness of unit testing
Issue-ID: POLICY-2630
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I6475f9272c1a770836af537c13b23e486b66ac3e
Pamela Dragosh [Wed, 3 Jun 2020 12:10:17 +0000 (12:10 +0000)]
Merge "Stability test for Apex-pdp"
aditya.puthuparambil [Tue, 2 Jun 2020 15:22:59 +0000 (16:22 +0100)]
Stability test for Apex-pdp
Issue-ID: POLICY-2457
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Id47155d172f2b6386c94470dd5068ee09d2a8238
Pamela Dragosh [Thu, 28 May 2020 18:36:17 +0000 (14:36 -0400)]
Point to parent SNAPSHOT
Issue-ID: POLICY-2319
Change-Id: I0699b2d2791e07df89b7a1e9c78320ced3c14f26
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
RossC [Thu, 21 May 2020 11:59:22 +0000 (12:59 +0100)]
Bump apex master to 2.4.0
Issue-ID: POLICY-2514
Change-Id: I764cfe41ed8cf8ffebd4ff076d0b76b79d61e142
Signed-off-by: RossC <ross.carter@est.tech>
RossC [Wed, 20 May 2020 14:12:22 +0000 (15:12 +0100)]
Bump Apex to 2.3.3
Issue-ID: POLICY-2514
Change-Id: I5b130b052150eb0e51759c751b83ab9d6f199759
Signed-off-by: RossC <ross.carter@est.tech>
RossC [Wed, 20 May 2020 13:03:08 +0000 (14:03 +0100)]
Release apex 2.3.2 docker
Issue-ID: POLICY-2514
Change-Id: I6dbdc5057a944792372ebcd02fe30f97fe7b6686
Signed-off-by: RossC <ross.carter@est.tech>
RossC [Wed, 20 May 2020 11:10:41 +0000 (12:10 +0100)]
Release apex 2.3.2 java artifacts
Issue-ID: POLICY-2514
Change-Id: If247d2ea6d7aabe5c82776ddf46ddf623247cc13
Signed-off-by: RossC <ross.carter@est.tech>
Ram Krishna Verma [Tue, 19 May 2020 17:05:47 +0000 (17:05 +0000)]
Merge "Point to released artifacts"
Pamela Dragosh [Tue, 19 May 2020 16:21:45 +0000 (12:21 -0400)]
Point to released artifacts
Issue-ID: POLICY-2514
Change-Id: I76b58cd69dcba6010867a583edb1b844eeec20d4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Fri, 15 May 2020 14:09:37 +0000 (15:09 +0100)]
Fix Web Socket server connection failure
In the Web Socket unit test, sometimes the server does not start quickly
enough and is not available when the wek socket client connects. This
review changes the unit test to wait for up to 2 seconds for the web
socket server to come up.
Issue-ID: POLICY-2571
Change-Id: I0c970783f368d691d07683bad0cdc28b681e5334
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 15 May 2020 10:15:11 +0000 (11:15 +0100)]
Unit test fails when port number occupied
If the port specified in the allocateAddress() is occupied, the method
returns the next highest available port. The unit test is changed to
reflect this behaviour.
Issue-ID: POLICY-1916
Change-Id: I02f63476d5f8f3ef2b2363afb3e23de04264e810
Signed-off-by: liamfallon <liam.fallon@est.tech>
RossC [Thu, 7 May 2020 12:25:34 +0000 (13:25 +0100)]
Unit tests for various classes
Issue-ID: POLICY-1916
Change-Id: Ie7cafa16ce12ca542a4e76307caddb36b7753990
Signed-off-by: RossC <ross.carter@est.tech>
Ram Krishna Verma [Fri, 1 May 2020 19:26:45 +0000 (15:26 -0400)]
Minor fixes in examples-vcpe
Issue-ID: POLICY-1916
Change-Id: Ie3d1c33648e7996ac063bbaac6ea11f3df03564b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Fri, 1 May 2020 15:06:29 +0000 (11:06 -0400)]
Minor fixes in examples-grpc
Issue-ID: POLICY-1916
Change-Id: I4bd93d72f234e1ce572b11bcb0621078480e061b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Pamela Dragosh [Mon, 27 Apr 2020 12:12:31 +0000 (08:12 -0400)]
Point to latest SNAPSHOTs
Glassfish security fix in parent, also fixes in common/models
Issue-ID: POLICY-2510
Change-Id: Id5186d4e2610a56db6ef66be62b4cc5177018c68
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 17 Apr 2020 14:17:32 +0000 (14:17 +0000)]
Merge "Fix sonar issues"
a.sreekumar [Wed, 15 Apr 2020 13:58:52 +0000 (14:58 +0100)]
Bump policy-apex-pdp to 2.3.2-SNAPSHOT
Change-Id: Ic668ab20498bdc41edc78f52c7ce9d89a1385f19
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Pamela Dragosh [Wed, 15 Apr 2020 00:59:17 +0000 (20:59 -0400)]
Release 2.3.1 apex docker image
Issue-ID: POLICY-2378
Change-Id: I0d3d2733083b50dc4b0f5e8126e7014d4ef97a4d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
huaxing [Fri, 10 Apr 2020 05:16:12 +0000 (13:16 +0800)]
Fix sonar issues
Issue-ID: POLICY-1913
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: Id1a9a6b6f7a9c8c74dd69bd0d30af05162a92cd1
Pamela Dragosh [Wed, 15 Apr 2020 00:08:27 +0000 (20:08 -0400)]
Release apex 2.3.1
Issue-ID: POLICY-2378
Change-Id: I7b966eca01f8baf0be3461b33efb8faaf12eb29c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ram Krishna Verma [Tue, 14 Apr 2020 19:39:54 +0000 (19:39 +0000)]
Merge "Point to released common/models"
Pamela Dragosh [Tue, 14 Apr 2020 18:52:23 +0000 (14:52 -0400)]
Point to released common/models
Issue-ID: POLICY-2378
Change-Id: I3d4ef6b6b8f61c0af23676189c9bf6eec529e3f3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
aditya.puthuparambil [Tue, 14 Apr 2020 12:16:07 +0000 (13:16 +0100)]
SONAR issue fix
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Ie6dccc50ad63c5fdca1e79d7985aec2455041b56
Pamela Dragosh [Mon, 13 Apr 2020 20:14:15 +0000 (16:14 -0400)]
Point common/models fix
Fix for naming policy and yaml string conversion.
Issue-ID: POLICY-2486
Change-Id: I1fc63ab7fdde63c5555d0bae784aee1309f7f8c3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Sat, 11 Apr 2020 19:35:04 +0000 (15:35 -0400)]
Point to released parent, common models
Issue-ID: POLICY-2378
Change-Id: I219f1ba6c816166c98346df47a68d21b9736b6b5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
huaxing [Tue, 7 Apr 2020 03:57:57 +0000 (11:57 +0800)]
Make sure Editor's css overrides common css
Issue-ID: POLICY-2446
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I1bc45367884ec78436a97256ac4286ab79c8a6b7
liamfallon [Mon, 6 Apr 2020 14:41:28 +0000 (15:41 +0100)]
Fix intermittent unit test failures WebSocket
The Web Socket server is marked as started before the start process has
complted. This change fixes that issue.
Issue-ID: POLICY-1470
Change-Id: I5b5ef5832893d884a6551b0516df91cb71d6c622
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sat, 4 Apr 2020 14:35:07 +0000 (15:35 +0100)]
Fix intermittent unit test failures reseterquestor
When consumers and producers are paired as in the case of the REST
Rquestor, both sides must come up and be wired together in the
initiation phase of apex-pdp before the consumers and producers start
handling envents.
In the ApexActivator class, the consumers were started immediately after
they were initialized meaning that a consumer could return events to a
producer that had not started yet.
This change fixes the ApexActivator so that it waits until all consumers
and producers are initialized before starting event handling.
It also fixes the timings on RestRequestor tests and tidies up the unit
tests.
Issue-ID: POLICY-2469
Change-Id: Ib66d9531bf21f2a879ab33795aded4f48e7bfbc6
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Sat, 4 Apr 2020 20:03:19 +0000 (20:03 +0000)]
Merge "Refer io.netty from policy/parent"
Ram Krishna Verma [Fri, 3 Apr 2020 18:26:15 +0000 (14:26 -0400)]
Refer io.netty from policy/parent
Issue-ID: POLICY-2467
Change-Id: Iea562574f466775f4dd443fc4ef9ecaa6ba610fd
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
liamfallon [Thu, 2 Apr 2020 19:54:52 +0000 (20:54 +0100)]
Fix failing Kafka tests
All the Kafka components need something near 10 seconds to come up
completely. This review tweaks the timing to allow the test Kafka server
to come up and to allow the consumers to connect to it.
Issue-ID: POLICY-2106
Change-Id: I6dd8ace0848bdc2549e658ef8908b4d85d5ea789
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Thu, 2 Apr 2020 17:44:21 +0000 (17:44 +0000)]
Merge "Fix hanging timeout on Executor test"
Liam Fallon [Thu, 2 Apr 2020 15:38:42 +0000 (15:38 +0000)]
Merge "Fix UUID missing in policy editor"
liamfallon [Wed, 1 Apr 2020 08:38:33 +0000 (09:38 +0100)]
Fix hanging timeout on Executor test
Issue-ID: POLICY-2106
Change-Id: I7bd44f8dfe349d73a4c8c4f978a30b455c45b2c7
Signed-off-by: liamfallon <liam.fallon@est.tech>
huaxing [Tue, 31 Mar 2020 08:55:48 +0000 (16:55 +0800)]
Fix UUID missing in policy editor
Issue-ID: POLICY-2445
Signed-off-by: huaxing <huaxing.jin@est.tech>
Change-Id: I7fda1961e95b1f18da6c0e22c7799195fc511443
aditya.puthuparambil [Wed, 1 Apr 2020 12:20:53 +0000 (13:20 +0100)]
My First Policy State Finalizer Example
Issue-ID: POLICY-1122
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: I552b58f39325982f1e26e59b352dfbe70cf35e7c
Jim Hahn [Tue, 31 Mar 2020 13:58:20 +0000 (13:58 +0000)]
Merge "Fix State Finalizer Prepare and Cleanup"
liamfallon [Tue, 31 Mar 2020 10:29:20 +0000 (11:29 +0100)]
Fix State Finalizer Prepare and Cleanup
The prepare() and cleanup() method were not called on state finalizers
for states. This review adds calls for them.
Issue-ID: POLICY-2450
Change-Id: I27aec4dea51f3e22b5922c04c7b7b974fca24292
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 31 Mar 2020 08:45:15 +0000 (09:45 +0100)]
Bump version of Infinispan for security
Change-Id: Ie01b221e182dd43e85e3e7277bb55169f85a1460
Signed-off-by: liamfallon <liam.fallon@est.tech>
Issue-ID: POLICY-2449
Change-Id: Icbb7a769eb8f0d9ef278d222ab007f330576abb3
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Mon, 30 Mar 2020 21:00:04 +0000 (21:00 +0000)]
Merge "Fix hanging tests in JavascritExecutor"
liamfallon [Fri, 27 Mar 2020 17:24:18 +0000 (17:24 +0000)]
Fix hanging tests in JavascritExecutor
Added tests to check threads start, execute, and stop correctly and
fixed JavescriptExecutor class to handle startup and shutdown correctly
without hanging.
Issue-ID: POLICY-2106
Change-Id: I9ab41023aae2ab1cbcaea53fdf5d48eccd90a2f1
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sun, 29 Mar 2020 12:10:38 +0000 (13:10 +0100)]
Fix timeout issues in gRPC tests
When running the gRPC tests in a slow or overloaded environment, the
timeupts must be set longer.
Issue-ID: POLICY-2106
Change-Id: Id152f1f82ef47f646c7b0488b4486425c6816e31
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Fri, 27 Mar 2020 16:58:48 +0000 (12:58 -0400)]
Point to latest snapshots
Issue-ID: POLICY-2378
Change-Id: Ie85ef583e8f0732a3b716b9e9b8947fb349522c7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 26 Mar 2020 01:34:08 +0000 (01:34 +0000)]
Merge "Point to models 2.2.2"
Pamela Dragosh [Thu, 26 Mar 2020 00:03:17 +0000 (20:03 -0400)]
Point to models 2.2.2
Issue-ID: POLICY-2378
Change-Id: Iffbed4a039e9a645cc081f09997aeedf0dba4056
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
a.sreekumar [Wed, 25 Mar 2020 23:01:06 +0000 (23:01 +0000)]
Bump policy-apex-pdp to 2.3.1-SNAPSHOT
Change-Id: I59b93fccb0f3a41f8db753d1e8e2978bbb51e9a0
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
a.sreekumar [Tue, 24 Mar 2020 16:03:24 +0000 (16:03 +0000)]
Release policy-apex-pdp 2.3.0 docker image
Change-Id: I7ad38253cab457f92912e17ea9eaf8300347f62e
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
a.sreekumar [Tue, 24 Mar 2020 16:00:28 +0000 (16:00 +0000)]
Release policy-apex-pdp 2.3.0 artifacts
Change-Id: Id23e5c848b6a338f09bbaecbf89e184e4e9f4e4f
Issue-ID: POLICY-2378
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
liamfallon [Wed, 25 Mar 2020 19:23:29 +0000 (19:23 +0000)]
Ignore JUnit tests that hang on await
This change ignores the tests that are hanging in Jenkins until the Apex
images are released. Once the images are released we'll fix these tests.
Issue-ID: POLICY-2106
Change-Id: I6a733896da044d3f24443ac202d6122a341db135
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 25 Mar 2020 17:35:43 +0000 (17:35 +0000)]
Add timeout on Javascript latch awaits
It is possible that the initiation and especially shutdown happens so
fast that the execution thread counts down the latch before the caller
calls await(), in which case the Javascript Rhino thread will hang. This
review adds a timeout on the await calls.
Issue-ID: POLICY-2106
Change-Id: Icfc6d4b478cca62522461c25d61ce9ee7328684a
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 25 Mar 2020 12:09:54 +0000 (12:09 +0000)]
Reduce size of client artifacts
This change:
- Removes separate packaging of the three clients
- Reduces the size of the combined client by suppressing unused
dependencies
- Removes the Servlet code from the Docker packaging
- Removes the client WARs from the docker package
Issue-ID: POLICY-2443
Change-Id: If0a0c2dddc3f05f2815b84ae04fcc029b1c4fe08
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Mon, 23 Mar 2020 17:49:50 +0000 (17:49 +0000)]
Launch separate threads for Javascript task execution
When a policy is loaded, a separate thread is spawned for each
Javascript script executor. This allows us to precompile the Javascript
scripts and also to have a larger stack available for script execution.
Issue-ID: POLICY-2106
Change-Id: I97323aafb623ba537ac1889b3c9504b345b4f67e
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Mon, 23 Mar 2020 23:51:45 +0000 (19:51 -0400)]
Point to released artifacts
Issue-ID: POLICY-2378
Change-Id: Ie1803786c6bbc636ef0f98a1c158aa17b6292e84
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
a.sreekumar [Fri, 20 Mar 2020 18:30:43 +0000 (18:30 +0000)]
Adding example for APEX gRPC plugin for CDS interaction
Change-Id: I8361eb0cbe74c3548ca98f3005bc37f5a1f91747
Issue-ID: POLICY-2436
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Jorge Hernandez [Thu, 19 Mar 2020 16:56:29 +0000 (16:56 +0000)]
Merge "Apex-pdp tutorial documentation changes"
aditya.puthuparambil [Thu, 19 Mar 2020 10:52:46 +0000 (10:52 +0000)]
Apex-pdp tutorial documentation changes
Issue-ID: POLICY-2424
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: I92491c904b65a0db93c9e6eaba676c653c276175
jhh [Wed, 18 Mar 2020 00:45:42 +0000 (19:45 -0500)]
renew policy certs till 03/17/2021
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6bd157d80a0aa1604e634ec561ee76e8197e97df
liamfallon [Wed, 11 Mar 2020 21:29:17 +0000 (21:29 +0000)]
Fix minor checkstyle/eclipse warnings
Some minor checkstyle and eclipse warnings have crept into the code in
the last few weeks. This review cleams them up.
Issue-ID: POLICY-1913
Change-Id: Ib5f103bc28c71a6c4db05ea05719eff41bb38914
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Wed, 11 Mar 2020 20:52:09 +0000 (20:52 +0000)]
Merge "Convert examples to Rhino Javascript format"
Ram Krishna Verma [Wed, 11 Mar 2020 20:51:11 +0000 (20:51 +0000)]
Merge "Fixing the gRPC consumer side"
liamfallon [Wed, 11 Mar 2020 17:17:14 +0000 (17:17 +0000)]
Convert examples to Rhino Javascript format
All examples are converted to Rhino Javascript from Nashorn Javascript.
Issue-ID: POLICY-2106
Change-Id: Ia6fec5b57b1e6131799b4b069968e4766ce54c96
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Wed, 11 Mar 2020 16:16:22 +0000 (16:16 +0000)]
Merge "Sonar Security vulnerabilities fix"
a.sreekumar [Mon, 9 Mar 2020 10:56:39 +0000 (10:56 +0000)]
Fixing the gRPC consumer side
Change-Id: I21d9253f41eee9b958e8fb723f6c19f266502cef
Issue-ID: POLICY-1656
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
liamfallon [Tue, 10 Mar 2020 21:09:28 +0000 (21:09 +0000)]
Adapt vCPE example for Rhino Javascript
Minor changes to Javascript source for execution under the Rhino script
engine.
Issue-ID: POLICY-2106
Change-Id: Ib7e30ce0067a11ea1bb3ca8d197c796dba9ea091
Signed-off-by: liamfallon <liam.fallon@est.tech>
aditya.puthuparambil [Tue, 10 Mar 2020 14:12:55 +0000 (14:12 +0000)]
Sonar Security vulnerabilities fix
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Change-Id: Ic86e04776c9300e37134210cd9db5b6d7e6a5a9e
Liam Fallon [Tue, 10 Mar 2020 13:49:32 +0000 (13:49 +0000)]
Merge "Sonar Bug fix"
liamfallon [Thu, 5 Mar 2020 10:50:48 +0000 (10:50 +0000)]
Use Rhino javascript executor in apex-pdp
Integation unit tests resultd in StackOverflowException errors in the
Graal Javascript interpreter. Following extensive testing and
trouobleshooting, it proved very difficult to fix these issues in Graal
as the stck overflow errors were occurring in native class instantiation
methods being invoked by Grall on the JVM.
The alternative Rhino Javascript engine is developed by mozilla, and was
incorporated into the Java 6 JVM and evolved into Nashorn in the Java 8
JVM. Oracle dropped Nashorn in Java 11. However, in parallel, Rhino
development has continued.
This review brings in the Rhino javascript engine into apex-pdp as the
replacement for Nashorn and instead of Graal. Graal seems to be pretty
unstable as yet so we may bring it in in future releases but for now
Rhino is a more stable and reliable alternative.
Issue-ID: POLICY-2106
Change-Id: I0edeff3b0bee404b38e3ebe22001a6e3375a44dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
aditya.puthuparambil [Mon, 9 Mar 2020 12:03:33 +0000 (12:03 +0000)]
Sonar Bug fix
Change-Id: Icb465fdcf5a580f599a111ed3c5d3510f5346f64
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Liam Fallon [Fri, 6 Mar 2020 10:26:59 +0000 (10:26 +0000)]
Merge "Adding gRPC plugin to dependencies in APEX"
a.sreekumar [Thu, 5 Mar 2020 23:36:06 +0000 (23:36 +0000)]
Adding gRPC plugin to dependencies in APEX
Change-Id: Iee8fdca9f23b432188a61054fe177283fdddc1ba
Issue-ID: POLICY-1656
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
aditya.puthuparambil [Wed, 4 Mar 2020 14:31:19 +0000 (14:31 +0000)]
Fixing SONAR bug + code smell
Change-Id: If76ddc860b67e0d8dcd4c48bacb5436ffc773faa
Issue-ID: POLICY-1913
Signed-off-by: aditya.puthuparambil <aditya.puthuparambil@est.tech>
Liam Fallon [Wed, 4 Mar 2020 13:32:27 +0000 (13:32 +0000)]
Merge "replace test sleep() with awaitality package"
Pamela Dragosh [Wed, 4 Mar 2020 12:50:06 +0000 (12:50 +0000)]
Merge "Preparing integration tests for Graal Javascript"
Pamela Dragosh [Wed, 4 Mar 2020 12:49:14 +0000 (12:49 +0000)]
Merge "GRPC support for APEX-CDS interaction"
liamfallon [Mon, 2 Mar 2020 17:08:47 +0000 (17:08 +0000)]
Preparing integration tests for Graal Javascript
Graal enforces Javascript more strictly than Nashorn does. This review
changes the tests in apex-pdp to comply with the stricter -Javascript
checking, re-enabling the integration test module.
- All log calls must be passed as strings, using toString()
- Byte/Float/Long Java types not supported in Javascript
Disable integration tests so that other changes can be brought in.
JMS integration test is disabled for now, it will be re-enabled in a
review shortly.
Issue-ID: POLICY-2106
Change-Id: I14bdb930eff735e862b51802cf72e4793cec3699
Signed-off-by: liamfallon <liam.fallon@est.tech>
Code Review / policy / apex-pdp.git / log