Fix no-lock service loader incorrect metadata

Issue-ID: POLICY-3202
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iac6d9c7459718df1aae97e0b56f51178cd6b172e

Add legacy-config new feature

This feature makes the legacy configuration optional.
It was used by brmsgw and other tooling to provision
via its DMaaP channel.   The capability to configure
via PdpConfiguration object is kept in the core
preserving backwards compatibility, but the DMaaP
provisioning channel(s) are optional.

Issue-ID: POLICY-2618
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia7198ac3b2810d85133c06ba5217a9c28e07ac4c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Use sh instead of ash in drools-pdp

Issue-ID: POLICY-3160
Change-Id: I37b2b75d010781108e40ae39d3742bc2c2e2fd7e
Signed-off-by: Jim Hahn <jrh3@att.com>

Update cert stores configuration

Issue-ID: POLICY-3158
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iee453ea70e0ebd9a82c0126ffedd8f5632783d6f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Delete keystores from drools

The Keystore is no longer needed in the tarball, as it is supplied
externally by the CSITs and Helm charts.  Deleted that file.

Issue-ID: POLICY-3143
Change-Id: I5f80f7e25a86b903fd67080adbf15ab090c4b346
Signed-off-by: Jim Hahn <jrh3@att.com>

Change Dockerfile httpie version to fix telemetry

telemetry based tools do not work as the http-prompt
version installed has changed in alpine repositories.

Issue-ID: POLICY-3138
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib838dabedacd03a72bd018f1d66ace95cbb0c511

Update policy-keystore with newer certificates

Issue-ID: POLICY-3139
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4b0cc4e1a1f6de36857f3e6e73b3dc6b1f9d8b87

Address plugin-not-found issues

Removed references to archetype-packaging and lifecycle-mapping, where
unnecessary due to pom inheritance.
Also removed unnecessary checkstyle plugins.

Issue-ID: POLICY-3126
Change-Id: Ia2bc398c7adbf13e925dd6329411310472c7ee35
Signed-off-by: Jim Hahn <jrh3@att.com>

bump pom versions to 1.9.0-SNAPSHOT

Issue-ID: POLICY-3105
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0686675cdddf6fb5ce78f792484486f39d705a58

bump poms to 1.8.2-SNAPSHOT

Issue-ID: POLICY-3127
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0cf960650fbd2010a7c747d4932fdf8226c1fa07

docker image release 1.8.1

Issue-ID: POLICY-3127
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iec454c8c56fbb6cd0a3b6f3d9066bec050370365

maven release 1.8.1

Issue-ID: POLICY-3127
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5273c846164413c510209605b8d6845fb740002d

point to released models 2.4.1

Issue-ID: POLICY-3127
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ifa9e15c24245f195f7def2b831db9e24bbc108ce

add no locking feature

It provides an interface to applications for locking
purposes that always succeeds.  It does not deny
acquiring resource locks.

Issue-ID: POLICY-3114
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6aebb5f40e4176e0ff7b0e6c6d4042a79dd0b7a3
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

modify filename and path for csit

after doing a test in jenkins sandbox
found some errors have to be fixed.

Issue-ID: POLICY-2895
Change-Id: I2bd6d79c71070ef7ce9ec179a1838d51b886b2ae
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Fix default timestamp in upgrade script"

Fix default timestamp in upgrade script

The 1811 upgrade script for distributed locking is failing, because the
default timestamp value is invalid for the new column type.  Modified
the value and also added one for the downgrade script.

Issue-ID: POLICY-3117
Change-Id: I8dff748cb089db551820418b1d597a1be207c9b5
Signed-off-by: Jim Hahn <jrh3@att.com>

enable viewing lifecycle statistics with telemetry

Issue-ID: POLICY-3121
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I25e8c4439c0a6beabe532c17cc58919f369f17f0
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Add quotes around variable in db script

Apparently, ash doesn't like "[ -z ${xxx} ]" if the content of $xxx
contains spaces.  Added quotes around ${xxx}.
Also fixed:
- a couple of "[" "]" mismatches
- a logic error in the selection of upgrade scripts

Issue-ID: POLICY-3117
Change-Id: I99c977825fe9df8a44c288b6307cd3e55c504f86
Signed-off-by: Jim Hahn <jrh3@att.com>

move drools-pdp csit to project level

move tests/plans from
csit repot to drools-pdp repo

Issue-ID: POLICY-2895
Change-Id: I8fd43ca763d74d6db7950b1b5d3502f3da73e09e
Signed-off-by: Taka Cho <takamune.cho@att.com>

Update info.yaml in drools-pdp

Issue-ID: POLICY-3028
Change-Id: I951ae73be6a42184f9fa72e4bac4432ae9b552b1
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

bump poms to 1.8.1-SNAPSHOT

Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I2210fcc34c9f69c3ea42c07543ffb9834f719620

docker image release 1.8.0

Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I54d4c113e558f8392ad10a7e4e8aff3d9b9ff508

maven release 1.8.0

Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If9d4eedc7d2710143588b0c2313628c2d9634c13

Upgrade hibernate dependency version in drools-pdp

The FOSS report for drools-pdp showed that hibernate-commons-annotations
uses the LGPL 2 license, which means it should be kept up to date, if
possible.  However, it is still version 5.0.1.Final, which was released
in 2015, while 5.1.2.Final was released in 2020.  Upgraded to the new
version.
Verified junits still pass in both drools-pdp & drools-apps.

Issue-ID: POLICY-3005
Change-Id: I1c42b14cfa812299797de002a7fa2e20b49dea6e
Signed-off-by: Jim Hahn <jrh3@att.com>

rearrange asserts in DroolsRunnable tests

There are consistent failures when doing staging builds
in policy-core junits.  This problem shows only in stage builds.
It is suspected to be a race conditioning with the internal
scheduling of rules and insertion of events.

Issue-ID: POLICY-3097
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0f2df770dfdda6d23e9cb29253f4152a0365d33a

use policy-jdk-alpine:2.2.1 base image

Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I2c891acddcce74297cf03d696af8472c127d27ea

versions: 1.8.0 common, 2.4.0 models, 3.3.0 parent

Issue-ID: POLICY-3088
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I34009c5916b04d1272b1d528272945fabe22a56c

Deprecate feature-simulators from drools

feature-simulators was only used by server-pool.  Now that server-pool
has been deprecated, the simulators can be deprecated, too.

Issue-ID: POLICY-3079
Change-Id: I4555432d90f99735de2f189ce626befb414027cb
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "support policy execution counts in lifecycle"

support policy execution counts in lifecycle

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic9150b9b76a04ee39cb0c0a78081ad22b21dcd02

Merge "convert date to instant for statistics"

convert date to instant for statistics

Issue-ID: POLICY-3069
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I72f9db0cd70fc24a21425ad071717fc0e704bb59

deprecate server-pool in droolspdp

deprecate server-pool in droolspdp

Issue-ID: POLICY-3079
Change-Id: Id25aea57cc4d119bba73de22c6dc77ab9a56c95f
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "remove TransMetric - not needed"

remove TransMetric - not needed

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I626de45b528bb891c79900085bfe783fe248b3fa
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

support pdp-type configuration for PAP status

Issue-ID: POLICY-3070
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaddd9bac102cbe79626fe91d78a457dcfd4cb1fb
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Merge "deploy stats in lifecycle module"

Merge "Upgrade dependencies in drools-pdp for IQ issues"

deploy stats in lifecycle module

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iaa78aa48064e8288265aeb498279e9d8324538d8
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

expose metric from mdctransaction

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I484174ae3a09e6706a36984aa2708f8ffef17808

Upgrade dependencies in drools-pdp for IQ issues

IQ reports identified a couple of vulnerabilities in various
dependencies.  Upgraded to the latest version of them per SECCOM.

Issue-ID: POLICY-3005
Change-Id: I52f1137bfaeee0d715ee438b69e98f2d06849d38
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Fix sonars from dependency upgrade"

Merge "support transaction reports in engine"

Fix sonars from dependency upgrade

The dependency upgrades in policy-parent caused some new sonars.  In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner.  Changed one to openMocks() because using the Runner
caused it to fail on jenkins, but not in the local eclipse.
Also fixed a type safety issue with EMPTY_LIST.

Issue-ID: POLICY-2909
Change-Id: Iea9420190f208d7de3bf3ad531515c92e0fab83f
Signed-off-by: Jim Hahn <jrh3@att.com>

support transaction reports in engine

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id1f02c86be491d5145e74725f76953e294e2975c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

More sonars in drools-pdp

Addressed the following issues:
- log user-controlled data; moved the "NOSONAR" to a different line
- make constructors protected

Issue-ID: POLICY-2909
Change-Id: Ic69c100af777779e791c38cc444dd2ea726258f2
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Upgrade dependencies"

Upgrade dependencies

Changes to eclipselink are incompatible with javax-persistence-api so
removed the latter.
Also added target-database property.
Also replaced string constants with eclipselink constants.
Per review comments, moved target-database values to property files.

Issue-ID: POLICY-3005
Change-Id: I043203a952d54406a5996c1e8b5ba8936bf558c0
Signed-off-by: Jim Hahn <jrh3@att.com>

pull generic code from mdctransaction into metric

created generic metric classes that would be used
now for 2 purposes: 1) existing logging framework of
metrics and transactions, 2) generic metric tracking to
be use to report pdp statistics.

Issue-ID: POLICY-3033
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I8f5d773f27871e19c8796d1fe2f3972b4c21fe67
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

small perf improvement passing policy map argument

Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I85aeba2e710f6637a6e6bdfd62e1bc8b70f4d19f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

sonars - protected constructors and typecasting

Issue-ID: POLICY-3017
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7e7e384db26e244e2514aec3c3579b7b7f92f8a1

sync policies when native artifact policies added

interoperability between native and non-native policies
present several difficulties.   The code submitted
operates in deltas where deploy and undeploy operations
are performed on the deltas of the updates.

In order to support interoperability, policies not
part of a delta update may need to be reapplied.
For example, in the case when the delta is just
a new native controller artifact, we should go
through the set of already deployed policies and
reapply non-native policies as long as the policy types that
the native artifact policy supports.

Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ieb8e5e17862e9d607433a1d4e86a026725d73498
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

add methods to check if a fact exists.

Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic00d2a548dbc904e044d2310c7d5439a1cb708a5
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Merge "sort deploy and undeploy policy lists"

sort deploy and undeploy policy lists

An order is imposed in the deployment and undeployment actions when
the list of active policies is retrieved from PAP.   This is to
ensure that the operations are applied in a sane way, for example
to try to prevent to undeploy policies before deleting a controller,
etc ..

The deployment order is 1) native controller, 2) native rule, and 3)
non-native policies.

The undeployment order is 1) non-native, 2) native rule, and 3)
native controller policies.

Issue-ID: POLICY-2762
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Icb15dcec87fd5d9917ee152ab15ca7277e13590a

drools-pdp docker build fail

after official jre 2.2.0 released
there is no /root/.cache exist
based on jenkins build

Issue-ID: POLICY-2999
Change-Id: I6c7db9dce3269bdcd26016d4049364bc72310dac
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Changed identifiers to concept identifiers"

use jdk base 2.2.0 - drools

use jdk base 2.2.0

Issue-ID: POLICY-2917
Change-Id: Ib7692dd05290dcb672a30174ed90441d364a4b83
Signed-off-by: Taka Cho <takamune.cho@att.com>

Changed identifiers to concept identifiers

The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.

The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.

Issue-ID: POLICY-2900
Change-Id: I677cc1f8730001b300ab2041f2d57c2485cbc4ed
Signed-off-by: liamfallon <liam.fallon@est.tech>

[docker] use `--no-cache-dir` flag to `pip` in dockerfiles to save space

using "--no-cache-dir" flag in pip install ,make sure downloaded
packages by pip don't cached on system . This is a best practice
which make sure to fetch from repo instead of using local cached one .
Further , in case of Docker Containers , by restricting caching ,
we can reduce image size.
In term of stats , it depends upon the number of python packages
multiplied by their respective size . e.g for heavy packages with a lot
of dependencies it reduce a lot by don't caching pip packages.

Further , more detail information can be found at

https://medium.com/sciforce/strategies-of-docker-images-optimization-2ca9cc5719b6

Issue-ID: POLICY-2948
Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
Change-Id: I0c4c6ba511bca93a1389c53a91bae9b2d4546ee6

Merge "remove all GPL-3.0 and plus license package - drools pdp"

Merge "move all bash to ash shell scripts"

move all bash to ash shell scripts

this gerrit would be the first step
to not to use any GPL-3.0 and plus license

Issue-ID: POLICY-2847
Change-Id: I09a571f14ef8c6983f9051068c2bad5acc173787
Signed-off-by: Taka Cho <takamune.cho@att.com>

remove all GPL-3.0 and plus license package - drools pdp

this gerrit would be the second step
to not to use any GPL-3.0 and plus license

Issue-ID: POLICY-2847
Change-Id: I67f9f4be6aba6e91e53a7462db79e60c73e58144
Signed-off-by: Taka Cho <takamune.cho@att.com>

verify schema validation for any policy type

Issue-ID: POLICY-2880
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0cc6e8967d42d347415857dc77976f2b8ab86516
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

support for not validated policy types

Issue-ID: POLICY-2880
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id816bb3edd44c34a342cd7ada95dd8f2f9d1b0a6
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Make feature-pooling-dmaap work without filtering

As DMaaP server-side filtering has been deprecated, modified
feature-pooling-dmaap to work without it.  The new design assumes that
each pdp gets its own unique consumer group, thus all pdps receive all
events.  Each pdp then uses the bucket assignments to determine whether
or not to process the event.  Note: this means that events no longer
have to be forwarded to the correct host, thus the "Forward" class has
been deleted.

Other than that, the code already did post-filtering of events so most
of it still works even without server-side filtering.  As a result, most
of the effort was in simply removing code that no longer applies.

Per review comments:
Modified code to use the event hash code instead of the request ID has
code when routing events.  This eliminated the need for the extractor
classes and related properties.
Replaced amsterdam and beijing properties with usecases properties.

Issue-ID: POLICY-2881
Change-Id: I87e4f98c14f419593879c278d7da053c80575553
Signed-off-by: Jim Hahn <jrh3@att.com>

Re-encrypt drools-pdp properties

To satisfy sonar, the algorithm for policy/common CryptoUtils has been
changed, necessitating the properties be re-encrypted.

Issue-ID: POLICY-2801
Change-Id: I59e63d68c1c7f62e321aa729e11fe41e13efd396
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp master to 1.8.0-SNAPSHOT

Bumping minor version now that guilin branch has been created.
Also repointed to snapshot versions for dependencies.

Issue-ID: POLICY-2875
Change-Id: Ic3d5b96e610db0487ce316a9397d2f9ecb04bda6
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp to 1.7.5 SNAPSHOT

Issue-ID: POLICY-2869
Change-Id: Id2fcbfcb5435f79b5ebb74a403fd6133d1b79a7c
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-pdp 1.7.4 docker

Issue-ID: POLICY-2869
Change-Id: I4e92d996dc55d000c4150c9e983bdc4904c30699
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-pdp 1.7.4 artifacts

Issue-ID: POLICY-2869
Change-Id: I4121fefa2ddcefb0f8c2cca15990a1d494c64827
Signed-off-by: Jim Hahn <jrh3@att.com>

Point drools to models 2.3.5

Issue-ID: POLICY-2869
Change-Id: I00931ad9b9df9c1f9ca893e0967693356c9eccfa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

enforce httpie 1.0.3 installed

http-prompt has a compatibility
issue with httpie 2.x.x
enforce to use httpie 1.0.3

Issue-ID: POLICY-2864
Change-Id: Ibfdd9afb48d0f755051516edb9ab790f12331cdc
Signed-off-by: Taka Cho <takamune.cho@att.com>

bump drools-pdp to 1.7.4-SNAPSHOT

Issue-ID: POLICY-2839
Change-Id: I85d286a012d7b54b8c847d94951703d2e6462e13
Signed-off-by: Taka Cho <takamune.cho@att.com>

release policy-drool 1.7.3 docker

Issue-ID: POLICY-2839
Change-Id: I496b7b992a5c2843e3e9fac933e1f376f03feb0f
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drools-pdp 1.7.3 artifact

Issue-ID: POLICY-2839
Change-Id: I1088f94022e370a9d4029fb47666b776c5ccd979
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.4

Issue-ID: POLICY-2839
Change-Id: Ifbc8239f9f5912eb7d1074424cf7c8060f71fdda
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.3

Issue-ID: POLICY-2839
Change-Id: I0bab7451436d5f76c19b743fe384cc0303a41228
Signed-off-by: Taka Cho <takamune.cho@att.com>

Use models 2.3.3-SNAPSHOT in drools-pdp

Issue-ID: POLICY-2863
Change-Id: Iaffc87711f33e4a5c35d1fdcaa21f8ec0d742baf
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp to 1.7.3 snapshot

Issue-ID: POLICY-2839
Change-Id: I750b5130c421dafd95dc4f323e891384a7815841
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drools-pdp 1.7.2 docker

Issue-ID: POLICY-2839
Change-Id: I687bd06a5fd1f56348b08f3866a0e18eef6bb848
Signed-off-by: Taka Cho <takamune.cho@att.com>

Release drool-pdp 1.7.2 maven artifacts

Issue-ID: POLICY-2839
Change-Id: Ia80368ae6632779451e9a3f9a595fa235906ac4b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.2

Issue-ID: POLICY-2839
Change-Id: I6110baaf281b82cbbfc384693dd5dc30c6c6d19b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix new sonars in drools-pdp

Addressed the following sonar issues:
- extract common test method
- too many assertions in test method
- don't always return the same value

Issue-ID: POLICY-2616
Change-Id: Iab836cdcd667b35e2db9db7d6ffc7896df33e1c8
Signed-off-by: Jim Hahn <jrh3@att.com>

update default keystores

Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If74e7eeb0ab8ff35accbfddb719bd477cd889b06

Fix more sonars in feature-server-pool

Addressed the following sonars:
- move fields from "interface" to "class"
- don't always return the same value
- remove commented-out code
- make constants "final"
- don't synchronize on parameters

Issue-ID: POLICY-2546
Change-Id: If2d410664d956a7efabf3a4dbef96bbf7d24de5e
Signed-off-by: Jim Hahn <jrh3@att.com>

Use alpine base image 2.1.1

Issue-ID: POLICY-2819
Change-Id: I5722330bff9c37ee9dd89d3fce0bd7fbdf975f1b
Signed-off-by: Jim Hahn <jrh3@att.com>

Handle CR in pom property files

Fixed deploy-artifacts to strip carriage returns from pom.properties
files before attempting to extract variables from them.
Switched to using 'sed' instead of dos2unix.

Issue-ID: POLICY-2823
Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9
Signed-off-by: Jim Hahn <jrh3@att.com>

bump to 1.7.2-SNAPSHOT

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0fb5ead444c23882454e3a48efea9d936a84e455

docker release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4271ce650490afbe9023f71f6c0ced0194e8d624

maven release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I807f85c5ab4398146ddb50a5942623a49eadbd26
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Update common and models to 1.7.1 and 2.3.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9ecd6b7d5cc741be5ed304d4a2a181f47c25a391

point to 2.1.0 policy-alpine base - droolspdp

In G-rel, using 2.1.0 base.

Issue-ID: POLICY-2789
Change-Id: I3b0b3d98b8915d7e45ec1231f41a7b97836d80c1
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix more sonars in drools-pdp

Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure

Fixed more eclipse warnings:
- parameterize generic types

Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Fix sonars in server-pool"

Fix sonars in server-pool

Addressed the following sonars in feature-server-pool:
- re-interrupt after catching an InterruptException
- reduce cognitive complexity
- cognitive complexity
- not enough arguments for logger message
- use UnaryOperator instead of Function
- update static fields via static methods
- too many break/continue in for-loop

Also fixed some Eclipse warnings:
- add parameter to generic types
- useless assignments
- newInstance() has been deprecated
- close streams

Issue-ID: POLICY-2616
Change-Id: Ibf6c20e6c2a7eb8c60e1b38f388d86a0f9b8804b
Signed-off-by: Jim Hahn <jrh3@att.com>

Fix sonar issue in distributed locking

Fixed sonar issue:
- Refactor the code of the lambda to have only one invocation throwing
  an exception

Issue-ID: POLICY-2616
Change-Id: I8d96b95d0da9a780daacec7a4de17167642b03c1
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove commons-io dependency

Policy parent has this declaration to the latest 2.7
version of commons-io which fixes a sonatype security
issue. There is no reason that drools-pdp should be
declaring this.

Issue-ID: POLICY-2798
Change-Id: Ie7dbe14458be4ead395dfcbebbc1c0cd3ccc4ea6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>