mojahidi [Thu, 4 Jan 2018 05:24:05 +0000 (10:54 +0530)]
Fixed sonar issues - ComponentDependenciesImpl
Fixed all sonar issues
Change-Id: Iaed4ea9bc7df52bd100d5d118b7212813ae22b76
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 14:12:55 +0000 (19:42 +0530)]
Fix Sonar VendorSoftwareProductInfoDaoZusammenImpl
Fixed reported sonar issue
Change-Id: Ifc827f6e1ac4c10272969e643d10b86171a0d963
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 14:02:13 +0000 (19:32 +0530)]
Fix Sonar issues- ElementToProcessConvertor
Fixed reported sonar issue
Change-Id: I631710a9421e34cf7c26a9316e2e3271bf44f587
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:54:56 +0000 (19:24 +0530)]
Fix Sonar issues- DeploymentFlavorDaoZusammenImpl
Fixed reported sonar issue
Change-Id: I58f503aa43f0257c263835053bde28442f98a2b5
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
talio [Wed, 3 Jan 2018 15:49:51 +0000 (17:49 +0200)]
fix failing tests
fix failing tests in uploadCSARFileTest.java, and changing error messages
Change-Id: Ied1384d87551242d3eb48987990a6e8a72b26916
Issue-ID: SDC-874
Signed-off-by: talio <tali.orenbach@amdocs.com>
talig [Thu, 4 Jan 2018 06:33:48 +0000 (08:33 +0200)]
Fix Orch Template Candidate Manager test failures
Change-Id: Icd5d96b5cd27b3051828b703fde549217341c320
Issue-ID: SDC-860
Signed-off-by: talig <talig@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:27:21 +0000 (18:57 +0530)]
Fix Sonar -ComponentDependencyModelDaoZusammenImpl
Fixed reported sonar issue
Change-Id: I6c8b86cb54bcc6d21920e9ea806dcd40717c2383
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 10:58:47 +0000 (16:28 +0530)]
Fix Sonar violations - ValidationErrorCodes
Removing the files since they are not referenced
Change-Id: Ica5835575222e96abc02132734b1e354d696ae35
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:20:41 +0000 (17:50 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProd
Fixed all sonar issues
Change-Id: Ibf766225a961e11249fbcebe8115b5426f521a83
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:19:33 +0000 (18:49 +0530)]
Fix Sonar issues- ComponentDaoZusammenImpl
Fixed reported sonar issue
Change-Id: Ieda1568b4b20cdaaee47534cbfc0c73bfcca393c
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 13:05:21 +0000 (18:35 +0530)]
Fix Sonar - ComponentArtifactDaoZusammenImpl
Fixed reported sonar issues
Change-Id: I1d74c641d65d47a7ab810bef94b77ef3a55cd071
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
mojahidi [Wed, 3 Jan 2018 12:38:10 +0000 (18:08 +0530)]
ComponentMonitoringForSwaggerFileUpload
Deleted unused interface
Change-Id: I039024b7bd77dca735bdd644da657aa05110b5c8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 3 Jan 2018 12:28:37 +0000 (17:58 +0530)]
deleted unused interface - ComponentUploads
Deleted unused interface
Change-Id: I4793c5486c18ed9ff74f9f70fd079dd5a78fb32b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ayalaben [Wed, 3 Jan 2018 06:38:27 +0000 (08:38 +0200)]
Unit Tests
Change-Id: I39ee00e80475aa93b0f99a350b56754c31c6e9b6
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
Abhai Singh [Wed, 3 Jan 2018 10:46:01 +0000 (16:16 +0530)]
Fix Sonar violations - ValidationManagerUtil
Fixed reported sonar issues by adding private constructor
Change-Id: I544dcdb7385ce8cf750f5f93695460365cc0e78f
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
miriame [Tue, 2 Jan 2018 13:35:55 +0000 (15:35 +0200)]
select item from workspace- skipping versions page
Change-Id: Iebd3bb33703c2d47265ba133f7b74ec961ba8b2f
Issue-ID: SDC-864
Signed-off-by: miriame <miriam.eini@amdocs.com>
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
fix MIB assignment
Assign mib file to all of the components from the same VFC type
Change-Id: Ia6a1a5a08b7383ec64ace085193b0c8daa399c7f
Issue-ID: SDC-811
Signed-off-by: talio <tali.orenbach@amdocs.com>
shalomb [Tue, 2 Jan 2018 11:48:40 +0000 (13:48 +0200)]
Remove Zusammen cassandra plugin
Remove Zusammen cassandra plugin
Change dependency
Modify imports
Change-Id: Ice66fdd9f3970961723df476c8d1e38040504189
Issue-ID: SDC-862
Signed-off-by: shalomb <shalomb@amdocs.com>
ayalaben [Tue, 2 Jan 2018 09:25:39 +0000 (11:25 +0200)]
Unit Tests
Change-Id: I6b863f3762eaad4f17967d77fc5ad64b23ee9d3a
Issue-ID: SDC-860
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
mojahidi [Thu, 28 Dec 2017 13:03:00 +0000 (18:33 +0530)]
Fixed sonar issues - VersionedVendorSoftwareProduc
Fixed all sonar issues except exception handling and newly introduced in collaboration merge
Change-Id: I9d9292411cd9f7ffb32aa284a5d63c86bb01b56d
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrek2000 [Sun, 31 Dec 2017 08:32:59 +0000 (10:32 +0200)]
sonar issue fix - exception handling
remove exception handling which does nothing to handle the error
Issue-ID: SDC-835
Change-Id: I45e0bc203e15b41f907641bfda130f20e1f00f54
Signed-off-by: shrek2000 <orenkle@amdocs.com>
avigaffa [Sun, 31 Dec 2017 13:07:39 +0000 (15:07 +0200)]
Fixing sonar Exception Handling
Change-Id: I04eb047973a3f5c07dd9dc410cb13af974e8ded1
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
talig [Mon, 1 Jan 2018 12:52:01 +0000 (14:52 +0200)]
Remove onboarding BE redundant healers
Change-Id: I6b849608e64f88c6b91b1bc772fdb33aaa7e8245
Issue-ID: SDC-845
Signed-off-by: talig <talig@amdocs.com>
talig [Mon, 1 Jan 2018 11:07:47 +0000 (13:07 +0200)]
Fix sonar issues + tests in versioning lib
Change-Id: Ib49288fe49be1e848b9615e548689cdbe0df4fee
Issue-ID: SDC-779
Signed-off-by: talig <talig@amdocs.com>
Michael Lando [Sun, 31 Dec 2017 11:26:46 +0000 (13:26 +0200)]
sonar plug in test
Change-Id: I804066364ce8ab3fba36c3e5a39fbbd4c1e397af
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
ayalaben [Sun, 31 Dec 2017 15:57:36 +0000 (17:57 +0200)]
Fix Owner Healer
Change-Id: I85371b7cd6e2fa6e929b42b4773eef685252bcff
Issue-ID: SDC-837
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
vempo [Sun, 31 Dec 2017 09:23:20 +0000 (11:23 +0200)]
Default ctor and styling in HealingEntity
Change-Id: I489ecbf4cd3789febe3ff56e11c1db31bf5e1d89
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Sun, 31 Dec 2017 09:12:53 +0000 (11:12 +0200)]
Default ctors in notification-api module
Change-Id: I823348c05a367ed876a63aaa146a98d1cb869cd8
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 12:19:51 +0000 (17:49 +0530)]
Fix Sonar issues ResourceBaseValidator
Fixed few reported sonar issues.
One sonar issue is ignored as it would involve change
in method signature of public method
Change-Id: Ib0c97ebce5b05dcc0e7dd3d46f25557cc51c31d8
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:43:06 +0000 (19:13 +0530)]
Fix Sonar violations - ValidationTestUtil
Fixed few reported sonar issues.
One sonar issue related to exception handling
is ignored as it would be fixed later
Change-Id: I316868b2f6634e8858696e87604e73de7c8d5e40
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:56:59 +0000 (19:26 +0530)]
Fix Sonar violations - ValidationUtil
Fixed few reported sonar issues.
Fixed as per review comment
Change-Id: Id3cbdcefe120eb9d807f7b66e1b0f329881ef658
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Abhai Singh [Thu, 28 Dec 2017 13:01:52 +0000 (18:31 +0530)]
Fix Sonar violations - Validator
Fixed few reported sonar issues.
One sonar issue is ignored as am not sure if
this qualifies to be a functionalInterface
Change-Id: I7b9f4faa4e8359c644f7473d7937c82357f576fd
Issue-ID: SDC-343
Signed-off-by: Abhai Singh <Abhai.Singh@amdocs.com>
Idan Amit [Fri, 29 Dec 2017 07:40:43 +0000 (09:40 +0200)]
SDC Designers Integration - Part 1
Finished first part of designers integration
Added templated configuration file
Added tests
Change-Id: I76e8b413063b939e1eb58da4a5502c4b526168f2
Issue-ID: SDC-687
Signed-off-by: Idan Amit <ia096e@intl.att.com>
mojahidi [Thu, 28 Dec 2017 12:07:41 +0000 (17:37 +0530)]
Fixed sonar issues - ComponentDependencyTracker
Fixed all sonar issues
Change-Id: I6a6ab4217964a8071af86e090570f8cb4a8dc122
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Michael Lando [Sun, 31 Dec 2017 07:57:46 +0000 (09:57 +0200)]
update simulator
Change-Id: I9d3bca6a4d0a4f258094c409a1a4f6df3521030f
Issue-ID: SDC-832
Signed-off-by: Michael Lando <ml636r@att.com>
ayalaben [Wed, 27 Dec 2017 10:05:35 +0000 (12:05 +0200)]
Add Item Owner to item
Change-Id: I91ce289159057bd5c179c64131d74a24aa83ac9f
Issue-ID: SDC-800
Signed-off-by: ayalaben <ayala.benzvi@amdocs.com>
vempo [Fri, 29 Dec 2017 13:36:35 +0000 (15:36 +0200)]
Fixed default constructor in config-lib module
Change-Id: Iae1758b963141df4f6369672d219348242ec796e
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 13:56:25 +0000 (15:56 +0200)]
Default constructors in nosqldb-api module
Change-Id: I94f0828f73ad68c844bd984f04aa5d11e8cda1e7
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 13:51:46 +0000 (15:51 +0200)]
Default constructors in versioning-api module
Change-Id: If43c648f094a7717871bbe5322e61254e2ce23c2
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:02:49 +0000 (16:02 +0200)]
Default constructors in action-api module
Change-Id: I0ac01140d94cd55e6e15eabe00361a14866aa43f
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:22:45 +0000 (16:22 +0200)]
Default constructors in activity-log-api module
Change-Id: Ibf61aaae8a8023b528eac5982e1488c26060a3e1
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:28:00 +0000 (16:28 +0200)]
Default constructors in model-api module
Change-Id: I9db997ab2ffc21aa6d6a31e9248aba65672da0ad
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 14:59:26 +0000 (16:59 +0200)]
Default constructors in vendor-license-api module
Change-Id: I27d68b0e9d2eb73e044a11433358f697d692cd4a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 15:05:21 +0000 (17:05 +0200)]
Default ctors in vendor-software-product module
Change-Id: I7e852d649c56d6c25f68d9e20c1682f4c3deca0a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:13:47 +0000 (17:43 +0530)]
Fixed sonar issues - ItemProperties
Fixed all sonar issues
Change-Id: Iccf3bd86156ece8d3dbc719f7fe40b8356b2710e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:10:55 +0000 (17:40 +0530)]
Fixed sonar issues - ConfigConstants
Fixed all sonar issues
Change-Id: I2b7657076aa2a296531a0c3677777ea6001102c4
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:40:20 +0000 (15:10 +0530)]
Refactored as discussed - OrchestrationUtil
Remvoed exception handling and Constructor fix
Change-Id: I6a97f31d429848fa3c008892c48358bc7f67536a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix sonar issues -HeatToToscaUtil
Changed as per comments provided
Change-Id: I4787b99b2a8629dbf2c1a68995546e185778f5e8
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
avigaffa [Thu, 28 Dec 2017 07:34:47 +0000 (09:34 +0200)]
Fixing sonar Exception Handling
Change-Id: I0afe103b921ea26de8f701e9a2cff7943ab58110
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
vempo [Thu, 28 Dec 2017 15:12:44 +0000 (17:12 +0200)]
Fixed broken mapping of ChoiceOrOther
ChoiceOrOther needs default constructor to be recreated by reflection
Change-Id: I194ced8b5e6a60f0dbe6f9b73715cd36c70f5163
Issue-ID: SDC-830
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:28:32 +0000 (15:58 +0530)]
Fixed sonar issues - OrchestrationUploadFactory
Fixed all sonar issues except exception handling
Change-Id: I694a37df40ef05a6217d2f6db41cd7b15ba1e10e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:44:02 +0000 (18:14 +0530)]
Refactored - ProcessManagerImpl
Refactored as per given comment
Change-Id: I366fc8ac93ce977143adbc3a4698ed5f11010405
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 12:25:08 +0000 (17:55 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I49f566c7babebf395a689846734f4932f150a9f8
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 11:09:18 +0000 (16:39 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I5419848dd28e1c2276c995308dcdff55c624dd8b
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Thu, 28 Dec 2017 05:09:55 +0000 (10:39 +0530)]
Fixed sonar issues - ImageManagerImpl
Fixed all sonar issues and refactored as per given comment
Change-Id: I86ec2ac3f72eae3fea5291664865a1c3b4c57791
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix Sonar violations - ConfigurationDataSource
1. Fixed major sonar violations configuration management core
- ConfigurationDataSource
Change-Id: Iee96111b3051a67d25f99a0ba49e99f4d9290345
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:38:14 +0000 (20:08 +0530)]
Fix Sonar violations - AggregateConfiguration
1. Fixed major sonar violations configuration management core
- AggregateConfiguration
Change-Id: I311d0e84fbfaf936ec1a260898e0cc0090e05be9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:45:17 +0000 (20:15 +0530)]
Fix Sonar violations - ConfigurationRepository
1. Fixed major sonar violations configuration management core
- ConfigurationRepository
Change-Id: Iab756af7ffae63fe9e644d733225908d121cbd9a
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:17:44 +0000 (19:47 +0530)]
Fix Sonar violations - AgglomerateConfiguration
1. Fixed major sonar violations configuration management core
- AgglomerateConfiguration
Change-Id: I1f79df3a1d256aeb45b82d344c507d40f6b83026
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:16:30 +0000 (15:46 +0530)]
Fixing sonar qube issues
Refactoring the code as per review comments.
Change-Id: I1edd457f8d0989f815cbf3f28fa0a5124a8c4ac7
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 14:09:34 +0000 (16:09 +0200)]
sonar issue fix - remove dead code
remove dead code.
Issue-ID: SDC-804
Change-Id: I1bae8d3d338730dfad72b155eacebc8e1f5c838f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:05:46 +0000 (19:35 +0530)]
Fix Sonar violations - ConfigurationFilter
1. Fixed major sonar violations configuration management core
- ConfigurationFilter
Change-Id: I6fa69a894854026c32ab7e81d7c3749c7bd16841
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Wed, 27 Dec 2017 08:17:10 +0000 (13:47 +0530)]
Fixed sonar issues - YamlUtil
Fixed violations and Added Copyright. Created constants
Change-Id: I061ed453ed3706410b49774ee2bd0572a1c3a36f
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 09:58:38 +0000 (15:28 +0530)]
Fix sonar issues - Common Methods
Junit and Logger removed
Change-Id: Ic1a987600a8a5ab8c236be242f0f0cd12faf9624
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
talio [Wed, 27 Dec 2017 10:59:05 +0000 (12:59 +0200)]
Add tests
Add unit tests for ToscaTreeManager
Change-Id: I772b63799cd34b687e6c81cb235c1c9a36ad34a2
Issue-ID: SDC-802
Signed-off-by: talio <tali.orenbach@amdocs.com>
mojahidi [Wed, 27 Dec 2017 13:06:28 +0000 (18:36 +0530)]
Fixed sonar issues - OrchestrationTemplateCandidat
Fixed all sonar issues
Change-Id: I3490d2299053475e79354526a854be99ebc5b9de
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
avigaffa [Wed, 27 Dec 2017 12:42:46 +0000 (14:42 +0200)]
Validate notification framework called in test
Call to ItemPermissionsManagerImplTest
Change-Id: I8b1f0e42c0f7b4ebf821f18e9fbbb801f95052c9
Issue-ID: SDC-803
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:39:24 +0000 (18:09 +0530)]
Fixed sonar issues - NetworkManagerImpl
Fixed all sonar issues
Change-Id: I0baf7c56a68b60a8635dd88638a287098e685b31
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:51:50 +0000 (16:21 +0530)]
Fixing sonar qube issues
Removed commented code from MapValidationFileResponseToValidationFileResponseDto file.
Change-Id: I03eca70fe5bc6dfed8ca7762b298e8f83f2ee628
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:17:14 +0000 (17:47 +0530)]
Fixed sonar issues - MonitoringUploadsManagerImpl
Fixed all sonar issues except exception handling
Change-Id: I799c2d485b509469f6b58b36654b2ee71d97f8c6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:16:35 +0000 (14:46 +0530)]
Refactored as per given comment
Removed exception handling fixes
Change-Id: Ie5a89783a63ebcf4b404db4f2b8be2c7b2140e50
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:54:18 +0000 (17:24 +0530)]
Fixed sonar issues - ComputeManagerImpl
Fixed all sonar issues
Change-Id: I04a06aadcf5b142334f571949b22778fa393fcc8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:46:54 +0000 (17:16 +0530)]
Fixed sonar issues - ComponentManagerImpl
Fixed all sonar issues
Change-Id: I2cc957cea740c2410c6b5d98e3335a3b1c1684e1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:48:42 +0000 (11:18 +0530)]
Fixed sonar issues - NotSupportedHeatOnboardMethod
Fixed all sonar issues
Change-Id: I877e1bdccf63a20a618dabfa9176d94cf023d2b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 05:18:24 +0000 (10:48 +0530)]
Fix sonar issues
Removed default constructor and changed few access modifier
Change-Id: Ibc669a1e8973fd6d7f90e474554b4701d1db4c57
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 08:24:27 +0000 (13:54 +0530)]
Fix sonar issues - TranslationContext
Code refactor and variable name change
Change-Id: I528be906feb5255d1b34ed30c7a287ae0d6bb29c
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 12:24:00 +0000 (14:24 +0200)]
Sonar issue Dix - Session is closeable
Cassandra session is closeable and should be protected by try block
Issue-ID: SDC-801
Change-Id: Ib2cc178e029dce1915e2931fe58e4a5d6527dd5f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
sheetalm [Wed, 27 Dec 2017 10:14:02 +0000 (15:44 +0530)]
Fixed sonar issues ToscaFileOutputServiceCsarImpl
Remove unwanted parenthesis. Corrected Copyright
Change-Id: If7cb2a722aa486156d6dc2c1fb90877d0442b3a6
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:41:01 +0000 (16:11 +0530)]
Fixed sonar issues - DeploymentFlavorManagerImpl
Fixed all sonar issues
Change-Id: Ied0cf9f1d5aac4fb97f7fc09bf3233cb5304c4c3
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:16:26 +0000 (15:46 +0530)]
Fixed sonar issues - OrchestrationProcessFactory
Fixed all sonar issues except exception handling
Change-Id: Id1ecf35c157be3c1c9c3f5614bd97b5f8c856e5b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:58:38 +0000 (15:28 +0530)]
Fixed sonar issues - OrchestrationTemplateProcess
Fixed all sonar issues
Change-Id: I9f706783dfc8ce794b018c3f65a78754e43e9dc0
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:43:06 +0000 (15:13 +0530)]
Fixed sonar issues - OrchestrationTemplateProcess
Fixed all sonar issues
Change-Id: Ib6664ac0837ffe83dbdf9afa7d0f6f0dc53e853f
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 07:31:30 +0000 (13:01 +0530)]
Fixed sonar issues - CSARConstants
Fixed all sonar issues
Change-Id: Ia0db69f41abe5557faf1e845590ba98f667bea1e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:50:50 +0000 (11:20 +0530)]
Fixed sonar issues - OnboardingMethodErrorBuilder
Fixed all sonar issues
Change-Id: Iec00a6d2b8028861fdab6e34e17d421fe3de1334
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:45:13 +0000 (11:15 +0530)]
Fixed sonar issues - ImageErrorBuilder
Fixed all sonar issues
Change-Id: I1a4f289524425999f019817cbc8df060d83e252b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:49:03 +0000 (12:19 +0530)]
Fix sonar issues - ResourceWalker
Code refactor and Javadoc
Change-Id: Ic14f3fe0cc8e1903ec3ec73b9a6b63a694e0db81
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:35:52 +0000 (15:05 +0530)]
Fixing sonar qube issues
Added Override annotation to method and removed runtime exception from method specification.
Change-Id: I12640d880c262fc301cafe8ede228e2a4772af88
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:21:38 +0000 (14:51 +0530)]
Fixing sonar qube issues
Fixed critical , major , minor issues in DefaultOutput class. Updated license header.
Change-Id: Ie79498108433c5cc16a3adb04c6f6072724d381d
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 09:12:51 +0000 (14:42 +0530)]
Sonar fixes for module - Configuration mgmt api
1. Fixed major sonar violations configuration management api module
Change-Id: I83863213e35cf092ffd1c1ff84f408318d5ce8e9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
Michael Lando [Wed, 27 Dec 2017 08:20:55 +0000 (10:20 +0200)]
sonar plug in test
Change-Id: I22f2680267edf4dabe21dd6736fa71f88000628c
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
shrek2000 [Wed, 27 Dec 2017 08:10:56 +0000 (10:10 +0200)]
Avoid Null Pointer
Change-Id: Ie6f78934a1c6407a05bd988fb234bf5662fb26e8
Issue-ID: SDC-799
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Idan Amit [Tue, 26 Dec 2017 16:01:01 +0000 (18:01 +0200)]
Fix documentation offered APIs
Replace the Read the Docs offered APIs to show the correct swagger.json data
Change-Id: Ife2fddca2646a169d538ded5d84f0afbec104184
Issue-ID: SDC-754
Signed-off-by: Idan Amit <ia096e@intl.att.com>
mojahidi [Wed, 27 Dec 2017 05:56:38 +0000 (11:26 +0530)]
Fixed sonar issues -NicInternalNetworkErrorBuilder
Fixed all sonar issues
Change-Id: I206a6529b85c501f06747178ff0571b7547428ad
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 07:40:11 +0000 (09:40 +0200)]
Avoid Null Pointer
Change-Id: I91eb26e842495271017d0c918bdae81d03c192f2
Issue-ID: SDC-797
Signed-off-by: shrek2000 <orenkle@amdocs.com>
mojahidi [Wed, 27 Dec 2017 08:50:14 +0000 (14:20 +0530)]
Fixed sonar issues - OrchestrationTemplateFileHand
Fixed all sonar issues
Change-Id: Ieece2d0e081a918e841e8ecbaf2b6af1a5d0f3b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:13:21 +0000 (11:43 +0530)]
Fix sonar issues
Modified access modifier and few refactor
Change-Id: I9386cce2dd90c411a262b3dbc0b95525dd1362c5
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Wed, 27 Dec 2017 07:28:58 +0000 (12:58 +0530)]
Fixed sonar issues - OnboardingManifest
Fixed all sonar issues
Change-Id: I7f07c7dba6713e76b24ad5bb4bf994a867769edc
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:53:59 +0000 (11:23 +0530)]
Fixed sonar issues - DeploymentFlavorErrorBuilder
Fixed all sonar issues
Change-Id: I528de8e970f40b03af183f499bd9ff61792c174a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talio [Wed, 27 Dec 2017 08:40:47 +0000 (10:40 +0200)]
fix TOSCA structure tree
when uploading a csar with two different directories that share the same name, the files structure that appears on the validation screen shows all of the files written under the same directory. this issue got fixed
Change-Id: I6da7399271fa1cde384f6feb51d60724584aa8f9
Issue-ID: SDC-535
Signed-off-by: talio <tali.orenbach@amdocs.com>
ojasdubey [Wed, 13 Dec 2017 10:53:43 +0000 (16:23 +0530)]
Simplified the return condition
Note: Sonar violations will be handled as a separate
task
Change-Id: I862247f5c693f4d64dff4ce18f2f71e42c85355a
Issue-ID: SDC-749
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
Code Review / sdc.git / log