so.git
4 years agostore heat env file sent to heat 18/92018/1
Gamboa, Gilbert [Thu, 25 Jul 2019 15:10:05 +0000 (11:10 -0400)]
store heat env file sent to heat

Initial commit, include heat environment info in cloud-api_requests.
Updated MSOHeatUtilsTest.saveStackTest unit test to assert
cloudApiRequests requestBody

Issue-ID: SO-2158
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I333cae7746459917ba5e64feb07db4f710b8d99b

4 years agoMerge "Fix delete of generic neutron network"
Seshu Kumar M [Thu, 25 Jul 2019 09:41:15 +0000 (09:41 +0000)]
Merge "Fix delete of generic neutron network"

4 years agoFix delete of generic neutron network 71/91971/1
Eric Multanen [Thu, 25 Jul 2019 05:36:13 +0000 (22:36 -0700)]
Fix delete of generic neutron network

Delete of Generic Neutron network was not working.
Logic checking for association with vf-module appears to
have been reversed.

Change-Id: If541c1133322f75c70f86cd77d8bccd88b94f356
Issue-ID: SO-2082
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
4 years agoset multi-stage flag in listener to log success 60/91960/1
Mnushkin, Dmitry [Wed, 24 Jul 2019 16:44:16 +0000 (12:44 -0400)]
set multi-stage flag in listener to log success

set multi-stage flag in listener to log success msg
added post listener for requests db object

Issue-ID: SO-2153
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I4b27cbb69b983bd2f7c0d72c8ebb4d9c43201120

4 years agoMerge "Major Sonar fixes in InstanceManagement"
Steve Smokowski [Wed, 24 Jul 2019 15:02:34 +0000 (15:02 +0000)]
Merge "Major Sonar fixes in InstanceManagement"

4 years agoMerge "Removed not used loggers"
Steve Smokowski [Wed, 24 Jul 2019 15:02:17 +0000 (15:02 +0000)]
Merge "Removed not used loggers"

4 years agoMerge "Major Sonar fixes in E2EServiceInstances"
Steve Smokowski [Wed, 24 Jul 2019 15:00:37 +0000 (15:00 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"

4 years agoMerge "Major Sonar fixes"
Steve Smokowski [Wed, 24 Jul 2019 14:59:27 +0000 (14:59 +0000)]
Merge "Major Sonar fixes"

4 years agoMerge "enhance get orchestration request"
Steve Smokowski [Wed, 24 Jul 2019 14:59:12 +0000 (14:59 +0000)]
Merge "enhance get orchestration request"

4 years agoMerge "Update SO to handle Async VNF operations to SDNC"
Steve Smokowski [Wed, 24 Jul 2019 14:59:09 +0000 (14:59 +0000)]
Merge "Update SO to handle Async VNF operations to SDNC"

4 years agoRemoved not used loggers 29/91929/1
r.bogacki [Wed, 24 Jul 2019 08:45:01 +0000 (10:45 +0200)]
Removed not used loggers

-Removed unnecessary loggers according to Sonar.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I05a0cc3187692fa17a6734d1c2a6be33d4b5ee34

4 years agoMajor Sonar fixes in InstanceManagement 16/91916/1
r.bogacki [Wed, 24 Jul 2019 07:06:26 +0000 (09:06 +0200)]
Major Sonar fixes in InstanceManagement

-Removed unnecessary code.
-Removed unused variables.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb

4 years agoMajor Sonar fixes in E2EServiceInstances 14/91914/1
r.bogacki [Wed, 24 Jul 2019 06:57:43 +0000 (08:57 +0200)]
Major Sonar fixes in E2EServiceInstances

-Removed unnecessary code.
-Removed unused variables.
-Introduced constants for repeating Strings.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4ac692849508178390796d149b2c3f2fddcd093b

4 years ago- Converted NetworkResource to use the parser 75/91875/1
Merkel, Jeff [Tue, 23 Jul 2019 15:43:21 +0000 (11:43 -0400)]
- Converted NetworkResource to use the parser

- Converted NetworkResource to use the parser getEntity method.
- run the formatting command so that it aligns correctly.

Issue-ID: SO-2147
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id6aa6c2967ec4014d6512851fa7dfff088946081

4 years agoMajor Sonar fixes 45/91845/1
r.bogacki [Tue, 23 Jul 2019 07:20:28 +0000 (09:20 +0200)]
Major Sonar fixes

Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
-Improved String comparisons in equals.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f

4 years agoMerge "Enhanced List Level flow with backward support"
Seshu Kumar M [Tue, 23 Jul 2019 05:30:31 +0000 (05:30 +0000)]
Merge "Enhanced List Level flow with backward support"

4 years agoenhance get orchestration request 11/91811/1
Plummer, Brittany [Mon, 22 Jul 2019 13:44:15 +0000 (08:44 -0500)]
enhance get orchestration request

Enhance get orchestration request to include workflow step
Began working on adding call for activity name
Added call to return activity information
Updated to return last task executed
Added last task executed info to returned string
Updated mocks to fix failing unit tests
Added responses for mocks to Camunda for process and activity history
Added tests to cover taskName changes
Began adding tests to cover changes to RequestHandlerUtils
Added more unit tests for activity lookup
Updated error messages for taskName
Moved properties to application.yaml file
Added unit tests to add more coverage to task retrieval
Moved Camunda calls to CamundaRequestHandler class
Removed unused imports from RequestHandlerUtils
Fixed formatting of tests and removed handler where not used
Removed CamundaRequestHandler from JerseyConfiguration
Added retryTemplate for camunda calls

Issue-ID: SO-2142
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a

4 years agoUpdate SO to handle Async VNF operations to SDNC 10/91810/1
Smokowski, Steven [Mon, 22 Jul 2019 13:42:42 +0000 (08:42 -0500)]
Update SO to handle Async VNF operations to SDNC

Update SO to handle Async VNF operations to SDNC

Issue-ID: SO-2141
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I20037306e9ce5b8df434511a46c0a3399e335c3d

4 years agoMerge "Added servicename to MDC so that it gets logged"
Steve Smokowski [Mon, 22 Jul 2019 13:17:29 +0000 (13:17 +0000)]
Merge "Added servicename to MDC so that it gets logged"

4 years agoVulnerability fixes in ServicePluginFactory 98/91798/1
r.bogacki [Mon, 22 Jul 2019 09:28:57 +0000 (11:28 +0200)]
Vulnerability fixes in ServicePluginFactory

Sonar vulnerability fixes in ServicePluginFactory:
-Added logger.

Issue-ID: SO-2139
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca

4 years agoAdded servicename to MDC so that it gets logged 97/91697/2
Boslet, Cory [Thu, 18 Jul 2019 20:20:38 +0000 (16:20 -0400)]
Added servicename to MDC so that it gets logged

Added servicename to MDC so that it gets logged and added enter and
exit markers.

Issue-ID: SO-2122
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead

4 years agoMerge "basic auth for so-monitoring"
Byung-Woo Jun [Fri, 19 Jul 2019 13:58:55 +0000 (13:58 +0000)]
Merge "basic auth for so-monitoring"

4 years agobasic auth for so-monitoring 94/90794/5
k.kazak [Fri, 19 Jul 2019 12:59:18 +0000 (14:59 +0200)]
basic auth for so-monitoring

Add basic auth for so-monitoring app
Issue submitted in pentest report

Change-Id: I8e826da9b9f66e893826fd9b40b3b26623b2ab8d
Issue-ID: OJSI-169
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoMerge "Set networkName value to the name from L3network"
Steve Smokowski [Fri, 19 Jul 2019 12:04:33 +0000 (12:04 +0000)]
Merge "Set networkName value to the name from L3network"

4 years agoMerge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"
Steve Smokowski [Thu, 18 Jul 2019 20:41:44 +0000 (20:41 +0000)]
Merge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"

4 years agoMerge "Commented out updatedAttribute declaration to prevent static analyzer warning...
Steve Smokowski [Thu, 18 Jul 2019 20:41:30 +0000 (20:41 +0000)]
Merge "Commented out updatedAttribute declaration to prevent static analyzer warning about unused variable"

4 years agoMerge changes I5e72e1c6,I5e1cb624
Steve Smokowski [Thu, 18 Jul 2019 20:40:57 +0000 (20:40 +0000)]
Merge changes I5e72e1c6,I5e1cb624

* changes:
  Added null check for function param pFqdns to prevent crash at for loop.
  Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning

4 years agoMerge "Fix error updating request_processing_data"
Steve Smokowski [Thu, 18 Jul 2019 20:40:14 +0000 (20:40 +0000)]
Merge "Fix error updating request_processing_data"

4 years agoMerge "Remove duplicate name check in createAAITasks."
Steve Smokowski [Thu, 18 Jul 2019 20:40:04 +0000 (20:40 +0000)]
Merge "Remove duplicate name check in createAAITasks."

4 years agoSet networkName value to the name from L3network 00/91700/1
Kuleshov, Elena [Thu, 18 Jul 2019 20:40:01 +0000 (16:40 -0400)]
Set networkName value to the name from L3network

Set networkName value to the name from L3network object.
Add JUnit argument captures for naming creates
Fix formatting errors in the JUnit file.

Issue-ID: SO-2123
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ie4d2bd86f1a47bd5742aa7786dc9cba47fa11392

4 years agoRemoving application-local.yaml files 94/91694/1
Roy, Amresh [Thu, 18 Jul 2019 19:21:23 +0000 (14:21 -0500)]
Removing application-local.yaml files

Removing the application-local.yaml files because they're no longer
maintained or working.

Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359

4 years agoFix error updating request_processing_data 92/91692/1
Gamboa, Gilbert [Thu, 18 Jul 2019 18:37:21 +0000 (14:37 -0400)]
Fix error updating request_processing_data

Fix error when updating existing record in request_processing_data
table.
Use correct field name in the toString method in RequestProcessingData
bean class.
RequestDbClient.updateRequestProcessingData should include entity id in
the URI on the PUT request.
Add new Config class ExposeEntityIdResourceConfiguration to make
Spring data Rest return id in the response for RequestProcessingData.
Make spring-boot-starter-data-rest not optional dependency in
mso-requests-db-repositories
Added unit test for RequestDbClient.updateRequestProcessingData()
method.

Issue-ID: SO-2120
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I733be06185e5c19a0b7112918ce0a0f2abf861d7

4 years agoMerge "Implement TLS for calls from VNFM adapter to VNFM"
Steve Smokowski [Thu, 18 Jul 2019 18:22:15 +0000 (18:22 +0000)]
Merge "Implement TLS for calls from VNFM adapter to VNFM"

4 years agoRemove duplicate name check in createAAITasks. 81/91681/1
Gamboa, Gilbert [Thu, 18 Jul 2019 15:28:01 +0000 (11:28 -0400)]
Remove duplicate name check in createAAITasks.

Remove duplicate name check in createAAITasks. This hould be done prior
to status check in WorkflowAction or BBInputSetup.

Issue-ID: SO-2119
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89

4 years agoMerge "Commented out initialization of workflowResponse to prevent static analyzer...
Steve Smokowski [Thu, 18 Jul 2019 11:55:25 +0000 (11:55 +0000)]
Merge "Commented out initialization of workflowResponse to prevent static analyzer warning about workflowResponse never being set to anything but null."

4 years agoMerge "Fixes in WorkflowAction"
Steve Smokowski [Thu, 18 Jul 2019 11:53:25 +0000 (11:53 +0000)]
Merge "Fixes in WorkflowAction"

4 years agoMerge "Major Sonar fixes"
Steve Smokowski [Thu, 18 Jul 2019 11:53:09 +0000 (11:53 +0000)]
Merge "Major Sonar fixes"

4 years agoMerge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Thu, 18 Jul 2019 11:52:22 +0000 (11:52 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"

4 years agoMerge "Add requestContext to unassignVfModule tasks and"
Steve Smokowski [Thu, 18 Jul 2019 11:52:03 +0000 (11:52 +0000)]
Merge "Add requestContext to unassignVfModule tasks and"

4 years agoMerge "Add SO BPMN name for NAME in tbl workflow"
Steve Smokowski [Thu, 18 Jul 2019 11:51:52 +0000 (11:51 +0000)]
Merge "Add SO BPMN name for NAME in tbl workflow"

4 years agoMerge "We need to expand column request_status"
Steve Smokowski [Thu, 18 Jul 2019 11:51:36 +0000 (11:51 +0000)]
Merge "We need to expand column request_status"

4 years agoImplement TLS for calls from VNFM adapter to VNFM 65/91665/1
MichaelMorris [Thu, 18 Jul 2019 11:42:07 +0000 (11:42 +0000)]
Implement TLS for calls from VNFM adapter to VNFM

Issue-ID: SO-2116
Change-Id: I1e5bdfcf3164545c89fb370014d49ef3ae6a9cf1
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoAdd SO BPMN name for NAME in tbl workflow 42/91642/1
Bonkur, Venkat (vb8416) [Thu, 18 Jul 2019 04:30:31 +0000 (00:30 -0400)]
Add SO BPMN name for NAME in tbl workflow

Added  SO update the R__WorkflowDesignerData.sql  script to insert name of BPMN process
instead of  description in the NAME field of workflow table for VnfInPlaceUpdate and
VnfConfigUpdate
Issue-ID: SO-2112
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I288a1159e95c3798c37ff41a599662e5df8317ba

4 years agoAdd requestContext to unassignVfModule tasks and 32/91632/1
Mcblain, Thomas [Wed, 17 Jul 2019 22:42:01 +0000 (18:42 -0400)]
Add requestContext to unassignVfModule tasks and

Add requestContext to unassignVfModule tasks and tests

Issue-ID: SO-2115
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ifddfe32fab9406afb69ad9192351500cfbed3610

4 years agoWe need to expand column request_status 30/91630/1
Gamboa, Gilbert [Wed, 17 Jul 2019 21:36:28 +0000 (17:36 -0400)]
We need to expand column request_status

New script to expand column request_status on table
archived_infra_requests as well.

Issue-ID: SO-2114
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: Ife1168e658bbb9e7fa69541de42173947564cac8

4 years agoadd query stack data and populate table step 23/91623/2
Boslet, Cory [Wed, 17 Jul 2019 17:36:05 +0000 (13:36 -0400)]
add query stack data and populate table step

Need to check if audit is enabled first in the delete record task
Updates to audit delete redeisgn and data to table
Various updates to logging, audit object, added tag to query, updated
tag value.
Updated write method to make sure an entry for this heat stack doesnt
already exist to avoid duplicate entrys
Updated unit test to account for get query
Added so that id is not hidden from query results
Updated the was delete is done plus minor updates.
Updated delete method to use resttemplate instead of bowman client
Combined the write and get stack data task into the external tasks.
Removed the task to delete the stack data from db
Updates to junit request id so its not a random id for test
Updated service tasks in att BB to call external task
Update to be a real uuid format due to failing unit test
Updated fields to protected and updated unit test

Issue-ID: SO-2111
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f

4 years agoAdded null check for yaml to prevent crash at 28/91428/1
Oleksandr Moliavko [Mon, 15 Jul 2019 07:20:42 +0000 (10:20 +0300)]
Added null check for yaml to prevent crash at
getParameterListFromEnvt()

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3

4 years agoFixing ASDCRestInterface for CSIT to simulate SDC req 85/91385/1
waqas.ikram [Fri, 12 Jul 2019 16:51:59 +0000 (17:51 +0100)]
Fixing ASDCRestInterface for CSIT to simulate SDC req

Change-Id: I6331d08441b9bf1f621f56ec1b7d911851010e62
Issue-ID: SO-1948
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
4 years agoCommented out updatedAttribute declaration to prevent 59/91359/1
Oleksandr Moliavko [Fri, 12 Jul 2019 12:29:32 +0000 (15:29 +0300)]
Commented out updatedAttribute declaration to prevent
static analyzer warning about unused variable

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0d46bcc817d08a6fbad3501c56336dc532bb5907

4 years agoAdded null check for function param pFqdns to 50/91150/2
Oleksandr Moliavko [Wed, 10 Jul 2019 11:04:26 +0000 (14:04 +0300)]
Added null check for function param pFqdns to
prevent crash at for loop.

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae

4 years agoCommented out initialization of workflowResponse to prevent 45/90945/4
Oleksandr Moliavko [Fri, 5 Jul 2019 12:14:07 +0000 (15:14 +0300)]
Commented out initialization of workflowResponse to prevent
static analyzer warning about workflowResponse never being
set to anything but null.

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib150e3836fda9b7d9785a574f904b2c61bfa39f4

4 years agoAdded check for null ptr before dereferencing at 91/91091/3
Oleksandr Moliavko [Tue, 9 Jul 2019 13:33:07 +0000 (16:33 +0300)]
Added check for null ptr before dereferencing at
gBBInput.getCustomer().getServiceSubscription() -
to prevent static analyzer warning

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70

4 years agoFixes in WorkflowAction 42/91142/3
r.bogacki [Wed, 10 Jul 2019 09:29:37 +0000 (11:29 +0200)]
Fixes in WorkflowAction

Fixes in WorkflowAction according to the Sonar analysis:
-Fixed String comparison.
-Removed unnecessary method parameters.
-Updated junit test.

Issue-ID: SO-2107
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I7522269e237f736521a627bcd1c8f77b0c776a70

4 years agoMajor Sonar fixes 40/91140/2
r.bogacki [Wed, 10 Jul 2019 09:09:31 +0000 (11:09 +0200)]
Major Sonar fixes

Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7

4 years agoVulnerability fixes in ServicePluginFactory 38/91138/2
r.bogacki [Wed, 10 Jul 2019 08:38:42 +0000 (10:38 +0200)]
Vulnerability fixes in ServicePluginFactory

Sonar vulnerability fixes in ServicePluginFactory.
-Moved hardcoded IP addresses to the property file.
-Added junit test.

Issue-ID: SO-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396

4 years agoMerge "Sonar Fix: SDNCAdapterApplication.java"
Steve Smokowski [Thu, 11 Jul 2019 12:48:58 +0000 (12:48 +0000)]
Merge "Sonar Fix: SDNCAdapterApplication.java"

4 years agoMerge "Major Sonar fixes in E2EServiceInstances"
Lukasz Muszkieta [Wed, 10 Jul 2019 07:20:01 +0000 (07:20 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"

4 years agoSonar Fix: SDNCAdapterApplication.java 26/91126/1
Arundathi Patil [Wed, 10 Jul 2019 03:53:11 +0000 (09:23 +0530)]
Sonar Fix: SDNCAdapterApplication.java

Removed unused imports from the file

Issue-ID: SO-2103
Change-Id: Id126f5203789d866b340d86b55bbc616991afc99
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "Sonar fix in CreateInventoryTask.java"
Marcus Williams [Tue, 9 Jul 2019 19:36:38 +0000 (19:36 +0000)]
Merge "Sonar fix in CreateInventoryTask.java"

4 years agoMerge "Sonar fixes in ManualTasks"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:24:19 +0000 (17:24 +0000)]
Merge "Sonar fixes in ManualTasks"

4 years agoMerge "Sonar fixes in OrchestrationRequests"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:22:41 +0000 (17:22 +0000)]
Merge "Sonar fixes in OrchestrationRequests"

4 years agoMajor Sonar fixes 87/91087/1
r.bogacki [Tue, 9 Jul 2019 12:10:53 +0000 (14:10 +0200)]
Major Sonar fixes

Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59

4 years agoSonar fixes in OrchestrationRequests 83/91083/1
r.bogacki [Tue, 9 Jul 2019 11:45:37 +0000 (13:45 +0200)]
Sonar fixes in OrchestrationRequests

Sonar fixes in OrchestrationRequests according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused variables.

Issue-ID: SO-2101
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5

4 years agoSonar fixes in ManualTasks 82/91082/1
r.bogacki [Tue, 9 Jul 2019 11:31:36 +0000 (13:31 +0200)]
Sonar fixes in ManualTasks

Code fixes in ManualTasks according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused imports.
-Removed unused variables.

Issue-ID: SO-2100
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0

4 years agoMajor Sonar fixes in E2EServiceInstances 80/91080/1
r.bogacki [Tue, 9 Jul 2019 11:05:34 +0000 (13:05 +0200)]
Major Sonar fixes in E2EServiceInstances

Major code fixes in E2EServiceInstances according to the Sonar analysis.
-Removed unnecessary code.
-Removed unnecessary method parameters.
-Removed unused variables.

Issue-ID: SO-2099
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d

4 years agoSonar fix in CreateInventoryTask.java 58/91058/1
Arundathi Patil [Tue, 9 Jul 2019 03:05:24 +0000 (08:35 +0530)]
Sonar fix in CreateInventoryTask.java

Fixed multiple sonar issues in this file

Issue-ID: SO-2098
Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "remove unneeded code"
Steve Smokowski [Mon, 8 Jul 2019 15:27:43 +0000 (15:27 +0000)]
Merge "remove unneeded code"

4 years agoMerge "Added null check to prevent call of getVnfResources() method for null vf object"
Steve Smokowski [Mon, 8 Jul 2019 15:26:41 +0000 (15:26 +0000)]
Merge "Added null check to prevent call of getVnfResources() method for null vf object"

4 years agoMerge "Added null check for heatStack to prevent crash at getCanonicalName() call"
Steve Smokowski [Mon, 8 Jul 2019 14:19:14 +0000 (14:19 +0000)]
Merge "Added null check for heatStack to prevent crash at getCanonicalName() call"

4 years agoMerge "add junit coverage for VnfmHelper"
Steve Smokowski [Mon, 8 Jul 2019 14:18:29 +0000 (14:18 +0000)]
Merge "add junit coverage for VnfmHelper"

4 years agoMerge "Fixed sonar issue in QueryGroups.java"
Seshu Kumar M [Mon, 8 Jul 2019 13:03:04 +0000 (13:03 +0000)]
Merge "Fixed sonar issue in QueryGroups.java"

4 years agoFixed sonar issue in QueryGroups.java 75/90975/1
Arundathi Patil [Fri, 5 Jul 2019 17:13:42 +0000 (22:43 +0530)]
Fixed sonar issue in QueryGroups.java

Fixed sonar issues across this file

Issue-ID: SO-2096
Change-Id: Ib2b9fb5d12da2eb1f99562466c5a5d9039b0e50f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agomso will support new requeststate values 56/90956/1
Gamboa, Gilbert [Fri, 5 Jul 2019 14:30:58 +0000 (10:30 -0400)]
mso will support new requeststate values

Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED.
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request
status in case rollback is not needed.
Variable rollbackTargetState needs to be returned to WorkflowAction flow
Variable rollbackTargetState needs to in to ExecuteBuildingBlock as
well. Add new RequestDb migration file to expand infra_active_requests
column request_status to 25 bytes to fit new request states.

Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197
Issue-ID: SO-2093
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoupdate bpmn to save extsystemerrorsource 55/90955/1
Plummer, Brittany [Fri, 5 Jul 2019 14:23:16 +0000 (10:23 -0400)]
update bpmn to save extsystemerrorsource

Added ext error source to workflow exception
Updated all lines that create this exception with source
Added unit tests and updated existing ones

Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb
Issue-ID: SO-2092
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoadd junit coverage for VnfmHelper 37/90937/1
Lukasz Muszkieta [Fri, 5 Jul 2019 10:20:32 +0000 (12:20 +0200)]
add junit coverage for VnfmHelper

Change-Id: I0db84333f1c5ffa09ec78f504a101b75343157a3
Issue-ID: SO-1576
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agofix global-jjb migration issue 05/90905/1
sarada prasad sahoo [Thu, 4 Jul 2019 12:57:00 +0000 (18:27 +0530)]
fix global-jjb migration issue

fix global-jjb migration issue
- VNFSDK, SO

Issue-ID: SO-1992
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I2e11f0c151c54151e526efdebf92f49621dc0f7f

4 years agoremove unneeded code 90/90890/1
Lukasz Muszkieta [Thu, 4 Jul 2019 10:59:01 +0000 (12:59 +0200)]
remove unneeded code

Change-Id: Ib7c692b2a7fd8bc5f40d6a4acba504948cc7fc1b
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agofix global-jjb migration issue 87/90887/1
sarada prasad sahoo [Thu, 4 Jul 2019 09:25:01 +0000 (14:55 +0530)]
fix global-jjb migration issue

fix global-jjb migration issue
- VNFSDK, SO

Issue-ID: SO-1992
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: Idaee5994614a9264e0b0edc57be6e529a343b807

4 years agoAdded null check to prevent call of getVnfResources() method 74/90774/1
Oleksandr Moliavko [Tue, 2 Jul 2019 11:30:18 +0000 (14:30 +0300)]
Added null check to prevent call of getVnfResources() method
for null vf object

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0c2ea5de5ed9ab55ad78f58f3a68241e7cb2d064

4 years agoAdded null check for heatStack to prevent crash at 62/90762/1
Oleksandr Moliavko [Tue, 2 Jul 2019 06:59:15 +0000 (09:59 +0300)]
Added null check for heatStack to prevent crash at
getCanonicalName() call

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Icf49b7db336002ad56769b221ec61101fac04fd5

4 years agoEnhanced List Level flow with backward support 33/89633/5
sarada prasad sahoo [Fri, 7 Jun 2019 09:16:36 +0000 (14:46 +0530)]
Enhanced List Level flow with backward support

Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.

Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
4 years agoMerge "do not overwrite status message with rollback"
Steve Smokowski [Mon, 1 Jul 2019 17:41:52 +0000 (17:41 +0000)]
Merge "do not overwrite status message with rollback"

4 years agodo not overwrite status message with rollback 23/90723/1
Mnushkin, Dmitry [Mon, 1 Jul 2019 12:10:54 +0000 (08:10 -0400)]
do not overwrite status message with rollback

update rollback error for rollback and not original msg
run code formatting on updated files
add unit test for false value of isRollback flag

Change-Id: I25d8fb9771766461b1192e3758237dfc199787f8
Issue-ID: SO-2081
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agosupport new query param format 22/90722/1
Chan, Mercy [Mon, 1 Jul 2019 12:07:17 +0000 (08:07 -0400)]
support new query param format

- added format query parameter (optional), implemented logic to
populate requestStatus field based on whether or not format is present
moved request status constants to its own class visible globally.
- changed @requestParam to @QueryParam in GET endpoint
(OrchestrationRequests class. updated unit tests to call method being
tested directly rather than from another private function
- moved setting requestStatus to a separate method, also updated unit
tests to separate out each scenarion into its own method
- added unit test for when format=detail, corrected existing unit tests
to test result to be FAILED
- updated Status.java to include extra request status values; moved
Status class to common org.onap.so.constants package

Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260
Issue-ID: SO-2080
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoAdded check for null response to prevent crash at 08/90708/3
Oleksandr Moliavko [Mon, 1 Jul 2019 09:11:50 +0000 (12:11 +0300)]
Added check for null response to prevent crash at
response.getEntity() method call.

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Id796f4426f33cf419bbe5ed07500452ac0c7c775

4 years agoenhance workflowaction to handle resume func 33/90533/6
Mnushkin, Dmitry [Wed, 26 Jun 2019 15:14:28 +0000 (11:14 -0400)]
enhance workflowaction to handle resume func

init code for RESUME with junit passing
overwrite URI on resume op from original request

Change-Id: I1eee2bd66aa20804ba4a2834d269b5947565b9dc
Issue-ID: SO-2055
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "improved logging when no exception data is found"
Steve Smokowski [Thu, 27 Jun 2019 18:23:48 +0000 (18:23 +0000)]
Merge "improved logging when no exception data is found"

4 years agoMerge "Update failsafe dependency to 2.0.1"
Steve Smokowski [Thu, 27 Jun 2019 18:23:42 +0000 (18:23 +0000)]
Merge "Update failsafe dependency to 2.0.1"

4 years agoMerge "handle multiple cvnfc configs"
Steve Smokowski [Thu, 27 Jun 2019 18:23:37 +0000 (18:23 +0000)]
Merge "handle multiple cvnfc configs"

4 years agoMerge "add rollback ext system error source"
Steve Smokowski [Thu, 27 Jun 2019 18:23:31 +0000 (18:23 +0000)]
Merge "add rollback ext system error source"

4 years agoimproved logging when no exception data is found 38/90538/2
Benjamin, Max [Wed, 26 Jun 2019 15:35:00 +0000 (11:35 -0400)]
improved logging when no exception data is found

improved logging when no exception data is found

Change-Id: I4f6298652ad474119cd1ebc58a927d532ea3e6be
Issue-ID: SO-2068
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoUpdate failsafe dependency to 2.0.1 36/90536/2
Benjamin, Max [Wed, 26 Jun 2019 15:26:55 +0000 (11:26 -0400)]
Update failsafe dependency to 2.0.1

Updated calls to failsafe 2.0.1 API

Change-Id: I2c86ca02d56a07262e330ee5f8f088d1a1f5b4a7
Issue-ID: SO-2057
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agohandle multiple cvnfc configs 35/90535/2
Merkel, Jeff [Wed, 26 Jun 2019 15:23:02 +0000 (11:23 -0400)]
handle multiple cvnfc configs

- Handle multiple cvnfc configs with the same model uuid.
- Update CvnfcConfigurationCustomization to a List from a Set

Change-Id: I8c026510d813ebb6294a9cedd39d4d4b8f4b9dcf
Issue-ID: SO-2056
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoadd rollback ext system error source 28/90528/2
Plummer, Brittany [Wed, 26 Jun 2019 14:58:22 +0000 (10:58 -0400)]
add rollback ext system error source

Added rollbackExtSystemErrorSource column and updated GET
orchestrationRequests response
Added missing columns from requestDb to schema.sql

Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a
Issue-ID: SO-2054
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoFix macro delete instance bug. 27/90527/2
Gamboa, Gilbert [Wed, 26 Jun 2019 14:53:51 +0000 (10:53 -0400)]
Fix macro delete instance bug.

Fix macro delete instance bug. vf-modules not being sorted correctly
because isbaseboolean field is not being set.

Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47
Issue-ID: SO-2053
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoChanged dependency back to 1.3.0 92/90592/1
Benjamin, Max (mb388a) [Thu, 27 Jun 2019 12:59:30 +0000 (08:59 -0400)]
Changed dependency back to 1.3.0

sdc-distribution-client changed back to 1.3.0

Change-Id: I53fd206c16bdb9c22976b6b671784841923b5295
Issue-ID: SO-2078
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"
Steve Smokowski [Wed, 26 Jun 2019 12:59:48 +0000 (12:59 +0000)]
Merge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"

4 years agoMerge "Security updates for maven dependencies"
Steve Smokowski [Wed, 26 Jun 2019 12:59:43 +0000 (12:59 +0000)]
Merge "Security updates for maven dependencies"

4 years agoMerge "Updated path to match AID for resume requests"
Steve Smokowski [Wed, 26 Jun 2019 12:59:36 +0000 (12:59 +0000)]
Merge "Updated path to match AID for resume requests"

4 years agoMerge "Moved code inside IF checking for null ptr to prevent crash"
Steve Smokowski [Wed, 26 Jun 2019 12:59:31 +0000 (12:59 +0000)]
Merge "Moved code inside IF checking for null ptr to prevent crash"