policy/common.git
6 years agoadd more junit coverage to new Serializer class 13/66413/6
Jim Hahn [Thu, 13 Sep 2018 16:40:37 +0000 (12:40 -0400)]
add more junit coverage to new Serializer class

Removed calls to superclass methods so that appropriate
exceptions are thrown.
Better comments for new tests.
Removed @Ignore from tests.
Removed tabs from pom.

Change-Id: I97fa63951eed4c2ac5ce0a267d8da5134a2a1c71
Issue-ID: POLICY-1106
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoadd utility class to test serializable classes 35/66235/3
Jim Hahn [Wed, 12 Sep 2018 21:47:53 +0000 (17:47 -0400)]
add utility class to test serializable classes

Closed the ByteArrayXxxStreams.
Closed byte output stream, even if exception in object stream.

Change-Id: I3f779a5c0e6df3ac3496abe60a46e0696b4e261c
Issue-ID: POLICY-1106
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoUpgrade dmaap from policy/parent 85/66185/1
Pamela Dragosh [Wed, 12 Sep 2018 17:55:51 +0000 (13:55 -0400)]
Upgrade dmaap from policy/parent

Need the following gerrit review to come in first:
https://gerrit.onap.org/r/#/c/66183/

This will now inherit from policy/parent the latest
dmaap version to be used across all policy projects.

Issue-ID: POLICY-1116
Change-Id: If76895e54d56d153621947da01ca6de2151ead25
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoRemove changing of access on par fields 93/65193/2
liamfallon [Fri, 7 Sep 2018 12:36:41 +0000 (13:36 +0100)]
Remove changing of access on par fields

Parameter handling refactored to remove changing of
access on fields in parameters, new implementation requires
getters to be defined for all fields.

Note: This change causes a knock on into distribution

Change-Id: I172f5d9310caf92d6ea825ff93292019c00a47c3
Issue-ID: POLICY-1095
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoMerge "Remove unused property"
Jorge Hernandez [Tue, 4 Sep 2018 20:11:30 +0000 (20:11 +0000)]
Merge "Remove unused property"

6 years agoRemove unused property 93/64493/1
Pamela Dragosh [Tue, 4 Sep 2018 17:55:24 +0000 (13:55 -0400)]
Remove unused property

Now that we moved to policy/parent, this property isn't
necessary in this repo.

Found this as I was looking into mariadb security issues
for both drools-pdp and engine.

Issue-ID: POLICY-1059
Change-Id: If06e00608fe7f76314c233e806fca5d9150734ae
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdd support for http PUT 07/63807/1
mmis [Thu, 30 Aug 2018 12:34:55 +0000 (13:34 +0100)]
Add support for http PUT

Added support for http PUT for use by the policy forwarder in
policy/distribution

Issue-ID: POLICY-926
Change-Id: Ifa5c2e8be0582797936b95b772ad236f35c10f24
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agoMerge "Improvements to Parameter Srvice"
Pamela Dragosh [Wed, 29 Aug 2018 11:54:54 +0000 (11:54 +0000)]
Merge "Improvements to Parameter Srvice"

6 years agoMerge "Adding usage of openpojo in policy common"
Pamela Dragosh [Tue, 28 Aug 2018 15:22:50 +0000 (15:22 +0000)]
Merge "Adding usage of openpojo in policy common"

6 years agoAdding usage of openpojo in policy common 49/63249/3
ramverma [Tue, 28 Aug 2018 13:09:39 +0000 (14:09 +0100)]
Adding usage of openpojo in policy common

* Changing TestHealthCheckReport to use openpojo for testing the
  HealthCheckReport class.
* Adding a custom Tester implementation called ToStringTester
  as a utility to test toString() method of classes using openpojo.

Change-Id: I491a23c471d50454b4d5591c6c09c6758e2c0624
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoImprovements to Parameter Srvice 51/63251/1
liamfallon [Tue, 28 Aug 2018 13:13:02 +0000 (14:13 +0100)]
Improvements to Parameter Srvice

Add proper handling for optional parameters
Add setName() to the parameter group interface to force definition
of that method
Add some convenience metnods to parameter service

Issue-ID: POLICY-1035
Change-Id: Iaa9226f45215b00aff9b78ab5fc120c24a0af46d
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoMake checkstyle warnings fail 91/61891/2
Pamela Dragosh [Wed, 22 Aug 2018 18:02:14 +0000 (14:02 -0400)]
Make checkstyle warnings fail

For this repo, we add an suppression filter for some abbreviation names.
It is far too cumbersome to rename these checkstyle issues at this time.
We will do so post-Casablanca release.

We copy the oparent checkstyle pom settings and set to fail on any
warnings.

Change-Id: Icfbd005819a3289acd30796693be85c2ea460212
Issue-ID: POLICY-881
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoAdding common utility classes to policy/common 33/61833/1
ramverma [Wed, 22 Aug 2018 11:13:33 +0000 (12:13 +0100)]
Adding common utility classes to policy/common

* Adding HealthCheckReport class to policy/common for wider use
  among all policy modules.
* Adding utility class called ParameterValidationUtils for providing
  common validation methods to all policy modules. For now, it has only 3
  validation methods but we all can add more in future.

Change-Id: I363fe116ba74f25299fd71211be73505b3164f72
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agoUse builder for http and jersey client 77/60877/5
Krishnajinka [Thu, 16 Aug 2018 09:14:51 +0000 (18:14 +0900)]
Use builder for http and jersey client

Sonar issue with more than 7 params in a method. Use builder object
instead of params. Rework2 for fixing review comments.
Add modifications copyright

Issue-ID: POLICY-1017
Change-Id: Ib0fa692f8da770dcba06158d6e6cafbed2969c27
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
6 years agoFix checkstyle comments etc. 25/60625/3
Pamela Dragosh [Tue, 14 Aug 2018 20:43:53 +0000 (16:43 -0400)]
Fix checkstyle comments etc.

Adding javadoc comments, renaming variables names,
fixed whitespace and 120 length. Also some variables
were made final since they were declared further from
usage. Splitting out Asserts.

Still remaining are the abbreviations.

Issue-ID: POLICY-881
Change-Id: I31ce5a9eea02578bce023c0c607a19108bb726fa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "Fixes for checkstyle issues"
Jorge Hernandez [Tue, 14 Aug 2018 19:36:43 +0000 (19:36 +0000)]
Merge "Fixes for checkstyle issues"

6 years agoFixes for checkstyle issues 51/60551/1
Pamela Dragosh [Tue, 14 Aug 2018 13:45:44 +0000 (09:45 -0400)]
Fixes for checkstyle issues

More fixes for spacing, adding comments, adding period at the
end, and move code closer to usage.

Issue-ID: POLICY-881
Change-Id: Ife99eaf627a221e87d65d24dfd145b0ee4e06d21
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoModify topic factory to use builder param 87/60287/2
Krishnajinka [Tue, 14 Aug 2018 00:26:00 +0000 (09:26 +0900)]
Modify topic factory to use builder param

Fix sonar issue with method build using more than 7 params
Use BusTopicParams to send parameters into methods

Issue-ID: POLICY-1017
Change-Id: I194284da63cb95f91ce2e8a8c21a526a5ab9f6f3
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
6 years agoFix checkstyle in utils 75/60375/1
Pamela Dragosh [Mon, 13 Aug 2018 18:39:43 +0000 (14:39 -0400)]
Fix checkstyle in utils

Cleared all the checkstyle in these 2 submodules.

Issue-ID: POLICY-881
Change-Id: I248e1894aebf549d5a4f8669a6466ec227d40b55
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoRemove simple checkstyle 61/60061/2
Pamela Dragosh [Fri, 10 Aug 2018 18:45:45 +0000 (14:45 -0400)]
Remove simple checkstyle

Mostly concentrated on the period at the end of summary.
But I did clear a few others for longer than 120 characters
and placement of methods next to each other. Possibly a few
others.

I did not clear everything, but will submit a few more
reviews to get the others.

Issue-ID: POLICY-881
Change-Id: I692a5349d686d52fee4040757cdc2ed8b5cc221b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoMerge "get time from correct timer object"
Pamela Dragosh [Fri, 10 Aug 2018 14:13:35 +0000 (14:13 +0000)]
Merge "get time from correct timer object"

6 years agoget time from correct timer object 11/60011/1
Jim Hahn [Fri, 10 Aug 2018 12:56:49 +0000 (08:56 -0400)]
get time from correct timer object

Change-Id: Ie060e45d2cda368ffbb5908b41594d7795bae40b
Issue-ID: POLICY-1045
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Fix bug in common-paramter validation service"
Pamela Dragosh [Thu, 9 Aug 2018 16:16:22 +0000 (16:16 +0000)]
Merge "Fix bug in common-paramter validation service"

6 years agoMerge "generic jetty filter and cadi support"
Pamela Dragosh [Thu, 9 Aug 2018 12:49:57 +0000 (12:49 +0000)]
Merge "generic jetty filter and cadi support"

6 years agoFix bug in common-paramter validation service 43/59843/1
ramverma [Thu, 9 Aug 2018 11:26:28 +0000 (12:26 +0100)]
Fix bug in common-paramter validation service

In GroupValidationResult & GroupMapValidationResult, the setResult
method was not setting the actual status that it has recieved from the
nested group rather it was setting its own status again. Due to which
the validation status of overall ParameterGroup was coming as CLEAN even
if a nested child has reported it as INVALID.
Changed the expected validation result texts for TestValidation accordingly.

Change-Id: I5943decce39574089ca74f9bbccbfbe66d8d542c
Issue-ID: POLICY-1035
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
6 years agogeneric jetty filter and cadi support 89/59689/2
Jorge Hernandez [Wed, 8 Aug 2018 15:28:36 +0000 (10:28 -0500)]
generic jetty filter and cadi support

Change-Id: I363e44e85e1d89c6254218629010d5c3e1507e0a
Issue-ID: POLICY-1043
Signed-off-by: Jorge Hernandez <jh1730@att.com>
6 years agoApply builder pattern for topic cnsmer prdcr 31/59031/4
krishnajinka [Sun, 5 Aug 2018 07:52:10 +0000 (16:52 +0900)]
Apply builder pattern for topic cnsmer prdcr

Modify endpoints event bus related classes to use builder pattern
in particular apply bus topic params object instead of
using parameters as it is. Rework based on commnts

Issue-ID: POLICY-1017
Change-Id: I572a72fa525cf4f664eb70d0415be73116499bd2
Signed-off-by: krisjinka <kris.jinka@samsung.com>
6 years agoMerge "generic jetty https server support"
Pamela Dragosh [Fri, 3 Aug 2018 22:24:28 +0000 (22:24 +0000)]
Merge "generic jetty https server support"

6 years agoMerge "Use builder in Bus DMaap UEB Topic constrctr"
Liam Fallon [Fri, 3 Aug 2018 19:40:06 +0000 (19:40 +0000)]
Merge "Use builder in Bus DMaap UEB Topic constrctr"

6 years agogeneric jetty https server support 09/58509/10
Jorge Hernandez [Wed, 1 Aug 2018 21:18:25 +0000 (16:18 -0500)]
generic jetty https server support

jetty https support in constructor, or by using
".https" when creating an http server service.

Change-Id: I94e8e3e4b93eb6b194657028c740b6781316c7da
Issue-ID: POLICY-940
Signed-off-by: Jorge Hernandez <jh1730@att.com>
6 years agoUpgrade jetty to clear security issue 51/58951/1
Pamela Dragosh [Fri, 3 Aug 2018 14:27:04 +0000 (10:27 -0400)]
Upgrade jetty to clear security issue

This got missed in this repository

Issue-ID: POLICY-1030
Change-Id: Ib62fd66cc8cb74b7579f9eddbba675e4c1d16c2a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoFix pom and checkstyle warnings in common 37/58937/1
liamfallon [Fri, 3 Aug 2018 12:33:44 +0000 (13:33 +0100)]
Fix pom and checkstyle warnings in common

Some dependency versions are now managed in the master POM
Checkstyle showed up some warnings in paramters and capabilities.

Change-Id: Ifebd8a076bdb3fda626b5b1fda9324801bf58643
Issue-ID: POLICY-716
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoUse builder in Bus DMaap UEB Topic constrctr 25/58925/1
Krishnajinka [Fri, 3 Aug 2018 11:12:05 +0000 (20:12 +0900)]
Use builder in Bus DMaap UEB Topic constrctr

Constructors of the Bus Dmaap Ueb topic source class using many param
Refactor to use builder pattern for clean code implementation.

Issue-ID: POLICY-1017
Change-Id: Iea75b64ad232e83541a60a03a19cbb598c370cff
Signed-off-by: Krishnajinka <kris.jinka@samsung.com>
6 years agoMerge "Add resource handling utility class"
Jorge Hernandez [Wed, 1 Aug 2018 13:16:04 +0000 (13:16 +0000)]
Merge "Add resource handling utility class"

6 years agoAdd resource handling utility class 45/58045/2
liamfallon [Mon, 30 Jul 2018 16:13:22 +0000 (17:13 +0100)]
Add resource handling utility class

Add ResourceUtils, a class that provides utility methods
for dealing with Java resources on the classpath.

Change-Id: Ie4df249315ad145aabdfb35bb827ffbf6d79e095
Issue-ID: POLICY-922
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoMerge "Improve validation, add hierarchical validation"
Jorge Hernandez [Tue, 31 Jul 2018 16:57:16 +0000 (16:57 +0000)]
Merge "Improve validation, add hierarchical validation"

6 years agoImprove validation, add hierarchical validation 93/57993/9
liamfallon [Mon, 30 Jul 2018 09:22:27 +0000 (10:22 +0100)]
Improve validation, add hierarchical validation

Parameter validaiton updated to generically support nested groups of
parameters, and nested maps of parameters.

Unit test showing JSON parameter input added.
Unit test showing YAML parameter inout added.

Test parameter group classes moved into subdirectory

This allows parameters to be unmarshaled seamlessly from JSON and YAML
files.

Change-Id: I768e11f31ee7f62299c4d5d95ab68a005d1aff16
Issue-ID: POLICY-922
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoCopy policy-endpoints from drools-pdp to common 47/58047/2
mmis [Mon, 30 Jul 2018 16:04:50 +0000 (17:04 +0100)]
Copy policy-endpoints from drools-pdp to common

Removed changes made in commit b40acf2d244058c162a8597968e59f2708e6abf4
that went beyond the scope of POLICY-967

Issue-ID: POLICY-967
Change-Id: Ibbf78540dec8bf8601a62dacc8c7056d43f70ba1
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agosupport ueb/dmaap https related configuration 35/57935/1
Jorge Hernandez [Sun, 29 Jul 2018 03:00:06 +0000 (22:00 -0500)]
support ueb/dmaap https related configuration

Change-Id: Ide2e3524cbbf0a8caf36ad48c003b7500482ad4a
Issue-ID: POLICY-941
Signed-off-by: Jorge Hernandez <jh1730@att.com>
6 years agoMerge "Add common parameter handling"
Jorge Hernandez [Thu, 26 Jul 2018 18:06:35 +0000 (18:06 +0000)]
Merge "Add common parameter handling"

6 years agoFix eclipse warnings in common logging 11/57711/1
liamfallon [Thu, 26 Jul 2018 14:02:21 +0000 (15:02 +0100)]
Fix eclipse warnings in common logging

Minor annoying eclipse warnings due to raw Class and
deprecated log enums removed.

Change-Id: I7248b0c6fa4a4dc62104c75b07fadc5a144e8a47
Issue-ID: POLICY-716
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoAdd common parameter handling 05/57305/5
liamfallon [Tue, 24 Jul 2018 11:38:24 +0000 (12:38 +0100)]
Add common parameter handling

This common module is proposed to handle all parameters and properties
for the ONAP Policy Framework in a common way.

Parameters and Properties:
- are validated once when they are loaded and need not be checked again
  in classes that use them
- are available for lookup in a parameter service, they need not be passed
  in constructors and method arguments
- are input using a single implementiation of input method only
  (JSON/YAML/Java properties/REST)
- are defined in a schema and the schema is used for validation as much
  as possible

Issue-ID: POLICY-922
Change-Id: I1fac88b9e952b6b5fcbea04319cb4294a9653327
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoCopy policy-endpoints from drools-pdp to common 55/57055/9
mmis [Fri, 20 Jul 2018 14:28:25 +0000 (15:28 +0100)]
Copy policy-endpoints from drools-pdp to common

Issue-ID: POLICY-967
Change-Id: I374c155ee102c3e157c60d0a22d7191544abb76a
Signed-off-by: mmis <michael.morris@ericsson.com>
6 years agoRemove site-manager from common-modules 67/57067/2
Kevin McKiou [Fri, 20 Jul 2018 17:14:35 +0000 (12:14 -0500)]
Remove site-manager from common-modules

Patch 1: The site-manager is specific to the AT&T environment and is
not functional in ONAP.  This change removes the site-manager module
from the policy common-modules.

Patch 2: Removed the site-manager from the pom.xml file.

Issue-ID: POLICY-1001
Change-Id: Ibd8dd95915739205b0c5463c8b28706b615d9faf
Signed-off-by: Kevin McKiou <km097d@att.com>
6 years agofixed Checkstyle warnings 07/56107/1
vamshi.nemalikonda [Tue, 10 Jul 2018 14:14:02 +0000 (19:44 +0530)]
fixed Checkstyle warnings

Issue-ID: POLICY-881
Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
Change-Id: I4057306bec83a48921c90a081fb9752f663ee3b6

6 years agofixed Checkstyle warnings 23/54823/3
vamshi.nemalikonda [Thu, 14 Jun 2018 15:05:03 +0000 (20:35 +0530)]
fixed Checkstyle warnings

Issue-ID: POLICY-881
Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
Change-Id: Idc0c088497b4a49789c3f0aedf034d380bd3af1c

6 years agoMerge "IntegrityMonitor: remove sleep from junit tests"
Pamela Dragosh [Mon, 25 Jun 2018 14:00:03 +0000 (14:00 +0000)]
Merge "IntegrityMonitor: remove sleep from junit tests"

6 years agoIntegrityAuditor: remove sleep from junit tests 35/55235/3
Jim Hahn [Thu, 21 Jun 2018 20:23:19 +0000 (16:23 -0400)]
IntegrityAuditor: remove sleep from junit tests

Modified the code to use a CurrentTime object for its "time" operations
(e.g., sleep(), currentTimeInMillis()). Modified junit tests to replace
the CurrentTime object with TestTime objects so they don't actually
do any sleeping.
Reformat "commit" message.
Remove TODO from junit test.
Init testTime in junit setUp().
Add AuditorTime and test classes.
Change "latch" to "semaphore" in comments.
Change time units in junit test from SECONDS to MILLISECONDS.
Add sleep() method to auditor test class.
Reorder field qualifiers.
Change utils scope to "compile" in pom.

Change-Id: I8aa8b642b315156c00422192e4aa8e47b4503c2f
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoIntegrityMonitor: remove sleep from junit tests 27/55227/2
Jim Hahn [Thu, 21 Jun 2018 19:43:32 +0000 (15:43 -0400)]
IntegrityMonitor: remove sleep from junit tests

Modified the code to use a CurrentTime object for its "time"
operations (e.g., sleep(), currentTimeInMillis()).  Modified
junit tests to replace the CurrentTime object with TestTime
objects so they don't actually do any sleeping.
Update license date.
Remove unneeded dependency from pom.
Don't start FpManager thread within its own constructor.
toMillis() should handle -1 as an input.
Fix comment in test base superclass.
Change time units in test base from DAYS to MILLISECONDS.

Change-Id: Id6a4edb1747ca1a683e5d37522872b781294532d
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "PropertyUtil: remove sleep when running junit test"
Pamela Dragosh [Thu, 21 Jun 2018 19:54:37 +0000 (19:54 +0000)]
Merge "PropertyUtil: remove sleep when running junit test"

6 years agoMerge "Delete SpecPropertyConfiguration class"
Pamela Dragosh [Thu, 21 Jun 2018 19:35:42 +0000 (19:35 +0000)]
Merge "Delete SpecPropertyConfiguration class"

6 years agoMerge "IntegrityMonitory - remove latch for non-test code"
Pamela Dragosh [Thu, 21 Jun 2018 19:35:25 +0000 (19:35 +0000)]
Merge "IntegrityMonitory - remove latch for non-test code"

6 years agoMerge "IntegrityAudit - remove latches from non-test code"
Pamela Dragosh [Thu, 21 Jun 2018 19:34:21 +0000 (19:34 +0000)]
Merge "IntegrityAudit - remove latches from non-test code"

6 years agoPropertyUtil: remove sleep when running junit test 55/55155/3
Jim Hahn [Fri, 15 Jun 2018 00:09:37 +0000 (20:09 -0400)]
PropertyUtil: remove sleep when running junit test

Update licenses.
Remove uneeded dependencies.
Make "timer" field private.
Make LazyHolder protected.
Add comment to TestListener.
Combine copyright lines.

Change-Id: I77c198c9bc6c224fa93ef74d0c56aa73b187e169
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoIntegrityAudit - remove latches from non-test code 51/55151/1
Jim Hahn [Wed, 13 Jun 2018 16:23:26 +0000 (12:23 -0400)]
IntegrityAudit - remove latches from non-test code

Change-Id: I5d5cc7d581f78d5551e2fe7447720403bb63ada2
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoIntegrityMonitory - remove latch for non-test code 47/55147/1
Jim Hahn [Thu, 14 Jun 2018 13:05:50 +0000 (09:05 -0400)]
IntegrityMonitory - remove latch for non-test code

Change-Id: I95ebcf8aabfa01eb6453a4ba5dd88d11c8f025c9
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Add CurrentTime utilities"
Pamela Dragosh [Wed, 20 Jun 2018 17:25:18 +0000 (17:25 +0000)]
Merge "Add CurrentTime utilities"

6 years agoDelete SpecPropertyConfiguration class 33/55133/1
Jim Hahn [Wed, 20 Jun 2018 13:10:06 +0000 (09:10 -0400)]
Delete SpecPropertyConfiguration class

Change-Id: Ie97d2c396ec6df1e03287a7ecb866bc8acf6cfbc
Issue-ID: POLICY-907
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoAdd CurrentTime utilities 75/55075/2
Jim Hahn [Fri, 15 Jun 2018 13:10:00 +0000 (09:10 -0400)]
Add CurrentTime utilities

Add some comments.  Update license text.

Change-Id: I4cee208378c44d9730274aee337feb95f9026add
Issue-ID: POLICY-908
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Move SpecProperties from drools-pdp to common"
Pamela Dragosh [Tue, 19 Jun 2018 15:13:58 +0000 (15:13 +0000)]
Merge "Move SpecProperties from drools-pdp to common"

6 years agoMove SpecProperties from drools-pdp to common 37/55037/1
Jim Hahn [Mon, 18 Jun 2018 21:29:01 +0000 (17:29 -0400)]
Move SpecProperties from drools-pdp to common

Change-Id: Ifa1785922b42f990d4d84c1410dd1d881b10647d
Issue-ID: POLICY-907
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoUse setXxx() methods for @Property fields 25/55025/2
Jim Hahn [Mon, 18 Jun 2018 19:53:30 +0000 (15:53 -0400)]
Use setXxx() methods for @Property fields

Fortify generates a security exception when PropertyConfiguration
attempts to directly update private fields.  PropertyConfiguration
has been modified to invoke setXxx() methods, instead, to set the
values for the fields.
Add junit tests for new methods.

Change-Id: Ic4420b6348724c5a384d3c2c8bf7b4c0c6350fa9
Issue-ID: POLICY-906
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoMerge "Fix entry in logging message catalog"
Pamela Dragosh [Sun, 10 Jun 2018 00:04:32 +0000 (00:04 +0000)]
Merge "Fix entry in logging message catalog"

6 years agoRemove "&quot;" from logback xml files 65/51065/2
Jim Hahn [Fri, 8 Jun 2018 15:50:22 +0000 (11:50 -0400)]
Remove "&quot;" from logback xml files

Logback complains if %d{} values contain "&quot;", but it works fine
without them, thus they have been removed.
Update license header.

Change-Id: Ie72cc5ec922c161e1fd5058021a57282c4f0134b
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoFix entry in logging message catalog 55/51055/1
Jim Hahn [Fri, 8 Jun 2018 14:55:10 +0000 (10:55 -0400)]
Fix entry in logging message catalog

Replaced hyphen with underscore in a resource id in the message
catalog.

Change-Id: I3734d87361a3a58f92db48a8c22b40e5eadead42
Issue-ID: POLICY-785
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoRemoving checkstyle warnings from ErrorsTester 19/50919/1
vamshi.nemalikonda [Thu, 7 Jun 2018 12:23:14 +0000 (17:53 +0530)]
Removing checkstyle warnings from ErrorsTester

Change-Id: Ifc70d9682317033fd98b43ba802f9fd1acf519a8
Issue-ID: POLICY-881
Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
6 years agoFixed most of the Checkstyle warnings. 11/50911/1
vamshi.nemalikonda [Thu, 7 Jun 2018 11:17:07 +0000 (16:47 +0530)]
Fixed most of the Checkstyle warnings.

Change-Id: I80b05663e81648058f84aff5d5cda2deaa2d87c9
Issue-ID: POLICY-881
Signed-off-by: vamshi.nemalikonda <vn00480215@techmahindra.com>
6 years agoUpdate policy-common to SNAPSHOT-1.3.0 75/50375/1
liamfallon [Tue, 5 Jun 2018 14:41:08 +0000 (15:41 +0100)]
Update policy-common to SNAPSHOT-1.3.0

Snapshot updated for Casablanca.

Change-Id: Ife941f771b02be68e35fd638adfac78cf2b3ba99
Issue-ID: POLICY-875
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoUse ${POLICY_LOGS} for log directory 89/48389/2 2.0.0-ONAP beijing 2.0.0-ONAP v1.2.3
Jim Hahn [Mon, 21 May 2018 21:49:13 +0000 (17:49 -0400)]
Use ${POLICY_LOGS} for log directory

Update license date.

Change-Id: I912e1d8ab56b124178b4bfdd8646ee62b48b386c
Issue-ID: POLICY-759
Signed-off-by: Jim Hahn <jrh3@att.com>
6 years agoUpdate Policy Common to 1.2.3-SNAPSHOT 89/48289/1
liamfallon [Mon, 21 May 2018 11:56:13 +0000 (12:56 +0100)]
Update Policy Common to 1.2.3-SNAPSHOT

These reviews must be merged in order because of layering.

This review should be merged FIRST.

Issue-ID: POLICY-844
Change-Id: I7cf07902c3b2d7766dc64f1c1dd80d91dee18467
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
6 years agoUpgrade 1.2.2 version.properties 73/47873/1 v1.2.2
Pamela Dragosh [Wed, 16 May 2018 18:01:42 +0000 (14:01 -0400)]
Upgrade 1.2.2 version.properties

This file needs to be upgraded also.

Issue-ID: POLICY-798
Change-Id: I9a899b9889e0cb0cf82d65dba6f86af5613e201e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoUpgrade SNAPSHOT to 1.2.2 07/47807/2
liamfallon [Wed, 16 May 2018 11:41:31 +0000 (12:41 +0100)]
Upgrade SNAPSHOT to 1.2.2

These reviews must be merged in order because of layering.

This review should be merged FIRST

Change-Id: If143b2d23487c073fafad8f6208cd8d320ec98e9
Issue-ID: POLICY-798
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
7 years agoAdd INFO.yaml file 53/45353/4 v1.2.1
Jessica Wagantall [Tue, 1 May 2018 03:07:43 +0000 (20:07 -0700)]
Add INFO.yaml file

Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information

Change-Id: Ia4f34d6a00c7d5f0b5a830ca58de20445ff2b224
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
7 years agoAdd missing licenses 93/42793/1
Pamela Dragosh [Fri, 13 Apr 2018 18:49:59 +0000 (14:49 -0400)]
Add missing licenses

Issue-ID: POLICY-741
Change-Id: Iac1b4a61dbdc6de46fa82357076d6b3b44b128f1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
7 years agoUpgrade SNAPSHOT to 1.2.1 81/42781/2
Pamela Dragosh [Fri, 13 Apr 2018 16:14:42 +0000 (12:14 -0400)]
Upgrade SNAPSHOT to 1.2.1

Issue-ID: POLICY-736
Change-Id: Iccb43b692908ffc35fc0d18da1e967718e3c3519
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
7 years agoRemove ECOMP trademark 69/39769/1 v1.2.0
Pamela Dragosh [Wed, 28 Mar 2018 18:19:59 +0000 (11:19 -0700)]
Remove ECOMP trademark

Issue-ID: POLICY-696
Change-Id: I036dbbe004e4e37b5ffa95e416dab3ec507046d2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
7 years agoRemoved checkstyle warnings 01/39701/2
eikrwaq [Wed, 28 Mar 2018 14:50:57 +0000 (15:50 +0100)]
Removed checkstyle warnings

Change-Id: I350bbd414477fe0b480c1bc4e7fa60b1e63842a7
Issue-ID: POLICY-712
Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
7 years agoAdd PropertyConfiguration class 79/38179/15
Jim Hahn [Fri, 23 Mar 2018 18:47:42 +0000 (14:47 -0400)]
Add PropertyConfiguration class

Added PropertyConfiguration class, which provides for the loading of
properties into the fields of a subclass.  Annotations are used to
identify the field to be loaded and the name of the property from
which it is to be loaded.
Changed attribute "useDefault" to "emptyOk" so that it only has to
be specified when the default value is empty.
Reformatted a couple of files.
Added setAllFields() method.
Added getRawPropertyValue() method so subclasses can change how
values are extracted from the property set.
Added SpecPropertyConfiguration so controller or session names
may be embedded within property names.
Fixed some typos.
Refactored out generalizeType2().
Changed exception classes to take field name instead of Field object.
Modified getValue() to take the field name and class type instead of
Field object.
Removed or fixed comments in junit tests.
Added more junit tests.
Changed emptyOk attribute to accept, to facilitate adding other
options in the future.
Corrected comments on the isEmptyOk() methods.

Change-Id: I6b190fea687f87cf512fb3236bfcf40b7adc4566
Issue-ID: POLICY-577
Signed-off-by: Jim Hahn <jrh3@att.com>
7 years agoAdd junit and refactor code 01/37501/9
eikrwaq [Wed, 21 Mar 2018 15:31:05 +0000 (15:31 +0000)]
Add junit and refactor code

Adding Junit tests in modules and refactoring code

Change-Id: I887f1b2371d9e3d4a4e2ce6e7e1f3c97a361f283
Issue-ID: POLICY-704
Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
7 years agoMerge "Removed checkstyle warnings"
Pamela Dragosh [Wed, 21 Mar 2018 13:21:23 +0000 (13:21 +0000)]
Merge "Removed checkstyle warnings"

7 years agoMerge "Removed checkstyle warnings"
Pamela Dragosh [Wed, 21 Mar 2018 12:10:13 +0000 (12:10 +0000)]
Merge "Removed checkstyle warnings"

7 years agoRemoved checkstyle warnings 73/37073/3
mmis [Tue, 20 Mar 2018 11:46:13 +0000 (11:46 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/ia

Issue-ID: POLICY-695
Change-Id: I25f589dff5ce1dba0681ba549a53087426593d71
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoRemoved checkstyle warnings 63/37163/1
mmis [Tue, 20 Mar 2018 15:28:46 +0000 (15:28 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/sitemanager

Issue-ID: POLICY-695
Change-Id: I9ac6f95e7e259016e0ad9ad7caced59e4d6b84a0
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoRemoved checkstyle warnings 53/37153/1
mmis [Tue, 20 Mar 2018 15:02:53 +0000 (15:02 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/im

Issue-ID: POLICY-695
Change-Id: I32b4797249386c0d1bd0f50792880a1759503a67
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoMerge "Removed checkstyle warnings"
Pamela Dragosh [Tue, 20 Mar 2018 14:49:45 +0000 (14:49 +0000)]
Merge "Removed checkstyle warnings"

7 years agoRemoved checkstyle warnings 29/36229/3
mmis [Fri, 16 Mar 2018 14:42:22 +0000 (14:42 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/logging

Some warnings remain that required renaming of classes and public methods.
These will be taken separately

Issue-ID: POLICY-695
Change-Id: Id604c66708917de390c556b50f6266f929b09134
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoFixing reported bug in Sonar for policy/common 33/36233/5
eikrwaq [Fri, 16 Mar 2018 15:05:41 +0000 (15:05 +0000)]
Fixing reported bug in Sonar for policy/common

Change-Id: I449259749f93a5b9058c76e99d96465466458a56
Issue-ID: POLICY-661
Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
7 years agoMerge "Fixing 12 reported bugs in Sonar for policy/common"
Pamela Dragosh [Fri, 16 Mar 2018 13:58:57 +0000 (13:58 +0000)]
Merge "Fixing 12 reported bugs in Sonar for policy/common"

7 years agoFixing 12 reported bugs in Sonar for policy/common 99/35999/6
eikrwaq [Thu, 15 Mar 2018 12:59:14 +0000 (12:59 +0000)]
Fixing 12 reported bugs in Sonar for policy/common

Change-Id: I7bf453828f7a62070e7a73362798e6f2d4806b2f
Issue-ID: POLICY-661
Signed-off-by: eikrwaq <waqas.ikram@ericsson.com>
7 years agoRemoved checkstyle warnings 97/36197/1
mmis [Fri, 16 Mar 2018 09:44:46 +0000 (09:44 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/utils

Issue-ID: POLICY-695
Change-Id: I831b74c889d44784d6328619d88eb92fb524ce74
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoMerge "Removed checkstyle warnings"
Pamela Dragosh [Thu, 15 Mar 2018 20:07:31 +0000 (20:07 +0000)]
Merge "Removed checkstyle warnings"

7 years agoRemoved checkstyle warnings 39/36039/1
mmis [Thu, 15 Mar 2018 10:59:51 +0000 (10:59 +0000)]
Removed checkstyle warnings

Removed checkstyle warnings in policy/common/utils-test

Issue-ID: POLICY-695
Change-Id: I9962b2f815d2c116f77475944bc17ea1cb0af539
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoUpdate oparent version to 1.1.0 31/35831/1
liamfallon [Wed, 14 Mar 2018 21:39:21 +0000 (21:39 +0000)]
Update oparent version to 1.1.0

Directive from ONAP project that all repos should be
updated. Change vierified with a build with .m2 /org/onap
cleared.

Change-Id: Iff212a0f7b2917b20237ec7ef5f4b2cbd13d7dcb
Issue-ID: POLICY-693
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
7 years agoClean up pom.xml due to redesign 63/34963/1
Pamela Dragosh [Fri, 9 Mar 2018 14:26:17 +0000 (09:26 -0500)]
Clean up pom.xml due to redesign

No need for this anymore as the staging builds won't work
anyway and this is in the settings.

Issue-ID: POLICY-623
Change-Id: I98a61be05d25083f595fb308bfefd942a02c8208
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
7 years agoAdded junit tests in ONAP-Logging 79/33179/2
mmis [Tue, 27 Feb 2018 14:05:23 +0000 (14:05 +0000)]
Added junit tests in ONAP-Logging

Added junit tests to org.onap.policy.common.logging.flexlogger package in ONAP-Logging

Issue-ID: POLICY-582
Change-Id: I024f990960fa71bff7655da9c2cd5dd0db8ee33c
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoAdded junit tests in ONAP-Logging 79/32679/2
mmis [Fri, 23 Feb 2018 11:32:19 +0000 (11:32 +0000)]
Added junit tests in ONAP-Logging

Added junit tests to org.onap.policy.common.logging.eelf package in ONAP-Logging

Issue-ID: POLICY-582
Change-Id: Ifca9c38d8b8703b183c25d891d6ed257eb21c91b
Signed-off-by: mmis <michael.morris@ericsson.com>
7 years agoUpgrade EELF to fix license 91/32391/1
Pamela Dragosh [Wed, 21 Feb 2018 14:08:31 +0000 (09:08 -0500)]
Upgrade EELF to fix license

We asked EELF to upgrade qos.logback to 1.2.3, they upgraded to 1.2.1.

This will also fix a compilation error we have due to a combination
of commits and ordering of inclusion of qos.logback.

Issue-ID: POLICY-505
Change-Id: Ia086ceae5e1468d34a8db053818fef3f50585f25
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
7 years agoMerge "Increase junit coverage in ONAP-logging"
Jorge Hernandez [Tue, 20 Feb 2018 22:34:11 +0000 (22:34 +0000)]
Merge "Increase junit coverage in ONAP-logging"

7 years agoIncrease junit coverage in ONAP-logging 97/32297/3
Jim Hahn [Tue, 20 Feb 2018 18:41:59 +0000 (13:41 -0500)]
Increase junit coverage in ONAP-logging

Added some junit tests to increase coverage of ONAP-logger.
Many classes still need test cases.

Also fixed some sonar issues:
Returned interface instead of ConcurrentHashMap.
Used EnumMap instead of HashMap.
Used StringBuilder instead of StringBuffer.
Replaced literals with constants.
Replaced enum1.toString().equals(enum2.toString()) with enum1 == enum2

Updated license dates.
Updated another license date.

Change-Id: I777b6a913d7d03187a29dfeb817800b386ee23aa
Issue-ID: POLICY-582
Signed-off-by: Jim Hahn <jrh3@att.com>
7 years agoMerge "Consolidating and organizing dependencies"
Jorge Hernandez [Tue, 20 Feb 2018 17:54:03 +0000 (17:54 +0000)]
Merge "Consolidating and organizing dependencies"