Rodrigo Lima [Mon, 4 May 2020 00:24:35 +0000 (20:24 -0400)]
Add Autowired annotation to the constructor instead of param in ExternalTestingImpl
Issue-ID: SDC-3003
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I720c6cf271a1444a584f42cdca2a7e4f2c59a85d
Francis Toth [Fri, 24 Apr 2020 14:31:36 +0000 (10:31 -0400)]
Refactor CsarUtils::createCsar
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I41994c98515844030eed1d6f2756c9779e864cff
Issue-ID: SDC-2812
Francis Toth [Wed, 22 Apr 2020 23:00:33 +0000 (19:00 -0400)]
Extract ArtifactOperationInfo from ArtifactsBusinessLogic
This commit only intends to extract the inner static class ArtifactOperationInfo from the ArtifactsBusinessLogic class. In addition, getters have been added to get the artifactOperationEnum field's state (this allowed to reduce some boilerplate).
Change-Id: Ib79a75893ef11ba0d25e0578d7e95f60284589d0
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2961
Francis Toth [Thu, 30 Apr 2020 19:36:38 +0000 (15:36 -0400)]
Remove powermockito from NetworksImplTest
This commit aims to remove the Powermockito dependency from NetworksImplTest.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I7eecb877f86a64514609e11fd9501f3fb972a866
Issue-ID: SDC-2984
Rodrigo Lima [Fri, 1 May 2020 15:44:48 +0000 (11:44 -0400)]
Remove powermockito from ApiTest
- Remove powermockit from ApiTest. Add new constructor to ExternalTestingImpl in order to pass
vendorSoftwareProductManager param.
Issue-ID: SDC-3003
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Ibdaa12a986557dbf1d4cdf6d4c1952ba642582cf
vasraz [Fri, 1 May 2020 11:33:22 +0000 (12:33 +0100)]
Increase test coverage - openecomp-sdc-model-lib
Change-Id: I86e4935fd418bb01971f21ae32351be6044a2566
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3001
vasraz [Fri, 1 May 2020 15:40:10 +0000 (16:40 +0100)]
Increase test coverage - openecomp-sdc-vendor-software-product-api
Change-Id: Ifaaf73998ee0f7df66082fdc4963b4c05678e5c1
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3001
Francis Toth [Fri, 1 May 2020 17:26:03 +0000 (13:26 -0400)]
Refactor CsarUtils::validateNonMetaArtifact
This commit aims to refactor the CsarUtils::validateNonMetaArtifact function and make it up to standards regarding how fj.Either should be used.
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Icadfce7229839e53bd09926b6865f2872c39d1a5
Issue-ID: SDC-2812
andre.schmid [Thu, 30 Apr 2020 15:56:36 +0000 (16:56 +0100)]
Fix sdc-FE /onboarding war listing
It creates a index.html page that will end up in the
onboarding-FE .war file. When the /onboarding context
is accessed, a blank page will show up instead of the
contents of the .war.
Change-Id: I0fb4be28e193e6e6bbd58c1af9a49d5750981b7e
Issue-ID: SDC-3000
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Ben David, Elad (eb7504) [Thu, 30 Apr 2020 11:00:28 +0000 (14:00 +0300)]
HEAT to TOSCA VM Consolidation
Change-Id: I00c9cf90d7486af33955acae7dfe653e14ceebdc
Issue-ID: SDC-2997
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
Chris André [Tue, 28 Apr 2020 21:49:54 +0000 (17:49 -0400)]
Replace call to `get` with a call to `ifPresent`
Issue-ID: SDC-2989
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I7fe273d869035f8852dbc398de60cc49dec2ce6e
Rodrigo Lima [Wed, 29 Apr 2020 19:39:56 +0000 (15:39 -0400)]
Remove mockito from TypeUtilsTest
- Remove the use of mockito verify from TypeUtilsTest
Issue-ID: SDC-2993
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I42c9c972cead10afaa3ec299624cf3d26e4d04db
andre.schmid [Thu, 23 Apr 2020 11:44:59 +0000 (12:44 +0100)]
Fix GAB ui test row and column count
Change-Id: Ib9e4eb054cd23db9359b6d4db4ce079007c1e4e7
Issue-ID: SDC-2963
Signed-off-by: andre.schmid <andre.schmid@est.tech>
vasraz [Wed, 29 Apr 2020 13:13:18 +0000 (14:13 +0100)]
Fix VFs and Service not visible in SDC Dashboard
Change-Id: Ia42775388c3ad9539b7d0020476f0f7a91ce8bb9
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2938
Chris André [Tue, 21 Apr 2020 18:40:07 +0000 (14:40 -0400)]
Handle null case in `GroupVersionUpdater`
- change in the final condition of `isGenerateGroupUUID`
- Added tests related to modified code
Issue-ID: SDC-2913
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I22738f9f4922467209a16a4d6b3b78d7bfac11c9
Francis Toth [Fri, 24 Apr 2020 14:29:03 +0000 (10:29 -0400)]
Refactor CsarUtils::getEntryData
Change-Id: I1732ae05cfbe93c1bef8c249e16088a0cad34106
Issue-ID: SDC-2812
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Francis Toth [Fri, 24 Apr 2020 15:11:01 +0000 (11:11 -0400)]
Refactor CsarUtils::populateZip
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I136ebda0ff92d6c42368f102ccf2b10f37524808
Issue-ID: SDC-2812
Francis Toth [Mon, 20 Apr 2020 00:16:33 +0000 (20:16 -0400)]
Remove csvReportFilePath from ValidationConfigManager
This commit aims to extract the csvReportFilePath field from ValidationConfigManager in order to improve testability. This commit contains multiple minor modifications resulting from bubbling up the csvReportFilePath static field to where it is actually set. Put differently, most of the modifications result from changing the signature of the functions which formerly relied on ValidationConfigManager.getCSVReportFilePath.
Change-Id: I82c3b0fca8a0f407319e40ecfff45e89ec1d4323
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Issue-ID: SDC-2499
Chris André [Fri, 24 Apr 2020 23:51:01 +0000 (19:51 -0400)]
Work around potential NullPointerExceptions in HeatTreeManagerUtil
- Replace null return values with empty Map objects
Issue-ID: SDC-2928
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I3357a8789a00201a7ffda1dbf0be5f08cbb9c33b
andre.schmid [Fri, 6 Mar 2020 14:42:45 +0000 (14:42 +0000)]
Enabling JS in SonarCloud
Configures jest test coverage and missing sonar
properties for javascript file scan and report.
Change-Id: I9170a176cc4e580ac14f669c334ee949942503f6
Issue-ID: SDC-2741
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Rodrigo Lima [Thu, 23 Apr 2020 19:41:02 +0000 (15:41 -0400)]
Fix null pointer warning
- Check name and value in method setToscaPresentationValue
Issue-ID: SDC-2926
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I0d66b29c84139afff92065769bf1b79082959333
Chris André [Wed, 22 Apr 2020 15:22:29 +0000 (11:22 -0400)]
Add null test to ComponentBusinessLogic
- Added test in `getFilteredComponentInstanceProperties` for null value
- Removed nested `if` statements in `isMatchingComplexPropertyByRecursively`
Issue-ID: SDC-2907
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I13a47b0dfe7aa6dec845a856c58bba8be5c1eead
andre.schmid [Tue, 21 Apr 2020 17:08:10 +0000 (18:08 +0100)]
Update WORKFLOW Artifact Type configuration
To add an operation with an existing Workflow in a RESOURCE,
the Artifact Type WORKFLOW needs to support the extension
"bpmn" and the component type "RESOURCE".
Change-Id: Ic7eb9afe3ced0348f7aadcc43edf121a0bdcf015
Issue-ID: SDC-2954
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Wed, 22 Apr 2020 10:00:52 +0000 (11:00 +0100)]
Fix potential NPE in ArtifactsBusinessLogic
Fixes potential NPE in ArtifactsBusinessLogic introduced by SDC-2754.
Change-Id: If53915ffc41ddd0dbcf00ea318cdae6f1b5471ad
Issue-ID: SDC-2959
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Chris André [Thu, 16 Apr 2020 21:48:06 +0000 (17:48 -0400)]
Added early check for null value for `containerV`
- Formatting code following project's code style
- Added early check for null value for `containerV`
Issue-ID: SDC-2905
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I648e9a4a04be3f2e7cd3e30a70c04de2257a99d3
Chris André [Wed, 22 Apr 2020 00:51:42 +0000 (20:51 -0400)]
Minor cleanups for BasicAuthenticationFilter
- Changed String representing encoding to Java's StandardCharsets.UTF_8
- Added explicit else condition in order to not rely on `abortWith`'s side effects
Issue-ID: SDC-2917
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I81cb94c399ff1d810e85c7b63fde195928ab1b08
Chris André [Tue, 21 Apr 2020 23:25:21 +0000 (19:25 -0400)]
Add null tests
- Change `isPropertiesListSizesNotEquals` to `isPropertiesListSizesEquals`
- Added assertions to silence SonarCloud
Issue-ID: SDC-2914
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I88003de54aea6c28575fecf0f41b4c5ef36ef154
Rodrigo Lima [Mon, 20 Apr 2020 15:56:35 +0000 (11:56 -0400)]
Fix null pointer exception warnings
Issue-ID: SDC-2911
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: Ic7f0ef631ed98e8baf2ea32b6bfc56a7142738f8
Rodrigo Lima [Wed, 22 Apr 2020 15:57:18 +0000 (11:57 -0400)]
Handle null condition in TopologyTemplateOperation
- check if instanceId null in method isNotEmptyMapOfProperties
Issue-ID: SDC-2920
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I70667142ed51834de638903ccae4ffcb896cccab
Baumel, Dvir (db384r) [Tue, 21 Apr 2020 11:14:15 +0000 (14:14 +0300)]
Fix unit tests not running
Change-Id: I06462b6180a1f1a310aae994f4e703a498f80247
Issue-ID: SDC-2933
Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
Chris André [Tue, 14 Apr 2020 20:21:43 +0000 (16:21 -0400)]
Used `configurationManager` instead of `getConfigurationManager`
Issue-ID: SDC-2890
Change-Id: I1559ebc60076bd0884ae1136c9c904f7ab46e72e
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Reo Inoue [Mon, 20 Apr 2020 07:20:49 +0000 (16:20 +0900)]
Fix bug for class SwitchoverDetector
Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com>
Issue-ID: SDC-2931
Change-Id: I6b40f538ff9ce7eed22ce71c542b188a8c866f26
Chris André [Tue, 21 Apr 2020 15:21:32 +0000 (11:21 -0400)]
Add null test to DistributionMonitoringBusinessLogic
- Added test in `handleAuditingDaoResponse` for null value related to `resAuditingGenericEvent`
Issue-ID: SDC-2909
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I422629cdbd4f05e10609cd78b7328c4e9f45538b
Rodrigo Lima [Tue, 21 Apr 2020 19:17:29 +0000 (15:17 -0400)]
Handle null condition in ResourceImportManager
- check if parentResource null in methods setRequirements and setCapabilities
Issue-ID: SDC-2912
Signed-off-by: Rodrigo Lima <rodrigo.lima@yoppworks.com>
Change-Id: I1ea5a8cf26e3883b5d26fb970bc0abc4cbf1ee9a
Chris André [Wed, 22 Apr 2020 01:26:12 +0000 (21:26 -0400)]
Add null test in ArtifactsOperations
- Added if statement in `updateArtifactOnGraph` to account for the case where variable `artifactInst` has not been properly initialized
Issue-ID: SDC-2919
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I73fe3b3bcef59e5797a0f7cfe7b6894816d0d3fb
Chris André [Wed, 22 Apr 2020 01:11:55 +0000 (21:11 -0400)]
Minor cleanups for JanusGraphDao
- Fixed typo in a call to `logger.debug`
- Modified if statement following recommendation from SonarCloud
Issue-ID: SDC-2918
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I75d50d74703bf7c706b84723bb5d43760b8b7baf
Chris André [Wed, 22 Apr 2020 00:28:38 +0000 (20:28 -0400)]
Add null test to test in `UpgradeBusinessLogic`
Issue-ID: SDC-2915
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I4e6f27b707b1bdbbecf9a97606c9a655d834fe56
Chris André [Wed, 22 Apr 2020 00:41:08 +0000 (20:41 -0400)]
Add null tests in `createComponentExternal`
Issue-ID: SDC-2916
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: Ieb0a79c8d3a891a08cd758e1a4ebab7679166476
Ofir Sonsino [Tue, 21 Apr 2020 17:30:28 +0000 (20:30 +0300)]
INFO.yaml update
Change-Id: Ie410001eae688aa9d0c579f35eb57eeebfe9ae08
Issue-ID: SDC-2934
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
andre.schmid [Tue, 21 Apr 2020 13:13:17 +0000 (14:13 +0100)]
Fix catalog-ui dev proxy calls to uicache
Fixes webpack dev server proxy to uicache removed in
SDC-2843, Change Id: I9a6c89e45ea425eb9abf827906562e14a39cf1ff.
Change-Id: I83aa842df4c7bf3d140216c93b48eb1cfec48656
Issue-ID: SDC-2944
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Tue, 21 Apr 2020 13:01:21 +0000 (14:01 +0100)]
Fix 404 in sdc-FE calls to workflow
Fixes webpack workflow proxy configuration.
Fixes FE proxy while rewriting URLs to workflow plugin.
Fixes compilation problems to run locally the catalog-ui.
Change-Id: I89f3f46bd8ce0159713b1d0d957a2e75f8a3d062
Issue-ID: SDC-2943
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Tue, 21 Apr 2020 13:30:00 +0000 (14:30 +0100)]
Fix catalog-fe plugin online checking
ESAPI encoder cannot be loaded due to a missing ESAPI.properties file
in path, which causes an exception and breaks the online checking call.
The plugin is always shown as offline.
Change-Id: I05088d200e9a1bea1de2e00c07d5bbf6e3a67d41
Issue-ID: SDC-2945
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Francis Toth [Sun, 19 Apr 2020 23:50:10 +0000 (19:50 -0400)]
Remove props from ValidationConfigManager
Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I1c3a845c44722010e8933876e59752cef00937f0
Issue-ID: SDC-2499
andre.schmid [Mon, 20 Apr 2020 13:20:23 +0000 (14:20 +0100)]
Fix cs-init SchemaFileImport error file creation
Fix issue in SdcSchemaFileImport "STDERR: Error in file creation :
data, /tmp/sdctool/tosca/data-types/data.yml
(No such file or directory)", during the cassandra init.
Introduced by SDC-2898.
Change-Id: Ifd2018fac456f15d03fc39ea766a6ae0c3eda081
Issue-ID: SDC-2939
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Mon, 20 Apr 2020 07:47:08 +0000 (08:47 +0100)]
Fix GAB problem in ui-ci tests
Generic Artifact Browser is failing in tests due
to an assertion problem.
Change-Id: Ib398d04f0a876ae7d531af14e129f0dc6838dd52
Issue-ID: SDC-2903
Signed-off-by: andre.schmid <andre.schmid@est.tech>
Chris André [Thu, 16 Apr 2020 00:05:32 +0000 (20:05 -0400)]
Added a try-with-resource to properly close a FileInputStream
Issue-ID: SDC-2898
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I0a0163937ee2e760f3074d858dfc68a7b262ecd9
Chris André [Thu, 16 Apr 2020 20:29:05 +0000 (16:29 -0400)]
Added early check for null value for `containerV`
- Formatting code following project's code style
- Added early check for null value for `containerV`
Issue-ID: SDC-2904
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: Ib8d7c1bf36608855c73d8a0df637e86aefce9377
aribeiro [Fri, 3 Apr 2020 11:01:29 +0000 (12:01 +0100)]
Fix Tosca properties declaration
Remove duplicated entries
Default value for Boolean type should not be a String
According to the description for the keyname 'attachments:' it should be of type List rather than String
Issue-ID: SDC-2870
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Iac2b4f89dac16a6aef9dcabea74def5cacff99a6
andre.schmid [Fri, 17 Apr 2020 13:53:17 +0000 (14:53 +0100)]
Validates artifact configuration
Validates if all the SDC base artifacts are configured.
The base artifacts are provided by the ArtifactTypeEnum.
Change-Id: Iffa38d6ba276014940afad71f7472bc8d730fcf8
Issue-ID: SDC-2929
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Wed, 29 Jan 2020 17:25:21 +0000 (17:25 +0000)]
Configure a new Artifact Type
Centralizes artifact configuration in one yaml entry.
Allow the configuration of a new artifact type without
the need of code changes.
The configuration file now is used as a source of
artifacts types instead the artifact type enum.
The enum will be used as a source of base artifact types
and also in hard coded business rules.
Change-Id: Id0383d9fca9bce0519a4d52a4ecb3a68c8713f0f
Issue-ID: SDC-2754
Signed-off-by: andre.schmid <andre.schmid@est.tech>
andre.schmid [Fri, 3 Apr 2020 16:41:23 +0000 (17:41 +0100)]
Max boundary check for instances relationships
Considering the max boundary of a requirement during a component
composition, allowing the correct number of the requirement
relationships between instances.
Change-Id: I82a1a6daeda8fadcf1c232b117d5b099db7b35d7
Issue-ID: SDC-2872
Signed-off-by: andre.schmid <andre.schmid@est.tech>
vasraz [Thu, 2 Apr 2020 15:26:24 +0000 (16:26 +0100)]
Fix non appearance VFCs on the Home tab
Change-Id: I1543da25b76adbe426726444bd855393267fabe5
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2868
Divyang Patel [Thu, 9 Apr 2020 11:31:49 +0000 (21:31 +1000)]
Added ui-ci test case for checking if hidden
categories are not visible (USECASE: 3rd Party Operational Domain Manager)
Issue-ID: SDC-2879
Signed-off-by: Divyang Patel <divyang.patel@team.telstra.com>
Change-Id: Ic64b7de0f6ee70aef279ce13c3d2e18c194c6789
Chris André [Thu, 16 Apr 2020 00:18:59 +0000 (20:18 -0400)]
Simplified thread-safety for the `getGson` method
Issue-ID: SDC-2900
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I8c687bb408a5e0b1e95316bdae6d53126bc82696
Sebastien Premont-Tendland [Thu, 16 Apr 2020 18:51:35 +0000 (14:51 -0400)]
Unable to update VSP (heat template) version in VF
This seems to fix the issue, we can still
onboard CBA at VF level and the CBA get included
in the distributed CSAR under the directory
Artifacts/*/Deployment/CONTROLLER_BLUEPRINT_ARCHIVE/
as expected
Issue-ID: SDC-2892
Signed-off-by: Sebastien Premont-Tendland <sebastien.premont@bell.ca>
Change-Id: Ie9f9cd7b8d2cf5eb3ff3c41a4b04eedd788265a6
Neil Derraugh [Fri, 17 Apr 2020 17:35:30 +0000 (13:35 -0400)]
ZipSlip test fails on Mac OS
Mac OS has a symlink in the tmp dir that gets created in the test for
ZipSlip. Using real paths prevents the test test from failing by using
actual paths instead of a potentially different symlinked path to the
canonical path.
Issue-ID: SDC-2887
Signed-off-by: neil.derraugh <neil.derraugh@yoppworks.com>
Change-Id: Iafb0a84f6ab68276c5782c1ef716c59435aa72f5
Chris André [Wed, 15 Apr 2020 17:37:46 +0000 (13:37 -0400)]
Removed explicit references to exceptions in log messages
Issue-ID: SDC-2884
Change-Id: I6f3e9503922cc3a4f4049fced8d23cede7b0455a
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
andre.schmid [Fri, 10 Apr 2020 13:13:23 +0000 (14:13 +0100)]
Fix GAB problem in ui-ci tests
Generic Artifact Browser is failing in tests
due mainly to a removal of the default constructor
in GAB class.
Change-Id: Id10b8d8d81c224e2658002b9c928e8aef7ca8e32
Issue-ID: SDC-2903
Signed-off-by: andre.schmid <andre.schmid@est.tech>
k.kedron [Wed, 8 Apr 2020 16:00:11 +0000 (18:00 +0200)]
Improved UX in the distribution component
Added new logic to expand currently open tab,
after clicking the refresh button.
Issue-ID: SDC-2886
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Ib9d1c7cbf2ca2dd9df22f7f74ffda64144c06047
vasraz [Wed, 15 Apr 2020 09:21:49 +0000 (10:21 +0100)]
Add IntelliJ IDE files to .gitignore, remove duplications
Change-Id: I1f4934dfb8df0c485a5ecbb6e19efd0563f61520
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2895
Arindam Mondal [Mon, 13 Apr 2020 07:35:14 +0000 (16:35 +0900)]
Add java 11 dependency in openecomp-be
Issue-ID: SDC-2889
Change-Id: I1be0ffebb3b954f9020939438782dce4f62d4fad
Signed-off-by: arindam <arind.mondal@samsung.com>
Baumel, Dvir (db384r) [Mon, 23 Mar 2020 14:21:05 +0000 (16:21 +0200)]
Upgrade Junit to version 5.6
Issue-ID: SDC-2844
Change-Id: I4716bf7920f9bb79c450ebfd48e9d4fba54fdfdd
Signed-off-by: Baumel, Dvir (db384r) <dvir.baumel@intl.att.com>
Reo Inoue [Fri, 10 Apr 2020 00:32:45 +0000 (09:32 +0900)]
Add some unit tests
This change adds unit tests for ComponentLogi
to increase test coverage.
Issue-ID: SDC-2885
Change-Id: I53e5da1a1022ef2a6e29119cc531b61dcc3020b1
Signed-off-by: Reo Inoue <inoue.reo@jp.fujitsu.com>
Aric Gardner [Thu, 9 Apr 2020 19:40:55 +0000 (12:40 -0700)]
Automation adds workflow.rst
Issue-ID: CIMAN-376
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: If806410c1e2bbe480a1a77c4e04ad38e5084aa5e
Aric Gardner [Thu, 9 Apr 2020 19:23:12 +0000 (12:23 -0700)]
Automation adds dcaedesigner.rst
Issue-ID: CIMAN-376
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: Ie948abc12c8f0233f39e935dfa9494b726586621
LF Jenkins CI [Wed, 8 Apr 2020 20:24:12 +0000 (20:24 +0000)]
Automation adds sdc-architecture.rst
Issue-ID: CIMAN-376
Change-Id: Ia5a1e44150c71d4fc4fbda18099df1f9bca83dd9
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
LF Jenkins CI [Wed, 8 Apr 2020 19:40:21 +0000 (19:40 +0000)]
Automation adds sdc-offeredapis.rst
Issue-ID: CIMAN-376
Change-Id: I79720045f2583c91f24ec109a17e76050bafabbb
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
LF Jenkins CI [Tue, 7 Apr 2020 20:26:36 +0000 (20:26 +0000)]
Automation adds release-notes.rst
Add _release_notes hook to allow automation.
Fix non valid release notes characters in content.
Issue-ID: CIMAN-376
Change-Id: I331047b44e54cb210d8bbc8b5cc84841b13b36d5
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
LF Jenkins CI [Tue, 7 Apr 2020 17:43:35 +0000 (17:43 +0000)]
Automation adds index.rst
Issue-ID: CIMAN-376
Change-Id: I6b9df89424fcb6ad0cbdbe6631b4514f20edf57a
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
Dmitry Puzikov [Mon, 6 Apr 2020 14:12:42 +0000 (16:12 +0200)]
Added more tests to increase coverage
Removed redundant tests
Change-Id: I7776639d435267c4c38a32a7c19d925b0e715b15
Issue-ID: SDC-2869
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Dmitry Puzikov [Thu, 2 Apr 2020 17:03:21 +0000 (19:03 +0200)]
More unit tests added
Unused constant removed.
Error logging added.
Change-Id: I91dca825e54ffd8f11a69344d6bb00b4e70dbea1
Issue-ID: SDC-2869
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
k.kedron [Mon, 6 Apr 2020 12:21:40 +0000 (14:21 +0200)]
Added more tests.
Added more unit tests for cover CapabilityRequirementConverter.
Issue-ID: SDC-2869
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: If4f252f63cf126aab0961199c296581c0d089b21
Dmitry Puzikov [Fri, 3 Apr 2020 15:40:28 +0000 (17:40 +0200)]
More tests added
Change-Id: I4b6ec51eb13d3553b308f794fb22b7761993f0ab
Issue-ID: SDC-2869
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
vasraz [Thu, 2 Apr 2020 18:23:40 +0000 (19:23 +0100)]
Increase test coverage
Change-Id: I5ed0e2520305519af573df10768c3ee69c39f213
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
aribeiro [Thu, 2 Apr 2020 09:04:31 +0000 (10:04 +0100)]
Fix when adding a VF
Remove duplicated field when adding VF, fix label names and fix field that appears mandatory even though its not
Issue-ID: SDC-2865
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Iac0866ebcd1b90570949fe9c851fec1f861818af
andre.schmid [Thu, 2 Apr 2020 13:39:47 +0000 (14:39 +0100)]
Fix ready probe exit code
The exit code ranges from 0 to 255, so it should not be
returning the http status code.
This was breaking the health check for the docker_run.sh
script, which was always getting a 0 return code in a
case of 503 http status for example.
Change-Id: I52b2923cdfc0d7389894917ccc4aa58468ac8bdc
Issue-ID: SDC-2867
Signed-off-by: andre.schmid <andre.schmid@est.tech>
ilanap [Wed, 1 Apr 2020 11:25:35 +0000 (14:25 +0300)]
bugfix for operations screen
Add Operation Button is missing in Service management
committing fix by Akiva
Issue-ID: SDC-2843
Signed-off-by: ilanap <ilanap@amdocs.com>
Change-Id: I9a6c89e45ea425eb9abf827906562e14a39cf1ff
andre.schmid [Tue, 31 Mar 2020 10:39:52 +0000 (11:39 +0100)]
Fix sdc-backend image context.xml creation
The file was not being overwritten during the build process.
It was not changing after the first build, causing war artifact
version problems while running the container.
Change-Id: I8b1ab741c82f9274a2049bb4c2d1c3a8c1c8ee38
Issue-ID: SDC-2862
Signed-off-by: andre.schmid <andre.schmid@est.tech>
aribeiro [Thu, 2 Apr 2020 13:05:57 +0000 (14:05 +0100)]
Fix data type properties declaration
According to TOSCA Network properties definition the keyname 'ip_version:' should have Integer as valid_values rather than String
Where the keyname 'count:' is declared as a String type the default value should be String rather than Integer
Fix misspelled ONAP types 'onap.datatypes.monitoring.measurementType' and 'onap.datatypes.monitoring.managedObjectDNsBasic'
Fix the keynames 'upstream:' and 'downstream:' as both are declared as a String type the valid_values should be String rather than Integer
Issue-ID: SDC-2864
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I56afdf2818b5f2463fb6088cd8b468fd38ef5086
aribeiro [Thu, 2 Apr 2020 09:53:12 +0000 (10:53 +0100)]
Fix keyname 'constraints:' according to TOSCA property definition
Issue-ID: SDC-2863
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I955af393b4f10ca56a01bfcb2f62c37496c484d6
aribeiro [Thu, 2 Apr 2020 14:00:20 +0000 (15:00 +0100)]
Remove keyname 'required' from Schema definition
The Schema definitions does not have keyname 'required'. The keyname 'required' is a TOSCA property definition.
Issue-ID: SDC-2866
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I0a827d30c8790ec63c20a9da6cd0758eb024c491
vasraz [Thu, 2 Apr 2020 09:26:08 +0000 (10:26 +0100)]
Increase test coverage
Change-Id: I0c8ddfb32ae7abc6443007fc5cee72bec6da785b
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
Dmitry Puzikov [Wed, 1 Apr 2020 15:11:21 +0000 (17:11 +0200)]
Tests added to increase coverage
Change-Id: I16a729385647cb691fb7c94bd8f26a3c19b1b99d
Issue-ID: SDC-2861
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
vasraz [Wed, 1 Apr 2020 13:43:08 +0000 (14:43 +0100)]
Increase test coverage
Change-Id: I290371a025ba3376a013ba464e4dfb601d74aa8b
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
vasraz [Wed, 1 Apr 2020 11:07:50 +0000 (12:07 +0100)]
Increase test coverage
Change-Id: I7b1d4b783d2d8e41a8ff92db15d77270ba4eef80
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
Ofir Sonsino [Wed, 1 Apr 2020 07:52:28 +0000 (10:52 +0300)]
R6 release notes and documentation update
Change-Id: Ieebd8c55a505d02ceef5e330d047c024f5d820db
Issue-ID: SDC-2793
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
Satoshi Fujii [Wed, 26 Feb 2020 06:39:38 +0000 (15:39 +0900)]
Fix catalog-be unit test failure
Fixed catalog-be test failure due to missing imports
Change-Id: I91f281302a33b5b8f640100a3f1b77908ae44e7c
Issue-ID: SDC-2659
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Satoshi Fujii [Wed, 26 Feb 2020 06:39:38 +0000 (15:39 +0900)]
Add 'required in runtime' for service inputs
User may want to set required to true for some inputs
so that make sure those input values are given at service
instantiation time.
By this change 'required in runtime' column is introduced into
service inputs table in Properties Assignment screen
and user can select required true/false for each input.
Change-Id: I0d676d2d20e02c975d51c7f4d2bb63c699743d66
Issue-ID: SDC-2659
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
vasraz [Thu, 26 Mar 2020 14:20:02 +0000 (14:20 +0000)]
Increase test coverage
Change-Id: Ibc6134e5954537258541ff018dc9794191d4e907
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
vasraz [Thu, 26 Mar 2020 17:25:54 +0000 (17:25 +0000)]
Increase test coverage
Change-Id: If9b371042a42213f38828f9628714d076261f25c
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
ilanap [Thu, 26 Mar 2020 10:50:06 +0000 (12:50 +0200)]
Initial fix for https call to plugins
Creates an http/https client to check whether plugin is online. missing UI fixes still
Issue-ID: SDC-2843
Signed-off-by: ilanap <ilanap@amdocs.com>
Change-Id: I06ee08c73881c8a8c458198f9b6a0f9df1021f52
Signed-off-by: ilanap <ilanap@amdocs.com>
Dmitry Puzikov [Wed, 25 Mar 2020 15:31:43 +0000 (16:31 +0100)]
Fix unit tests
Added asserts where required, add tests.
Replaced getters-setters with Lombok annotations.
Fixed incorect SUT in the tests.
Removed default constructors used only for tests.
Change-Id: I9be29d9c0d891039952178a3c3e1c3a2062d1382
Issue-ID: SDC-2856
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Tufman, Shay (st198j) [Wed, 25 Mar 2020 12:41:45 +0000 (14:41 +0200)]
Support 50 Characters for VSP Name
Change-Id: I02ddb9d67669e2ecca02762a4bb9862bf28df3cb
Issue-ID: SDC-2854
Signed-off-by: Tufman, Shay (st198j) <st198j@att.com>
k.kedron [Wed, 25 Mar 2020 14:29:42 +0000 (15:29 +0100)]
Updated the sdc cert
Issue-ID: SDC-2855
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I1ee3f155ca50edee4a47b8585d95f9a3f848b94a
vasraz [Tue, 24 Mar 2020 17:32:06 +0000 (17:32 +0000)]
Increase test coverage
Change-Id: Ie28e36012be1313efa0082b34c0b36c325dc1b76
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
vasraz [Tue, 24 Mar 2020 12:29:04 +0000 (12:29 +0000)]
Increase test coverage
Change-Id: I90606d768c55ad13aa9df62bc4d3f533206db1bc
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2833
Dmitry Puzikov [Tue, 24 Mar 2020 17:22:03 +0000 (18:22 +0100)]
Fix unit tests
Add asserts where required, fix tiny issues.
Replace getters-setters with Lombok annotations.
Change-Id: Icb1a20f400fd8732a3d0ae23b8fe88bc693df1f5
Issue-ID: SDC-2853
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Ben David, Elad (eb7504) [Mon, 23 Mar 2020 16:05:27 +0000 (18:05 +0200)]
Fix to CSIT failure due to EP type
Change-Id: I6a2bcd4b43490898952fa1a5ea171ece015d376c
Issue-ID: SDC-2820
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
Lasse Kaihlavirta [Tue, 24 Mar 2020 13:43:15 +0000 (15:43 +0200)]
Improve log texts
Issue-ID: SDC-2852
Signed-off-by: Lasse Kaihlavirta <l.kaihlavirt@partner.samsung.com>
Change-Id: I7a1ebfc625e297f943794046f37b15cc48d8cacb
Ofir Sonsino [Sun, 22 Mar 2020 08:46:13 +0000 (10:46 +0200)]
Fix for Operation Button is missing
Change-Id: I4da92b9e7055c4b7b375e77aab87122e8a61b520
Issue-ID: SDC-2843
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
Code Review / sdc.git / log