Bonkur, Venkat (vb8416) [Thu, 8 Aug 2019 16:41:12 +0000 (12:41 -0400)]
Add SO re-name the migration sql for version conflict
Rename the version from V6.1 to V6.3 for
V6.1__AlterColumnActionCategoryControllerSelectionCategory.sql
There is another script with same version in the att ecomp.
Issue-ID: SO-2209
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ia7e527419dfe149f8cbdd9d0748768f8b7bc9904
Seshu Kumar M [Thu, 8 Aug 2019 12:56:37 +0000 (12:56 +0000)]
Merge "Fix NoClassDefFoundError for ServicePluginFactory"
Seshu Kumar M [Thu, 8 Aug 2019 12:55:47 +0000 (12:55 +0000)]
Merge "VNFM adapter support two way TLS"
Lukasz Muszkieta [Thu, 8 Aug 2019 11:57:01 +0000 (11:57 +0000)]
Merge "Added null check for listFiles() result to prevent crash at iterating through file list; replaced System.out.println calls with logger calls"
sarada prasad sahoo [Thu, 8 Aug 2019 09:51:43 +0000 (15:21 +0530)]
Fix NoClassDefFoundError for ServicePluginFactory
Fix NoClassDefFoundError for ServicePluginFactory
appears when we run SO via docker-compose command
Change-Id: I8ba5963edf28f81d948f71a9d698541f682de908
Issue-ID: SO-2206
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Seshu Kumar M [Thu, 8 Aug 2019 11:36:56 +0000 (11:36 +0000)]
Merge "Sonar fixes for SvnfmController"
Seshu Kumar M [Thu, 8 Aug 2019 11:35:43 +0000 (11:35 +0000)]
Merge "Added null checks for getUpdateResInputObj() return value to prevent crash at toString() calls"
Seshu Kumar M [Thu, 8 Aug 2019 11:34:36 +0000 (11:34 +0000)]
Merge "Replace collections.size with isEmpty for better performance"
Oleksandr Moliavko [Thu, 8 Aug 2019 06:34:45 +0000 (09:34 +0300)]
Added null check for listFiles() result to prevent crash
at iterating through file list; replaced System.out.println
calls with logger calls
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I6b4a49228903f013127b39244db9d1b67c0ff2f0
Oleksandr Moliavko [Thu, 8 Aug 2019 10:13:29 +0000 (13:13 +0300)]
Added null checks for getUpdateResInputObj() return value
to prevent crash at toString() calls
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If55fd3b00fe9d2406fe1b2eeda66fa005ce13bc4
sindhu3672 [Thu, 8 Aug 2019 09:33:57 +0000 (15:03 +0530)]
Avoid local variables shadow class fields
Avoid local variables shadow class fields mso catalog db adapter
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ie2a62a76ca43a5c7f2e0cdee00263230a2ae154d
sindhu3672 [Thu, 8 Aug 2019 09:12:50 +0000 (14:42 +0530)]
Replace collections.size with isEmpty for better performance
Replace collections.size with isEmpty for better performance asdc-controller
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ie8adc3a149a583fe66c771ee70ae95055a229f83
subhash kumar singh [Thu, 8 Aug 2019 09:03:23 +0000 (09:03 +0000)]
Merge "Fix Critical Bug - print array content correctly"
subhash kumar singh [Thu, 8 Aug 2019 09:02:12 +0000 (09:02 +0000)]
Merge changes I910db5fe,I269f4e20,I2ad55d49,I1cb6eee0,Ifa375512, ...
* changes:
add vid based apis details
add uui based apis details
add vid based instantiation flows
add e2e flow details
add pnf instantiate flows
add the NBI section to the instantiate flows
Lukasz Muszkieta [Thu, 8 Aug 2019 08:11:42 +0000 (08:11 +0000)]
Merge "Fix sonar issues in MSOCoreBPMN"
seshukm [Thu, 8 Aug 2019 07:34:28 +0000 (13:04 +0530)]
add vid based apis details
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I910db5fe7e2006ec3808ce738fd11fb9b061e47a
seshukm [Thu, 8 Aug 2019 07:33:42 +0000 (13:03 +0530)]
add uui based apis details
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I269f4e20e0c30168a97ef3db056a69fefd564eac
seshukm [Thu, 8 Aug 2019 07:33:06 +0000 (13:03 +0530)]
add vid based instantiation flows
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I2ad55d49bd1be2a684354f958dcbe93cf0dbaf17
seshukm [Thu, 8 Aug 2019 07:32:21 +0000 (13:02 +0530)]
add e2e flow details
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I1cb6eee09292ed206a4315e1e9245d35256fd357
seshukm [Thu, 8 Aug 2019 07:30:41 +0000 (13:00 +0530)]
add pnf instantiate flows
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: Ifa375512d97aa5f9c56156a20eae5e220ef0039c
seshukm [Thu, 8 Aug 2019 07:29:54 +0000 (12:59 +0530)]
add the NBI section to the instantiate flows
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I5567a89fa36aa85397a3472147e7848f44561a48
Seshu Kumar M [Thu, 8 Aug 2019 07:25:06 +0000 (07:25 +0000)]
Merge "Replace duplicated String literals"
Seshu Kumar M [Thu, 8 Aug 2019 07:24:02 +0000 (07:24 +0000)]
Merge "Shift string literal to left side of equals(avoid null pointer ex)"
subhash kumar singh [Thu, 8 Aug 2019 06:58:44 +0000 (06:58 +0000)]
Merge changes I00b02c80,Icf854fba,I41a7ea89,I3c9b75ba
* changes:
add instantiation flow
add pre_instantiation details
add the information of the instantiate in dev guide
correct the camunda modeler info Introduce the instantiate flow details
Seshu Kumar M [Thu, 8 Aug 2019 06:11:13 +0000 (06:11 +0000)]
Merge "Set suppressRollback variable for ActivityBBs"
sindhu3672 [Thu, 8 Aug 2019 06:10:48 +0000 (11:40 +0530)]
Shift string literal to left side of equals(avoid null pointer ex)
Avoid null pointer exception mso-openstack-adapters classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ie7099318a79162aed26ec3a8e4a013cece367736
seshukm [Thu, 8 Aug 2019 05:58:35 +0000 (11:28 +0530)]
add instantiation flow
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I00b02c80c357ce5379d89769a3552e826ef257cc
seshukm [Thu, 8 Aug 2019 05:57:27 +0000 (11:27 +0530)]
add pre_instantiation details
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: Icf854fba5ea3c94a0b320ed5fef6375a688b040f
seshukm [Thu, 8 Aug 2019 05:49:42 +0000 (11:19 +0530)]
add the information of the instantiate in dev guide
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I41a7ea89245da8be8e1a1e41138a662e9cce2ffa
sindhu3672 [Wed, 7 Aug 2019 10:09:35 +0000 (15:39 +0530)]
Replace duplicated String literals
Replace duplicated String literals mso-openstack-adapters files
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I3089f407ffd01afbccaada81c2aef290299dfe32
seshukm [Thu, 8 Aug 2019 05:43:54 +0000 (11:13 +0530)]
correct the camunda modeler info
Introduce the instantiate flow details
Issue-ID: SO-608
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I3c9b75ba734b918d2ee57242944b4b087e9e5792
Parshad Patel [Thu, 8 Aug 2019 04:10:59 +0000 (13:10 +0900)]
Fix sonar issues in MSOCoreBPMN
Either log or rethrow this exception
Make "serviceParams" transient or serializable
Make "extSystemErrorSource" transient or serializable
Issue-ID: SO-1841
Change-Id: If752c7898a0934212d425b1c80b8d2ee34098ad3
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Bonkur, Venkat (vb8416) [Wed, 7 Aug 2019 17:47:54 +0000 (13:47 -0400)]
Add SO Message instead of Exception when vmIds are empty
Add the conditions to log messages instead of null pointer exception
when vmIds or vserverIds are not present.
Issue-ID: SO-2186
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I27dd8a5480cf5e2d8588cc71ca3bfefaf0e138cc
Lukasz Muszkieta [Wed, 7 Aug 2019 13:39:20 +0000 (15:39 +0200)]
Fix Critical Bug - print array content correctly
Change-Id: I525c2f3d2731a38183de108d4674d9dcef43bcb7
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Lukasz Muszkieta [Wed, 7 Aug 2019 13:14:53 +0000 (15:14 +0200)]
Sonar fixes for SvnfmController
Change-Id: I70051af78d353447e11985cc1a8fa8e7f2606f89
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Steve Smokowski [Wed, 7 Aug 2019 12:16:52 +0000 (12:16 +0000)]
Merge "updated delete payloads for bulk deletes"
Elena Kuleshov [Tue, 6 Aug 2019 19:55:54 +0000 (15:55 -0400)]
Set suppressRollback variable for ActivityBBs
SuppressRollback variable needs to be true for ActivityBBs
Issue-ID: SO-2163
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I64754e9fc010b48eb8ee9b41fd0fe31c0fbb2592
Merkel, Jeff [Tue, 6 Aug 2019 19:56:30 +0000 (15:56 -0400)]
- Updated cvnfc's to use the getEntity API.
- Updated cvnfc's to use the getEntity API.
Issue-ID: SO-2202
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id367e82d655a838100d8f81f8b4f76303600b182
Benjamin, Max [Tue, 6 Aug 2019 19:54:51 +0000 (15:54 -0400)]
updated delete payloads for bulk deletes
updated delete payloads for bulk deletes
moved test-request.json to the correct location
Issue-ID: SO-2203
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8d9d4d0bbe45f32d4e07a1ba0128e627d3b27795
Oleksandr Moliavko [Tue, 6 Aug 2019 08:59:56 +0000 (11:59 +0300)]
Added close() call for InputStream instance to
remove static analyzer warning about handle
leak in getMsoAaiPassword()
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I2be9cc72f78275a80c6f03d806bea2ad275f23b4
Seshu Kumar M [Mon, 5 Aug 2019 12:07:54 +0000 (12:07 +0000)]
Merge "Added null check for return value of getUpdateResInputObj(), to prevent crash at call of toString() method"
Seshu Kumar M [Mon, 5 Aug 2019 12:01:07 +0000 (12:01 +0000)]
Merge "ModelInstanceName is required in SNIROHomingv2 to"
Seshu Kumar M [Mon, 5 Aug 2019 11:58:27 +0000 (11:58 +0000)]
Merge "Added newToken null check to prevent crash at newToken.getValue() call"
Oleksandr Moliavko [Mon, 5 Aug 2019 11:21:10 +0000 (14:21 +0300)]
Added null check for return value of
getUpdateResInputObj(), to prevent crash at call
of toString() method
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ifa6c683885490fef7fcf08e2b32b2dc76ef776a6
Seshu Kumar M [Mon, 5 Aug 2019 05:13:36 +0000 (05:13 +0000)]
Merge "Removed addition of null value to string to prevent static analyzer warning"
Seshu Kumar M [Mon, 5 Aug 2019 05:12:20 +0000 (05:12 +0000)]
Merge "Fix Blocker Bug"
MichaelMorris [Fri, 2 Aug 2019 23:20:31 +0000 (23:20 +0000)]
VNFM adapter support two way TLS
Change-Id: Icdb57587c9070bcce405eeaea4275fea0af0533a
Issue-ID: SO-2190
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Lukasz Muszkieta [Fri, 2 Aug 2019 16:59:12 +0000 (18:59 +0200)]
Fix Blocker Bug - prevent from npe throwing
Change-Id: Id6dd23c07f282ac7c7d3df3f612175d1bbf5a184
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Lukasz Muszkieta [Fri, 2 Aug 2019 15:36:37 +0000 (17:36 +0200)]
Fix Blocker Bug
Change-Id: I6be7c799896d32ffd20591ce9b8a0957d506b5c3
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Gamboa, Gilbert [Fri, 2 Aug 2019 14:11:17 +0000 (10:11 -0400)]
ModelInstanceName is required in SNIROHomingv2 to
ModelInstanceName is required in SNIROHomingv2 to build placement
demand. The source service does not have a modelInstanceName attribute,
we need to set it to the service proxy modelInstanceName.
Issue-ID: SO-2188
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I85c0940b17349c8dd5dc171954acf9f884ccff9f
Oleksandr Moliavko [Fri, 2 Aug 2019 13:08:18 +0000 (16:08 +0300)]
Added newToken null check to prevent crash at
newToken.getValue() call
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib338ec2d901fd68d5b04be4423088449546b7e31
Oleksandr Moliavko [Fri, 2 Aug 2019 12:26:05 +0000 (15:26 +0300)]
Removed addition of null value to string to
prevent static analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib9dbd55f3688e38688668828778653eadc04a836
Seshu Kumar M [Fri, 2 Aug 2019 07:09:32 +0000 (07:09 +0000)]
Merge "Use correct name and id for VNFUnsetClosedLoopDisabledFlagActivity"
Seshu Kumar M [Fri, 2 Aug 2019 07:08:00 +0000 (07:08 +0000)]
Merge "Fixed potential crashes due to null object dereference attempts in exception handlers"
Seshu Kumar M [Fri, 2 Aug 2019 07:05:41 +0000 (07:05 +0000)]
Merge "General sonar fixes"
Seshu Kumar M [Fri, 2 Aug 2019 07:03:47 +0000 (07:03 +0000)]
Merge "Add oauth for calls from VNFM to VNFM adapter"
Seshu Kumar M [Fri, 2 Aug 2019 07:00:40 +0000 (07:00 +0000)]
Merge "Add SO Increase Action_category column width"
Seshu Kumar M [Fri, 2 Aug 2019 06:59:14 +0000 (06:59 +0000)]
Merge "Added null checks to prevent crashes at method calls"
Seshu Kumar M [Fri, 2 Aug 2019 06:56:19 +0000 (06:56 +0000)]
Merge "Added null check for injectedVariables to prevent crash at call of injectedVariables.get()"
Arindam Mondal [Fri, 2 Aug 2019 06:08:56 +0000 (15:08 +0900)]
General sonar fixes
+) Add logger to log exception
++) Format logger
Issue-ID: SO-2187
Change-Id: Id77271340070a61e7ce82822321d7e5b8b03f759
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Seshu Kumar M [Fri, 2 Aug 2019 05:45:09 +0000 (05:45 +0000)]
Merge "Updatable to false to prevent setting fk to null"
Bonkur, Venkat (vb8416) [Fri, 2 Aug 2019 03:30:05 +0000 (23:30 -0400)]
Add SO Increase Action_category column width
Action_category column width in Controller_selection_category table
is increased to accommodate activity categories like
DistributeTrafficCheck which are longer than the column width.
Issue-ID: SO-2185
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ia5c813bfabfc95d4502c7ade4413672c64ad8ada
MichaelMorris [Thu, 1 Aug 2019 21:57:24 +0000 (21:57 +0000)]
Add oauth for calls from VNFM to VNFM adapter
Change-Id: I6ff1f9ed130b8331f6a001d3dcb64b9dcfb30eb5
Issue-ID: SO-2180
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Byung-Woo Jun [Thu, 1 Aug 2019 17:47:33 +0000 (17:47 +0000)]
Merge "Add oauth for calls from VNFM adapter to VNFM"
Oleksandr Moliavko [Thu, 1 Aug 2019 14:25:47 +0000 (17:25 +0300)]
Added null checks to prevent crashes at
method calls
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ie3b70aa59cf73ca6203d0f1aab1ed096af906050
Oleksandr Moliavko [Thu, 1 Aug 2019 11:02:18 +0000 (14:02 +0300)]
Fixed potential crashes due to null object
dereference attempts in exception handlers
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I9882171b47b6442fa8ca12110d8ef23fc975347b
Elena Kuleshov [Thu, 1 Aug 2019 07:13:04 +0000 (03:13 -0400)]
Handle no pservers case on lock check
Check for null return value from pservers query
Issue-ID: SO-2184
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I34c71601e694241a6d3cfefa8227200e715e2ed3
Oleksandr Moliavko [Mon, 29 Jul 2019 15:13:55 +0000 (18:13 +0300)]
Added null check for injectedVariables to prevent
crash at call of injectedVariables.get()
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I1d05b32b0aa0c001c79e41576bc8b3435a9aae1f
Elena Kuleshov [Thu, 1 Aug 2019 05:47:58 +0000 (01:47 -0400)]
Use correct name and id for VNFUnsetClosedLoopDisabledFlagActivity
Set name and id for VNFUnsetClosedLoopDisabledFlagActivity to VNFUnsetClosedLoopDisabledFlagActivity
Issue-ID: SO-2183
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I401258b2db32c43566019a903a57ca61e30649e0
Steve Smokowski [Wed, 31 Jul 2019 19:40:09 +0000 (19:40 +0000)]
Merge "Changed to set source service as model info"
Boslet, Cory [Wed, 31 Jul 2019 15:23:30 +0000 (11:23 -0400)]
Changed to set source service as model info
Changed to set source service as model info for service proxy per sniro.
Updated junit test to account for source service change.
Issue-ID: SO-2179
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I43161f0109b62a895d5122a7b0aca0eea8694b16
Benjamin, Max (mb388a) [Wed, 31 Jul 2019 15:03:06 +0000 (11:03 -0400)]
added back missing method in groovy file
Need to bring back AbstractTaskProcessor.logWorkflowException()
method because this is being called from a number of groovy files.
Issue-ID: SO-2172
Change-Id: Id5dee85fcb48265955dde3d74f7c0f98300410f0
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Plummer, Brittany [Wed, 31 Jul 2019 13:30:43 +0000 (08:30 -0500)]
Updatable to false to prevent setting fk to null
Updatable to false to prevent setting foreign key to null before delete
Issue-ID: SO-2178
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I9b9f94c0d0b56a61cd8b9c56e80e5a3ec4819a50
MichaelMorris [Wed, 31 Jul 2019 13:28:48 +0000 (13:28 +0000)]
Add oauth for calls from VNFM adapter to VNFM
Change-Id: I0e6ba16bbeab457ec0c1985e345e26f544434667
Issue-ID: SO-2169
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Seshu Kumar M [Wed, 31 Jul 2019 12:58:31 +0000 (12:58 +0000)]
Merge "fix install SO docs"
Seshu Kumar M [Wed, 31 Jul 2019 12:57:32 +0000 (12:57 +0000)]
Merge "Replaced constructor call with Boolean.valueOf() call to prevent static analyzer warning about inefficient use of constructor"
Manamohan [Wed, 31 Jul 2019 09:55:44 +0000 (15:25 +0530)]
Javadoc and logging improvement
Added Javadocs for VnfAdapterCreateTasks and SDNCAssignTasks.
Change-Id: Ifb76e278eb90ba2d4644b649e91c1ffb15c55101
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
Oleksandr Moliavko [Tue, 30 Jul 2019 13:18:31 +0000 (16:18 +0300)]
Replaced constructor call with Boolean.valueOf() call
to prevent static analyzer warning about inefficient
use of constructor
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Id5a883628726bdd0313a46ea4808a36eccf03c9a
k.kazak [Tue, 30 Jul 2019 12:04:37 +0000 (14:04 +0200)]
fix install SO docs
Fix warning in Install Configure SO doc
Fix image urls in Install Configure SO doc
Change-Id: I95cdb6898893d3a3ae3cbac430f5359e01a7500a
Issue-ID: SO-2149
Signed-off-by: k.kazak <k.kazak@samsung.com>
Seshu Kumar M [Tue, 30 Jul 2019 10:42:41 +0000 (10:42 +0000)]
Merge "apih allowing requests with the same requestid"
Seshu Kumar M [Tue, 30 Jul 2019 10:05:10 +0000 (10:05 +0000)]
Merge "Sonar fix: CreateVfModuleRequest.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:02:28 +0000 (10:02 +0000)]
Merge "Sonar fix: HealthStackAudit.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:01:31 +0000 (10:01 +0000)]
Merge "fix architecture.rst formatting"
Seshu Kumar M [Tue, 30 Jul 2019 10:00:45 +0000 (10:00 +0000)]
Merge "Javadoc and logging improvement"
Seshu Kumar M [Tue, 30 Jul 2019 09:59:26 +0000 (09:59 +0000)]
Merge "fix malformed tables in docs"
Seshu Kumar M [Tue, 30 Jul 2019 09:58:14 +0000 (09:58 +0000)]
Merge "Sonar Fix: VduArtifact.java"
Seshu Kumar M [Tue, 30 Jul 2019 09:57:48 +0000 (09:57 +0000)]
Merge "Javadoc and logging improvement"
Elena Kuleshov [Tue, 30 Jul 2019 09:40:39 +0000 (05:40 -0400)]
Use generic req mapping for CM requests
Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests.
Issue-ID: SO-2168
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed
Seshu Kumar M [Tue, 30 Jul 2019 13:32:59 +0000 (13:32 +0000)]
Merge "Added null check to heatStack.getOutputs() to prevent crash at get() call; removed redundant null check to simplify the code"
Oleksandr Moliavko [Tue, 30 Jul 2019 10:30:40 +0000 (13:30 +0300)]
Added null check to heatStack.getOutputs()
to prevent crash at get() call; removed redundant
null check to simplify the code
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If9d8dcba3008cd7ebe60c17c08c71a07a6df9df4
Seshu Kumar M [Tue, 30 Jul 2019 11:56:25 +0000 (11:56 +0000)]
Merge "Replaced constructor calls with valueOf() method calls to remove static analyzer warnings about inefficient constructor calls"
Seshu Kumar M [Tue, 30 Jul 2019 11:55:49 +0000 (11:55 +0000)]
Merge "Replaced constructor call with valueOf() call to remove static analyzer warning about inefficient use of constructor"
Seshu Kumar M [Tue, 30 Jul 2019 11:55:12 +0000 (11:55 +0000)]
Merge "Removed subscriber variable that was not actually used in any test (to remove static analyzer warning)"
Seshu Kumar M [Tue, 30 Jul 2019 11:53:12 +0000 (11:53 +0000)]
Merge "commented out bad tests, will revisit"
DeWayne Filppi [Wed, 3 Jul 2019 23:45:02 +0000 (16:45 -0700)]
commented out bad tests, will revisit
Change-Id: I57e0e1378e743074b3fad3533756179776bfaf0b
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Issue-ID: SO-1836
Oleksandr Moliavko [Tue, 30 Jul 2019 07:51:07 +0000 (10:51 +0300)]
Replaced constructor calls with valueOf() method calls
to remove static analyzer warnings about inefficient
constructor calls
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If5b0c9c3569759f738e01c0352e267ee8a995c5f
Oleksandr Moliavko [Tue, 30 Jul 2019 06:04:41 +0000 (09:04 +0300)]
Replaced constructor call with valueOf() call to
remove static analyzer warning about inefficient
use of constructor
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5b6285aa8708b57bb54a90d38130a21b07c2b2c5
Seshu Kumar M [Tue, 30 Jul 2019 05:46:43 +0000 (05:46 +0000)]
Merge "repair vfcInstanceGroup order"
Oleksandr Moliavko [Tue, 30 Jul 2019 05:36:52 +0000 (08:36 +0300)]
Removed subscriber variable that was not actually
used in any test (to remove static analyzer
warning)
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I7665c3dcb85d5c0d80c0448e6ad5ff1ece5a0bef
Plummer, Brittany [Mon, 29 Jul 2019 18:33:20 +0000 (14:33 -0400)]
apih allowing requests with the same requestid
Updated filters to throw error on duplicate requestId
Added message indicating exception will be thrown
Added unit tests for requestIdFilters
Added access modifier in filter test
Updated CloudApiRequests for successful deletion when
InfraActiveRequest is deleted
Removed changes from CloudApiRequests bean
Updated repository to include deleteByRequestId
Removed unused import from cloudApiRequests
Removed deleteByRequestId from interface
Updated to change type of extended jparepository
Removed repository added for CloudApiRequests
Updated uri check to remove '/' from checked string
Updated returned on failing junit test
Updated access modifiers for logger and createRequestError
Issue-ID: SO-2166
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id0cee672567b15e0a3eb1acfbdfb967945494500
Code Review / so.git / log