Code Review / sdc.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
sdc.git
5 years agoAvoid duplicated verification if package is signed 04/95904/5
commit | commitdiff | tree
vasraz [Thu, 5 Sep 2019 13:25:39 +0000 (14:25 +0100)]
Avoid duplicated verification if package is signed

Fix potential thread leak by using try-with-resource.

Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2580

5 years agoFix and refactor manifest parsing 91/95391/4
commit | commitdiff | tree
andre.schmid [Fri, 30 Aug 2019 17:20:32 +0000 (18:20 +0100)]
Fix and refactor manifest parsing

Fix a CMS signature reading expected token.
Fix the necessity of a empty line in the end of the manifest.
Implement CMS signature, Source checksum algorithm and digest reading.
Indicate the line number and content when a manifest error occurs.
Remove unnecessary recursive reading.
Centralize manifest tokens.
Improve tests by checking the expected error.
Document the code.

Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757
Issue-ID: SDC-2563
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agoFix factory instance creation instability 16/97316/4
commit | commitdiff | tree
andre.schmid [Fri, 18 Oct 2019 13:58:21 +0000 (14:58 +0100)]
Fix factory instance creation instability

Refactor the factory registry and instance creation.
Remove unnecessary static code in Factory creation.
Centralize the responsibility to read the factory registry configuration
and cache the factory instances in a Singleton called
FactoryRegistryManager.
Clean the base abstract factory that was sharing non factory code, it
had all the factory registry code statically, never used by the concrete
factory classes.

Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66
Issue-ID: SDC-1905
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agoChanges for new service category 40/96540/3
commit | commitdiff | tree
atif husain [Wed, 2 Oct 2019 08:03:57 +0000 (18:03 +1000)]
Changes for new service category

Introduced new service category, Partner Domain Service
Added logic to disable composition for Partner Domain Service category

Issue-ID: SDC-2382
Change-Id: I6ed135733c6f05914e102c037ebe9057ad731e75
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
5 years agoEl Alto known issues 11/97011/1
commit | commitdiff | tree
Ofir Sonsino [Sun, 13 Oct 2019 08:29:47 +0000 (11:29 +0300)]
El Alto known issues

Change-Id: I293935d6a159691390bd90dd3fc2998821c97773
Issue-ID: SDC-2569
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoFix failing unit test 32/96732/1
commit | commitdiff | tree
vasraz [Tue, 8 Oct 2019 15:44:09 +0000 (16:44 +0100)]
Fix failing unit test

Issue-ID: SDC-2609
Change-Id: Ibf411a8d10af858ee2f42f9b4b565b81fee33ebe
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
5 years agoDocument fixed OJSI tickets in release notes 55/96655/1
commit | commitdiff | tree
Krzysztof Opasiak [Sat, 5 Oct 2019 22:33:33 +0000 (00:33 +0200)]
Document fixed OJSI tickets in release notes

Issue-ID: OJSI-31
Issue-ID: OJSI-76
Issue-ID: OJSI-77
Issue-ID: OJSI-78
Issue-ID: OJSI-79
Issue-ID: OJSI-80
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ie57bdbfae0b40ff7633ff674d22ac5ad3c5cf866

5 years agoRevert "Sonar fix NullPointerException" 18/96618/2
commit | commitdiff | tree
Ofir Sonsino [Fri, 4 Oct 2019 10:51:15 +0000 (10:51 +0000)]
Revert "Sonar fix NullPointerException"

This reverts commit b0f96a46e2720c75eb035bbe94015e5a1c6b0b32.

Issue-ID: SDC-2542
Change-Id: I63b5349670c8e5fa814d686cfa93173d0ea6297e
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoFix for error message. 13/96413/2
commit | commitdiff | tree
aribeiro [Mon, 30 Sep 2019 10:04:00 +0000 (11:04 +0100)]
Fix for error message.

Fixing error message for invalid values across SDC backend API.

Issue-ID: SDC-2324
Change-Id: If01307138baf7692e398abf20eb75bbe9a8aa394
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
5 years agoAdd support for HTTPS in sanity tests 62/96062/2
commit | commitdiff | tree
Petr Ospalý [Fri, 20 Sep 2019 03:51:37 +0000 (05:51 +0200)]
Add support for HTTPS in sanity tests

If 'disableHttp' is enabled then HTTP ports are replaced with HTTPS ports.
Also added the latest trustore with AAF issuer. And because certs for SDC
components have CN set to "sdc" - environment json must have the domain
names correctly too...it will not work with plain IPs.

The changes have been tested from CSIT perspective so if something is
missing here or wrong then it is due to the fact that I was focusing on
bringing https support to the same level as are http tests and there is
also the fact that I do not know SDC component at all.

The changes are also done in a manner of previous ones - hacked on top of
the current codebase, which is in dire need of a rewrite:

- duplicated trustores and other artifacts
- duplicated scripts and/or similar script with small differences
- ui tests use old ubuntu image vs api tests on alpine
- chef codebase is very messy and I see no benefit in the current usage

Issue-ID: SDC-2564

Signed-off-by: Petr Ospalý <p.ospaly@partner.samsung.com>
Change-Id: I32e0fb7723ab8489eb09372d410c6f34aaf7cfc8

5 years agoAdd substitution mapping to sanity test 27/95527/2
commit | commitdiff | tree
andre.schmid [Wed, 11 Sep 2019 19:20:05 +0000 (20:20 +0100)]
Add substitution mapping to sanity test

Change-Id: Ib970a5929f12144faa2e655f5f898c645feb17b7
Issue-ID: SDC-2282
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agoSonar fix NullPointerException 04/95304/5
commit | commitdiff | tree
Arindam Mondal [Tue, 10 Sep 2019 06:02:53 +0000 (15:02 +0900)]
Sonar fix NullPointerException

Issue-ID: SDC-2542
Change-Id: I08a93932d2776c40a982bb802aeac994c1f35841
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agoFix for closing sdc splashscreen. 73/96273/2
commit | commitdiff | tree
aribeiro [Thu, 26 Sep 2019 10:43:21 +0000 (11:43 +0100)]
Fix for closing sdc splashscreen.

After loading, the SDC splashscreen will now disappear after a total of 4 seconds.

Issue-ID: SDC-2258
Change-Id: I16629b2cf90f6cca0469ceb506128dabfc1ea3e1
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
5 years agoUpdate release notes 15/96515/1
commit | commitdiff | tree
Ofir Sonsino [Wed, 2 Oct 2019 15:27:04 +0000 (18:27 +0300)]
Update release notes

Change-Id: I4ea66e1bef928bb4d43d23e063d9af1c44aa1e8d
Issue-ID: SDC-2569
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agonpm registry fix 94/95894/1
commit | commitdiff | tree
Ofir Sonsino [Wed, 18 Sep 2019 07:32:39 +0000 (10:32 +0300)]
npm registry fix

Change-Id: I6e4b866c118b0c11518a0aff6fce59956b123013
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoBump SDC version 1.5.2 15/95315/1
commit | commitdiff | tree
Ofir Sonsino [Tue, 10 Sep 2019 07:52:13 +0000 (10:52 +0300)]
Bump SDC version 1.5.2

Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoUpdated the sdc cert for ONAP namespace in the kubernetes. 40/95240/2
commit | commitdiff | tree
k.kedron [Mon, 9 Sep 2019 14:40:21 +0000 (16:40 +0200)]
Updated the sdc cert for ONAP namespace in the kubernetes.

Issue-ID: SDC-2539
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I4dba563d5dd8b041a2a61076a9ccbabcc4d22316

5 years agofix a nested node type issue 64/94064/11
commit | commitdiff | tree
Liang Ding [Thu, 22 Aug 2019 04:58:54 +0000 (21:58 -0700)]
fix a nested node type issue

the newly added node type is considered as nested
when substitution_mapping is enabled in TOSCA yaml file

Change-Id: Ibdee29d7a553c7b1ce085cbe971ceace6c4488f5
Issue-ID: SDC-2282
Signed-off-by: Liang Ding <liang.ding@intel.com>
5 years agoRevert "Basic authorization for unsecured endpoint" 24/95124/1
commit | commitdiff | tree
andre.schmid [Fri, 6 Sep 2019 09:45:03 +0000 (09:45 +0000)]
Revert "Basic authorization for unsecured endpoint"

This reverts commit 34e04405

Change-Id: I6e27ce2d04b50417c3b0c9e5da217cbc57f8d277
Issue-ID: SDC-2556
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agoopenecomp-be code coverage increase 11/94911/2
commit | commitdiff | tree
Piotr Darosz [Wed, 4 Sep 2019 10:27:53 +0000 (12:27 +0200)]
openecomp-be code coverage increase

Add tests for classes in
sdc.vendorsoftwareproduct.types.schemagenerator package

Change-Id: Iabd22f88a5106c881ee687a4b57a62f59c0bc10e
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agocatalog-be code coverage increase 20/94920/5
commit | commitdiff | tree
Piotr Darosz [Wed, 4 Sep 2019 12:19:27 +0000 (14:19 +0200)]
catalog-be code coverage increase

Add tests for DistributionCatalogServlet class

Change-Id: I3da0460f09c803a0ec5a26bd2c7f70f36c6998a1
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - catalog-model 26/94926/2
commit | commitdiff | tree
Tomasz Golabek [Wed, 4 Sep 2019 12:29:46 +0000 (14:29 +0200)]
unit tests - catalog-model

Coverage increasing

Change-Id: Idb7902578aca65eaee1a63871e9b84e3c4767233
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - NetworkPackageHealer 16/94916/3
commit | commitdiff | tree
Tomasz Golabek [Wed, 4 Sep 2019 10:56:12 +0000 (12:56 +0200)]
unit tests - NetworkPackageHealer

Additional junit tests using mockito

Change-Id: I1a48d0dd15a3319dc096816ea36346f4b13322fc
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agocommon code coverage increase 05/94905/2
commit | commitdiff | tree
Piotr Darosz [Wed, 4 Sep 2019 08:05:34 +0000 (10:05 +0200)]
common code coverage increase

Add tests for classes in sdc.tosca.datatypes.model package

Change-Id: Ifc277512d833b2501f0e594b9062d39c26565055
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoopenecomp-be code coverage increase 84/94884/2
commit | commitdiff | tree
Piotr Darosz [Wed, 4 Sep 2019 07:11:35 +0000 (09:11 +0200)]
openecomp-be code coverage increase

Add tests for classes in openecomp.core.model.types package

Change-Id: I1c8044b2c8d422468dba610b2012e1cb34a75835
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - openecomp-sdc 42/94842/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 3 Sep 2019 14:08:37 +0000 (16:08 +0200)]
unit tests - openecomp-sdc

Additional junit tests mostly for pojos

Change-Id: I851d7df94b1e1c225d087b8881c3c1cd30867efb
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoImplement PNFD Model driven conversion 47/93947/7
commit | commitdiff | tree
andre.schmid [Tue, 3 Sep 2019 13:45:28 +0000 (13:45 +0000)]
Implement PNFD Model driven conversion

Change-Id: I7427e82353cac17817457294d78953f867d2d6e8
Issue-ID: SDC-2509
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agoOnboard Package Handling 22/94222/10
commit | commitdiff | tree
aribeiro [Tue, 3 Sep 2019 08:37:55 +0000 (08:37 +0000)]
Onboard Package Handling

Retain the original onboarded package when it comes in zip/csar format.

Issue-ID: SDC-2510
Change-Id: Ie293db25eca8872be26ffc8475b25ccace1aab6f
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
5 years agocatalog-be code coverage increase 35/94835/2
commit | commitdiff | tree
Piotr Darosz [Tue, 3 Sep 2019 12:27:06 +0000 (14:27 +0200)]
catalog-be code coverage increase

Increase code coverage in ResourcesServlet class

Change-Id: I633da1a41d7266dd1b218814bf5d52de73c8d264
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - openecomp-sdc 27/94827/4
commit | commitdiff | tree
Tomasz Golabek [Tue, 3 Sep 2019 11:08:37 +0000 (13:08 +0200)]
unit tests - openecomp-sdc

Additional junit tests for action, type etc.

Change-Id: I93b088035fca13db4fdcf9da0d58e7f01ee4f976
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - common-app-api 21/94821/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 3 Sep 2019 10:13:54 +0000 (12:13 +0200)]
unit tests - common-app-api

Additional junit tests for common

Change-Id: I79dd83e4de767652c019db292bdf7a23d9dca8a4
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoopenecomp-utilities-lib code coverage increase 09/94809/2
commit | commitdiff | tree
Piotr Darosz [Tue, 3 Sep 2019 08:28:11 +0000 (10:28 +0200)]
openecomp-utilities-lib code coverage increase

Add tests for RequirementDefinitionDeserializer class

Change-Id: I038f73fad4daa3eab931c566668359db9b5f6dc6
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - catalog-model 04/94804/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 3 Sep 2019 08:02:44 +0000 (10:02 +0200)]
unit tests - catalog-model

Additional junit tests for be-model

Change-Id: I7364cd33411d7f6eb69f9a02b2aea889c594ea7b
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoGeneral Sonar fixes 85/94785/2
commit | commitdiff | tree
Arindam Mondal [Tue, 3 Sep 2019 05:23:35 +0000 (14:23 +0900)]
General Sonar fixes

+)Organize imports
++) log formatter

Issue-ID: SDC-2542
Change-Id: Ibb4b568b19ee40a68f783bfa820bd7c73aae5c1f
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agoFixed ready-probe file 43/94743/3
commit | commitdiff | tree
k.kedron [Mon, 2 Sep 2019 10:45:35 +0000 (12:45 +0200)]
Fixed ready-probe file

Fixed ready-probe script url endpoint.

Issue-ID: SDC-2548
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Ibfc2d9199bd01678766810540df594d70812bd9e

5 years agocatalog-be code coverage increase 86/94786/2
commit | commitdiff | tree
Piotr Darosz [Mon, 2 Sep 2019 13:13:42 +0000 (15:13 +0200)]
catalog-be code coverage increase

Increase test code coverage in ElementServletTest

Change-Id: I65d08d901f30c218e60b5630132d9eb8b4a90a9a
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoopenecomp-be code coverage increase 00/94800/2
commit | commitdiff | tree
Piotr Darosz [Tue, 3 Sep 2019 07:14:35 +0000 (09:14 +0200)]
openecomp-be code coverage increase

Add tests for classes in generator.datatypes.tosca package

Change-Id: Ic21b4e05d15e881016fa5f25113625bc441924c9
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoopenecomp-be code coverage increase 95/94795/1
commit | commitdiff | tree
Piotr Darosz [Tue, 3 Sep 2019 06:40:37 +0000 (08:40 +0200)]
openecomp-be code coverage increase

Add tests for classes in vendorsoftwareproduct.types.composition package

Change-Id: I2b05536a4fd80021bfedd2e7ff0f1747f6227935
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - catalog-model 62/94762/2
commit | commitdiff | tree
Tomasz Golabek [Mon, 2 Sep 2019 14:05:21 +0000 (16:05 +0200)]
unit tests - catalog-model

Additional junit tests for ToscaListValueConverter

Change-Id: I41e8b501129ceb0640e54e4173b3cdf13983ccd8
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoBasic authorization for unsecured endpoint 87/94687/3
commit | commitdiff | tree
m.kowalski3 [Fri, 30 Aug 2019 14:02:56 +0000 (16:02 +0200)]
Basic authorization for unsecured endpoint

Issue-ID: OJSI-90
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I3423d316e4853cfd5fa4aee50ad6506937bd6381

5 years agocatalog-be code coverage increase 38/94738/3
commit | commitdiff | tree
Piotr Darosz [Mon, 2 Sep 2019 07:42:33 +0000 (09:42 +0200)]
catalog-be code coverage increase

Added tests for ArtifactExternalServlet

Change-Id: Ic20e172e910f9c5e18d3f43f78a10a36c588f16d
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agounit tests - openecomp-be 37/94737/2
commit | commitdiff | tree
Tomasz Golabek [Mon, 2 Sep 2019 07:06:00 +0000 (09:06 +0200)]
unit tests - openecomp-be

Additional junit tests for zusammen models

Change-Id: I4593d5c5dfd9619f36c69096462ed5de08b189f0
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agotesting common-app-api utils YamlToObjectConverter 85/94685/3
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 30 Aug 2019 13:50:41 +0000 (15:50 +0200)]
testing common-app-api utils YamlToObjectConverter

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I10fc2d7a35150e97b90a1c69c4faac949e439db3

5 years agounit tests - openecomp-be 27/94727/2
commit | commitdiff | tree
Piotr Darosz [Sun, 1 Sep 2019 13:05:38 +0000 (15:05 +0200)]
unit tests - openecomp-be

Additional junit tests for dao-types

Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
Change-Id: I195610e66628d5d8546846592c98c726ba81824d

5 years agoGeneral sonar fixes 89/94489/4
commit | commitdiff | tree
Arindam Mondal [Thu, 29 Aug 2019 01:31:29 +0000 (10:31 +0900)]
General sonar fixes

+) Removed empty method
++)Removed unused import

Issue-ID: SDC-2542
Change-Id: I9081e7c5f2b9329101c231ae18b4075e33219535
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agoFix artifacts references in main TOSCA descriptor 94/94294/3
commit | commitdiff | tree
andre.schmid [Thu, 29 Aug 2019 16:31:53 +0000 (16:31 +0000)]
Fix artifacts references in main TOSCA descriptor

During package conversion, artifacts can have their path changed.
References for those artifacts inside the main TOSCA descriptor must be
updated accordingly.

Change-Id: Idcffb0724c20875ff1decebfec7c47605bfe20dc
Issue-ID: SDC-2540
Signed-off-by: andre.schmid <andre.schmid@est.tech>
5 years agotesting common-app-api utils ValidationUtil 75/94675/2
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 30 Aug 2019 09:43:39 +0000 (11:43 +0200)]
testing common-app-api utils ValidationUtil

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I49339dd340b2262f81d750ae7fe6165f3fabca14

5 years agounit tests - openecomp-be 64/94664/2
commit | commitdiff | tree
Tomasz Golabek [Fri, 30 Aug 2019 08:52:41 +0000 (10:52 +0200)]
unit tests - openecomp-be

Additional junit tests for vendor-license-api-types

Change-Id: I343d04f001a92d47aa411e6bda498fa772040e5b
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - openecomp-be 61/94661/2
commit | commitdiff | tree
Tomasz Golabek [Fri, 30 Aug 2019 07:26:10 +0000 (09:26 +0200)]
unit tests - openecomp-be

Additional junit tests for vendor-software-product-rest-types

Change-Id: I757fe0eed085b6ce880dda143ad1fceac220aafe
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoUpdate ready-probe file 58/94658/2
commit | commitdiff | tree
k.kedron [Thu, 29 Aug 2019 15:05:58 +0000 (17:05 +0200)]
Update ready-probe file

Update ready-probe file to support the https mode.

Issue-ID: SDC-2548
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I78328d7575d202d1d241785e07fb57573ffe2739

5 years agoUse https request in the dcoker_run 32/94432/2
commit | commitdiff | tree
k.kedron [Wed, 28 Aug 2019 13:01:51 +0000 (15:01 +0200)]
Use https request in the dcoker_run

-Update the docker_run script to use https connection
for healthCheck request.
-Removing the onap/sdc-simulator each time when docker is running up
to prevent error with restarting host
-Checkstyle for script

Issue-ID: SDC-2546
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I66fbb67bbcd3e200c61a5ec67f15f5f5dad5bc8c

5 years agoFully HTTPS support in the catalog-be 56/94356/3
commit | commitdiff | tree
k.kedron [Tue, 27 Aug 2019 16:10:09 +0000 (18:10 +0200)]
Fully HTTPS support in the catalog-be

Fully HTTPS support:
-Updated jvm configuration to support call to
the SDC components using HTTPS.
-Checkstyle in the recipes
-Add support for disableHttp flag in the chef script
-Add support for change the http to https in the python script
-Fixed the --schema param in the importONAPNormativeALL and
upgradeONAPNormative python scripts
-Checkstyle in the importX python script
-Disabled pycurl.SSL_VERIFYHOST to fix communication with the be component

Issue-ID: SDC-2501
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I588ba21638083694932a1af272f3bcbaa98268a7

5 years agounit tests - openecomp-be 72/94572/2
commit | commitdiff | tree
Tomasz Golabek [Thu, 29 Aug 2019 11:32:30 +0000 (13:32 +0200)]
unit tests - openecomp-be

Additional junit tests for item-rest-services and unique-type-rest-services

Change-Id: I330954ad4eb432c126c7f163f9fdea30d3173cd9
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agorefactoring tests in Common-App-Api util 00/94500/3
commit | commitdiff | tree
Bartosz Gardziejewski [Wed, 28 Aug 2019 12:24:36 +0000 (14:24 +0200)]
refactoring tests in Common-App-Api util

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Id2c3d3ade4ec176eaee6302c46ddc4009eb40931

5 years agounit tests - openecomp-be 81/94581/2
commit | commitdiff | tree
Tomasz Golabek [Thu, 29 Aug 2019 12:40:28 +0000 (14:40 +0200)]
unit tests - openecomp-be

Additional junit tests for conflict-rest-types and vendor-license-rest-types

Change-Id: I3e58d8a85f40e0f3a2e64c2b3195c97bb71a8fbd
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agocatalog-be code coverage increase 94/94494/3
commit | commitdiff | tree
Piotr Darosz [Thu, 29 Aug 2019 06:53:10 +0000 (08:53 +0200)]
catalog-be code coverage increase

Increase test code coverage in catalog-be ServiceBusinessLogic - part 1

Change-Id: I1ef29b46f41bfe7d41219ddbe5dbb0dd5a6649ad
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
5 years agoBRG Category 06/94406/1
commit | commitdiff | tree
Ofir Sonsino [Wed, 28 Aug 2019 07:12:58 +0000 (10:12 +0300)]
BRG Category

Change-Id: I9ac88bae14227fb687d0520da349b2c72c7b1ead
Issue-ID: SDC-2535
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoremove duplicated dependencies 37/94337/2
commit | commitdiff | tree
vasraz [Tue, 27 Aug 2019 10:28:15 +0000 (10:28 +0000)]
remove duplicated dependencies

Change-Id: I60962892f035d81943567a0b3d7819ef3cab52f7
Issue-ID: SDC-2388
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
5 years agoincreasing test code coverage in catalog be ArtifactBusinessLogic 65/94265/5
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 23 Aug 2019 12:47:36 +0000 (14:47 +0200)]
increasing test code coverage in catalog be ArtifactBusinessLogic

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I1283a3901a9056589cfffea381391d7307d26425

5 years agoGeneral Sonar fixes 19/94319/6
commit | commitdiff | tree
Arindam Mondal [Tue, 27 Aug 2019 04:47:44 +0000 (13:47 +0900)]
General Sonar fixes

+) Replace System.out with logger
++) Use try-with-resources to close the resource
+++) Format to delete tab charachter
++++) flip equals to avoid potential NPE

Issue-ID: SDC-2542
Change-Id: If57f36072ec67e9622d4fe51bce8336094dc10c8
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agoFixed swagger dependency 23/94323/3
commit | commitdiff | tree
k.kedron [Tue, 27 Aug 2019 06:00:11 +0000 (08:00 +0200)]
Fixed swagger dependency

Fixed ClassNotFoundException after the jetty server start.

Issue-ID: SDC-2543
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Ice9d58ceb74e5d261f9296c804c13881db9f3b94

5 years agoremove duplicated dependencies from catalog-be/pom.xml 31/94231/2
commit | commitdiff | tree
vasraz [Mon, 26 Aug 2019 13:39:26 +0000 (13:39 +0000)]
remove duplicated dependencies from catalog-be/pom.xml

Change-Id: I8a5cecd6e5d8a1db8229431ed4ac32d005a52e0b
Issue-ID: SDC-2388
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
5 years agoFully HTTPS support in the catalog-fe 27/94227/2
commit | commitdiff | tree
k.kedron [Fri, 23 Aug 2019 14:46:49 +0000 (16:46 +0200)]
Fully HTTPS support in the catalog-fe

Fully HTTPS support:
-Updated jvm configuration to support call to
the SDC components using HTTPS.
-Checkstyle in the recipes
-Added buildRestClient method to create the CloseableHttpClient
supporting the SSL connection
-Sonar fixes in the PluginStatusBL class

Issue-ID: SDC-2516
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I35b9e22026898d2cc67a4b2d86d9d508a33fcb59

5 years agoUpgrade swagger 70/94170/7
commit | commitdiff | tree
Arindam Mondal [Fri, 23 Aug 2019 03:13:33 +0000 (12:13 +0900)]
Upgrade swagger

Issue-ID: SDC-2154
Change-Id: I95f6326a088f9a29c4ccb3b7a741d57ecf27ae7a
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agounit tests - catalog-be 67/94267/2
commit | commitdiff | tree
Tomasz Golabek [Mon, 26 Aug 2019 10:16:32 +0000 (12:16 +0200)]
unit tests - catalog-be

Additional junit tests

Change-Id: Icc7dd508204094643c4796eaef01febd112a7869
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoFixed sonar issues in ConfigurationRepository 65/90465/5
commit | commitdiff | tree
Piotr Borelowski [Tue, 25 Jun 2019 15:17:41 +0000 (17:17 +0200)]
Fixed sonar issues in ConfigurationRepository

Fixing sonar issues in onap-configuration-management-core project

Issue-ID: SDC-2390
Signed-off-by: Piotr Borelowski <p.borelowski@partner.samsung.com>
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I2814b189eb53f53ab94295ff6bba76d118616800

5 years agoFixed pom spring version configuration 92/94192/3
commit | commitdiff | tree
k.kedron [Fri, 23 Aug 2019 09:16:35 +0000 (11:16 +0200)]
Fixed pom spring version configuration

Fixed pom configuration in the application-config-rest-service

Issue-ID: SDC-2326
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I1ea39c42dcb0d257ee3c47e2920550dda07010ce

5 years agoAdd unit test for DuplicateComputeInComponentErrorBuilder and refactor ComponentDepen... 41/93041/3
commit | commitdiff | tree
m.kowalski3 [Thu, 8 Aug 2019 10:07:39 +0000 (12:07 +0200)]
Add unit test for DuplicateComputeInComponentErrorBuilder and refactor ComponentDependencyModelErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: Icb6cf51f7777a8a9d3b237ecd98579edc11f9ebb

5 years agounit tests - resource business logic 14/94214/2
commit | commitdiff | tree
Tomasz Golabek [Fri, 23 Aug 2019 13:03:24 +0000 (15:03 +0200)]
unit tests - resource business logic

Additional junit tests

Change-Id: I2a6e4f67f725343ac789361c2de45354ae817fb9
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - catalog-model 21/94221/2
commit | commitdiff | tree
Tomasz Golabek [Fri, 23 Aug 2019 14:06:13 +0000 (16:06 +0200)]
unit tests - catalog-model

Additional junit tests

Change-Id: I82f88ec4cc1fb18314cfb33dd9aafa58688318e0
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoFix in RestConf - Policy model id 67/94067/2
commit | commitdiff | tree
Vidyashree Rama [Thu, 22 Aug 2019 06:34:48 +0000 (12:04 +0530)]
Fix in RestConf - Policy model id

Bug fix in policy model id of restconf collector

Change-Id: Ifd3a4298ee7d0a0ce00602f777878a202fe89eaa
Issue-ID: SDC-2101
Signed-off-by: Vidyashree Rama <vidyashree.rama@huawei.com>
5 years agoincreasing test coverage in common-app-api common catalog 96/94196/6
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 23 Aug 2019 10:42:11 +0000 (12:42 +0200)]
increasing test coverage in common-app-api common catalog

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Ida905fc6f0f28d75522c865d33abf636c1fb7fdb

5 years agoincreasing test coverage in common-app-api exception catalog 91/94191/4
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 23 Aug 2019 09:12:50 +0000 (11:12 +0200)]
increasing test coverage in common-app-api exception catalog

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I0dd6bc60c88acbcf1b3755627a7b10b874a549ba

5 years agounit tests - catalog-be 89/94189/5
commit | commitdiff | tree
Tomasz Golabek [Fri, 23 Aug 2019 08:48:28 +0000 (10:48 +0200)]
unit tests - catalog-be

Additional junit tests

Change-Id: Id83ab89115bd7bec471f42d3b96a2054ff4ead53
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoincreasing test coverage in common-app-api fe catalog 87/94187/4
commit | commitdiff | tree
Bartosz Gardziejewski [Fri, 23 Aug 2019 08:22:21 +0000 (10:22 +0200)]
increasing test coverage in common-app-api fe catalog

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Ib4ca69ef881ea5db4f1d186b00f9a1cfbc603259

5 years agoFully HTTPS support in the webseal-simulator 38/94038/2
commit | commitdiff | tree
k.kedron [Wed, 21 Aug 2019 11:31:02 +0000 (13:31 +0200)]
Fully HTTPS support in the webseal-simulator

Updated the HTTPS configuration:
-Added truststore certificate.
-Updated configuration to use JETTY_BASE env value
instead hardcoded variable
-Updated jvm configuration to support call to
the SDC components using HTTPS.
-Added support for the disableHttp flag.

Issue-ID: SDC-2517
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Ib7f4c7a6762c56c8031ba6734f02d388aaefd722

5 years agoincreasing test coverage in common-app-api 20/94120/4
commit | commitdiff | tree
Bartosz Gardziejewski [Thu, 22 Aug 2019 13:15:49 +0000 (15:15 +0200)]
increasing test coverage in common-app-api

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I7ae64864734e7246681ca6ef6d6bb71b3d3df158

5 years agounit tests - asdctool 10/94110/2
commit | commitdiff | tree
Tomasz Golabek [Thu, 22 Aug 2019 13:03:50 +0000 (15:03 +0200)]
unit tests - asdctool

Additional junit tests

Change-Id: I889772efaccbc6f1555d50cd47a02d868348d310
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoincreasing code coverage in catalog fe 02/94102/4
commit | commitdiff | tree
Bartosz Gardziejewski [Thu, 22 Aug 2019 11:29:04 +0000 (13:29 +0200)]
increasing code coverage in catalog fe

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: Ica194c87def27163e20b2802100d9f296586a6ed

5 years agounit tests - catalog-be 01/94101/3
commit | commitdiff | tree
Tomasz Golabek [Thu, 22 Aug 2019 11:05:23 +0000 (13:05 +0200)]
unit tests - catalog-be

Additional junit tests

Change-Id: Ief7f445521f7821e47715a44c423fd11a17568e1
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - catalog-model 87/94087/2
commit | commitdiff | tree
Tomasz Golabek [Thu, 22 Aug 2019 09:21:04 +0000 (11:21 +0200)]
unit tests - catalog-model

Additional junit tests

Change-Id: I9952933895ba22114fb0bf19a51e54f1a232c8f3
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - sdc-healthcheck-manager 29/94029/2
commit | commitdiff | tree
Tomasz Golabek [Wed, 21 Aug 2019 08:40:45 +0000 (10:40 +0200)]
unit tests - sdc-healthcheck-manager

Additional junit tests

Change-Id: I6562e5085f7bfd692db129bf1706f3f569ebd793
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoUnit tests - openecomp-sdc-validation-manager 55/93955/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 20 Aug 2019 12:06:08 +0000 (14:06 +0200)]
Unit tests - openecomp-sdc-validation-manager

Tests for org.openecomp.sdc.validation

Change-Id: If0acdb2f453b5cd60d0ec49870f1467cdd212492
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agounit tests - sdc-common-rest 19/94019/2
commit | commitdiff | tree
Tomasz Golabek [Wed, 21 Aug 2019 07:18:38 +0000 (09:18 +0200)]
unit tests - sdc-common-rest

Additional junit tests

Change-Id: Ieeb6f02e1d5abf131882c530a0ba3a395d56c6cd
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agorelease notes for El Alto Early Drop 43/94043/2
commit | commitdiff | tree
Ofir Sonsino [Wed, 21 Aug 2019 13:04:00 +0000 (16:04 +0300)]
release notes for El Alto Early Drop

Change-Id: Ib875bee201f1be0bca0d38e2d906f448e562f990
Issue-ID: SDC-2492
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoincreasing test coverage in openecomp-be api 69/93969/6
commit | commitdiff | tree
Bartosz Gardziejewski [Tue, 20 Aug 2019 13:53:19 +0000 (15:53 +0200)]
increasing test coverage in openecomp-be api

Issue-ID: SDC-2326
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I93cc5183190fcbada2349b18f14fbec9c28f1ae5

5 years agoUnit tests - openecomp-sdc-vsp-manager 42/93942/3
commit | commitdiff | tree
Tomasz Golabek [Tue, 20 Aug 2019 09:39:23 +0000 (11:39 +0200)]
Unit tests - openecomp-sdc-vsp-manager

Tests for org.openecomp.sdc.vendorsoftwareproduct

Change-Id: I737b8ca71219c3e241f902a34419c685435e467c
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoUnit tests - togglz-rest-types 65/93965/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 20 Aug 2019 13:32:53 +0000 (15:32 +0200)]
Unit tests - togglz-rest-types

Tests for org.openecomp.sdcrests.togglz

Change-Id: Ic507eee3e77fbbe727b0deeb3912103d0c7737db
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoRemoved dummy subproject 66/93966/2
commit | commitdiff | tree
Tomasz Golabek [Tue, 20 Aug 2019 13:36:12 +0000 (15:36 +0200)]
Removed dummy subproject

Change-Id: Idb5d33229c76bec9768c8c6c1d73faa96fff2225
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
5 years agoHTTPS calls for webseal-simulator 57/93757/2
commit | commitdiff | tree
r.bogacki [Mon, 19 Aug 2019 08:43:05 +0000 (10:43 +0200)]
HTTPS calls for webseal-simulator

Implemented HTTPS calls into webseal-simulator
-Added p12 keystore certificate.
-Updated application configuration.

Issue-ID: SDC-2517
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ieb5f9ec5a0e409eb4bad36f708b2eec424ecf70b

5 years agoHTTPS calls for catalog-fe 55/93755/4
commit | commitdiff | tree
r.bogacki [Mon, 19 Aug 2019 08:16:23 +0000 (10:16 +0200)]
HTTPS calls for catalog-fe

Implemented HTTPS calls into catalog-fe
-Added p12 keystore certificate.
-Updated application configuration.
-Added trust-store.

Issue-ID: SDC-2516
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I6c36598dd7df8be85e99619ab7004ceed905f6e1

5 years agoHTTPS calls for catalog-be 46/93746/6
commit | commitdiff | tree
r.bogacki [Wed, 14 Aug 2019 07:04:26 +0000 (09:04 +0200)]
HTTPS calls for catalog-be

Implement HTTPS calls into catalog-be
-Added p12 keystore certificate.
-Updated application configuration.
-Added trust-store.

Issue-ID: SDC-2501
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iecdff1010f763489395e9d67d3a0cecd22d09c88

5 years agofix INFO.yaml 36/93736/2
commit | commitdiff | tree
Ofir Sonsino [Sun, 18 Aug 2019 11:19:24 +0000 (14:19 +0300)]
fix INFO.yaml

Change-Id: Iabedb5768b5ab572dd627426ecedff62ab3a1244
Issue-ID: SDC-2448
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
5 years agoUpdate PM Mapper Data Type 30/93530/2
commit | commitdiff | tree
dfarrelly [Wed, 14 Aug 2019 16:06:20 +0000 (16:06 +0000)]
Update PM Mapper Data Type

*Update PM Mapper Data Type to include full filter schema

Issue-ID: DCAEGEN2-1605
Change-Id: I5aea43ddef798d14b445ee0ab4275370db08e011
Signed-off-by: dfarrelly <david.farrelly@est.tech>
5 years agoHandle 'get_input' syntax for layer_protocols in PnfExtCp type 29/91729/6
commit | commitdiff | tree
vasraz [Tue, 6 Aug 2019 09:44:08 +0000 (09:44 +0000)]
Handle 'get_input' syntax for layer_protocols in PnfExtCp type

Change-Id: I52f91e47dbda20c8c0701ee25f2eec5a83815112
Issue-ID: SDC-2427
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
5 years agoUpdating documentation on onboarding packages 82/92582/2
commit | commitdiff | tree
bilal.iqbal [Wed, 14 Aug 2019 15:15:45 +0000 (15:15 +0000)]
Updating documentation on onboarding packages

Change-Id: Id167f34e918e15856d7c86b9f7c767e1e3f4a0bb
Issue-ID: DOC-521
Signed-off-by: bilal.iqbal <bilal.iqbal@est.tech>
5 years agoHTTPS calls for sdc-onboarding 02/92802/6
commit | commitdiff | tree
r.bogacki [Tue, 6 Aug 2019 13:45:17 +0000 (15:45 +0200)]
HTTPS calls for sdc-onboarding

Implement HTTPS calls into sdc-onboarding
-Added p12 keystore certificate.
-Updated application configuration.
-Added trust-store.

Issue-ID: SDC-2498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: Ia96c42cddee5fd94014963c9d2f584b098693a9a

5 years agoAdd unit tests for NicInternalNetworkErrorBuilder 92/92892/4
commit | commitdiff | tree
m.kowalski3 [Wed, 7 Aug 2019 13:25:14 +0000 (15:25 +0200)]
Add unit tests for NicInternalNetworkErrorBuilder

Issue-ID: SDC-2327
Signed-off-by: Marcin Kowalski <m.kowalski3@partner.samsung.com>
Change-Id: I8a6127218edf895b8b43d973348cc47794e212c1

5 years agoFix PM Mapper policy ID 14/92914/2
commit | commitdiff | tree
dfarrelly [Wed, 7 Aug 2019 15:31:17 +0000 (15:31 +0000)]
Fix PM Mapper policy ID

*Change policy ID to match onap.policies.monitoring naming convention

Issue-ID: DCAEGEN2-1605
Change-Id: If5e61692c19d344714704bf411631dec01b3226a
Signed-off-by: dfarrelly <david.farrelly@est.tech>
5 years agoAdditional unit tests 06/93006/1
commit | commitdiff | tree
Tomasz Golabek [Thu, 8 Aug 2019 06:55:52 +0000 (08:55 +0200)]
Additional unit tests

Tests for ItemVersionConflictConverter

Change-Id: I5bf7ac9322e44d7021f87c9853ae250024172f0c
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
next
SDC Parent Project Catalog FE and BE