leventecsanyi [Fri, 8 Sep 2023 13:52:24 +0000 (15:52 +0200)]
Set lock state and reason upon request
- added new LockReasonCategories and improved SyncUtils.isReadyForRetry
- refactored logic aroudn retry times
- refactored unit tests
Issue-ID: CPS-1860
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I4382d6ad1fa0a7d9dacb8c8281b0458a5afc0375
Toine Siebelink [Mon, 18 Sep 2023 14:54:22 +0000 (14:54 +0000)]
Merge "Migrate CPS to Spring-boot 3.0"
mpriyank [Wed, 13 Sep 2023 10:42:05 +0000 (11:42 +0100)]
Docs for the distributed datastructures in cps and ncmp
- listed the distributed datastructures that we use in cps and ncmp.
- summary of the usage in the product.
Issue-ID: CPS-1867
Change-Id: I6535f7cfc6ef68731d22c81500ba4b876e7db0f4
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
egernug [Wed, 26 Jul 2023 09:36:15 +0000 (10:36 +0100)]
Migrate CPS to Spring-boot 3.0
Issue-ID: CPS-1789
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I932fca8a50cedf2ae0604401c5e2b27896e4d449
Luke Gleeson [Tue, 12 Sep 2023 09:42:32 +0000 (09:42 +0000)]
Merge "Dmi plugin watchdog cheking aliveness"
halil.cakal [Mon, 11 Sep 2023 11:34:37 +0000 (12:34 +0100)]
Verify kafka headers by header name
- Change subscription notification flow
- Change data operations flow
Issue-ID: CPS-1613
Change-Id: I5c8aeb26c925071d810975dd6686309b7ad6b76f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
halil.cakal [Thu, 31 Aug 2023 10:45:47 +0000 (11:45 +0100)]
Dmi plugin watchdog cheking aliveness
- Add capability of GET request into DmiRestClient
- Add watchdog job to check aliveness of dmi plugins
- DmiPluginStatus enum as UP or DOWN
- Add unit tests for the new function in dmi rest client
- Add unit tests for dmi watchdog
Issue-ID: CPS-1856
Change-Id: Ic38a96f0485a0bfe1b6af5bb2f57f6119d8fa563
Signed-off-by: halil.cakal <halil.cakal@est.tech>
leventecsanyi [Mon, 4 Sep 2023 08:59:23 +0000 (10:59 +0200)]
Modify inventory using moduleSetTag as optional attribute
- added moduletSetTag as an optional field for RestInputCmHandle
Issue-ID: CPS-1803
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I15c9d1eeb4f7db83ca23c50f3ffe9603cd5b14c9
Jessica Wagantall [Thu, 31 Aug 2023 20:40:23 +0000 (13:40 -0700)]
CI: Remove GHA for RTDv3
These actions are getting moved to the .github repo since
they need to run for all repos.
Issue-ID: CIMAN-33
Change-Id: I49560ddbcb128448d6dd29a65a611ba8bf526427
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Priyank Maheshwari [Thu, 31 Aug 2023 16:03:36 +0000 (16:03 +0000)]
Merge "Hazelcast cache config stroring trust level per dmi plugin"
halil.cakal [Mon, 28 Aug 2023 11:25:37 +0000 (12:25 +0100)]
Hazelcast cache config stroring trust level per dmi plugin
- Add Hazelcast cache config to store trust level
per dmi plugin
Issue-ID: CPS-1855
Change-Id: Ibe7f8393008ca7352aacddba99ecd19d6e1eb326
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Jessica Wagantall [Wed, 30 Aug 2023 18:58:31 +0000 (11:58 -0700)]
CI: Add rtdv3 merge GHA workflow call
Issue-ID: CIMAN-33
Change-Id: I2f6d6d089b359c95554b8caa921e3c98d26decf5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
ToineSiebelink [Mon, 28 Aug 2023 14:21:59 +0000 (15:21 +0100)]
Extend model loader to support model-upgrade (part 2)
- add upgrade related methods to common abstract class
- add new (agreed) inventory model
- add InventoryModelLoader
- add more logging for success cases
- simplified constant names considering the context (class name)
Issue-ID: CPS-1804
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I61a5c6d320d340a5c469ce20140f984439ba71a2
Priyank Maheshwari [Fri, 25 Aug 2023 13:54:17 +0000 (13:54 +0000)]
Merge "Extend model loader to support model-upgrade (part 1)"
Priyank Maheshwari [Fri, 25 Aug 2023 09:21:33 +0000 (09:21 +0000)]
Merge "Subscription Forwarding Fix"
ToineSiebelink [Thu, 24 Aug 2023 09:29:34 +0000 (10:29 +0100)]
Extend model loader to support model-upgrade (part 1)
- refactor existign code for easier extension
(no code changes yet, just want to review refactor in this first patch...)
- changed log level of some (error) logging
Issue-ID: CPS-1804
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I234ad6c4057e9447cd39a83b8f48799918ca6b7f
lukegleeson [Thu, 24 Aug 2023 10:36:22 +0000 (11:36 +0100)]
Subscription Forwarding Fix
Issue-ID: CPS-1853
Change-Id: Ic3f2bf28e18d3cadafb57e9dd4bfce8ab06cdb49
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Luke Gleeson [Thu, 24 Aug 2023 08:44:42 +0000 (08:44 +0000)]
Merge "Add verification flow in CSIT: Cm Data Subscription Create"
leventecsanyi [Wed, 23 Aug 2023 13:55:30 +0000 (15:55 +0200)]
Bump pom file versions
Issue-ID: CPS-1851
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I15c1a9577ac940abfaae60689e3082f55455c28c
Priyank Maheshwari [Wed, 23 Aug 2023 13:58:43 +0000 (13:58 +0000)]
Merge "Add 3.3.6 container yaml file to CPS"
leventecsanyi [Wed, 23 Aug 2023 13:40:39 +0000 (15:40 +0200)]
Add 3.3.6 container yaml file to CPS
Issue-ID: CPS-1850
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: I55698ee7177861c195a278aa07638db32c28f265
leventecsanyi [Wed, 23 Aug 2023 13:07:09 +0000 (15:07 +0200)]
Add new release version yaml
Issue-ID: CPS-1849
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Change-Id: Ia604a0e92456f0dc0b4b5241e0b7817cfe950a4c
mpriyank [Tue, 22 Aug 2023 12:17:46 +0000 (13:17 +0100)]
Release notes and openapi yml update
- add to rst file and update the rest api changes
Issue-ID: CPS-1846
Change-Id: I242fc98c025ffe0bf654640ad16dfef2bb0fcbaf
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
ToineSiebelink [Tue, 22 Aug 2023 12:22:12 +0000 (13:22 +0100)]
Document async eror 107, southbound system is busy
Issue-ID: CPS-1844
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Iff8a8b7a88ce8404f541b3dfa73305541bc09056
Sourabh Sourabh [Tue, 22 Aug 2023 11:02:24 +0000 (11:02 +0000)]
Merge "Correct minimum-coverage in pom files"
Priyank Maheshwari [Tue, 22 Aug 2023 11:00:48 +0000 (11:00 +0000)]
Merge "Replace event-id with correlation-id for data read operation cloud event"
Toine Siebelink [Tue, 22 Aug 2023 08:54:54 +0000 (08:54 +0000)]
Merge "Fix: Add file expension for reusable workflow"
Luke Gleeson [Tue, 22 Aug 2023 08:49:37 +0000 (08:49 +0000)]
Merge "Missing test for getDataNodes (ep1)"
Jessica Wagantall [Mon, 21 Aug 2023 20:22:29 +0000 (13:22 -0700)]
Fix: Add file expension for reusable workflow
Issue-ID: CIMAN-33
Change-Id: I3a4960eefb97628ad7e837ca241d36a98540c8b5
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Toine Siebelink [Mon, 21 Aug 2023 16:43:52 +0000 (16:43 +0000)]
Merge "CI: Add test rtdv3 GHA workflow"
ToineSiebelink [Mon, 21 Aug 2023 16:42:57 +0000 (17:42 +0100)]
Correct minimum-coverage in pom files
Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I43fb6e1be7595faddfb5a22932793e8909b036fc
sourabh_sourabh [Mon, 21 Aug 2023 14:52:52 +0000 (15:52 +0100)]
Replace event-id with correlation-id for data read operation cloud event
- Modified data operation event consumer to send correlation-id instead
if event-id while publishing cloud event to client topic.
Issue-ID: CPS-1842
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I30738b90d2ff0d14b5ee0bac680eff834aa968bf
halil.cakal [Wed, 12 Apr 2023 14:19:45 +0000 (15:19 +0100)]
Add verification flow in CSIT: Cm Data Subscription Create
- Add Confluent Kafka Library support for Robot Framework
- Add capability of testing for Kafka flows
- Add CSIT test: Cm Data Notifications Subscription Create
complying with CloudEvents
- Change DMI version to latest for CSIT
- Change DMI service name for Kafka topic extension
- Change kafka listeners in docker compose
Issue-ID: CPS-1613
Change-Id: Ic22cb36fdcee0f5c2bd6ff5c1876747aef563f8b
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Luke Gleeson [Mon, 21 Aug 2023 10:20:09 +0000 (10:20 +0000)]
Merge "Cm Subscription: PENDING logic handling in NCMP"
Jessica Wagantall [Fri, 18 Aug 2023 17:48:11 +0000 (10:48 -0700)]
CI: Add test rtdv3 GHA workflow
This is not a voting workflow, but rather it replicates what
Jenkins does in GHA.
The idea is to have this workflow tested first before we deprecate
the global-jjb rtdv3 job and switch to GHA.
Issue-ID: CIMAN-33
Change-Id: I83742b2fb9d16785a6932c93a2c701f13527307b
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Luke Gleeson [Fri, 18 Aug 2023 13:17:32 +0000 (13:17 +0000)]
Merge "Device heartbeat listener"
Priyank Maheshwari [Fri, 18 Aug 2023 12:55:49 +0000 (12:55 +0000)]
Merge "CPS-Core : Expose a java interface to update schema set"
mpriyank [Wed, 26 Jul 2023 16:33:35 +0000 (17:33 +0100)]
Device heartbeat listener
- Infrastructure code to have the kafka listener and distributed set in
place
- performance tested locally
- testware added
Issue-ID: CPS-1642
Change-Id: I775dbe6e6b520b8777faa08610db439877757572
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Arpit Singh [Fri, 18 Aug 2023 08:26:12 +0000 (13:56 +0530)]
Missing test for getDataNodes (ep1)
- there was no test to check the exceptions thrown by getDataNodes
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: Ifa1df8ebe83fafba833be14559d94261bca93ef0
sourabh_sourabh [Tue, 15 Aug 2023 11:15:33 +0000 (12:15 +0100)]
CPS-Core : Expose a java interface to update schema set
- Exposed an interface to update anchor by schema set name.
- New interface is implemented into RI model.
- New native query is exposed to update id with given schema set name.
- A new integration test is written to test new interface into cps core.
Issue-ID: CPS-1800
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ibf44712e11b53cb6673b04b9e3fd864321c90839
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Fri, 18 Aug 2023 09:56:42 +0000 (10:56 +0100)]
Modify data operation schema to accommodate additional information
- Code is modify to add resourceIdentifier and option to data operation kafka response for status code 100, 101, 102 and 103.
Issue-ID: CPS-1837
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I1f7870d9d373f69de03240700b9d74be46fbfb6c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Luke Gleeson [Fri, 18 Aug 2023 10:52:17 +0000 (10:52 +0000)]
Merge "Bring back coverage to 1.00 for ncmp-rest"
Sourabh Sourabh [Fri, 18 Aug 2023 10:52:15 +0000 (10:52 +0000)]
Merge "Update of top-level data node fails with SQL error"
mpriyank [Fri, 18 Aug 2023 10:34:08 +0000 (11:34 +0100)]
Bring back coverage to 1.00 for ncmp-rest
Issue-ID: CPS-1832
Change-Id: I1704060d0cd56d7c2d2fb7b932a8142d3940120b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Luke Gleeson [Fri, 18 Aug 2023 10:03:31 +0000 (10:03 +0000)]
Merge "Add code coverage for missing branches in pagination API(ep4)"
danielhanrahan [Thu, 17 Aug 2023 14:43:34 +0000 (15:43 +0100)]
Update of top-level data node fails with SQL error
The error is caused by the fetch-descendants code using
ResultSet.getLong which returns a 'long' primitive instead
of a 'Long' object. Thus a parent ID of 'NULL' becomes '0',
which causes an error during update. To preserve the NULL
value, ResultSet.getObject must be used.
Issue-ID: CPS-1841
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ida6837a04954cd3c23f0f2faabd7d0712d8ee19d
rajesh.kumar [Fri, 11 Aug 2023 08:47:49 +0000 (14:17 +0530)]
Add code coverage for missing branches in pagination API(ep4)
Add new test cases for missing branch covereage in Pagiantion API
- Added test cases in cps-rest to cover the scenario of missing
page index and missing page size
Issue-ID:CPS-1835
Change-ID: I73f97f986a817d423f93a8d922dcd9647b1108bc
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
mpriyank [Thu, 10 Aug 2023 22:09:38 +0000 (23:09 +0100)]
Cm Subscription: PENDING logic handling in NCMP
- Remove PENDING state from dmi schema
- Modify ncmp out event mapper to categorize
response per details
- Rename class and method names as well as
in unit tests
- resolved the merge conflicts
Issue-ID: CPS-1830
Change-Id: I5b7f523f546ec9940c246bd286586fdeba2f892e
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Sourabh Sourabh [Thu, 17 Aug 2023 08:37:47 +0000 (08:37 +0000)]
Merge "Fixing sonar issues"
sourabh_sourabh [Wed, 16 Aug 2023 12:16:25 +0000 (13:16 +0100)]
Modify data operation schema to accommodate additional information
- Data operation schema is updated to add resourceIdentifier and
options.
- dmi plugin stub is modified to add both the attributes into kafka
response message.
Issue-ID:CPS-1837
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I624c32d07ccf396f3090766049622f43f5c3f44f
danielhanrahan [Wed, 16 Aug 2023 09:39:48 +0000 (10:39 +0100)]
Fixing sonar issues
Issue-ID: CPS-475
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7623a8301fd4567bf96c605eb26bf6c02b1d3c76
danielhanrahan [Tue, 15 Aug 2023 13:12:30 +0000 (14:12 +0100)]
Update performance test timing for warmup
Incorrect limit on the warmup results in performance pipeline
failing, as the first test that runs must include the time taken
to write initial data.
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I82353fcd5d0904f458808b32f4f01597ba25a688
mpriyank [Thu, 10 Aug 2023 13:27:51 +0000 (14:27 +0100)]
Generic Cloud Event Mapper
- Introduced a generic event cloud mapper to be used all over the
codebase
- Added as a utility so we dont have to inject it as spring bean
- Refactored code and added tests
- Incorporated review comments
Issue-ID: CPS-1827
Change-Id: I8dab914791e01bbf6492ce96e7ba6eaa8f75a6cb
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Tue, 8 Aug 2023 14:27:18 +0000 (15:27 +0100)]
Refactoring Subscription Create LCM use case
- Client to NCMP: CmSubscriptionNcmpInEvent
- NCMP to DMI: CmSubscriptionDmiInEvent
- DMI to NCMP: CmSubscriptionDmiOutEvent
- NCMP to Client: CmSubscriptionNcmpOutEvent
- code package changed from avcsubscription to cmsubscription
- Other classes name as per the events naming above
- Test classes refactored
- NO LOGIC changes incorporated in this patch
Issue-ID: CPS-1831
Change-Id: Id5ad5f799007deaaf6d6fc0f402c130339263d09
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
sourabh_sourabh [Tue, 8 Aug 2023 18:30:41 +0000 (19:30 +0100)]
Modify DmiDataOperationRequest to make it identical as DataOperationRequest
- Modified DmiDataOperationRequest attribute from operationType to
operation.
- Wrapped operation details to parent attribute operationd array.
Issue-ID: CPS-1833
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I79aa943e10e1c32c3252a6eb4375c14496476f8b
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Priyank Maheshwari [Tue, 8 Aug 2023 08:48:40 +0000 (08:48 +0000)]
Merge "Subscription Creation: Fixes for code review after demo"
danielhanrahan [Fri, 4 Aug 2023 13:29:55 +0000 (14:29 +0100)]
Update performance test timings for larger dataset
- Populate 3 anchors with 1000 openroadm devices nodes for
read and query tests (over 250,000 fragments)
- Increase update perf tests to update 100 out of 1000 devices
- Increase delete perf tests to delete 100 out of 300 devices
- Remove bookstore data from performance tests
- Update test timings
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iaa36694be907278e772ae729a85510ea9d004fd1
halil.cakal [Tue, 1 Aug 2023 15:35:58 +0000 (16:35 +0100)]
Subscription Creation: Fixes for code review after demo
- Change missleading subscription details in testware
- Change datastore check to comply with CPS enum
- Remove redundant CloudConstructionException
- Change exception handling in cloud event mappers
to avoid loss of information
- Remove exception handling from scheduler service
as discussed in the meeting
Issue-ID: CPS-1732
Change-Id: I9fee2eafd4db97a0eed80e39219463c904f5a980
Signed-off-by: halil.cakal <halil.cakal@est.tech>
mpriyank [Fri, 4 Aug 2023 11:42:21 +0000 (12:42 +0100)]
Update coverage ratio to 0.99
- in order to stabilize the builds , updating the coverage ratio for
cps-ncmp-rest package to 0.99 from 1.00
- Will bring back to 1.00 once the necessary fixes are in place.
Issue-ID: CPS-1832
Change-Id: If0f106d7c1a44294ed67c83a049f667d9ce13b31
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Tue, 1 Aug 2023 14:36:27 +0000 (15:36 +0100)]
Ability to disable sending auth header
- introduced configurable parameter to disable sending auth header in
the request to dmi-plugin
- default is to include the auth header
- DMI_AUTH_ENABLED flag can be set to true/false to control the
behaviour
- Also added the env variables to the CSITs
- updated release-notes
Issue-ID: CPS-1819
Change-Id: If97c06e33f06e391d2190b7300d73210ed2f4e27
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
halil.cakal [Thu, 3 Aug 2023 15:12:33 +0000 (16:12 +0100)]
Fix: integration test that is for add and delete top level list element
Issue-ID: CPS-1605
Change-Id: Ia6ba73d5e4930bcc547cf24d06c50c681c3a7452
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Luke Gleeson [Thu, 3 Aug 2023 13:13:47 +0000 (13:13 +0000)]
Merge "Support pagination in query across all anchors(ep4)"
rajesh.kumar [Tue, 25 Apr 2023 06:28:35 +0000 (11:58 +0530)]
Support pagination in query across all anchors(ep4)
Add pagination query parameters in query across all anchors API
pagination parameters (pageIndex and pageSize) are optional
default is to query all fragments
each pageSize represents number of records(number of anchors)
TotalRecords is returned in response header to find number of pages.
- If pagination option is provided in request then query number of
anchors equal to pageSize. pageIndex is used for setting offset.
- return number of records(one anchor per record) as per pagesize
and pageSize
Issue-ID: CPS-1605
Change-ID: I73f97f986a817d423f93a8d922dcd9647b2504bc
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
Toine Siebelink [Tue, 1 Aug 2023 12:20:51 +0000 (12:20 +0000)]
Merge "Fix: Make bookstore data consistent"
Rudrangi Anupriya [Mon, 31 Jul 2023 11:20:32 +0000 (16:50 +0530)]
Add 'direct' keyword to descendants option to query direct children (ep1)
-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child.
-added unit tests to test direct keyword
Issue-ID: CPS-1784
Change-Id: Icb7f59fbeebb03703626132d6d5d2cfde0e5ab4d
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
Toine Siebelink [Mon, 31 Jul 2023 10:31:59 +0000 (10:31 +0000)]
Merge "Use constants for magic numbers in perf tests"
ToineSiebelink [Wed, 26 Jul 2023 16:49:02 +0000 (17:49 +0100)]
Increase code coverage in cps-service module
- After last rebase I had to remove 3 unused recent cloud eventd specific exceptions/constructors
- Moved the only used new exception from SPI to the relevant util package
(please NOTE not all exceptions belong in SPI and always question need for new exception
when there is no specific handling, try to use standard or existign CPS exception instead!)
- Increased cps-service module (line) coverage from 95 to 100%
- Added tests for missing exceptions (handling i.e. thrown up)
- Removed incorrect SPI defined OperationNotYetSupportedException
(replaced with standard java exception instead)
- Fixed some legacy issues with existign test classes I modified
(unnecessary setup, conventions etc)
- Increased coverage for DataNodeBuilder
- Added or modified test to include more spi models
- Added tests for Hazelcast Configs
- Added more tests for json object mapper
- Added test and fixed error handling in YangUtils/XmlFileUtils
(it was incorrectly converting a config exception to a data validation exception)
Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I5852ba01bc5b33ae361b8f29daae9868f05baa35
danielhanrahan [Thu, 27 Jul 2023 09:44:38 +0000 (10:44 +0100)]
Use constants for magic numbers in perf tests
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic87bcb1847b97a0e8c59b2e3636e9ccd66f814ae
leventecsanyi [Fri, 28 Jul 2023 15:36:55 +0000 (17:36 +0200)]
Fix pom.xml version
- corrected version number
Issue-ID: CPS-1817
Signed-off-by: Levente Csanyi <levente.csanyi@est.tech>
Change-Id: Id97b3d55e7342619804b8e007238718b56ef3120
Rudrangi Anupriya [Fri, 28 Jul 2023 08:58:54 +0000 (14:28 +0530)]
Add 'direct' keyword to descendants option to query direct children (ep1)
-added 'direct' keyword also to Fetch Descendants Option along with 'all' and 'none' to Query direct child.
-added unit tests to test direct keyword
Issue-ID:CPS-1784
Change-Id: Iab7f59fbeebb03703626132c6d5c2afde0e5ab4d
Signed-off-by: Rudrangi Anupriya <ra00745022@techmahindra.com>
Toine Siebelink [Thu, 27 Jul 2023 15:14:19 +0000 (15:14 +0000)]
Merge "Improve 32K limit tests"
Toine Siebelink [Thu, 27 Jul 2023 15:14:02 +0000 (15:14 +0000)]
Merge "Add write performance tests"
sourabh_sourabh [Tue, 25 Jul 2023 09:58:52 +0000 (10:58 +0100)]
Update RTD (CPS-1515: Spike: Support Multiple CM-Handles for NCMP Get Operation)
- Added information about data operation NCMP endpoint and kafka event
details.
- Re-structured "CPS-Events" and "Modeling" page.
Issue-ID:CPS-1785
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I2b077ccd7ccd6144a8f9f2183d927f922075f532
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
danielhanrahan [Wed, 26 Jul 2023 12:19:50 +0000 (13:19 +0100)]
Improve 32K limit tests
Some operations were previously limited to 32,768 parameters,
such as getDataNodesForMultipleXpaths. After this limit was lifted,
the tests only verified that database exceptions were not thrown.
This commit improves the tests by verifying that the operations
return or delete the expected data.
- Create 33,000 data nodes
- Verify that getDataNodesForMultipleXpaths returns 33,000 nodes
- Verify than deleteDataNodes deletes 33,000 nodes
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I7029ea0cf1d4e95c5ca814ca62c222fc5b9ddc7e
Sourabh Sourabh [Thu, 27 Jul 2023 12:16:35 +0000 (12:16 +0000)]
Merge "Allow getDataNodes to read whole lists(ep 1)"
danielhanrahan [Thu, 18 May 2023 09:18:10 +0000 (10:18 +0100)]
Allow getDataNodes to read whole lists(ep 1)
- getDataNodes can now retrieve list data nodes.
Issue-ID: CPS-1696
Signed-off-by: arpitsingh <as00745003@techmahindra.com>
Change-Id: I320a368d6cb73599d3f7c13fe9b8ab7d0cc69470
Luke Gleeson [Thu, 27 Jul 2023 10:20:54 +0000 (10:20 +0000)]
Merge "Subscription Creation: NCMP to Client CloudEvent transformation"
Toine Siebelink [Thu, 27 Jul 2023 09:56:32 +0000 (09:56 +0000)]
Merge "Performance test of reading non-existing datanodes"
Arpit Singh [Thu, 27 Jul 2023 09:18:30 +0000 (14:48 +0530)]
Fix: Make bookstore data consistent
- Removed list named invoice from all bookstore files
- Added a new parent list as bookstore-address
- Refactored tests
Issue-ID: CPS-1813
Signed-off-by: Arpit Singh <as00745003@techmahindra.com>
Change-Id: I5c7e83e1ee0ad9ac1d94d1906c2361c7a00d49af
danielhanrahan [Wed, 26 Jul 2023 08:50:55 +0000 (09:50 +0100)]
Add write performance tests
- Add perf test for openroadm (linear time)
- Add perf test for bookstore (exponential time!)
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I9c1772a9e9684707f2dbb32b2c361ec248fb1c60
danielhanrahan [Wed, 26 Jul 2023 15:42:39 +0000 (16:42 +0100)]
Performance test of reading non-existing datanodes
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I183129bb5b0a2d620b87e9b36f3113fe8e169798
danielhanrahan [Wed, 26 Jul 2023 15:56:10 +0000 (16:56 +0100)]
Performance test of deleting non-existing datanodes
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifae635f45d8ec1990452ade958253972fde68415
halil.cakal [Thu, 13 Jul 2023 10:28:18 +0000 (11:28 +0100)]
Subscription Creation: NCMP to Client CloudEvent transformation
- Delete legacy avc subscription event and event outcome schemas
- Change subscription response and outcome sample json file contents
- Change ncmp event response code to support avc subscriptions
- Add mapper that maps cloud event to subscription event response
- Add mapper that maps subscription event outcome to cloud event
- Change subscription event response consumer to consume CloudEvents
- Change time out task to support response event instead client id and
name
- Change subscription event response mapper to support Cloud Event
- Change subscription outcome mapper to group subscription responses as
per details and status
- Change subscription status to have fromString functionality
- Change all unit tests to support new functionalities
- Add cps exceptions for cloud event and outcome type
- Add details field in yang model
- Change data node helper to supoort details field
- Consolidate final subscription response codes
- Fix code smells reported by SonarLint
Issue-ID: CPS-1739
Change-Id: I5eadeb8ef40d3d7befb762b5a8d2139fe3c85d7e
Signed-off-by: halil.cakal <halil.cakal@est.tech>
danielhanrahan [Wed, 26 Jul 2023 14:50:06 +0000 (15:50 +0100)]
Some performance tests are skipped due to filename
CPS POM is setup so that only files ending in 'Spec' or 'Test' are
run as tests, and files ending in 'PerfTest' will only run in the
'include-performance' profile. The 32K limit tests are currently
being skipped always, as they do not end in 'Spec', 'Test', or
'PerfTest'. This commit renames them to PerfTest.
Issue-ID: CPS-1811
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I75a4ae92edf324213f734503c23dedb2b31fd007
danielhanrahan [Mon, 24 Jul 2023 08:37:34 +0000 (09:37 +0100)]
Update dmi-stub details in test-deregistration script
dmi-plugin-stub was renamed to dmi-plugin-demo-and-csit-stub,
and port changed to 8092.
Issue-ID: CPS-1560
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I3005087ace35aa131df720ed04c642d2d72f1255
ToineSiebelink [Mon, 24 Jul 2023 11:23:05 +0000 (12:23 +0100)]
Fix code coverage reporting
- Fixed (partly duplicated) exclusion list: all exlusings now in PARENT pom only
(this means module reports and aggregate report use same exclusion
- Set common minimum to 100% (3 modules now achieve this :-) )
- Added./clean cm-parsre test to get too 10% in that module too
- Increased module specif minima to actual coverge today
Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic155f963bfd472e11481fcab6ee8ca227903d9ae
egernug [Fri, 21 Jul 2023 12:27:24 +0000 (13:27 +0100)]
Prepare for next CPS-NCMP release
Issue-ID: CPS-1797
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Ib2b840b6b37131f16afd879720658d2e45387d6a
egernug [Fri, 21 Jul 2023 12:19:01 +0000 (13:19 +0100)]
Container for release 3.3.5
Issue-ID: CPS-1797
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Id8bcefe615947a7ec160275bf7a3326e80a0f2f3
egernug [Fri, 21 Jul 2023 12:11:04 +0000 (13:11 +0100)]
Maven stage yaml for 3.3.5
Issue-ID: CPS-1797
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I99232dde07a4ad92fd124265214bc760a032de12
egernug [Fri, 21 Jul 2023 10:14:23 +0000 (11:14 +0100)]
Increase timeout for PollingConditions
Test failing due to timing issues. Increasing timeout to rectify.
Issue-ID: CPS-475
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I89b512809922470f10940fcdd739f057b8f9c80e
Sourabh Sourabh [Thu, 20 Jul 2023 15:29:14 +0000 (15:29 +0000)]
Merge "Refactor ncmp request handlers (fix async issue)"
Toine Siebelink [Thu, 20 Jul 2023 13:27:18 +0000 (13:27 +0000)]
Merge "Apostrophe handling in CpsPathParser"
ToineSiebelink [Tue, 18 Jul 2023 12:23:29 +0000 (13:23 +0100)]
Refactor ncmp request handlers (fix async issue)
- simplified request handlers (sub)classes (no more need for default interface)
- fix issue with async execution of data operation requests (wasn't really async)
- removed redundant (unreachable) check in production code
- Improved code coverage (branches) ncmp request handlers added UNIT test
- removed MVC test scenarios now covered by appropriate unit level tests
- applied Spock Polling Condition for verifying async call
Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ibe601c709de65080fa8898f2419fdbd92c5ba27d
Luke Gleeson [Thu, 20 Jul 2023 09:47:48 +0000 (09:47 +0000)]
Merge "Persisting a list element to a parent list (ep2)"
danielhanrahan [Wed, 28 Jun 2023 11:55:20 +0000 (12:55 +0100)]
Apostrophe handling in CpsPathParser
Apostrophe is not currently handled correctly, and having apostrophe in
the xpath will lead to various errors.
For example, normalizing this xpath works:
/path[@name="I'm quoted"] -> /path[@name='I\'m quoted']
However the resulting xpath will throw a PathParsingException if parsed!
(Thus path normalization is not idempotent.)
- Use '' for escaping apostrophe in single quoted leaf value,
to comply with XPath standard (and use "" for escaping in ").
- Use Liquibase to make existing data comply with new rules.
- Leaf values in data leaves are now unescaped, e.g. "I'm quoted"
- Quoting is now consistent for leaf/text/contains conditions.
Issue-ID: CPS-1769
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iafc287f738254d7f99706c6bc548091c0ecd5aa0
Toine Siebelink [Thu, 20 Jul 2023 08:52:40 +0000 (08:52 +0000)]
Merge "Allow duplicate leaf names in Cps Path leaf condition"
egernug [Wed, 19 Jul 2023 10:05:00 +0000 (11:05 +0100)]
Prepare for next CPS-NCMP release
Issue-ID: CPS-1791
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Ide0fcdfa41656e25395ac8478da1bb489fd8663e
egernug [Tue, 18 Jul 2023 10:32:56 +0000 (11:32 +0100)]
Container yaml for release
Issue-ID: CPS-1793
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: If7ac05d814da42b12c66704afcb153f4af72f3e5
egernug [Tue, 18 Jul 2023 10:26:18 +0000 (11:26 +0100)]
Maven stage yaml
Issue-ID: CPS-1793
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: Ie553550137038e4086f049beca76506df48e2a21
egernug [Tue, 18 Jul 2023 09:57:42 +0000 (10:57 +0100)]
Update release notes for release 3.3.4
Issue-ID: CPS-1792
Signed-off-by: egernug <gerard.nugent@est.tech>
Change-Id: I3f278d3e89dbc1a757f603ac312686d83612eec8