so.git
5 years agoMerge 'origin/casablanca' into master 75/77475/1
Benjamin, Max (mb388a) [Fri, 25 Jan 2019 22:08:41 +0000 (17:08 -0500)]
Merge 'origin/casablanca' into master

Issue-ID: SO-1435
Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
5 years agoMerge "Removed deprecated Matcher imports"
Steve Smokowski [Fri, 25 Jan 2019 13:53:23 +0000 (13:53 +0000)]
Merge "Removed deprecated Matcher imports"

5 years agoMerge "update all inprogress checks in apih handler"
Steve Smokowski [Fri, 25 Jan 2019 13:53:16 +0000 (13:53 +0000)]
Merge "update all inprogress checks in apih handler"

5 years agoMerge "Upgraded tosca parser to version 1.4.8"
Steve Smokowski [Fri, 25 Jan 2019 13:53:06 +0000 (13:53 +0000)]
Merge "Upgraded tosca parser to version 1.4.8"

5 years agoupdate all inprogress checks in apih handler 46/76146/3
Benjamin, Max (mb388a) [Tue, 22 Jan 2019 17:55:57 +0000 (12:55 -0500)]
update all inprogress checks in apih handler

Added second mapper for error responses
Removed method level ObjectMapper instantiation
Fixed formatting of resource file
Added db update if responsne from history lookup is empty
Fixed url and added it to yaml file
Removed space added to the end of line
Removed unused test resource file
Changed wording of exception message name
Added more JUnit tests and fixed auth lookup
Added path for checking process-instance history
Added ContactCamundaException for camundaHistoryCheck
Began adding auth header to send on request to camunda
Added unit tests for completed and terminated requests
Began adding test for camundaHistoryCheck
Added HistoricProcessInstance object for camunda response
Test commit, added comment to camundaHistoryCheck
Began adding method for checking camundaHistory

Change-Id: Ia9d94613fa5e78f2b8690874c39f032d60599e5e
Issue-ID: SO-1414
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRemoved deprecated Matcher imports 43/76143/3
Benjamin, Max (mb388a) [Tue, 22 Jan 2019 16:56:59 +0000 (11:56 -0500)]
Removed deprecated Matcher imports

replaced org.mockito.Matchers with ArgumentMatchers

Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7
Issue-ID: SO-1413
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoUpgraded tosca parser to version 1.4.8 22/76322/1
Benjamin, Max (mb388a) [Thu, 24 Jan 2019 22:35:39 +0000 (17:35 -0500)]
Upgraded tosca parser to version 1.4.8

- Upgraded tosca parser to version 1.4.8 and updated imports

Change-Id: Ic9549375d3d70598606056691e4e8baabfbd83d1
Issue-ID: SO-1426
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agobugfixes jan 24th 20/76320/1
Benjamin, Max (mb388a) [Thu, 24 Jan 2019 22:06:39 +0000 (17:06 -0500)]
bugfixes jan 24th

Fix null pointer exception when no requestParameters are specified
Add configurable timer in ActivateVfModuleBB to delay call to SDNC
activate - Use raw slf4j logger - use {} formatting
Add configurable timer in ActivateVfModuleBB to delay call to SDNC
activate - Use raw slf4j logger
Add configurable timer in ActivateVfModuleBB to delay call to SDNC
activate - removed unused references in test class
Add configurable timer in ActivateVfModuleBB to delay call to SDNC
activate
Update PortGroup objects separately from the parent VCE object -
restore setVariable calls back into vce object - they might be needed
later.
Update PortGroup objects separately from the parent VCE object -
updated test class
extra call to get PortGroups
Update PortGroup objects separately from the parent VCE object - use
PortGroup.getInterfaceRole() getter method instead of accessing field
directly.
Update PortGroup objects separately from the parent VCE object
Added back required headers for tenant isolation.
removed workflow exception from outmapping in execute
Fix possible null ptr exception, fix to add braces.
Default networkTechnology in Update as done in Create
Fix failing junits, mapper force upper case nwtech
update exception builder to properly throw exception error message
supporting assign service instance a la carte as well
adding in proper exception handling in network rest v1
add the unassign action to R macro data file

Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7
Issue-ID: SO-1424
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix typo 04/76304/1
subhash kumar singh [Thu, 24 Jan 2019 17:52:27 +0000 (23:22 +0530)]
Fix typo

Fix typo for typo in method name.

Change-Id: I8dde10a5e161ad376469ff1bdc4d649d7fa89c02
Issue-ID: SO-1422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoFix AR receipe retrival 82/76282/1
subhash kumar singh [Thu, 24 Jan 2019 11:30:09 +0000 (17:00 +0530)]
Fix AR receipe retrival

Fix AR receipe retrival.

Change-Id: I5675fef17c1ee6375dd6c68a311d5f0568438879
Issue-ID: SO-1422
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoFix get of operationType 87/76187/1
subhash kumar singh [Wed, 23 Jan 2019 11:12:13 +0000 (16:42 +0530)]
Fix get of operationType

OperationType should return empty from db request instead of "null".

Change-Id: I5df3df5aead6008c4e14961ee385cafe64c37959
Issue-ID: SO-1417
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agovalidate number of uri keys 42/76142/1
Benjamin, Max (mb388a) [Tue, 22 Jan 2019 16:48:03 +0000 (11:48 -0500)]
validate number of uri keys

test was setting unnecessary keys on uri
changed plural to singular AAI class
added in validation for number of keys provided

Change-Id: I86f61301aa5f2ea676678908bae1e88b86d7e570
Issue-ID: SO-1409
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed incorrect object reference 41/76141/1
Benjamin, Max (mb388a) [Tue, 22 Jan 2019 16:46:47 +0000 (11:46 -0500)]
fixed incorrect object reference

changed plural to singular AAI class

Change-Id: I6205d95b881d011e377669858fc85dc2ff0a17f6
Issue-ID: SO-1412
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Either log or rethrow this exception."
Steve Smokowski [Tue, 22 Jan 2019 14:41:31 +0000 (14:41 +0000)]
Merge "Either log or rethrow this exception."

5 years agoMerge "Fix CSAR distribution on CCVPN service" into casablanca
Steve Smokowski [Tue, 22 Jan 2019 13:56:52 +0000 (13:56 +0000)]
Merge "Fix CSAR distribution on CCVPN service" into casablanca

5 years agoFix CSAR distribution on CCVPN service 01/76101/3
subhash kumar singh [Tue, 22 Jan 2019 07:26:29 +0000 (12:56 +0530)]
Fix CSAR distribution on CCVPN service

Fix db schema to allow CCVPN service witout heat artifacts.

Change-Id: I4f79881a6a04f01f8984835eea88907a61c640db
Issue-ID: SO-1407
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoFix Integer cast exception in getResourceInput 05/76105/1 so-1408
subhash kumar singh [Tue, 22 Jan 2019 08:57:55 +0000 (14:27 +0530)]
Fix Integer cast exception in getResourceInput

Fix Integer cast exception in getResourceInput.

Change-Id: I2022ec07fe12bfe1764f734f1776f6bd32143b84
Issue-ID: SO-1408
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoEither log or rethrow this exception. 56/75856/3
Shubhada Ramkrishna Vaze [Wed, 16 Jan 2019 09:34:13 +0000 (15:04 +0530)]
Either log or rethrow this exception.

Location:DistributionClientEmulator.java

Change-Id: I38b1b3fed9db0d24a6045352127e48b98cce6b63
Issue-ID: SO-1397
Signed-off-by: Shubhada Ramkrishna Vaze <SV00449682@TechMahindra.com>
5 years agoMerge "Bug fixes from AT&T January 20th"
Steve Smokowski [Mon, 21 Jan 2019 20:42:51 +0000 (20:42 +0000)]
Merge "Bug fixes from AT&T January 20th"

5 years agoBug fixes from AT&T January 20th 41/76041/3
Benjamin, Max (mb388a) [Sun, 20 Jan 2019 21:10:18 +0000 (16:10 -0500)]
Bug fixes from AT&T January 20th

sorted vfmodules by base last for negative action reqs
store Response in execution as String on network delete
added functionality to skip rollback based on flag # Conflicts: #
bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo
w/tasks/WorkflowAction.java
require XML in the header for delete network request
Update APP-C LCM Client library version to 1.7.0.
replaced wiremock style test with mockito test
Handle AAIClient Exps in CreateCustomerV1 getServiceInstance()
changed default status code to be configurable
Replace vnfType by nfRole in the healthcheck request to SDNO.
updated error messages in sdnc handler and flow status
updated flow status message on completion of flow
Send GenericVnf object for AAI VNF update for vnf-api updates
Add a JUnit test file for SDNOValidatorImpl.java
Set nodeType on the inner SDNO request as per update from SDNO.
updated rollbackToAssigned logic to remove unassign flows
updated sdnc handler error message for client error
added exception handling for httpclienterror in sdnc
out map workflow exception so error is reported
throws sdnc error message on bad response from sdnc
add catalog entries for TRANSPORT service delete flows
change script number that was duplicate
add find method to NorthBoundRequestRepository
include serviceType in hash code
use asterisk for all non-TRANSPORT flow db entries
alacart true, rm not needed transport srvc model steps
correct insert query syntax for orchestration_flow
support serviceType (TRANSPORT) process flow
fix SDNCAdapterException causing no callback to bpmn
use JsonAlias for alternate case when deserializing
GRM client will accept both "serviceEndPointList" and
"ServiceEndPointList" root node in the JSON response.
AAIRestClient now uses getSystemName in headers
finishtime should not be returned in requeststatus

Change-Id: I81a185252b057020f7f36f125c85c3357756da88
Issue-ID: SO-1403
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "convert from sync to async"
Steve Smokowski [Mon, 21 Jan 2019 13:45:42 +0000 (13:45 +0000)]
Merge "convert from sync to async"

5 years agoUpdate the SDC-Tosca version 62/76062/5
seshukm [Mon, 21 Jan 2019 11:21:38 +0000 (16:51 +0530)]
Update the SDC-Tosca version

Issue-ID: SDC-1955

Change-Id: I6de3ac0509755b5b4ce54015c761d8651467347b
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoconvert from sync to async 46/76046/1
Benjamin, Max (mb388a) [Sun, 20 Jan 2019 23:30:39 +0000 (18:30 -0500)]
convert from sync to async

fixed network adapter object mapper test issues
fixed all test issues and compilation issues
remove setting of notification url for rollback
covert sync calls for create and delete network to async
removed async after from invoke sdnc adapter task
remove unwanted changes that were committed earlier
fix unmarshalling of response back from openstack adap
added in code to throw an error when AIC issue

Change-Id: Ic9fa39584ed2bcb70804fbd74586f1cc119c7d8b
Issue-ID: SO-1404
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoensure data for si matches on macro requests 42/76042/1
Benjamin, Max (mb388a) [Mon, 21 Jan 2019 01:17:45 +0000 (20:17 -0500)]
ensure data for si matches on macro requests

Fixed failing ValidationExceptionTest
Moved MacroRequest.json to test specific folder
Moved resource files to test specific folder
Cleaned up comments from UserParamsValidationTest
Refactored modelInfoValidation method
Removed unused constants from ValidationException
Removed unused ValidationException
ADded overrideExistingMessage boolean
Added test for missing modelType in userParams service object
Fixed failing JUnit tests in MsoRequestTest
Started fixing failing JUnit tests
Began adding validation and tests for userParams modelInfo
Began adding validation for instanceName

Change-Id: I442f6b660af4e716d75746f8d8155aac1e183e80
Issue-ID: SO-1405
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Correct the URLs in swagger"
Seshu Kumar M [Fri, 18 Jan 2019 16:47:49 +0000 (16:47 +0000)]
Merge "Correct the URLs in swagger"

5 years agoMerge "remove unused uuid parameter"
Steve Smokowski [Fri, 18 Jan 2019 13:07:28 +0000 (13:07 +0000)]
Merge "remove unused uuid parameter"

5 years agoCorrect the URLs in swagger 78/75978/1
seshukm [Fri, 18 Jan 2019 08:41:47 +0000 (14:11 +0530)]
Correct the URLs in swagger

Issue-ID: SO-675

Change-Id: I55dbc4d64f41dbf0a38e38ee11ba35d4ed7f2cfd
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoupdate the interface doc for Dublin 77/75977/1
seshukm [Fri, 18 Jan 2019 08:40:05 +0000 (14:10 +0530)]
update the interface doc for Dublin

Issue-ID: SO-675

Change-Id: I07a20a651e95ea114caeeec797a7881c3a1bc663
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agobump the SO version to 1.3.7 76/75976/1
seshukm [Fri, 18 Jan 2019 08:31:27 +0000 (14:01 +0530)]
bump the SO version to 1.3.7

Issue-ID: SO-1400

Change-Id: Iaab560b348dee04f47d173855516171f5058a384
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "Sonar:Critical"
Steve Smokowski [Thu, 17 Jan 2019 17:42:09 +0000 (17:42 +0000)]
Merge "Sonar:Critical"

5 years agoMerge "Change size for resource input" into casablanca
Steve Smokowski [Thu, 17 Jan 2019 17:41:45 +0000 (17:41 +0000)]
Merge "Change size for resource input" into casablanca

5 years agoChange size for resource input 21/75921/3
subhash kumar singh [Thu, 17 Jan 2019 08:58:43 +0000 (14:28 +0530)]
Change size for resource input

Change size for resource input.

Change-Id: Ic6856e6baa2623867d0ae688c98ed24dbb245036
Issue-ID: SO-1400
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoMerge "Fix url for catalog query" into casablanca
Steve Smokowski [Thu, 17 Jan 2019 13:28:28 +0000 (13:28 +0000)]
Merge "Fix url for catalog query" into casablanca

5 years agoAdded CorsConfigurer class and cleaned up typos 18/75918/1
Eoin Hanan [Wed, 16 Jan 2019 16:30:32 +0000 (16:30 +0000)]
Added CorsConfigurer class and cleaned up typos

Change-Id: If133419e4ddb7aa4b8b0a199a57e1eaf9a8386c7
Issue-ID: SO-1335
Signed-off-by: Eoin Hanan <eoin.hanan@ericsson.com>
(cherry picked from commit ae993816c1dbe800dffe0c9e0dada126a57860e6)

5 years agoremove unused uuid parameter 15/75915/1
Lukasz Muszkieta [Thu, 17 Jan 2019 07:49:22 +0000 (08:49 +0100)]
remove unused uuid parameter

Change-Id: I0c4d5d6fcbf5d7c48c82b4485980adf2fde809cd
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoJSON objects now displaying as string 28/75528/2
Eoin Hanan [Fri, 7 Dec 2018 09:57:04 +0000 (09:57 +0000)]
JSON objects now displaying as string

Change-Id: I659f56dd28e8a1f44bf88c7a23c961866d081cca
Issue-ID: SO-1286
Signed-off-by: Eoin Hanan <eoin.hanan@ericsson.com>
(cherry picked from commit b19a518ceecc27255505616eed878abcff260f25)

5 years agoChanges to UI Time Variables 27/75527/2
Eoin Hanan [Wed, 5 Dec 2018 11:34:22 +0000 (11:34 +0000)]
Changes to UI Time Variables

Change-Id: If1289c7a7addf032b6c8d98fd58fca92ffcd5a7c
Issue-ID: SO-1265
Signed-off-by: Eoin Hanan <eoin.hanan@ericsson.com>
(cherry picked from commit 5df9c2d914e0b8bd6ade407a799fd6c159e54deb)

5 years agoFlow loses highlighted path on page reloads 26/75526/2
shinuj1989 [Wed, 28 Nov 2018 10:22:11 +0000 (10:22 +0000)]
Flow loses highlighted path on page reloads

Change-Id: I7806cdd1998c4451359b452eb5c9bf1e7059fc32
Issue-ID: SO-1245
Signed-off-by: shinuj1989 <shinu.john@ericsson.com>
(cherry picked from commit 8bc174515ba421f2163b74788454bda9bcb885b5)

5 years agoChanged nodeport from 9091 to 30224 25/75525/2
eHanan [Wed, 21 Nov 2018 16:36:31 +0000 (16:36 +0000)]
Changed nodeport from 9091 to 30224

Change-Id: I64999b518b5ea2d20bd74a07ed1e566df065688f
Issue-ID: SO-1164
Signed-off-by: eHanan <eoin.hanan@ericsson.com>
(cherry picked from commit 0f66685d0eceb65e5aca62b0ed96123b57df2683)

5 years agoAdded CorsConfigurer class and cleaned up typos 88/75888/1
Eoin Hanan [Wed, 16 Jan 2019 16:30:32 +0000 (16:30 +0000)]
Added CorsConfigurer class and cleaned up typos

Change-Id: If133419e4ddb7aa4b8b0a199a57e1eaf9a8386c7
Issue-ID: SO-1335
Signed-off-by: Eoin Hanan <eoin.hanan@ericsson.com>
5 years agoFix url for catalog query 70/75870/1
subhash kumar singh [Wed, 16 Jan 2019 12:43:48 +0000 (18:13 +0530)]
Fix url for catalog query

Fix url for catalog query.

Change-Id: I694284b9c3b354a5d0e4340b7f7e78744096c80f
Issue-ID: SO-1398
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoMerge "remove unused uuid parameter"
Steve Smokowski [Tue, 15 Jan 2019 16:09:53 +0000 (16:09 +0000)]
Merge "remove unused uuid parameter"

5 years agoMerge "Either log or rethrow this exception."
Steve Smokowski [Tue, 15 Jan 2019 15:59:47 +0000 (15:59 +0000)]
Merge "Either log or rethrow this exception."

5 years agoremove unused uuid parameter 15/75815/1
Lukasz Muszkieta [Tue, 15 Jan 2019 13:11:13 +0000 (14:11 +0100)]
remove unused uuid parameter

Change-Id: I07793ddafdb8c23ff62ce282c413585c495751ab
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agorevert the changes 14/75814/1
seshukm [Tue, 15 Jan 2019 12:47:19 +0000 (18:17 +0530)]
revert the changes

Issue-ID: SO-1391

Change-Id: I166d149b813aebb0511c1944a3bd3700080de201
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoupdate release notes for 1.3.6 11/75811/1
seshukm [Tue, 15 Jan 2019 12:10:35 +0000 (17:40 +0530)]
update release notes for 1.3.6

Issue-ID: SO-1352

Change-Id: Ie5bc189058d5f32406e3a92e0e859826c5060f3b
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoSonar:Critical 10/75110/4
Manamohan Satapathy [Tue, 15 Jan 2019 08:48:52 +0000 (14:18 +0530)]
Sonar:Critical

ValetUpdateResponse.java:L37

Change-Id: I93db82c18cda553d3b1c78467d7c558a2787e7d8
Issue-ID: SO-1351
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
5 years agoMsoTenantUtilsFactoryTest unit tests 42/75742/3
Michal Kabaj [Mon, 14 Jan 2019 12:56:32 +0000 (13:56 +0100)]
MsoTenantUtilsFactoryTest unit tests

-added new test cases for factory class

Change-Id: Iddd221d1ff5fa6748657b635bc07b6c795b8b9d8
Issue-ID: SO-1339
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
5 years agoeliminate the failing tests 99/75799/2
seshukm [Tue, 15 Jan 2019 05:18:15 +0000 (06:18 +0100)]
eliminate the failing tests

Initial step to make the release build success for 1.3.6.

Issue-ID: SO-1391

Change-Id: If7cadd5b5cd23cdbf6474bf94850a83ed7efed81
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoEither log or rethrow this exception. 00/75800/1
Shubhada Ramkrishna Vaze [Tue, 15 Jan 2019 06:10:52 +0000 (11:40 +0530)]
Either log or rethrow this exception.

Location:GlobalHealthcheckHandler.java Line No:180

Change-Id: I679e99774cee228dc239f0403a44be223fdd46cd
Issue-ID: SO-1360
Signed-off-by: Shubhada Ramkrishna Vaze <SV00449682@TechMahindra.com>
5 years agoAdd missing license headers 47/75747/1
Benjamin, Max (mb388a) [Mon, 14 Jan 2019 14:08:02 +0000 (09:08 -0500)]
Add missing license headers

add headers to files which were missing them

Issue-ID: SO-1390
Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Add junit tests for MsoCloudifyUtils"
Steve Smokowski [Sat, 12 Jan 2019 13:16:57 +0000 (13:16 +0000)]
Merge "Add junit tests for MsoCloudifyUtils"

5 years agoMerge "updated logging to JaxRsFilterLogging"
Steve Smokowski [Sat, 12 Jan 2019 13:16:43 +0000 (13:16 +0000)]
Merge "updated logging to JaxRsFilterLogging"

5 years agoMerge "Created sniro request pojos for homingV2 flow"
Steve Smokowski [Sat, 12 Jan 2019 13:16:32 +0000 (13:16 +0000)]
Merge "Created sniro request pojos for homingV2 flow"

5 years agoMerge "get subnet sequence number from A&AI"
Steve Smokowski [Sat, 12 Jan 2019 13:16:21 +0000 (13:16 +0000)]
Merge "get subnet sequence number from A&AI"

5 years agoMerge "Re-enable Actuator for Springboot 2.0"
Steve Smokowski [Sat, 12 Jan 2019 13:15:45 +0000 (13:15 +0000)]
Merge "Re-enable Actuator for Springboot 2.0"

5 years agoMerge changes I49db843f,I6c6d7a50
Steve Smokowski [Sat, 12 Jan 2019 13:14:52 +0000 (13:14 +0000)]
Merge changes I49db843f,I6c6d7a50

* changes:
  descriptive messages now returned by validator
  refactored validator to be more generic

5 years agoMerge "Service Proxy Consolidation"
Steve Smokowski [Sat, 12 Jan 2019 13:14:34 +0000 (13:14 +0000)]
Merge "Service Proxy Consolidation"

5 years agoMerge "Quality of Life logging improvements"
Steve Smokowski [Sat, 12 Jan 2019 13:14:14 +0000 (13:14 +0000)]
Merge "Quality of Life logging improvements"

5 years agoMerge "removed retired A&AI versions from codebase"
Steve Smokowski [Sat, 12 Jan 2019 13:13:45 +0000 (13:13 +0000)]
Merge "removed retired A&AI versions from codebase"

5 years agoMerge "Miscellaneous fixes"
Steve Smokowski [Sat, 12 Jan 2019 13:13:34 +0000 (13:13 +0000)]
Merge "Miscellaneous fixes"

5 years agoMerge "explicitly type defs and strings for templates"
Steve Smokowski [Sat, 12 Jan 2019 13:13:22 +0000 (13:13 +0000)]
Merge "explicitly type defs and strings for templates"

5 years agoMerge "naming ms client fixes"
Steve Smokowski [Sat, 12 Jan 2019 13:13:06 +0000 (13:13 +0000)]
Merge "naming ms client fixes"

5 years agoMerge "validation for vnfs before WorkflowAction starts"
Steve Smokowski [Sat, 12 Jan 2019 13:12:55 +0000 (13:12 +0000)]
Merge "validation for vnfs before WorkflowAction starts"

5 years agoadded id when calling SDNCHandler subflow 21/75721/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 03:49:31 +0000 (22:49 -0500)]
added id when calling SDNCHandler subflow

added mso-request-id when calling SDNCHandler subflow

Change-Id: I4b8f56ab5623236528b1c6031af616c8724dd716
Issue-ID: SO-1389
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agodescriptive messages now returned by validator 20/75720/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 03:24:32 +0000 (22:24 -0500)]
descriptive messages now returned by validator

descriptive messages now returned by validator

Change-Id: I49db843fbdfe20979fba6991744c62aa1f745d5f
Issue-ID: SO-1388
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agonaming ms client fixes 19/75719/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 03:07:56 +0000 (22:07 -0500)]
naming ms client fixes

Fixed failing unit test for request object builder
Added throws declaration for IOException
Changed endpoint to point to wiremock
Added exception handling for httpstatuscode
Reverted changes to validator
Added exception handling for response from naming mS
Changed how element object properties are set
Changed yaml to point to naming mS dev env
Began adding unit tests for naming client

Change-Id: Ic753e0dbaed52065ff5c0dfc9a59a726fdbdc642
Issue-ID: SO-1387
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoexplicitly type defs and strings for templates 18/75718/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 03:04:12 +0000 (22:04 -0500)]
explicitly type defs and strings for templates

explicitly type defs and strings for templates

Change-Id: If4af5b0cdf086cd0d30277d1e835e2aa7c8e7f9c
Issue-ID: SO-1386
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMiscellaneous fixes 17/75717/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:54:58 +0000 (21:54 -0500)]
Miscellaneous fixes

updated common pom to use aai schema version 1.4.1
removed handle sync error from SDNCHandler bpmn flow
added mso-request-id to in mapping of delete vnf flows
moved temporary test file to temporary folder
Removed obsolete genericVnfNode parameter from updateGenericVnfNode
sorted vfmodules by base last for negative action reqs

Change-Id: I7a5018d67292cfaac8d923ac3bd9b27ed037be57
Issue-ID: SO-1382
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoremoved retired A&AI versions from codebase 16/75716/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:48:00 +0000 (21:48 -0500)]
removed retired A&AI versions from codebase

removed retired A&AI versions from codebase

Change-Id: I3e0a185ad1020c91be2fa3df7a509fde2a83c4cd
Issue-ID: SO-1385
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agorefactored validator to be more generic 14/75714/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:35:13 +0000 (21:35 -0500)]
refactored validator to be more generic

removed overloaded method from class for JUEL
changed test back to DelegateExecution
added methods to allow validations with DelegateExecution
refactored validator to be more generic

Change-Id: I6c6d7a50e8b5470ffa5619cc83966f5ad68e66fe
Issue-ID: SO-1383
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoQuality of Life logging improvements 13/75713/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:19:45 +0000 (21:19 -0500)]
Quality of Life logging improvements

Remove invalid newline character in process name
Quality of Life logging improvements

Change-Id: I2193c08e365e847f6be144106a0b20aa7828497e
Issue-ID: SO-1381
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoService Proxy Consolidation 12/75712/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:14:32 +0000 (21:14 -0500)]
Service Proxy Consolidation

- Updated ServiceProxyResourceCustomization to remove the ID column
- Removed setConfigurationResourceCustomization from
serviceProxyResource since that relationship doesn't exist anymore
- Updated ServiceProxy resource to remove the object dependencies
between ServiceProxyCustomization and ConfigurationResourceCustomization
- Removed the delete statement since this is causing the test to fail
because the service table doesn't exist yet
- Updated configuration_customization to drop the
serviceProxyCustomization FK
- Added migration script to consolidate the ServiceProxy and
ServiceProxyCustomization into a single table and migrate the data.
- Code changes to support consolidating the ServiceProxy and
ServiceProxyCustomization table into a single table

Change-Id: I1e49cb22c8b667f157dd1c349b5e36fd06236630
Issue-ID: SO-1380
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agovalidation for vnfs before WorkflowAction starts 11/75711/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:09:59 +0000 (21:09 -0500)]
validation for vnfs before WorkflowAction starts

Removed accidental merge markup from WorkflowActionBB
Addition of prevalidation to WorkflowActionBB.
Implement more JUnits for validation methods.
Implement verification of deleteInstance workflow for VNR configuration
dependencies.
Added a validation mechanism on a workflow level to check for valid
actions.

Change-Id: Icb2859c3b8ece534d4e9831ca5f48a15dfaef58d
Issue-ID: SO-1379
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoget subnet sequence number from A&AI 10/75710/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:07:06 +0000 (21:07 -0500)]
get subnet sequence number from A&AI

Add AAIQuery for subnet block to CreateNetwork bpmn
MSO shall get subnet sequence number.

Change-Id: I5cf73d1b5344f41ac98a51274948822322e3591b
Issue-ID: SO-1378
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRe-enable Actuator for Springboot 2.0 09/75709/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:02:26 +0000 (21:02 -0500)]
Re-enable Actuator for Springboot 2.0

Re-enable Actuator for Springboot 2.0

Change-Id: Icee67885d9bd26d6b6ff8a4fceb9add56926b0a8
Issue-ID: SO-1377
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoCreated sniro request pojos for homingV2 flow 08/75708/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 02:00:13 +0000 (21:00 -0500)]
Created sniro request pojos for homingV2 flow

Updated random ports to replaced in expected file response
Created sniro request pojos for homingV2 flow.

Change-Id: Ib2fedbc28dc048048a21eaa88601bcb0c21360f7
Issue-ID: SO-1376
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoupdated logging to JaxRsFilterLogging 07/75707/1
Benjamin, Max (mb388a) [Sat, 12 Jan 2019 01:57:10 +0000 (20:57 -0500)]
updated logging to JaxRsFilterLogging

Changed the MDC sourcing from LoggingInterceptor to JaxRsFilterLogging.

Change-Id: Idd807f1bf6d3a5a680f547d09503a53a362cd5d1
Issue-ID: SO-1362
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdd junit tests for MsoCloudifyUtils 90/75690/1
Lukasz Muszkieta [Fri, 11 Jan 2019 12:02:33 +0000 (13:02 +0100)]
Add junit tests for MsoCloudifyUtils

Change-Id: If12ed6350306cd489aa8b1744a513875b42540c3
Issue-ID: SO-430
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agojunits for MsoTenantUtilsFactory 07/75607/2
Tomasz Gwozdecki [Thu, 10 Jan 2019 08:08:59 +0000 (03:08 -0500)]
junits for MsoTenantUtilsFactory

-Added new test for MsoTenantUtilsFactory

Change-Id: I9ba756a1f1c569dc7d0c1528272cca1ccfe3aad4
Issue-ID: SO-1339
Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
5 years agofix jenkins master build 66/75666/1
Lukasz Muszkieta [Fri, 11 Jan 2019 10:26:21 +0000 (11:26 +0100)]
fix jenkins master build

Change-Id: If263db591b98af62d9d49d75c602bd5c7966f1e4
Issue-ID: SO-1375
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoMerge "update the SDC client APIs"
Byung-Woo Jun [Fri, 11 Jan 2019 08:14:53 +0000 (08:14 +0000)]
Merge "update the SDC client APIs"

5 years agoMerge "Fix json parsing of resource input" into casablanca 1.3.6 3.0.1-ONAP
Seshu Kumar M [Fri, 11 Jan 2019 04:26:58 +0000 (04:26 +0000)]
Merge "Fix json parsing of resource input" into casablanca

5 years agoMerge "update the SDC client APIs" into casablanca
Byung-Woo Jun [Thu, 10 Jan 2019 08:51:56 +0000 (08:51 +0000)]
Merge "update the SDC client APIs" into casablanca

5 years agoupdate the SDC client APIs 96/75596/1
seshukm [Thu, 10 Jan 2019 06:15:01 +0000 (07:15 +0100)]
update the SDC client APIs

Issue-ID: SO-1337

Change-Id: Iafd90debd2410e5dcbd55dba8a2c33018e4ecf6d
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoupdate the SDC client APIs 94/75594/1
seshukm [Thu, 10 Jan 2019 05:22:56 +0000 (06:22 +0100)]
update the SDC client APIs

Issue-ID: SO-1337

Change-Id: I87f799664ea7a3b46a53fab6eec8e0aae07c3596
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoFix json parsing of resource input 64/75264/4
subhash kumar singh [Fri, 4 Jan 2019 07:09:08 +0000 (12:39 +0530)]
Fix json parsing of resource input

Fix json parsing of resource input by adding escape character.

Change-Id: Ic19bd5dae5eea25faaeae2df3eb0bcc29482ea7c
Issue-ID: SO-1358
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoFix the image path 65/75365/1
seshukm [Mon, 7 Jan 2019 14:24:42 +0000 (22:24 +0800)]
Fix the image path

Issue-ID: SO-1337

Change-Id: Ifbc15a413cfc0dea96ef7fb22a500901c575af62
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "Remove Swagger UI"
Seshu Kumar M [Sun, 6 Jan 2019 15:34:41 +0000 (15:34 +0000)]
Merge "Remove Swagger UI"

5 years agoFix the APi info 31/75331/1
seshukm [Sun, 6 Jan 2019 08:45:20 +0000 (14:15 +0530)]
Fix the APi info

Issue-ID: SO-1337

Change-Id: I5cd683d047550fc3a7ae9689e23da2e9f34caba9
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoFix the dev info 29/75329/1
seshukm [Sun, 6 Jan 2019 06:23:10 +0000 (11:53 +0530)]
Fix the dev info

Issue-ID: SO-1337

Change-Id: Ic3e7976dcca6457968ddcca2cfbe1ccb3ec1f5c2
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoUpdate the api content 28/75328/1
seshukm [Sat, 5 Jan 2019 12:22:05 +0000 (04:22 -0800)]
Update the api content

Issue-ID: SO-1337

Change-Id: Ibecfd3d4d065af95b1e3287e8d2063443a75f86b
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoBugfixes for December 2018 84/75284/1
Benjamin, Max (mb388a) [Fri, 4 Jan 2019 03:50:11 +0000 (22:50 -0500)]
Bugfixes for December 2018

Changed the way that the cidr is constructed in network utils.
added in the if statement to check if selflink already exists
removed execution line that was not needed in pull
added service instance id to workflowResourceIds for virtualLinkKey
network flows
wrote test for updating request to complete in db
workflow action directly updates db instead of using mso complete
process
Increase max timeout for SDNO Health Checks dmaap.
Added execution variable and corrected type and way data is retrieved
to fix defect
fixed retry status message in request db for #/5
updated workflowActionBBTasks for flow status message
updated flow status to failed on a workflowaction fail
Removed slashes and fixed rollbackStatusMessage
Updated requestStatus logic for adding status messages
Added junit test to validate casue of a defect and cleaned up code and
logging
added end timestamp to request db on complete request
fixed l3Network update of orchestation status in
DoUpdateNetworkInstance groovy as well
fixed update of l3network orchestration status
Add explicit resetting of heatStackId in A&AI to DeleteVfModule and
DeleteVolumeGroup BBs.
Preserve heatStackId setting in the copiedVfModule when updating the VF
Module in A&AI.
added functionality to skip rollback based on flag
Update snapshot version for logging, add headers
fixed optional of error in retrieveErrorMessage method
Set heatStackId to null if we want to remove it in A&AI.
added in a warn logger statement to keep track of field
map network technology from l3network instead of model info for network
adapter object mapper
Force heatStackId value to empty on an attempt to set it to null on
update
updated common pom to use aai schema version 1.4.1
removed handle sync error from SDNCHandler bpmn flow

Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4
Issue-ID: SO-1361
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Added timeStamp to requestStatus returned"
Steve Smokowski [Fri, 4 Jan 2019 13:16:58 +0000 (13:16 +0000)]
Merge "Added timeStamp to requestStatus returned"

5 years agoHttpClientFactory to create HttpClient instances 28/74728/4
Michal Kabaj [Mon, 17 Dec 2018 16:10:24 +0000 (17:10 +0100)]
HttpClientFactory to create HttpClient instances

-Replace constructor calls with existing factory
-Add create methods to factory for each required Media Type

Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9
Issue-ID: SO-1344
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
5 years agoAdded timeStamp to requestStatus returned 20/74520/5
Kalkere Ramesh, Sharan (sk720x) [Tue, 11 Dec 2018 16:58:18 +0000 (11:58 -0500)]
Added timeStamp to requestStatus returned

Added timeStamp to requestStatus returned

Change-Id: Ife220b95287e672f456f1511f64ddccb613dde93
Issue-ID: SO-1328
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
5 years agoMerge "Either log or rethrow this exception"
Steve Smokowski [Thu, 3 Jan 2019 13:05:33 +0000 (13:05 +0000)]
Merge "Either log or rethrow this exception"

5 years agoupdate the SO detailed api 94/75194/1
seshukm [Thu, 3 Jan 2019 01:28:29 +0000 (09:28 +0800)]
update the SO detailed api

Issue-ID: SO-1337

Change-Id: Ic18a2119aea7dcfa1c41724f5c8db1f6a44dc703
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoSonar:Critical 78/75178/1
Manamohan Satapathy [Wed, 2 Jan 2019 10:45:17 +0000 (16:15 +0530)]
Sonar:Critical

CompareModelsResult.java:L31,L32 & L33
Issue-ID: SO-1356

Change-Id: I0afd0c5e12e63c7758238dd50968e4b2a926237d
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
5 years agobump the version to 1.3.6 28/75128/1
seshukm [Fri, 28 Dec 2018 09:48:52 +0000 (17:48 +0800)]
bump the version to 1.3.6

Issue-ID: SO-1352

Change-Id: Ida0f3ff65c020e1390594e1fffcc9f93cb7d60d1
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>