policy/apex-pdp.git
5 years agoFix Sonar/Checkstyle issues in apex-pdp 93/90593/2
liamfallon [Thu, 27 Jun 2019 14:58:28 +0000 (14:58 +0000)]
Fix Sonar/Checkstyle issues in apex-pdp

BBS Java code introduced Sonar issues, these are resolved.
Also fixed checkstyle errors in other classes.
Also fiexed "unexpected type" eclipse errors.

Issue-ID: POLICY-1791
Change-Id: I3931051f0944c6d53745c8dd1db7cca4ee118f1c
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoAllow Kafka plugin to take arbitrary properties 55/90455/2 2.2.0
liamfallon [Tue, 25 Jun 2019 16:10:25 +0000 (16:10 +0000)]
Allow Kafka plugin to take arbitrary properties

This change adds support for arbitrary Kafka properties to be passed to
Kafka through the Kafka plugin.

Issue-ID: POLICY-1818
Change-Id: I4389876286747b250c8abe492e9e31674a9483c9
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoUpgrade to released common and models 98/90398/1
Pamela Dragosh [Mon, 24 Jun 2019 15:44:03 +0000 (11:44 -0400)]
Upgrade to released common and models

Released common 1.5.0 and models 2.1.0

Issue-ID: POLICY-1737
Change-Id: I677d1c210869ea565fc4edd9c190567a6ad01642
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoReplace uses of getCanonicalName() with getName() in APEX 97/90297/1
a.sreekumar [Fri, 21 Jun 2019 11:21:14 +0000 (11:21 +0000)]
Replace uses of getCanonicalName() with getName() in APEX

Change-Id: Ifcd8866e65a7bc1238d5a4137f7bad288a5bfb3b
Issue-ID: POLICY-1861
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoUpgrade to release 3.0.0 parent 54/90254/2
Pamela Dragosh [Thu, 20 Jun 2019 20:23:14 +0000 (16:23 -0400)]
Upgrade to release 3.0.0 parent

Policy/parent released

Issue-ID: POLICY-1737
Change-Id: I55c99667e2775c934c7e1f41d2225facdecb121b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoEnable maven-checkstyle-plugin in apex-pdp 72/90172/3
a.sreekumar [Thu, 20 Jun 2019 09:39:59 +0000 (09:39 +0000)]
Enable maven-checkstyle-plugin in apex-pdp

Enable maven-checkstyle-plugin in apex-pdp/pom.xml to fail the build at warning level.
Fix all the existing check style issues in the component.

Change-Id: I4de9c1bd9ca5a2876de9086d2d3526cbdc25c080
Issue-ID: POLICY-1732
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoUse io.fabric8:docker-maven-plugin to build and push docker images 14/90014/3
Rashmi Pujar [Mon, 17 Jun 2019 14:34:49 +0000 (10:34 -0400)]
Use io.fabric8:docker-maven-plugin to build and push docker images

Issue-ID: POLICY-969
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: Ia3c7c2d6b77d87848c344f212f4a0266db90426e

5 years agoFix junit tests in apex-pdp 45/90145/1
liamfallon [Wed, 19 Jun 2019 09:43:28 +0000 (09:43 +0000)]
Fix junit tests in apex-pdp

Sonar fix broke some of the junit tests for parameters; fixed those.

Issue-ID: POLICY-1791
Change-Id: If39472b9936d5312a1d4109ad83610f5913d3e34
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoPolicy JSON formatting issues in APEX 88/89888/1
a.sreekumar [Fri, 14 Jun 2019 13:07:14 +0000 (13:07 +0000)]
Policy JSON formatting issues in APEX

In APEX, the policy model currently needs to be escaped, otherwise
causes json formatting issues. This is fixed.

Change-Id: If9d5043acef0b175494be797fc7acd9c6c4f4494
Issue-ID: POLICY-1839
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoBBS APEX policy not updating PNF attachment point after relocation 96/89696/1
s00370346 [Tue, 11 Jun 2019 12:32:57 +0000 (18:02 +0530)]
BBS APEX policy not updating PNF attachment point after relocation

Issue-ID: POLICY-1835
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
Change-Id: I47473444b58fa3b064ba142ce13c5e3520adb8c7

5 years agoMerge "Removing rpm build option from apex-pdp"
Jorge Hernandez [Thu, 6 Jun 2019 18:56:10 +0000 (18:56 +0000)]
Merge "Removing rpm build option from apex-pdp"

5 years agoMerge "BBS Apex Policy vendor --> manufacturer and other"
Jorge Hernandez [Thu, 6 Jun 2019 18:55:40 +0000 (18:55 +0000)]
Merge "BBS Apex Policy vendor --> manufacturer and other"

5 years agoRemoving rpm build option from apex-pdp 26/89526/1
ramverma [Thu, 6 Jun 2019 14:44:52 +0000 (14:44 +0000)]
Removing rpm build option from apex-pdp

Removing the commented rpm profile from pom of apex-pdp-package-full as
the rpm build is no longer needed. Also, in ONAP build servers the rpm
package is missing which leads to build failure.
However, I have created a wiki under Policy R5 collboration area to
document the steps needed to generate a rpm build if needed in fture.

Change-Id: Ie3703f7bcf7b07d23c2d9de813583c29ea2af720
Issue-ID: POLICY-1121
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoBBS Apex Policy vendor --> manufacturer and other 10/89510/1
s00370346 [Thu, 6 Jun 2019 12:57:25 +0000 (18:27 +0530)]
BBS Apex Policy vendor --> manufacturer and other

Issue-ID: POLICY-1831
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
Change-Id: Ib1e60287c6209e1f16764d071e28facc75a12c6e

5 years agoFix apex docker chmod 77/89177/2
jrh3 [Tue, 4 Jun 2019 15:02:43 +0000 (11:02 -0400)]
Fix apex docker chmod

The chmod in the docker builder for my local VM does not appear to
support the "+x" style options. Modified the apex docker
file to use "755" instead.

Issue-ID: POLICY-1829
Signed-off-by: jrh3 <jrh3@att.com>
Change-Id: I99faa8a31e92243bcc28207afba40b2b680ba1bf

5 years agoRemove POLICY_APEX_PDP_HOME in Dockerfile 21/89121/1
shaoqiu [Mon, 3 Jun 2019 07:08:41 +0000 (07:08 +0000)]
Remove POLICY_APEX_PDP_HOME in Dockerfile

To use POLICY_HOME not POLICY_XXX_HOME

Issue-ID: POLICY-1702
Change-Id: I145164f662d2d0fdd94875e8bcacd4f7a669309a
Signed-off-by: shaoqiu <tim.huang@est.tech>
5 years agoBump apex-pdp to version 2.2.0 38/88938/1
Jim Hahn [Thu, 30 May 2019 17:04:05 +0000 (13:04 -0400)]
Bump apex-pdp to version 2.2.0

Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Iba1c6a80917a37cc63e2250a32df40046df9ee4f

5 years agoUpdate Apex PDP Documentation 54/88354/1
a.sreekumar [Thu, 23 May 2019 13:44:09 +0000 (13:44 +0000)]
Update Apex PDP Documentation

Updating the Apex PDP documentation to support the new architecture.

Change-Id: Ice4d91080d57504d10db24ada08757ae3d03afd3
Issue-ID: POLICY-1682
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoUpdate INFO.yaml to add Jim and Ram 59/88259/1
liamfallon [Wed, 22 May 2019 14:42:18 +0000 (14:42 +0000)]
Update INFO.yaml to add Jim and Ram

Issue-ID: POLICY-1775
Change-Id: I5d3b555c6a089c7562d8b00584a5b3e2a616f880
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoupdate apexApps.sh to support JMX connection 55/88055/2
Hengye [Tue, 21 May 2019 02:51:57 +0000 (02:51 +0000)]
update apexApps.sh to support JMX connection

Issue-ID: POLICY-1781
Change-Id: Ic0dba48c67048dbafd4e2efa106b466f4dd4ca81
Signed-off-by: Hengye <yehui.wang@est.tech>
5 years agoStep snapshot version of apex-pdp 56/87856/1
liamfallon [Thu, 16 May 2019 09:46:58 +0000 (09:46 +0000)]
Step snapshot version of apex-pdp

Issue-ID: POLICY-1630
Change-Id: I6dfce7eb33d9bc41caabf6b8842377b486de672d
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoUpgrade to release policy/models 26/87726/1 2.1.0 4.0.0-ONAP
Pamela Dragosh [Wed, 15 May 2019 00:47:04 +0000 (20:47 -0400)]
Upgrade to release policy/models

Release 2.0.0

Issue-ID: POLICY-1630
Change-Id: I2ccca4576253d066e219c367097d98d9594730ea
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
5 years agoUpgrade policy/parent & policy/common in apex-pdp 36/87536/1
ramverma [Mon, 13 May 2019 10:45:00 +0000 (10:45 +0000)]
Upgrade policy/parent & policy/common in apex-pdp

Change-Id: If8120ba787fbd721f334c6f4d19df8d168ba9182
Issue-ID: POLICY-1630
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
5 years agoMerge "ONAP BBS Policy: CPE-Authentication event throwing error"
Pamela Dragosh [Thu, 9 May 2019 16:07:59 +0000 (16:07 +0000)]
Merge "ONAP BBS Policy: CPE-Authentication event throwing error"

5 years agoFix to accomodate recent changes in policy-models-tosca 48/87148/1
a.sreekumar [Tue, 7 May 2019 13:13:12 +0000 (13:13 +0000)]
Fix to accomodate recent changes in policy-models-tosca

Recent change in JpaToscaPolicy require corresponding changes in PDP-A as the code
was expecting a simple string earlier. This review contains the changes to fix
this

Change-Id: I3bbae264800b2c8bb8bdd61eae7b171028a85bc3
Issue-ID: POLICY-1739
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoONAP BBS Policy: CPE-Authentication event throwing error 83/86883/2
s00370346 [Fri, 3 May 2019 06:10:28 +0000 (11:40 +0530)]
ONAP BBS Policy: CPE-Authentication event throwing error

Issue-ID: POLICY-1734
Change-Id: I8d209afb67e9b46a7db516fce76977e679d7ab7b
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
5 years agoFix HTTPS configuration on PDP-A 95/86895/1
liamfallon [Fri, 3 May 2019 12:08:27 +0000 (12:08 +0000)]
Fix HTTPS configuration on PDP-A

This review enables HTTPS for health check on PDP-A

Issue-ID: POLICY-1732
Change-Id: I139a4c3ba043f978d1a75ae560037f713def1c1f
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoFix docker version for Apex 20/86720/1
liamfallon [Wed, 1 May 2019 14:53:46 +0000 (14:53 +0000)]
Fix docker version for Apex

Docker build is breaking, version of base alpine set in this
review. Changed to use version 1.4.0.

Issue-ID: INT-997
Change-Id: Icacb31e1fa9abef29930507fab7d53af125588e3
Signed-off-by: liamfallon <liam.fallon@est.tech>
5 years agoMerge "Rebase image on policy-base-alpine"
Liam Fallon [Tue, 30 Apr 2019 16:08:06 +0000 (16:08 +0000)]
Merge "Rebase image on policy-base-alpine"

5 years agoRebase image on policy-base-alpine 63/83463/4
Dmitry Puzikov [Mon, 25 Mar 2019 09:47:23 +0000 (10:47 +0100)]
Rebase image on policy-base-alpine

Issue-ID: INT-997
Change-Id: I1a39eaf9cc0fc546eafde10d0b81a90ed5d32b13
Signed-off-by: Dmitry Puzikov <dmitry.puzikov@tieto.com>
5 years agoUpdating the supportedPolicyTypes in config files 26/86526/1
a.sreekumar [Mon, 29 Apr 2019 14:06:04 +0000 (14:06 +0000)]
Updating the supportedPolicyTypes in config files

Changing the supportedPolicyTypes in apex-pdp configuration files
to "onap.policies.controlloop.operational.Apex"

Change-Id: Ie92d5284fbd80da48318ce7863471876ccb380bb
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
5 years agoMerge "ONAP BBS: Apex Nomadic ONT bug fixes"
Liam Fallon [Mon, 29 Apr 2019 11:43:01 +0000 (11:43 +0000)]
Merge "ONAP BBS:  Apex Nomadic ONT bug fixes"

6 years agoONAP BBS: Apex Nomadic ONT bug fixes 50/86150/7
s00370346 [Wed, 24 Apr 2019 13:40:05 +0000 (19:10 +0530)]
ONAP BBS:  Apex Nomadic ONT bug fixes

Issue-ID: DCAEGEN2-1237
Change-Id: Ibc1b5a221af5eb28799764498b2751d99f5764f3
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
6 years agoChanges to fix PDP-A not going to ACTIVE state 72/86272/2
a.sreekumar [Thu, 25 Apr 2019 12:29:06 +0000 (12:29 +0000)]
Changes to fix PDP-A not going to ACTIVE state

PDP-A state will now change to ACTIVE even when the policy list is
empty.
When the state is ACTIVE and PAP sends a PDP_UPDATE with policies, PDP-A
will start executing the policies.

Change-Id: Icb5b139939698920d4fa3991dcca33536c6caefc
Issue-ID: POLICY-1674
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoMerge "ONAP BBS: Apex Nomadic ONT bug fixes"
Jorge Hernandez [Mon, 22 Apr 2019 17:38:54 +0000 (17:38 +0000)]
Merge "ONAP BBS:  Apex Nomadic ONT bug fixes"

6 years agoONAP BBS: Apex Nomadic ONT bug fixes 25/85625/2
s00370346 [Wed, 17 Apr 2019 18:02:08 +0000 (23:32 +0530)]
ONAP BBS:  Apex Nomadic ONT bug fixes

Issue-ID: DCAEGEN2-1237
Change-Id: I739f8e55113793f5cd4d3b70e0a1296d775bb414
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
6 years agoAdd DMaaP sim configuration files 95/85595/1
liamfallon [Wed, 17 Apr 2019 13:58:47 +0000 (13:58 +0000)]
Add DMaaP sim configuration files

Add configurtion files that work with the DMaaP simulator.

Issue-ID: POLICY-1643
Change-Id: I719f9db4ec5273a32ba350811eb39b4238002341
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoMerge "ONAP BBS: Apex Nomadic ONT Policy Implementation"
Pamela Dragosh [Tue, 16 Apr 2019 16:05:51 +0000 (16:05 +0000)]
Merge "ONAP BBS: Apex Nomadic ONT Policy Implementation"

6 years agoBug fix as per Jim's comment 88/85488/2
a.sreekumar [Tue, 16 Apr 2019 15:32:46 +0000 (15:32 +0000)]
Bug fix as per Jim's comment

Changing the PdpUpdate already handled check back to previous code.

Change-Id: Icc195b5a8609fba8601dc151f62fdaf0c67b7be0
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoMerge "One year cert with new component names"
Pamela Dragosh [Tue, 16 Apr 2019 13:34:38 +0000 (13:34 +0000)]
Merge "One year cert with new component names"

6 years agoMerge "Fix Security and Unit Test DB issues"
Pamela Dragosh [Tue, 16 Apr 2019 13:32:48 +0000 (13:32 +0000)]
Merge "Fix Security and Unit Test DB issues"

6 years agoFix Security and Unit Test DB issues 48/85448/2
liamfallon [Tue, 16 Apr 2019 11:20:08 +0000 (11:20 +0000)]
Fix Security and Unit Test DB issues

This review removes more links to the Zookeeper version 3.5.4-beta with
Zookeeper version 3.4.14.

It also replaces the Derby in-memory database with the H2 in memory
database for unit tests.

Issue-ID: POLICY-1540
Change-Id: Ic44f2e866644114b7c0cf66aac7e528017b8206b
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoChanges for RestServer support and some sonar fix 48/85348/3
a.sreekumar [Tue, 16 Apr 2019 09:40:48 +0000 (09:40 +0000)]
Changes for RestServer support and some sonar fix

1) Changes to add RestServer to the PDP-A for healthcheck.
2) Adding Junit testcases.
3) Fixing some sonar issues.
4) Fixing checkstyle issues.

Change-Id: I03530190c733432d219284dda9d9d4cc32ab0773
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoOne year cert with new component names 79/85379/1
jhh [Mon, 15 Apr 2019 23:15:30 +0000 (18:15 -0500)]
One year cert with new component names

Change-Id: Ia3025f2a0eada4f53623bb45d5849ceddf368925
Issue-ID: POLICY-1580
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
6 years agoONAP BBS: Apex Nomadic ONT Policy Implementation 27/84927/2
s00370346 [Wed, 10 Apr 2019 18:44:39 +0000 (00:14 +0530)]
ONAP BBS: Apex Nomadic ONT Policy Implementation

Issue-ID: DCAEGEN2-1237
Change-Id: I81831f6498b6c47c0a43215e0445c791b12dac6e
Signed-off-by: s00370346 <swarup.nayak1@huawei.com>
6 years agoFix security problem with Zookeeper 38/85338/1
liamfallon [Mon, 15 Apr 2019 15:31:55 +0000 (15:31 +0000)]
Fix security problem with Zookeeper

Issue-ID: POLICY-1540
Change-Id: I5c549a1dffb21b54c81a44ba69ca49cb24732558
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoChanges for packaging services-onappf and some refactoring 54/85054/2
a.sreekumar [Thu, 11 Apr 2019 16:56:29 +0000 (16:56 +0000)]
Changes for packaging services-onappf and some refactoring

1) Added the code for packaging PDP-A.
2) Updating the package names.
3) Updating the dependencies in services-onappf. Some dependencies can
be removed as they are brought in while packaging.
4) Some other minor changes.

Change-Id: Idf62d7854f3435806a9e8aa975138fbfd45e3ea8
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoRemove hibernate from apex 02/84902/1
liamfallon [Wed, 10 Apr 2019 16:18:43 +0000 (16:18 +0000)]
Remove hibernate from apex

Issue-ID: POLICY-1368
Change-Id: I67f448fc9d89eef4829cd6f999f5c21ac8ebff12
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoMerge "Some changes and bug fixes for PdpMessage handling"
Jorge Hernandez [Wed, 10 Apr 2019 14:46:18 +0000 (14:46 +0000)]
Merge "Some changes and bug fixes for PdpMessage handling"

6 years agoFix Kafka partiion support in APEX 71/84871/1
liamfallon [Wed, 10 Apr 2019 12:52:37 +0000 (12:52 +0000)]
Fix Kafka partiion support in APEX

The kafka producer property â€˜partitioner.class’ should be configurable via
the EngineConfig.json file so that a specialized or custom Kafka partitioner
can be used.

Issue-ID: POLICY-1627
Change-Id: Ic36ccdf3d244ab932b58c3e2ae1cd668249726c5
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoSome changes and bug fixes for PdpMessage handling 46/84746/1
a.sreekumar [Tue, 9 Apr 2019 20:48:32 +0000 (20:48 +0000)]
Some changes and bug fixes for PdpMessage handling

1) Updating pom file of services-onappf to fix dependency related
issues.
2) Some changes to accomodate recent updates.
3) Fix for some issues identified during testing.

Change-Id: I8150ed9858902ebbe12321a793770df3fdc7e773
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoChanges to handle PdpUpdate and PdpStateChange messages 57/84257/5
a.sreekumar [Mon, 8 Apr 2019 12:38:21 +0000 (12:38 +0000)]
Changes to handle PdpUpdate and PdpStateChange messages

1) Adding listeners and handlers for PdpUpdate messages.
2) Adding listeners and handlers for PdpStateChange messages.
3) Some changes to accomodate recent changes in the models.
4) Test cases.

Change-Id: I66644d94fd2a242738d9b0f78e5d0ece76342057
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoChanges to send pdp status messages 97/83597/3
a.sreekumar [Tue, 2 Apr 2019 09:09:51 +0000 (09:09 +0000)]
Changes to send pdp status messages

1) Adding handlers to create and send pdp status messages from apex-pdp.
2) Changes to read initial pdp status parameters from configuration
file.
3) Adding test cases.

Change-Id: Id2d1caa8abc124865a9ef8fbfe4d9f751e4491b5
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoMerge "Change vCPE example to use POJOs"
Liam Fallon [Mon, 1 Apr 2019 00:35:11 +0000 (00:35 +0000)]
Merge "Change vCPE example to use POJOs"

6 years agoChange vCPE example to use POJOs 86/69986/31
liamfallon [Mon, 8 Oct 2018 12:36:31 +0000 (13:36 +0100)]
Change vCPE example to use POJOs

This review uses POJOs rather than Avro schema to unmarshal
and marshal events from and to DMaaP.

The POJO classes for interacting with DMaaP have been moved into
a common policy module.

This review is now ready for full review (finally!).

Issue-ID: POLICY-954
Change-Id: Ibb89d8af5b9006821e6a0a756e16bbe3815af15a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: Liam Fallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoAdding services-onappf module to apex-pdp 55/83355/1
a.sreekumar [Tue, 26 Mar 2019 13:54:45 +0000 (13:54 +0000)]
Adding services-onappf module to apex-pdp

1) Adding services-onappf module to apex-pdp.
2) Following the code base from policy/pap to build the module.
3) Currently PAP is using property & configuration file for bootstrap.
Continuing the same in this module as well.
4) Adding relevant test cases.

Change-Id: Id9740ea60ae3ecbd88e5d6d3586ee0dde1054cca
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
6 years agoFix checkstyle/Sonar issues on juint/sonar fixes 71/82671/1
liamfallon [Tue, 19 Mar 2019 12:52:20 +0000 (12:52 +0000)]
Fix checkstyle/Sonar issues on juint/sonar fixes

Recent changes to increase code coverage and fox Sonar bugs have
introduced checkstyle and further Sonar issues. This review
cleans those up.

Issue-ID: POLICY-1523
Change-Id: I829217ef77d52e57f9713cfeee5b122e1f25efbc
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoUse Assertions class from policy-common 72/79372/4
liamfallon [Tue, 19 Mar 2019 01:16:38 +0000 (01:16 +0000)]
Use Assertions class from policy-common

Change import line in all classes that use
the Assertions class, there are a lot of them.

Issue-ID: POLICY-1264
Change-Id: I8480264be4e36348b3fc63acf1bc36e9c9dd250b
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoAdd NSS libraries to images 34/82534/1
Jorge Hernandez [Sun, 17 Mar 2019 05:43:21 +0000 (00:43 -0500)]
Add NSS libraries to images

Alpine OpenJDK was updated 2 days ago (3/14), this
upgrade seems to break java applications that depend on libnss*.so
OS libraries, which seem are no longer installed with the jdk.

Added some other libraries to aid when debugging.

Change-Id: I80ba6a4e145f107219f4380da1cb90ede5ccc056
Issue-ID: POLICY-1604
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
6 years agoUpdate INFO.yaml file 86/82486/1
Jessica Wagantall [Fri, 15 Mar 2019 20:53:25 +0000 (13:53 -0700)]
Update INFO.yaml file

Update missing information blocks and
indentation to pass verify job.

Change-Id: I65eddd59fb920f656f20e696968e69c1bdf8e3df
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoMerge "reduce too many method param"
Jorge Hernandez [Thu, 14 Mar 2019 13:50:23 +0000 (13:50 +0000)]
Merge "reduce too many method param"

6 years agoreduce too many method param 08/81908/2
Arindam Mondal [Mon, 11 Mar 2019 06:40:58 +0000 (15:40 +0900)]
reduce too many method param

Issue-ID: POLICY-1535
Change-Id: Ia6f699d315ebd214257dc64d559a0ac4685307f5
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
6 years agoFix sonar code smell issues in apex-pdp 14/81914/2
Parshad Patel [Mon, 11 Mar 2019 07:55:06 +0000 (16:55 +0900)]
Fix sonar code smell issues in apex-pdp

Fix method has more than 7 parameters issues

Issue-ID: POLICY-1535
Change-Id: I12d995e323bbdbe3762c903fcb116dfe81bf7b54
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoMerge "Increase test coverage for plugins-event-carrier"
Liam Fallon [Fri, 8 Mar 2019 13:49:51 +0000 (13:49 +0000)]
Merge "Increase test coverage for plugins-event-carrier"

6 years agoIncrease test coverage for plugins-event-carrier 35/81835/1
Parshad Patel [Fri, 8 Mar 2019 08:09:57 +0000 (17:09 +0900)]
Increase test coverage for plugins-event-carrier

Add basic JUnit test cases for plugins-event-carrier-restserver

Issue-ID: POLICY-1513
Change-Id: I36e41bd05be71c44eb9e94350f4614437b0d205b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoMerge "Increase test coverage for plugins-executor-js"
Jorge Hernandez [Thu, 7 Mar 2019 15:06:23 +0000 (15:06 +0000)]
Merge "Increase test coverage for plugins-executor-js"

6 years agoMerge "Increase test coverage for plugins-event"
Liam Fallon [Wed, 6 Mar 2019 13:58:47 +0000 (13:58 +0000)]
Merge "Increase test coverage for plugins-event"

6 years agoIncrease test coverage for plugins-executor-js 29/79429/2
Hengye [Wed, 6 Mar 2019 05:14:13 +0000 (05:14 +0000)]
Increase test coverage for plugins-executor-js

Add junit test cases into apex-pdp/plugins/plugins-executor-javascript

Issue-ID: POLICY-1523
Change-Id: Ie8017be2f7507fdb641a4020e13152c656cadf04
Signed-off-by: Hengye <yehui.wang@est.tech>
6 years agoIncrease test coverage for plugins-event 41/79241/4
Parshad Patel [Wed, 27 Feb 2019 01:37:57 +0000 (10:37 +0900)]
Increase test coverage for plugins-event

Add JUnit test cases for plugins-event-carrier-websocket

Issue-ID: POLICY-1513
Change-Id: I5f2a8dacfff4c14cf4a24e9258b5a551cecc1489
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoMerge "Increase test coverage for plugins-executor-mvel"
Pamela Dragosh [Fri, 1 Mar 2019 13:13:00 +0000 (13:13 +0000)]
Merge "Increase test coverage for plugins-executor-mvel"

6 years agoMerge "Increase test coverage for plugins-executor-jruby"
Pamela Dragosh [Fri, 1 Mar 2019 13:12:11 +0000 (13:12 +0000)]
Merge "Increase test coverage for plugins-executor-jruby"

6 years agoMerge "Use Alpine as base docker image"
Pamela Dragosh [Fri, 1 Mar 2019 12:56:58 +0000 (12:56 +0000)]
Merge "Use Alpine as base docker image"

6 years agoMerge "Increase test coverage for plugins-executor-jython"
Pamela Dragosh [Thu, 28 Feb 2019 19:27:27 +0000 (19:27 +0000)]
Merge "Increase test coverage for plugins-executor-jython"

6 years agoMerge "Fix checkstyle problems on sonar fix"
Jorge Hernandez [Thu, 28 Feb 2019 17:49:41 +0000 (17:49 +0000)]
Merge "Fix checkstyle problems on sonar fix"

6 years agoMerge "Update INFO.yaml Liam's email"
Liam Fallon [Thu, 28 Feb 2019 17:09:18 +0000 (17:09 +0000)]
Merge "Update INFO.yaml Liam's email"

6 years agoUpdate INFO.yaml Liam's email 73/79373/1
Pamela Dragosh [Thu, 28 Feb 2019 15:31:19 +0000 (10:31 -0500)]
Update INFO.yaml Liam's email

est.tech

Issue-ID: POLICY-1556
Change-Id: I1088e64016a15161ec979bf8de1af35835fa3c83
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
6 years agoFix checkstyle problems on sonar fix 71/79371/1
liamfallon [Tue, 26 Feb 2019 14:39:32 +0000 (14:39 +0000)]
Fix checkstyle problems on sonar fix

A sonar fix brought in some minor checkstyle issues. This
review fixes those.

Issue-ID: POLICY-1535
Change-Id: I4f9d66ffc0a4fcc8901d7e18bfb21a1d1cf135b7
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoUse Alpine as base docker image 51/79251/2
Hengye [Thu, 28 Feb 2019 08:03:50 +0000 (08:03 +0000)]
Use Alpine as base docker image

change docker base image from ubuntu 16.04 to Alpine 3.9

Issue-ID: POLICY-1555
Change-Id: Ia21f5e8185bd26f4b04276eed204ac358f655a59
Signed-off-by: Hengye <yehui.wang@est.tech>
6 years agoIncrease test coverage for plugins-executor-jython 39/79239/2
ning.xi [Thu, 28 Feb 2019 03:01:19 +0000 (03:01 +0000)]
Increase test coverage for plugins-executor-jython

Add junit test cases into apex-pdp/plugins/plugins-executor-jython

Issue-ID: POLICY-1523
Change-Id: I2545a9cefc6b4b9a53200b98081ddd8bc8274b40
Signed-off-by: ning.xi <ning.xi@est.tech>
6 years agoIncrease test coverage for plugins-executor-jruby 37/79237/2
shaoqiu [Thu, 28 Feb 2019 02:56:02 +0000 (02:56 +0000)]
Increase test coverage for plugins-executor-jruby

Add junit test cases into apex-pdp/plugins/plugins-executor-jruby

Issue-ID: POLICY-1523
Change-Id: I2ed06a69cf991d744aa5c4c69f605fdf1dca6524
Signed-off-by: shaoqiu <tim.huang@est.tech>
6 years agoIncrease test coverage for plugins-executor-mvel 36/79236/4
Hengye [Thu, 28 Feb 2019 02:32:56 +0000 (02:32 +0000)]
Increase test coverage for plugins-executor-mvel

Add junit test cases into apex-pdp/plugins/plugins-executor-mvel

Issue-ID: POLICY-1523
Change-Id: I74d47974a326c7fbd53a0b7d88262ef1dbd54c8c
Signed-off-by: Hengye <yehui.wang@est.tech>
6 years agoMerge "Fix sonar code smell"
Jorge Hernandez [Wed, 27 Feb 2019 14:55:59 +0000 (14:55 +0000)]
Merge "Fix sonar code smell"

6 years agoMerge "Increase test coverage for plugins-event"
Jorge Hernandez [Tue, 26 Feb 2019 19:20:22 +0000 (19:20 +0000)]
Merge "Increase test coverage for plugins-event"

6 years agoIncrease test coverage for plugins-event 45/79145/1
Parshad Patel [Tue, 26 Feb 2019 02:06:52 +0000 (11:06 +0900)]
Increase test coverage for plugins-event

Add basic JUnit test cases for plugins-event-carrier-jms

Issue-ID: POLICY-1513
Change-Id: I68fa36bc988745108014f47a57fc02bc2ceed0c7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoMerge "sonar:reduce number of method param"
Pamela Dragosh [Mon, 25 Feb 2019 20:03:28 +0000 (20:03 +0000)]
Merge "sonar:reduce number of method param"

6 years agosonar:reduce number of method param 06/78806/2
Arindam Mondal [Wed, 20 Feb 2019 07:28:26 +0000 (16:28 +0900)]
sonar:reduce number of method param

Changes done according to sonar recommendation.

Issue-ID: POLICY-1535
Change-Id: I57a608e4db1b67959cbabe23e7fe0b1aa91e30cd
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
6 years agoFix checkstyle errors on tests 63/79063/1
liamfallon [Sat, 23 Feb 2019 20:01:28 +0000 (20:01 +0000)]
Fix checkstyle errors on tests

Issue-ID: POLICY-1513
Change-Id: Id61df043adf398a0493916f6116ff5858c60fb29
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoChange versions of Zookeeper and C3P0 75/78975/2
liamfallon [Fri, 22 Feb 2019 17:30:59 +0000 (17:30 +0000)]
Change versions of Zookeeper and C3P0

This review changes the versions of Zookeeper and C3P0 to
resolve security issues.

It also merges the context test utils module into the context test because that
module was misplaced and put an incompatible Zookeeper dependency in the
APEX context module.

Issue-ID: POLICY-1540
Change-Id: I86048ae1fc8b818611f423d6fd1f4a9fcc3f76f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agocorrect a typo in doc APEX User Manual 01/78901/1
Hengye [Thu, 21 Feb 2019 09:24:25 +0000 (09:24 +0000)]
correct a typo in doc APEX User Manual

Issue-ID: POLICY-1523
Change-Id: I44675a5119170ab724926ba08a3bfceefda31b57
Signed-off-by: Hengye <yehui.wang@est.tech>
6 years agoIncrease test coverage for apex-pdp/plugins 97/78797/1
Parshad Patel [Wed, 20 Feb 2019 02:38:16 +0000 (11:38 +0900)]
Increase test coverage for apex-pdp/plugins

Add basic JUnit test cases for plugins-event-carrier-kafka

Issue-ID: POLICY-1513
Change-Id: I009547115705496a850a9609416cdf71f52fb936
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoFix sonar code smell 36/78636/3
Arindam Mondal [Mon, 18 Feb 2019 09:27:51 +0000 (18:27 +0900)]
Fix sonar code smell

Issue-ID: POLICY-1523
Change-Id: I24f9fe5811bb93597efe79c98572c5249e74026c
Signed-off-by: arindamm <arind.mondal@samsung.com>
6 years agoFix bug with Apex rejecting HTTP 2xx responses 93/77893/1
liamfallon [Tue, 5 Feb 2019 17:37:24 +0000 (17:37 +0000)]
Fix bug with Apex rejecting HTTP 2xx responses

APEX rejects all HTTP responses except 200. This change accepts
any HTTP 2xx response code as a valid response.

Issue-ID: POLICY-1289
Change-Id: Ief681ba4dac1ef3ff5f257dd931569bd2274d017
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoFix version warning in apex pom 96/75996/1
ramverma [Fri, 18 Jan 2019 15:17:12 +0000 (15:17 +0000)]
Fix version warning in apex pom

Change-Id: Ia3b7fa204fb8564b679a4416fcc0f70fa0a9a54f
Issue-ID: POLICY-1074
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
6 years agoFix crashing unit tests in Apex 26/75826/1
liamfallon [Tue, 15 Jan 2019 15:54:45 +0000 (15:54 +0000)]
Fix crashing unit tests in Apex

Issue-ID: POLICY-1403
Change-Id: Ie9d2cc46f3daf4d6b2eb2774a8be8c35e0c45754
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoUpdate comment to check Sonar build issue 09/75809/1
liamfallon [Tue, 15 Jan 2019 10:59:15 +0000 (10:59 +0000)]
Update comment to check Sonar build issue

Issue-ID: POLICY-1403
Change-Id: I87ebf85dbbe8544e38666e8e793a8e1cbbcfc7c6
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoUse parent version of Eclipselink 68/75668/1
liamfallon [Fri, 11 Jan 2019 10:51:50 +0000 (10:51 +0000)]
Use parent version of Eclipselink

Issue-ID: POLICY-1360
Change-Id: I33d8cef3f5d273c0c2a93ecda321205316aea6de
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoFix context clearing on model upgrade 59/75559/3
liamfallon [Wed, 9 Jan 2019 13:30:23 +0000 (14:30 +0100)]
Fix context clearing on model upgrade

Existing context is cleared when a model upgrade is carried out
on an Apex PDP. The clear() method is called in error on the
Apex engine during the upgrade.

This change also has some small updates to the DecisionMaker example,
which is used to test this feature.

Issue-ID: POLICY-1395
Change-Id: I547a3a60712d1572d9daadf5eab4afcae2a5c321
Signed-off-by: liamfallon <liam.fallon@est.tech>
6 years agoRename test classes in apex-pdp/services 82/75082/1
Parshad Patel [Wed, 26 Dec 2018 05:54:59 +0000 (14:54 +0900)]
Rename test classes in apex-pdp/services

Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes

Issue-ID: POLICY-1263
Change-Id: I951f4e30736144010d69a0fb3b9181f7fee76013
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
6 years agoMerge "Rename test classes in apex-pdp/model,core"
Liam Fallon [Fri, 21 Dec 2018 17:26:57 +0000 (17:26 +0000)]
Merge "Rename test classes in apex-pdp/model,core"

6 years agoRename test classes in apex-pdp/model,core 46/75046/1
Parshad Patel [Fri, 21 Dec 2018 06:36:35 +0000 (15:36 +0900)]
Rename test classes in apex-pdp/model,core

Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes

Issue-ID: POLICY-1263
Change-Id: I6cb8d09799d7abd1b50ead1edbc4986649ad4ba7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>