liamfallon [Fri, 11 Feb 2022 00:43:14 +0000 (00:43 +0000)]
Remove apex-pdp unused core modules
This is the final review in the refactoring of the model code in
apex-pdp.
The core-messaging and core-infrastructure modules are unused in
apex-pdp except for websocket communication. Websocket communication is
also not used in any deployment.
This review:
- removes the core-mesaging module, which had an apex-specific websocket
implementation, except for the MessageException class, which is moved
to the base core module
- removes the core-infrastructure module, except for the ThreadUtils
class, which is moved to the base core module
- removes the websocket event protocol, which used core-messaging but is
not used in any deployment
- collapses all three "core" submodules into a single module
- Updates dependencies where needed
Issue-ID: POLICY-1820
Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 10 Feb 2022 12:06:25 +0000 (12:06 +0000)]
Collapse apex-pdp maven model submodules
This review collapses all the code in six podel submodules into a single
model module. There are no code changes, just files moved around.
This change reduces the complexity of the code structure and speeds up
the build.
Issue-ID: POLICY-1820
Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Thu, 10 Feb 2022 13:18:43 +0000 (13:18 +0000)]
Merge "rename metrics as per global constants for prometheus"
Rashmi Pujar [Thu, 27 Jan 2022 03:39:11 +0000 (22:39 -0500)]
rename metrics as per global constants for prometheus
Issue-ID: POLICY-3760
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I0fb59e8d9c95fd81a1754bb769705ef753b9022d
Jorge Hernandez [Wed, 9 Feb 2022 19:04:25 +0000 (19:04 +0000)]
Merge "Remove JAXB and XML, use GSON for JSON"
liamfallon [Mon, 7 Feb 2022 17:56:44 +0000 (17:56 +0000)]
Remove JAXB and XML, use GSON for JSON
This review converst apex-pdp to use GSON for JSON handling. In order to
preserve backward compatibility with the JAXB format of JSON, custom
handling of maps was required. Therefore, the policy-common
StandardCoder could not be used.
There are a lot of small changes, removing annotations from concepts and
tweaking of test data. However, this cleans up the code base so it is
worth doing.
Issue-ID: POLICY-1820
Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0
Signed-off-by: liamfallon <liam.fallon@est.tech>
Rashmi Pujar [Tue, 25 Jan 2022 23:08:09 +0000 (18:08 -0500)]
Expose APEX policy execution metrics
Testing of these metrics will be covered in CSIT.
Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I8aed49d113f071ab33691f8cf1df624f3358386a
liamfallon [Fri, 4 Feb 2022 10:34:28 +0000 (10:34 +0000)]
Remove JPA annotations from apex-pdp code
This review is part of a series of reviews to move the apex-pdp state
machine model to use the base model types in policy models.
Persistence of policies for apex-pdp is now implemented in PAP and API.
The historic direct load and save functionality for APEX policy state
machine models to and from databases is no longer used and no longer
supported.
This commit removes JPA annotations form apex-pdp code.
Subsequent reviews will mvoe the mdoel across to use the policy models
base model types.
Issue-ID: POLICY-1820
Change-Id: I91a45a0ca6c88f9ba4b201bad920065f95ffb31e
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 3 Feb 2022 12:01:57 +0000 (12:01 +0000)]
Remove direct DB Load/Save from apex-pdp
This review is part of a series of reviews to move the apex-pdp state
machine model to use the base model types in policy models.
Persistence of policies for apex-pdp is now implemented in PAP and API.
The historic direct load and save functionality for APEX policy state
machine models to and from databases is no longer used and no longer
supported.
This revmoves the DAO code from apex-pdp and the associated handling
and test code.
The next review will remove the JPA annotations.
Subsequent reviews will mvoe the mdoel across to use the policy models
base model types.
Issue-ID: POLICY-1820
Change-Id: Iabf034b40a413d32fe62091fe3446f52ec30d3af
Signed-off-by: liamfallon <liam.fallon@est.tech>
waynedunican [Tue, 16 Nov 2021 08:44:43 +0000 (08:44 +0000)]
Remove references to MariaDB from resource files
Issue-ID: POLICY-2086
Change-Id: If38af6a319211c96f8be94f32551dc00b91d6ed1
Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
Liam Fallon [Wed, 26 Jan 2022 09:52:27 +0000 (09:52 +0000)]
Merge "Fix intermittent build test error"
saul.gill [Tue, 25 Jan 2022 13:40:27 +0000 (13:40 +0000)]
Fix intermittent build test error
Error visible intermittently in CLM builds
Changed running order of assertions to fix
Intermittent error no loger observed
Issue-ID: POLICY-3893
Change-Id: I27e2c33f298e10f8b9dda85a015258db105043b7
Signed-off-by: saul.gill <saul.gill@est.tech>
Liam Fallon [Tue, 25 Jan 2022 14:13:11 +0000 (14:13 +0000)]
Merge "Add TOSCA policy status header field to APEX event create CLI"
Rashmi Pujar [Sat, 22 Jan 2022 05:37:28 +0000 (00:37 -0500)]
Add TOSCA policy status header field to APEX event create CLI
In order to expose the processing status of a TOSCA policy
to APEX-PDP, a new header field for APEX concept "event"
has been introduced to track this within an APEX policy
implementation. This field will be leveraged to extract
the TOSCA policy execution metrics. Note, that the field is
marked as optional for backward compatibility.
Unit tests have been augmented to test for the field wherever
applicable and the default empty value is retained for the others.
"example-grpc" module has been updated to include this field.
Exposing the TOSCA policy execution metrics is outside the
scope of this patch since the current changes are already
very large owing to the atomic nature of the change introduced.
Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: Ief6d70f9abcfc8414e10aa51a27815ee9028e4c8
liamfallon [Tue, 18 Jan 2022 10:39:06 +0000 (10:39 +0000)]
Update to SECCOM recommended dependencies
SECCOM has issued a directive on which dependencies should be used, see
this wiki page:
https://wiki.onap.org/display/SV/Jakarta+Policy
This is the policy parent review to comply with the SECCOM directive.
Zookeeper is added as a test dependency, it is no longer pulled in as a
transitive dependency by Kafka.
Issue-ID: POLICY-3849
Change-Id: Id504b308cd4e806e9e2e9489842abf1a7f93b9dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 12 Jan 2022 16:36:45 +0000 (16:36 +0000)]
Add newline to end of POM file
If the new line is not there, then it breaks the release scripts because
the line count is off.
Issue-ID: POLICY-3835
Change-Id: Ie18070c844d8138b7c6eb4dd74b1c46cfe132846
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Wed, 12 Jan 2022 09:06:24 +0000 (09:06 +0000)]
Merge "Prometheues metrics for APEX engine stats"
Rashmi Pujar [Fri, 7 Jan 2022 06:38:40 +0000 (01:38 -0500)]
Prometheues metrics for APEX engine stats
Issue-ID: POLICY-3846
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I385446683372548f3fed6d609a9e85633ec2916d
liamfallon [Thu, 6 Jan 2022 14:32:33 +0000 (14:32 +0000)]
Exclude log4j test dependency
There is a transitive test dependency in apex-pdp on log4j, doesn't show
up in the CLM reports (because it is a test dependency). Removing the
dependency.
Issue-ID: POLICY-3862
Change-Id: Ic9121cf4405678efcf805f711ccb9f36269178d3
Signed-off-by: liamfallon <liam.fallon@est.tech>
Liam Fallon [Fri, 3 Dec 2021 11:23:42 +0000 (11:23 +0000)]
Merge "Prometheus metrics for policy deploy/undeploy requests for APEX"
liamfallon [Thu, 2 Dec 2021 15:54:04 +0000 (15:54 +0000)]
Update snapshot and/or references of policy/apex-pdp to latest snapshots
*** This commit is generated by a PF release script ***
policy/apex-pdp updated to its latest own and reference snapshots
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ifbca56e3e4f3d166e633a2c56f55615aa4bfec6b
Rashmi Pujar [Fri, 26 Nov 2021 12:44:23 +0000 (07:44 -0500)]
Prometheus metrics for policy deploy/undeploy requests for APEX
Added counters for:
- Policy deploy/undeploy requests total
- Policy deploy/undeploy successful requests total
- Policy deploy/undeploy failed requests total
Cleaned up unused method resetAllStatistics.
Fixed some checkstyle warnings
Update to latest snapshot for parent, and common modules
Depends on https://gerrit.onap.org/r/c/policy/parent/+/125974 for build to pass.
Issue-ID: POLICY-3760
Change-Id: I4a9447c9caea7a018dba86057b9dae3871910709
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
liamfallon [Mon, 29 Nov 2021 11:33:31 +0000 (11:33 +0000)]
Update snapshot of policy/apex-pdp to 2.7.1-SNAPSHOT
*** This commit is generated by a PF release script ***
policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead
liamfallon [Fri, 26 Nov 2021 12:07:42 +0000 (12:07 +0000)]
Release docker images for policy/apex-pdp: 2.7.0
*** This commit is generated by a PF release script ***
This commit releases the docker images for repo policy/apex-pdp.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I97c7fdc4118f24c1f72b1028b7d734ccffd5ad7b
liamfallon [Fri, 26 Nov 2021 10:41:47 +0000 (10:41 +0000)]
Release policy/apex-pdp: 2.7.0
*** Release Phase 8: This commit is generated by a PF release script ***
This is the eigth phase in releasing images, it releases policy/apex-pdp.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I4df10a4c1331f0f2309282743af8455001c8af9f
liamfallon [Thu, 25 Nov 2021 15:50:38 +0000 (15:50 +0000)]
Update parent,common.models and docker references
*** Release Phase 7: This commit is generated by a PF release script ***
This is the seventh release phase, it updates parent, common and models
references in policy/apex-pdp.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I501aab4ddf6dbf2ed6700f2ecbf7da80ecaadf3d
liamfallon [Thu, 25 Nov 2021 11:41:13 +0000 (11:41 +0000)]
Update parent and common references
*** Release Phase 7: This commit is generated by a PF release script ***
This is the seventh release phase, it updates parent, common and models
references in policy/apex-pdp.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I78c4e212e6c330d8a1549038f4c1ec47d6f2b4df
Ram Krishna Verma [Mon, 25 Oct 2021 22:12:16 +0000 (18:12 -0400)]
Point to snapshot dependency
Issue-ID: POLICY-3788
Change-Id: Ia18be8148b1565dff8cb240026ac0ccf280df169
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
lapentafd [Mon, 18 Oct 2021 09:06:31 +0000 (10:06 +0100)]
HTTP code filter for RestClientProducer
RestClient producer can now consider 2xx response status as success
Issue-ID: POLICY-3743
Change-Id: I40c4dce01b437ea6b9f9bbc317835657cb7ebc8a
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
a.sreekumar [Thu, 14 Oct 2021 10:15:57 +0000 (11:15 +0100)]
Bump policy/apex-pdp to Jakarta 2.7.0-SNAPSHOT
Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Thu, 14 Oct 2021 09:24:25 +0000 (10:24 +0100)]
Bump policy/apex-pdp to 2.6.2-SNAPSHOT
Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Thu, 14 Oct 2021 08:55:16 +0000 (09:55 +0100)]
Release apex-pdp 2.6.1 docker artifacts
Change-Id: I9cca081a9274922b79c87a1b0e8a96e66d9c4154
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 13 Oct 2021 17:46:11 +0000 (18:46 +0100)]
Release apex-pdp 2.6.1 maven artifacts
Change-Id: Id9ab217d3623f0726840895e31cb0b1c8fd7fbc7
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
liamfallon [Wed, 13 Oct 2021 14:29:52 +0000 (15:29 +0100)]
Update parent/common/models/docker references
Issue-ID: POLICY-3696
Change-Id: If4c5290890639fdf99de37501a134f820c92696b
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Fri, 8 Oct 2021 10:57:13 +0000 (11:57 +0100)]
APEX-PDP S3P changes for Istanbul
Change-Id: I58f564ef19df39f2c0fff64a72c9f083faf88556
Issue-ID: POLICY-3655
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 15 Sep 2021 11:05:24 +0000 (12:05 +0100)]
Bump apex-pdp to 2.6.1-SNAPSHOT
Change-Id: Ie39d324e02a302b882318d46735a727322ce409d
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 15 Sep 2021 10:24:23 +0000 (11:24 +0100)]
Release apex-pdp 2.6.0 docker image
Change-Id: I499837227ddf4ad3df0366763d4aa73c489db78a
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 15 Sep 2021 09:44:47 +0000 (10:44 +0100)]
Release apex-pdp 2.6.0 maven artifacts
Change-Id: I9a5887991442b40865be818fb876acea104de776
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
liamfallon [Mon, 13 Sep 2021 15:43:19 +0000 (16:43 +0100)]
Use released common and models
Issue-ID: POLICY-3587
Change-Id: I11a84934a1a0fc515bf0ae9af9105ba7df19549e
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 9 Sep 2021 20:52:29 +0000 (21:52 +0100)]
Remove blank line from INFO.yaml
Issue-ID: POLICY-3587
Change-Id: If2a9cffb84f8b3d8117a4a9cb338cb1b8964b6cf
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 9 Sep 2021 15:05:31 +0000 (16:05 +0100)]
Point at released policy-parent
Issue-ID: POLICY-3587
Change-Id: Iea42a1c281ffd3578a05e3601c0db9836c9d6dfc
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 8 Sep 2021 11:56:48 +0000 (12:56 +0100)]
Update INFO.yaml
Update the INFO.yaml file with latest information.
Issue-ID: POLICY-3552
Change-Id: Ic6842a0325f2f9d45fa769b75baefb0960e872e1
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 7 Sep 2021 14:40:54 +0000 (15:40 +0100)]
Use managed version of commons-codec
apex-pdp was using a very old version of commons-codec. This change
enables it to use the version of commons-codec managed from policy
parent.
Issue-ID: POLICY-3590
Change-Id: Ic29e46b61107719df5aaad00ee923de056fe7bac
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Thu, 2 Sep 2021 17:27:40 +0000 (13:27 -0400)]
Fix sonar security issues in apex-pdp
Fixed sonar security issues:
- set permissions of temporary files
Issue-ID: POLICY-3093
Change-Id: I1dfc87f22975fa950cfcfc47196fad55d6cbf277
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 1 Sep 2021 15:45:05 +0000 (11:45 -0400)]
Fix sonars in apex-pdp #3
Fixed:
- use "var"
- use assertEquals instead of assertTrue(xxx.equals())
- separate assertions
Issue-ID: POLICY-3093
Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Fri, 27 Aug 2021 20:53:11 +0000 (16:53 -0400)]
Fix sonar issues in apex-pdp
Issue-ID: POLICY-3077
Change-Id: Id5e7c2ddada2bac3b73fe543f9adade6f9b83e6c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 30 Aug 2021 15:03:16 +0000 (15:03 +0000)]
Merge "Fix sonars in apex-pdp #2"
liamfallon [Mon, 30 Aug 2021 13:26:22 +0000 (14:26 +0100)]
Use latest policy-parent snapshot
The parent snapshot enables the latest version of netty.
Issue-ID: POLICY-3590
Change-Id: I273c7e25988f6190d761ba4300eb56c9f02e3cee
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Fri, 27 Aug 2021 19:24:06 +0000 (15:24 -0400)]
Fix sonars in apex-pdp #2
plugins-events thru plugins-persistence-jpa-eclipselink
Fixed:
- use "var"
- disambiguate method parameter types
- rename parameter
Issue-ID: POLICY-3093
Change-Id: Ife5897015be495403e731754d5862b803a217c87
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 27 Aug 2021 18:49:41 +0000 (14:49 -0400)]
Address more sonars in apex-pdp
Fixed services-engine thru utilities.
Fixed:
- use "var"
- use Files.delete()
- only one method call in assert()
Issue-ID: POLICY-3093
Change-Id: I6f62108c770c15e8b84bc51746066fefa409e0fc
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 27 Aug 2021 15:14:36 +0000 (11:14 -0400)]
Address eclipse warnings in apex-pdp
Fixed:
- deprecated mockito methods
- unused mocks
Issue-ID: POLICY-3093
Change-Id: I20d9aebb2a6390b2a3c95ae9ccc59b710b9e58ce
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Thu, 26 Aug 2021 20:22:12 +0000 (16:22 -0400)]
Fix sonar issues
Issue-ID: POLICY-3077
Change-Id: I480b97984754ec4b69c6cde6481510fbbf62252e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Thu, 26 Aug 2021 17:38:26 +0000 (13:38 -0400)]
Use policy/docker image 2.3.0
Issue-ID: POLICY-3587
Change-Id: I5beff4d99dc869e85497621f50b6a56d3d95e7db
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 25 Aug 2021 15:44:58 +0000 (11:44 -0400)]
Remove GPLv3 from apex-pdp image
The apex-pdp docker image includes libelf, which is GPLv3 and is
therefore disallowed by ONAP. Appears to be included with "iproute2",
which isn't needed anymore, so just removed it. Also added code to
update the "apk" repo list.
Issue-ID: POLICY-2845
Change-Id: I7472d584bdd391b7a711c6718f2596b1081c032c
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 24 Aug 2021 17:20:26 +0000 (13:20 -0400)]
Use CompareToBuilder
Also added lombok to test classes.
Issue-ID: POLICY-3391
Change-Id: I9ecf479f3861a2e5211b037e885029d1719b6a56
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 23 Aug 2021 21:10:00 +0000 (17:10 -0400)]
More lombok for apex-pdp
Added lombok to auth thru context-management, excluding basic-model and
context-model.
Issue-ID: POLICY-3391
Change-Id: I1c3a69d52d3bc65a99126ad44126e5a97424c66f
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 23 Aug 2021 19:16:13 +0000 (15:16 -0400)]
Fix junits broken by change in is-alive type
Issue-ID: POLICY-3531
Change-Id: I1460333fdd2ebeb96aaa3b5d3186d2bd1eda2d71
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Mon, 23 Aug 2021 13:52:17 +0000 (14:52 +0100)]
Enable prometheus by default in apex-pdp
Change-Id: I0f0742474a5b242ebe71c0e5ab62bc2b1d0de1b9
Issue-ID: POLICY-3538
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
a.sreekumar [Wed, 18 Aug 2021 13:47:08 +0000 (14:47 +0100)]
Use common RestServer in apex-pdp
Change-Id: I8e0089cdd16f8e5f8db70db9c678fb598521158b
Issue-ID: POLICY-3539
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Taka Cho [Mon, 9 Aug 2021 20:12:04 +0000 (16:12 -0400)]
use url resource for docker-tag -- apex
use groovy url resource from docker repo
to identify the tag for docker
Issue-ID: POLICY-3378
Change-Id: I73be74f19d0d39912676d839c99f918fdfcf2078
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Tue, 3 Aug 2021 18:08:09 +0000 (14:08 -0400)]
Use lombok for apex-pdp #7
Updated thru core-protocols.
Issue-ID: POLICY-3391
Change-Id: I2226fee16b276eba5c7f3fd1921a6cef36654f07
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 2 Aug 2021 20:36:26 +0000 (16:36 -0400)]
Use lombok in apex-pdp #5
Updated examples thru integration-executor-test.
Issue-ID: POLICY-3391
Change-Id: Idc707146a646d05720675a787761c199484048e9
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 2 Aug 2021 19:56:00 +0000 (15:56 -0400)]
Use lombok in apex-pdp #4
Updated model, testsuites, and tools.
Issue-ID: POLICY-3391
Change-Id: I187d84380661f5d4222967c1c5f004c318d65982
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 2 Aug 2021 19:28:00 +0000 (15:28 -0400)]
Use lombok in apex-pdp #3
Updated plugins thru plugins-persistence-jpa-eclipselink.
Issue-ID: POLICY-3391
Change-Id: Id7a5aeca8bb45c7a089f0b9d49c9ecd4bc8a7178
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 4 Aug 2021 14:41:51 +0000 (10:41 -0400)]
Use lombok in apex-pdp #2
Updated context to use lombok.
Issue-ID: POLICY-3391
Change-Id: I349e0202fffad161cac08cebaea4a9571db58bda
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 30 Jul 2021 20:06:49 +0000 (16:06 -0400)]
Use lombok annotations in apex-pdp
Updated projects: services-engine through utilities
Issue-ID: POLICY-3391
Change-Id: I35ebb40d86e9bda360f7819516290b3fea88335c
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Wed, 28 Jul 2021 16:21:35 +0000 (17:21 +0100)]
Improve APEX logging for irrelevant events
When multiple policies are expecting event on the same topic/endpoint,
a lot of event parsing failure log messages are generated
unnecessarily. With this change, only a 1 line message will
be printed if an event cannot be parsed, and the detailed messages
will be available at debug level.
Change-Id: If1e7460ef5ed86fd470396f1e2ed8cc3c8af70c4
Issue-ID: POLICY-3499
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Mon, 19 Jul 2021 18:48:59 +0000 (14:48 -0400)]
Use docker registry properties in apex-pdp
Issue-ID: POLICY-3374
Change-Id: I7d9cfecdea244db6215f2c594f61b2d9b6cf96e0
Signed-off-by: Jim Hahn <jrh3@att.com>
adheli.tavares [Thu, 8 Jul 2021 14:36:25 +0000 (15:36 +0100)]
Update pdp statistics to count deploy/undeploy separately.
Issue-ID: POLICY-3383
Change-Id: Ie9c5c7178c4c4302a0ba63ab42732f7157d302f8
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
lapentafd [Wed, 30 Jun 2021 12:10:42 +0000 (13:10 +0100)]
Fix Sonar in apex examples aadm bbs
Replacing local-variable type inference
Issue-ID: POLICY-3093
Change-Id: I84bc2d182256f6a4aa24d9c1e020e934190bd623
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Ajith Sreekumar [Tue, 6 Jul 2021 13:33:46 +0000 (13:33 +0000)]
Merge "Cleanup input & outputFields from Task definition"
Liam Fallon [Mon, 5 Jul 2021 07:36:38 +0000 (07:36 +0000)]
Merge "Fix Sonar Issues in apex examples-adaptive"
a.sreekumar [Tue, 29 Jun 2021 12:57:14 +0000 (13:57 +0100)]
Cleanup input & outputFields from Task definition
1) Remove the usage of inputField and outputField from Task definition.
2) Fix issues around populating events to task in case of State
Finalizer Logic.
Change-Id: Ief17f400729410b83c6b7c665980d443e0cf6f28
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
lapentafd [Tue, 29 Jun 2021 10:31:34 +0000 (11:31 +0100)]
Fix Sonar Issues in apex examples-adaptive
Replacing local-variable type inference
Replaced EqualsAndHashCode ToString
methods with lombok annotation in AutoLearn class
Issue-ID: POLICY-3093
Change-Id: I3f3911222f0e34ad3c7687d7a1e1aad218448303
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Jim Hahn [Wed, 30 Jun 2021 03:36:29 +0000 (03:36 +0000)]
Merge "Use unique name in apex-pdp messages"
a.sreekumar [Tue, 29 Jun 2021 13:47:03 +0000 (14:47 +0100)]
Fixing checkstyle issue in APEX
Change-Id: I6b88d59a54617cb9f14a5aaa2638f87a6c1ef3e9
Issue-ID: POLICY-3209
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Tue, 29 Jun 2021 12:33:33 +0000 (12:33 +0000)]
Merge "Changes to support multiple outputs from a state"
Liam Fallon [Tue, 29 Jun 2021 07:56:19 +0000 (07:56 +0000)]
Merge "Fix sonar issues in apex plugins and testsuites"
Jim Hahn [Mon, 28 Jun 2021 20:01:47 +0000 (16:01 -0400)]
Use unique name in apex-pdp messages
Used name generator for apex-pdp instance id.
Issue-ID: POLICY-3410
Change-Id: Ifcb216d45fba7d6b10043f39fcb299daffe86b69
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Tue, 22 Jun 2021 14:55:46 +0000 (15:55 +0100)]
Changes to support multiple outputs from a state
This review addresses two main changes:
1) inputFields and outputFields are not tied to task definition anymore.
Instead inputEvent and outputEvents associated to a task is populated
as part of the policy state definition, as the state definition have
the information anyway.
- Clean up of the usage of inputFields and outputFields in task
definition will happen in a future review
- inputFields and outputFields defined in task definition in
policies until honolulu will not make the policy invalid as the
changes are done in backward compatible way.
2) Multiple output events can come out of a final state now.
- Define another policy state output with the relevant eventName in
the command file
- In the task logic, create a map to store the fields of the relevant
outputEvent, and then just call
"executor.addFieldsToOutput(<the_map_of_fields>)"
These 2 steps are enough to send multiple events to relevant
components as per the apex configuration.
Change-Id: Id88ca402704106404f529e595e1a76f6bf167876
Issue-ID: POLICY-3336
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ajith Sreekumar [Mon, 28 Jun 2021 09:35:23 +0000 (09:35 +0000)]
Merge "Update policy-apex-pdp for checkstyle 8.43"
liamfallon [Mon, 28 Jun 2021 09:15:14 +0000 (10:15 +0100)]
Update policy-apex-pdp for checkstyle 8.43
Issue-ID: POLICY-3209
Change-Id: I0cb6fc8f5693fe03b4d68af2fde5116e9e248115
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ajith Sreekumar [Mon, 28 Jun 2021 08:49:09 +0000 (08:49 +0000)]
Merge "Update apex-pdp for checkstyle 8.43"
lapentafd [Fri, 25 Jun 2021 13:52:51 +0000 (14:52 +0100)]
Fix sonar issues in apex plugins and testsuites
Replacing local-variable type inference
Issue-ID: POLICY-3093
Change-Id: I715231d6cf71d13c87b260b9f903910f9a5c434f
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
liamfallon [Thu, 24 Jun 2021 16:01:11 +0000 (17:01 +0100)]
Update apex-pdp for checkstyle 8.43
Issue-ID: POLICY-3206
Change-Id: I3873c85aab577e85a9ae6b610c3871ee4de6ea53
Signed-off-by: liamfallon <liam.fallon@est.tech>
lapentafd [Tue, 22 Jun 2021 11:29:11 +0000 (12:29 +0100)]
Sonar Issues in Apex plugins-context
Replacing local-variable type inference, and checkstyle fix
Refactor lambda expression to have one invocation to throw exception
Issue-ID: POLICY-3093
Change-Id: I6f89793a3652c50897d7f8e0fda35fffba903acc
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Wed, 16 Jun 2021 11:23:23 +0000 (12:23 +0100)]
Fix Sonar Issues in apex-pdp-services-engine
Test refactoring and local-variable type inference replaced
Issue-ID: POLICY-3093
Change-Id: I0c5506f27ea53da7740acce87a25060ba2bce7f4
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Tue, 15 Jun 2021 10:09:52 +0000 (11:09 +0100)]
Fix Sonar issues in apex-pdp
Issue-ID: POLICY-3093
Change-Id: I4def597b054a9ab2f3cc9a4665df04dd1d515ebf
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Thu, 10 Jun 2021 15:38:21 +0000 (16:38 +0100)]
Fix Rebase Issue on Sonar Issues apex-pdp-model
Deleting a duplicate method inserted in two different reviews
Issue-ID: POLICY-3093
Change-Id: Ie7c06c17ad1df380ebcd7129c218f5784152ff0e
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Pamela Dragosh [Thu, 10 Jun 2021 13:30:35 +0000 (13:30 +0000)]
Merge "Fix Sonar Issues in apex-pdp-basic-model"
Ram Krishna Verma [Wed, 9 Jun 2021 18:20:27 +0000 (18:20 +0000)]
Merge "Fix Sonar Issues in apex-pdp-model"
lapentafd [Tue, 8 Jun 2021 12:20:41 +0000 (13:20 +0100)]
Fix Sonar Issues in apex-pdp-basic-model
Test refactoring and use of Local-Variable Type Inference
Issue-ID: POLICY-3093
Change-Id: If19c9ec96ba440a58eff679f276e4b53a26ce1ab
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
lapentafd [Wed, 2 Jun 2021 11:02:46 +0000 (12:02 +0100)]
Fix Sonar Issues in apex-pdp-model
Changes made into model/basic-model
Renamed test classes to match the others
Issue-ID: POLICY-3093
Change-Id: I7a0d6046ead42a9165aaf96b89511dd8d064d109
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Ajith Sreekumar [Wed, 2 Jun 2021 11:44:06 +0000 (11:44 +0000)]
Merge "Fix Sonar Issues on Apex-pdp"
lapentafd [Thu, 27 May 2021 09:18:49 +0000 (10:18 +0100)]
Fix Sonar Issues on Apex-pdp
Changes made into cli-codegen, cli-editor, and core-engine
Renamed one test class to match other test classes
Issue-ID: POLICY-3093
Change-Id: Ib2d947782021590ffc08d426e7a1607a8c33f98a
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
a.sreekumar [Fri, 28 May 2021 10:40:37 +0000 (11:40 +0100)]
Fixing issues around policy deployment in APEX
Following items are fixed.
1) When in PASSIVE state, any policiesToBeUndeployed received
in PDP_UPDATE message are not handled.
2) APEX policy deployment fails when policiesToBeUndeployed
and policiesToBeDeployed come together in PDP_UPDATE message from PAP.
3) Improve response messages after deployment/undeployment.
Change-Id: I8f9c802db4b19c43881c734570b65ad66b3867d5
Issue-ID: POLICY-3332
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Thu, 13 May 2021 19:31:07 +0000 (15:31 -0400)]
Remove csit folder from policy/apex-pdp
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews.
Issue-ID: POLICY-3257
Change-Id: I26d281b75d91e7bf1250e97b22d0e7a303815ed6
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
a.sreekumar [Wed, 12 May 2021 16:32:01 +0000 (17:32 +0100)]
Fix issue where apex-pdp test is failing in gitlab
One of the testcases in APEX-PDP is failing only in gitlab,
but not failing in jenkins or local builds.
The reason is "/I/Dont/Exist*" is an invlaid path in jenkins etc,
but it is valid in gitlab somehow.
Changing this to "/I/Dont/Exist\0" so that the path is invalid
irrespective of the build platform.
Change-Id: I42bbc9ae21f0d827082f446f8dd416dcc10349e2
Issue-ID: POLICY-3306
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Pamela Dragosh [Tue, 11 May 2021 19:09:55 +0000 (19:09 +0000)]
Merge "Support ':' in Apex Event Avro schema fieldnames"
a.sreekumar [Tue, 11 May 2021 11:27:42 +0000 (12:27 +0100)]
Update the default logback.xml in APEX to log to STDOUT
Update the default logback.xml to log to STDOUT,
so that while running in standalone mode, logs can be seen easily.
Change-Id: Ie0ccdbe11672c33723c920767ce14d1b26fa9762
Issue-ID: POLICY-3303
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>