vid.git
4 years agoMerge "Allow plugging-in any provided LoginStrategy"
Amichai Hemli [Sun, 25 Aug 2019 12:02:01 +0000 (12:02 +0000)]
Merge "Allow plugging-in any provided LoginStrategy"

4 years agoFix to vf-module-homing-data-action controller to retrieve the cloudRegionId 25/94125/4
Alexey Sandler [Thu, 22 Aug 2019 12:16:48 +0000 (15:16 +0300)]
Fix to vf-module-homing-data-action controller to retrieve the cloudRegionId

Issue-ID: VID-378
Change-Id: I6042e72c9ebb8508b822df276da1b8549501042c
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoAllow plugging-in any provided LoginStrategy 50/94250/3
Ittay Stern [Sun, 25 Aug 2019 10:02:27 +0000 (13:02 +0300)]
Allow plugging-in any provided LoginStrategy

Support dynamic loading of provided implementations of PORTAL SDK's 
`org.onap.portalsdk.core.auth.LoginStrategy` interface.

VID will load the class defined by `login.strategy.classname`
configuration parameter. Default will keep current ONAP's dev login.

Change-Id: I956a1f3376455211398769f3193703129b779871
Issue-ID: VID-594
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Begin release notes for El Alto Early Drop"
Amichai Hemli [Thu, 22 Aug 2019 18:27:02 +0000 (18:27 +0000)]
Merge "Begin release notes for El Alto Early Drop"

4 years agoMove this variable to comply with Java Code Conventions 75/94075/3
Thugutla sailakshmi [Thu, 22 Aug 2019 07:30:57 +0000 (13:00 +0530)]
Move this variable to comply with Java Code Conventions

Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Ibf8099258145a2ae591cd0acce9bbe75b592eccd
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMerge "Add a semicolon at the end of this statement."
Ittay Stern [Thu, 22 Aug 2019 16:19:03 +0000 (16:19 +0000)]
Merge "Add a semicolon at the end of this statement."

4 years agoMerge "extract constant in MsoBusinessLogicImplTest"
Ittay Stern [Thu, 22 Aug 2019 16:14:16 +0000 (16:14 +0000)]
Merge "extract constant in MsoBusinessLogicImplTest"

4 years agoMerge "Move this variable to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:09:03 +0000 (16:09 +0000)]
Merge "Move this variable to comply with Java Code Conventions"

4 years agoMerge "Move this constructor to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:05:37 +0000 (16:05 +0000)]
Merge "Move this constructor to comply with Java Code Conventions"

4 years agoMerge "Move this constructor to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:04:05 +0000 (16:04 +0000)]
Merge "Move this constructor to comply with Java Code Conventions"

4 years agoextract constant in MsoBusinessLogicImplTest 32/94132/1
Eylon Malin [Thu, 22 Aug 2019 14:40:14 +0000 (17:40 +0300)]
extract constant in MsoBusinessLogicImplTest

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I49a50f0762b2db8bcab06340a6407a0ee7970c86

4 years agoMerge "make scheduler client tolerance to error messages"
Amichai Hemli [Thu, 22 Aug 2019 13:50:23 +0000 (13:50 +0000)]
Merge "make scheduler client tolerance to error messages"

4 years agomake scheduler client tolerance to error messages 06/94106/2
Eylon Malin [Thu, 22 Aug 2019 12:22:17 +0000 (15:22 +0300)]
make scheduler client tolerance to error messages

Read response from scheduler as String save them as raw,
and only then parse them

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I38ed8f211b2c111b57741254cb5e90317fefdc7d
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "probe mso by retrieving empty list of request status"
Amichai Hemli [Thu, 22 Aug 2019 13:12:17 +0000 (13:12 +0000)]
Merge "probe mso by retrieving empty list of request status"

4 years agoprobe mso by retrieving empty list of request status 91/94091/2
Eylon Malin [Thu, 22 Aug 2019 09:26:41 +0000 (12:26 +0300)]
probe mso by retrieving empty list of request status

Mso probe component use getRawOrchestrationRequestsByFilter
which return HttpResponseWithRequestInfo

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icee95af8dbe26296e9fc110170fb758e5133984c
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoAdd MsoController deletion tests 99/94099/1
kurczews [Thu, 22 Aug 2019 10:35:04 +0000 (12:35 +0200)]
Add MsoController deletion tests

Change-Id: I534fb06e7bf742f2fe6931e5b6f279f499aeed08
Issue-ID: VID-470
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
4 years agoMove this constructor to comply with Java Code Conventions 85/94085/1
Thugutla sailakshmi [Thu, 22 Aug 2019 07:55:44 +0000 (13:25 +0530)]
Move this constructor to comply with Java Code Conventions

Move this constructor to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I50e166bebe331db6b1e46f06c156791fa41b500b
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this constructor to comply with Java Code Conventions 79/94079/1
Thugutla sailakshmi [Thu, 22 Aug 2019 07:40:45 +0000 (13:10 +0530)]
Move this constructor to comply with Java Code Conventions

Move this constructor to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I3641f897f191dc8717bf65fefd4fd2c699f7195b
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variable to comply with Java Code Conventions 32/94032/2
Thugutla sailakshmi [Wed, 21 Aug 2019 08:57:29 +0000 (14:27 +0530)]
Move this variable to comply with Java Code Conventions

Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I01c4d3e2efc1ee23694da8d3e6770978d94e88c2
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement. 69/94069/1
anushadasari [Thu, 22 Aug 2019 06:52:50 +0000 (12:22 +0530)]
Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-583
Change-Id: I68d334ce5f7f427ebc3e49b5991fd989676d8c0e
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoBegin release notes for El Alto Early Drop 37/94037/1
Ittay Stern [Wed, 21 Aug 2019 11:21:45 +0000 (14:21 +0300)]
Begin release notes for El Alto Early Drop

Change-Id: Ifba726c82e8348d7744ffd3483380831d1888abf
Issue-ID: VID-553
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoprobe sdc by retrieving service model if uuid configured 27/93627/5
Eylon Malin [Thu, 15 Aug 2019 14:23:44 +0000 (17:23 +0300)]
probe sdc by retrieving service model if uuid configured

If system.properties has value for probe.sdc.model.uuid then usd
this value for retrieving service model
otherwise probe only sdc connectivity with sdc2/rest/healthCheck

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icd1c31217e56a8c0cfa5c2f2bc5f11e0c8dd7ff8
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "merge 2 TestNg transformers"
Ittay Stern [Wed, 21 Aug 2019 10:01:21 +0000 (10:01 +0000)]
Merge "merge 2 TestNg transformers"

4 years agoMerge "Move this variables and constructors to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:57:21 +0000 (09:57 +0000)]
Merge "Move this variables and constructors to comply with Java Code Conventions"

4 years agoMerge changes from topics "VID-583", "VID-582"
Ittay Stern [Wed, 21 Aug 2019 09:06:00 +0000 (09:06 +0000)]
Merge changes from topics "VID-583", "VID-582"

* changes:
  Add a semicolon at the end of this statement.
  Unused Import

4 years agoMerge "Move this variables to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:02:57 +0000 (09:02 +0000)]
Merge "Move this variables  to comply with Java Code Conventions"

4 years agoMerge "Move this variables to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:00:23 +0000 (09:00 +0000)]
Merge "Move this variables to comply with Java Code Conventions"

4 years agoMove this variables and constructors to comply with Java Code Conventions 30/93930/3
Thugutla sailakshmi [Tue, 20 Aug 2019 07:41:54 +0000 (13:11 +0530)]
Move this variables and constructors to comply with Java Code Conventions

Move this variables and constructors  to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Id8e4c00609ad17d624da82d8b73d14b5cb0639b1
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variables to comply with Java Code Conventions 24/94024/1
Thugutla sailakshmi [Wed, 21 Aug 2019 07:41:14 +0000 (13:11 +0530)]
Move this variables  to comply with Java Code Conventions

Move this variables  to comply with Java Code Conventions

Issue-ID: VID-581
Change-Id: I74728ee5234501ba3c2a8fe5ae889c1e9186f2dc
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement. 23/94023/1
anushadasari [Wed, 21 Aug 2019 07:40:33 +0000 (13:10 +0530)]
Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-583
Change-Id: I73dbc757d62ef388d8935ef6aa25f08c3a82df8c
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMove this variables to comply with Java Code Conventions 26/93926/2
Thugutla sailakshmi [Tue, 20 Aug 2019 07:23:57 +0000 (12:53 +0530)]
Move this variables to comply with Java Code Conventions

Move this variables to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Id618b3717658dcd44b17a5f85b0b87e7e8b71826
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoUnused Import 21/94021/1
anushadasari [Wed, 21 Aug 2019 07:27:30 +0000 (12:57 +0530)]
Unused Import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-582
Change-Id: Id79d2f2af4d69ded8e1c8da10fc67e4e7ea0f933
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java...
Ittay Stern [Wed, 21 Aug 2019 06:54:55 +0000 (06:54 +0000)]
Merge "Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code Conventions"

4 years agoMerge "Sonar Fix - HttpsAuthClient.java"
Ittay Stern [Wed, 21 Aug 2019 06:54:29 +0000 (06:54 +0000)]
Merge "Sonar Fix - HttpsAuthClient.java"

4 years agoMerge changes from topics "VID-580", "VID-579", "VID-578"
Ittay Stern [Wed, 21 Aug 2019 06:34:15 +0000 (06:34 +0000)]
Merge changes from topics "VID-580", "VID-579", "VID-578"

* changes:
  unused import
  Move the variable to comply with JCC.
  semicolon at the end of this statement.

4 years agomerge 2 TestNg transformers 23/93623/2
Eylon Malin [Thu, 15 Aug 2019 13:42:22 +0000 (16:42 +0300)]
merge 2 TestNg transformers

Testng probably don't behave well with 2 transformers that change same
thing. So I merge 2 transformers that skip tests to one transformer.
Issue-ID: VID-378

Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I569d421b853ed1e0dc2a5055dbaf8e5bba6db470
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agounused import 41/93941/1
anushadasari [Tue, 20 Aug 2019 09:30:49 +0000 (15:00 +0530)]
unused import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-580
Change-Id: I3ea680af37477b564d02fcc9b58956b3958d184d
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMove the variable to comply with JCC. 40/93940/1
anushadasari [Tue, 20 Aug 2019 09:12:19 +0000 (14:42 +0530)]
Move the variable to comply with JCC.

According to the Java Code Conventions as defined by Oracle, the members of a class or interface declaration should appear in the following order in the source files:
Class and instance variables
Constructors
Methods

Issue-ID: VID-579
Change-Id: Ie87b550a30df06eb2498565b719bd52b11d0c3f9
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agosemicolon at the end of this statement. 32/93932/1
anushadasari [Tue, 20 Aug 2019 07:59:19 +0000 (13:29 +0530)]
semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Change-Id: Ia09e1bb1894da379f68cc39e83f955e66b957511
Issue-ID: VID-578
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoadding update about mounted certificates in rst file 63/93863/1
Bartosz Gardziejewski [Mon, 19 Aug 2019 11:47:19 +0000 (13:47 +0200)]
adding update about mounted certificates in rst file

Issue-ID: VID-494
Change-Id: I732a426975247448f05539d1a95c0b6c66ccf5a7
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
4 years agoSonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code... 64/93664/1
dinesha [Fri, 16 Aug 2019 06:50:19 +0000 (12:20 +0530)]
Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code Conventions

Fixed sonar issus across the file

Issue-ID: VID-547
Change-Id: I3362cf34c3db506ab3359669045169fe761743ea
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoSkip log format validation for a week 09/93609/3
Eylon Malin [Thu, 15 Aug 2019 08:39:22 +0000 (11:39 +0300)]
Skip log format validation for a week

Add annotation SkipTestUntil and TestNg transformer so we can add
annotation for skip test till some date (aka time bomb)
Use it in log format tests
Issue-ID: VID-378

Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ib4b5d17d73d360fd2554b5ffc0373790d22d9e4e
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "Move this variable to comply with Java Code Conventions"
Ittay Stern [Wed, 14 Aug 2019 12:36:05 +0000 (12:36 +0000)]
Merge "Move this variable to comply with Java Code Conventions"

4 years agoMerge "Move this variable to comply with Java Code Conventions"
Ittay Stern [Wed, 14 Aug 2019 12:35:32 +0000 (12:35 +0000)]
Merge "Move this variable to comply with Java Code Conventions"

4 years agoSonar Fix - HttpsAuthClient.java 26/93526/1
dinesha [Wed, 14 Aug 2019 09:01:22 +0000 (14:31 +0530)]
Sonar Fix - HttpsAuthClient.java

Fixed Sonar issues accross the file

Issue-ID: VID-547
Change-Id: I2b344b48fec4e153cb47154ec49998aa1c267a95
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoMerge "moving certs from docker image to mounted catalog"
Ittay Stern [Tue, 13 Aug 2019 16:38:29 +0000 (16:38 +0000)]
Merge "moving certs from docker image to mounted catalog"

4 years agoMerge "Bump VID version to 5.0.1"
Amichai Hemli [Tue, 13 Aug 2019 16:23:53 +0000 (16:23 +0000)]
Merge "Bump VID version to 5.0.1"

4 years agoCorrect link in info.yaml removal entry 25/93425/1
Ittay Stern [Tue, 13 Aug 2019 15:51:57 +0000 (18:51 +0300)]
Correct link in info.yaml removal entry

Change-Id: I112a9130260627e96b01ff31a67b0c7aaa2fee14
Issue-ID: VID-502
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoBump VID version to 5.0.1 24/93424/1
Ittay Stern [Tue, 13 Aug 2019 15:45:23 +0000 (18:45 +0300)]
Bump VID version to 5.0.1

Issue-ID: VID-494

Change-Id: I0564a6ac162b82211733525133c6e1dadf1541c0
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoAdd a semicolon at the end of this statement 10/93410/1
anushadasari [Tue, 13 Aug 2019 11:30:25 +0000 (17:00 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-568
Change-Id: Id89534f4fbd326ebcbe12857bce7e2d69bf73dfd
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMove this variable to comply with Java Code Conventions 08/93408/1
Thugutla sailakshmi [Tue, 13 Aug 2019 11:12:14 +0000 (16:42 +0530)]
Move this variable to comply with Java Code Conventions

move the variable to comply with java code convenrions

Issue-ID: VID-561
Change-Id: I11a671d8be20429c3e53fd98d54330b982564f93
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agotests - rename csar file names for alignment with code 88/93388/1
Eylon Malin [Tue, 13 Aug 2019 08:21:53 +0000 (11:21 +0300)]
tests - rename csar file names for alignment with code

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I5313de573f8077e3ddcea565c0d056c2cb5857a5

4 years agoMerge "Change out-of-the-box config to work on dev's environment"
Amichai Hemli [Tue, 13 Aug 2019 08:14:18 +0000 (08:14 +0000)]
Merge "Change out-of-the-box config to work on dev's environment"

4 years agoMerge "Upgrade pom files"
Ittay Stern [Mon, 12 Aug 2019 18:01:25 +0000 (18:01 +0000)]
Merge "Upgrade pom files"

4 years agocatch any Throwable when failed to register to simulator 51/93351/1
Eylon Malin [Mon, 12 Aug 2019 15:46:53 +0000 (18:46 +0300)]
catch any Throwable when failed to register to simulator

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I553f8bf1fa657ce792ef690db95471de6f3658b3

4 years agoUpgrade pom files 59/91259/4
Einat Vinouze [Thu, 11 Jul 2019 13:25:44 +0000 (16:25 +0300)]
Upgrade pom files

versions:use-latest-releases

Issue-ID: VID-512

Change-Id: I3bdc7ff06717776e4f15316cca623e8025066495
Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoSonar Fix - ResourceType.java- Added field 'final' to the static variable 54/93154/4
dinesha [Fri, 9 Aug 2019 07:02:05 +0000 (12:32 +0530)]
Sonar Fix - ResourceType.java- Added field 'final' to the static variable

Fixed Sonar issues across the file

Issue-ID: VID-547
Change-Id: I1daa62cf2e30f5b0dbe142c7ea183f93fd7fb48f
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoMerge "return this expression instead of assigning it to the temporary variable"
Ittay Stern [Mon, 12 Aug 2019 08:26:29 +0000 (08:26 +0000)]
Merge "return this expression instead of assigning it to the temporary variable"

4 years agoMerge "Remove declaration of thrown exception"
Ittay Stern [Mon, 12 Aug 2019 08:25:43 +0000 (08:25 +0000)]
Merge "Remove declaration of thrown exception"

4 years agoMerge "Remove useless trailing whitespace"
Ittay Stern [Mon, 12 Aug 2019 08:25:39 +0000 (08:25 +0000)]
Merge "Remove useless trailing whitespace"

4 years agoMerge "Move this variable to comply with Java Code Conventions"
Ittay Stern [Mon, 12 Aug 2019 08:23:42 +0000 (08:23 +0000)]
Merge "Move this variable to comply with Java Code Conventions"

4 years agoRemove declaration of thrown exception 17/93017/2
anushadasari [Thu, 8 Aug 2019 07:48:25 +0000 (13:18 +0530)]
Remove declaration of thrown exception

Remove the declaration of thrown exception 'org.onap.vid.aai.exceptions.HttpClientBuilderException' which is a runtime exception.

Issue-ID: VID-559
Change-Id: I8fe8c29e3aa1d4b0b35522931057efa260c60206
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoRemove useless trailing whitespace 25/93025/2
anushadasari [Thu, 8 Aug 2019 09:04:25 +0000 (14:34 +0530)]
Remove useless trailing whitespace

Trailing whitespaces are simply useless and should not stay in code. They may generate noise when comparing different versions of the same file.

Issue-ID: VID-565
Change-Id: If5647e94ea897bf42761a689d036a7229b34a500
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoreturn this expression instead of assigning it to the temporary variable 74/92874/5
Thugutla Sailakshmi [Wed, 7 Aug 2019 09:04:23 +0000 (14:34 +0530)]
return this expression instead of assigning it to the temporary variable

Issue-ID: VID-561
Change-Id: I64e50083b9b0fe40fa0ba32723e30adb0dbce08e
Signed-off-by: Thugutla Sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variable to comply with Java Code Conventions 81/92881/5
Thugutla sailakshmi [Wed, 7 Aug 2019 11:50:11 +0000 (17:20 +0530)]
Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I1c59d863eb93537177e84a3a10fed0862189191c
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variable to comply with Java Code Conventions 75/92875/5
Thugutla sailakshmi [Wed, 7 Aug 2019 11:25:02 +0000 (16:55 +0530)]
Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I7d3382d43a0484dbadea4d3285a235a628d84ffc
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMerge "set VID to use internally UTC timezone"
Ittay Stern [Mon, 12 Aug 2019 07:53:22 +0000 (07:53 +0000)]
Merge "set VID to use internally UTC timezone"

4 years agoMerge "return MsoResponseWrapper with null body in case of null response"
Ittay Stern [Mon, 12 Aug 2019 07:53:18 +0000 (07:53 +0000)]
Merge "return MsoResponseWrapper with null body in case of null response"

4 years agoChange out-of-the-box config to work on dev's environment 98/93298/2
Ittay Stern [Wed, 7 Aug 2019 15:39:22 +0000 (18:39 +0300)]
Change out-of-the-box config to work on dev's environment

1) Fill-up system.properties's missing fields, and same for
   system_template.properties.

   This modifies some SO endpoints, most significantly --
   mso.restapi.vnf.instance is now
   /serviceInstantiation/v7/serviceInstances/<service_instance_id>/vnfs
   instead of
   /serviceInstances/v6/<service_instance_id>/vnfs

2) Configure endpoint's to a local simulator's location:
   * ecomp_rest_url in portal.properties
   * mso.server.url, aai.server.url in system.properties
   * asdc.client.rest.host in asdc.properties

3) Added always-on getSessionSlotCheckInterval in simulator.

Issue-ID: VID-564

Change-Id: Icc7bdc83ed65df3415a4b0f36f98291775909f49
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "use epsdk 2.5.0 in VID"
Ittay Stern [Mon, 12 Aug 2019 05:45:56 +0000 (05:45 +0000)]
Merge "use epsdk 2.5.0 in VID"

4 years agoreturn MsoResponseWrapper with null body in case of null response 85/93085/2
Eylon Malin [Thu, 8 Aug 2019 14:02:38 +0000 (17:02 +0300)]
return MsoResponseWrapper with null body in case of null response

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ia05237264557634f18ed868904cc68350a312fc1

4 years agoset VID to use internally UTC timezone 99/93099/1
Eylon Malin [Thu, 8 Aug 2019 15:01:34 +0000 (18:01 +0300)]
set VID to use internally UTC timezone

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I4b062d4a7ec68e564c46a094a75739dc9ad0355b

4 years agofix test getServiceModelALaCarteInstantiation 94/93094/1
Eylon Malin [Thu, 8 Aug 2019 14:41:01 +0000 (17:41 +0300)]
fix test getServiceModelALaCarteInstantiation

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I0d98886837cc67164b77f3407323ac45e3e126a4

4 years agoMove this variable to comply with Java Code Conventions 18/93018/2
Thugutla sailakshmi [Thu, 8 Aug 2019 07:46:50 +0000 (13:16 +0530)]
Move this variable to comply with Java Code Conventions

Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I9c40a6165ece22bbfda29e17cdb8572a2b7d11e8
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agomoving certs from docker image to mounted catalog 77/93077/1
Bartosz Gardziejewski [Thu, 8 Aug 2019 13:17:32 +0000 (15:17 +0200)]
moving certs from docker image to mounted catalog

Removing certificates from dockerfile and adding mounted volume in docker-compose, this is connected with oom commit https://gerrit.onap.org/r/c/oom/+/92888

Issue-ID: VID-494
Change-Id: Ibf52542344ecf79fb947858329f37018731d2270
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
4 years agoMerge "Resolving VlanTagSubInterfaceTest#createSubInterface_validPopupDataAndUI befor...
Ittay Stern [Thu, 8 Aug 2019 12:33:50 +0000 (12:33 +0000)]
Merge "Resolving VlanTagSubInterfaceTest#createSubInterface_validPopupDataAndUI beforeTest"

4 years agoResolving VlanTagSubInterfaceTest#createSubInterface_validPopupDataAndUI beforeTest 64/93064/1
RachelF [Thu, 8 Aug 2019 11:49:09 +0000 (14:49 +0300)]
Resolving VlanTagSubInterfaceTest#createSubInterface_validPopupDataAndUI beforeTest

Issue-ID: VID-566
Signed-off-by: RachelF <rachel.fishbein@intl.att.com>
Change-Id: I623835324593d1de3db08824dffe4c167264174b

4 years agoSonar Fix - Group.java 53/93053/1
dinesha [Thu, 8 Aug 2019 10:45:34 +0000 (16:15 +0530)]
Sonar Fix - Group.java

Fixed Sonar issues accross the file

Issue-ID: VID-547
Change-Id: I128b69d6ddcf8b1198ffd42530d664c92dd13cc7
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agosupport more resource types in ServiceModelInflator 31/92931/1
Eylon Malin [Wed, 7 Aug 2019 17:12:00 +0000 (20:12 +0300)]
support more resource types in ServiceModelInflator

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I80ce2b81202ea08491f65fc47390f826b2b02d20

4 years agoMerge "add default exception handling to VidRestrictedBaseController"
Amichai Hemli [Wed, 7 Aug 2019 17:08:28 +0000 (17:08 +0000)]
Merge "add default exception handling to VidRestrictedBaseController"

4 years agoadd default exception handling to VidRestrictedBaseController 28/92928/1
Eylon Malin [Wed, 7 Aug 2019 16:39:53 +0000 (19:39 +0300)]
add default exception handling to VidRestrictedBaseController

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ie5bac35975257ad092c75e8e7e7dfd8fefa0363e

4 years agouse epsdk 2.5.0 in VID 16/92916/1
Eylon Malin [Wed, 7 Aug 2019 15:36:49 +0000 (18:36 +0300)]
use epsdk 2.5.0 in VID

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Id483174b283a5f1eb6160982a446ccb223606c9e

4 years agoRemove the declaration of thrown exception 84/92884/1
anushadasari [Wed, 7 Aug 2019 11:59:20 +0000 (17:29 +0530)]
Remove the declaration of thrown exception

Remove the declaration of thrown exception 'org.onap.vid.aai.ExceptionWithRequestInfo' which is a runtime exception.

Issue-ID: VID-559
Change-Id: I275d7323d153c70fa515af4a0417fe0910ee451d
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoRemove Unused Import 80/92880/1
anushadasari [Wed, 7 Aug 2019 11:48:14 +0000 (17:18 +0530)]
Remove Unused Import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-563
Change-Id: Id88ce00cca08b58e0ac4beb60026c9dae5dd892e
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAt most one statement is allowed per line 76/92876/1
anushadasari [Wed, 7 Aug 2019 11:26:49 +0000 (16:56 +0530)]
At most one statement is allowed per line

At most one statement is allowed per line, but 2 statements were found
on this line.
For better readability, do not put more than one statement on a single line.

Issue-ID: VID-562
Change-Id: Ibdae3413af96d49ce7a39e53d3af611e237cc16b
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "removing unused ViewLog Controller and jsp"
Ittay Stern [Wed, 7 Aug 2019 09:17:13 +0000 (09:17 +0000)]
Merge "removing unused ViewLog Controller and jsp"

4 years agoMerge "Use lcpRegionOptionId as value in resume"
Ittay Stern [Wed, 7 Aug 2019 09:16:42 +0000 (09:16 +0000)]
Merge "Use lcpRegionOptionId as value in resume"

4 years agoremoving unused ViewLog Controller and jsp 61/92861/1
Eylon Malin [Wed, 7 Aug 2019 09:04:04 +0000 (12:04 +0300)]
removing unused ViewLog Controller and jsp

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I7d5cdd0091e2c67adc617894386a58a89046880e

4 years agofix getNetworkListTest UT 59/92859/1
Eylon Malin [Wed, 7 Aug 2019 07:39:43 +0000 (10:39 +0300)]
fix getNetworkListTest UT

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Id28c5b3062f45c217f0bfc93e6d2a7c6333d15c4

4 years agoMerge changes Iede12655,I73fcc78e
Ittay Stern [Wed, 7 Aug 2019 07:19:18 +0000 (07:19 +0000)]
Merge changes Iede12655,I73fcc78e

* changes:
  add endpoints for getVpnList and getActiveNetworkList
  use cache for retrieving all subscribers list

4 years agoUse lcpRegionOptionId as value in resume 57/92857/1
Rina Roi [Wed, 7 Aug 2019 07:14:08 +0000 (10:14 +0300)]
Use lcpRegionOptionId as value in resume

Issue-ID: VID-482
Signed-off-by: Rina Roi <rina.roi@intl.att.com>
Change-Id: Ibe617ba739db8e6217362a8009dedc9bd3465239

4 years agoadd endpoints for getVpnList and getActiveNetworkList 31/92831/1
Eylon Malin [Tue, 6 Aug 2019 16:23:29 +0000 (19:23 +0300)]
add endpoints for getVpnList and getActiveNetworkList

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Iede126556df337b1ab70dd76c9452f4b51e11376

4 years agouse cache for retrieving all subscribers list 26/92826/1
Eylon Malin [Tue, 6 Aug 2019 15:47:30 +0000 (18:47 +0300)]
use cache for retrieving all subscribers list

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I73fcc78ebbd8ee01349ecefa924c20014ca33907

4 years agoSonar Critical: Make dateFormat an instance variable 97/92197/4
nandkumar [Tue, 6 Aug 2019 12:23:47 +0000 (17:53 +0530)]
Sonar Critical: Make dateFormat an instance variable

Change-Id: I1f275c2b4b814afc7c50e02e756312ce6923efe0
Issue-ID: VID-535
Signed-off-by: nandkumar <np00602065@techmahindra.com>
4 years agofix tests by adding missing preset of get subscribers from AAI 04/92804/1
Eylon Malin [Tue, 6 Aug 2019 13:59:21 +0000 (16:59 +0300)]
fix tests by adding missing preset of get subscribers from AAI

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I6dc101b76089c32b8b9d2912a070b64bf01514ec

4 years agoSonar Fix- RoleGenaratorServiceImpl.java- Define a constant instead of duplicating... 84/92784/1
dinesha [Tue, 6 Aug 2019 11:47:56 +0000 (17:17 +0530)]
Sonar Fix- RoleGenaratorServiceImpl.java- Define a constant instead of duplicating this literal

Fixed Sonar issues accross the file

Issue-ID: VID-547
Change-Id: I91dc81916fc1c7843e0f5b723cdf47153e682592
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoMerge "Sonar Fix- CommandParentData.java- Move this variable to comply with Java...
Ittay Stern [Tue, 6 Aug 2019 11:33:06 +0000 (11:33 +0000)]
Merge "Sonar Fix- CommandParentData.java- Move this variable to comply with Java Code Conventions"

4 years agoSonar Fix- CommandParentData.java- Move this variable to comply with Java Code Conven... 79/92779/1
dinesha [Tue, 6 Aug 2019 11:19:16 +0000 (16:49 +0530)]
Sonar Fix- CommandParentData.java- Move this variable to comply with Java Code Conventions

Fixed Sonar issues accross the file

Issue-ID: VID-547
Change-Id: I104df866f1e4e8477c954942ae69fe647028e621
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoSonar Fix- ProbeController.java- Reorder the modifiers to comply with the Java Langua... 78/92778/1
dinesha [Tue, 6 Aug 2019 11:12:47 +0000 (16:42 +0530)]
Sonar Fix- ProbeController.java- Reorder the modifiers to comply with the Java Language Specification

Fixed Sonar issues accross the file

Issue-ID: VID-547
Change-Id: I6240ae0bc339ba43b55b8a66609935bc63705c1d
Signed-off-by: dinesha <dineshgs@in.ibm.com>
4 years agoMerge "handle errors in change management and tenant isolation"
Ittay Stern [Tue, 6 Aug 2019 09:54:26 +0000 (09:54 +0000)]
Merge "handle errors in change management and tenant isolation"