Jim Hahn [Mon, 23 Mar 2020 15:36:09 +0000 (11:36 -0400)]
Update new SDNR actor with v2.0 structures
SDNR v2.0 introduced an extra "input" and "output" layer within
the body of the messages. Added POJOs to match that, and updated
the actor to use the new POJOs so that no extra steps are needed
during serialization or deserialization.
Also modified the SDNR and APPC-LCM simulators to discard request messages
when looking for the response, if the sink and source topics happen to
be the same.
Added the SDNR simulator.
Added more coverage to the SDNR actor.
Fixed a sonar issue in the SDNR junit code:
- use a constant instead of a literal (i.e., for "ModifyConfig")
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I70914a299dd5e9ee8eaccb5d42a2596cab814091
Liam Fallon [Mon, 23 Mar 2020 12:22:15 +0000 (12:22 +0000)]
Merge "Bug fixes in models simulators"
Liam Fallon [Mon, 23 Mar 2020 12:21:50 +0000 (12:21 +0000)]
Merge "Exception not propagated by processResponse"
Jim Hahn [Fri, 20 Mar 2020 22:08:52 +0000 (18:08 -0400)]
Fix legacy APPC handling of Request
Legacy APPC uses the same topic for both requests and responses.
Unfortunately, when the actor sees the request, thinking it's a
response, it throws an exception because it can't find the status
code. Fixed.
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I6137fb21dbf1149ff2faca2407ba69be0de6d40b
Jim Hahn [Fri, 20 Mar 2020 22:29:21 +0000 (18:29 -0400)]
Exception not propagated by processResponse
If the topic processResponse() method throws an exception, then
the actor/operation is left in an incomplete state.
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I6c5d149d4046fbfb970c8dd831fc3938516d1115
Jim Hahn [Fri, 20 Mar 2020 19:53:47 +0000 (15:53 -0400)]
Bug fixes in models simulators
Fixed these issues:
- topics weren't started
- appc topics were reversed
- prevent appc simulator from responding to a response (i.e., infinite
loop)
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1f43be72d35f874fec98f48f1a112c055c00eee5
Jim Hahn [Fri, 20 Mar 2020 18:07:33 +0000 (18:07 +0000)]
Merge "Add docker file for all simulators"
liamfallon [Fri, 20 Mar 2020 12:50:35 +0000 (12:50 +0000)]
Test cascaded multiple revision gets
This patch tests cascaded get requests with multiple revisions.
Issue-ID: POLICY-2377
Change-Id: Ie7dc849d7b930b861d38c386a9950ae7e84e2a05
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Tue, 17 Mar 2020 21:41:59 +0000 (17:41 -0400)]
Add docker file for all simulators
Some CSITs may require multiple simulators. This adds a class that
will start all of the simulators. A tarball is generated from which
a docker image can be built.
Added simulators for Topics: appc and appc-lcm.
Fixed licenses in files in packages directory.
Fixed per review comments:
- add version to Dockerfile
Issue-ID: POLICY-2434
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Id7aa9cb5a5874f7b4185273ab0d2c074198554ff
Liam Fallon [Fri, 20 Mar 2020 09:51:38 +0000 (09:51 +0000)]
Merge "Point to released common and parent"
Liam Fallon [Fri, 20 Mar 2020 09:31:29 +0000 (09:31 +0000)]
Merge "Misc simple sonar issue fixes"
Pamela Dragosh [Fri, 20 Mar 2020 00:17:05 +0000 (20:17 -0400)]
Point to released common and parent
common 1.6.2 and parent 3.1.1
Issue-ID: POLICY-2378
Change-Id: I668814f6d121db4f22050d2b6d307d5d3743ddf4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Chris Ramstad [Tue, 17 Mar 2020 18:52:02 +0000 (11:52 -0700)]
Misc simple sonar issue fixes
Issue-ID: POLICY-2389
Signed-off-by: Chris Ramstad <cramstad@ciena.com>
Change-Id: I7ce91e331a128aaadaab5ac837e19873a3388164
liamfallon [Thu, 19 Mar 2020 17:37:05 +0000 (17:37 +0000)]
Add unit test for Version fetch change
Issue-ID: POLICY-2377
Change-Id: Iaad1da84de058fcb50d24663156b4b0bcedd427e
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 19 Mar 2020 15:28:49 +0000 (15:28 +0000)]
Allow fetch of old policy type verisons
Due to the problems with TOSCA and version handling, the filtering for
policy types on old versions did not work. This change fixes that
problem.
Issue-ID: POLICY-2377
Change-Id: I462bd5710b9dea37475861d1021d28b2c7391a24
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Wed, 18 Mar 2020 19:54:16 +0000 (19:54 +0000)]
Merge "renew policy certs till 03/17/2021"
liamfallon [Wed, 18 Mar 2020 11:47:20 +0000 (11:47 +0000)]
Return latest entity on null versions
This review amends the behaviour of "get" operations on entities to
always return the latest version of an entity when the version of the
search key is the null key (value of 0.0.0).
Issue-ID: POLICY-2377
Change-Id: I4f7c12637c90bc1a83ce2ba5ef40e15b461a7d51
Signed-off-by: liamfallon <liam.fallon@est.tech>
jhh [Wed, 18 Mar 2020 00:40:32 +0000 (19:40 -0500)]
renew policy certs till 03/17/2021
Issue-ID: POLICY-2402
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I42919180d73058bc78cc70a29a6d5d45823aa9eb
Pamela Dragosh [Mon, 16 Mar 2020 19:29:00 +0000 (19:29 +0000)]
Merge "Consistent returns on Service Template gets"
liamfallon [Fri, 13 Mar 2020 12:34:58 +0000 (12:34 +0000)]
Consistent returns on Service Template gets
This review enables specification of versions of entities on incoming
service templates using a ':' delimiter.
So this will load version 1.00, version 2.0.0, and version 3.0.0:
org.onap.entitiy:1.0.0:
version: 1.0.0
org.onap.entity:2.0.0:
version: 2.0.0
org.onap.entity
version: 3.0.0
So this will load version 1.00, version 2.0.0, and version 4.0.0:
org.onap.entitiy:1.0.0:
version: 1.0.0
org.onap.entity:2.0.0:
version: 2.0.0
org.onap.entity:
version: 3.0.0
org.onap.entity:
version: 4.0.0
This will load
org.onap.entity:1.0.0
name: org.onap.entity
version: 1.0.0
This will throw an exception
org.onap.entity:1.0.0
name: org.onap.some.other.entity
version: 1.0.0
This will throw an exception
org.onap.entity:1.0.0:
name: org.onap.entity
version: 2.0.0
Issue-ID: POLICY-2377
Change-Id: I34bccf065b4ee4d2fe71b052bf009d4a40e2cba8
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Fri, 13 Mar 2020 13:54:28 +0000 (13:54 +0000)]
Adding APEX example to policy models
Change-Id: Idc3da44d99d8d8228a9bc6be49039c2fa02b350e
Issue-ID: POLICY-2424
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Jim Hahn [Thu, 12 Mar 2020 22:55:21 +0000 (18:55 -0400)]
Revert some UUID variable names
Unfortunately, some code uses "new Yaml(...)" to decode policies and
"Yaml" doesn't understand GSON annotations. As a result, this means
that the field names must match the serialized name, thus they must
continue to end with "UUID" instead of "Uuid".
Issue-ID: POLICY-1910
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I97c2f5c7e59b758b13a1dbcceed709b2e2e064a2
Pamela Dragosh [Thu, 12 Mar 2020 19:25:47 +0000 (19:25 +0000)]
Merge "Clean up minor checkstyle/sonar issues"
liamfallon [Thu, 12 Mar 2020 12:15:04 +0000 (12:15 +0000)]
Clean up minor checkstyle/sonar issues
A few minor eclipse warnings and checkstyle warnings in policy models.
Issue-ID: POLICY-1910
Change-Id: I612c6514fa7d88cb8658a7ee1618869a525e48d7
Signed-off-by: liamfallon <liam.fallon@est.tech>
Chris Ramstad [Wed, 11 Mar 2020 23:06:14 +0000 (16:06 -0700)]
SONAR: Squelch bug regarding non-initalized lombok.NonNull values
Issue-ID: POLICY-2389
Signed-off-by: Chris Ramstad <cramstad@ciena.com>
Change-Id: Iba9faf9e878d55022be7882e862ebed826dc76c1
Pamela Dragosh [Wed, 11 Mar 2020 18:05:05 +0000 (14:05 -0400)]
Add message to DecisionResponse
For better error message information to be returned.
Issue-ID: POLICY-2242
Change-Id: I704249c9f4c85b0893b3e004aa1022bd70c87f2e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Wed, 11 Mar 2020 13:18:07 +0000 (13:18 +0000)]
Merge "Add VFC Actor"
Liam Fallon [Tue, 10 Mar 2020 21:20:40 +0000 (21:20 +0000)]
Merge "Immediately finish if guard is disabled"
Pamela Dragosh [Tue, 3 Mar 2020 21:08:37 +0000 (16:08 -0500)]
Add VFC Actor
Adding first cut at VFC Actor.
Issue-ID: POLICY-2386
Change-Id: I4749ed3f350f01d05026057ffe4149f3843d8475
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Jim Hahn [Tue, 10 Mar 2020 14:30:37 +0000 (10:30 -0400)]
Fix field names in SO Actor messages
Issue-ID: POLICY-2371
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I42b6980460c2075544eb7698479b386eff8ef7b5
Jim Hahn [Mon, 9 Mar 2020 14:22:29 +0000 (10:22 -0400)]
Immediately finish if guard is disabled
Modified the Guard Actor to check the "disabled" flag during
start() instead of waiting until it gets down into startOperationAsync.
Issue-ID: POLICY-1625-guard-disabled
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Id6ccf506b82504552d6e1f4637ad11e2e41e77e5
Liam Fallon [Tue, 10 Mar 2020 09:18:30 +0000 (09:18 +0000)]
Merge "Add subrequest ID to OperationOutcome"
Jorge Hernandez [Mon, 9 Mar 2020 22:25:16 +0000 (22:25 +0000)]
Merge "Add optional controllerName in Op. Legacy Policies"
Pamela Dragosh [Mon, 9 Mar 2020 18:04:56 +0000 (18:04 +0000)]
Merge "Fix guard policy types and policies"
jhh [Thu, 5 Mar 2020 20:32:21 +0000 (14:32 -0600)]
Add optional controllerName in Op. Legacy Policies
Optional controllerName has been added to Legacy Operational
policies to be able to route Operational Policies to an
specific drools controller.
Currently, the policies are deployed to all controllers that
support a policy type. In the case, that there are multiple
controllers set, and the policy is only to be routed to one of
them, this field should be populated.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7288ce0069a723b8e6ec535331dc9cda56fbf130
Pamela Dragosh [Sun, 8 Mar 2020 14:39:21 +0000 (10:39 -0400)]
Fix guard policy types and policies
Ensured the correct properties are available for each guard
Policy Type.
Added vDNS blacklist policy for testing.
Issue-ID: POLICY-2243
Change-Id: I1cdcd3810f226446cd12f2123f8a9f41e6b5b4b2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Fri, 6 Mar 2020 23:22:28 +0000 (18:22 -0500)]
Add subrequest ID to OperationOutcome
Rule notifications need the subrequest ID to be populated in the
OperationOutcome object, where possible.
Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ic44320f67ad8df7bcb3000cfa667f95427818e71
Jim Hahn [Fri, 6 Mar 2020 19:00:58 +0000 (14:00 -0500)]
Log full URL for REST calls
Actors only log the URI, without the host and port info. Modified
to log the full URL.
Also adjusted URLs for trailing "/".
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I0c9a2d139258ef23bc363a873b56f5cb4680247d
liamfallon [Fri, 6 Mar 2020 17:17:36 +0000 (17:17 +0000)]
Full version in policy metadata version
Major, minor, and patch version of policy now in policy metadata
version.
Issue-ID: POLICY-2243
Change-Id: I1f3c7054a12e724264b117e399890c9e1c3347f2
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Fri, 6 Mar 2020 15:58:15 +0000 (15:58 +0000)]
Merge "TOSCA Compliant Guard Policies"
Pamela Dragosh [Thu, 5 Mar 2020 12:55:57 +0000 (07:55 -0500)]
TOSCA Compliant Guard Policies
Fixing the legacy guard policies and renaming them so we are
able to differentiate them.
Adding newer, cleaner TOSCA Guard Policies that match the operational
guard policies.
Removing legacy guard policies.
Fixing JUnit so that they don't use indexes to test whether versions
are changed correctly.
Added back in new guard policies. Fixed the guard policy types to use
camel case.
Issue-ID: POLICY-2243
Change-Id: Ie611f26f73f41e64c0b467f524f470739158f437
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Thu, 5 Mar 2020 21:41:15 +0000 (16:41 -0500)]
Add other APPC-LCM operations
Also added legacy ModifyConfig as an operation within APPC-LCM.
Added logging to topic registration keys.
Issue-ID: POLICY-2403
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ia54a573fd6218a8afe870184b9a3baebc05b766a
Jim Hahn [Fri, 6 Mar 2020 01:49:43 +0000 (01:49 +0000)]
Merge "Add SO VF Module Delete Operation"
Jim Hahn [Wed, 4 Mar 2020 02:02:13 +0000 (21:02 -0500)]
Add SO VF Module Delete Operation
Redesigned the SO Operation classes; moved some code from the subclass
to the superclass so it could be reused by the VF Module Delete Operation.
JerseyClient does not support DELETE with a request body, so had to
implement a delete() method using java11 HttpClient.
Fix some issues found while testing with drools-apps.
Added "delete" operation to SO simulator.
Issue-ID: POLICY-2371
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I269fe13cf90c295ec2bbac92bc5a59b3820ea265
jhh [Thu, 5 Mar 2020 18:50:37 +0000 (12:50 -0600)]
Make Controller policy type derived from native
onap.policies.drools.Controller has been made to
be derived from native, and it has been consolidated
under the onap.policies.native.Drools.yaml.
Additionallly some renaming of fields has been done in
an attempt to be more representative of its content.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5b1cf04f36db01b917b77eff4ab5254073be9b0c
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Ram Krishna Verma [Thu, 5 Mar 2020 16:22:53 +0000 (16:22 +0000)]
Merge "Add APPC-LCM actor"
Peyton Puckett [Mon, 2 Mar 2020 22:02:07 +0000 (16:02 -0600)]
Add APPC-LCM actor
Issue-ID: POLICY-2403
Change-Id: Ia7b26cce9ec8308c3d83c374e5ac6aea3af38a1d
Signed-off-by: Peyton Puckett <peyton.puckett@att.com>
Pamela Dragosh [Thu, 5 Mar 2020 13:24:05 +0000 (13:24 +0000)]
Merge "SDNC Actor doesn't use full URL"
Liam Fallon [Thu, 5 Mar 2020 08:14:58 +0000 (08:14 +0000)]
Merge "Fix tca monitoring tca_policy type"
Jim Hahn [Wed, 4 Mar 2020 20:02:45 +0000 (15:02 -0500)]
SDNC Actor doesn't use full URL
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib9e6e4d988013966317df5b7c15867e3691b5748
Jim Hahn [Wed, 4 Mar 2020 17:01:06 +0000 (12:01 -0500)]
Fix exception message in Actors
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1efa70785e162c9a02ed90f5f8d94e85d2432d73
Pamela Dragosh [Wed, 4 Mar 2020 15:29:54 +0000 (10:29 -0500)]
Fix tca monitoring tca_policy type
Should not use map or entry_schema
Issue-ID: POLICY-2408
Change-Id: Ieebe625676edab6c44323b7c69a50cc22099235f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jim Hahn [Tue, 3 Mar 2020 21:54:52 +0000 (16:54 -0500)]
Translate APPC Instant to Long
APPC uses encode Instant fields as milliseconds instead of as
ISO date strings.
Issue-ID: POLICY-2363
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Id9bedb11c43264f882b6fd044155621c8ccc79f6
Ram Krishna Verma [Tue, 3 Mar 2020 19:41:16 +0000 (19:41 +0000)]
Merge "Fix path issues"
liamfallon [Tue, 3 Mar 2020 16:14:34 +0000 (16:14 +0000)]
Return incoming service templates on create
We should return the incoming service template on create requests. This
change is required for CSIT tests.
Issue-ID: POLICY-1402
Change-Id: I1072c9c16d2b267c34fa015e7e7a355ba9f5338a
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Tue, 3 Mar 2020 14:57:35 +0000 (14:57 +0000)]
Merge "Don't log cancellation exception"
Jim Hahn [Tue, 3 Mar 2020 04:55:07 +0000 (23:55 -0500)]
Log topic message before publishing
Code was publishing and then logging the message. Reversed the
order.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1b5dd5e96d86d818cd38d2a671fb37c2576e2054
Jim Hahn [Tue, 3 Mar 2020 02:50:28 +0000 (21:50 -0500)]
Don't log cancellation exception
When an Actor operation is canceled it's done on purpose, yet the whole
exception stack trace is included in the log. Modified the code to
leave out the stack trace for cancellations. I don't THINK this will
cause a sonar issue, as it isn't the exception is never caught via
a "catch" clause.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib5238e4791ae491b30286cdc8ed9caf67432dc26
Jim Hahn [Mon, 2 Mar 2020 21:17:36 +0000 (16:17 -0500)]
Fix path issues
A&AI tenant query is prepending the target entity with "/", but it should
not. Fixed it.
Modified A&AI and SO actors to get path prefixes from parameters.
Fixed a bug in an A&AI simulator response (extra "}" at the end.
Issue-ID: POLICY-2349
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I71f8b1e5fb8a4bd29b4f616a7757d366c7d58127
Ram Krishna Verma [Mon, 2 Mar 2020 21:36:02 +0000 (21:36 +0000)]
Merge "Log Actor parameter error message"
Jim Hahn [Mon, 2 Mar 2020 19:50:11 +0000 (14:50 -0500)]
Log Actor parameter error message
When an operation cannot be configured, the message did not
include information describing the issue. Fixed it.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I671bf27693a8bfa87305099fcefa0e4e0c48928d
Ram Krishna Verma [Fri, 28 Feb 2020 22:53:54 +0000 (17:53 -0500)]
Testcases for cds actor
Adding test cases for cds actor, operator, operation & manager.
Coverage is more than 95% overall.
Fixed review comments.
Issue-ID: POLICY-2384
Change-Id: I64beeb0c46918b990ad7e67248559169fc7940a1
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Pamela Dragosh [Fri, 21 Feb 2020 19:57:50 +0000 (14:57 -0500)]
Add SDNR Actor
Actor for SDNR and necessary JUnit tests.
Removed the Pair code.
Issue-ID: POLICY-2382
Change-Id: I3da1d95f431cc076f12e9ad26280b92058fe51cc
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ram Krishna Verma [Sun, 1 Mar 2020 15:44:26 +0000 (15:44 +0000)]
Merge "Add sequence number to Actors"
Liam Fallon [Sun, 1 Mar 2020 14:38:22 +0000 (14:38 +0000)]
Merge "Sequence throws NPE if task outcome is null"
Jim Hahn [Sat, 29 Feb 2020 19:34:53 +0000 (14:34 -0500)]
Guard Actor is adding the wrong type of Operator
The Guard Actor should be adding a GuardOperator, but it was
adding an HttpOperator, instead. Fixed the code.
Issue-ID: POLICY-2350
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I03517e993442da13a4dbd1eb0c4a0318b0c1c9f2
Jim Hahn [Sat, 29 Feb 2020 18:20:06 +0000 (13:20 -0500)]
Add sequence number to Actors
When actors with duplicate names are loaded, a way is needed to
determine which should take precedence. Added a sequence number to
Actor to facilitate this. Unfortunately, couldn't use OrderedServiceImpl,
because it only creates the Actors once, which would break a number
of junit tests.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I1ade92f4fe516cfc54bb92d0a3624c67e8981075
Jim Hahn [Sat, 29 Feb 2020 13:16:34 +0000 (08:16 -0500)]
Sequence throws NPE if task outcome is null
If a task outcome is null, then sequence() throws an NPE. Modified
it to treat a null outcome as a failure.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I57b8be27f72c7cbf43e0b3b8816696ab1928f396
jhh [Fri, 28 Feb 2020 01:28:59 +0000 (19:28 -0600)]
Remove controllerVersion (no use at this point).
It is not clear what would be the controller version for
at this point. We could add back if we find a good use
for this field.
Issue-ID: POLICY-2388
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ic5dfeb1f39172550c7a0bda538992b0c64d1c71e
Jim Hahn [Wed, 26 Feb 2020 22:14:34 +0000 (17:14 -0500)]
Change ActorService config to Map<String,Object>
It's a bit of a pain to pass Map<String, Map<String,Object>> to
the ActorService configure() method. Changed it to simply take
a Map<String,Object>, as it had been in a previous iteration.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib6e703115027bc4919cc93762ca5b38d254f2b8f
Ram Krishna Verma [Wed, 26 Feb 2020 21:03:39 +0000 (21:03 +0000)]
Merge "ActorService constructor should be public"
Jim Hahn [Wed, 26 Feb 2020 18:37:21 +0000 (13:37 -0500)]
ActorService constructor should be public
Now that ActorService is no longer a singleton, the constructor
should be public so other classes can create an instance.
Also added a test to verify that each ActorService instance gets
its own instances of the actors.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I78cabecc0ca6b355696a5d27489a4e59b6e7c012
Jim Hahn [Wed, 26 Feb 2020 16:07:35 +0000 (11:07 -0500)]
Custom Query should always use vserver
Modified the Custom Query Operation to ignore the target entity
passed via the "params" and always use the vserver name found in
the enrichment data.
Issue-ID: POLICY-2349
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: If2c45df2d0377ca08059bdbfa0bcc3d3f043c5b9
Liam Fallon [Wed, 26 Feb 2020 15:37:35 +0000 (15:37 +0000)]
Merge "Add actor for CDS"
Ram Krishna Verma [Wed, 26 Feb 2020 14:14:58 +0000 (14:14 +0000)]
Merge "Remove ActorService singleton"
Jim Hahn [Tue, 25 Feb 2020 23:33:47 +0000 (18:33 -0500)]
Eliminate a couple more xxxAsync calls in Actors
Eliminated a few more xxxAsync calls in Actors. Now, the remaining
xxxAsync calls are necessary so that the callbacks are executed using
the executor specified via the "params".
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ia4ff758f71f8bbe014ae5b1a58d8439c0d4ea2ed
Ram Krishna Verma [Tue, 25 Feb 2020 21:36:18 +0000 (21:36 +0000)]
Merge "Add "disabled" property to Guard Actor"
Ram Krishna Verma [Fri, 21 Feb 2020 22:24:47 +0000 (17:24 -0500)]
Add actor for CDS
1) Create the operator, operation & manager classes for gRPC request.
2) Use CompletableFuture to track CDS request flow.
Issue-ID: POLICY-2384
Change-Id: I84e30131a69c2d24c1871ceebced2b69194f619c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Pamela Dragosh [Tue, 25 Feb 2020 20:33:49 +0000 (20:33 +0000)]
Merge "Support separate VF Counts for different Targets"
Jim Hahn [Tue, 25 Feb 2020 18:53:28 +0000 (13:53 -0500)]
Remove ActorService singleton
The ActorService singleton is not needed at this time, so it was
removed.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I9b4cbb72cedbeb77b39422e71650ab60c9aec7ec
Jim Hahn [Tue, 25 Feb 2020 17:29:08 +0000 (12:29 -0500)]
Support separate VF Counts for different Targets
Changed the key by which the VF Count is stored within the context
so that each Target can have its own VF Count. Also moved VF Count
code from VfModuleCreate to SoOperation, to hide the determination
of the VF Count "key".
Fixed sonar issue about return "null" instead of returning an empty
list - modified the code to use Optional.
Issue-ID: POLICY-2371
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ia23eabea0edf6857372e269a2db1a21e741824c6
Jim Hahn [Tue, 25 Feb 2020 15:49:32 +0000 (10:49 -0500)]
Add "disabled" property to Guard Actor
Issue-ID: POLICY-2350
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I3e9c9aae474d4b288a162243bc492b301d1044c0
Jim Hahn [Mon, 24 Feb 2020 20:11:35 +0000 (15:11 -0500)]
Add PipelineUtil
Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I7745e8286dd6f086941b979f16b2328bfa066788
Ram Krishna Verma [Tue, 25 Feb 2020 14:37:04 +0000 (14:37 +0000)]
Merge "Move CQ operation name from actor.aai to aai"
Jim Hahn [Mon, 24 Feb 2020 19:37:53 +0000 (14:37 -0500)]
Move CQ operation name from actor.aai to aai
Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I12a7d55b118baa5f0f849855fbcf0602a1208b52
Jim Hahn [Mon, 24 Feb 2020 15:38:07 +0000 (10:38 -0500)]
Add "finalOutcome" flag to OperationOutcome
The Actor clients receive notifications of operation failures, but
no indication if it's the final failure, thus they do not know if
they should progress on to the "failure" policies.
Issue-ID: POLICY-2385
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: If053ed459e1d790e58eca950a8feeabaf4d67a41
Ram Krishna Verma [Mon, 24 Feb 2020 19:01:23 +0000 (19:01 +0000)]
Merge "Change payload to Map<String,Object> so it's more versatile"
a.sreekumar [Fri, 21 Feb 2020 14:06:57 +0000 (14:06 +0000)]
Fix to avoid ConcurrentModificationException in policy-models
Change-Id: If911bdd4116b722e13e00199d05b1794de4e79c2
Issue-ID: POLICY-1402
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Jim Hahn [Fri, 21 Feb 2020 00:08:55 +0000 (19:08 -0500)]
Change payload to Map<String,Object> so it's more versatile
This was supposed to be two separate commits, but I goofed something.
Added guard query to Operation superclass. Modified VfModuleCreate
to store the VF count, pass it to the guard, and bump it once the
create completes successfully.
Added code to check Actors for proper plug-in to ActorService.
Renamed "operation" property to "operations", to be more consistent
with other parameters (e.g., TopicParameterGroup).
The META-INF/services files for the actors had mixed case, which
did not match the package name of the Actor class, preventing the
ServiceLoader from recognizing them. Also modified the ActorService
to skip any that cannot actually be loaded, for whatever reason
(e.g., not in the classpath).
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ifa97744543f2866cc553138ec5ec644b033de780
jhh [Fri, 21 Feb 2020 21:19:12 +0000 (15:19 -0600)]
Modifications in vDNS tosca policies to match spec
Issue-ID: POLICY-2383
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I875612ab47dd35277426fd9ec81d2e5e00188355
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Chenfei Gao [Fri, 21 Feb 2020 17:20:49 +0000 (12:20 -0500)]
Changed the encoding scheme for native xacml policy string
Issue-ID: POLICY-2182
Change-Id: I47dc7253b2ffb325a4a2a873d66499634ae23d16
Signed-off-by: Chenfei Gao <cgao@research.att.com>
Ram Krishna Verma [Fri, 21 Feb 2020 15:37:22 +0000 (15:37 +0000)]
Merge "More actor clean-up"
jhh [Thu, 20 Feb 2020 21:40:08 +0000 (15:40 -0600)]
Corrections in vCPE and vFW tosca to match spec.
Issue-ID: POLICY-2375
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ibffc67dd0b68da8597a5fdff7c65321ef4313352
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Jim Hahn [Thu, 20 Feb 2020 14:40:14 +0000 (09:40 -0500)]
More actor clean-up
Currently, Operator classes refer to Operation classes, and
vice versa, creating a dependency cycle. In addition, there is
a slight problem in that if an operator is reconfigured, any
running operation may get inconsistent configuration data.
Modified the code to create Config objects that are passed to
the operation, instead of passing the Operator to the operations.
This solved both issues.
Replaceed makeOperator() with constructors.
Added parameter type to HttpActors.
Modified guard to get "ONAP" properties from its configuration,
as a default.
Changed setUp() to setUpBasic(), so "throws Exception" could be
removed, thus resolving a sonar issue.
Issue-ID: POLICY-1625
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: I21eb8798acfbc636ff1bd8741b21c7278365b6e4
Jorge Hernandez [Thu, 20 Feb 2020 16:50:04 +0000 (16:50 +0000)]
Merge "Add Guard Actor"
Pamela Dragosh [Thu, 20 Feb 2020 15:42:37 +0000 (15:42 +0000)]
Merge "Minor fix to avoid ConcurrentModificationException in policy-models"
Liam Fallon [Thu, 20 Feb 2020 13:16:30 +0000 (13:16 +0000)]
Merge "Add SO actor"
a.sreekumar [Thu, 20 Feb 2020 11:58:45 +0000 (11:58 +0000)]
Minor fix to avoid ConcurrentModificationException in policy-models
Change-Id: If737f6ae0bcb0f8c694711a67a3c879fee8c11c5
Issue-ID: POLICY-1402
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Jim Hahn [Wed, 19 Feb 2020 22:24:11 +0000 (17:24 -0500)]
Add Guard Actor
Issue-ID: POLICY-2350
Signed-off-by: Jim Hahn <jrh3@att.com>
Change-Id: Ib68c22a1154607563cb8a657b8101757a29b47ef
Pamela Dragosh [Wed, 19 Feb 2020 17:47:18 +0000 (17:47 +0000)]
Merge "Fix cascaded get filtering and speed"