cps.git
47 hours agoMerge "Update latest release of 3GPP ProvMnS interface"
Lee Anjella Macabuhay [Wed, 7 Jan 2026 12:48:33 +0000 (12:48 +0000)]
Merge "Update latest release of 3GPP ProvMnS interface"

2 days agoUpdate latest release of 3GPP ProvMnS interface 46/142846/7
seanbeirne [Mon, 5 Jan 2026 13:47:04 +0000 (13:47 +0000)]
Update latest release of 3GPP ProvMnS interface

- badOP -> badOp
- 204 response code on delete
- Changes made to make Patch error responses compatible with required
  badOp
- Unintended OpenApi yaml file changes made, legacy changes from
  previous commits

Change-Id: I287a11642f7b58112b1bf5440546fb1c7ac7fde0
Signed-off-by: seanbeirne <sean.beirne@est.tech>
3 days agoRemoved extra slash on outgoing fdn 58/142858/1
seanbeirne [Tue, 6 Jan 2026 09:34:41 +0000 (09:34 +0000)]
Removed extra slash on outgoing fdn

- Extra preceding slash added for longest match search
- Now will be removed when forwarding to dmi

Issue-ID: CPS-2707
Change-Id: Id81bb18ce0718dc7b63beb2a71ddebe1311e4cd5
Signed-off-by: seanbeirne <sean.beirne@est.tech>
3 days agofix: 100% code coverage for ParameterMapper 43/142843/1
emaclee [Mon, 5 Jan 2026 13:29:16 +0000 (13:29 +0000)]
fix: 100% code coverage for ParameterMapper

Issue-ID: CPS-3093
Change-Id: I7eefa3cf389d10b737a990704de74e8c455ff839
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
7 days agoMerge "Revert docker compose config to 2 instances"
Lee Anjella Macabuhay [Fri, 2 Jan 2026 11:27:08 +0000 (11:27 +0000)]
Merge "Revert docker compose config to 2 instances"

7 days agoRevert docker compose config to 2 instances 40/142840/1
seanbeirne [Fri, 2 Jan 2026 10:57:54 +0000 (10:57 +0000)]
Revert docker compose config to 2 instances

Issue-ID: CPS-3093
Change-Id: Id0a4390d3062eff62712e39bf065967386e6e87a
Signed-off-by: seanbeirne <sean.beirne@est.tech>
7 days agoMerge "Adjust timing for Delta Report performance test and make OpenROADM test data...
Lee Anjella Macabuhay [Fri, 2 Jan 2026 08:42:26 +0000 (08:42 +0000)]
Merge "Adjust timing for Delta Report performance test and make OpenROADM test data deterministic"

2 weeks agoRefactor ProvMnS error handling and simplify request parameters 83/142783/3
ToineSiebelink [Thu, 11 Dec 2025 16:10:20 +0000 (16:10 +0000)]
Refactor ProvMnS error handling and simplify request parameters

This update covers several tickets: CPS-3078, CPS-3093, CPS-3095, CPS-3096, CPS-3099
- Consolidate error handling in ProvMnSRestExceptionHandler
  - changed reason to title
- Remove ErrorResponseBuilder and integrate functionality into exception handler
- Refactor ProvMnsController and centralize error handling into 1 common method. including
  - correct code for Policy Executor denial
  - handle timeouts
  - handle all other exceptions
  - handle #/attribute reference validation depending on content type
- Enhance ProvMnSException with additional error handling capabilities
  use ProvMnSException to store the information to create the correct error response
- Simplify OperationDetailsFactory implementation

TODO: Remove docker config updates for debugging
TODO Lee Anjella
   - Check if a mapping to type is available for every possible statuscode in provMnsExceptions
   - COVREAGE 100% MIsine exception in ParameterMapper.java

Issue-ID: CPS-3093
Change-Id: Ic5ed5a8502ebf74166c73c037884979f468cdb8d
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
2 weeks agoMerge "fix: Reduce high cardinality in ProvMnS API client metrics"
Toine Siebelink [Mon, 22 Dec 2025 17:51:53 +0000 (17:51 +0000)]
Merge "fix: Reduce high cardinality in ProvMnS API client metrics"

2 weeks agofix: Reduce high cardinality in ProvMnS API client metrics 90/142790/5
emaclee [Mon, 22 Dec 2025 13:42:59 +0000 (13:42 +0000)]
fix: Reduce high cardinality in ProvMnS API client metrics

- Add ClientRequestMetricsTagCustomizer to template FDN values in URI metrics
- Apply custom metrics handler to DMI WebClients
- Template URI from /ProvMnS/v1/SubNetwork=A/ManagedElement=E to /ProvMnS/v1/{fdn}
- Preserve query parameters as templates for operational visibility
- Fix existing tests to handle new WebClient configuration dependencies

Issue-ID: CPS-3067
Change-Id: I98b972a9d84f6e6710e82ae73bc5499771c3a340
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 weeks agoMerge "Add dmi-properties to integration test"
Lee Anjella Macabuhay [Fri, 19 Dec 2025 09:48:28 +0000 (09:48 +0000)]
Merge "Add dmi-properties to integration test"

3 weeks agoMerge "Part 2: Add delta report in Kafka notification"
Lee Anjella Macabuhay [Fri, 19 Dec 2025 09:47:44 +0000 (09:47 +0000)]
Merge "Part 2: Add delta report in Kafka notification"

3 weeks agoAdjust timing for Delta Report performance test and make OpenROADM test data determin... 09/142809/4
Arpit Singh [Thu, 18 Dec 2025 05:21:11 +0000 (10:51 +0530)]
Adjust timing for Delta Report performance test and make OpenROADM test data deterministic

- Adjusted timing for Delta Report performance test to account for changes
  observed after isolating anchors within DeltaPerfTest.
- Change applies to Delta between 2 anchors test
- Modified approach for creating modified OpenROADM test data:
  - Replaced random generation with deterministic logic
  - Ensures consistent and reliable performance test results

Issue-ID: CPS-3101
Change-Id: Ic64e242d400915a958b9817407a3b0fa991b86a7
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
3 weeks agoPart 2: Add delta report in Kafka notification 67/142267/19
Arpit Singh [Thu, 30 Oct 2025 13:06:16 +0000 (18:36 +0530)]
Part 2: Add delta report in Kafka notification

Added support for delta report in kafka notifications for CPS core
endpoints.
The following methods are supported in this path:
 - saveData, saveListElements,
   updateNodeLeavesAndExistingDescendantLeaves, updateNodeLeaves,
   updateDataNodeAndDescendants, replaceListContent, deleteDataNode,
   deleteListOrListElement, deleteDataNodes.
The following methods are not supported in this patch:
 - updateDataNodesAndDescendants, deleteDataNodes
 As they need a separate method to generate delta report and then send
 the notifications, which can be done as a separate patch.

Issue-ID: CPS-3026
Change-Id: I28700c67df55e8e19754d7ca9e9a1aab5540fc71
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
3 weeks agoMerge "Bug: k6 logs not saving"
Toine Siebelink [Wed, 17 Dec 2025 13:16:42 +0000 (13:16 +0000)]
Merge "Bug: k6 logs not saving"

3 weeks agoAdd dmi-properties to integration test 80/142780/1
egernug [Wed, 17 Dec 2025 12:36:40 +0000 (12:36 +0000)]
Add dmi-properties to integration test

Issue-ID: CPS-3061

Change-Id: I1dbf82bf6674875242f640f36caeedfcb7668764
Signed-off-by: egernug <gerard.nugent@est.tech>
3 weeks agoBug: k6 logs not saving 78/142778/2
emaclee [Tue, 16 Dec 2025 19:06:09 +0000 (19:06 +0000)]
Bug: k6 logs not saving

- renamed make-logs.sh to archive-logs.sh
- refactored archive-logs.sh for better readability
- implemented log file numbering with newest files first
- modified so only one zip folder for each test run; zip folder
  contains all services logs
- improve timestamp format for better readability
- moved log collection action from teardown to main script
  exit handler
- ensure logs are captured regardless of test outcome

Issue-ID:CPS-3079
Change-Id: I6d90c9be95ea61c29a1fa2ecdc4ea4d022420e85
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 weeks agoMerge "Migrate cm-handles.additional-properties to cm-handles.dmi-properties"
Toine Siebelink [Wed, 17 Dec 2025 11:05:29 +0000 (11:05 +0000)]
Merge "Migrate cm-handles.additional-properties to cm-handles.dmi-properties"

3 weeks agoMerge "Fix: update documentation for CPS-2428 notification subscription APIs"
Toine Siebelink [Tue, 16 Dec 2025 10:58:43 +0000 (10:58 +0000)]
Merge "Fix: update documentation for CPS-2428 notification subscription APIs"

3 weeks agoMigrate cm-handles.additional-properties to cm-handles.dmi-properties 54/142754/4
egernug [Tue, 9 Dec 2025 12:26:42 +0000 (12:26 +0000)]
Migrate cm-handles.additional-properties to cm-handles.dmi-properties

- Split bulkUpdateCmHandleStatesAndProperties and updateCmHandleFields to perform separate tasks
- updateCmHandleFields updates fields in previous use cases
- bulkUpdateCmHandleStatesAndProperties only updates fields for migration purposes
- Added dmiProperties to CmHandleStateAndDmiPropertiesUpdate
- Added convertAdditionalPropertiesToJson to convert additionalProperties to dmiProperties

Issue-ID: CPS-3063

Change-Id: I7560a289150147d1cda40e75a41d52c2723316e8
Signed-off-by: egernug <gerard.nugent@est.tech>
3 weeks agoMerge "Isolate Delta Report performance test data"
Toine Siebelink [Tue, 16 Dec 2025 09:03:29 +0000 (09:03 +0000)]
Merge "Isolate Delta Report performance test data"

3 weeks agoIsolate Delta Report performance test data 65/142665/3
Arpit Singh [Wed, 10 Dec 2025 05:13:38 +0000 (10:43 +0530)]
Isolate Delta Report performance test data

- Delta report performance tests shared openroadm anchor with other
  performance tests in CPS.
- The patch removes the use of openroadm anchors for Delta Report
  performance tests.
- Delta Report performance tests now use two independent anchors as
  source and target: delta-report-anchor and openroadm-modified.
- Both the anchors are deleted once the Delta Report tests finish
  executing.
- Removed @Ignore from first Delta Report test to check if there is any
  impact on other CPS performance tests.

Issue-ID: CPS-3092
Change-Id: Ib1107329973d58cb4b90091f4983d3f42e07a3d7
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
4 weeks agoFix: update documentation for CPS-2428 notification subscription APIs 68/142668/4
Arpit Singh [Wed, 10 Dec 2025 12:25:38 +0000 (17:55 +0530)]
Fix: update documentation for CPS-2428 notification subscription APIs

Three APIs were added to manage CPS notifications:
- Create notification subscription
- Get notification subscription
- Delete notification subscription

Swagger examples were outdated and did not reflect the correct fields.
Updated documentation to ensure accurate examples for successful API execution.

- Added missing Javadoc in notification subscription class for better clarity.

Issue-ID: CPS-3094
Change-Id: I740b7721d8cfe4cea38a9da014b99989e3e13027
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
4 weeks agoFix Null Pointer Exception during LCM Event Metric Recording 24/142724/2
ToineSiebelink [Wed, 10 Dec 2025 15:34:36 +0000 (15:34 +0000)]
Fix Null Pointer Exception during LCM Event Metric Recording

- Add null check when recording metric for unknown states (initial create and delete use cases)
- Extend Create Integration test to verify the (number of) recording metrics
- Moved Instrumentation bean to integration testbase as it is now used in several test classes
- Update version of docker test container to latest (part of troubleshooting with Docker for windows integration)
- Clean up some legacy issues in related integration testware
  - unnecessary and distracting spacing
  - correct use of #testValue in descriptions

Issue-ID:CPS-3088

Change-Id: Ic1163e33606ee2fe2c4e136e63282708a4625f60
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
4 weeks agoMerge "Update Patch Operation to make multiple calls to Policy Executor"
Toine Siebelink [Tue, 9 Dec 2025 16:11:32 +0000 (16:11 +0000)]
Merge "Update Patch Operation to make multiple calls to Policy Executor"

4 weeks agoUpdate Patch Operation to make multiple calls to Policy Executor 34/142634/4
leventecsanyi [Wed, 3 Dec 2025 12:21:56 +0000 (13:21 +0100)]
Update Patch Operation to make multiple calls to Policy Executor

  - refatored OperationDetailsFactory
  - updated testware

Issue-ID: CPS-3071
Change-Id: Ic078c7c8125dc1424e3c9e379fc617b07b8f6fec
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
4 weeks agoAccept single-element FDN in the ProvMnS interface 93/142693/2
leventecsanyi [Mon, 8 Dec 2025 11:39:37 +0000 (12:39 +0100)]
Accept single-element FDN in the ProvMnS interface

 - removed extra validation to accept simple FDNs

Issue-ID: CPS-3077
Change-Id: I67d19d45957e4cfa11b9776bdc42f5253b9593aa
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
4 weeks agoMerge "refactor: Remove LcmEventHeader parameter from sendLcmEvent method"
Lee Anjella Macabuhay [Mon, 8 Dec 2025 10:40:10 +0000 (10:40 +0000)]
Merge "refactor: Remove LcmEventHeader parameter from sendLcmEvent method"

4 weeks agoMerge "Update current expectation for k6 tests #3"
Toine Siebelink [Mon, 8 Dec 2025 10:38:57 +0000 (10:38 +0000)]
Merge "Update current expectation for k6 tests #3"

4 weeks agoUpdate current expectation for k6 tests #3 85/142685/1
halil.cakal [Mon, 8 Dec 2025 09:05:14 +0000 (09:05 +0000)]
Update current expectation for k6 tests #3

- The new values (current expectation) is adjusted according to avarage
  value of test results after excluding the peaks (while other tests are
also running in parallel)

Issue-ID: CPS-2697

Change-Id: I7e929d188dc0d4b90a95e7d884b4583b0f4ee7db
Signed-off-by: halil.cakal <halil.cakal@est.tech>
4 weeks agoBump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml 77/142677/1
dependabot[bot] [Mon, 8 Dec 2025 00:24:10 +0000 (00:24 +0000)]
Bump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml

Bumps [lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml](https://github.com/lfit/releng-reusable-workflows) from 0.2.26 to 0.2.28.
- [Release notes](https://github.com/lfit/releng-reusable-workflows/releases)
- [Commits](https://github.com/lfit/releng-reusable-workflows/compare/f8814d81051c7a2e4d7584657b4d283b62a56b20...b4c8bfdea114d034bfa6ed2fe2c9775bc091d5ca)

updated-dependencies:
- dependency-name: lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml
  dependency-version: 0.2.28
  dependency-type: direct:production
  update-type: version-update:semver-patch

CIMAN-33

Change-Id: I62483d24900bf17eb7f06838ecfcd757e9ad05fc
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: onap.gh2gerrit <releng+onap-gh2gerrit@linuxfoundation.org>
5 weeks agoUpdate current expectation (cps limit) for k6 tests #2 45/142645/1
halil.cakal [Thu, 4 Dec 2025 16:25:40 +0000 (16:25 +0000)]
Update current expectation (cps limit) for k6 tests #2

- More fine tuninng on current expectations

Issue-ID: CPS-2697

Change-Id: I64aad8e911a2dbe39768a1329ce83d25891376a8
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 weeks agorefactor: Remove LcmEventHeader parameter from sendLcmEvent method 41/142641/2
ToineSiebelink [Wed, 3 Dec 2025 10:47:52 +0000 (10:47 +0000)]
refactor: Remove LcmEventHeader parameter from sendLcmEvent method

- Remove LcmEventHeader parameter from LcmEventsProducer.sendLcmEvent()
- Extract headers directly from LcmEvent object using new extractHeadersAsMap() method
- Remove json definition of now unnecessary lcm event header object
- Fix bug(?) related to recording metrics when sending event failed
- Removed unnecessary null checks for status during metric record
- Refactored LcmEventHelper, LcmEventProducer and LcmEventProducerHelper into 3 classes with clear responsibilities
  LcmEventProducer               : can send events (depends on LcmObjectCreator)
  LcmEventObjectCreator          : create events(depends on CmHandlePropertyChangeDetector)
  CmHandlePropertyChangeDetector : detects the updates
- Cleaned up corresponding test classes
- Renamed cps/events/EventsProducer.java to cps/events/EventProducer (singular, consistent with other classes)
  (apologies, this caused updates for 3/4 of the files in this commit)
- Renamed dmi/EventProducer to dmi/DmiEventProducer to avoid clashes with main EventProducer (in some testware)

Issue-ID: CPS-3072
Change-Id: I2126fed8a1d45c0360a777b4419103804c5ff9f2
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
5 weeks agoMerge "Fix Replace a Node API behaviour handling List items"
Lee Anjella Macabuhay [Thu, 4 Dec 2025 14:30:25 +0000 (14:30 +0000)]
Merge "Fix Replace a Node API behaviour handling List items"

5 weeks agoMerge "Added k8 specific tests for second dmi-stub in postman-collections"
Lee Anjella Macabuhay [Thu, 4 Dec 2025 13:37:26 +0000 (13:37 +0000)]
Merge "Added k8 specific tests for second dmi-stub in postman-collections"

5 weeks agoMerge "Update current expectation (cps limit) for k6 tests"
Toine Siebelink [Thu, 4 Dec 2025 13:25:41 +0000 (13:25 +0000)]
Merge "Update current expectation (cps limit) for k6 tests"

5 weeks agoUpdate current expectation (cps limit) for k6 tests 39/142639/1
halil.cakal [Thu, 4 Dec 2025 10:23:28 +0000 (10:23 +0000)]
Update current expectation (cps limit) for k6 tests

- After k6 started to use k8s cluster, current test expectations have
  been improved for some k6 tests, thus values updated

Issue-ID: CPS-2697

Change-Id: I5bdda7cd5be480d14806d015416bfd1bd09e8117
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 weeks agoFix Replace a Node API behaviour handling List items 71/142271/20
Arpit Singh [Wed, 3 Dec 2025 11:47:59 +0000 (17:17 +0530)]
Fix Replace a Node API behaviour handling List items

Jira - [CPS-2708] Enhance Replace A Node with List Items
Documentation - https://lf-onap.atlassian.net/wiki/x/gIDMAQ

- Previously, Replace a node endpoint accepted list items and returned a
  200 OK response, but the data was not actually replaced when cross
  checked.
- This patch fixes the issue of phantom replace operations and ensures
  that the API correctly handles list items.

Issue-ID:CPS-2708
Change-Id: Ibc9bbb88ccbb07302355321c6d5c2eade0e7e5fa
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
5 weeks agoMerge "Fix response code returned by Get delta between 2 anchors API"
Toine Siebelink [Thu, 4 Dec 2025 08:53:31 +0000 (08:53 +0000)]
Merge "Fix response code returned by Get delta between 2 anchors API"

5 weeks agoMerge "Integration test for state migration job"
Toine Siebelink [Thu, 4 Dec 2025 08:48:45 +0000 (08:48 +0000)]
Merge "Integration test for state migration job"

5 weeks agoFix response code returned by Get delta between 2 anchors API 68/142368/9
Arpit Singh [Fri, 14 Nov 2025 12:24:29 +0000 (17:54 +0530)]
Fix response code returned by Get delta between 2 anchors API

- Get delta between 2 anchors returned a 200 OK response in case an
  invalid xpath is provided with the request.
- The patch fixes that and now the API returns 400 BAD RERQUEST when an
  invalid xpath is used

Issue-ID: CPS-3041
Change-Id: Ic73003fdcf8e2f67cdf715f8da7641016ba61258
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
5 weeks agoIntegration test for state migration job 23/142623/4
egernug [Tue, 2 Dec 2025 11:40:45 +0000 (11:40 +0000)]
Integration test for state migration job

- Added DataMigrationIntegrationSpec test class
- Changed migrateInventoryToModelRelease20250722 signature to take in batch size
- Changed InventoryModelLoaderSpec to call upgradeAndMigrateInventoryModel() directly
- Added schemaSetExists() check in ModuleUpgradeServiceIntegrationSpec to allow for suite and isolated execution

Issue-ID: CPS-3061

Change-Id: I2a51a5e3fae91155396357500f5e2d2cec70f8df
Signed-off-by: egernug <gerard.nugent@est.tech>
5 weeks agoMerge "Move ConditionProperties from CPS to NCMP"
Lee Anjella Macabuhay [Wed, 3 Dec 2025 12:57:27 +0000 (12:57 +0000)]
Merge "Move ConditionProperties from CPS to NCMP"

5 weeks agoMove ConditionProperties from CPS to NCMP 68/142568/4
shikha0203 [Thu, 27 Nov 2025 10:32:33 +0000 (10:32 +0000)]
Move ConditionProperties from CPS to NCMP

Issue-ID: CPS-2729
Change-Id: Iba04f16a000dd461165ab8db18bd71e168a64eb2
Signed-off-by: shikha0203 <shivani.khare@est.tech>
5 weeks agoExpand Integration test to verify LCM Event 29/142629/2
ToineSiebelink [Tue, 2 Dec 2025 17:32:19 +0000 (17:32 +0000)]
Expand Integration test to verify LCM Event

- Fixed small bug: EventId and EventTime in header and event should be identical
- Check LCM event details for common fields
- Check Header value and corresponding event fields (duplicated!)
- Check old and new value for create and update use cases
- Removed unessary public method

Issue-ID: CPS-3072
Change-Id: I4eaa44747e0ca4c631dea037a2f55a307e0ad1a4
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
5 weeks agoMerge "Limit number of operations in a ProvMnS PATCH request"
Toine Siebelink [Tue, 2 Dec 2025 11:02:38 +0000 (11:02 +0000)]
Merge "Limit number of operations in a ProvMnS PATCH request"

5 weeks agoLimit number of operations in a ProvMnS PATCH request 75/142575/2
seanbeirne [Fri, 28 Nov 2025 11:22:09 +0000 (11:22 +0000)]
Limit number of operations in a ProvMnS PATCH request

-New configurable stting in application.yml

Issue-ID: CPS-3070
Change-Id: Ia41ec57cd72a19da989b85b3dbd88e36b2f2dc5b
Signed-off-by: seanbeirne <sean.beirne@est.tech>
5 weeks agoAdded k8 specific tests for second dmi-stub in postman-collections 49/142449/4
halil.cakal [Fri, 14 Nov 2025 11:47:50 +0000 (11:47 +0000)]
Added k8 specific tests for second dmi-stub in postman-collections

- added new env. variable suit for k8s deployment
- new tests are added for k8s, all using the new env. suit:
  - cm handle registration for dmi-stub-1 and dmi-stub-2 each having two
    cm handles
  - cm handle get for dmi-stub-1 and dmi-stub-2
  - get resource data operation
  - delete cm handles for both dmis

Issue-ID: CPS-3039

Change-Id: Icd0a99b09d4c83a356886dbc9b80ea9463fb35a8
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 weeks agoError Handling for unsupported ProvMnS PATCH operations 76/142576/1
seanbeirne [Fri, 28 Nov 2025 16:18:54 +0000 (16:18 +0000)]
Error Handling for unsupported ProvMnS PATCH operations

Issue-ID: CPS-3068
Change-Id: I906038c79e17b63ac228ccfcb8a39fcf72e294d7
Signed-off-by: seanbeirne <sean.beirne@est.tech>
6 weeks agoMerge "Migrate state data to new cm-handles.cm-handle-state"
Lee Anjella Macabuhay [Thu, 27 Nov 2025 16:09:06 +0000 (16:09 +0000)]
Merge "Migrate state data to new cm-handles.cm-handle-state"

6 weeks agoMigrate state data to new cm-handles.cm-handle-state 24/142424/13
egernug [Thu, 13 Nov 2025 11:31:12 +0000 (11:31 +0000)]
Migrate state data to new cm-handles.cm-handle-state

- Added new DataMigration class to perform migration
- Amended InventoryModelLoader to use migration class
- Moved setAndUpdateCmHandleField to InventoryPersistence and made public
- Created bulk implementation of setAndUpdateCmHandleField

Issue-ID: CPS-3023

Change-Id: Ie6ee5af7d3edb1a4e27de358da1da3624af04f48
Signed-off-by: egernug <gerard.nugent@est.tech>
6 weeks agoMerge "Improve mapping for Resource objects in PolicyExecutor"
Lee Anjella Macabuhay [Thu, 27 Nov 2025 08:58:53 +0000 (08:58 +0000)]
Merge "Improve mapping for Resource objects in PolicyExecutor"

6 weeks agoMerge "Bump to version 3.7.4"
Lee Anjella Macabuhay [Wed, 26 Nov 2025 14:17:32 +0000 (14:17 +0000)]
Merge "Bump to version 3.7.4"

6 weeks agoBump to version 3.7.4 30/142530/3
egernug [Wed, 26 Nov 2025 13:38:38 +0000 (13:38 +0000)]
Bump to version 3.7.4

Issue-ID: CPS-3047

Change-Id: I42ac0c2ed389f7fd13647dc473c53bb80c414783
Signed-off-by: egernug <gerard.nugent@est.tech>
6 weeks agoMerge "Add container 3.7.3"
Lee Anjella Macabuhay [Wed, 26 Nov 2025 13:34:20 +0000 (13:34 +0000)]
Merge "Add container 3.7.3"

6 weeks agoAdd container 3.7.3 26/142526/1
egernug [Wed, 26 Nov 2025 13:17:46 +0000 (13:17 +0000)]
Add container 3.7.3

Issue-ID: CPS-3047

Change-Id: I539b3451b5c78638824b29b81ef165b60dbba9f0
Signed-off-by: egernug <gerard.nugent@est.tech>
6 weeks agoMerge "Add maven stage yaml for release 3.7.3"
Lee Anjella Macabuhay [Wed, 26 Nov 2025 13:01:12 +0000 (13:01 +0000)]
Merge "Add maven stage yaml for release 3.7.3"

6 weeks agoAdd maven stage yaml for release 3.7.3 23/142523/1
egernug [Wed, 26 Nov 2025 12:13:00 +0000 (12:13 +0000)]
Add maven stage yaml for release 3.7.3

Issue-ID: CPS-3047

Change-Id: I4d15e44e7f9d9cfb2f043c22ec39dcd1b46e95ff
Signed-off-by: egernug <gerard.nugent@est.tech>
6 weeks agoMerge "ProvMnS Get to support additional type in return"
Toine Siebelink [Wed, 26 Nov 2025 09:22:39 +0000 (09:22 +0000)]
Merge "ProvMnS Get to support additional type in return"

6 weeks agoImprove mapping for Resource objects in PolicyExecutor 13/142513/4
leventecsanyi [Tue, 25 Nov 2025 08:24:12 +0000 (09:24 +0100)]
Improve mapping for Resource objects in PolicyExecutor

  - added ResourceObjectDetails for improved mapping
  - added OperationDetailsFactory service and moved related code there from PolicyExecutor

Issue-ID: CPS-3059
Change-Id: Ib6c9329cf89b25f5507a07bb7a6e36c2f06cf259
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
6 weeks agoMerge "Fix Sonarcube violations"
Toine Siebelink [Tue, 25 Nov 2025 17:12:02 +0000 (17:12 +0000)]
Merge "Fix Sonarcube violations"

6 weeks agoRevert commit (ncmp): for Connection refused exp. in DmiRestClient #2 16/142516/1
halil.cakal [Tue, 25 Nov 2025 14:34:31 +0000 (14:34 +0000)]
Revert commit (ncmp): for Connection refused exp. in DmiRestClient #2

- This is a manual revert for the commit : 142464: changed env. variable server.port for dmi-stub | https://gerrit.onap.org/r/c/cps/ncmp-dmi-plugin/+/142464
- There have been k6 failures after build # : 2637

Issue-ID: CPS-3056

Change-Id: I369ba0d6c7f69bd9501668e7e2d63c89596c98e3
Signed-off-by: halil.cakal <halil.cakal@est.tech>
6 weeks agoMerge "Code Coverage gaps in CPS-NCMP-Service 100%"
Lee Anjella Macabuhay [Tue, 25 Nov 2025 13:31:43 +0000 (13:31 +0000)]
Merge "Code Coverage gaps in CPS-NCMP-Service 100%"

6 weeks agoProvMnS Get to support additional type in return 14/142514/1
seanbeirne [Tue, 25 Nov 2025 12:55:55 +0000 (12:55 +0000)]
ProvMnS Get to support additional type in return

- application/vnd.3gpp.object-tree-hierarchical+json now supported

Issue-ID: CPS-3066
Change-Id: I2dc85459987f0f58e850a04ab4b09e34a7b2e62a
Signed-off-by: seanbeirne <sean.beirne@est.tech>
6 weeks agoFix Sonarcube violations 04/142504/3
seanbeirne [Mon, 24 Nov 2025 13:44:00 +0000 (13:44 +0000)]
Fix Sonarcube violations

- Extracted NOT READY to static variable
- Restructured Try catch blocks in controller
- Resolved minor code smells

Issue-ID: CPS-475
Change-Id: I25b7ac93e4d8bff46ab9281b55ac05e479ef2e31
Signed-off-by: seanbeirne <sean.beirne@est.tech>
6 weeks agoMerge "changed env. variable to SERVER_PORT for pod dmi-stub-2"
Toine Siebelink [Mon, 24 Nov 2025 17:20:08 +0000 (17:20 +0000)]
Merge "changed env. variable to SERVER_PORT for pod dmi-stub-2"

6 weeks agoMerge "Bump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard...
Toine Siebelink [Mon, 24 Nov 2025 17:01:50 +0000 (17:01 +0000)]
Merge "Bump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml"

6 weeks agoCode Coverage gaps in CPS-NCMP-Service 100% 05/142505/1
ToineSiebelink [Mon, 24 Nov 2025 12:10:44 +0000 (12:10 +0000)]
Code Coverage gaps in CPS-NCMP-Service 100%

- Covered last 3 remaining gaps
- Removed Coverage setting from CPS NCMP Service module pom so its set by parent to 100% ðŸ˜Š
- Removed Coverage setting from CPS NCMP Rest module pom so its set by parent to 100% ðŸ˜Š

Issue-ID: CPS-475
Change-Id: I63774f7bf4a7e44a0a4f143df5964c384783de85
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
6 weeks agoAdding @Ignore on delta performance tests while analysis 02/142502/1
emaclee [Mon, 24 Nov 2025 13:20:44 +0000 (13:20 +0000)]
Adding @Ignore on delta performance tests while analysis

- Reverted the following:
- CPS-3031: https://gerrit.onap.org/r/c/cps/+/142353
- CPS-3032: https://gerrit.onap.org/r/c/cps/+/142359
- CPS-3033: https://gerrit.onap.org/r/c/cps/+/142363

Issue-ID: CPS-3033
Change-Id: Ic8107961d4da5b97d840b34e382fd6f390738c91
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
6 weeks agoMerge "Filling Code Coverage gaps in CPS-NCMP-Service"
Lee Anjella Macabuhay [Mon, 24 Nov 2025 13:05:45 +0000 (13:05 +0000)]
Merge "Filling Code Coverage gaps in CPS-NCMP-Service"

6 weeks agoFilling Code Coverage gaps in CPS-NCMP-Service 60/142460/2
ToineSiebelink [Thu, 20 Nov 2025 15:37:25 +0000 (15:37 +0000)]
Filling Code Coverage gaps in CPS-NCMP-Service

- Removed unused variation of ProvMnS exception
- Cover error scenarios on Inventory Facade Impl
- Refactored LCM Event sending to always use (batch) of CmHandleTransitionPair
  (this meant I could avoid a different variations that was hard to test, and simply removed redundant duplicated code
- Add tested for simple data object no used in any current test
- Added some additional (typically negative) scenarios in existing test
- Change LCM Event related methods signatures to use term 'current' and 'target' and in that order consistently
- Refactored (simplified) Lcm Event Helper had a lot of unnecessary method splitting ending up in bad names like populateX & create
- Simplified arg[] handle and some other groovy improvement in related tests

Issue-ID:CPS-475

Change-Id: Ifd1ec6246a316098dec62a8f6737f90cfda36de5
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
6 weeks agoBump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml 66/142466/1
dependabot[bot] [Mon, 24 Nov 2025 00:31:36 +0000 (00:31 +0000)]
Bump lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml

Bumps [lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml](https://github.com/lfit/releng-reusable-workflows) from 0.2.25 to 0.2.26.
- [Release notes](https://github.com/lfit/releng-reusable-workflows/releases)
- [Commits](https://github.com/lfit/releng-reusable-workflows/compare/21dee35da5cf13331dad63a2c81ae5bb6d023f95...f8814d81051c7a2e4d7584657b4d283b62a56b20)

updated-dependencies:
- dependency-name: lfit/releng-reusable-workflows/.github/workflows/reuse-openssf-scorecard.yaml
  dependency-version: 0.2.26
  dependency-type: direct:production
  update-type: version-update:semver-patch

CIMAN-33

Change-Id: I7fff337a77105ca5f84f0fba394e44572b6657c3
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: onap.gh2gerrit <releng+onap-gh2gerrit@linuxfoundation.org>
6 weeks agochanged env. variable to SERVER_PORT for pod dmi-stub-2 65/142465/1
halil.cakal [Fri, 21 Nov 2025 13:27:49 +0000 (13:27 +0000)]
changed env. variable to SERVER_PORT for pod dmi-stub-2

- minikube can not bind env. variable if it was DMI_STUB_SERVER_PORT for
  the pod dmi-stub-2, thus it changed to SERVER_PORT to solve the
problem

Issue-ID: CPS-3056

Change-Id: I7948ca540a01d0cd244698a7ce2bd43201e83634
Signed-off-by: halil.cakal <halil.cakal@est.tech>
7 weeks agoDelete cmSubscriptionConfigSpec groovy file 62/142462/1
seanbeirne [Fri, 21 Nov 2025 10:03:42 +0000 (10:03 +0000)]
Delete cmSubscriptionConfigSpec groovy file

-Pointed to deleted java file

Issue-ID: CPS-475
Change-Id: Ic56ca33bfe53cf6209f785727b3ea9b3a5397fcf
Signed-off-by: seanbeirne <sean.beirne@est.tech>
7 weeks agoMerge "Bug: ProvMnS error handling returning all DMI error responses as 500"
Lee Anjella Macabuhay [Fri, 21 Nov 2025 09:52:33 +0000 (09:52 +0000)]
Merge "Bug: ProvMnS error handling returning all DMI error responses as 500"

7 weeks agoMerge "Fix casting issue for Patch operation"
Toine Siebelink [Thu, 20 Nov 2025 15:45:23 +0000 (15:45 +0000)]
Merge "Fix casting issue for Patch operation"

7 weeks agoMerge "Add tests for coverage in subscription files"
Toine Siebelink [Thu, 20 Nov 2025 15:24:00 +0000 (15:24 +0000)]
Merge "Add tests for coverage in subscription files"

7 weeks agoAdd tests for coverage in subscription files 59/142459/2
emaclee [Thu, 20 Nov 2025 14:29:58 +0000 (14:29 +0000)]
Add tests for coverage in subscription files

- added tests to cover lines in subscription related classes
- removed unused subscription cache (legacy)

Issue-ID: CPS-475
Change-Id: I9621e6f999399e70d20e1c289f8d991c649636ac
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
7 weeks agoFix casting issue for Patch operation 46/142446/10
leventecsanyi [Fri, 14 Nov 2025 14:54:09 +0000 (15:54 +0100)]
Fix casting issue for Patch operation

  - fixed casting issue for Resource
  - refactored mapping logic for patch item

Issue-ID: CPS-3055
Change-Id: Ia471e53bde656bb7865aee6616f1ad57e44f82bf
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
7 weeks agoImprove code coverage CPS-NCMP-Service 58/142458/2
ToineSiebelink [Tue, 18 Nov 2025 10:05:33 +0000 (10:05 +0000)]
Improve code coverage CPS-NCMP-Service

- Increase coverage threshold cps-ncmp-service to 99%
- Use real configuration classes for DMI Client Integration Test
  (fills big coverage gap in WebClientConfiguration)
- Filled testing gaps in CM AVC Events package
  (partly by removing redundant code!)
- Filled testing gaps in hazelcast cache configs
- Added missing test for Inventory Persistence service

Issue-ID: CPS-475
Change-Id: I0987427c4d50ed48848809d10f3486af6e14312b
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
7 weeks agoMerge "Add Rejected scenario(s) for create subscription"
Toine Siebelink [Thu, 20 Nov 2025 11:39:52 +0000 (11:39 +0000)]
Merge "Add Rejected scenario(s) for create subscription"

7 weeks agoAdd Rejected scenario(s) for create subscription 88/142388/7
emaclee [Tue, 4 Nov 2025 18:22:51 +0000 (18:22 +0000)]
Add Rejected scenario(s) for create subscription

- added consuming REJECTED create request from DMI
- when REJECTED request is consumed, should update database and
  log details (dataNodeSelector, dataJobId, dmi details)
- added ignoring when dataJobId is not unique with test

Issue-ID: CPS-3005
Change-Id: If06c6ddfb3cf151ebf9485d43ba9d6ee5ef57287
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
7 weeks agoMerge "added second dmi-stub to cps-charts"
Lee Anjella Macabuhay [Wed, 19 Nov 2025 16:37:29 +0000 (16:37 +0000)]
Merge "added second dmi-stub to cps-charts"

7 weeks agoBug: ProvMnS error handling returning all DMI error responses as 500 56/142456/1
seanbeirne [Tue, 18 Nov 2025 17:11:17 +0000 (17:11 +0000)]
Bug: ProvMnS error handling returning all DMI error responses as 500

Issue-ID: CPS-3048
Change-Id: I9bc30f4f09664c331e396cb4aa18c90be3475f7c
Signed-off-by: seanbeirne <sean.beirne@est.tech>
7 weeks agoFix bug related to incorrect exception check when saving data nodes 55/142455/2
ToineSiebelink [Wed, 19 Nov 2025 08:46:01 +0000 (08:46 +0000)]
Fix bug related to incorrect exception check when saving data nodes

Issue-ID: CPS-3053
Change-Id: I32c14a64f3422f0d088752821519a4cc592e4509
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
7 weeks agoMerge "Forwarding list parameters : attributes and field consistently"
Lee Anjella Macabuhay [Tue, 18 Nov 2025 17:19:42 +0000 (17:19 +0000)]
Merge "Forwarding list parameters : attributes and field consistently"

7 weeks agoTask 3: Get delta between an anchor and JSON payload with grouping enabled 63/142363/3
Arpit Singh [Wed, 12 Nov 2025 12:29:00 +0000 (17:59 +0530)]
Task 3: Get delta between an anchor and JSON payload with grouping enabled

Remove @Ignore from the third Delta Report performance test (Get delta between
an anchor and JSON payload with grouping enabled) Jenkins build remains stable
or fails due to this test.

Purpose:
This change is part of an investigation to identify which Delta Report performance
test is causing the build failures.

Issue-ID: CPS-3033
Change-Id: I17ed5a52657675e9e2d1c0d75033246f09715060
Signed-off-by: Arpit Singh <AS00745003@techmahindra.com>
7 weeks agoForwarding list parameters : attributes and field consistently 53/142453/1
ToineSiebelink [Mon, 17 Nov 2025 16:01:33 +0000 (16:01 +0000)]
Forwarding list parameters : attributes and field consistently

- Treat 'fields' same as 'attributes' i.e. support empty value
- Refactored code (removed unnecessary null-check)
- Add test for all scenarios in Controller for best readability

Issue-ID: CPS-3046
Change-Id: I3d3e59f9b736a74036d73f55af5c6349010aa1e1
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
7 weeks agoMerge "Bug: Forward Empty attributes to DMI in Provmns GET"
Lee Anjella Macabuhay [Fri, 14 Nov 2025 13:49:40 +0000 (13:49 +0000)]
Merge "Bug: Forward Empty attributes to DMI in Provmns GET"

8 weeks agoBug: Forward Empty attributes to DMI in Provmns GET 42/142442/1
seanbeirne [Fri, 14 Nov 2025 11:35:33 +0000 (11:35 +0000)]
Bug: Forward Empty attributes to DMI in Provmns GET

- Modified RestServiceUrlTemplateBuilder to accept empty attributes
- Updated test ware to reflect change

Issue-ID: CPS-3046
Change-Id: I35d736cd6884154e1241fd50441cd6e1b0931f89
Signed-off-by: seanbeirne <sean.beirne@est.tech>
8 weeks agoMerge "Replace sleep with polling in CmSubscriptionSpec"
Lee Anjella Macabuhay [Fri, 14 Nov 2025 11:15:21 +0000 (11:15 +0000)]
Merge "Replace sleep with polling in CmSubscriptionSpec"

8 weeks agoReplace sleep with polling in CmSubscriptionSpec 12/142412/3
shikha0203 [Tue, 11 Nov 2025 16:59:37 +0000 (16:59 +0000)]
Replace sleep with polling in CmSubscriptionSpec

Issue-ID: CPS-3037
Change-Id: If3da998b1f9a2d41ea774b2e323aa6a1aa51cd57
Signed-off-by: shikha0203 <shivani.khare@est.tech>
8 weeks agoMerge "Update Policy Executor mapping for ProvMnS inputs"
Lee Anjella Macabuhay [Thu, 13 Nov 2025 20:53:57 +0000 (20:53 +0000)]
Merge "Update Policy Executor mapping for ProvMnS inputs"

8 weeks agoUpdate Policy Executor mapping for ProvMnS inputs 23/142423/6
leventecsanyi [Thu, 13 Nov 2025 09:02:45 +0000 (10:02 +0100)]
Update Policy Executor mapping for ProvMnS inputs

  - update mapping for Policy Executor for FDNs with a #
  - added extra testware

Issue-ID: CPS-2704
Change-Id: I250265d31bcdf61b053bf77b83a4ba8dc3e0ac67
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
8 weeks agoMerge "Implement PATCH for ProvMnS interface with bug fixes"
Lee Anjella Macabuhay [Thu, 13 Nov 2025 10:42:45 +0000 (10:42 +0000)]
Merge "Implement PATCH for ProvMnS interface with bug fixes"

8 weeks agoadded second dmi-stub to cps-charts 07/142407/4
halil.cakal [Wed, 5 Nov 2025 15:26:45 +0000 (15:26 +0000)]
added second dmi-stub to cps-charts

- cps-charts should support two dmi-stub instances, each uses its own
  pod. Since each pod should return its own Servlet URI (dmi-stub
address)
- the services for dmi-stub instances should be defined seperately since
  a fixed dmi-stub address is required. (otherwise adress would be
dynamic on each deployment)
- env. variable DMI_STUB_SERVER_PORT is used to override ther server
  port for second dmi-stub (ports should be different on pod levels)
- for the latest architecture please visit the solution page:
   https://lf-onap.atlassian.net/wiki/spaces/DW/pages/347537434/CPS-2933+Kubernetes+container+management+system+for+CPS+and+NCMP
- updated Uri address for dmi stub services

Issue-ID: CPS-2934

Change-Id: I1c6bda107ed362278dea7c26fa842a286de76009
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 weeks agoImplement PATCH for ProvMnS interface with bug fixes 10/142410/7
seanbeirne [Tue, 11 Nov 2025 15:50:01 +0000 (15:50 +0000)]
Implement PATCH for ProvMnS interface with bug fixes

-Implement PATCH endpoint with error handling
-Missing # attribute update operation; will come in later patch
-Fixes error return bug where all errors defaulted to 500
-Fixes get call to dmi in put operation
-Moved Resource to body in fowarding

Issue-ID: CPS-2704
Change-Id: I06bf643b155410a24774c5af9d6016c2d70a2219
Signed-off-by: seanbeirne <sean.beirne@est.tech>
8 weeks agoFix SonarQube issues 11/142411/2
emaclee [Wed, 12 Nov 2025 10:37:51 +0000 (10:37 +0000)]
Fix SonarQube issues

- refactored cmDataJobSubscriptionPersistenceService to get URI
  from a customizable parameter
- defined constants for 'dataNodeSelector' , 'dataJobId' and 'status' leaf names

Issue-ID: CPS-475
Change-Id: I4344e2b9b239bbdc99cb82e945c4368af00bb1b8
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
8 weeks agoMerge "Change Implement Exactly Once Semantics logging change back to debug level"
Lee Anjella Macabuhay [Wed, 12 Nov 2025 09:54:51 +0000 (09:54 +0000)]
Merge "Change Implement Exactly Once Semantics logging change back to debug level"

8 weeks agoMerge "Task 2: Merge Get delta between 2 anchors with grouping disabled"
Toine Siebelink [Wed, 12 Nov 2025 09:39:09 +0000 (09:39 +0000)]
Merge "Task 2: Merge Get delta between 2 anchors with grouping disabled"