Make feature-pooling-dmaap work without filtering

As DMaaP server-side filtering has been deprecated, modified
feature-pooling-dmaap to work without it.  The new design assumes that
each pdp gets its own unique consumer group, thus all pdps receive all
events.  Each pdp then uses the bucket assignments to determine whether
or not to process the event.  Note: this means that events no longer
have to be forwarded to the correct host, thus the "Forward" class has
been deleted.

Other than that, the code already did post-filtering of events so most
of it still works even without server-side filtering.  As a result, most
of the effort was in simply removing code that no longer applies.

Per review comments:
Modified code to use the event hash code instead of the request ID has
code when routing events.  This eliminated the need for the extractor
classes and related properties.
Replaced amsterdam and beijing properties with usecases properties.

Issue-ID: POLICY-2881
Change-Id: I87e4f98c14f419593879c278d7da053c80575553
Signed-off-by: Jim Hahn <jrh3@att.com>

Re-encrypt drools-pdp properties

To satisfy sonar, the algorithm for policy/common CryptoUtils has been
changed, necessitating the properties be re-encrypted.

Issue-ID: POLICY-2801
Change-Id: I59e63d68c1c7f62e321aa729e11fe41e13efd396
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp master to 1.8.0-SNAPSHOT

Bumping minor version now that guilin branch has been created.
Also repointed to snapshot versions for dependencies.

Issue-ID: POLICY-2875
Change-Id: Ic3d5b96e610db0487ce316a9397d2f9ecb04bda6
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp to 1.7.5 SNAPSHOT

Issue-ID: POLICY-2869
Change-Id: Id2fcbfcb5435f79b5ebb74a403fd6133d1b79a7c
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-pdp 1.7.4 docker

Issue-ID: POLICY-2869
Change-Id: I4e92d996dc55d000c4150c9e983bdc4904c30699
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-pdp 1.7.4 artifacts

Issue-ID: POLICY-2869
Change-Id: I4121fefa2ddcefb0f8c2cca15990a1d494c64827
Signed-off-by: Jim Hahn <jrh3@att.com>

Point drools to models 2.3.5

Issue-ID: POLICY-2869
Change-Id: I00931ad9b9df9c1f9ca893e0967693356c9eccfa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

enforce httpie 1.0.3 installed

http-prompt has a compatibility
issue with httpie 2.x.x
enforce to use httpie 1.0.3

Issue-ID: POLICY-2864
Change-Id: Ibfdd9afb48d0f755051516edb9ab790f12331cdc
Signed-off-by: Taka Cho <takamune.cho@att.com>

bump drools-pdp to 1.7.4-SNAPSHOT

Issue-ID: POLICY-2839
Change-Id: I85d286a012d7b54b8c847d94951703d2e6462e13
Signed-off-by: Taka Cho <takamune.cho@att.com>

release policy-drool 1.7.3 docker

Issue-ID: POLICY-2839
Change-Id: I496b7b992a5c2843e3e9fac933e1f376f03feb0f
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drools-pdp 1.7.3 artifact

Issue-ID: POLICY-2839
Change-Id: I1088f94022e370a9d4029fb47666b776c5ccd979
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.4

Issue-ID: POLICY-2839
Change-Id: Ifbc8239f9f5912eb7d1074424cf7c8060f71fdda
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.3

Issue-ID: POLICY-2839
Change-Id: I0bab7451436d5f76c19b743fe384cc0303a41228
Signed-off-by: Taka Cho <takamune.cho@att.com>

Use models 2.3.3-SNAPSHOT in drools-pdp

Issue-ID: POLICY-2863
Change-Id: Iaffc87711f33e4a5c35d1fdcaa21f8ec0d742baf
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-pdp to 1.7.3 snapshot

Issue-ID: POLICY-2839
Change-Id: I750b5130c421dafd95dc4f323e891384a7815841
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drools-pdp 1.7.2 docker

Issue-ID: POLICY-2839
Change-Id: I687bd06a5fd1f56348b08f3866a0e18eef6bb848
Signed-off-by: Taka Cho <takamune.cho@att.com>

Release drool-pdp 1.7.2 maven artifacts

Issue-ID: POLICY-2839
Change-Id: Ia80368ae6632779451e9a3f9a595fa235906ac4b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.2

Issue-ID: POLICY-2839
Change-Id: I6110baaf281b82cbbfc384693dd5dc30c6c6d19b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix new sonars in drools-pdp

Addressed the following sonar issues:
- extract common test method
- too many assertions in test method
- don't always return the same value

Issue-ID: POLICY-2616
Change-Id: Iab836cdcd667b35e2db9db7d6ffc7896df33e1c8
Signed-off-by: Jim Hahn <jrh3@att.com>

update default keystores

Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: If74e7eeb0ab8ff35accbfddb719bd477cd889b06

Fix more sonars in feature-server-pool

Addressed the following sonars:
- move fields from "interface" to "class"
- don't always return the same value
- remove commented-out code
- make constants "final"
- don't synchronize on parameters

Issue-ID: POLICY-2546
Change-Id: If2d410664d956a7efabf3a4dbef96bbf7d24de5e
Signed-off-by: Jim Hahn <jrh3@att.com>

Use alpine base image 2.1.1

Issue-ID: POLICY-2819
Change-Id: I5722330bff9c37ee9dd89d3fce0bd7fbdf975f1b
Signed-off-by: Jim Hahn <jrh3@att.com>

Handle CR in pom property files

Fixed deploy-artifacts to strip carriage returns from pom.properties
files before attempting to extract variables from them.
Switched to using 'sed' instead of dos2unix.

Issue-ID: POLICY-2823
Change-Id: I1114af13a3262e49b87fb270d5c78cda4de9e5c9
Signed-off-by: Jim Hahn <jrh3@att.com>

bump to 1.7.2-SNAPSHOT

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0fb5ead444c23882454e3a48efea9d936a84e455

docker release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4271ce650490afbe9023f71f6c0ced0194e8d624

maven release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I807f85c5ab4398146ddb50a5942623a49eadbd26
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Update common and models to 1.7.1 and 2.3.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I9ecd6b7d5cc741be5ed304d4a2a181f47c25a391

point to 2.1.0 policy-alpine base - droolspdp

In G-rel, using 2.1.0 base.

Issue-ID: POLICY-2789
Change-Id: I3b0b3d98b8915d7e45ec1231f41a7b97836d80c1
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix more sonars in drools-pdp

Fixed more sonars in drools-pdp:
- remove commented code
- don't throw generic Exception
- unused field (made it protected instead of private)
- log conditionally
- cognitive complexity
- too many break/continue
- return empty list instead of null
- Random() is not secure

Fixed more eclipse warnings:
- parameterize generic types

Issue-ID: POLICY-2616-sonars3
Change-Id: Ia5ad769b2ea763568cfae3d81807926d89153b09
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Fix sonars in server-pool"

Fix sonars in server-pool

Addressed the following sonars in feature-server-pool:
- re-interrupt after catching an InterruptException
- reduce cognitive complexity
- cognitive complexity
- not enough arguments for logger message
- use UnaryOperator instead of Function
- update static fields via static methods
- too many break/continue in for-loop

Also fixed some Eclipse warnings:
- add parameter to generic types
- useless assignments
- newInstance() has been deprecated
- close streams

Issue-ID: POLICY-2616
Change-Id: Ibf6c20e6c2a7eb8c60e1b38f388d86a0f9b8804b
Signed-off-by: Jim Hahn <jrh3@att.com>

Fix sonar issue in distributed locking

Fixed sonar issue:
- Refactor the code of the lambda to have only one invocation throwing
  an exception

Issue-ID: POLICY-2616
Change-Id: I8d96b95d0da9a780daacec7a4de17167642b03c1
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove commons-io dependency

Policy parent has this declaration to the latest 2.7
version of commons-io which fixes a sonatype security
issue. There is no reason that drools-pdp should be
declaring this.

Issue-ID: POLICY-2798
Change-Id: Ie7dbe14458be4ead395dfcbebbc1c0cd3ccc4ea6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Address more sonars in drools-pdp

Addressed the following sonars:
- either log or rethrow
- call "remove()" for thread-local-storage
- use assertEquals
- only one method call in exception test
- swap arguments in assertEquals
- add assertion to assertThatThrownBy()
- explain @Ignore

Also addressed eclipse warnings:
- unused fields and methods

Issue-ID: POLICY-2616
Change-Id: I6590c0d2b103885bc933014d48bf5fd92401cd80
Signed-off-by: Jim Hahn <jrh3@att.com>

block status operations until controllers ready

Status messages to the PAP won't be send until
all mandatory resources specified in the
lifecycle.pdp.policytypes property are functional.

Issue-ID: POLICY-2669
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia9d4c678fcfbdb232059d0827235845ee11f1201
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

exit jvm when detecting configuration problems

It follows the same approach that in other policy
components by throwing a runtime-exception vs
System.exit(x).

Issue-ID: POLICY-2752
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iba508fc7095b060373742849e394c8fdd2a2334f
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Merge "remove legacy operational policies support"

move to alpine from debian

moving to alpine-jdk base for
drool-pdp apps

csit drools/apps tested in windriver labs:
http://10.12.6.96:8080/tmp/tmp.yxBE30uD1m-robot-workdir/report.html

1, httpie has to install via apk
2, http-prompt has to install via pip

Issue-ID: POLICY-2787
Change-Id: I3d1bd86c7c2c3c48e9ac2a823b988bb9b1bdf98f
Signed-off-by: Taka Cho <takamune.cho@att.com>

remove legacy operational policies support

Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I6066b8040add53ed32572a71854f3f7094bc41d6

Update INFO.yaml in policy-drools-pdp

Verified with Jessica W that the "type" should still be "Addition",
even when updating the PTL.
Updated to Mature, per TSC.

Issue-ID: POLICY-2738
Change-Id: I3a90f3dff643f89cc5eba3a46ba4570dc756bfef
Signed-off-by: Taka Cho <takamune.cho@att.com>

Remove more jackson dependencies from drools-pdp

Issue-ID: POLICY-1528
Change-Id: I9b4054cbfd41ec1abe61d6fe459ebb29adaa7a45
Signed-off-by: Jim Hahn <jrh3@att.com>

Add Ajith to policy/drools-pdp info

Issue-ID: POLICY-2738
Change-Id: Ib40ad93e6c0562fa60c99c9c6eff5072e355c062
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Support multiple Policy/Controller types using 'controller.type' property"

Support multiple Policy/Controller types using 'controller.type' property

It provides a feature base to allow for custom Policy
and Drools Controllers.

Issue-ID: POLICY-2415
Change-Id: Ibe3f11e3ecd925537ffd03d2420bb3b8214029c9
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Remove jackson from drools-pdp

Issue-ID: POLICY-1528
Change-Id: I616c48d62c63f8f213ec012f8746509471c38f89
Signed-off-by: Jim Hahn <jrh3@att.com>

Point to SNAPSHOT for drools-pdp

Issue-ID: POLICY-2695
Change-Id: I65fb75dda4dd26a54c593ecb26d7e0950a59e27c
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "add exec option to policy usage message"

add exec option to policy usage message

Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I5b3bbc36ea33c30625119a9e624b68c82a91b634

Merge "exec pdp-d java process to run in the foreground"

exec pdp-d java process to run in the foreground

Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I0a08a2760e4dc5a61a59c7f0f3096db76d42cc29

Merge "sonar fix for server pool"

Bump drools-pdp to 1.7.1-SNAPSHOT

Issue-ID: POLICY-2709
Change-Id: Ifb6232eb428e2cd9c729fef54862779b2ee55bbc
Signed-off-by: Taka Cho <takamune.cho@att.com>

release docker 1.7.0

Issue-ID: POLICY-2695
Change-Id: I250bd36079484f9869f39ec000347c106384ebaf
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drool-pdp 1.7.0

Issue-ID: POLICY-2709
Change-Id: Ide08c4847a7c41bcb76b6009be59be7ec3621191
Signed-off-by: Taka Cho <takamune.cho@att.com>

point to release parent, common and model

release 1.7.0

Issue-ID: POLICY-270
Change-Id: I4975883ef85ab99345d7f9f32bbc72c091c0573a
Signed-off-by: Taka Cho <takamune.cho@att.com>

sonar fix for server pool

- move to a method for nest try and catch
- fixed some typos in comments
- use constant for the same String
- boolean method should be checked
- removed unnecessary exceptions

Issue-ID: POLICY-2616
Change-Id: I647ee095171feedfd44ca6967676f61842c2c91b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Checkstyle fixes to drools-pdp"

Merge "Use apache Triple"

Merge "sonar fix for TargetLock"

Checkstyle fixes to drools-pdp

Issue-ID: POLICY-2696
Change-Id: I7f80737c52e3f16e03803118d92411e4ac39c5fb
Signed-off-by: Jim Hahn <jrh3@att.com>

Use apache Triple

Replaced policy-utils/Triple with apache Triple.

Issue-ID: POLICY-2694
Change-Id: I160f90c03f18b7da8dec5d0a00f809bcfb29680b
Signed-off-by: Jim Hahn <jrh3@att.com>

sonar fix for TargetLock

- duplicating strings to constant
- to not log tainted, user-controlled data.

Issue-ID: POLICY-2616
Change-Id: Iaa9dd9f9ef839cec58ae60d8464b889a02b8ddb5
Signed-off-by: Taka Cho <takamune.cho@att.com>

drools-pdp sonar fix

most of changes are assert statement

Issue-ID: POLICY-2616
Change-Id: I3bd3076115d28d8cfabcbe0859cc4b21085e1394
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Updating drools pdp dependencies"

Updating drools pdp dependencies

Issue-ID: POLICY-2387
Change-Id: I5fe17c2514aed5c595d4e2a3d95fbb210a6f229b
Signed-off-by: RossC <ross.carter@est.tech>

sonar fix for feature server pool

- reduce cognitive complexity
- return a boolean value
- Replace this lambda with a method reference
- use lombok annotation @EqualsAndHashcode
- removed unnecessary exception

Issue-ID: POLICY-2616
Change-Id: Ia0c300c2909bbdd232f2a3c758a5709b70f06d1c
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-oss"

Merge "Clean up of Pair classes - drools-pdp"

feature-eelf: eelf-core from: 1.0.0 -> 2.0.0-oss

Issue-ID: POLICY-2387
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I29d4f07d990797a470bce0898ca67741974f1c00
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Merge "sonar fix - FeatureServerPool"

Clean up of Pair classes - drools-pdp

Removed Pair class from drools-pdp and replaced with Apache Common Pair
class

Issue-ID: POLICY-2202
Change-Id: Ica2a5b734fb6eebfc0713027c1c4dc3b8d3882c8
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "replace an emptyArray and computeIfAbsent instead"

override central repo with right repository

This is to prevent that other poms setting the repository
http://repo2.maven.org, which has been decommissioned.
The repo1.maven.org is the one to be used, only with https.

Issue-ID: POLICY-2677
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I743014ea553f5df829eb0bd7ada2cb3d1fb842bf

replace an emptyArray and computeIfAbsent instead

- some methods should return an empty array.
- avoid the result of a java.util.Map.get()
  against null before proceeding with adding
  or changing the value in the map.
- Declaring a variable only to immediately
  return or throw it is a bad practice.

Issue-ID: POLICY-2616
Change-Id: I21a55c5ea716d8f64dc9155f84cabcfbcf5a22e0
Signed-off-by: Taka Cho <takamune.cho@att.com>

sonar fix - FeatureServerPool

- sonar thinks one block of comments are code,
  so changed some syntax in comments
- not more than one break or continue statement

Issue-ID: POLICY-2616
Change-Id: Ia35b73584f5a8492320c4beaa069ba7f903ce268
Signed-off-by: Taka Cho <takamune.cho@att.com>

feature server Keyword sonar fix

- remove unnecessary cast
- A "NullPointerException" could be
  thrown; "last" is nullable here
- regexp method name
- remove curly braces and 'return'

Issue-ID: POLICY-2616
Change-Id: Icd6ab0cf1f77cdc8cf1bffb3ae2781702add9ab5
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "replace Thread sleep with Awaitility"

replace Thread sleep with Awaitility

- use '{}' for logger msg
- sonar suggest using use libraries
  Awaitility for asynchroneous testing

Issue-ID: POLICY-2616
Change-Id: I09828cdb9467235403f299c6419e8560ca21aefd
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Upgrade hibernate to clear dom4j sonatype"

Upgrade hibernate to clear dom4j sonatype

dom4j 1.3.1 has sonatype issue, 1.3.3 fixed it.

hibernate is the dependency that pulls in dom4j, upgrading
to latest patch will pull in the fixed dom4j.

Issue-ID: POLICY-2675
Change-Id: Ibb80fa7c96df42322bd3dc6c7a1d1d81deb365ab
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

fix sonar issue - feature-server

- A field should not duplicate
  the name of its containing class
- Invoke method(s) only conditionally
- add equals and hashcode
- some leftover changes for %n

Issue-ID: POLICY-2616
Change-Id: Icc094c17245e6a163d1158d97890579d76b84aec
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "need Override equals and hashCode method"

Merge "fix sonar - feature-server"

fix sonar - feature-server

%n is portable across platforms \n is not.

Issue-ID: POLICY-2616
Change-Id: I6daa827b93384c8b25dcb58b87fff116d09a2176
Signed-off-by: Taka Cho <takamune.cho@att.com>

need Override equals and hashCode method

Use eclipse to generate those two
Overrides in order to avoid sonar
issue

Issue-ID: POLICY-2616
Change-Id: If7e887b99fa44dac5ac5fa6f8c8cfe677238576d
Signed-off-by: Taka Cho <takamune.cho@att.com>

reduce sonar issue - feature-server

Remove useless curly braces around statement
Rename the method name
change to '<>'

Issue-ID: POLICY-2616
Change-Id: I679ce7e44b1a8c2c30f78820c12f91f18e5aa944
Signed-off-by: Taka Cho <takamune.cho@att.com>

removed unused methods parameter

Unused parameters are misleading.
Whatever the values passed to such
parameters, the behavior will be the same.

Issue-ID: POLICY-2616
Change-Id: I9a595dca81ce061846fa53adf8086130ffd31a74
Signed-off-by: Taka Cho <takamune.cho@att.com>

Removing log4j from feature-state-management/pom.xml

Issue-ID: POLICY-2623
Signed-off-by: Utkarsh Jauhari <uj426b@att.com>
Change-Id: I5f9e7b67ce39177c4f7211ea0e30d78bc7a95cc3

Address checkstyle version issues in drools-pdp

Also added serializationId to several classes to address eclipse warnings.

Issue-ID: POLICY-2188
Change-Id: I3df5e8abaad8da9261c0d5cd19a93ed68dceb870
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "drools-pdp sonar issue fixes"

drools-pdp sonar issue fixes

fix all assert statements to
comply with sonar issue

Issue-ID: POLICY-2616
Change-Id: Ia36e3eab7c74d8dfb1ab3fa1395b1f64b173e09a
Signed-off-by: Taka Cho <takamune.cho@att.com>

equals and hashCode should be overridden in pairs

hashCode should be overridden in pairs.
followed by Effective Java:

You must override hashCode() in every class that
overrides equals(). Failure to do so will result
in a violation of the general contract for
Object.hashCode(), which will prevent your class from
functioning properly in conjunction with all
hash-based collections, including HashMap, HashSet, and Hashtable.

Issue-ID: POLICY-2616
Change-Id: I2b29722daab5c520547397aae68d8ebaa71b2c4b
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "reduce sonar issue - 2 rev"

reduce sonar issue - 2 rev

In some conditions for assertTrue, sonarcloud
recommends using assertEquals

Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));

Compliant Solution

Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);

Issue-ID: POLICY-2616
Change-Id: Ib362573bd865d1b561916bf64640c8ddeaa02546
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "do strict validation before domain conversion"

do strict validation before domain conversion

need to perform a validation pass as the validation
combined with putting a domain model object tree
together run into problems when dealing with
integers that are passed as strings.

Issue-ID: POLICY-2577
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I06a2b6e8dc7e0442c2503b6d978deddbf652d830
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

reduce sonar issue - drools-pdp

remove unused import
rename the method name

Issue-ID: POLICY-2616
Change-Id: I15845159063ec5fa3cfb34a59b9c433ba3201ccc
Signed-off-by: Taka Cho <takamune.cho@att.com>

reduce sonar issue

In some conditions for assertTrue, sonarcloud
recommends using assertEquals

Assert.assertTrue(a.equals(b));
Assert.assertTrue(a == b);
Assert.assertTrue(a == null);
Assert.assertTrue(a != null);
Assert.assertFalse(a.equals(b));

Compliant Solution

Assert.assertEquals(a, b);
Assert.assertSame(a, b);
Assert.assertNull(a);
Assert.assertNotNull(a);
Assert.assertNotEquals(a, b);

Issue-ID: POLICY-2616
Change-Id: I6a4b0ac76c0816a8d4bf1914dc96210d20cdff03
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Change metrics and transactions layout in logback.xml"

Change metrics and transactions layout in logback.xml

Update logging code to compliant with logging standard

Issue-ID: POLICY-2578
Change-Id: I98decce81eae95c006d6485bf3440ac9119b2bf5
Signed-off-by: Joseph Chou <jc2555@att.com>