so.git
5 years agoupdate INFO.yaml 01/89101/4
seshukm [Fri, 31 May 2019 04:31:16 +0000 (10:01 +0530)]
update INFO.yaml

Issue-ID: SO-1944

Change-Id: I221fc3cce7f72373ad35a6ce07c887e928038348
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
(cherry picked from commit c32829b9f2e67a46fb56b590c253fd3bdc9cce97)

5 years agoMerge "New GroupLevel DeleteE2EServiceInstance flow"
Seshu Kumar M [Sun, 2 Jun 2019 07:58:31 +0000 (07:58 +0000)]
Merge "New GroupLevel DeleteE2EServiceInstance flow"

5 years agoMerge "property to determine if delete audit is needed"
Steve Smokowski [Fri, 31 May 2019 21:58:13 +0000 (21:58 +0000)]
Merge "property to determine if delete audit is needed"

5 years agoMerge "apih resume request handling more generic"
Steve Smokowski [Fri, 31 May 2019 21:58:03 +0000 (21:58 +0000)]
Merge "apih resume request handling more generic"

5 years agoMerge "issue encoding openstack errors"
Steve Smokowski [Fri, 31 May 2019 21:57:53 +0000 (21:57 +0000)]
Merge "issue encoding openstack errors"

5 years agoMerge "Fix issue where request was not being updated"
Steve Smokowski [Fri, 31 May 2019 21:57:41 +0000 (21:57 +0000)]
Merge "Fix issue where request was not being updated"

5 years agoenhanced vnf adapter errog log. 83/89083/1
Sangalang, Felix [Fri, 31 May 2019 20:19:54 +0000 (16:19 -0400)]
enhanced vnf adapter errog log.

enhanced vnf adapter error log for heatEnvironment when null.
removed the junit tests because of no assertions coverage.
enhanced vnf adapter errog log.

Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2
Issue-ID: SO-1967
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix issue where request was not being updated 81/89081/1
Smokowski, Steven [Fri, 31 May 2019 20:15:23 +0000 (16:15 -0400)]
Fix issue where request was not being updated

Fix issue where request was not being updated

Change-Id: Ib4b3809797449224ac417facfaa4bf48d91a1ecb
Issue-ID: SO-1966
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoissue encoding openstack errors 80/89080/1
Smokowski, Steven [Fri, 31 May 2019 20:12:39 +0000 (16:12 -0400)]
issue encoding openstack errors

Fix setting of port to fix unit test issues
Fix formatting error on the file causing build issue
Properly revert change that was made previously
Fix issue where base java library not encoding properly

Change-Id: I2bfa46825d9a99998195dbd7bd422f88fa76ef09
Issue-ID: SO-1965
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoproperty to determine if delete audit is needed 77/89077/1
Kalkere Ramesh, Sharan [Fri, 31 May 2019 20:02:40 +0000 (16:02 -0400)]
property to determine if delete audit is needed

update the onap delete vf module BB bpmn as well
validate formatting of audit tasks code changes
added a property to determine if delete audit is needed

Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83
Issue-ID: SO-1964
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoapih resume request handling more generic 76/89076/1
Plummer, Brittany [Fri, 31 May 2019 19:56:32 +0000 (15:56 -0400)]
apih resume request handling more generic

getInstanceName throws exception if requestScope doesn't match modelType
Updated to combine separate return statements
Replaced if statements for modelType and added tests
Replace if statements for modelType in ResumeOrchestrationRequest and
added tests
Added coverage for setId in ModelType
Updated to use ModelType setters/getters
model type can now get and set generically
Added modelInfo to RequestBody for resume request
Added getModelType call and unit tests
Moved getModelType from ServiceInstances
Moved getModelType and added unit tests
Added tests for getIsBaseVfModule
Added more tests for isBaseVfModule
Began adding tests for getIsBaseVfModule
Updated currentActiveRequest creation and isBaseVfModule
Updated recipe lookup and setting of aLaCarte to be more general
Updated concurrency control to include other resources

Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3
Issue-ID: SO-1963
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "converted lock time from hard coded value"
Steve Smokowski [Fri, 31 May 2019 17:15:39 +0000 (17:15 +0000)]
Merge "converted lock time from hard coded value"

5 years agoMerge "Corrected enum formatting by plugin"
Steve Smokowski [Fri, 31 May 2019 17:15:30 +0000 (17:15 +0000)]
Merge "Corrected enum formatting by plugin"

5 years agoMerge "JUnit tests for RestfulUtil"
Steve Smokowski [Fri, 31 May 2019 16:51:26 +0000 (16:51 +0000)]
Merge "JUnit tests for RestfulUtil"

5 years agoMerge "Added NPE check for audit"
Steve Smokowski [Fri, 31 May 2019 16:50:35 +0000 (16:50 +0000)]
Merge "Added NPE check for audit"

5 years agoMerge "apih to populate original request id"
Steve Smokowski [Fri, 31 May 2019 16:50:13 +0000 (16:50 +0000)]
Merge "apih to populate original request id"

5 years agoCorrected enum formatting by plugin 63/89063/1
Benjamin, Max (mb388a) [Fri, 31 May 2019 16:24:53 +0000 (12:24 -0400)]
Corrected enum formatting by plugin

enums are now single item per line

Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoconverted lock time from hard coded value 62/89062/1
Kalkere Ramesh, Sharan [Fri, 31 May 2019 16:13:12 +0000 (12:13 -0400)]
converted lock time from hard coded value

update lock time property to have a default of 60000
converted lock time from hard coded to property driven

Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d
Issue-ID: SO-1962
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoHandle multiple host routes correctly for networks 60/89060/1
Mcblain, Thomas [Fri, 31 May 2019 15:52:36 +0000 (11:52 -0400)]
Handle multiple host routes correctly for networks

unit test for the method that creates subnets
Remove project name from junit test data
Handle multiple host routes correctly for networks

Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd
Issue-ID: SO-1961
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoapih to populate original request id 58/89058/1
Plummer, Brittany [Fri, 31 May 2019 15:48:34 +0000 (11:48 -0400)]
apih to populate original request id

Updated schema.sql to fix failing tests
Added constants for request parameters
Added originalRequestId to be saved on resume request
Added originalRequestId to orchestrationRequests response

Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a
Issue-ID: SO-1960
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdded NPE check for audit 56/89056/1
Boslet, Cory [Fri, 31 May 2019 15:46:57 +0000 (11:46 -0400)]
Added NPE check for audit

Added NPE check so that flow continues when no audit results present

Change-Id: I614dbaff7eaaca86a503da2734d7c5f7a197bb1b
Issue-ID: SO-1959
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Renamed NF fields in catalog db pojo"
Steve Smokowski [Fri, 31 May 2019 15:36:42 +0000 (15:36 +0000)]
Merge "Renamed NF fields in catalog db pojo"

5 years agoMerge "Remove update of request status"
Steve Smokowski [Fri, 31 May 2019 15:36:38 +0000 (15:36 +0000)]
Merge "Remove update of request status"

5 years agofix keypair conflict issue in openstack adapter 81/88181/3
Smokowski, Steven [Tue, 21 May 2019 15:58:01 +0000 (11:58 -0400)]
fix keypair conflict issue in openstack adapter

Fix wiremock stubs to return proper data and url
Fix copyright header issue on unit test file
Fix keypair issue, clean up unit tests and logging
Fix issues found in unit testing, update data
Fix broken Unit tests that used invalid data
Continue Refactor to support keypair failure scenario
Update logic for when to auto delete a stuck keypair

Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006
Issue-ID: SO-1897
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoNew GroupLevel DeleteE2EServiceInstance flow 28/89028/1
sarada prasad sahoo [Fri, 31 May 2019 13:12:38 +0000 (18:42 +0530)]
New GroupLevel DeleteE2EServiceInstance flow

Modified the subprocess 'DoDeleteE2EServiceInstance'
to support Group level instances.

Change-Id: I8dfd154bc6eb9c9f7c7dc932bdce215a3b9fd800
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoMerge "Improvements in AAIClientHelper"
Lukasz Muszkieta [Fri, 31 May 2019 10:49:32 +0000 (10:49 +0000)]
Merge "Improvements in AAIClientHelper"

5 years agoImprovements in AAIClientHelper 09/89009/1
r.bogacki [Fri, 31 May 2019 09:07:46 +0000 (11:07 +0200)]
Improvements in AAIClientHelper

Improvements in AAIClientHelper according to the Sonar analysis.
Removed unnecessary exception throwing.
Fixed imports.
Updated java docs.

Issue-ID: SO-1958
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I60835304466bb656f09ba16b487907fa529e5eab

5 years agoMerge "Improvements in RequestClient"
Lukasz Muszkieta [Fri, 31 May 2019 08:39:42 +0000 (08:39 +0000)]
Merge "Improvements in RequestClient"

5 years agoImprovements in RequestClientFactory 89/88889/1
r.bogacki [Thu, 30 May 2019 13:16:57 +0000 (15:16 +0200)]
Improvements in RequestClientFactory

Improvements in RequestClientFactory according to the Sonar analysis.
Fixed imports.
Removed unnecessary exceptions handling.
Replaced depreciated  DefaultHttpClient with a new one.

Issue-ID: SO-1947
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id497bfb620775aac67ad4c5f6d57e0fccce4fd34

5 years agoImprovements in RequestClient 83/88883/3
r.bogacki [Thu, 30 May 2019 12:27:16 +0000 (14:27 +0200)]
Improvements in RequestClient

Improvements in RequestClient according to the Sonar analysis.
Removed unnecessary exceptions handling.
Added junit tests.
Fixed imports.

Issue-ID: SO-1945
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iee22e7dbeb39ca28c437f9a8a804b81945cb9bc5

5 years agoMerge "Improvements in CamundaClient"
Steve Smokowski [Thu, 30 May 2019 11:44:16 +0000 (11:44 +0000)]
Merge "Improvements in CamundaClient"

5 years agoMerge "Fix DeleteE2EServiceInstance flow"
Seshu Kumar M [Thu, 30 May 2019 11:15:31 +0000 (11:15 +0000)]
Merge "Fix DeleteE2EServiceInstance flow"

5 years agoImprovements in CamundaClient 69/88769/1
rob.bog [Wed, 29 May 2019 13:18:09 +0000 (15:18 +0200)]
Improvements in CamundaClient

Removed code duplicates.
Fixed declarations of thrown exceptions.
Fixed imports.

Issue-ID: SO-1936
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ic178341b0049307da033408719ff263a00059ba7

5 years agoJUnit tests for RestfulUtil 58/88458/4
r.bogacki [Fri, 24 May 2019 11:51:36 +0000 (13:51 +0200)]
JUnit tests for RestfulUtil

Increased junit tests coverage according to Sonar analyses.
Added missing tests for RestfulUtil.

Issue-ID: SO-1692
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I8744960c0ad3a36ca4c36e23867168bfda5cbd1d

5 years agoMerge "Fix request body for SDNC req"
Seshu Kumar M [Wed, 29 May 2019 12:07:28 +0000 (12:07 +0000)]
Merge "Fix request body for SDNC req"

5 years agoFix request body for SDNC req 17/88517/2
subhash kumar singh [Mon, 27 May 2019 06:17:50 +0000 (11:47 +0530)]
Fix request body for SDNC req

Fix request body for SDNC req.

Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Ia8112b81fa29f886e282445b3c0dc068d487cadd

5 years agoFix sonar for MapEntry 45/88545/1
k.kazak [Mon, 27 May 2019 13:00:15 +0000 (15:00 +0200)]
Fix sonar for MapEntry

MapEntry bug: make entry private and provide accessors
MapEntry codesmell: move comment 'Required by JAXB' into empty constructor
MapElements codesmell: move explanatory comment inside empty constructor
MapElements codesmell: log error stacktrace
MapAdapter codesmell: use entry set instead of key set for iteration
JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases

Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoCalls to/from VNFM fail 84/88384/2
MichaelMorris [Thu, 23 May 2019 15:52:59 +0000 (15:52 +0000)]
Calls to/from VNFM fail

Issue-ID: SO-1909
Change-Id: I2f8a19dfd456316e5436be4e85d8a384d7d5ed6f
Signed-off-by: MichaelMorris <michael.morris@est.tech>
5 years agoFix Build -Use latest SNAPSHOT appc client-libs 16/88416/1
Marcus G K Williams [Thu, 23 May 2019 22:25:25 +0000 (15:25 -0700)]
Fix Build -Use latest SNAPSHOT appc client-libs

Issue-ID: SO-1921
Change-Id: Id20f8f7d77469e8123317447aa974a3e77103761
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoRemove update of request status 62/88362/1
Smokowski, Steven [Thu, 23 May 2019 14:36:12 +0000 (10:36 -0400)]
Remove update of request status

fix unit test now that method does not update status
Remove update of request status, should not be done

Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922
Issue-ID: SO-1915
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRenamed NF fields in catalog db pojo 60/88360/1
Merkel, Jeff [Thu, 23 May 2019 14:33:57 +0000 (10:33 -0400)]
Renamed NF fields in catalog db pojo

- Renamed Nf properties to just Function, Role, Type.

Change-Id: I0cec751e783c1fb7abdcf9f9565eadf89e0ac32c
Issue-ID: SO-1914
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoSDNC request body fix 39/88239/3
subhash kumar singh [Wed, 22 May 2019 12:20:35 +0000 (17:50 +0530)]
SDNC request body fix

Request body fix for sdnc requests.

Change-Id: Id3e454be18c62ab8c2e5ee572de55bf3ef7c18a3
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoFix instance resource list 23/88223/3
subhash kumar singh [Wed, 22 May 2019 06:05:46 +0000 (11:35 +0530)]
Fix instance resource list

Fix instance resource list if group is not list type.

Change-Id: I99d37d5407c925dbb3355de73105de755b30bc04
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoMerge "Enhanced logic for multilevel list input"
subhash kumar singh [Wed, 22 May 2019 12:18:45 +0000 (12:18 +0000)]
Merge "Enhanced logic for multilevel list input"

5 years agoMerge "Added script for adding original_request_id column"
Steve Smokowski [Tue, 21 May 2019 15:42:24 +0000 (15:42 +0000)]
Merge "Added script for adding original_request_id column"

5 years agoFix DeleteE2EServiceInstance flow 49/88149/1
sarada prasad sahoo [Tue, 21 May 2019 10:07:23 +0000 (15:37 +0530)]
Fix DeleteE2EServiceInstance flow

Fixed the issue when subprocess 'DoDeleteE2EServiceInstance'
calls 'AAI GenericGetService' sub-process
which is deleted from SO common-bpmn.

Change-Id: I8f5dce0135031c2d44fccd51676a709f014ef3c7
Issue-ID: SO-1809
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoEnhanced logic for multilevel list input 30/88130/2
sarada prasad sahoo [Tue, 21 May 2019 04:28:43 +0000 (09:58 +0530)]
Enhanced logic for multilevel list input

Optimized VF/GROUP/VFC level parsing logic
as per doCompareModel call flow

Change-Id: If934ee1407a1bad6c9adec9e32533166b5fb4d93
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoMerge "Fix SDNC Resource creation workflow"
subhash kumar singh [Tue, 21 May 2019 07:06:24 +0000 (07:06 +0000)]
Merge "Fix SDNC Resource creation workflow"

5 years agoFix SDNC Resource creation workflow 10/88010/7
Isaac Manuel Raj [Fri, 17 May 2019 15:18:58 +0000 (20:48 +0530)]
Fix SDNC Resource creation workflow

Fix SDNC Resource Creation workflow

Issue-ID: SO-1393

Change-Id: Ia75150adf3695e623a2f3ec7ea5f720667142c1b
Signed-off-by: Isaac Manuel Raj <isaac.manuelraj@huawei.com>
5 years agoAdded script for adding original_request_id column 14/88114/1
Plummer, Brittany [Mon, 20 May 2019 20:03:09 +0000 (16:03 -0400)]
Added script for adding original_request_id column

Added IF NOT EXISTS clause to ADD COLUMN
Added script for adding original_request_id column

Change-Id: I816d260c60fb5473a9ffb11fa36c49a3493e8e72
Issue-ID: SO-1902
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Initial checkin of updates for vf module replace"
Steve Smokowski [Mon, 20 May 2019 14:17:16 +0000 (14:17 +0000)]
Merge "Initial checkin of updates for vf module replace"

5 years agoMerge "Fix bad query, adjust sql to use non-att bb"
Steve Smokowski [Mon, 20 May 2019 14:17:08 +0000 (14:17 +0000)]
Merge "Fix bad query, adjust sql to use non-att bb"

5 years agoMerge "Altered bpmn and audit behavior on delete vf mod"
Steve Smokowski [Mon, 20 May 2019 14:17:03 +0000 (14:17 +0000)]
Merge "Altered bpmn and audit behavior on delete vf mod"

5 years agoMerge "Set workflowexceptionerrormessage in all cases"
Steve Smokowski [Mon, 20 May 2019 14:16:58 +0000 (14:16 +0000)]
Merge "Set workflowexceptionerrormessage in all cases"

5 years agoMerge "Audit service enhancements"
Steve Smokowski [Mon, 20 May 2019 14:16:50 +0000 (14:16 +0000)]
Merge "Audit service enhancements"

5 years agoMerge "END_TIME is not populated by bpmn as expected"
Steve Smokowski [Mon, 20 May 2019 14:16:29 +0000 (14:16 +0000)]
Merge "END_TIME is not populated by bpmn as expected"

5 years agoEnhanced logic for multilevel list input 85/87985/2
sarada prasad sahoo [Fri, 3 May 2019 06:54:32 +0000 (12:24 +0530)]
Enhanced logic for multilevel list input

Added extra VF/VFC level test cases,
also corrected first level index increment logic.

Change-Id: I18982b4b6821da4f7dc06743c3aeca0fa54176e3
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoMerge "Add model type to resource model"
Seshu Kumar M [Mon, 20 May 2019 05:14:45 +0000 (05:14 +0000)]
Merge "Add model type to resource model"

5 years agoMerge "Fix null check for groups"
Seshu Kumar M [Mon, 20 May 2019 05:12:01 +0000 (05:12 +0000)]
Merge "Fix null check for groups"

5 years agoAdd model type to resource model 93/87993/3
subhash kumar singh [Fri, 17 May 2019 13:31:40 +0000 (19:01 +0530)]
Add model type to resource model

Add model type to resource model.

Change-Id: Ic1937d859cebca1b515d9c069c51c9811d6874ab
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoRecipe retrieval for groups 38/87938/4
subhash kumar singh [Fri, 17 May 2019 04:46:07 +0000 (10:16 +0530)]
Recipe retrieval for groups

Recipe retrieval for groups.

Change-Id: I2ba68777f3655ebc7794b75d357253022fe7739b
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoInitial checkin of updates for vf module replace 04/88004/2
Smokowski, Steven [Fri, 17 May 2019 14:31:27 +0000 (10:31 -0400)]
Initial checkin of updates for vf module replace

fix toString method and add unit tests for new code
Fix Null pointer issue in UT, extra chars
Initial checkin of updates for vf module replace

Change-Id: I2d62f5c2077cd022ccf796d126494e526ad48c54
Issue-ID: SO-1893
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAltered bpmn and audit behavior on delete vf mod 07/88007/1
Boslet, Cory [Fri, 17 May 2019 14:36:25 +0000 (10:36 -0400)]
Altered bpmn and audit behavior on delete vf mod

Renamed variable from contin to flowShouldContinue.
Updated bpmn junits and exceptionbuilder junits.
Updated bpmns to use non interrupting escalation event.
Altered bpmn and audit behavior on delete vf module

Change-Id: I4ade4c934a9193099cfd29d740c68e60633c03e5
Issue-ID: SO-1896
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix bad query, adjust sql to use non-att bb 06/88006/1
Smokowski, Steven [Fri, 17 May 2019 14:34:49 +0000 (10:34 -0400)]
Fix bad query, adjust sql to use non-att bb

Fix bad query, adjust sql to use non-att bb

Change-Id: Ifb231dee77242b37b1d8145f5a33fb3a87974b63
Issue-ID: SO-1895
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix null check for groups 41/87341/4
subhash kumar singh [Thu, 9 May 2019 09:50:48 +0000 (15:20 +0530)]
Fix null check for groups

Fix null check for groups.

Change-Id: I2432707e4a6dc6bfe49d23eddc9318562c2c43b3
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoEND_TIME is not populated by bpmn as expected 03/88003/1
Sangalang, Felix [Fri, 17 May 2019 14:16:27 +0000 (10:16 -0400)]
END_TIME is not populated by bpmn as expected

Removed/Cleaned-up unnecessary lines/codes.
Updated junit tests for END_TIME to any(Timestamp.class).
END_TIME is not populated by bpmn when rainy day retry or rollback is
executed.

Change-Id: I614d66ca767629bf43aac8eee981423e5393015e
Issue-ID: SO-1887
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoSet workflowexceptionerrormessage in all cases 02/88002/1
Boslet, Cory [Fri, 17 May 2019 14:14:26 +0000 (10:14 -0400)]
Set workflowexceptionerrormessage in all cases

Removed white spaces so that they are gone.
Change to set workflowexceptionerrormessage in all cases so that its
available to workflowactionbb.

Change-Id: I66130b80eab0c0a0f96c3a7a5509bb70dda26884
Issue-ID: SO-1886
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAudit service enhancements 01/88001/1
Boslet, Cory [Fri, 17 May 2019 14:06:55 +0000 (10:06 -0400)]
Audit service enhancements

Update number of threads used for openstack audit
Refactored post construct audit service and added junits

Change-Id: Ic5bd42cda98835305d2e2d5d09a5c039376316a5
Issue-ID: SO-1898
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "refactor so-mon-ui code"
Steve Smokowski [Wed, 15 May 2019 21:16:55 +0000 (21:16 +0000)]
Merge "refactor so-mon-ui code"

5 years agoMerge "store openstack request status in requestdb"
Steve Smokowski [Wed, 15 May 2019 21:02:51 +0000 (21:02 +0000)]
Merge "store openstack request status in requestdb"

5 years agomapped host routes into gbb l3 network object 98/87798/1
Kalkere Ramesh, Sharan [Wed, 15 May 2019 18:34:33 +0000 (14:34 -0400)]
mapped host routes into gbb l3 network object

mapped host routes into gbb l3 network object

Change-Id: Ie3ab4693f7584946b1e2020d43143412bec62631
Issue-ID: SO-1885
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agostore openstack request status in requestdb 97/87797/1
Smokowski, Steven [Wed, 15 May 2019 18:19:49 +0000 (14:19 -0400)]
store openstack request status in requestdb

Openstack request status now stored in request db

Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d
Issue-ID: SO-1867
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix sdnc nb snapshot version, fix build 20/87720/1
Marcus G K Williams [Wed, 15 May 2019 00:33:36 +0000 (17:33 -0700)]
Fix sdnc nb snapshot version, fix build

Issue-ID: SO-1877
Change-Id: I2b8f25311e92d35bffe1c70490041d32be217c5a
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoFix common ccsdk dependency and build 96/87596/1
Marcus G K Williams [Mon, 13 May 2019 21:20:33 +0000 (14:20 -0700)]
Fix common ccsdk dependency and build

Issue-ID: SO-1874
Change-Id: I898049fc986abef8c7eba0c402088686ecb20b34
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agorefactor so-mon-ui code 40/87240/5
Andrei_Barcovschi [Wed, 8 May 2019 12:54:37 +0000 (13:54 +0100)]
refactor so-mon-ui code

Change-Id: I026496a4bfd5485484394409d09df52f7d59a9da
Issue-ID: SO-1691
Signed-off-by: Andrei_Barcovschi <andrei.barcovschi@ericsson.com>
5 years agoMerge "fix newest sonar bugs"
Seshu Kumar M [Mon, 13 May 2019 04:57:52 +0000 (04:57 +0000)]
Merge "fix newest sonar bugs"

5 years agoMerge "Remove unused logger,replace type specification"
Seshu Kumar M [Mon, 13 May 2019 04:50:36 +0000 (04:50 +0000)]
Merge "Remove unused logger,replace type specification"

5 years agoMerge "Update Rainy day handling to be more robust"
Steve Smokowski [Fri, 10 May 2019 16:43:19 +0000 (16:43 +0000)]
Merge "Update Rainy day handling to be more robust"

5 years agoMerge "Updated closing gateway to be inclusive instead."
Steve Smokowski [Fri, 10 May 2019 16:43:16 +0000 (16:43 +0000)]
Merge "Updated closing gateway to be inclusive instead."

5 years agoMerge "Remove triple logging of VNF adapter response"
Steve Smokowski [Fri, 10 May 2019 16:43:13 +0000 (16:43 +0000)]
Merge "Remove triple logging of VNF adapter response"

5 years agoMerge "APIH should ensure valid requestId UUID"
Steve Smokowski [Fri, 10 May 2019 16:43:09 +0000 (16:43 +0000)]
Merge "APIH should ensure valid requestId UUID"

5 years agoMerge "Added to write variablles on audit failure"
Steve Smokowski [Fri, 10 May 2019 16:43:06 +0000 (16:43 +0000)]
Merge "Added to write variablles on audit failure"

5 years agoUpdate Rainy day handling to be more robust 61/87461/2
Smokowski, Steven [Fri, 10 May 2019 14:01:06 +0000 (10:01 -0400)]
Update Rainy day handling to be more robust

Clean up unused tests and code, update UT
Fix issue with junits and conflicts on id field
Update Rainy day handling to be more robust

Change-Id: I2ce9a1288457017613dece19357e44b8566867c5
Issue-ID: SO-1866
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoUpdated closing gateway to be inclusive instead. 63/87463/1
Boslet, Cory [Fri, 10 May 2019 14:02:49 +0000 (10:02 -0400)]
Updated closing gateway to be inclusive instead.

Updated closing gateway to be inclusive instead.

Change-Id: If877bf71b406d00f7a0e277b88f9e3064e642be0
Issue-ID: SO-1868
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAPIH should ensure valid requestId UUID 60/87460/1
Bhatt, Prema [Fri, 10 May 2019 13:55:00 +0000 (09:55 -0400)]
APIH should ensure valid requestId UUID

Added logic to check if the requestId sent in GET orchestrationRequest
query is a valid UUID. Updated existing unit tests and added a new test
for invalid UUID scenario.

Change-Id: I424bef8aa75dd7e47de8145603899820dfb99725
Issue-ID: SO-1865
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoCreated custom BadResponseException class 59/87459/1
Plummer, Brittany [Fri, 10 May 2019 13:52:31 +0000 (09:52 -0400)]
Created custom BadResponseException class

Created custom BadResponseException class

Change-Id: I9b7288c5c489e155a84f2b98956df8f3f8f53bb4
Issue-ID: SO-1864
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRemove triple logging of VNF adapter response 58/87458/1
Mcblain, Thomas [Fri, 10 May 2019 13:51:05 +0000 (09:51 -0400)]
Remove triple logging of VNF adapter response

Remove triple logging of VNF adapter response to bpel

Change-Id: Ia8f3d3b9b76616e9dcc9f638ba5ca58dcac3ab8b
Issue-ID: SO-1863
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdded to write variablles on audit failure 57/87457/1
Boslet, Cory [Fri, 10 May 2019 13:49:24 +0000 (09:49 -0400)]
Added to write variablles on audit failure

Added to write variablles on audit failure so bpmn knows whether
success or not.

Change-Id: I1eb0827a10ee75f4ee89bfb36d13035a2612e032
Issue-ID: SO-1862
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "use logger to log exception"
Steve Smokowski [Fri, 10 May 2019 12:02:27 +0000 (12:02 +0000)]
Merge "use logger to log exception"

5 years agoMerge "add junit coverage for InstantiateOperationProgressor"
Steve Smokowski [Thu, 9 May 2019 12:30:38 +0000 (12:30 +0000)]
Merge "add junit coverage for InstantiateOperationProgressor"

5 years agoMerge "Removed null checks from ResourceRequestBuilder"
Steve Smokowski [Thu, 9 May 2019 12:30:27 +0000 (12:30 +0000)]
Merge "Removed null checks from ResourceRequestBuilder"

5 years agoadd junit coverage for InstantiateOperationProgressor 39/87339/2
Lukasz Muszkieta [Thu, 9 May 2019 09:38:01 +0000 (11:38 +0200)]
add junit coverage for InstantiateOperationProgressor

Change-Id: I8409877b8db74871ccd2a3d20a1cdc8faacbe568
Issue-ID: SO-1576
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoUpdate License info 21/87321/1
seshukm [Thu, 9 May 2019 04:58:35 +0000 (10:28 +0530)]
Update License info

Issue-ID: SO-1854

Change-Id: Icd347db4fddb50a8543193394c71e61d9bd69282
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agouse logger to log exception 18/87318/2
Arindam Mondal [Thu, 9 May 2019 04:25:50 +0000 (13:25 +0900)]
use logger to log exception

sonar link:https://sonar.onap.org/project/issues?id=org.onap.so%3Aso&resolved=false&types=VULNERABILITY

Issue-ID: SO-1859
Change-Id: I599ca396db3d24cbef56bb3aea8f83b2d52ff26d
Signed-off-by: arindamm <arind.mondal@samsung.com>
5 years agoMerge "Fix resourceIndex to model"
Seshu Kumar M [Wed, 8 May 2019 08:12:11 +0000 (08:12 +0000)]
Merge "Fix resourceIndex to model"

5 years agoFix resourceIndex to model 09/87209/1
subhash kumar singh [Tue, 7 May 2019 17:20:30 +0000 (22:50 +0530)]
Fix resourceIndex to model

Fix resourceIndex to model in json mapping.

Change-Id: Ia609d3eb381b14fc5654774e83f8417a4d876e91
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agofix newest sonar bugs 00/86800/2
k.kazak [Thu, 2 May 2019 09:58:21 +0000 (11:58 +0200)]
fix newest sonar bugs

OperationProgressor: restore interrupted state
PnfEventReadyDmaapClient: remove useless check for null that never happens
Test for this case already exists in
PnfEventReadyDmaapClientTest.pnfCorrelationIdIsNotFoundInHttpResponse

Change-Id: Ic7e4d0cb701721ee4d9a8bc46d65dc1d847d7704
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoUpdate the format of resourceInput 54/87054/2
zm330 [Mon, 6 May 2019 16:07:22 +0000 (00:07 +0800)]
Update the format of resourceInput

Save format when resource is list type
e.g.
{key2:[vf_prop_list,INDEX,key]|default}

Issue-ID: SO-1393

Change-Id: Ibb5e7bb31114fa3bbd7a3e1af5f2152a98941a4b
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
5 years agoRemoved null checks from ResourceRequestBuilder 09/87109/1
r.bogacki [Tue, 7 May 2019 06:22:38 +0000 (08:22 +0200)]
Removed null checks from ResourceRequestBuilder

Removed unnecessary null checks from ResourceRequestBuilder
according to comments from https://gerrit.onap.org/r/#/c/87001/

Change-Id: I21140d812982713229c322d772e6a10f7c7c044d
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agoRemove unused logger,replace type specification 88/85888/2
Sindhuri.A [Sat, 20 Apr 2019 08:46:52 +0000 (14:16 +0530)]
Remove unused logger,replace type specification

Remove unused logger,replace type specification sdnc beans and mapper classes

Issue-ID: SO-1490

Change-Id: I9a671f0ade5b86dbfd4cce1fbc6c07c0fdcf38a8
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>