cps.git
4 weeks agoCM SUBSCRIPTION: add new subscription for non existing xpath 91/137991/7
emaclee [Mon, 20 May 2024 07:54:44 +0000 (08:54 +0100)]
CM SUBSCRIPTION: add new subscription for non existing xpath

- added new method for when adding new subscription for non
  existing xpath but existing cmhandle

Issue-ID: CPS-2207
Change-Id: I149fbaea2f276503cb9d45c8807519bbe0417f3b
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
5 weeks agoSet CPS Project Status to 'Mature' 38/137938/1
ToineSiebelink [Thu, 16 May 2024 14:33:16 +0000 (15:33 +0100)]
Set CPS Project Status to 'Mature'

As approved by TSC on 2024-05-16
See also https://wiki.onap.org/display/DW/ONAP+Project+and+Component+Lifecycle

Issue-ID: CPS-2224
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I60933c208a98adb65cf68e7fdc352839846a772c

5 weeks agoMerge "Integration for getting cm handle by longest alternate id match"
Toine Siebelink [Thu, 16 May 2024 13:42:27 +0000 (13:42 +0000)]
Merge "Integration for getting cm handle by longest alternate id match"

5 weeks agoMerge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module...
Toine Siebelink [Thu, 16 May 2024 08:18:10 +0000 (08:18 +0000)]
Merge "CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources"

5 weeks agoMerge "More fine tuning around remainin plots"
Toine Siebelink [Wed, 15 May 2024 14:34:52 +0000 (14:34 +0000)]
Merge "More fine tuning around remainin plots"

5 weeks agoMore fine tuning around remainin plots 10/137910/1
halil.cakal [Wed, 15 May 2024 13:50:33 +0000 (14:50 +0100)]
More fine tuning around remainin plots

- Fine tuning for the plots only:
- Read datatrees for multiple xpaths
- Query with all descendants
- Writing 200 devices
- Saving list of 50 devices

Issue-ID: CPS-2192

Change-Id: I508e31cd861a4006cac41ebbbe307b7bd2acde2f
Signed-off-by: halil.cakal <halil.cakal@est.tech>
5 weeks agoCPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources 38/137838/8
david.mcweeney [Wed, 1 May 2024 11:08:00 +0000 (12:08 +0100)]
CPS-2181 - #1 Included Module Set Tag in NCMP calls to DMI for Yang Module Resources

Change-Id: I4f8cf79667e3155f49b9109d26b5807f5d54f90c
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2181

5 weeks agoIntegration for getting cm handle by longest alternate id match 34/137834/3
sourabh_sourabh [Thu, 2 May 2024 15:46:21 +0000 (16:46 +0100)]
Integration for getting cm handle by longest alternate id match

- Added a new integration test to check total time and memory taken to
  get cm handle by its longest match alternate id.

Issue-ID: CPS-2176
Change-Id: I7a6b299c46803a0878406f1e16fdae970b361dd9
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
5 weeks agoBump CPS to 3.5.0-SNAPSHOT 02/137902/1
mpriyank [Wed, 15 May 2024 09:39:02 +0000 (10:39 +0100)]
Bump CPS to 3.5.0-SNAPSHOT

- bump cps to 3.5.0-SNAPSHOT

Issue-ID: CPS-2228
Change-Id: I8a6d7e702b557d5b90dd384bbe429de4958ef77f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 weeks agoMerge "CPS Bump to 3.4.10-SNAPSHOT"
Daniel Hanrahan [Tue, 14 May 2024 12:25:36 +0000 (12:25 +0000)]
Merge "CPS Bump to 3.4.10-SNAPSHOT"

5 weeks agoMerge "Adjust percentage limits to 10 percent below the threshold"
Toine Siebelink [Tue, 14 May 2024 11:51:10 +0000 (11:51 +0000)]
Merge "Adjust percentage limits to 10 percent below the threshold"

5 weeks agoCPS Bump to 3.4.10-SNAPSHOT 89/137889/2
mpriyank [Tue, 14 May 2024 09:09:55 +0000 (10:09 +0100)]
CPS Bump to 3.4.10-SNAPSHOT

- bumping CPS to 3.4.10-SNAPSHOT version

Issue-ID: CPS-2221
Change-Id: I8513582791078762bfb9d828966028c233e031db
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
5 weeks agoMerge "container yaml for cps 3.4.9"
Daniel Hanrahan [Tue, 14 May 2024 08:59:23 +0000 (08:59 +0000)]
Merge "container yaml for cps 3.4.9"

6 weeks agocontainer yaml for cps 3.4.9 87/137887/1
mpriyank [Mon, 13 May 2024 17:28:53 +0000 (18:28 +0100)]
container yaml for cps 3.4.9

- container yaml to release CPS 3.4.9

Issue-ID: CPS-2221
Change-Id: I8dee6c42230f38c7a1fdf1dc7821e71c5da2af06
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 weeks agoMaven stage yaml for CPS 3.4.9 86/137886/2
mpriyank [Mon, 13 May 2024 17:22:14 +0000 (18:22 +0100)]
Maven stage yaml for CPS 3.4.9

- maven stage yaml to release CPS 3.4.9

Issue-ID: CPS-2221
Change-Id: Ifc16ed01cc4d7928d5f9ec86ebe668ab26285584
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 weeks agoAdjust percentage limits to 10 percent below the threshold 85/137885/1
halil.cakal [Mon, 13 May 2024 12:43:55 +0000 (13:43 +0100)]
Adjust percentage limits to 10 percent below the threshold

Issue-ID: CPS-2192

Change-Id: Iac37751b17f186e550ce12e3e17968d90cbf432a
Signed-off-by: halil.cakal <halil.cakal@est.tech>
6 weeks agoMerge "Ncmp out event for REJECTED scenario"
Daniel Hanrahan [Fri, 10 May 2024 13:22:05 +0000 (13:22 +0000)]
Merge "Ncmp out event for REJECTED scenario"

6 weeks agoNcmp out event for REJECTED scenario 70/137870/1
mpriyank [Thu, 9 May 2024 15:04:40 +0000 (16:04 +0100)]
Ncmp out event for REJECTED scenario

- Handling and publishing the event to client when dmi plugin rejects
  applying the subscription
- test scenarios to support the same

Issue-ID: CPS-2214
Change-Id: I2ac6d125a7262a7428a962d81a26a33594b570d9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 weeks agoFine tuning of the performance plots 69/137869/2
halil.cakal [Thu, 9 May 2024 14:24:46 +0000 (15:24 +0100)]
Fine tuning of the performance plots

- Fine tune some of the performance plots which are
  not align to the limit

Issue-ID: CPS-2200

Change-Id: I925443aa74a4eb814728d0642db0951c76f86186
Signed-off-by: halil.cakal <halil.cakal@est.tech>
6 weeks agoRelease note for cps-change-event toggle 66/137866/1
mpriyank [Thu, 9 May 2024 10:46:09 +0000 (11:46 +0100)]
Release note for cps-change-event toggle

- Release notes to enable and disable the toggle functionality
  introduced.
- If the CPS change events are of no interest to them then they can be
  disabled by the environment variable CPS_CHANGE_EVENT_NOTIFICATIONS_ENABLED

Issue-ID: CPS-2211
Change-Id: If2fddb6a499e24194b3eeca2ecdf99b8fb5ec687
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 weeks agoConditional cps change events 54/137854/3
mpriyank [Tue, 7 May 2024 14:33:19 +0000 (15:33 +0100)]
Conditional cps change events

- introduced a parameter to control the cps core change event
  notifications. we should be able to disable these notifications
  without affecting other notification flows.
- fixed the LayeredArchitectureTest as we are accessing the Anchor model
  in the events package now.

Issue-ID: CPS-2213
Change-Id: Id875925bc14de1cc6e8fa3193c0df470e09fe43f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
6 weeks agoMerge "Schedule response to client"
Lee Anjella Macabuhay [Tue, 7 May 2024 09:57:09 +0000 (09:57 +0000)]
Merge "Schedule response to client"

7 weeks agoMerge "[BUG] Correctly parse observedTimestamp"
Lee Anjella Macabuhay [Fri, 3 May 2024 14:55:32 +0000 (14:55 +0000)]
Merge "[BUG] Correctly parse observedTimestamp"

7 weeks ago[BUG] Correctly parse observedTimestamp 41/137841/6
mpriyank [Fri, 3 May 2024 12:45:03 +0000 (13:45 +0100)]
[BUG] Correctly parse observedTimestamp

- Using the DateTimeUtility to parse the passed OffsetDateTime and using
  it for conversion to string
- Moving to actual src/main/java from test side as it is to be used in
  the prod code as well and only keeping the methods in use.
- Added test to fix the coverage issue

Issue-ID: CPS-2211
Change-Id: I2b4325bb77a6da7fd470986b1da293f455650375
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
7 weeks agoMerge "Release notes is updated for error hanndling related to upgrade operation"
Priyank Maheshwari [Fri, 3 May 2024 13:13:36 +0000 (13:13 +0000)]
Merge "Release notes is updated for error hanndling related to upgrade operation"

7 weeks agoRelease notes is updated for error hanndling related to upgrade 40/137840/1
sourabh_sourabh [Fri, 3 May 2024 12:10:36 +0000 (13:10 +0100)]
Release notes is updated for error hanndling related to upgrade
operation

Issue-ID: CPS-2204
Change-Id: Iaa3f61c53e4120cdf19b7ad1c3313fc32f904866
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
7 weeks agoMake NCMP integration tests use MockWebServer 39/137739/5
sourabh_sourabh [Thu, 2 May 2024 09:26:16 +0000 (10:26 +0100)]
Make NCMP integration tests use MockWebServer

Change from using MockRestServiceServer - which is only compatible
with RestTemplate - to MockWebServer, which will allow tests to work
using WebClient instead of RestTemplate.

Issue-ID: CPS-2183
Change-Id: I7494fe17cba6e92f7df81f0fd0185e1d2b5a5541
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
7 weeks agoSchedule response to client 35/137835/1
mpriyank [Fri, 3 May 2024 09:48:04 +0000 (10:48 +0100)]
Schedule response to client

- Scheduling sending the response by reading whatever is present in the
  cache for subscription after a pre-configured time.
- Also added test validation for the same

Issue-ID: CPS-2209
Change-Id: Ifacb0b12734a0529e671b0b63836189a243e453c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
7 weeks agoMerge "Query operation path by alternate id"
Daniel Hanrahan [Thu, 2 May 2024 09:42:34 +0000 (09:42 +0000)]
Merge "Query operation path by alternate id"

7 weeks agoHandle error in case of upgrade operation 28/137828/4
sourabh_sourabh [Thu, 2 May 2024 09:08:04 +0000 (10:08 +0100)]
Handle error in case of upgrade operation

- Send an error response if cm handle not found for upgrade operation.
- Restrict upgrade operation if it is already in progress.

Issue-ID:CPS-2204
Change-Id: Iad63732c5b1d2215b06a09ddda1c0c604cd7648c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
7 weeks agoMerge "Add Notification support in cps core"
Priyank Maheshwari [Thu, 2 May 2024 08:58:44 +0000 (08:58 +0000)]
Merge "Add Notification support in cps core"

7 weeks agoMerge "CM Subscription: Link method to publish to DMI in service layer"
Daniel Hanrahan [Wed, 1 May 2024 13:45:20 +0000 (13:45 +0000)]
Merge "CM Subscription: Link method to publish to DMI in service layer"

7 weeks agoBump CPS version 25/137825/1
danielhanrahan [Wed, 1 May 2024 12:53:00 +0000 (13:53 +0100)]
Bump CPS version

- bump cps to 3.4.9-SNAPSHOT
- also updated the release notes

Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifd7feb413baac30e3cbbdf2aeaac5fbb5ae2e463

7 weeks agoContainer YAML for CPS 3.4.8 24/137824/1
danielhanrahan [Wed, 1 May 2024 12:22:56 +0000 (13:22 +0100)]
Container YAML for CPS 3.4.8

- added container yaml for cps 3.4.8

Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id6ef50ab413bb910fa6ea866964ffe01d90b9b29

7 weeks agoMaven stage yaml for 3.4.8 23/137823/1
danielhanrahan [Wed, 1 May 2024 11:43:16 +0000 (12:43 +0100)]
Maven stage yaml for 3.4.8

- added maven stage yaml to release CPS 3.4.8 version

Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic734ec947de86a30cf7b3f080a82c518403a4f5f

7 weeks agoUpdate OpenAPI docs for 3.4.8 21/137821/1
danielhanrahan [Wed, 1 May 2024 10:25:36 +0000 (11:25 +0100)]
Update OpenAPI docs for 3.4.8

Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib520a55b099b7a89751dab7032cabeba19b6a934

7 weeks agoCM Subscription: Link method to publish to DMI in service layer 20/137820/1
emaclee [Tue, 30 Apr 2024 17:18:31 +0000 (18:18 +0100)]
CM Subscription: Link method to publish to DMI in service layer

- Add call to method to publish to DMI for create request
- Refactor calls to all Mappers to a single Mapper class handler

Issue-ID: CPS-2196
Change-Id: I6476f47684ea9a0f55a7d207c1931a0fef8aa672
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
7 weeks agoRelease notes update for 3.4.8 93/137793/4
danielhanrahan [Fri, 26 Apr 2024 10:55:55 +0000 (11:55 +0100)]
Release notes update for 3.4.8

Add release notes updates for bug fix CPS-2190 (slow module search)

Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I9c4500727640040593aacbd209c2d5ec6a86a315

7 weeks agoMerge "[BUG]Defaults for cps and dmi user and pass"
Daniel Hanrahan [Tue, 30 Apr 2024 14:50:15 +0000 (14:50 +0000)]
Merge "[BUG]Defaults for cps and dmi user and pass"

7 weeks agoMerge "CM Subscription: REfactor classes of producers and consumers"
Priyank Maheshwari [Tue, 30 Apr 2024 14:44:15 +0000 (14:44 +0000)]
Merge "CM Subscription: REfactor classes of producers and consumers"

7 weeks ago[BUG]Defaults for cps and dmi user and pass 16/137816/3
mpriyank [Tue, 30 Apr 2024 09:14:26 +0000 (10:14 +0100)]
[BUG]Defaults for cps and dmi user and pass

- provided default values for DMI_USERNAME and DMI_PASSWORD which is
  required to set when DMI_AUTH_ENABLED is true
- Also provided defaults for CPS_USERNAME and CPS_PASSWORD as its
  been used in the logback xml file and if not provided then causes an
  issue with the logger

Issue-ID: CPS-2194
Change-Id: I70fdbeca970556c7bd19f27c1b6b5123fd591283
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
7 weeks agoReverted web client changes as it breaking CPS functionality: 19/137819/2
sourabh_sourabh [Tue, 30 Apr 2024 12:19:11 +0000 (13:19 +0100)]
Reverted web client changes as it breaking CPS functionality:

1. Error handling not working
2. Unable to make dmi call as url appens extra "/"

Commit 1: Replace RestTemplate with WebClient in synchronous DMI calls

    - added DmiWebClientConfiguration
    - use WebClient in DmiRestClient
    - fixed unit tests
    - ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
    - encode query params for DMI requests

Commit 2: Module sync task failing with WebClient

    - added configurable buffer size

Commit 3: Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize

Issue-ID:CPS-989, CPS-2195, CPS-2198

Change-Id: I6c71ab2801b222708404f51bd60f2b3031ebf32e
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
7 weeks agoAdd Notification support in cps core 60/137160/19
rajesh.kumar [Fri, 23 Feb 2024 14:59:59 +0000 (20:29 +0530)]
Add Notification support in cps core

Add notification support using cloud events

Issue-ID:CPS-2068
Change-Id: I56c34400dc73c71b936a51260efd240223babacd
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
7 weeks agoMerge "Ajust time limits for performance tests"
Daniel Hanrahan [Tue, 30 Apr 2024 09:15:24 +0000 (09:15 +0000)]
Merge "Ajust time limits for performance tests"

8 weeks agoCM Subscription: REfactor classes of producers and consumers 18/137818/1
emaclee [Mon, 29 Apr 2024 09:30:20 +0000 (10:30 +0100)]
CM Subscription: REfactor classes of producers and consumers

Issue-ID: CPS-2196
Change-Id: I0b56f37a1b615b9615d6bd7005348733e1739a46
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
8 weeks agoRe-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter 06/137806/4
sourabh_sourabh [Mon, 29 Apr 2024 14:42:22 +0000 (15:42 +0100)]
Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize

Issue-ID: CPS-2198

Change-Id: Id441208c66433b2539adf83a0881c3c3c79d2b15
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
8 weeks agoQuery operation path by alternate id 35/137735/7
sourabh_sourabh [Wed, 24 Apr 2024 11:29:53 +0000 (12:29 +0100)]
Query operation path by alternate id

- New method is written to find longest match for fdn path
- Introduced new exception for alternate id

Issue-ID: CPS-2142
Change-Id: Ifd048574db88586a2d37a3681034a083eb2b7691
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
8 weeks agoAjust time limits for performance tests 07/137807/1
halil.cakal [Mon, 29 Apr 2024 14:39:10 +0000 (15:39 +0100)]
Ajust time limits for performance tests

- new time limits adjusted for dedicated
  physical cps-performance test-server

Issue-ID: CPS-2192

Change-Id: Ia258a8f7460b3fbe68e5b3b61bc918f7d394c1b1
Signed-off-by: halil.cakal <halil.cakal@est.tech>
8 weeks agoMerge "Module sync task failing with WebClient"
Daniel Hanrahan [Mon, 29 Apr 2024 10:52:08 +0000 (10:52 +0000)]
Merge "Module sync task failing with WebClient"

8 weeks agoMerge "CM SUBSCRIPTION: Remove accepted and rejected cache entries"
Priyank Maheshwari [Mon, 29 Apr 2024 10:21:46 +0000 (10:21 +0000)]
Merge "CM SUBSCRIPTION: Remove accepted and rejected cache entries"

8 weeks agoModule sync task failing with WebClient 95/137795/5
leventecsanyi [Fri, 26 Apr 2024 11:35:32 +0000 (13:35 +0200)]
Module sync task failing with WebClient

    - added configurable buffer size

Issue-ID: CPS-2195
Change-Id: I7cdb09856fd4d80134a91e54faa7e6600f3721dc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
8 weeks agoCM SUBSCRIPTION: Remove accepted and rejected cache entries 94/137794/1
emaclee [Thu, 25 Apr 2024 12:01:06 +0000 (13:01 +0100)]
CM SUBSCRIPTION: Remove accepted and rejected cache entries

Issue-ID: CPS-2185
Change-Id: I01ba8e4f6e0e42a31ad5234ad468ac4625c2b0f3
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
8 weeks agoFaster module searches (CPS-2190 #3) 90/137790/1
danielhanrahan [Fri, 26 Apr 2024 09:09:54 +0000 (10:09 +0100)]
Faster module searches (CPS-2190 #3)

This greatly improves performance of module searches by eliminating
unneeded SQL queries via Hibernate lazy fetching.

Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie9e65017d0027366456f1741cc37b10679317b25

8 weeks ago[BUG] Remove slow validation check during module search (CPS-2190 #2) 68/137768/2
danielhanrahan [Thu, 25 Apr 2024 13:33:05 +0000 (14:33 +0100)]
[BUG] Remove slow validation check during module search (CPS-2190 #2)

The check for existing modules is extremely slow, being dependent on
the file sizes of the Yang modules being queries.
The validation check is also completely unnecessary, since it simply
ignores any exceptions and returns an empty set, which the main logic
does implicitly. (The Dataspace check is also not needed, as the NCMP
dataspace is guaranteed to exist.)

Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I329c1f8aac3f50bda0333e6c9c686f47af2e009f

8 weeks agoPerf Test for Module Search is dependent on module size (CPS-2190 #1) 59/137759/3
danielhanrahan [Wed, 24 Apr 2024 13:15:47 +0000 (14:15 +0100)]
Perf Test for Module Search is dependent on module size (CPS-2190 #1)

Add a new test showing that Yang module search is dependent on the
 file size of the Yang modules being searched for.

Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I8fd28f4c91be11ef7428251397a887af17649015

2 months agoReplace RestTemplate with WebClient in synchronous DMI calls 13/137713/13
leventecsanyi [Thu, 18 Apr 2024 14:30:29 +0000 (16:30 +0200)]
Replace RestTemplate with WebClient in synchronous DMI calls

    - added DmiWebClientConfiguration
    - use WebClient in DmiRestClient
    - fixed unit tests
    - ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
    - encode query params for DMI requests

Issue-ID:CPS-989
Change-Id: I26434568f68266e95669a51c134978ddd197d802
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoMerge "Reject create request with duplicated subscriptionId"
Priyank Maheshwari [Wed, 24 Apr 2024 16:22:49 +0000 (16:22 +0000)]
Merge "Reject create request with duplicated subscriptionId"

2 months agoReject create request with duplicated subscriptionId 22/137722/6
emaclee [Tue, 16 Apr 2024 08:56:59 +0000 (09:56 +0100)]
Reject create request with duplicated subscriptionId

Issue-ID: CPS-2184
Change-Id: I1bddb02239e6a2d3f47aa731eb24a9f1f64e63b5
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Signed-off-by: seanbeirne <sean.beirne@est.tech>
2 months agoNcmpCloudEventBuilder refactoring 34/137734/1
mpriyank [Wed, 24 Apr 2024 11:03:46 +0000 (12:03 +0100)]
NcmpCloudEventBuilder refactoring

- Builder named as NcmpEvent and we have specialised method to build the
  NcmpEvent as cloud event now
- Introduced source as the builder default property

Issue-ID: CPS-2191
Change-Id: I51c571313091ce9a4d10f4e1af7423eee999cea8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months ago[BUG] Make failed async task report failure on Kafka topic 23/137723/3
danielhanrahan [Tue, 16 Apr 2024 21:04:44 +0000 (22:04 +0100)]
[BUG] Make failed async task report failure on Kafka topic

- In event of async task timeout, error code 102
  (DMI_SERVICE_NOT_RESPONDING) is sent to client topic.
- In event of unexpected error (such as database unavailable),
  error code 108 (UNKNOWN_ERROR) is sent to client topic.
- The default timeouts have been adjusted so that the task
  timeout (60s) is longer than the HTTP and Database timeouts (30s),
  so that expected codes are returned.

Issue-ID: CPS-2186
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I84c3447a625e084c445ab2f5c01e2b32a0c971ac

2 months agoTemporary dsiable Operation Too Large Exception 20/137720/1
ToineSiebelink [Fri, 19 Apr 2024 09:25:01 +0000 (10:25 +0100)]
Temporary dsiable Operation Too Large Exception

- settign limit to 50000 to efftively disable it
- ericsson is not ready and wil infrom us when it can be enabled again

Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib1a8308a20bd77fcba9c4c9fc94739d5dd731b1f

2 months agoFix build issue with subscription 09/137709/2
emaclee [Thu, 18 Apr 2024 09:43:05 +0000 (10:43 +0100)]
Fix build issue with subscription

Issue-ID: CPS-2164
Change-Id: I49a18df0927b5beff62a12f9bc2a2e8e486537c9
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2 months agoMerge "Cm Subscription: Remove subscription method"
Daniel Hanrahan [Wed, 17 Apr 2024 15:49:48 +0000 (15:49 +0000)]
Merge "Cm Subscription: Remove subscription method"

2 months agoCm Subscription: Remove subscription method 00/137600/7
emaclee [Wed, 27 Mar 2024 12:46:39 +0000 (12:46 +0000)]
Cm Subscription: Remove subscription method

- method to remove a subscription Id from leaflist
- condition if subscription list is empty, remove subscription
  all together

Issue-ID: CPS-2164
Change-Id: Id694f441f9675fa9a048e3b824e1f02fae73f87e
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2 months agoMerge "Handle Subscription Response from DMI"
Priyank Maheshwari [Fri, 12 Apr 2024 12:24:39 +0000 (12:24 +0000)]
Merge "Handle Subscription Response from DMI"

2 months agoHandle Subscription Response from DMI 99/137599/4
seanbeirne [Tue, 26 Mar 2024 10:28:17 +0000 (10:28 +0000)]
Handle Subscription Response from DMI

Issue-ID: CPS-1972
Change-Id: Idb8ad14f06e365707404d099a4581282d4a0add9
Signed-off-by: seanbeirne <sean.beirne@est.tech>
2 months agoMerge "Update depcrecated method in KafaConfig"
Toine Siebelink [Thu, 11 Apr 2024 10:09:42 +0000 (10:09 +0000)]
Merge "Update depcrecated method in KafaConfig"

2 months agoUpdate depcrecated method in KafaConfig 70/137670/1
ToineSiebelink [Wed, 10 Apr 2024 15:43:19 +0000 (16:43 +0100)]
Update depcrecated method in KafaConfig

Issue-ID: CPS-2179
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I882746a68f2d32f07fbcfeeac1f45b9dbbb8c62e

2 months agoDefine a java based datastructure for DataJob and interface 50/137550/15
sourabh_sourabh [Tue, 2 Apr 2024 12:35:33 +0000 (13:35 +0100)]
Define a java based datastructure for DataJob and interface

- Defined java interface to handle datajob
- Defined all the modules needed to process data job request
- data jon response module id also defined
- dummy impl. of java interface

Issue-ID: CPS-2155
Change-Id: I20c7b621aa4bd40fe7758cb19b8720fc7cf5164c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
2 months agoIntroduce and handle Operation Too Large Exception for batch operations 62/137662/4
ToineSiebelink [Tue, 9 Apr 2024 17:39:51 +0000 (18:39 +0100)]
Introduce and handle Operation Too Large Exception for batch operations

Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Iec05d2013be4f971309f0e75d84dc5d0936eb8ef

2 months agoDocument new NCMP Status Code: 112, message too large 60/137660/2
ToineSiebelink [Tue, 9 Apr 2024 16:32:40 +0000 (17:32 +0100)]
Document new NCMP Status Code: 112, message too large

- Updated RTD
- Added new value to relevant Enum (although not used in our code)

Issue-ID: CPS-2178
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I4ba8c1622921919ae253a292d96307439ef20e2a

2 months agoAdd OpenSFF ScoreCard Action to GitHub 47/137647/1
ToineSiebelink [Thu, 4 Apr 2024 15:02:52 +0000 (16:02 +0100)]
Add OpenSFF ScoreCard Action to GitHub

Issue-ID: CPS-2158
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Idf4f29756317591b616e776b750aca3340e428f1

2 months agoMerge "Remove old committers from INFO.yaml"
Toine Siebelink [Thu, 4 Apr 2024 10:03:10 +0000 (10:03 +0000)]
Merge "Remove old committers from INFO.yaml"

2 months agoMerge "Add integration tests of NCMP REST API"
Toine Siebelink [Thu, 4 Apr 2024 09:37:43 +0000 (09:37 +0000)]
Merge "Add integration tests of NCMP REST API"

2 months agoRemove old committers from INFO.yaml 44/137644/1
ToineSiebelink [Thu, 4 Apr 2024 09:13:43 +0000 (10:13 +0100)]
Remove old committers from INFO.yaml

Issue-ID: CPS-1887
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic147dc498307fa24ce5953ba39df0f4e3a2e6a13

2 months agoMerge "Add moduleSetTag to the request towards dmi plugin"
Toine Siebelink [Thu, 4 Apr 2024 08:45:18 +0000 (08:45 +0000)]
Merge "Add moduleSetTag to the request towards dmi plugin"

2 months agoMerge "Modify INFO.yaml for committer rights"
Toine Siebelink [Thu, 4 Apr 2024 08:40:36 +0000 (08:40 +0000)]
Merge "Modify INFO.yaml for committer rights"

2 months agoAdd moduleSetTag to the request towards dmi plugin 39/137639/7
leventecsanyi [Tue, 2 Apr 2024 12:47:31 +0000 (14:47 +0200)]
Add moduleSetTag to the request towards dmi plugin

    - mapping module set tag to DmiRequest

Issue-ID: CPS-2030
Change-Id: I487e48baf98919d3ff5e25d2428a065dd3a30335
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
2 months agoMerge "[BUG] Mock DMI will respond to Health Checks during tests"
Toine Siebelink [Thu, 4 Apr 2024 08:07:26 +0000 (08:07 +0000)]
Merge "[BUG] Mock DMI will respond to Health Checks during tests"

2 months agoBump CPS version 11/137611/1
mpriyank [Fri, 29 Mar 2024 13:47:19 +0000 (13:47 +0000)]
Bump CPS version

- bump cps to 3.4.8-SNAPSHOT
- also updated the release notes

Issue-ID: CPS-2168
Change-Id: Iee7f1e2febbf28b0d5a2855d3128d9eb8bb3c490
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoContainer YAML for CPS 10/137610/1
mpriyank [Fri, 29 Mar 2024 12:07:23 +0000 (12:07 +0000)]
Container YAML for CPS

- added container yaml for cps 3.4.7

Issue-ID: CPS-2168
Change-Id: Ieb3afc2eb7f62e20bedef28cd5da3a2e7731bfa0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoMaven stage yaml for 3.4.7 09/137609/1
mpriyank [Fri, 29 Mar 2024 11:37:33 +0000 (11:37 +0000)]
Maven stage yaml for 3.4.7

- added maven stage yaml to release CPS 3.4.7 version

Issue-ID: CPS-2168
Change-Id: Id139fcf1c19acb2ffdd0a9e39066dc961158159b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoRelease notes for 3.4.7 CPS 08/137608/1
mpriyank [Fri, 29 Mar 2024 10:57:05 +0000 (10:57 +0000)]
Release notes for 3.4.7 CPS

 - updated release notes for CPS 3.4.7 version

Issue-ID: CPS-2168
Change-Id: I3a6689234e63db301787d49a5c76063c0b6203ae
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoMerge "Uplift Spring boot 3.2.4"
Priyank Maheshwari [Fri, 29 Mar 2024 10:22:51 +0000 (10:22 +0000)]
Merge "Uplift Spring boot 3.2.4"

2 months agoUplift Spring boot 3.2.4 72/137572/11
emaclee [Sun, 24 Mar 2024 19:05:34 +0000 (19:05 +0000)]
Uplift Spring boot 3.2.4

- uplifted spring boot from 3.1.2 to 3.2.4
- removed redundant dependencies
- upgraded relevant dependencies
- use of @Bean(some_name) is give a specific bean name
- using @Bean(some_name) with @Qualifier so on the injection point to specify which bean to actually inject, this is used as we deal with multiple beans of the same type.

Issue-ID: CPS-2101
Change-Id: I64d5bf567b9eb03fb39034a46528d0160b332715
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2 months agoAdd integration tests of NCMP REST API 49/137249/3
danielhanrahan [Thu, 28 Mar 2024 17:30:50 +0000 (17:30 +0000)]
Add integration tests of NCMP REST API

Add some tests using MockMvc of NCMP REST API:
- CM handle registration
- CM handle ID searches
- CM handle deregistration

Issue-ID: CPS-2033
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I493aca8c3f8c263f5a50f6a2c66e317b9a6e08aa

2 months ago[BUG] Mock DMI will respond to Health Checks during tests 93/137593/6
danielhanrahan [Tue, 26 Mar 2024 18:03:36 +0000 (18:03 +0000)]
[BUG] Mock DMI will respond to Health Checks during tests

Health Check for DMI is sometimes running during integration tests,
causing the mockDmiServer to fail due to unexpected Rest requests.
As a fix, the mock DMI will respond to health checks.

Issue-ID: CPS-2167
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie4a0059583e66dfcc00e1aa998671a662ccf053a

2 months agoModify INFO.yaml for committer rights 06/137606/1
danielhanrahan [Thu, 28 Mar 2024 16:29:56 +0000 (16:29 +0000)]
Modify INFO.yaml for committer rights

Issue-ID: CPS-1887
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ibe95eaf58679fc4c2d7486f1402d922d1264b450

2 months agoMerge "Scheduled task for Subscription Response"
Lee Anjella Macabuhay [Wed, 27 Mar 2024 16:26:42 +0000 (16:26 +0000)]
Merge "Scheduled task for Subscription Response"

2 months agoFix code smell 01/137601/4
emaclee [Wed, 27 Mar 2024 14:54:50 +0000 (14:54 +0000)]
Fix code smell

- change string to formatted

Issue-ID: CPS-475
Change-Id: I59271c63f244c4d6684b145b1afe2356668e6fd8
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
2 months agoScheduled task for Subscription Response 16/137516/13
mpriyank [Thu, 14 Mar 2024 09:11:27 +0000 (09:11 +0000)]
Scheduled task for Subscription Response

- Need to send the response back to the client in max 30 secs
- Also have the capability to send the response right away
- Testware added for the same
- Also added code to cancel the scheduled task
- Added state for cancelling the task

Issue-ID: CPS-2140
Change-Id: I3ab321d8221cd8f697c26be46d2e63d89b360923
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
2 months agoMerge "Condense Liquibase steps"
Toine Siebelink [Tue, 26 Mar 2024 16:38:50 +0000 (16:38 +0000)]
Merge "Condense Liquibase steps"

2 months agoCondense Liquibase steps 69/137469/13
david.mcweeney [Wed, 21 Feb 2024 09:51:29 +0000 (09:51 +0000)]
Condense Liquibase steps

Change-Id: I1493f49bb93c359df3ff7d4f928f9a94fb8b2604
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2061

2 months agoMerge "Code review cleanup for: Add kafka messaging support to integration test module"
Lee Anjella Macabuhay [Tue, 26 Mar 2024 10:42:15 +0000 (10:42 +0000)]
Merge "Code review cleanup for: Add kafka messaging support to integration test module"

3 months agoCode review cleanup for: Add kafka messaging support to integration test module 48/137548/2
halil.cakal [Fri, 22 Mar 2024 11:46:03 +0000 (11:46 +0000)]
Code review cleanup for: Add kafka messaging support to integration test module

- Address code review on commit which already merged
  https://gerrit.onap.org/r/c/cps/+/137496

Issue-ID: CPS-2152

Change-Id: I7a46dd08c919227c37fdeacf4763d0ab364c88c1
Signed-off-by: halil.cakal <halil.cakal@est.tech>
3 months agoMerge "Save new cm notification subscription"
Priyank Maheshwari [Mon, 25 Mar 2024 15:28:54 +0000 (15:28 +0000)]
Merge "Save new cm notification subscription"

3 months agoSave new cm notification subscription 36/137536/2
emaclee [Tue, 19 Mar 2024 12:43:51 +0000 (12:43 +0000)]
Save new cm notification subscription

Issue-ID: CPS-2043
Change-Id: If1c066a7d1c1f7e1c154714fe06f2566b727634c
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
3 months agoMerge "Add kafka messaging support to integration test module"
Toine Siebelink [Tue, 19 Mar 2024 17:02:00 +0000 (17:02 +0000)]
Merge "Add kafka messaging support to integration test module"

3 months agoMerge "Update deployment docs for Postgres shared_buffers value"
Toine Siebelink [Tue, 19 Mar 2024 16:13:04 +0000 (16:13 +0000)]
Merge "Update deployment docs for Postgres shared_buffers value"

3 months agoAdd kafka messaging support to integration test module 96/137496/11
halil.cakal [Mon, 11 Mar 2024 14:19:36 +0000 (14:19 +0000)]
Add kafka messaging support to integration test module

- add ncmp test using kafka to integration test suite

Issue-ID: CPS-2152

Change-Id: Ia486bbcf1590ecf3ec6cbc2f513b74d55e4d6a31
Signed-off-by: halil.cakal <halil.cakal@est.tech>