so.git
4 years agoupdate the relaese notes 79/90079/1
seshukm [Tue, 18 Jun 2019 11:59:23 +0000 (17:29 +0530)]
update the relaese notes

Issue-ID: SO-1992

Change-Id: I07169b2083661601308edf79dae205685bd45266
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
4 years agoMerge "Fix sonar issues in mso-openstack-adapters"
Steve Smokowski [Mon, 17 Jun 2019 12:53:57 +0000 (12:53 +0000)]
Merge "Fix sonar issues in mso-openstack-adapters"

4 years agoMerge "Sonar fixes and improvements"
Steve Smokowski [Mon, 17 Jun 2019 12:53:39 +0000 (12:53 +0000)]
Merge "Sonar fixes and improvements"

4 years agoMerge "Validate ServiceInstance name using createNodesUri"
Steve Smokowski [Mon, 17 Jun 2019 12:52:12 +0000 (12:52 +0000)]
Merge "Validate ServiceInstance name using createNodesUri"

4 years agoSonar fixes and improvements 66/89666/4
r.bogacki [Tue, 11 Jun 2019 06:48:21 +0000 (08:48 +0200)]
Sonar fixes and improvements

General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Improvements in diamond operators.
-Removed unnecessary code.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9345b6ab0f4027b17e1bebf0b6657394c13dc298

4 years agoImprovements in MsoVnfAdapterImpl 36/89736/2
r.bogacki [Wed, 12 Jun 2019 08:46:14 +0000 (10:46 +0200)]
Improvements in MsoVnfAdapterImpl

Improvements in MsoVnfAdapterImpl according to the Sonar analyses.
-Removed unnecessary code.
-Fixed imports.
-Extracted constants.

Issue-ID: SO-2011
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c

5 years agoValidate ServiceInstance name using createNodesUri 54/89954/1
Sangalang, Felix [Sun, 16 Jun 2019 16:00:36 +0000 (12:00 -0400)]
Validate ServiceInstance name using createNodesUri

Validate ServiceInstance name using createNodesUri.

Change-Id: I5194dd933dc98064888250bc9a38e6ee9716fc01
Issue-ID: SO-2024
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Validate names before writing to A&AI"
Max Benjamin [Sat, 15 Jun 2019 14:08:46 +0000 (14:08 +0000)]
Merge "Validate names before writing to A&AI"

5 years agoMerge "update multi stage code to accurately skip bbs"
Max Benjamin [Sat, 15 Jun 2019 14:08:41 +0000 (14:08 +0000)]
Merge "update multi stage code to accurately skip bbs"

5 years agoMerge "dmaap client using wrong auth property"
Max Benjamin [Sat, 15 Jun 2019 14:08:37 +0000 (14:08 +0000)]
Merge "dmaap client using wrong auth property"

5 years agoMerge "support async operation for vf module operations"
Steve Smokowski [Fri, 14 Jun 2019 20:09:16 +0000 (20:09 +0000)]
Merge "support async operation for vf module operations"

5 years agoMerge "add is_data_internal column to request db"
Max Benjamin [Fri, 14 Jun 2019 19:55:16 +0000 (19:55 +0000)]
Merge "add is_data_internal column to request db"

5 years agoMerge "use count format and limit one for exists"
Max Benjamin [Fri, 14 Jun 2019 19:55:06 +0000 (19:55 +0000)]
Merge "use count format and limit one for exists"

5 years agoMerge "adapter client will not retry on openstack failure"
Max Benjamin [Fri, 14 Jun 2019 19:55:02 +0000 (19:55 +0000)]
Merge "adapter client will not retry on openstack failure"

5 years agoadd is_data_internal column to request db 22/89922/1
Mnushkin, Dmitry [Fri, 14 Jun 2019 18:46:49 +0000 (14:46 -0400)]
add is_data_internal column to request db

add is_data_internal column to request processing data
Use Boolean type in java bean to be mapped by hibernate

Change-Id: I40a96f80114e02a2ced17efb47e45718dfd2ee7c
Issue-ID: SO-2023
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoValidate names before writing to A&AI 20/89920/1
Sangalang, Felix [Fri, 14 Jun 2019 18:45:16 +0000 (14:45 -0400)]
Validate names before writing to A&AI

Validate name for InstanceGroup, Configuration and Network.

Change-Id: I494749e17a40c6c0cdd51dd28d9c9bca371410ac
Issue-ID: SO-2022
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agomso to validate the name uniqueness in A&AI 19/89919/1
Gamboa, Gilbert [Fri, 14 Jun 2019 18:15:54 +0000 (14:15 -0400)]
mso to validate the name uniqueness in A&AI

Need to change query by name using nodes query to make sure names are
globally unique.
Added new Exception type for duplicate A&AI object names.
Added tests for AAIVfModulResources.

Change-Id: I71558d0881d7060819f5f807fe58779be6edfa6f
Issue-ID: SO-2020
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofix delete stack error not propogating 91/89891/2
Smokowski, Steven [Fri, 14 Jun 2019 13:12:10 +0000 (09:12 -0400)]
fix delete stack error not propogating

Update logic to properly format rollback error messages

Change-Id: I66ad4fd78758661be297810f393e6da759daa17b
Issue-ID: SO-2014
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoupdate multi stage code to accurately skip bbs 03/89903/1
Benjamin, Max [Fri, 14 Jun 2019 14:12:35 +0000 (10:12 -0400)]
update multi stage code to accurately skip bbs

moved around classes to packages that make more sense
updated license headers in java files
converted MultiStage logic to FlowManipulator
moved tests to new package location and fixed issues
allow for custom listeners before flowsToExecute
moved validation classes to listener.validation

Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6
Issue-ID: SO-2021
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agodmaap client using wrong auth property 97/89897/1
Boslet, Cory [Fri, 14 Jun 2019 13:44:54 +0000 (09:44 -0400)]
dmaap client using wrong auth property

Changed dmaap client to set auth property correctly to prevent double
decryting and wrong value

Change-Id: I83dc8c67e94a8bec187c056e7dfa1f966cc5ee3c
Issue-ID: SO-2019
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agouse count format and limit one for exists 95/89895/1
Benjamin, Max [Fri, 14 Jun 2019 13:42:00 +0000 (09:42 -0400)]
use count format and limit one for exists

use count format and limit one for exists

Change-Id: If15ccf0a63bf6fd5e732eb150bfdbed22c5a3f1d
Issue-ID: SO-2017
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoadapter client will not retry on openstack failure 94/89894/1
Sangalang, Felix [Fri, 14 Jun 2019 13:40:04 +0000 (09:40 -0400)]
adapter client will not retry on openstack failure

Utilized the original util method with boolean argument.
inventory audit: adapter client should not retry on openstack failures.

Change-Id: Ibdcec58c662f54ccef887e74f17634baa9df2457
Issue-ID: SO-2016
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agosupport async operation for vf module operations 92/89892/1
Smokowski, Steven [Fri, 14 Jun 2019 13:26:20 +0000 (09:26 -0400)]
support async operation for vf module operations

support async operation for vf module operations with sdnc
Update Junit comparison data to be valid for new code
Modify coded to support usage of ASYNC response sdnc

Change-Id: I95b955cb257dcead152d68cd4cc4fb0fbcdfd708
Issue-ID: SO-2015
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "update logger statements in apih"
Steve Smokowski [Tue, 11 Jun 2019 17:51:55 +0000 (17:51 +0000)]
Merge "update logger statements in apih"

5 years agoUpdated sdno to use msokey config property 06/89706/1
Boslet, Cory [Tue, 11 Jun 2019 14:23:58 +0000 (10:23 -0400)]
Updated sdno to use msokey config property

Updated sdno to use msokey config property instead of one that doesnt
exist

Change-Id: I7f1bc39ae1dae3f6b0cab8c05c97950f45c83f71
Issue-ID: SO-2009
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoupdate logger statements in apih 05/89705/1
Bhatt, Prema [Tue, 11 Jun 2019 14:21:56 +0000 (10:21 -0400)]
update logger statements in apih

Corrected arguments to logger methods
only log exception in catch blocks

Change-Id: I0657b00ce45ac543d5e900db6ce5c24ba34e345d
Issue-ID: SO-2007
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoImprovements in ServiceInstances 72/89672/1
r.bogacki [Tue, 11 Jun 2019 08:07:07 +0000 (10:07 +0200)]
Improvements in ServiceInstances

Improvements in ServiceInstances according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary code.
-Refactored diamond operators.

Issue-ID: SO-2008
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ieb03f5b3fb52432091170402237ba4e23ed70e5d

5 years agoMerge "replaced String.repeat with static final strings"
Steve Smokowski [Mon, 10 Jun 2019 14:43:07 +0000 (14:43 +0000)]
Merge "replaced String.repeat with static final strings"

5 years agoMerge "Improvements in JsonUtilForPnfCorrelationId"
Lukasz Muszkieta [Mon, 10 Jun 2019 14:09:41 +0000 (14:09 +0000)]
Merge "Improvements in JsonUtilForPnfCorrelationId"

5 years agoreplaced String.repeat with static final strings 87/89587/4
Benjamin, Max [Fri, 7 Jun 2019 15:13:59 +0000 (11:13 -0400)]
replaced String.repeat with static final strings

replaced String.repeat with static final strings

Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoSonar fixes and improvements 88/89488/3
r.bogacki [Thu, 6 Jun 2019 08:32:49 +0000 (10:32 +0200)]
Sonar fixes and improvements

General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary variables.
-Added String constants.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I8b77def931e703c8a73929ec09324823a91721e3

5 years agoImprovements in JsonUtilForPnfCorrelationId 64/89564/2
r.bogacki [Fri, 7 Jun 2019 08:19:23 +0000 (10:19 +0200)]
Improvements in JsonUtilForPnfCorrelationId

General fixes and improvements according to the Sonar analysis
-Added private constructor for a utility class.
-Refactored lambda expression.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ife8cfdf9c341dc89a1699fd616ec68cba734a5d5

5 years agoMerge "Added ext_system_error_source column to requestdb"
Steve Smokowski [Sun, 9 Jun 2019 19:45:23 +0000 (19:45 +0000)]
Merge "Added ext_system_error_source column to requestdb"

5 years agoMerge "Switched name and id, and updated tests"
Steve Smokowski [Sun, 9 Jun 2019 19:45:11 +0000 (19:45 +0000)]
Merge "Switched name and id, and updated tests"

5 years agoUpdate stack save to only save the params object 20/89620/1
Smokowski, Steven [Sun, 9 Jun 2019 14:39:47 +0000 (10:39 -0400)]
Update stack save to only save the params object

use get parameters not store entire request of stack
Update stack save to only save off the params object

Change-Id: I41e0e03b412e37f12d348c84a1512c9bf4403748
Issue-ID: SO-2002
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdded ext_system_error_source column to requestdb 19/89619/1
Plummer, Brittany [Sun, 9 Jun 2019 14:38:55 +0000 (10:38 -0400)]
Added ext_system_error_source column to requestdb

Added ext_system_error_source column to requestdb

Change-Id: Iad9ad0178546aad2b64014987ff3da60f01f8bd4
Issue-ID: SO-2001
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoSwitched name and id, and updated tests 18/89618/1
Plummer, Brittany [Sun, 9 Jun 2019 14:38:07 +0000 (10:38 -0400)]
Switched name and id, and updated tests

Switched name and id, and updated tests

Change-Id: Ica8251be71d2fd9362e4f209755d80bc36ccbf66
Issue-ID: SO-2000
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge remote-tracking branch 'origin/dublin' into 'origin/master' 97/89597/5
Benjamin, Max (mb388a) [Sat, 8 Jun 2019 00:28:02 +0000 (20:28 -0400)]
Merge remote-tracking branch 'origin/dublin' into 'origin/master'

Change-Id: Ib8eaae7ee4a404bde568803afaf6c4e183cbbd53
Issue-ID: SO-2004
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix Master Build - Use 1.5.0-SNAPSHOT of so/libs 08/89608/1
Marcus G K Williams [Fri, 7 Jun 2019 20:47:04 +0000 (13:47 -0700)]
Fix Master Build - Use 1.5.0-SNAPSHOT of so/libs

Issue-ID: SO-2006
Change-Id: Ice30a4bb39d314b047bb92953de578908fd6af81
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoFix Dublin Build- Use Release 1.4.0 OpenStack Libs 03/89603/1
Marcus G K Williams [Fri, 7 Jun 2019 20:14:20 +0000 (13:14 -0700)]
Fix Dublin Build- Use Release 1.4.0 OpenStack Libs

Issue-ID: SO-2005
Change-Id: If1483009d57179e01fbe52e07fbf4a3c81ae3ebf
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoMerge "Typo in bpmn mso-request-id variable name"
Steve Smokowski [Fri, 7 Jun 2019 17:40:11 +0000 (17:40 +0000)]
Merge "Typo in bpmn mso-request-id variable name"

5 years agoMerge "Handle when model cust uuid is null from sdnc"
Steve Smokowski [Fri, 7 Jun 2019 17:39:21 +0000 (17:39 +0000)]
Merge "Handle when model cust uuid is null from sdnc"

5 years agoMerge "Check if configuration resource already exists."
Steve Smokowski [Fri, 7 Jun 2019 17:39:13 +0000 (17:39 +0000)]
Merge "Check if configuration resource already exists."

5 years agoMerge "Updated to use the logicalResourceId"
Steve Smokowski [Fri, 7 Jun 2019 17:39:03 +0000 (17:39 +0000)]
Merge "Updated to use the logicalResourceId"

5 years agoMerge "resume request support"
Steve Smokowski [Fri, 7 Jun 2019 17:38:55 +0000 (17:38 +0000)]
Merge "resume request support"

5 years agoMerge "vrfvalidation exceptions not getting logged"
Steve Smokowski [Fri, 7 Jun 2019 17:38:46 +0000 (17:38 +0000)]
Merge "vrfvalidation exceptions not getting logged"

5 years agoMerge "change the update line to update the latest stack"
Steve Smokowski [Fri, 7 Jun 2019 17:38:37 +0000 (17:38 +0000)]
Merge "change the update line to update the latest stack"

5 years agoMerge "Enhance naming service support"
Steve Smokowski [Fri, 7 Jun 2019 17:38:26 +0000 (17:38 +0000)]
Merge "Enhance naming service support"

5 years agoMerge "Accommodate WAN Networking"
Steve Smokowski [Fri, 7 Jun 2019 17:38:13 +0000 (17:38 +0000)]
Merge "Accommodate WAN Networking"

5 years agoMerge "Set response code in UpdateAAIGenericVnf"
Max Benjamin [Fri, 7 Jun 2019 12:37:42 +0000 (12:37 +0000)]
Merge "Set response code in UpdateAAIGenericVnf"

5 years agoAdd non-cloudowner nbrequest lookup in workflowAction 53/89553/2
Marcus G K Williams [Fri, 7 Jun 2019 01:12:52 +0000 (18:12 -0700)]
Add non-cloudowner nbrequest lookup in workflowAction

Using a cloudOwner different than "CloudOwner"
when instantiating a vfmodule using GR_API
causes nbrequest lookup in workflowAction to
fail. This change adds a final check for
northboundRequest that does not use
cloudOwner field before failing.

This should enable instantiation
on multiple cloudRegions without
seperate northbound_request_ref_lookup
actions for each cloudOwner.

Issue-ID: SO-1995
Change-Id: I9d1fe39fb056d03e8473a524c21f41319c13c20f
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoresume request support 45/89545/1
Plummer, Brittany [Thu, 6 Jun 2019 20:02:00 +0000 (16:02 -0400)]
resume request support

copy request body rewrite requestorid
added missing curly brace case to regex
Updated how we are updating requestorId in requestBody
Removed unused imports from RequestHandlerUtils
Replaced requestorId in requestBody string
Began updating requestorId in requestBody

Change-Id: I54bd8097b196899b271956f03395bb98d295e1e0
Issue-ID: SO-1990
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoHandle when model cust uuid is null from sdnc 44/89544/1
Mcblain, Thomas [Thu, 6 Jun 2019 19:59:20 +0000 (15:59 -0400)]
Handle when model cust uuid is null from sdnc

Modify wording on null uuid exception and test for it
Expand null handling to vfmc and cvnfc find in lists
Modify to chain the filter of nulls then to match.
Change to ExpectedException in junit; filter nulls.
Handle better when model cust. uuid is null from sdnc

Change-Id: I1f1edffa1db84509bd649803660a55510868b6eb
Issue-ID: SO-1989
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agovrfvalidation exceptions not getting logged 43/89543/1
Gamboa, Gilbert [Thu, 6 Jun 2019 19:55:45 +0000 (15:55 -0400)]
vrfvalidation exceptions not getting logged

Remove unused imports in VrfValidation class
Check for null AAI network and vpn-bindings. Do not catch exceptions in
WorkflowAction.traverseVrfCondifuration. Propagate exceptions and let
calling method selectExecutionList() handle exceptions.

Change-Id: I26adfdb351cee6dc111f496901558340b8152a2a
Issue-ID: SO-1988
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoUpdated to use the logicalResourceId 42/89542/1
Plummer, Brittany [Thu, 6 Jun 2019 19:51:46 +0000 (15:51 -0400)]
Updated to use the logicalResourceId

Updated to use the logicalResourceId instead of physicalResourceId

Change-Id: I2ebc800cf7ce4b5794bece7c304ebd7d1ac92088
Issue-ID: SO-1979
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoCheck if configuration resource already exists. 41/89541/1
Merkel, Jeff [Thu, 6 Jun 2019 19:50:15 +0000 (15:50 -0400)]
Check if configuration resource already exists.

Check if configuration resource already exists.

Change-Id: I359aaa96ef66b37880cf369c3f5bd7bfd828aab1
Issue-ID: SO-1978
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agochange the update line to update the latest stack 40/89540/1
Kalkere Ramesh, Sharan [Thu, 6 Jun 2019 19:48:55 +0000 (15:48 -0400)]
change the update line to update the latest stack

fix the unit test for latest stack update
change the update line to update the latest stack

Change-Id: I8b7f903c9f7bbae1163f1363a19f18b2803f558c
Issue-ID: SO-1977
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoEnhance naming service support 39/89539/1
Mnushkin, Dmitry [Thu, 6 Jun 2019 19:34:19 +0000 (15:34 -0400)]
Enhance naming service support

correct sourcing for service-model-name in NamingMS
remove zone ID from NamingMS input for service name
follow up removal of autowired on NamingRequestObject

Change-Id: Icba2e32c07ee0c7d7739ce21bd547e3030c1e271
Issue-ID: SO-1976
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAccommodate WAN Networking 38/89538/2
Gamboa, Gilbert [Thu, 6 Jun 2019 18:23:36 +0000 (14:23 -0400)]
Accommodate WAN Networking

checked and evaluated naming policy only if infra bonding.
Updated workflowAction to include vrf configuration for vpn-binding in
resourceIds list.
added in linked resource to service proxy cust
committing the asdc controller classpath change
added some unit tests for vrf validation and updated bbinput setup test
update config resource cust foreign key mapping
Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest.
added in a check to see if list is empty before access
added unit tests for bbinput setup for vrf config
Update AssignFlows enum with correct AssignVrfConfiguration flow name

Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44
Issue-ID: SO-1975
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"
Max Benjamin [Thu, 6 Jun 2019 17:37:59 +0000 (17:37 +0000)]
Merge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"

5 years agoMerge remote-tracking branch 'origin/dublin' into 'origin/master' 30/89530/1
Steve Smokowski [Wed, 5 Jun 2019 20:24:37 +0000 (16:24 -0400)]
Merge remote-tracking branch 'origin/dublin' into 'origin/master'

Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38
Issue-ID: SO-1980
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
5 years agoMerge "Improvements in ServiceDecomposition"
Lukasz Muszkieta [Thu, 6 Jun 2019 08:25:07 +0000 (08:25 +0000)]
Merge "Improvements in ServiceDecomposition"

5 years agoMerge "Changed service orc status to Assigned" into dublin 1.4.3
Seshu Kumar M [Thu, 6 Jun 2019 08:15:39 +0000 (08:15 +0000)]
Merge "Changed service orc status to Assigned" into dublin

5 years agoMerge "Added post process to AAI in HandlePNF" into dublin
Seshu Kumar M [Thu, 6 Jun 2019 08:15:33 +0000 (08:15 +0000)]
Merge "Added post process to AAI in HandlePNF" into dublin

5 years agoMerge "Improvements in SniroHomingV2"
Lukasz Muszkieta [Thu, 6 Jun 2019 07:50:21 +0000 (07:50 +0000)]
Merge "Improvements in SniroHomingV2"

5 years agoMerge "update SO release notes" into dublin
subhash kumar singh [Thu, 6 Jun 2019 07:21:37 +0000 (07:21 +0000)]
Merge "update SO release notes" into dublin

5 years agoImprovements in ServiceDecomposition 80/89480/1
r.bogacki [Thu, 6 Jun 2019 06:48:21 +0000 (08:48 +0200)]
Improvements in ServiceDecomposition

Improvements in ServiceDecomposition according to the Sonar analysis.
-Fixed imports.
-Replaced System.out with logger.
-Simplified if statements.
-Removed unused code.

Issue-ID: SO-1997
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: If7c399635fffef5bc75b10c7d93be4b27e097bd7

5 years agoupdate SO release notes 79/89479/1
seshukm [Thu, 6 Jun 2019 05:59:34 +0000 (11:29 +0530)]
update SO release notes

Issue-ID: SO-1992

Change-Id: I47f9651740ab012e05dc09f9b874cfba6fc83699
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoChanged service orc status to Assigned 10/89410/1
marios.iakovidis [Wed, 5 Jun 2019 17:31:51 +0000 (20:31 +0300)]
Changed service orc status to Assigned

Issue-ID: SO-1938
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I68d684f837f2dea9decb2e577742ab905f825d04

5 years agoAdded post process to AAI in HandlePNF 09/89409/1
marios.iakovidis [Wed, 5 Jun 2019 17:21:16 +0000 (20:21 +0300)]
Added post process to AAI in HandlePNF

Issue-ID: SO-1993
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I6abec916438221669817b49997431b6164ee1a76

5 years agoMerge "Fix ConfigAssign/Deploy null return of BlueprintName/Version" into dublin
Steve Smokowski [Wed, 5 Jun 2019 12:50:28 +0000 (12:50 +0000)]
Merge "Fix ConfigAssign/Deploy null return of BlueprintName/Version" into dublin

5 years agoGeneral Sonar fixes and improvements 62/89362/2
r.bogacki [Wed, 5 Jun 2019 12:11:00 +0000 (14:11 +0200)]
General Sonar fixes and improvements

General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary variables.
-Protect utility static classes with private constructor.
-Removed unnecessary exceptions.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib0011d730f86e0e1a25d4cf1080a61b2fbb335ae

5 years agoImprovements in SniroHomingV2 23/89323/1
r.bogacki [Wed, 5 Jun 2019 06:41:46 +0000 (08:41 +0200)]
Improvements in SniroHomingV2

Improvements in SniroHomingV2 according to the Sonar analyses.
-Removed unnecessary variables.
-Removed duplicated code.
-Added String constants.
-Improvements for an array size checking.
-Refactored diamond operators for a simplicity.

Issue-ID: SO-1991
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ia4f23210635e1ffad97eeb1d881a269fe391ff73

5 years agoAdd SO exclude ConfigurationScaleOutBB 21/89321/1
Bonkur, Venkat (vb8416) [Wed, 5 Jun 2019 02:46:14 +0000 (22:46 -0400)]
Add SO exclude ConfigurationScaleOutBB

Updated the WorkflowAction.isConfiguration() to exclude ConfigurationScaleOutBB
problem- VF module check failure during scale out
Issue-ID: SO-1982
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I5caa6f1c5ff21131ea1c42a63b441a39f77a6e62

5 years agoHandle 201 and 422 status codes 19/89419/1
Elena Kuleshov [Wed, 5 Jun 2019 00:49:09 +0000 (20:49 -0400)]
Handle 201 and 422 status codes

SDC activitySpec API returns 201 for success and 422 when already exists

Issue-ID: SO-1996
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I75837b75cbd24f4ccfb97a07e91219b3b61453f6

5 years agoFix ConfigAssign/Deploy null return of BlueprintName/Version 84/89284/5
sunilb [Tue, 4 Jun 2019 23:30:15 +0000 (05:00 +0530)]
Fix ConfigAssign/Deploy null return of BlueprintName/Version

Fix ConfigAssign/Deploy null return of BlueprintName/Version
Issue-ID: SO-1985
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: I15b6d38a21320eae6ca58a1e3d515813b9c243fd

5 years agoFix northbound_request_ref_lookup SERVICE_TYPE = '*' 83/89283/1
Marcus G K Williams [Tue, 4 Jun 2019 20:33:44 +0000 (13:33 -0700)]
Fix northbound_request_ref_lookup SERVICE_TYPE = '*'

Make sure SERVICE_TYPE is not NULL so that
GR_API alacarte requests work.

Issue-ID: SO-1904 SO-1892
Change-Id: Ib4c617311b17f6d521a3eee0a71a6247d7770d54
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoTypo in bpmn mso-request-id variable name 77/89277/1
Yang Xu [Fri, 24 May 2019 20:17:50 +0000 (16:17 -0400)]
Typo in bpmn mso-request-id variable name

Change-Id: I50e7f33a3a38e77c84874d75ab33c5f9bb693f8b
Issue-ID: SO-1922
Signed-off-by: Yang Xu <yang.xu3@huawei.com>
(cherry picked from commit 253a7e17c7b89acfc3cb8748239a544bade75437)

5 years agoSet response code in UpdateAAIGenericVnf 75/89275/1
Yang Xu [Tue, 28 May 2019 05:09:11 +0000 (01:09 -0400)]
Set response code in UpdateAAIGenericVnf

Change-Id: I67fb789d40ea86a82379e76b94c2da1bd552cd31
Issue-ID: SO-1927
Signed-off-by: Yang Xu <yxu@futurewei.com>
(cherry picked from commit 019a4125af612b59f11571f52e4f369cfa59ba0c)

5 years agoMerge "Add SO Turn off OpenStack heat stack audit" into dublin
Steve Smokowski [Tue, 4 Jun 2019 12:10:18 +0000 (12:10 +0000)]
Merge "Add SO Turn off OpenStack heat stack audit" into dublin

5 years agoImprovements in ToscaResourceInstaller 28/89228/1
r.bogacki [Tue, 4 Jun 2019 11:02:46 +0000 (13:02 +0200)]
Improvements in ToscaResourceInstaller

Improvements in ToscaResourceInstaller according to the Sonar analyses.
-Removed unnecessary imports.
-Removed unnecessary exceptions.
-Improvements for an array size checking.
-Refactored diamond operators for a simplicity.

Issue-ID: SO-1984
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I498933adadbb2d6f5dc956b0056c728f141e3869

5 years agoImprovements in VfResourceStructure 25/89225/1
r.bogacki [Tue, 4 Jun 2019 10:30:05 +0000 (12:30 +0200)]
Improvements in VfResourceStructure

Improvements in VfResourceStructure according to the Sonar analyses.
-Removed unnecessary imports.
-Removed unnecessary exceptions.
-Improvements for possible NPE issues.

Issue-ID: SO-1983
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I014c5de19eca853cf1263b541e2c34b6e6db9b1d

5 years agoAdd SO Turn off OpenStack heat stack audit 76/89176/2
Bonkur, Venkat (vb8416) [Mon, 3 Jun 2019 19:36:31 +0000 (15:36 -0400)]
Add SO Turn off OpenStack heat stack audit

UPDATE these files
so/bpmn/mso-infrastructure-bpmn/src/main/resources/application.yaml
so/mso-api-handlers/mso-api-handler-infra/src/main/resources/application.yaml
should have
mso: infra:
    auditInventory: false
Issue-ID: SO-1974
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I57bb396604e9eb2787122199cdf8a2d1ce54048a

5 years agoMerge "Fix ConfigAssignVnfBB and ConfigDeployVnfBB"
Marcus Williams [Mon, 3 Jun 2019 23:11:29 +0000 (23:11 +0000)]
Merge "Fix ConfigAssignVnfBB and ConfigDeployVnfBB"

5 years agoMerge "update INFO.yaml"
Marcus Williams [Mon, 3 Jun 2019 20:57:36 +0000 (20:57 +0000)]
Merge "update INFO.yaml"

5 years agoupdate INFO.yaml 01/89101/4
seshukm [Fri, 31 May 2019 04:31:16 +0000 (10:01 +0530)]
update INFO.yaml

Issue-ID: SO-1944

Change-Id: I221fc3cce7f72373ad35a6ce07c887e928038348
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
(cherry picked from commit c32829b9f2e67a46fb56b590c253fd3bdc9cce97)

5 years agoFix ConfigAssignVnfBB and ConfigDeployVnfBB 49/89149/5
Alexis de Talhouët [Mon, 3 Jun 2019 14:14:58 +0000 (10:14 -0400)]
Fix ConfigAssignVnfBB and ConfigDeployVnfBB

Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
5 years agoFix ConfigAssignVnfBB and ConfigDeployVnfBB 47/89147/6
Alexis de Talhouët [Mon, 3 Jun 2019 13:58:07 +0000 (09:58 -0400)]
Fix ConfigAssignVnfBB and ConfigDeployVnfBB

Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
5 years agoMerge "update INFO.yaml" into dublin
Steve Smokowski [Mon, 3 Jun 2019 15:39:17 +0000 (15:39 +0000)]
Merge "update INFO.yaml" into dublin

5 years agoupdate INFO.yaml 50/89150/1
seshukm [Mon, 3 Jun 2019 14:25:34 +0000 (19:55 +0530)]
update INFO.yaml

Issue-ID: SO-1929

Change-Id: I21b68e16851a23bc4869fa08df86d57f68de1c5a
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoCleaned up duplicated literals 20/88620/7
rob.bog [Tue, 28 May 2019 11:18:24 +0000 (13:18 +0200)]
Cleaned up duplicated literals

Cleaned up Sonar code smells related to the duplicated
literals in loggers.

Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e

5 years agoMerge "Modify scaleOut-related settings" into dublin
Seshu Kumar M [Mon, 3 Jun 2019 10:01:06 +0000 (10:01 +0000)]
Merge "Modify scaleOut-related settings" into dublin

5 years agoMerge "Added orchestration status to service" into dublin
Seshu Kumar M [Mon, 3 Jun 2019 00:37:23 +0000 (00:37 +0000)]
Merge "Added orchestration status to service" into dublin

5 years agoAdded orchestration status to service 35/88935/3
marios.iakovidis [Sun, 2 Jun 2019 21:31:21 +0000 (00:31 +0300)]
Added orchestration status to service

Issue-ID: SO-1938
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I78cc401a746ef4dbca41a869729b9791210038f4

5 years agoFixing EtSI BB ClassCastException 03/89103/1
waqas.ikram [Sun, 2 Jun 2019 15:24:20 +0000 (15:24 +0000)]
Fixing EtSI BB ClassCastException

Change-Id: Ia5a37f80392693f603d6597760ca9725882de169
Issue-ID: SO-1971
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
5 years agoMerge "New GroupLevel DeleteE2EServiceInstance flow"
Seshu Kumar M [Sun, 2 Jun 2019 07:58:31 +0000 (07:58 +0000)]
Merge "New GroupLevel DeleteE2EServiceInstance flow"

5 years agoMerge "property to determine if delete audit is needed"
Steve Smokowski [Fri, 31 May 2019 21:58:13 +0000 (21:58 +0000)]
Merge "property to determine if delete audit is needed"

5 years agoMerge "apih resume request handling more generic"
Steve Smokowski [Fri, 31 May 2019 21:58:03 +0000 (21:58 +0000)]
Merge "apih resume request handling more generic"

5 years agoMerge "issue encoding openstack errors"
Steve Smokowski [Fri, 31 May 2019 21:57:53 +0000 (21:57 +0000)]
Merge "issue encoding openstack errors"

5 years agoMerge "Fix issue where request was not being updated"
Steve Smokowski [Fri, 31 May 2019 21:57:41 +0000 (21:57 +0000)]
Merge "Fix issue where request was not being updated"