so.git
5 years agoMerge "Fix the monitroing feature"
Byung-Woo Jun [Sun, 23 Sep 2018 17:08:15 +0000 (17:08 +0000)]
Merge "Fix the monitroing feature"

5 years agoMerge "Fix the developer info"
Byung-Woo Jun [Sat, 22 Sep 2018 14:47:39 +0000 (14:47 +0000)]
Merge "Fix the developer info"

5 years agoMerge "Fix improper Licesnse scans"
Byung-Woo Jun [Sat, 22 Sep 2018 14:46:32 +0000 (14:46 +0000)]
Merge "Fix improper Licesnse scans"

5 years agoFix the monitroing feature 39/68539/1
seshukm [Sat, 22 Sep 2018 10:30:47 +0000 (18:30 +0800)]
Fix the monitroing feature

Change-Id: I6be6c8aabfe1a1248d72d7e77db017e1d1d57562
Issue-ID: SO-1085
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoFix the developer info 35/68535/1
seshukm [Sat, 22 Sep 2018 05:21:19 +0000 (13:21 +0800)]
Fix the developer info

Change-Id: Id5c96acc2a5fff6ddb4470aa8ed822a287a90fc7
Issue-ID: SO-1084
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoFix improper Licesnse scans 31/68531/2
seshukm [Sat, 22 Sep 2018 04:47:54 +0000 (12:47 +0800)]
Fix improper Licesnse scans

Change-Id: I701f1b9475e0a1f74e007c90757b70bc4502b6da
Issue-ID: SO-915
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "DeploymentInfo tests and construction improvement"
Seshu Kumar M [Sat, 22 Sep 2018 04:29:22 +0000 (04:29 +0000)]
Merge "DeploymentInfo tests and construction improvement"

5 years agoMerge "various bugfixes for casablanca"
Rob Daugherty [Fri, 21 Sep 2018 15:24:50 +0000 (15:24 +0000)]
Merge "various bugfixes for casablanca"

5 years agoMerge "added test case to ResponseHandlerTest.java"
Seshu Kumar M [Fri, 21 Sep 2018 07:37:43 +0000 (07:37 +0000)]
Merge "added test case to ResponseHandlerTest.java"

5 years agoMerge "Update OofHoming w/ directives"
Seshu Kumar M [Fri, 21 Sep 2018 01:36:06 +0000 (01:36 +0000)]
Merge "Update OofHoming w/ directives"

5 years agoUpdate OofHoming w/ directives 07/68307/1
Marcus G K Williams [Fri, 21 Sep 2018 00:46:07 +0000 (17:46 -0700)]
Update OofHoming w/ directives

Issue-ID: SO-746
Change-Id: I597f7621a32eeb5b8e92cf80700c60bccdc5e560
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoMerge "Add Java OofClient"
Byung-Woo Jun [Fri, 21 Sep 2018 00:36:41 +0000 (00:36 +0000)]
Merge "Add Java OofClient"

5 years agoMerge "Add multicloud to VnfPluginAdapter"
Marcus Williams [Fri, 21 Sep 2018 00:04:50 +0000 (00:04 +0000)]
Merge "Add multicloud to VnfPluginAdapter"

5 years agoAdd multicloud to VnfPluginAdapter 21/66521/10
Eric Multanen [Fri, 14 Sep 2018 11:42:38 +0000 (04:42 -0700)]
Add multicloud to VnfPluginAdapter

Adds new mode 'multicloud' to VnfPluginAdapter
along with MsoMulticloudUtils and supporting
code.

Change-Id: I1cfdc9ba09c58315fb0bfc025854cf0122a32759
Issue-ID: SO-752
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
5 years agoMerge "Standardize 3rd party library versions"
Seshu Kumar M [Fri, 21 Sep 2018 00:03:01 +0000 (00:03 +0000)]
Merge "Standardize 3rd party library versions"

5 years agoMerge "Add homing flag to alacart flows"
Rob Daugherty [Thu, 20 Sep 2018 21:30:12 +0000 (21:30 +0000)]
Merge "Add homing flag to alacart flows"

5 years agoAdd homing flag to alacart flows 33/68233/2
Marcus G K Williams [Wed, 19 Sep 2018 22:41:58 +0000 (15:41 -0700)]
Add homing flag to alacart flows

Issue-ID: SO-745
Change-Id: I5e9e5031be403d17e0dc141a0879b0a28062168e
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agovarious bugfixes for casablanca 49/67749/2
Benjamin, Max (mb388a) [Wed, 19 Sep 2018 13:56:15 +0000 (09:56 -0400)]
various bugfixes for casablanca

fixed unit tests after addition of A&AI edge label
added option for edgelabel between vnf inst group
added belongs to in connecting a vnf to instance group
- Adding test for
getRainyDayHandlerStatusByFlowNameAndServiceTypeAndVnfTypeAndErrorCodeAn
dWorkStep method in the catalogdb client
correct default RainyDay table search input
updated custom resolver to include float and added comment to explain
timestamp configuration
added a custom resolver and updated snake yaml version
Replacing bowman client with restTemplate.exchange | Add Accept and
Content-Type to headers
Removing the unused imports as well
Implementing some review comments for hte tests being ignored
Replacing bowman client with restTemplate.exchange |Fixing Junits
Replacing bowman client with restTemplate.exchange | Making Data
inserts to go specifically in requestDB
Replacing bowman client with restTemplate.exchange | Adding Junits
Replacing bowman client with restTemplate.exchange | Adding Junits
Replacing bowman client with restTemplate.exchange | Adding Junits
Replacing bowman client with restTemplate.exchange
- Updated tosca parser version to 1.4.3 and upgraded vnfc test case
with new csar to pass with latest parser code.
added test case for when workflow has not called all flows
fixed issue with rollback and retry in workflowaction
Reverted homing changes and changes assign vnf to use the homing
produced GeneralBuildingBlock.
fixed unit test to build the correct format hashmap
reverted extraction back to LinkedHashMap
marshal sdnc output to an object
removed unused variables and imports
extract response code/message from embedded map
add junits to parse SDNC assign response
removed missed org.openecomp.mso imports from bpmn

Change-Id: Ib2b6591a744ecb5b08c522494cdf1ad7dae18a08
Issue-ID: SO-1069
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Runtime BPMN Deployment Capability"
Rob Daugherty [Thu, 20 Sep 2018 18:35:13 +0000 (18:35 +0000)]
Merge "Runtime BPMN Deployment Capability"

5 years agoMerge "Do not use twice Homing ID for two BPMN"
Rob Daugherty [Thu, 20 Sep 2018 18:18:23 +0000 (18:18 +0000)]
Merge "Do not use twice Homing ID for two BPMN"

5 years agoMerge "Activity for Flow Completion Status"
Rob Daugherty [Thu, 20 Sep 2018 18:18:10 +0000 (18:18 +0000)]
Merge "Activity for Flow Completion Status"

5 years agoRuntime BPMN Deployment Capability 43/68143/2
Elena Kuleshov [Thu, 20 Sep 2018 15:07:23 +0000 (11:07 -0400)]
Runtime BPMN Deployment Capability

Added license header to BpmnInstaller.java
ASDC Controller integration with BPMN Installer
Correct a test file name in a JUnit.
BPMN deployment mechanism for WorkflowDesigner

Change-Id: I670406dd09b8789c86ab0b85ef122b35ea057698
Issue-ID: SO-826
Signed-off-by: Elena Kuleshov <EK1439@att.com>
5 years agoDo not use twice Homing ID for two BPMN 07/68207/1
Alexis de Talhouët [Thu, 20 Sep 2018 16:52:19 +0000 (12:52 -0400)]
Do not use twice Homing ID for two BPMN

ID must be unique.

Change-Id: Ie5af43240732592a27e6afbf815a351c58e1f5c4
Issue-ID: SO-1078
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
5 years agoStandardize 3rd party library versions 01/68201/1
Gary Wu [Thu, 20 Sep 2018 16:35:08 +0000 (09:35 -0700)]
Standardize 3rd party library versions

Use applicable 3rd party library versions
from oparent.  Includes upgrade to oparent 1.2.1.

Change-Id: I04941105fc659a1829018da26d59ba56ad08ad42
Issue-ID: INT-656
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
5 years agoActivity for Flow Completion Status 51/68151/1
Elena Kuleshov [Thu, 20 Sep 2018 15:12:01 +0000 (11:12 -0400)]
Activity for Flow Completion Status

Add a JUnit for existing workflow exception
Changes to base test to include flowCompletionTasks
Workflow Designer - implementation of Completion Activity

Change-Id: Id80a92f97603c10a40ef401522a05a52d976247e
Issue-ID: SO-843
Signed-off-by: Elena Kuleshov <EK1439@att.com>
5 years agoUpdate Logging 45/68145/1
Smokowski, Steve (ss835w) [Thu, 20 Sep 2018 15:04:00 +0000 (11:04 -0400)]
Update Logging

Update logging to meet Casablanca Spec

Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484
Issue-ID: SO-947
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
5 years agoMerge "Addition of Dockerfile/logback for SO-Monitoring"
Seshu Kumar M [Thu, 20 Sep 2018 12:59:15 +0000 (12:59 +0000)]
Merge "Addition of Dockerfile/logback for SO-Monitoring"

5 years agoMerge "Add junit tests for ConfirmVolumeGroupName"
Rob Daugherty [Thu, 20 Sep 2018 12:19:52 +0000 (12:19 +0000)]
Merge "Add junit tests for ConfirmVolumeGroupName"

5 years agoMerge "Update release notes for temp release."
Byung-Woo Jun [Thu, 20 Sep 2018 11:29:01 +0000 (11:29 +0000)]
Merge "Update release notes for temp release."

5 years agoAdd junit tests for ConfirmVolumeGroupName 45/68045/1
Lukasz Muszkieta [Thu, 20 Sep 2018 10:21:59 +0000 (12:21 +0200)]
Add junit tests for ConfirmVolumeGroupName

Change-Id: I382bf9599dfee3a30c129c121d91fddeec42937f
Issue-ID: SO-784
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoMerge "get e2e service process response bug fix"
Seshu Kumar M [Thu, 20 Sep 2018 10:19:43 +0000 (10:19 +0000)]
Merge "get e2e service process response bug fix"

5 years agoMerge "bug fix for ccvpn uc after integration test"
Seshu Kumar M [Thu, 20 Sep 2018 10:19:36 +0000 (10:19 +0000)]
Merge "bug fix for ccvpn uc after integration test"

5 years agoMerge "Move h2 dependency configration to so top pom"
Seshu Kumar M [Thu, 20 Sep 2018 08:52:32 +0000 (08:52 +0000)]
Merge "Move h2 dependency configration to so top pom"

5 years agoUpdate release notes for temp release. 09/68009/1
seshukm [Thu, 20 Sep 2018 07:45:06 +0000 (15:45 +0800)]
Update release notes for temp release.

Change-Id: I526efa36cdc29d3d6cd7c48c695d8adfbe218044
Issue-ID: SO-1077
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "Added fix for potential nullpointerexception"
Seshu Kumar M [Thu, 20 Sep 2018 06:21:27 +0000 (06:21 +0000)]
Merge "Added fix for potential nullpointerexception"

5 years agoget e2e service process response bug fix 79/67979/1
Yulian Han [Thu, 20 Sep 2018 03:50:07 +0000 (11:50 +0800)]
get e2e service process response bug fix

Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa70000021
Issue-ID: SO-683
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
5 years agoMove h2 dependency configration to so top pom 75/67975/1
Siva.ye [Thu, 20 Sep 2018 03:28:20 +0000 (03:28 +0000)]
Move h2 dependency configration to so top pom

Change-Id: Idaa55084f5ecb0dd3536c232cebc14fb50000008
Issue-ID: SO-1075
Signed-off-by: Siva.ye <yezhihua@huawei.com>
5 years agobug fix for ccvpn uc after integration test 73/67973/1
Yulian Han [Thu, 20 Sep 2018 03:30:15 +0000 (11:30 +0800)]
bug fix for ccvpn uc after integration test

Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa70000020
Issue-ID: SO-683
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
5 years agoMerge "Workflow Activities Execution Environment"
Rob Daugherty [Wed, 19 Sep 2018 23:50:23 +0000 (23:50 +0000)]
Merge "Workflow Activities Execution Environment"

5 years agoMerge "Workflow Designer Activities Implementation"
Rob Daugherty [Wed, 19 Sep 2018 23:50:13 +0000 (23:50 +0000)]
Merge "Workflow Designer Activities Implementation"

5 years agoMerge "Deployment script for Activities"
Rob Daugherty [Wed, 19 Sep 2018 23:49:52 +0000 (23:49 +0000)]
Merge "Deployment script for Activities"

5 years agoAdd Java OofClient 81/67581/4
Marcus G K Williams [Thu, 30 Aug 2018 18:44:56 +0000 (11:44 -0700)]
Add Java OofClient

Issue-ID: SO-745
Change-Id: I8c49c573b18d4b7a9e93f7627dc3d1a1e6e71432
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
5 years agoMerge "Removed unused import in CXFConfiguration"
Rob Daugherty [Wed, 19 Sep 2018 20:03:06 +0000 (20:03 +0000)]
Merge "Removed unused import in CXFConfiguration"

5 years agoWorkflow Activities Execution Environment 27/67827/2
Elena Kuleshov [Wed, 19 Sep 2018 18:03:47 +0000 (14:03 -0400)]
Workflow Activities Execution Environment

Add a license header to ExecuteActivity.java
Fix a JUnit by modifying the values for the expected variables.
BBInput changes to support CM flows
Implement JavaDelegate for activities execution

Change-Id: I9cfc51241d414b85441d1a8443a950b97d14b65f
Issue-ID: SO-827
Signed-off-by: Elena Kuleshov <EK1439@att.com>
5 years agoDeployment script for Activities 29/67829/1
Elena Kuleshov [Wed, 19 Sep 2018 18:07:11 +0000 (14:07 -0400)]
Deployment script for Activities

Deployment script for activities to WorkflowDesigner and activities
specs.

Change-Id: I7474805ccf5c8ab0e0a7a43b785de02a29649e2e
Issue-ID: SO-840
Signed-off-by: Elena Kuleshov <EK1439@att.com>
5 years agoWorkflow Designer Activities Implementation 17/67817/1
Elena Kuleshov [Wed, 19 Sep 2018 17:41:20 +0000 (13:41 -0400)]
Workflow Designer Activities Implementation

Logging changes and error message fixes for runAppcCommand()
added unit test and removed catch blocks
Workflow Designer Activities Implementation

Change-Id: I22d3d95541708ddc9e2617a92085b0d4c16caad9
Issue-ID: SO-829
Signed-off-by: Elena Kuleshov <EK1439@att.com>
5 years agoMerge "Add homing to CreateGenericALaCarteService flow"
Marcus Williams [Wed, 19 Sep 2018 14:18:09 +0000 (14:18 +0000)]
Merge "Add homing to CreateGenericALaCarteService flow"

5 years agoRemoved unused import in CXFConfiguration 29/67729/2
ezhil [Wed, 19 Sep 2018 13:48:55 +0000 (19:18 +0530)]
Removed unused import in CXFConfiguration

Removed logger import

Issue-ID: SO-1030
Change-Id: Ifd890e7319f963a3958b5d42c0e4505eacd2eb43
Signed-off-by: ezhil <ezhrajam@in.ibm.com>
5 years agoAddition of Dockerfile/logback for SO-Monitoring 39/66939/2
root [Mon, 17 Sep 2018 09:28:05 +0000 (10:28 +0100)]
Addition of Dockerfile/logback for SO-Monitoring

Creating and adding the files required to include
SO-Monitoring's docker image in the full SO build.

Change-Id: I72cec6f51b8935f39757415eea7d8b961b8c8cd6
Issue-ID: SO-855
Signed-off-by: rope252 <gareth.roper@ericsson.com>
5 years agofix the interface path 71/67671/2
seshukm [Wed, 19 Sep 2018 10:37:22 +0000 (18:37 +0800)]
fix the interface path

Change-Id: Iba07a1b11853177697f32ac14cef912b9691bfd9
Issue-ID: SO-1067
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoMerge "Update bpmn and groovy files for ccvpn usecase"
Seshu Kumar M [Wed, 19 Sep 2018 07:46:59 +0000 (07:46 +0000)]
Merge "Update bpmn and groovy files for ccvpn usecase"

5 years agoUpdate bpmn and groovy files for ccvpn usecase 21/67621/1
subhash kumar singh [Wed, 19 Sep 2018 06:57:51 +0000 (12:27 +0530)]
Update bpmn and groovy files for ccvpn usecase

Update bpmn and groovy files for ccvpn usecase.

Change-Id: Ib992d3577c9805b0d5e09afc2d8a6be6ded5b7b3
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Issue-ID: SO-689

5 years agoUpdate 3rd components to secure version 77/67577/1
Siva.ye [Wed, 19 Sep 2018 03:35:56 +0000 (11:35 +0800)]
Update 3rd components to secure version

Change-Id: Idaa55084f5ecb0dd3536c232cebc14fb50000007
Issue-ID: SO-1013
Signed-off-by: Siva.ye <yezhihua@huawei.com>
5 years agoUpgrade to openstack libs version 1.3.0 17/67417/1
Rob Daugherty [Tue, 18 Sep 2018 18:06:51 +0000 (14:06 -0400)]
Upgrade to openstack libs version 1.3.0

Version 1.3.0 uses fasterxml.jackson.

Note: several unit tests were wrong and had to be fixed. They were
using a fasterxml ObjectMapper to deserialize openstack library
class objects compiled with codehaus JsonProperty annotations.
Consequently, the ObjectMapper could not "see" the annotations.
The tests "worked" because the json was constructed wrongly to
match. I have now fixed the json so that they have the true
property names defined by the annotations.

Change-Id: I088137ee5dd5af9cffd426610a50ae6408c5b190
Issue-ID: SO-1025
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoadded test case to ResponseHandlerTest.java 69/66969/4
Sandeep J [Mon, 17 Sep 2018 11:24:52 +0000 (16:54 +0530)]
added test case to ResponseHandlerTest.java

to increase code coverage

Issue-ID: SO-153
Change-Id: I0829b1c49756eb5f30a618d3ef7d22dbb242126d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdd homing to CreateGenericALaCarteService flow 23/65323/6
Srivahni Chivukula [Tue, 18 Sep 2018 15:32:49 +0000 (08:32 -0700)]
Add homing to CreateGenericALaCarteService flow

Created HomingBB.bpmn in so-bpmn-building-blocks
and updated AssignVnfBB to use HomingBB.bpmn.
HomingBB.bpmn is made capable of using Sniro/OOF

Issue-ID: SO-927
Change-Id: I19c8ada96485f563c2756a22ad3bee4c9367953b
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Signed-off-by: Srivahni Chivukula <srivahni.chivukula@intel.com>
5 years agoMerge "fixed sonar issue in MsoNetworkAdapterAsyncImpl"
Seshu Kumar M [Tue, 18 Sep 2018 14:16:49 +0000 (14:16 +0000)]
Merge "fixed sonar issue in MsoNetworkAdapterAsyncImpl"

5 years agoNexusIQ issue: commons-beanutils 93/67293/1
Rob Daugherty [Tue, 18 Sep 2018 12:53:11 +0000 (08:53 -0400)]
NexusIQ issue: commons-beanutils

This artifact is not actually used by SO.
Removed it from the poms.

Change-Id: Icfeb3026581996bc980a223232a305c488a01fb2
Issue-ID: SO-1065
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoMerge "junits for HttpClientRedirectStrategy"
Seshu Kumar M [Tue, 18 Sep 2018 12:32:42 +0000 (12:32 +0000)]
Merge "junits for HttpClientRedirectStrategy"

5 years agoMerge "added test case to CamundaClientTest.java"
Seshu Kumar M [Tue, 18 Sep 2018 12:31:29 +0000 (12:31 +0000)]
Merge "added test case to CamundaClientTest.java"

5 years agoMerge "Fix issues with load spinner and stats"
Seshu Kumar M [Tue, 18 Sep 2018 11:35:27 +0000 (11:35 +0000)]
Merge "Fix issues with load spinner and stats"

5 years agoFix issues with load spinner and stats 11/67011/2
Ronan Kenny [Mon, 17 Sep 2018 14:11:43 +0000 (15:11 +0100)]
Fix issues with load spinner and stats

Fixing issues where stats returned Nan and
implementation of loading spinner

Change-Id: I989efb739ed244de3760476ce2dfff8928f51c86
Issue-ID: SO-727
Signed-off-by: Ronan Kenny <ronan.kenny@ericsson.com>
5 years agojunits for HttpClientRedirectStrategy 11/67211/1
Tomasz Gwozdecki [Tue, 18 Sep 2018 07:33:10 +0000 (03:33 -0400)]
junits for HttpClientRedirectStrategy

-Added new tests for HttpClientRedirectStrategy
-Tests for method getRedirect

Change-Id: Ica45eac1cbf65170b5b9c84f002b05884c36f5a0
Issue-ID: SO-814
Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
5 years agoMerge "Added log in case of exception in servicepluginfac"
Seshu Kumar M [Tue, 18 Sep 2018 07:25:20 +0000 (07:25 +0000)]
Merge "Added log in case of exception in servicepluginfac"

5 years agoMerge "conflict process"
Seshu Kumar M [Tue, 18 Sep 2018 06:18:38 +0000 (06:18 +0000)]
Merge "conflict process"

5 years agoMerge "save csar file path add directory version"
Seshu Kumar M [Tue, 18 Sep 2018 06:18:31 +0000 (06:18 +0000)]
Merge "save csar file path add directory version"

5 years agoMerge "NetworkAdapterRest.java: Fixed sonar issues"
Seshu Kumar M [Tue, 18 Sep 2018 05:56:27 +0000 (05:56 +0000)]
Merge "NetworkAdapterRest.java: Fixed sonar issues"

5 years agoMerge "Fix to use common MsoLogger"
Seshu Kumar M [Tue, 18 Sep 2018 05:53:19 +0000 (05:53 +0000)]
Merge "Fix to use common MsoLogger"

5 years agoNexusIQ Issue: org.codehaus.groovy 25/67125/2
Rob Daugherty [Mon, 17 Sep 2018 20:54:18 +0000 (16:54 -0400)]
NexusIQ Issue: org.codehaus.groovy

Upgrade from version 2.4.7 to 2.4.8

Change-Id: Ieff55648420b03151d0d5534ef9f64b82145c26f
Issue-ID: SO-1064
Signed-off-by: Rob Daugherty <rd472p@att.com>
5 years agoFix Parse Version 79/67079/1
Smokowski, Steve (ss835w) [Mon, 17 Sep 2018 19:04:13 +0000 (15:04 -0400)]
Fix Parse Version

Issue-ID: SO-1063

Change-Id: I6d627915297f9be0a383516df363d3adec8fc083
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
5 years agoMerge "more stability fixes"
Marcus Williams [Mon, 17 Sep 2018 19:01:22 +0000 (19:01 +0000)]
Merge "more stability fixes"

5 years agomore stability fixes 43/67043/1
Benjamin, Max (mb388a) [Mon, 17 Sep 2018 15:14:35 +0000 (11:14 -0400)]
more stability fixes

Remove conditional to not check VNF topology
add empty string verification for serviceName field
Add junits for CNRCR and NtwkAdptr changes.
Add search in new CollNtwkResCust tbl to get NtwkResource.
-  Updated test data files to include 'pre-load' flag in both
VfModuleOperation and NetworkOperation json test data files.
-  MSO to not to send <preload>boolean</from-preload> to SDNC in
network-topology-opertion and vf-module-topology-operation. Updated
GeneralTopologyObjectMapper to set 'from-preload' to null so that
elements with Nulls are not sent to SDNC. Updated
buildNetworkInformation() and buildVfModuleInformation() methods.
update flow stats to not cause bpmn flow to crash
Fix headers so SDNC does not return XML
Add implementation of deleteVolumeGroupResponse parsing; fix JUnits
that worked by accident.

Change-Id: Ia96d552d731e112505fcf739029a6fd4d0134546
Issue-ID: SO-1061
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "add single transaction api to aaiclient"
Rob Daugherty [Mon, 17 Sep 2018 16:01:21 +0000 (16:01 +0000)]
Merge "add single transaction api to aaiclient"

5 years agoMerge "Updated error handling of BPMN sub flows"
Rob Daugherty [Mon, 17 Sep 2018 16:00:08 +0000 (16:00 +0000)]
Merge "Updated error handling of BPMN sub flows"

5 years agoMerge "Accept header not honored when building exception"
Rob Daugherty [Mon, 17 Sep 2018 15:59:12 +0000 (15:59 +0000)]
Merge "Accept header not honored when building exception"

5 years agoMerge "Accept VNF Recreate Requests"
Rob Daugherty [Mon, 17 Sep 2018 15:55:24 +0000 (15:55 +0000)]
Merge "Accept VNF Recreate Requests"

5 years agoFix to use common MsoLogger 33/67033/2
Byung-Woo Jun [Mon, 17 Sep 2018 15:11:52 +0000 (11:11 -0400)]
Fix to use common MsoLogger

Used the MsoLogger instead of using a separate logger

Change-Id: I62f8f8ef64a6f56eadf65829c3bf9521d651fbbb
Issue-ID: SO-1062
Signed-off-by: byungwoojun<byung-woo.jun@ericsson.com>
5 years agoadd single transaction api to aaiclient 29/67029/1
Benjamin, Max (mb388a) [Mon, 17 Sep 2018 14:52:09 +0000 (10:52 -0400)]
add single transaction api to aaiclient

fixed marshalling when issuing a patch request
added support for single transaction api in A&AI

Change-Id: Icf755f547523cc7dbf931e198177847a5a1c6ea1
Issue-ID: SO-1060
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix SDNC Parse 23/67023/1
Smokowski, Steve (ss835w) [Mon, 17 Sep 2018 14:37:20 +0000 (10:37 -0400)]
Fix SDNC Parse

Fix to use proper wrapper bean to fix marshalling

Change-Id: Iec167059557cbf73236f3efad9a9780571a0468e
Issue-ID: SO-1056
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
5 years agoUpdated error handling of BPMN sub flows 17/67017/1
Benjamin, Max (mb388a) [Mon, 17 Sep 2018 14:24:34 +0000 (10:24 -0400)]
Updated error handling of BPMN sub flows

Added error handling subprocess to only those BBs that call a sub flow.
 Refactored error handling in ExecuteBuildingBlock.
Added error handling and enhanced modeling of remaing BB flows
Added error handling and enhanced modeling of assign/activate BBs.

Change-Id: I2ab6236e3c2206b74b6368db69d8953a779f4f19
Issue-ID: SO-1059
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoNetworkAdapterRest.java: Fixed sonar issues 33/66933/2
Arundathi Patil [Mon, 17 Sep 2018 09:30:01 +0000 (15:00 +0530)]
NetworkAdapterRest.java: Fixed sonar issues

Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-openstack-adapters%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fnetwork%2FNetworkAdapterRest.java
Issue-ID: SO-1049
Change-Id: I4256f09b0d89714eb2214215e7a2a2f1f1644a8b
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoAccept header not honored when building exception 15/67015/1
Benjamin, Max (mb388a) [Mon, 17 Sep 2018 13:47:02 +0000 (09:47 -0400)]
Accept header not honored when building exception

added accept headers to http entity request
mappers were looking at "Content-Type" and not "Accept"
modified test to no longer share global headers
added additional tests and corrected comparison errors
Fixing issue with comparing media types, the equals method in
MediaType.class uses parameters as well to compare, added a method to
just compare the type and subtype and get done with it
Fixing test failures, getMEdiaType would come as null in most cases,
this causes the defautl serialization mode to be picked which is xml.
tests now pass with exception providers in place
exception providers now handle JSON and XML
Dumy push to re-trigger the build which failed at sonar evaluation
Trying to fix the build by removing different spy's
Returning XML instead of JSON in cases of error for
endpoints. Removed exceptions and its generic handler which is a good
thought, however given that the exceptionhandlers are generic it gets
tough to return to handle exceptions which require different namesaces
in response amongst other problems.

Change-Id: I684fe3b0047693093a99aa999faf261d7713f404
Issue-ID: SO-1058
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAccept VNF Recreate Requests 03/67003/1
Benjamin, Max (mb388a) [Mon, 17 Sep 2018 13:37:20 +0000 (09:37 -0400)]
Accept VNF Recreate Requests

Updated nfRole in sample catdb json response
Added gr-api-default recipe for recreate
Updated description in catdb response json
Updated catdb response file to have the correct action
Added action to common package
Removed requestor ids and source from test requests
Began adding recreate endpoint and tests
Began adding validation for recreate and junit tests

Change-Id: I60c588be104b82b2d0dfb8587069e04f7b4710be
Issue-ID: SO-1057
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoDeploymentInfo tests and construction improvement 97/66997/1
Michal Kabaj [Mon, 17 Sep 2018 13:10:43 +0000 (15:10 +0200)]
DeploymentInfo tests and construction improvement

- Improved construction by adding DeploymentInfoBuilder
- DeploymentInfo immutable
- added detailed unit tests

Change-Id: I3dabb91d5190ef932e77f0c76e18fde8ca73c64d
Issue-ID: SO-1055
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
5 years agoadded test case to CamundaClientTest.java 57/66957/1
Sandeep J [Mon, 17 Sep 2018 10:45:52 +0000 (16:15 +0530)]
added test case to CamundaClientTest.java

to increase code coverage

Issue-ID: SO-1053
Change-Id: I34f287041f5f09cf0c37a0c9babe9719a6d5ce97
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in MsoNetworkAdapterAsyncImpl 37/66937/1
Sandeep J [Mon, 17 Sep 2018 09:36:06 +0000 (15:06 +0530)]
fixed sonar issue in MsoNetworkAdapterAsyncImpl

fixed sonar issue as detailed in SO-1050

Issue-ID: SO-1050
Change-Id: Ia93775d855c04bb5b955d17c002c55f619198298
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMerge "fix sonar isue in openstack adapters ObjectFactory"
Byung-Woo Jun [Sun, 16 Sep 2018 22:17:41 +0000 (22:17 +0000)]
Merge "fix sonar isue in openstack adapters ObjectFactory"

5 years agoMerge "fix sonar issue in ValetClient.java"
Byung-Woo Jun [Sun, 16 Sep 2018 22:16:36 +0000 (22:16 +0000)]
Merge "fix sonar issue in ValetClient.java"

5 years agoMerge "fixed sonar issue in MSORequestDBApplication.java"
Byung-Woo Jun [Sun, 16 Sep 2018 22:15:29 +0000 (22:15 +0000)]
Merge "fixed sonar issue in MSORequestDBApplication.java"

5 years agoMerge "fixed sonar issue in ObjectFactory.java"
Byung-Woo Jun [Sun, 16 Sep 2018 22:14:38 +0000 (22:14 +0000)]
Merge "fixed sonar issue in ObjectFactory.java"

5 years agofix sonar isue in openstack adapters ObjectFactory 27/66827/1
Sandeep J [Sun, 16 Sep 2018 10:59:31 +0000 (16:29 +0530)]
fix sonar isue in openstack adapters ObjectFactory

fixed sonar issue as detailed in SO-1046

Issue-ID: SO-1046
Change-Id: I4064b7d7729f15afbfa07752cf5cc54e9847e861
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofix sonar issue in ValetClient.java 25/66825/1
Sandeep J [Sun, 16 Sep 2018 10:48:41 +0000 (16:18 +0530)]
fix sonar issue in ValetClient.java

fixed sonar issue as detailed in SO-1045

Issue-ID: SO-145
Change-Id: I754a6699ea1be798cf68c08c6e5900007bf6350b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in MSORequestDBApplication.java 23/66823/1
Sandeep J [Sun, 16 Sep 2018 10:39:40 +0000 (16:09 +0530)]
fixed sonar issue in MSORequestDBApplication.java

fixed sonar issue as detailed in SO-1044

Issue-ID: SO-144
Change-Id: I08bfe045eda953e23c9fa54ea159cd6c915705bd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in ObjectFactory.java 21/66821/1
Sandeep J [Sun, 16 Sep 2018 10:35:04 +0000 (16:05 +0530)]
fixed sonar issue in ObjectFactory.java

fixed sonar issue as detailed in SO-1043

Issue-ID: SO-1043
Change-Id: I529c1e8951b286c6f18d60aa810942d8db94df21
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed sonar issue in NetworkAdapterNotify_Service 19/66819/1
Sandeep J [Sun, 16 Sep 2018 10:26:37 +0000 (15:56 +0530)]
fixed sonar issue in NetworkAdapterNotify_Service

fixed sonae issue as detailed in SO-1042

Issue-ID: SO-1042
Change-Id: Iadb765acc0acd94c65281e212eed54d28e98ea91
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoObjectFactory.java: Fixed sonar issues 99/66599/1
Arundathi Patil [Fri, 14 Sep 2018 10:02:54 +0000 (15:32 +0530)]
ObjectFactory.java: Fixed sonar issues

Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-openstack-adapters%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fnetwork%2Fasync%2Fclient%2FObjectFactory.java

Issue-ID: SO-1038
Change-Id: I88c7c76d266afabcbbe1ea26772b601a0238cde1
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
5 years agoMerge "Removed printstacktrace from exception block"
Seshu Kumar M [Fri, 14 Sep 2018 08:56:03 +0000 (08:56 +0000)]
Merge "Removed printstacktrace from exception block"

5 years agoMerge "simplified vCPE PNF workflow"
Seshu Kumar M [Fri, 14 Sep 2018 08:38:53 +0000 (08:38 +0000)]
Merge "simplified vCPE PNF workflow"

5 years agoMerge "Remove unused import"
Chuanyu Chen [Fri, 14 Sep 2018 07:22:02 +0000 (07:22 +0000)]
Merge "Remove unused import"

5 years agoStability fixes 33/66233/2
Benjamin, Max (mb388a) [Wed, 12 Sep 2018 20:55:02 +0000 (16:55 -0400)]
Stability fixes

sdnc now logs the full response message as a json
removed erroneous encoding of variables with full XML
Return created network from getVirtualLinkL3Network
added exception logger to workflowaction aai check
Check for null value for vnfcPorts before referencing it
Added test case for invalid camunda response
Changed to use updateStatus method
Added saving for currentActiveReq and test for 401 resp
Change JUnit to use expectedException and clean up unused items.
Add vfModuleId to the exception message for missing model info.
Report an error if VF Module model info is expected but is null.
- Just renamed the Cvnfc and Vnfc set names
- Updated code to check for duplicate VNFC's across multiple modules in
the same VNF.
- Removed commented out if statement line for ALLOTTED_RESOURCE
- Reinitialize the Cvnfc and Vnfc Sets each time we iterate the
VFModule loop.  This will avoid the concurrent modification exception.
Eliminated Ben from the sample request
Changed to use else if for null check
Added null check before catdb call and test case
Fix implementation of a call to VNF Adapter for DeleteVolumeGroupBB.
Update the method to no call save and do a put
Revert usage of PUT method, use save instead

Change-Id: I9f69fb68d0639c23b8e1de6931938119bd3ac54b
Issue-ID: SO-1032
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>