kissand [Thu, 2 Jun 2022 14:26:23 +0000 (16:26 +0200)]
Handle errors during cm handle search
Issue-ID: CPS-1067
Change-Id: Iadc3413a29f9a455e658ec5bcaffc4881b7f7684
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Thu, 9 Jun 2022 13:05:54 +0000 (13:05 +0000)]
Merge "Fix sonar code smells"
ToineSiebelink [Wed, 8 Jun 2022 11:04:48 +0000 (12:04 +0100)]
Remove Model Sync From Registration
Decouple the model sync from registration process
Sync now only happens during the watchdog process
Cm Handles are persisted in state ADVISED when
registartion is successful
Issue-ID: CPS-876
Change-Id: Ia3353a0ab1c65a9db553e09138d5690d4f915727
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
sourabh_sourabh [Thu, 9 Jun 2022 10:34:31 +0000 (11:34 +0100)]
Override timers advised-modules-sync sleep-time-ms
- Override timers advised-modules-sync sleep-time-ms from docker compose
for CSIT test
Issue-ID: CPS-876
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I2cbc76c03cd5907e2d3bf28b38dbf8209eaaddbd
emaclee [Tue, 7 Jun 2022 17:32:29 +0000 (18:32 +0100)]
Fix sonar code smells
- Remove useless curly braces around statement
(https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYD_5_HLFWip2-KRhcLs)
- Define a constant
(https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYEj9y6sq272EuFEMiu-)
Issue-ID: CPS-475
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ib430fac481b29dba8725ed0dac4da3daa56a3984
Toine Siebelink [Thu, 9 Jun 2022 08:57:56 +0000 (08:57 +0000)]
Merge "Ncmp Producer Setup"
Toine Siebelink [Wed, 8 Jun 2022 10:03:11 +0000 (10:03 +0000)]
Merge "Merge 2 'query' end points in NCMP"
kissand [Thu, 12 May 2022 13:59:18 +0000 (15:59 +0200)]
Merge 2 'query' end points in NCMP
- merge two endpoint for a same backend
- use xPath query instead of sql query
- modify searches endpoint to return a cmHandle object with all public
properties
- handle old (deprecated) queries
- handle public property queries
- create useful examples
- use more verbose error messages
- simplify openapi yamls
- create new query service
- change second endpoint name to a better matched name
- modify legacy tests with new requirements
- create new tests for the new scenarios
Issue-ID: CPS-1016
Change-Id: I7476e9dbd510ec93b5b48ce85d477ecb2dadffff
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
mpriyank [Thu, 2 Jun 2022 10:27:55 +0000 (11:27 +0100)]
Ncmp Producer Setup
- Ncmp Kafka Publisher setup
- Test scenarios
- Refactored existing test class which were using kafka producer and
consumer properties to use from common MessageSpec
- Upcoming : Implementation Proposal and Actual logic to publish the
correct event
Issue-ID: CPS-1035
Change-Id: I93ae392e8c4e4c85d88ca7858332e79b59e85535
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
puthuparambil.aditya [Thu, 12 May 2022 15:31:00 +0000 (16:31 +0100)]
PoC Contract Stubs NCMP Rest Endpoints
Stubs defined for cmHandleSearch and passthrough operational
Issue-ID: CPS-919
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I4fd7bee8fa70ed237f74c721068ffa39817d5c7a
Toine Siebelink [Fri, 3 Jun 2022 08:11:25 +0000 (08:11 +0000)]
Merge "CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle registration"
sourabh_sourabh [Thu, 2 Jun 2022 12:54:09 +0000 (13:54 +0100)]
CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle registration
- @EnableRetry is added into application.
- Added retry count into log to add more information about retry.
Issue-ID: CPS-1020
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I00c58ef17a8c066f98711c1cf8e5e5cb5f22974b
Toine Siebelink [Thu, 2 Jun 2022 11:30:34 +0000 (11:30 +0000)]
Merge "Add module name to cps core output"
Toine Siebelink [Thu, 2 Jun 2022 09:05:44 +0000 (09:05 +0000)]
Merge "NcmpEvent creation for ModuleSync"
emaclee [Tue, 24 May 2022 10:51:19 +0000 (11:51 +0100)]
Add module name to cps core output
- add withModuleName method
- add getNodeIdentifierWithPrefix method
- add unit test in DataMapUtilsSpec
- add unit test in DataNodeBuilderSpec
- fix all existing unit tests
Issue-ID: CPS-870
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I51b70fa2dd3381eef9500b4339d4922c017e3000
mpriyank [Wed, 25 May 2022 11:25:48 +0000 (12:25 +0100)]
NcmpEvent creation for ModuleSync
- NcmpEvent schema creation which will be published when module sync is
completed
- Added cmHandleId in the event payload and made eventCorrelationId as
optional
- Upcoming : NcmpEvent publisher code and mapping of the events
Issue-ID: CPS-1036
Change-Id: I7731e6e6a4a8f718967ce68cc6ae0e411eb8c12b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Toine Siebelink [Wed, 1 Jun 2022 14:39:39 +0000 (14:39 +0000)]
Merge "Module Sync Lock State implementation"
DylanB95EST [Thu, 19 May 2022 13:09:58 +0000 (14:09 +0100)]
Module Sync Lock State implementation
Implementation of Lock state for module sync watchdog
Cm Handle state is locked if any exception is found
during sync process
Make changes around READY state method in line with the
new schema set
Add last updated time to composite state
Remove running datastore references as this is being done
at a later time
Issue-ID: CPS-875
Change-Id: I6bd159faefef2fa84dbf536c292ff0a132793381
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Wed, 1 Jun 2022 13:19:14 +0000 (13:19 +0000)]
Merge "DMI-NCMP Asynchronously Publish Response Event to Client Topic"
mpriyank [Thu, 26 May 2022 19:25:40 +0000 (20:25 +0100)]
Fixing CompositeState mapping
- Mapper null check
- NcmpServiceCmHandle mapping for the new composite state
- Added global parameter for jackson to include only NON_NULL attributes
in the response
Issue-ID: CPS-1066
Change-Id: I1924fef45345c77873f9c788baa701311e72bea7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
sourabh_sourabh [Mon, 30 May 2022 12:20:47 +0000 (13:20 +0100)]
DMI-NCMP Asynchronously Publish Response Event to Client Topic
- [NCMP] Added Unit Tests for NcmpAsyncRequestResponseEventMapper.java
Issue-ID: CPS-830
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I64dad7f0bb9b64e1864f19db5a5d74922dc6a83b
Joseph Keenan [Wed, 1 Jun 2022 08:41:24 +0000 (08:41 +0000)]
Merge "Handle RestTemplate Error handling so NCMP cna report correct server status"
ToineSiebelink [Fri, 27 May 2022 09:58:52 +0000 (10:58 +0100)]
Handle RestTemplate Error handling so NCMP cna report correct server status
- Moved resposne handling to DmRestClient
- Clean up incorrect/redundant tests in CmProxyDataServiceImplSpec
Issue-ID: CPS-1056
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I78ba87d6af7255d85758893cfef237d75227875a
Joseph Keenan [Thu, 26 May 2022 10:37:28 +0000 (10:37 +0000)]
Merge "CompositeStateBuilder added for building the compositeState"
puthuparambil.aditya [Wed, 25 May 2022 14:29:59 +0000 (15:29 +0100)]
CompositeStateBuilder added for building the compositeState
Added composite state to YangModelCmHandleRetriever
Issue-ID: CPS-878
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I8bdea55c0a8e27a906e24fc367dedf81c9b3501c
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
JosephKeenan [Tue, 24 May 2022 17:59:25 +0000 (18:59 +0100)]
Async request response NCMP -> Client
-Added consumer for DMI events and producer for forwarding to client
-Added schemas for events
-Updated tests
-Added new module for ncmp events
-Used mapstruct for event mapping
Issue-ID: CPS-830
Change-Id: I096d08af9d69092cf8651e11eaa00ce441fc3605
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
mpriyank [Fri, 20 May 2022 14:25:15 +0000 (15:25 +0100)]
Enhanced response with Complex State in API
- Introduced RestOutputCmHandleState in API specs of
retrieveCmHandleDetailsById
- Mapper to map CompositeState to RestOutputCmHandleState
- Enhanced existing test cases and introduced new one to test the
mapping result
Issue-ID: CPS-1047
Change-Id: I34fa198287e5d920bc0cea312ee4e368f3be2b90
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Toine Siebelink [Fri, 20 May 2022 15:57:00 +0000 (15:57 +0000)]
Merge "Get cm-handle public properties endpoint"
lukegleeson [Fri, 6 May 2022 11:02:42 +0000 (12:02 +0100)]
Get cm-handle public properties endpoint
Added RestOuputCmHandlePublicProperties OpenApi Object
Added Get cm-handle public properties endpoint
Added rest and service layer functionality for endpoint with tests
Fixed Copyright Checker violations
Issue-ID: CPS-1018
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ifc13cde350a49f6ba705a09e31853dc9c73be168
Joseph Keenan [Fri, 20 May 2022 08:40:21 +0000 (08:40 +0000)]
Merge "URI is not absolute when service name is not set"
Toine Siebelink [Thu, 19 May 2022 13:28:02 +0000 (13:28 +0000)]
Merge "Composite State to handle dmi-reg YANG updates"
mpriyank [Mon, 16 May 2022 16:14:25 +0000 (17:14 +0100)]
Composite State to handle dmi-reg YANG updates
- Introduce CompositeState object which handles change in updated YANG for dmi-registry
- Used Builder pattern as some of the fields are optional
- Removed the abstract ready method from CmHandleState which was used as
state machine
- Fixed few test cases
Issue-ID: CPS-1042
Change-Id: I8aaf6f819c66b3a9d30c5e8f0a0007f9528b247f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
DylanB95EST [Thu, 19 May 2022 10:00:18 +0000 (11:00 +0100)]
URI is not absolute when service name is not set
BUG - URI is not absolute exception when dmi-service-name
is not set in the database, due to null String
Has now been set to null value
Issue-ID: CPS-1043
Change-Id: If48c34d8caee302a1849555755960dccfd26ab7a
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
DylanB95EST [Mon, 16 May 2022 09:45:56 +0000 (10:45 +0100)]
Remove NCMP tag from properties
We have decided to remove the NCMP tag from properties
and will add it later as part of our release process for
KOHN.
Issue-ID: CPS-875
Change-Id: I7282c3c11879f2252c8a1b193df17f3f4bb1cf14
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Fri, 13 May 2022 08:03:43 +0000 (08:03 +0000)]
Merge "Watchdog-process that syncs 'ADVISED' CM Handles"
DylanB95EST [Thu, 5 May 2022 10:53:12 +0000 (11:53 +0100)]
Watchdog-process that syncs 'ADVISED' CM Handles
- Sync and Create Schema Set during
module sync watchdog process.
- Add a cm handle state transition machine to handle
state changes for a cm handle during watchdog
which syncs module service.
Issue-ID: CPS-875
Change-Id: I3b178f5693cb7ac30577dd81cdc82b462555389a
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Joseph Keenan [Thu, 12 May 2022 10:45:47 +0000 (10:45 +0000)]
Merge "Add graceful shutdown for Session Manager"
emaclee [Fri, 6 May 2022 09:36:29 +0000 (10:36 +0100)]
Add graceful shutdown for Session Manager
Introduce singleton session manager
Add unit test for session manager
Issue-Id: CPS-898
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Iaf91f1aa6c1ebfe0ab907e7f7d80a01e940a0fdd
Toine Siebelink [Wed, 11 May 2022 15:22:33 +0000 (15:22 +0000)]
Merge "Update DMI Registry yang to support DataStoreSyncState"
Lathish [Tue, 10 May 2022 09:41:05 +0000 (10:41 +0100)]
Update DMI Registry yang to support DataStoreSyncState
- Added dmi-registry@2022-05-10 yang to support DataStoreSyncState
- Added changelog 14 to add the dmi-registry
Issue-ID: CPS-1014
Change-Id: I910d2496a359fdf2441e172ca270036272d31dc6
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
DylanB95EST [Fri, 6 May 2022 09:43:58 +0000 (10:43 +0100)]
Watchdog Process-Make Configurable
Make time configurable for the watchdog process.
Add documentation outlining this.
Issue-ID: CPS-875
Change-Id: I1307c82d02789097efda1ba981eb1fd36c9efc38
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Tue, 10 May 2022 14:29:54 +0000 (14:29 +0000)]
Merge "Add ncmp tag to application yaml"
Toine Siebelink [Tue, 10 May 2022 14:08:37 +0000 (14:08 +0000)]
Merge "Improve Local Running of CSIT Tests"
lukegleeson [Tue, 10 May 2022 12:38:32 +0000 (13:38 +0100)]
Improve Local Running of CSIT Tests
Issue-ID: CPS-734
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iff92f43dc69cdaf3e1e78551f68ecfb08bde4b93
DylanB95EST [Mon, 9 May 2022 16:03:52 +0000 (17:03 +0100)]
Add ncmp tag to application yaml
Add an NCMP tag to Application.yml to store
NCMP related propeties
Issue-ID: CPS-875
Change-Id: I2bce3d765ae69cc2a4bb52a472eea7cae745fd2c
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
sourabh_sourabh [Fri, 6 May 2022 10:31:54 +0000 (11:31 +0100)]
Security Logging Fields
- Made logging.format value case insensitive for consistency as we did same change for cps-temporal, ncmp-dmi-plugin and oom.
Issue-ID: CPS-986
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I085a3777e8f4cf9e6b62e40d05672ce455916a85
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Fri, 22 Apr 2022 21:47:41 +0000 (22:47 +0100)]
Security Logging Fields
- logback core and encoder dependencies are added.
- New appender is added to log JSON format content on console.
Issue-ID: CPS-986
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ia72b27f306019fa259b3d6de4c5399f0ae734076
Joseph Keenan [Tue, 3 May 2022 11:39:31 +0000 (11:39 +0000)]
Merge "Fix sonar code smells"
Joseph Keenan [Tue, 3 May 2022 08:53:36 +0000 (08:53 +0000)]
Merge "Watchdog-process that changes CM Handles state"
kissand [Mon, 2 May 2022 08:42:30 +0000 (10:42 +0200)]
Fix sonar code smells
* Increase code coverage in DataNodeBuilder
Issue-ID: CPS-475
Change-Id: I00a3b1c81911c1ccd3db810eec2f2989946809c5
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Tue, 3 May 2022 08:16:24 +0000 (08:16 +0000)]
Merge "Updated the documentation with limitation of leaf condition"
Toine Siebelink [Fri, 29 Apr 2022 15:33:04 +0000 (15:33 +0000)]
Merge "[STRIMZI] Add strimzi kafka notes"
DylanB95EST [Wed, 20 Apr 2022 09:35:11 +0000 (10:35 +0100)]
Watchdog-process that changes CM Handles state
Add a fixed delay scheduler to switch cm-handles found in an ADVISED
state to a READY state
Scheduler currently runs every 30 seconds
Will only update a single cm-handle at a time
Queries CM-Handle with Advised States Only using CPS Path.
Will choose cm handle at random
Issue-ID: CPS-875
Change-Id: Ie1b49c89a0350d20e14748a65f9c1d260d8502d2
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Fri, 29 Apr 2022 10:45:02 +0000 (10:45 +0000)]
Merge "Fix sonar code smells"
kissand [Thu, 28 Apr 2022 08:20:39 +0000 (10:20 +0200)]
Fix sonar code smells
* Increase code coverage
https://sonarcloud.io/component_measures?metric=uncovered_conditions&id=onap_cps
Issue-ID: CPS-475
Change-Id: I124bad6c01acbcb9658f52eb68079628e074168e
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Lathish [Thu, 28 Apr 2022 15:37:00 +0000 (16:37 +0100)]
Updated the documentation with limitation of leaf condition
Issue-ID: CPS-988
Change-Id: I6d02b35b949c62f956b291a86d4abe6e1a70b3ec
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
emaclee [Mon, 4 Apr 2022 14:38:26 +0000 (15:38 +0100)]
Add methods to Lock Anchor entity
Added separate integration and mock-based unit tests
Issue-ID: CPS-898
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I14d1d1c41759ce028e2417fdd2df001280e19ab2
Toine Siebelink [Tue, 26 Apr 2022 17:10:58 +0000 (17:10 +0000)]
Merge "Fix Absolute Path to list with Integer/String key"
Lathish [Thu, 31 Mar 2022 16:29:22 +0000 (17:29 +0100)]
Fix Absolute Path to list with Integer/String key
- Introduced normalizedXpath to normalize the xpath and cpspath
- Introduced normalizedAncestorpath to normalize the ancestor path in xpath and cpspath
- Added new condition in the ANTLR Grammar to capture the invalid path in the xpath
- Introduced PathParsingException to replace the IllegalStateException
Issue-ID: CPS-961
Change-Id: Ie10f5c6cfc466387e79eec184b933297d1d79587
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Bruno Sakoto [Thu, 21 Apr 2022 22:08:18 +0000 (18:08 -0400)]
Review spring framework dependency
Use default spring framework version from spring boot dependencies.
Then, cps application is now currently using spring-web 5.3.16 (from
spring boot 2.6.4) instead of previously specified 5.3.13.
Issue-ID: CPS-998
Change-Id: If16c5f4c7176a34b5a595a1411d3caa763d3c2f0
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Renu Kumari [Mon, 18 Apr 2022 16:39:33 +0000 (12:39 -0400)]
Document ncmp-inventory error code in openapi
Issue-ID: CPS-896
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: Ic39da86c18ac921a6a3d213064f0b7c77d08e06f
sourabh_sourabh [Wed, 6 Apr 2022 15:24:52 +0000 (16:24 +0100)]
Refactor existing model sync code into separate package
- Created a new class to seperate sync related operations of modules.
- Kept newly created class into .../api/inventory/sync package.
- Created a separate groovy test.
- Fixed existing groovy test.
Issue-ID: CPS-950
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ie7cc36ea75daf43f1383757bcf2057c5cb4894b1
Lathish [Tue, 12 Apr 2022 13:39:02 +0000 (14:39 +0100)]
Fix ANTLR version issue
- Updated ANTLR compiler version to 4.9.2 to be compatible with runtime version
Issue-ID: CPS-961
Change-Id: I78a3fe541c9edcfc891fb045a60ed117d3aa5b08
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Cédric Ollivier [Mon, 11 Apr 2022 13:55:45 +0000 (15:55 +0200)]
Add bounds to sphinx requirement
As ONAP was created before Oct 20 2020 in RTD, we
must set bounds to enforce a compatible Sphinx version
(see manual).
Issue-ID: DOC-782
Signed-off-by: Cédric Ollivier <cedric.ollivier@orange.com>
Change-Id: I5ed268d592986764bf040690a47c5024692768b7
DylanB95EST [Mon, 11 Apr 2022 08:24:59 +0000 (09:24 +0100)]
Fix Sonar Qube Violations
Immediately return expression
Issue-ID: CPS-475
Change-Id: I2c33c94bef1ff097786299d3a037feea2b4ebbff
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
DylanB95EST [Fri, 8 Apr 2022 14:53:50 +0000 (15:53 +0100)]
Fix Sonar Qube Violations - Recurring task
Fix sonar issues in CPS.
- Remove Unnecessary cast to List
- Immediately return expession
Issue-ID: CPS-475
Change-Id: Ic3fa2f3f92784682045a780d87c6737d04f37659
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Joseph Keenan [Fri, 8 Apr 2022 13:18:12 +0000 (13:18 +0000)]
Merge "Refactoring/ Adding Tests for Validation"
DylanB95EST [Mon, 4 Apr 2022 12:09:22 +0000 (13:09 +0100)]
Refactoring/ Adding Tests for Validation
Refactored classes affected by validation
Have added tests for anywhere where validation is used
Have refactored the parse and sync modules validation
to be validated at the public api method
Issue-ID: CPS-322
Change-Id: I4989cfd03300fbdca41571d0aa2d0b96978858ba
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Fri, 8 Apr 2022 07:40:42 +0000 (07:40 +0000)]
Merge "Fix to stop build failure on CopyrightCheck Error"
Toine Siebelink [Fri, 8 Apr 2022 07:37:55 +0000 (07:37 +0000)]
Merge "Update info.yml for new Committer"
JosephKeenan [Thu, 7 Apr 2022 15:06:31 +0000 (16:06 +0100)]
Update info.yml for new Committer
-Updating INFO.yaml to include new committer for CPS (JosephKeenan)
Issue-ID: CPS-985
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: I08ca90749e13a977f83d173f2cd72146753c2370
lukegleeson [Thu, 7 Apr 2022 10:37:39 +0000 (11:37 +0100)]
Fix to stop build failure on CopyrightCheck Error
- This will make the maven build see an error thrown by the python script as a success and won't fail the build
Issue-ID: CPS-911
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ibc5311de8a2f173a92e44c20c1c244f016a99588
Bruno Sakoto [Wed, 6 Apr 2022 18:57:06 +0000 (18:57 +0000)]
Merge "dmi plugin version updated to 1.2.0-SNAPSHOT-latest"
JosephKeenan [Mon, 28 Mar 2022 11:26:07 +0000 (12:26 +0100)]
Query based on Public CM Properties
-Updated OpenAPI for new Endpoint
-Will replace SQL with CPSPathQuery once investigation is complete
-Functionality in place to determine if public properties match -
-Added Unit and CSIT tests - small modifications may need to be made
-CSIT tests enhanced to add additional nodes and tests
Issue-ID: CPS-731
Change-Id: I403e603ce79c4a4a6994d51b459b5703510d5a83
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
puthuparambil.aditya [Wed, 6 Apr 2022 13:44:22 +0000 (14:44 +0100)]
dmi plugin version updated to 1.2.0-SNAPSHOT-latest
CSIT updated to test the changes on Accept header
Issue-ID: CPS-957
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I2fb4abd5dff5ab7b02345ad6b4899987c2553130
sourabh_sourabh [Mon, 28 Mar 2022 12:21:55 +0000 (13:21 +0100)]
Async: NCMP Rest impl. including Request ID generation
- Restructured code and moved some of them at controller and service
layer.
- Unit is fixed and organized to it's belonging classes.
Issue-ID: CPS-828
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I0919218e35b1d11cb579d707f376b76de80409da
puthuparambil.aditya [Tue, 29 Mar 2022 10:03:52 +0000 (11:03 +0100)]
[cps] Fix getResourceDataForPassthroughOperational endpoint
Get endpoint only accepts application/json.
Issue-ID: CPS-957
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: Ifc7426fbcd6073a39554014dc18b2107b6343b16
Bruno Sakoto [Tue, 5 Apr 2022 12:30:00 +0000 (12:30 +0000)]
Merge "Structured Exception details for DMI"
mpriyank [Mon, 28 Mar 2022 10:17:47 +0000 (15:47 +0530)]
Structured Exception details for DMI
- Introduced DmiErrorMessage in API docs with 502 Bad Gateway
- HttpClientRequestException will be thrown which will be exposed as 502 BAD Gateway for the client from NCMP
Issue-ID: CPS-917
Change-Id: Iba8f159e8216bc1f63a9ab86208e5c802437e2e8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Renu Kumari [Mon, 28 Mar 2022 14:22:41 +0000 (10:22 -0400)]
Update CM-Handle registration response
- update openapi.yml with new response structure
- send only details of failed cm-handle operations
- updated csit to validate 200 status
Issue-ID: CPS-896
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I3b868bcc5b8ff488c31faef51edc82c771452234
ToineSiebelink [Fri, 1 Apr 2022 08:00:44 +0000 (09:00 +0100)]
Fix issue around duplicate build tag
Fixes failing build after merge of CPS-322.
Duplicate build tag found in checkstyle POM
Issue-ID: CPS-322
Change-Id: I099e4242e419d7b393e7787d3f75f9909dce52ac
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Toine Siebelink [Thu, 31 Mar 2022 13:08:13 +0000 (13:08 +0000)]
Merge "Additional validation for names/identifiers"
Toine Siebelink [Wed, 30 Mar 2022 13:17:09 +0000 (13:17 +0000)]
Merge "Copyright Check Script"
DylanB95EST [Tue, 8 Mar 2022 17:26:34 +0000 (17:26 +0000)]
Additional validation for names/identifiers
Implementing additional regex validation for names/identifiers
in CPS
- Introduces a CpsValidator
- Applies to relevent java public API's
- Tests have been updated where necessary
Issue-ID: CPS-322
Change-Id: I29ab8820bb1fe0eee247e425d6bb018bcd38f28e
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Mon, 28 Mar 2022 11:03:31 +0000 (11:03 +0000)]
Merge "Updated the Documentation with sample yang and json"
Renu Kumari [Wed, 23 Mar 2022 20:50:14 +0000 (16:50 -0400)]
Registration Response for Create cmhandles operations
- Changed implementation to register each cm-handle at a time
instead of registering all at once
- Removed YangCMHandleList class and using String format to
generated expected JSON
- Response of all three operation types is returned in the
updateDmiRegistrationAndSyncModule method
- Changed parseAndRemoveCmHandlesInDmiRegistration to protected
to keep in sync with create flow
- Refactored existing create CMHandle test cases
Issue-ID: CPS-896
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I5b0c01b3b8e31ca7c257b1e04069e35268be1132
Toine Siebelink [Fri, 25 Mar 2022 18:29:31 +0000 (18:29 +0000)]
Merge "Add Start and Stop sessions on JAVA API"
lukegleeson [Tue, 8 Mar 2022 11:41:52 +0000 (11:41 +0000)]
Copyright Check Script
- Prints warnings to build log if copyright issues detected
- File ignore included for checkstyle folder and common extensions which don't have copyrights
- Included Tests
Issue-ID: CPS-911
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Idbdd050af964335cc32218e3c11c77d4101f9ecd
Renu Kumari [Fri, 18 Mar 2022 18:32:10 +0000 (14:32 -0400)]
Registration Response for Update and Delete cmhandles operations
- Process registration in the delete, create and update order
- updateRegistration returns DMIRegistartionRespons that contains
response for all operations
- Added logic to not delete cmhandle if schemaset deletion fails
Issue-ID: CPS-896
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I907ff678d478894e7d4d3cc24b23a979c02ed97a
emaclee [Wed, 23 Mar 2022 11:02:03 +0000 (11:02 +0000)]
Add Start and Stop sessions on JAVA API
Issue-ID: CPS-899
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Idbeb922790824b1ca601d6d4798df45efa57d685
Toine Siebelink [Fri, 25 Mar 2022 14:03:47 +0000 (14:03 +0000)]
Merge "Update maven build deploy version"
Lathish [Tue, 15 Mar 2022 12:03:53 +0000 (12:03 +0000)]
Updated the Documentation with sample yang and json
Issue-ID: CPS-940
Change-Id: I66b2f0cc1007a23498803cca695aa3d19c0eb433
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
JosephKeenan [Wed, 23 Mar 2022 15:01:33 +0000 (15:01 +0000)]
Update SpringBoot when approved version has Log4J 2.17.1 or higher
-Updated cps-dependencies/pom.xml SpringBoot to v2.6.4
-Updated cps-parent/pom.xml springboot maven to v2.6.4
-Updated spring cloud dependencies to 2021.0.1
Issue-ID: CPS-958
Change-Id: I37aca89edf6da83501414b4f202d3bb88464c801
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
emaclee [Thu, 24 Mar 2022 10:10:37 +0000 (10:10 +0000)]
Update maven build deploy version
Issue-ID: CPS-953
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Icc79e3836a186a2a9ce79c0e97965bc7e1fbb347
Toine Siebelink [Wed, 23 Mar 2022 08:26:22 +0000 (08:26 +0000)]
Merge "Update log4j dependency version from 2.17.1 to 2.17.2"
Bruno Sakoto [Tue, 22 Mar 2022 18:00:25 +0000 (18:00 +0000)]
Merge "Update docs to add info on providing additional config"
Toine Siebelink [Tue, 22 Mar 2022 17:31:18 +0000 (17:31 +0000)]
Merge "Return Registration response for updating cmhandles"
Renu Kumari [Mon, 21 Mar 2022 13:18:41 +0000 (09:18 -0400)]
Update docs to add info on providing additional config
- Added information on overriding values of spring-supported properties
Issue-ID: CPS-918
Signed-off-by: Renu Kumari <renu.kumari@bell.ca>
Change-Id: I660cd9ea0c4c73d972f9c1645f5ed28308282fdc
emaclee [Tue, 22 Mar 2022 10:09:42 +0000 (10:09 +0000)]
Update log4j dependency version from 2.17.1 to 2.17.2
Issue-ID: CPS-953
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I1f97b1864128c9e1105ecef2bfa5e598eefcd5d5
ToineSiebelink [Mon, 21 Mar 2022 16:17:23 +0000 (16:17 +0000)]
Update versions for next release
Update Minor version number (on master) for next release as part of creating
Jakarta release branch
Issue-ID: CPS-952
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ie96ae7ce8997774d3ea27275c73e7d0703257e5e