Seshu Kumar M [Thu, 28 Sep 2017 13:14:07 +0000 (13:14 +0000)]
Merge changes Ibc78f5be,Id1a6e6d2
* changes:
Fix code complexity
Use diamond operator(<>)
Seshu Kumar M [Thu, 28 Sep 2017 13:07:15 +0000 (13:07 +0000)]
Merge "Removed unused imports"
seshukm [Thu, 28 Sep 2017 07:56:07 +0000 (13:26 +0530)]
Fixed Critical Sonar Issues
IssueId: SO-164
Change-Id: I87915bcdab1457c766d53157305e8e2b68a7b4d8
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
DeWayne Filppi [Thu, 28 Sep 2017 13:00:04 +0000 (13:00 +0000)]
Merge "Adding UT for E2E Service"
Seshu Kumar M [Thu, 28 Sep 2017 12:58:51 +0000 (12:58 +0000)]
Merge "service-topology-operation"
Seshu Kumar M [Thu, 28 Sep 2017 12:57:32 +0000 (12:57 +0000)]
Merge "Removed useless assignment to variables"
Seshu Kumar M [Thu, 28 Sep 2017 12:57:15 +0000 (12:57 +0000)]
Merge "Removed the unused variables"
Seshu Kumar M [Thu, 28 Sep 2017 12:56:55 +0000 (12:56 +0000)]
Merge "Replaced with the diamnod operator"
Seshu-Kumar-M [Thu, 28 Sep 2017 12:04:49 +0000 (17:34 +0530)]
Adding UT for E2E Service
IssueId: SO-50
Change-Id: I7fc39adb7a1d96022541189a6f7279b13bbb3b5e
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
Seshu Kumar M [Thu, 28 Sep 2017 12:51:54 +0000 (12:51 +0000)]
Merge "Removed useless assignment to local variables"
rama-huawei [Mon, 25 Sep 2017 13:27:57 +0000 (18:57 +0530)]
Removed useless assignment to local variables
Issue-Id:SO-118
Change-Id: I29ec088aa52073f4e9df5503ede9f306c72e41d0
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Rob Daugherty [Wed, 27 Sep 2017 15:53:56 +0000 (15:53 +0000)]
Merge "Add test cases for E2E service"
Rob Daugherty [Wed, 27 Sep 2017 15:53:28 +0000 (15:53 +0000)]
Merge "Fixed Blocker issues. IssueId: SO-165"
Rob Daugherty [Wed, 27 Sep 2017 15:53:22 +0000 (15:53 +0000)]
Merge "Fixed E2EService blocker SONAR IssueId: SO-118"
Seshu Kumar M [Wed, 27 Sep 2017 15:27:25 +0000 (15:27 +0000)]
Merge "Fixed string literal comparision issue"
Seshu Kumar M [Wed, 27 Sep 2017 15:21:24 +0000 (15:21 +0000)]
Merge "Removed useless assignment to variables"
Seshu Kumar M [Wed, 27 Sep 2017 15:19:46 +0000 (15:19 +0000)]
Merge "Removed useless assignment to variables"
Seshu Kumar M [Wed, 27 Sep 2017 15:19:00 +0000 (15:19 +0000)]
Merge "Replace with Diamond symbol"
Seshu Kumar M [Wed, 27 Sep 2017 15:14:51 +0000 (15:14 +0000)]
Merge "Adding comments for empty constructor"
Seshu Kumar M [Wed, 27 Sep 2017 15:11:20 +0000 (15:11 +0000)]
Merge "Correcting varriable name"
黄卓垚10112215 [Wed, 27 Sep 2017 13:15:46 +0000 (21:15 +0800)]
service-topology-operation
Change-Id: I26b03516eb73689f806aa9ea5f1edcb22a1c4d84
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
Discription: Network-topology-operation should work with Service-topology-operation. This commit is for the Service-topology-operation.
rama-huawei [Wed, 27 Sep 2017 10:37:52 +0000 (16:07 +0530)]
Removed useless assignment to variables
Issue-Id:SO-118
Change-Id: I97cfd892ae5d13003b0b37509ac91be863dbd55e
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
seshukm [Wed, 27 Sep 2017 10:20:30 +0000 (15:50 +0530)]
Fixed Blocker issues.
IssueId: SO-165
Change-Id: I7c2520af9394ceb600a5a25fa9acfd095d872a1d
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
rama-huawei [Wed, 27 Sep 2017 10:31:12 +0000 (16:01 +0530)]
Removed the unused variables
Issue-Id:SO-118
Change-Id: I979370f8d3ffa0382856353aa189610d24dcd20c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Wed, 27 Sep 2017 10:22:13 +0000 (15:52 +0530)]
Replaced with the diamnod operator
Issue-Id:SO-118
Change-Id: Iaad28a363586cd8b42e86bd7e854faa9e716c59d
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
ramanjaneya [Wed, 27 Sep 2017 10:02:41 +0000 (15:32 +0530)]
Removed unused imports
Issue-Id:SO-118
Change-Id: I0c58455e74dd444e1cddae96cde7608fbed3e436
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
Rob Daugherty [Wed, 27 Sep 2017 10:11:26 +0000 (06:11 -0400)]
Update POM to inherit from oparent
Issue: SO-71
Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24
Signed-off-by: Rob Daugherty <rd472p@att.com>
seshukm [Wed, 27 Sep 2017 07:06:45 +0000 (12:36 +0530)]
Fixed E2EService blocker SONAR
IssueId: SO-118
Change-Id: Ia2e6e0d3bbef4c80721991762876c9ed98043790
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
surya-huawei [Tue, 26 Sep 2017 12:35:12 +0000 (18:05 +0530)]
Fix code complexity
*Use equalsIgnoreCase instead of comparing on converted cases
This is done to reduce the number of conversions
and it's more simple and it internally performs
null check as well
*Remove unused imports
This is done to increase code readability
Issue-Id: SO-118
Change-Id: Ibc78f5be645db69695c12bca1fbd0282914e90eb
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 26 Sep 2017 12:27:50 +0000 (17:57 +0530)]
Use diamond operator(<>)
Major Sonar Issue
*Replace type specification with diamond operator
This is done to reduce the verbosity of generics code
Issue-Id: SO-118
Change-Id: Id1a6e6d2e03f6f92a0e36b9326df61154c0ba910
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Seshu Kumar M [Tue, 26 Sep 2017 20:43:51 +0000 (20:43 +0000)]
Merge "Fix some major Sonar Issues"
Seshu Kumar M [Tue, 26 Sep 2017 20:41:58 +0000 (20:41 +0000)]
Merge "Use try-with-resources"
Seshu-Kumar-M [Tue, 26 Sep 2017 13:43:47 +0000 (19:13 +0530)]
SO Debug Env Setup Guide
Guide on how to setup the debug env
SO-81
Change-Id: I02b59540b59f84d1857a083a665b970af84ba124
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
rama-huawei [Tue, 26 Sep 2017 12:44:26 +0000 (18:14 +0530)]
Removed useless assignment to variables
Issue-Id:SO-118
Change-Id: Ic745bcfcd895da55735a39bc22c0346339255abf
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Tue, 26 Sep 2017 12:35:04 +0000 (18:05 +0530)]
Removed useless assignment to variables
Issue-Id:SO-118
Change-Id: I38f63be63f1ee3464ea16107d4b5c152dd4b1410
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Tue, 26 Sep 2017 12:24:42 +0000 (17:54 +0530)]
Replace with Diamond symbol
Issue-Id:SO-118
Change-Id: Ia660ff49ae2c9ff5969ef13060fdfbffb4dfce13
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
shashikanth [Tue, 26 Sep 2017 12:19:38 +0000 (17:49 +0530)]
Fixed string literal comparision issue
Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143
Move the "default" string literal on the left side of this string comparison.
Issue-Id: APPC-186
Change-Id: I5d503e08331a867b2871dee7acfe74112228bf16
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
surya-huawei [Tue, 26 Sep 2017 11:29:52 +0000 (16:59 +0530)]
Fix some major Sonar Issues
*Remove unused varible and assigments
*Remove uneccessary comment
Issue-Id: SO-118
Change-Id: I6c8bd416dd504bd9bceb8fd04e5da5efcbb6c89a
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
surya-huawei [Tue, 26 Sep 2017 10:42:10 +0000 (16:12 +0530)]
Use try-with-resources
*Replace try with try-with-resources
This is done to close resources automatically
and not worry about finally block
*Replace explicit type info with diamond operator
This is done to reduce verbosity of generics code
Issue-Id: SO-118
Change-Id: I948ffd26bfe6022496ca4a272de2619aef0dbd88
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Ankit-Huawei [Tue, 26 Sep 2017 10:38:39 +0000 (16:08 +0530)]
Correcting varriable name
SO-158
Change-Id: I683896e38f349d072dcc2967dee3a00f86448e4c
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
Seshu-Kumar-M [Tue, 26 Sep 2017 08:13:21 +0000 (13:43 +0530)]
Add test cases for E2E service
IssueId : SO-50
Change-Id: Idbace244134aea60eab0cbce553355d6e2a69f25
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
Ankit-Huawei [Mon, 25 Sep 2017 12:30:43 +0000 (18:00 +0530)]
Adding comments for empty constructor
SO-158
Change-Id: I82c0cfc4bc642fea34480feee0d5fb0bcebffe60
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
Seshu Kumar M [Tue, 26 Sep 2017 07:58:16 +0000 (07:58 +0000)]
Merge "Added the "@Override" annotation above signature"
Seshu Kumar M [Tue, 26 Sep 2017 07:56:17 +0000 (07:56 +0000)]
Merge "Fixed string literal comparision major issue"
Seshu Kumar M [Tue, 26 Sep 2017 07:55:24 +0000 (07:55 +0000)]
Merge "Added "@Override" annotation method signature"
Chuanyu Chen [Tue, 26 Sep 2017 06:51:40 +0000 (06:51 +0000)]
Merge "Change bpmn file name"
shashikanth [Tue, 26 Sep 2017 05:53:09 +0000 (11:23 +0530)]
Added "@Override" annotation method signature
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|fileUuids=AV3Bnsck5bp_wwmIVB7V|rules=squid%3AS2293%2Csquid%3AS1161
Issue-Id:SO-118
Change-Id: Iea674f0d8f4f0b9cef346f8c5315b02767ae65f4
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Tue, 26 Sep 2017 05:38:08 +0000 (11:08 +0530)]
Fixed string literal comparision major issue
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#fileUuids=AV3BnsdG5bp_wwmIVCEu|resolved=false|severities=MAJOR
Issue-Id:SO-118
Change-Id: I9ce4b3cb4c5acc5d19183dc278e4907aae221443
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Tue, 26 Sep 2017 05:22:43 +0000 (10:52 +0530)]
Added the "@Override" annotation above signature
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#fileUuids=AV3BnsdI5bp_wwmIVCGH|resolved=false|severities=MAJOR
Issue-Id:SO-118
Change-Id: If5556adabedb0cb498ecb646df9cb8f2a15a265d
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Seshu Kumar M [Mon, 25 Sep 2017 17:04:50 +0000 (17:04 +0000)]
Merge "Fix @Override major issues"
Seshu Kumar M [Mon, 25 Sep 2017 17:03:44 +0000 (17:03 +0000)]
Merge "Fixed string literal comparision redundant code"
Seshu Kumar M [Mon, 25 Sep 2017 17:00:43 +0000 (17:00 +0000)]
Merge "Replaced with Diamond symbol"
Seshu Kumar M [Mon, 25 Sep 2017 17:00:35 +0000 (17:00 +0000)]
Merge "Replaced with Diamond symbol"
Seshu Kumar M [Mon, 25 Sep 2017 16:58:22 +0000 (16:58 +0000)]
Merge "Changed try to try with resource"
Seshu Kumar M [Mon, 25 Sep 2017 16:51:26 +0000 (16:51 +0000)]
Merge "Rename "status" which hides the class field"
Seshu Kumar M [Mon, 25 Sep 2017 16:51:05 +0000 (16:51 +0000)]
Merge "Replaced with Diamond symbol"
Seshu Kumar M [Mon, 25 Sep 2017 16:49:39 +0000 (16:49 +0000)]
Merge "Replaced with Diamond symbol"
Seshu Kumar M [Mon, 25 Sep 2017 16:46:40 +0000 (16:46 +0000)]
Merge "Changed try to try with resource"
Seshu Kumar M [Mon, 25 Sep 2017 16:44:21 +0000 (16:44 +0000)]
Merge "Fixed string format specifier."
Seshu Kumar M [Mon, 25 Sep 2017 16:43:34 +0000 (16:43 +0000)]
Merge "Changed try to try with resource"
Seshu Kumar M [Mon, 25 Sep 2017 16:42:52 +0000 (16:42 +0000)]
Merge "Modified string literal comparision."
shashikanth [Mon, 25 Sep 2017 14:26:33 +0000 (19:56 +0530)]
Fix @Override major issues
Add the "@Override" annotation above this method signature
Issue-Id:SO-118
Change-Id: I0973c1559c66b80a56a9c1ba610ae73bba54fe49
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 14:17:04 +0000 (19:47 +0530)]
Fixed string literal comparision redundant code
Move the "content" string literal on the left side of this string comparison.
Issue-Id:SO-118
Change-Id: Ice9ef2d94f594669f0399d31e5346e3c0be66c13
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 14:05:50 +0000 (19:35 +0530)]
Fix major sonar issues
Move the "filter" string literal on the left side of this string comparison
Issue-Id:SO-118
Change-Id: Ib9078c10ffac5cb54e74e4c4565d413f4908f532
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 13:53:43 +0000 (19:23 +0530)]
Modified string literal comparision.
Move the "vnf" string literal on the left side of this string comparison.
Issue-Id:SO-118
Change-Id: Ia964db05bfffc2c519065afc0016253f9c665d55
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 13:36:24 +0000 (19:06 +0530)]
Fixed string format specifier.
String contains no format specifiers.
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL
Issue-Id:SO-118
Change-Id: Ibcb5124a98ea689a01461dddc42a4aa1db147a20
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
rama-huawei [Mon, 25 Sep 2017 13:12:03 +0000 (18:42 +0530)]
Rename "status" which hides the class field
Issue-Id:SO-118
Change-Id: I7a367373f15f7cfa2d2cfb965b63397cabdcbf1f
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
shashikanth [Mon, 25 Sep 2017 13:11:45 +0000 (18:41 +0530)]
Changed try to try with resource
Change this condition so that it does not always evaluate to "false"
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER
Issue-Id:SO-118
Change-Id: I0ebc001b3e7f6a13a2d309b69cc4133271a9e87e
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 13:06:47 +0000 (18:36 +0530)]
Changed try to try with resource
Change this condition so that it does not always evaluate to "false"
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER
Issue-Id:SO-118
Change-Id: I29713fa4c4623439addb4b7f30325dcb7e1ccfcc
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
rama-huawei [Mon, 25 Sep 2017 13:03:46 +0000 (18:33 +0530)]
Replaced with Diamond symbol
Issue-Id:SO-118
Change-Id: Id57f5f76f766d7394571d7a1a59f631696ab37a4
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Mon, 25 Sep 2017 12:46:33 +0000 (18:16 +0530)]
Replaced with Diamond symbol
Issue-Id:SO-118
Change-Id: I50641f26b3047018b33b1cf5c782546453b9638c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Zhuoyao Huang [Mon, 25 Sep 2017 13:00:20 +0000 (21:00 +0800)]
Change bpmn file name
Change-Id: I4de255105cb9b1b7ac536738d0aef9655d147007
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
shashikanth [Mon, 25 Sep 2017 12:45:57 +0000 (18:15 +0530)]
Changed try to try with resource
Change this condition so that it does not always evaluate to "false"
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER
Issue-Id:SO-118
Change-Id: Ib5331efaeddf0b15e8d55a6b6619d319f8194707
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
rama-huawei [Mon, 25 Sep 2017 12:11:23 +0000 (17:41 +0530)]
Replaced with Diamond symbol
Issue-Id:SO-118
Change-Id: I6a1542d53c9021e315331a1643519c25500df20a
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Seshu Kumar M [Mon, 25 Sep 2017 12:08:48 +0000 (12:08 +0000)]
Merge "Changed try to try with resource"
Seshu Kumar M [Mon, 25 Sep 2017 12:07:09 +0000 (12:07 +0000)]
Merge "Replaced with Diamond symbol"
rama-huawei [Mon, 25 Sep 2017 11:12:09 +0000 (16:42 +0530)]
Replaced with Diamond symbol
Issue-Id:SO-118
Change-Id: Ib7c5963521bc2e077a3e4d888ffb30566fd76be5
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Mon, 25 Sep 2017 10:33:46 +0000 (16:03 +0530)]
Replaced with Diamond symbol
Change-Id: I439daab53236cd35e43e3a503ddc4b3218f7d992
Issue-Id:SO-118
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
shashikanth [Mon, 25 Sep 2017 10:00:17 +0000 (15:30 +0530)]
Changed try to try with resource
Change this condition so that it does not always evaluate to "false"
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER
Issue-Id:SO-118
Change-Id: I8885beed7ab1fa2e26e1155665d9507746bd9906
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
shashikanth [Mon, 25 Sep 2017 09:32:23 +0000 (15:02 +0530)]
Deleted redundant code
Remove this return statement from this finally block
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER
Issue-Id:SO-118
Change-Id: I6933ec089e6030d5fd5495b37f4d785b0935341b
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
rama-huawei [Mon, 25 Sep 2017 06:02:31 +0000 (11:32 +0530)]
Replaced with Diamond symbol
Change-Id: Ibc14257b814b83427ce0078f83aaf4d6b0cc38c0
Issue-Id:SO-118
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Zhuoyao Huang [Sat, 23 Sep 2017 08:37:48 +0000 (16:37 +0800)]
fix a bug and ...
Change-Id: Id5dfae04cffa98705a5d99f9cf7d7552de5b8418
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
Discription: fix a bug and commit underlay vpn achieved by yang decoder
Zhuoyao Huang [Sat, 23 Sep 2017 06:43:23 +0000 (14:43 +0800)]
Yang decoder
Change-Id: I4e264c33915969f883ebc3721e7020fb1256682c
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
description: It could help SO to use the restconf interface which is generated by yang-tools in SDN-C directly.
Chuanyu Chen [Sat, 23 Sep 2017 01:40:12 +0000 (01:40 +0000)]
Merge "update spring version in MSOCommonBPMN"
Chuanyu Chen [Sat, 23 Sep 2017 01:39:48 +0000 (01:39 +0000)]
Merge "Replaced with Diamond symbol"
Chuanyu Chen [Sat, 23 Sep 2017 01:39:36 +0000 (01:39 +0000)]
Merge "Removed useless parentheses"
Chuanyu Chen [Sat, 23 Sep 2017 01:39:05 +0000 (01:39 +0000)]
Merge "Replaced with diamond operator"
Chuanyu Chen [Sat, 23 Sep 2017 01:38:30 +0000 (01:38 +0000)]
Merge "Added @Override for method"
Chuanyu Chen [Sat, 23 Sep 2017 01:37:58 +0000 (01:37 +0000)]
Merge "underlay vpn"
Chuanyu Chen [Sat, 23 Sep 2017 01:37:07 +0000 (01:37 +0000)]
Merge "Fix for lack of flow condition"
Chuanyu Chen [Sat, 23 Sep 2017 01:36:30 +0000 (01:36 +0000)]
Merge "Add GET e2e svc instance"
rama-huawei [Fri, 22 Sep 2017 15:51:03 +0000 (21:21 +0530)]
Replaced with Diamond symbol
Removed useless parentheses
Issue-Id:SO-118
Change-Id: I79c55aebe53e82bc649c4524e5a1029a5b7a496f
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Fri, 22 Sep 2017 15:23:18 +0000 (20:53 +0530)]
Removed useless parentheses
Issue-Id:SO-118
Change-Id: I03173685857798cc12d5df532854a062ff08bf1c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
rama-huawei [Fri, 22 Sep 2017 13:24:13 +0000 (18:54 +0530)]
Replaced with diamond operator
Replace the synchronized class "StringBuffer" by an unsynchronized one such as "StringBuilder"
Issue-Id:SO-118
Change-Id: Ica8ce815a834fcb8195e16096972b6f1627d7214
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
Krzysztof Kwiecien [Fri, 22 Sep 2017 14:00:57 +0000 (16:00 +0200)]
update spring version in MSOCommonBPMN
Issue: SO-159
Change-Id: Ic3e442eaa7603b52a2e32e8395ca8ff9bc069f75
Signed-off-by: Krzysztof Kwiecien <krzysztof.kwiecien1@orange.com>
Ankit-Huawei [Fri, 22 Sep 2017 12:42:10 +0000 (18:12 +0530)]
Added @Override for method
SO-158
Change-Id: I71ab81317e011e3721beaa93afd6e845d5e18036
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
Zhuoyao Huang [Fri, 22 Sep 2017 11:22:42 +0000 (19:22 +0800)]
underlay vpn
Change-Id: I3eafc44ca701f02921dfe14a2714948cd1c21c2d
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
Seshu-Kumar-M [Fri, 22 Sep 2017 11:50:17 +0000 (19:50 +0800)]
Fix for lack of flow condition
condition corrected for the gate
SO-158
Change-Id: I10308d9062e7d28acb415310f85505eb561b467e
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
Seshu Kumar M [Fri, 22 Sep 2017 10:30:53 +0000 (10:30 +0000)]
Merge "Fix Blocker/Critical sonar issues"
shashikanth [Fri, 22 Sep 2017 09:54:41 +0000 (15:24 +0530)]
Fix Blocker/Critical sonar issues
Fix Blocker/Critical sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL
Fixed issue Remove this call to "equals"; comparisons between unrelated types always return false.
Issue-Id:SO-118
Change-Id: I8e3594958a84efc933206655b7ff96a7d08c24e0
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
Code Review / so.git / log