r.bogacki [Wed, 27 Feb 2019 12:09:08 +0000 (13:09 +0100)]
Removed MsoLogger from 'cloudify-client'
Removed MsoLogger from adapters ('cloudify-client')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I3d1f31a1ec8250772290383c23e65a0d5cc575a0
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Steve Smokowski [Tue, 26 Feb 2019 23:16:35 +0000 (23:16 +0000)]
Merge "Add CDS client"
Alexis de Talhouët [Tue, 26 Feb 2019 16:26:03 +0000 (11:26 -0500)]
Add CDS client
Change-Id: I3f77a2c9e8341239b97675f5897cecf28c7dfb6f
Issue-ID: SO-1483
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Kalkere Ramesh, Sharan (sk720x) [Tue, 26 Feb 2019 20:59:30 +0000 (15:59 -0500)]
removed flyway from bpmn base yaml
Fix startup of catalog, request, bpmn and openstack
Change-Id: I8e8222e410da58a62beed8cb184c90ebe73aea6c
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
Steve Smokowski [Tue, 26 Feb 2019 18:23:04 +0000 (18:23 +0000)]
Merge "Remove MsoLogger from 'mso-openstack-adapters'"
Steve Smokowski [Tue, 26 Feb 2019 18:02:04 +0000 (18:02 +0000)]
Merge "Remove MsoLogger from 'mso-adapter-utils'"
Steve Smokowski [Tue, 26 Feb 2019 18:01:29 +0000 (18:01 +0000)]
Merge "changed to jdbcUrl and updated flyway for bpmn"
k.kazak [Tue, 26 Feb 2019 17:23:41 +0000 (18:23 +0100)]
Remove MsoLogger from 'mso-openstack-adapters'
Removed MsoLogger from adapters ('mso-openstack-adapters')
Replaced MsoLogger with plain slf4j
Refactored login output
Fixed imports
Change-Id: Ib9da84f659dcc57a374f9b684ce8fbf30e866d4d
Issue-ID: LOG-631
Signed-off-by: k.kazak <k.kazak@samsung.com>
Steve Smokowski [Tue, 26 Feb 2019 16:57:49 +0000 (16:57 +0000)]
Merge "removed the duplicate BpelRestClient"
Steve Smokowski [Tue, 26 Feb 2019 16:57:42 +0000 (16:57 +0000)]
Merge "do not attempt to commit empty transactions"
Steve Smokowski [Tue, 26 Feb 2019 16:57:33 +0000 (16:57 +0000)]
Merge "Removed MsoLogger from 'MSOCoreBPMN'"
Steve Smokowski [Tue, 26 Feb 2019 16:57:27 +0000 (16:57 +0000)]
Merge "Default fromPreload to false if no"
k.kazak [Tue, 26 Feb 2019 16:50:51 +0000 (17:50 +0100)]
Remove MsoLogger from 'mso-adapter-utils'
Removed MsoLogger from adapters ('mso-adapter-utils')
Replaced MsoLogger with plain slf4j
Refactored login output
Fixed imports
Change-Id: I5805427f3d6870a35f523934ceee73f17d4e130d
Issue-ID: LOG-631
Signed-off-by: k.kazak <k.kazak@samsung.com>
Kalkere Ramesh, Sharan (sk720x) [Mon, 25 Feb 2019 23:51:48 +0000 (18:51 -0500)]
changed to jdbcUrl and updated flyway for bpmn
Fix startup of catalog, request, bpmn and openstack
Change-Id: I5982857c610ae46aa8690764c4f6ef99240f5088
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
Benjamin, Max (mb388a) [Tue, 26 Feb 2019 14:57:29 +0000 (09:57 -0500)]
Default fromPreload to false if no
Correct JUnit test data for default from-preload value
Default fromPreload to false if no requestParameters are available.
Change-Id: I20846871958226740e4a5dee90c8e31ff3bdfddf
Issue-ID: SO-1572
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 26 Feb 2019 14:54:15 +0000 (09:54 -0500)]
check that a la carte is not null
Handle the case of absent aLaCarte and usePreload settings
Change-Id: Ic3413515218013870ddce97ec225edaa6b6e99c3
Issue-ID: SO-1571
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 26 Feb 2019 14:52:30 +0000 (09:52 -0500)]
removed the duplicate BpelRestClient
removed the qualifier in the unit test that broke
removed the test for bpel rest network test
removed the duplicate BpelRestClient and added some logging
Change-Id: I2c5007537ef51f36f0014e091a61804d6354d7d7
Issue-ID: SO-1570
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 26 Feb 2019 14:51:06 +0000 (09:51 -0500)]
do not attempt to commit empty transactions
do not attempt to commit empty transactions
Change-Id: I0db4f87449e7362dbbc2dc6ccfffca9f75c077eb
Issue-ID: SO-1569
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Steve Smokowski [Tue, 26 Feb 2019 13:25:55 +0000 (13:25 +0000)]
Merge "Removed MsoLogger from 'mso-vfc-adapter'"
r.bogacki [Tue, 26 Feb 2019 13:15:35 +0000 (14:15 +0100)]
Removed MsoLogger from 'MSOCoreBPMN'
Removed MsoLogger from adapters ('MSOCoreBPMN')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: Ida6bc00d6b179d712716213ad514d2fb3faeacc1
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Tue, 26 Feb 2019 11:03:44 +0000 (12:03 +0100)]
Removed MsoLogger from 'mso-sdnc-adapter'
Removed MsoLogger from adapters ('mso-sdnc-adapter')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I1656776a04b322b9b8da30a3cc6aad31cd621a3e
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 25 Feb 2019 14:47:04 +0000 (15:47 +0100)]
Removed MsoLogger from 'mso-vfc-adapter'
Removed MsoLogger from adapters ('mso-vfc-adapter')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: Ib7561440520bdd9e1f0257639ab52f32f9bdb98e
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Kalkere Ramesh, Sharan (sk720x) [Mon, 25 Feb 2019 20:00:17 +0000 (15:00 -0500)]
moved flyway under spring namespace
Fix startup of catalog, request, bpmn and openstack
Change-Id: Iaa2c3a77f28ca67df7cc9f9b6f98e8b7e1d38181
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
Steve Smokowski [Mon, 25 Feb 2019 18:28:07 +0000 (18:28 +0000)]
Merge "Removed MsoLogger in 'mso-requests-db-adapter'"
Steve Smokowski [Mon, 25 Feb 2019 15:07:18 +0000 (15:07 +0000)]
Merge "Removed MsoLogger 'mso-requests-db-repositories'"
r.bogacki [Mon, 25 Feb 2019 14:04:45 +0000 (15:04 +0100)]
Removed MsoLogger from 'mso-requests-db'
Removed MsoLogger from adapters ('mso-requests-db')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I97fd5981b503b132fbbf4f64047481420c9c5fa6
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Steve Smokowski [Mon, 25 Feb 2019 13:54:48 +0000 (13:54 +0000)]
Merge "Removed MsoLogger in 'mso-catalog-db-adapter'"
Steve Smokowski [Mon, 25 Feb 2019 13:54:36 +0000 (13:54 +0000)]
Merge "Added Junit For DMaaPConsumerFailure.java"
Steve Smokowski [Mon, 25 Feb 2019 13:54:18 +0000 (13:54 +0000)]
Merge "Removed MsoLogger in 'mso-adapters-rest-interface'"
Steve Smokowski [Mon, 25 Feb 2019 13:53:42 +0000 (13:53 +0000)]
Merge "Removed MsoLogger from SO 'common' module"
Steve Smokowski [Mon, 25 Feb 2019 13:53:18 +0000 (13:53 +0000)]
Merge "Prevent race conditions on same distributionId."
Steve Smokowski [Mon, 25 Feb 2019 13:53:15 +0000 (13:53 +0000)]
Merge "Add NETWORK_CORRELATOR on network updates async"
Steve Smokowski [Mon, 25 Feb 2019 13:53:13 +0000 (13:53 +0000)]
Merge "Update long poll DMaaP timeout value to 55 seconds"
r.bogacki [Mon, 25 Feb 2019 13:36:58 +0000 (14:36 +0100)]
Removed MsoLogger 'mso-requests-db-repositories'
Removed MsoLogger from adapters ('mso-requests-db-repositories')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: Ibdd89620e6d23550fe523727475f1cd1e95d3992
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 25 Feb 2019 12:57:02 +0000 (13:57 +0100)]
Removed MsoLogger in 'mso-requests-db-adapter'
Removed MsoLogger from adapters ('mso-requests-db-adapter')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: Ib9f929ad673e4da122524e8874d07198949eba0b
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 25 Feb 2019 12:15:07 +0000 (13:15 +0100)]
Removed MsoLogger in 'mso-catalog-db-adapter'
Removed MsoLogger from adapters ('mso-catalog-db-adapter')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: Ic61119892e9d4cb41498f2be2a65990f4d51bf0a
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Sudarshan Kumar [Mon, 25 Feb 2019 12:05:20 +0000 (17:35 +0530)]
Added Junit For DMaaPConsumerFailure.java
Added Junit For DMaaPConsumerFailure.java
Issue-ID: SO-1480
Change-Id: I1eff422baaf4e4475e3989d34f5dd591b1bfe4b1
Signed-off-by: Sudarshan Kumar <sudars19@in.ibm.com>
r.bogacki [Mon, 25 Feb 2019 11:32:01 +0000 (12:32 +0100)]
Removed MsoLogger in 'mso-adapters-rest-interface'
Removed MsoLogger from adapters ('mso-adapters-rest-interface')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I2623c14dda55ae471bc11d40345c5f91c62bd94f
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 25 Feb 2019 09:23:33 +0000 (10:23 +0100)]
Removed MsoLogger from SO 'common' module
Replaced MsoLogger with plain slf4j.
Refactored login output.
Change-Id: I3ff1882406782d64cf0f572c574ab1068449f76b
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Benjamin, Max (mb388a) [Sun, 24 Feb 2019 15:42:15 +0000 (10:42 -0500)]
Prevent race conditions on same distributionId.
- Code to include optimistic lock to prevent race conditions on same
distributionId.
Change-Id: Ibe110b32f2472d991a4a3e03e3d15d5e4deefd65
Issue-ID: SO-1566
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Sun, 24 Feb 2019 15:50:44 +0000 (10:50 -0500)]
Add NETWORK_CORRELATOR on network updates async
added verification for mocked BpmnError
add unmarshal test missing in commit
add junit for NetworkAdapter Callback success/failure
Add NETWORK_CORRELATOR on network updates async etc
Change-Id: Ib10709ddb61011aec247e9c020b7ee7c42949118
Issue-ID: SO-1568
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Sun, 24 Feb 2019 15:48:45 +0000 (10:48 -0500)]
Update long poll DMaaP timeout value to 55 seconds
Update long poll DMaaP timeout value to 55 seconds
Change-Id: I19e5b19e81e202933478ce9c7c1c6f96d89125ec
Issue-ID: SO-1567
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Sun, 24 Feb 2019 15:41:12 +0000 (10:41 -0500)]
Remove deprecated code that duplicates enabled
Remove deprecated code that duplicates enabled parameter
Change-Id: I286ba0e4239207fca3aab30e6c9a159baea92fc5
Issue-ID: SO-1565
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Fri, 22 Feb 2019 22:51:42 +0000 (17:51 -0500)]
remove payload logging from metric/audit side
fixed unit test after changing how entities are read
remove payload logging from metric/audit side
Change-Id: Ibfe7cf96c76920926e9ae9ce5041389324d09b46
Issue-ID: SO-1564
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Kalkere Ramesh, Sharan (sk720x) [Fri, 22 Feb 2019 19:05:16 +0000 (14:05 -0500)]
added back in so monitoring to parent pom
Fix startup of catalog, request, bpmn and openstack
Change-Id: I7ef86a8ba81625cc0bdda35c3dcdf12b37ef2821
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
Steve Smokowski [Fri, 22 Feb 2019 15:14:25 +0000 (15:14 +0000)]
Merge "assignvfmodulebb must send use-preload"
Steve Smokowski [Fri, 22 Feb 2019 15:14:20 +0000 (15:14 +0000)]
Merge "Fix for when Customization already exists"
Steve Smokowski [Fri, 22 Feb 2019 15:13:58 +0000 (15:13 +0000)]
Merge "fix potential nullpointer from sonar"
Lukasz Muszkieta [Fri, 22 Feb 2019 14:05:42 +0000 (14:05 +0000)]
Merge "Change interface name to be more suitable"
k.kazak [Fri, 22 Feb 2019 08:00:16 +0000 (09:00 +0100)]
fix potential nullpointer from sonar
MsoMulticloudUtils: multicloudClient may be null
throw MsoException if it is null (instead of NullPointer)
removed unnecessary StackInfo object creation
using format specifiers for a logger instead of String concatenation
removed else block to make the code easier to read
Added tests for the method
Change-Id: I80d2e0ba2ef2d20c488cdfcf103d9cfa5784ab65
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
Kalkere Ramesh, Sharan (sk720x) [Thu, 21 Feb 2019 23:34:56 +0000 (18:34 -0500)]
updated base yamls to properly connect to DB
Fix startup of catalog, request, bpmn and openstack
Change-Id: I83dcd17d03c71301610ab2c8bbeb30142cc14303
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
Steve Smokowski [Thu, 21 Feb 2019 16:43:01 +0000 (16:43 +0000)]
Merge "remove unneeded code"
Lukasz Muszkieta [Thu, 21 Feb 2019 15:23:29 +0000 (16:23 +0100)]
remove unneeded code
Change-Id: Ib1a62a8cf3a0335bf163ca2634c86e95d2a258b8
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Steve Smokowski [Thu, 21 Feb 2019 13:28:45 +0000 (13:28 +0000)]
Merge "Fixed major Sonar issues in ServicePluginFactory"
Steve Smokowski [Thu, 21 Feb 2019 13:27:29 +0000 (13:27 +0000)]
Merge "Updated as per review comments"
Lukasz Muszkieta [Thu, 21 Feb 2019 12:28:55 +0000 (13:28 +0100)]
Change interface name to be more suitable
Change-Id: Ifb4f6bc7f3e18974e9a11a17d474ad989c043673
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
r.bogacki [Thu, 21 Feb 2019 10:01:22 +0000 (11:01 +0100)]
Fixed major Sonar issues in ServicePluginFactory
Removed not used variable.
Removed unnecessary castings.
Cleaned diamond operators.
Removed commented out block of code.
Change-Id: I0adca822f6dcb9efaa1ea96c9ff9092a7a2baa84
Issue-ID: SO-1552
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Prema Bhatt [Thu, 21 Feb 2019 00:50:10 +0000 (16:50 -0800)]
Updated as per review comments
This git review replaces https://gerrit.onap.org/r/#/c/78430/. As I had
some issues updating the existing git review, I'm creating a new one.
Issue-ID: SO-1391
Change-Id: Ida3f94ad7e2249a30a99d67a071930323ba743b5
Signed-off-by: Prema Bhatt <pb6115@att.com>
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:53:01 +0000 (16:53 -0500)]
Continue to separate AAIClient into GraphInventory
added narad specific relationship implementation
add mapper to narad rest client
wrapper now returns correct relationships type
equals now longer only works on AAIUris
Change-Id: I12325f76ae08659ffe744a56f5e6b6d54196b054
Issue-ID: SO-1541
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:50:13 +0000 (16:50 -0500)]
Fix for when Customization already exists
- When the Customization already exists associate the new
NetworkResource with it.
Change-Id: Ia4d89a04d020dd2f2ba4a2f2d330bda9bff6da14
Issue-ID: SO-1540
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:48:49 +0000 (16:48 -0500)]
assignvfmodulebb must send use-preload
Corrections to JUnit data to account for usePreload usage.
Resurrect usage of usePreload value and pass fromPreload to SDNC.
Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3
Issue-ID: SO-1539
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Steve Smokowski [Wed, 20 Feb 2019 16:48:32 +0000 (16:48 +0000)]
Merge "Fixed possible NPE in WorkflowAction"
Steve Smokowski [Wed, 20 Feb 2019 16:48:07 +0000 (16:48 +0000)]
Merge "fix sonar blocker try-with-resources"
Steve Smokowski [Wed, 20 Feb 2019 15:12:40 +0000 (15:12 +0000)]
Merge "Cleaned up Sonar issues in AuditStackServiceData"
r.bogacki [Wed, 20 Feb 2019 14:03:48 +0000 (15:03 +0100)]
Cleaned up Sonar issues in AuditStackServiceData
Removed unnecessary imports.
Removed unnecessary cast to "String".
Change-Id: I8b14b0f53860edb656b38914941c44003a625037
Issue-ID: SO-1537
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Tue, 19 Feb 2019 14:03:41 +0000 (15:03 +0100)]
Fixed possible NPE in WorkflowAction
NullPointerException could be thrown
in case when resource == null.
Change-Id: I1f78e4733187f3086ac1915d2bfb098fb8c4aabd
Issue-ID: SO-1530
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Steve Smokowski [Wed, 20 Feb 2019 13:13:45 +0000 (13:13 +0000)]
Merge "Create Pre Building Block validator"
Steve Smokowski [Wed, 20 Feb 2019 13:13:38 +0000 (13:13 +0000)]
Merge "flowvaldiator will allow more flexible filtering"
Steve Smokowski [Wed, 20 Feb 2019 13:13:32 +0000 (13:13 +0000)]
Merge "Update to set correct cvnfc code"
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 23:00:41 +0000 (18:00 -0500)]
Create Pre Building Block validator
Use Flowvalidator shouldRunFor method to check if flow needs to be
validated.
Create Pre Building Block validator to check if cloud-region
orchestration-disabled is true
Change-Id: I2f1dca16c97505292d9b99f7e206713e4963261f
Issue-ID: SO-1534
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:55:41 +0000 (17:55 -0500)]
flowvaldiator will allow more flexible filtering
fixed unit tests that reference forItems()
forItems is now shouldRunFor allowing more flexibility
Change-Id: I497f3a2899ae4df555e781c7c85a238e657fcba8
Issue-ID: SO-1533
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:51:14 +0000 (17:51 -0500)]
Update to set correct cvnfc code
- Update testcase naming code to oamfw for testCvnfc.
- Update to set correct cvnfc nfc_function and nfc_naming_code
Change-Id: I13eca10d4d76a24753eca99e3f6ff96d0cc408f4
Issue-ID: SO-1532
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:48:46 +0000 (17:48 -0500)]
Added the conversion of decrypted value
Added jUnit test for the conversion of decrypted value to Basic
Base64Binary.
Added the conversion of decrypted value as Basic Base64Binary.
Change-Id: I361cbe3dac61df2728c9f58c314a21b3cc764a9f
Issue-ID: SO-1531
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Lukasz Muszkieta [Tue, 19 Feb 2019 15:42:21 +0000 (15:42 +0000)]
Merge "Validate inputs for pnf association"
k.kazak [Tue, 19 Feb 2019 14:39:56 +0000 (15:39 +0100)]
fix sonar blocker try-with-resources
BpmnInstaller: use try-with-resources in containsWorkflows
remove unnecessary type casting to ZipEntry
BpmnInstallerTest: add tests for containsWorkflows
fix test for installBpmn (was silently failing with file not found)
Change-Id: I3122bcd19204bf498fe1a9b10630076e2df9d70b
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
Steve Smokowski [Tue, 19 Feb 2019 13:27:46 +0000 (13:27 +0000)]
Merge "fix sonar potential nullpointer"
k.kazak [Tue, 19 Feb 2019 08:06:56 +0000 (09:06 +0100)]
fix sonar potential nullpointer
AppcRunTasks: fix potential null pointer if vnf = null
AppcRunTasksTest: add tests for this case and the method itself
Change-Id: I63b37670541ef5ff31b03b0336d990677b753fc5
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
Benjamin, Max (mb388a) [Mon, 18 Feb 2019 17:50:57 +0000 (12:50 -0500)]
set version when using constructor
set version when using constructor
Change-Id: Iaa7c74c8189eb4c607f25fe3f1660c08e80b2586
Issue-ID: SO-1529
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Steve Smokowski [Mon, 18 Feb 2019 13:29:06 +0000 (13:29 +0000)]
Merge "fix sonar critical bug"
Steve Smokowski [Mon, 18 Feb 2019 13:28:05 +0000 (13:28 +0000)]
Merge "fix critical sonar bugs"
Joanna Jeremicz [Thu, 10 Jan 2019 08:22:46 +0000 (09:22 +0100)]
Validate inputs for pnf association
Issue-ID: SO-1274
Change-Id: I3fdb66ef4bd259bef46c6f092d7d142b6cb5d9dc
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 22:49:16 +0000 (17:49 -0500)]
Use APIH credentials in 'mso.db.auth'
Updated to use methods: env.getRequiredProperty() and msoLogger.error().
Added the msoKey and the CryptoUtils.decrypt() code, and used
"mso.camundaAuth".
Used APIH credentials in 'mso.db.auth' as source instead of
'mso.camundaAuth' (need decrypt code by CryptoUtils).
Change-Id: I66c9d96db8137c1d9a5b56aa33d14587cbaa7b9e
Issue-ID: SO-1517
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
k.kazak [Fri, 15 Feb 2019 16:27:08 +0000 (17:27 +0100)]
fix sonar critical bug
MsoHeatUtils: remove unnecessary heatClient check for null
1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309
2. heatClient is never null: method creates a new object or throws Exception
MsoHeatUtilsTest: added tests for getHeatClient and createStack methods
BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them
StubOpenStack: added stubs for getStack and unsuccessful authorization
removed unused imports
Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
Steve Smokowski [Fri, 15 Feb 2019 14:23:49 +0000 (14:23 +0000)]
Merge "query clients now set their expected object"
Steve Smokowski [Fri, 15 Feb 2019 12:40:24 +0000 (12:40 +0000)]
Merge "fix issue where we attempt audit with no servers"
Steve Smokowski [Fri, 15 Feb 2019 12:40:15 +0000 (12:40 +0000)]
Merge "updated camunda springboot version"
Steve Smokowski [Fri, 15 Feb 2019 12:39:02 +0000 (12:39 +0000)]
Merge "Process query of Network Policies from A&AI"
Steve Smokowski [Fri, 15 Feb 2019 12:38:58 +0000 (12:38 +0000)]
Merge "extract subinterface_network_quantity from policy"
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:59:07 +0000 (19:59 -0500)]
query clients now set their expected object
unit test is using the wrong number of keys for aai uri
query clients now set their expected object for method
Change-Id: I622c76cee0e9d47be35a78156267bf1c22cbf404
Issue-ID: SO-1514
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:54:00 +0000 (19:54 -0500)]
fix issue where we attempt audit with no servers
fix issue where we attempt audit with no servers
Change-Id: I47f76121c616bf65a5f8be73910adcc0d7088bdb
Issue-ID: SO-1513
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:52:29 +0000 (19:52 -0500)]
updated camunda springboot version
Added required unimplemented methods to classes
Change-Id: I1ab6333582f2f09c6c363786c8168fdf54936bf8
Issue-ID: SO-1512
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:14:00 +0000 (18:14 -0500)]
Process query of Network Policies from A&AI
Process query of Network Policies from A&AI as a NetworkPolicies object.
Change-Id: I01b4c00e3732a5518ddc21d08740c0684de86d5e
Issue-ID: SO-1511
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:12:24 +0000 (18:12 -0500)]
extract subinterface_network_quantity from policy
- Removed duplicate code that was causing a NumberFormatException
- Changed name from crTarget to policyNetworkCollection
- Added code to check we are setting the quantity on the correct
NetworkCollection
- Added code to extract the subinterface_network_quantity from the
nodeTemplate policy
Change-Id: Id12fa0241f16bfd4467209f08af5068d57b2d049
Issue-ID: SO-1510
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:10:29 +0000 (18:10 -0500)]
always increment gCurrentSequence
always increment gCurrentSequence to properly interact with retry and
rollback logic
Change-Id: I7e99973682f93f891c8d35a4f3699ba17a05bc15
Issue-ID: SO-1509
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Marcus Williams [Thu, 14 Feb 2019 20:02:18 +0000 (20:02 +0000)]
Merge "fix fields not set correctly in Fabric Policy dist"
Steve Smokowski [Thu, 14 Feb 2019 16:34:28 +0000 (16:34 +0000)]
Merge "cloud config migration from openstack to catdb"
Steve Smokowski [Thu, 14 Feb 2019 16:33:22 +0000 (16:33 +0000)]
Merge "fix major sonar bug"
Steve Smokowski [Thu, 14 Feb 2019 16:32:40 +0000 (16:32 +0000)]
Merge "fixed CandidateType json serialization"
Steve Smokowski [Thu, 14 Feb 2019 16:32:33 +0000 (16:32 +0000)]
Merge "add new functionality to aai client"
Steve Smokowski [Thu, 14 Feb 2019 16:32:24 +0000 (16:32 +0000)]
Merge "workflow action should read config for max retries"
Code Review / so.git / log