vempo [Fri, 29 Dec 2017 14:59:26 +0000 (16:59 +0200)]
Default constructors in vendor-license-api module
Change-Id: I27d68b0e9d2eb73e044a11433358f697d692cd4a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
vempo [Fri, 29 Dec 2017 15:05:21 +0000 (17:05 +0200)]
Default ctors in vendor-software-product module
Change-Id: I7e852d649c56d6c25f68d9e20c1682f4c3deca0a
Issue-ID: SDC-343
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:13:47 +0000 (17:43 +0530)]
Fixed sonar issues - ItemProperties
Fixed all sonar issues
Change-Id: Iccf3bd86156ece8d3dbc719f7fe40b8356b2710e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Thu, 28 Dec 2017 12:10:55 +0000 (17:40 +0530)]
Fixed sonar issues - ConfigConstants
Fixed all sonar issues
Change-Id: I2b7657076aa2a296531a0c3677777ea6001102c4
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:40:20 +0000 (15:10 +0530)]
Refactored as discussed - OrchestrationUtil
Remvoed exception handling and Constructor fix
Change-Id: I6a97f31d429848fa3c008892c48358bc7f67536a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix sonar issues -HeatToToscaUtil
Changed as per comments provided
Change-Id: I4787b99b2a8629dbf2c1a68995546e185778f5e8
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
avigaffa [Thu, 28 Dec 2017 07:34:47 +0000 (09:34 +0200)]
Fixing sonar Exception Handling
Change-Id: I0afe103b921ea26de8f701e9a2cff7943ab58110
Issue-ID: SDC-810
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
vempo [Thu, 28 Dec 2017 15:12:44 +0000 (17:12 +0200)]
Fixed broken mapping of ChoiceOrOther
ChoiceOrOther needs default constructor to be recreated by reflection
Change-Id: I194ced8b5e6a60f0dbe6f9b73715cd36c70f5163
Issue-ID: SDC-830
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:28:32 +0000 (15:58 +0530)]
Fixed sonar issues - OrchestrationUploadFactory
Fixed all sonar issues except exception handling
Change-Id: I694a37df40ef05a6217d2f6db41cd7b15ba1e10e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:44:02 +0000 (18:14 +0530)]
Refactored - ProcessManagerImpl
Refactored as per given comment
Change-Id: I366fc8ac93ce977143adbc3a4698ed5f11010405
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 12:25:08 +0000 (17:55 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I49f566c7babebf395a689846734f4932f150a9f8
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 11:09:18 +0000 (16:39 +0530)]
Fixing sonar qube issues
Refactor code as per review comment.
Change-Id: I5419848dd28e1c2276c995308dcdff55c624dd8b
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Thu, 28 Dec 2017 05:09:55 +0000 (10:39 +0530)]
Fixed sonar issues - ImageManagerImpl
Fixed all sonar issues and refactored as per given comment
Change-Id: I86ec2ac3f72eae3fea5291664865a1c3b4c57791
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 15:00:32 +0000 (20:30 +0530)]
Fix Sonar violations - ConfigurationDataSource
1. Fixed major sonar violations configuration management core
- ConfigurationDataSource
Change-Id: Iee96111b3051a67d25f99a0ba49e99f4d9290345
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:38:14 +0000 (20:08 +0530)]
Fix Sonar violations - AggregateConfiguration
1. Fixed major sonar violations configuration management core
- AggregateConfiguration
Change-Id: I311d0e84fbfaf936ec1a260898e0cc0090e05be9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:45:17 +0000 (20:15 +0530)]
Fix Sonar violations - ConfigurationRepository
1. Fixed major sonar violations configuration management core
- ConfigurationRepository
Change-Id: Iab756af7ffae63fe9e644d733225908d121cbd9a
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:17:44 +0000 (19:47 +0530)]
Fix Sonar violations - AgglomerateConfiguration
1. Fixed major sonar violations configuration management core
- AgglomerateConfiguration
Change-Id: I1f79df3a1d256aeb45b82d344c507d40f6b83026
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:16:30 +0000 (15:46 +0530)]
Fixing sonar qube issues
Refactoring the code as per review comments.
Change-Id: I1edd457f8d0989f815cbf3f28fa0a5124a8c4ac7
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 14:09:34 +0000 (16:09 +0200)]
sonar issue fix - remove dead code
remove dead code.
Issue-ID: SDC-804
Change-Id: I1bae8d3d338730dfad72b155eacebc8e1f5c838f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 14:05:46 +0000 (19:35 +0530)]
Fix Sonar violations - ConfigurationFilter
1. Fixed major sonar violations configuration management core
- ConfigurationFilter
Change-Id: I6fa69a894854026c32ab7e81d7c3749c7bd16841
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Wed, 27 Dec 2017 08:17:10 +0000 (13:47 +0530)]
Fixed sonar issues - YamlUtil
Fixed violations and Added Copyright. Created constants
Change-Id: I061ed453ed3706410b49774ee2bd0572a1c3a36f
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 09:58:38 +0000 (15:28 +0530)]
Fix sonar issues - Common Methods
Junit and Logger removed
Change-Id: Ic1a987600a8a5ab8c236be242f0f0cd12faf9624
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
talio [Wed, 27 Dec 2017 10:59:05 +0000 (12:59 +0200)]
Add tests
Add unit tests for ToscaTreeManager
Change-Id: I772b63799cd34b687e6c81cb235c1c9a36ad34a2
Issue-ID: SDC-802
Signed-off-by: talio <tali.orenbach@amdocs.com>
mojahidi [Wed, 27 Dec 2017 13:06:28 +0000 (18:36 +0530)]
Fixed sonar issues - OrchestrationTemplateCandidat
Fixed all sonar issues
Change-Id: I3490d2299053475e79354526a854be99ebc5b9de
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
avigaffa [Wed, 27 Dec 2017 12:42:46 +0000 (14:42 +0200)]
Validate notification framework called in test
Call to ItemPermissionsManagerImplTest
Change-Id: I8b1f0e42c0f7b4ebf821f18e9fbbb801f95052c9
Issue-ID: SDC-803
Signed-off-by: avigaffa <avi.gaffa@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:39:24 +0000 (18:09 +0530)]
Fixed sonar issues - NetworkManagerImpl
Fixed all sonar issues
Change-Id: I0baf7c56a68b60a8635dd88638a287098e685b31
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 10:51:50 +0000 (16:21 +0530)]
Fixing sonar qube issues
Removed commented code from MapValidationFileResponseToValidationFileResponseDto file.
Change-Id: I03eca70fe5bc6dfed8ca7762b298e8f83f2ee628
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 12:17:14 +0000 (17:47 +0530)]
Fixed sonar issues - MonitoringUploadsManagerImpl
Fixed all sonar issues except exception handling
Change-Id: I799c2d485b509469f6b58b36654b2ee71d97f8c6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:16:35 +0000 (14:46 +0530)]
Refactored as per given comment
Removed exception handling fixes
Change-Id: Ie5a89783a63ebcf4b404db4f2b8be2c7b2140e50
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:54:18 +0000 (17:24 +0530)]
Fixed sonar issues - ComputeManagerImpl
Fixed all sonar issues
Change-Id: I04a06aadcf5b142334f571949b22778fa393fcc8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 11:46:54 +0000 (17:16 +0530)]
Fixed sonar issues - ComponentManagerImpl
Fixed all sonar issues
Change-Id: I2cc957cea740c2410c6b5d98e3335a3b1c1684e1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:48:42 +0000 (11:18 +0530)]
Fixed sonar issues - NotSupportedHeatOnboardMethod
Fixed all sonar issues
Change-Id: I877e1bdccf63a20a618dabfa9176d94cf023d2b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 05:18:24 +0000 (10:48 +0530)]
Fix sonar issues
Removed default constructor and changed few access modifier
Change-Id: Ibc669a1e8973fd6d7f90e474554b4701d1db4c57
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 08:24:27 +0000 (13:54 +0530)]
Fix sonar issues - TranslationContext
Code refactor and variable name change
Change-Id: I528be906feb5255d1b34ed30c7a287ae0d6bb29c
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 12:24:00 +0000 (14:24 +0200)]
Sonar issue Dix - Session is closeable
Cassandra session is closeable and should be protected by try block
Issue-ID: SDC-801
Change-Id: Ib2cc178e029dce1915e2931fe58e4a5d6527dd5f
Signed-off-by: shrek2000 <orenkle@amdocs.com>
sheetalm [Wed, 27 Dec 2017 10:14:02 +0000 (15:44 +0530)]
Fixed sonar issues ToscaFileOutputServiceCsarImpl
Remove unwanted parenthesis. Corrected Copyright
Change-Id: If7cb2a722aa486156d6dc2c1fb90877d0442b3a6
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:41:01 +0000 (16:11 +0530)]
Fixed sonar issues - DeploymentFlavorManagerImpl
Fixed all sonar issues
Change-Id: Ied0cf9f1d5aac4fb97f7fc09bf3233cb5304c4c3
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 10:16:26 +0000 (15:46 +0530)]
Fixed sonar issues - OrchestrationProcessFactory
Fixed all sonar issues except exception handling
Change-Id: Id1ecf35c157be3c1c9c3f5614bd97b5f8c856e5b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:58:38 +0000 (15:28 +0530)]
Fixed sonar issues - OrchestrationTemplateProcess
Fixed all sonar issues
Change-Id: I9f706783dfc8ce794b018c3f65a78754e43e9dc0
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 09:43:06 +0000 (15:13 +0530)]
Fixed sonar issues - OrchestrationTemplateProcess
Fixed all sonar issues
Change-Id: Ib6664ac0837ffe83dbdf9afa7d0f6f0dc53e853f
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 07:31:30 +0000 (13:01 +0530)]
Fixed sonar issues - CSARConstants
Fixed all sonar issues
Change-Id: Ia0db69f41abe5557faf1e845590ba98f667bea1e
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:50:50 +0000 (11:20 +0530)]
Fixed sonar issues - OnboardingMethodErrorBuilder
Fixed all sonar issues
Change-Id: Iec00a6d2b8028861fdab6e34e17d421fe3de1334
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:45:13 +0000 (11:15 +0530)]
Fixed sonar issues - ImageErrorBuilder
Fixed all sonar issues
Change-Id: I1a4f289524425999f019817cbc8df060d83e252b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:49:03 +0000 (12:19 +0530)]
Fix sonar issues - ResourceWalker
Code refactor and Javadoc
Change-Id: Ic14f3fe0cc8e1903ec3ec73b9a6b63a694e0db81
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:35:52 +0000 (15:05 +0530)]
Fixing sonar qube issues
Added Override annotation to method and removed runtime exception from method specification.
Change-Id: I12640d880c262fc301cafe8ede228e2a4772af88
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
shrikantawachar [Wed, 27 Dec 2017 09:21:38 +0000 (14:51 +0530)]
Fixing sonar qube issues
Fixed critical , major , minor issues in DefaultOutput class. Updated license header.
Change-Id: Ie79498108433c5cc16a3adb04c6f6072724d381d
Issue-ID: SDC-343
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
ojasdubey [Wed, 27 Dec 2017 09:12:51 +0000 (14:42 +0530)]
Sonar fixes for module - Configuration mgmt api
1. Fixed major sonar violations configuration management api module
Change-Id: I83863213e35cf092ffd1c1ff84f408318d5ce8e9
Issue-ID: SDC-343
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
Michael Lando [Wed, 27 Dec 2017 08:20:55 +0000 (10:20 +0200)]
sonar plug in test
Change-Id: I22f2680267edf4dabe21dd6736fa71f88000628c
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
shrek2000 [Wed, 27 Dec 2017 08:10:56 +0000 (10:10 +0200)]
Avoid Null Pointer
Change-Id: Ie6f78934a1c6407a05bd988fb234bf5662fb26e8
Issue-ID: SDC-799
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Idan Amit [Tue, 26 Dec 2017 16:01:01 +0000 (18:01 +0200)]
Fix documentation offered APIs
Replace the Read the Docs offered APIs to show the correct swagger.json data
Change-Id: Ife2fddca2646a169d538ded5d84f0afbec104184
Issue-ID: SDC-754
Signed-off-by: Idan Amit <ia096e@intl.att.com>
mojahidi [Wed, 27 Dec 2017 05:56:38 +0000 (11:26 +0530)]
Fixed sonar issues -NicInternalNetworkErrorBuilder
Fixed all sonar issues
Change-Id: I206a6529b85c501f06747178ff0571b7547428ad
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 07:40:11 +0000 (09:40 +0200)]
Avoid Null Pointer
Change-Id: I91eb26e842495271017d0c918bdae81d03c192f2
Issue-ID: SDC-797
Signed-off-by: shrek2000 <orenkle@amdocs.com>
mojahidi [Wed, 27 Dec 2017 08:50:14 +0000 (14:20 +0530)]
Fixed sonar issues - OrchestrationTemplateFileHand
Fixed all sonar issues
Change-Id: Ieece2d0e081a918e841e8ecbaf2b6af1a5d0f3b8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Wed, 27 Dec 2017 06:13:21 +0000 (11:43 +0530)]
Fix sonar issues
Modified access modifier and few refactor
Change-Id: I9386cce2dd90c411a262b3dbc0b95525dd1362c5
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Wed, 27 Dec 2017 07:28:58 +0000 (12:58 +0530)]
Fixed sonar issues - OnboardingManifest
Fixed all sonar issues
Change-Id: I7f07c7dba6713e76b24ad5bb4bf994a867769edc
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 27 Dec 2017 05:53:59 +0000 (11:23 +0530)]
Fixed sonar issues - DeploymentFlavorErrorBuilder
Fixed all sonar issues
Change-Id: I528de8e970f40b03af183f499bd9ff61792c174a
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talio [Wed, 27 Dec 2017 08:40:47 +0000 (10:40 +0200)]
fix TOSCA structure tree
when uploading a csar with two different directories that share the same name, the files structure that appears on the validation screen shows all of the files written under the same directory. this issue got fixed
Change-Id: I6da7399271fa1cde384f6feb51d60724584aa8f9
Issue-ID: SDC-535
Signed-off-by: talio <tali.orenbach@amdocs.com>
ojasdubey [Wed, 13 Dec 2017 10:53:43 +0000 (16:23 +0530)]
Simplified the return condition
Note: Sonar violations will be handled as a separate
task
Change-Id: I862247f5c693f4d64dff4ce18f2f71e42c85355a
Issue-ID: SDC-749
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
shrek2000 [Wed, 27 Dec 2017 08:32:14 +0000 (10:32 +0200)]
add private constructor
Change-Id: I89c40a4e566fcc00de2b3e9b49def9b04c366d24
Issue-ID: SDC-793
Signed-off-by: shrek2000 <orenkle@amdocs.com>
mojahidi [Wed, 27 Dec 2017 06:34:55 +0000 (12:04 +0530)]
Fixed sonar issues - NicManagerImpl
Fixed all sonar issues
Change-Id: Ic56ea70826845f94a3a8d83193fc75f1179bb62b
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
Michael Lando [Tue, 26 Dec 2017 17:14:02 +0000 (19:14 +0200)]
sonar plug in fix
Change-Id: Ib8fdef1f537b93494402aece3e145ff716363b68
Issue-ID: SDC-776
Signed-off-by: Michael Lando <ml636r@att.com>
mojahidi [Tue, 26 Dec 2017 14:44:32 +0000 (20:14 +0530)]
Fixed sonar issues - ComputeErrorBuilder
Fixed all sonar issues
Change-Id: If38e9ec81c72da6a96e9d0c12312416b239c2d02
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 14:40:02 +0000 (20:10 +0530)]
Fixed sonar issues - ComponentDependencyModel
Fixed all sonar issues
Change-Id: I4469b63b6a2291a7780e591edda36827c7bf51a1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 14:46:50 +0000 (20:16 +0530)]
Fixed sonar issues - DeleteNicErrorBuilder
Fixed all sonar issues
Change-Id: I5a71e83bce19bff06f6d9d7609c3b959abcda066
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 09:22:15 +0000 (14:52 +0530)]
Fix sonar issues
Argument name change and no-op comment
Change-Id: I3087310fe8dfedadbeac8408051fded0225838f2
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:20:48 +0000 (12:50 +0530)]
Fixed sonar issues - VendorLicenseManagerImpl
Refactored as per given comment
Change-Id: I92ec3c5a0152a625c1cad33ef2a92292b10977b2
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 09:11:57 +0000 (14:41 +0530)]
Fix sonar issues
Code correction as per suggestion
Change-Id: Ia7772c1f257b90fc38ff4b12ee71b37354f7606b
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:09:34 +0000 (12:39 +0530)]
Fixed sonar issues - NovaServerGuideLineValidator
Fixed all sonar issues
Change-Id: I5152c860c925ce0532d1b5053a3738d82e1bfafe
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 13:44:23 +0000 (19:14 +0530)]
Fix sonar issues
Removed commented code, and refactor
Change-Id: I3cb107ab3931e323dd11c32c8285f871e5082531
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:34:17 +0000 (17:04 +0530)]
Fixed sonar issues - HeatResourceValidator
Done refactoring as per given comment
Change-Id: Id1cd659af6ddd9e24d281a1bb0d1ae9431bcaf98
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
ojasdubey [Wed, 13 Dec 2017 09:52:01 +0000 (15:22 +0530)]
Update Global Types for TOSCA Import
Migrated ONAP specific types to a new folder
Change-Id: I992a12ac4913c6df5ad616b8d32ecdd706682102
Issue-ID: SDC-749
Signed-off-by: ojasdubey <ojas.dubey@amdocs.com>
sheetalm [Tue, 26 Dec 2017 07:59:08 +0000 (13:29 +0530)]
Fixed sonar issues - ToscaNodeType
Adding private constructor. Making constant final. Corrected copyright
Change-Id: I025aaddbae4133a2bd0b4bba450726a166ebeb1a
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
mojahidi [Tue, 26 Dec 2017 07:13:36 +0000 (12:43 +0530)]
Fixed sonar issues - LimitErrorBuilder
Fixed all sonar issues
Change-Id: I6243f40a4bf400f834166f813154455cae9b7ab1
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
talig [Tue, 26 Dec 2017 07:22:12 +0000 (09:22 +0200)]
Add Item Manager and Dao impl unit tests
Change-Id: I30df90a7ca543195d286f322e8bfa52ffabca849
Issue-ID: SDC-779
Signed-off-by: talig <talig@amdocs.com>
siddharth0905 [Tue, 26 Dec 2017 07:07:18 +0000 (12:37 +0530)]
Fix sonar issues
Added static inner class for initializing system prop
Change-Id: I63c23640058a68c7f8d228a2a509d1b440fd20e6
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:40:29 +0000 (12:10 +0530)]
Fixed sonar issues - ContrailServiceTemplate
Fixed all sonar issues
Change-Id: I2ecf439dac9e180fd1640c53abb0e15991434704
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:43:02 +0000 (12:13 +0530)]
Fixed sonar issues - NeutronPortNamingConvention
Fixed all sonar issues
Change-Id: Ibc328c6e7d7d6e71837107d34dc24731735db9d6
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Tue, 26 Dec 2017 06:31:11 +0000 (12:01 +0530)]
Fixed sonar issues - ContrailServiceInstance
Fixed all sonar issues
Change-Id: Ia1f1f73dd5c0d7f6151b9cab91a3bcb11bd787ed
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:41:31 +0000 (11:11 +0530)]
Fixed sonar issues - ToscaExtensionYamlUtil
Introduced new variable instead of using parameter. Added Copyright
Change-Id: I8f7ff38c987acb1d6919c95e4a430df29927c1f9
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:29:42 +0000 (10:59 +0530)]
Fixed sonar issues - FileDataStructureHealer
Remove no arg constructor and unwanted logger. Corrected Copyright
Change-Id: I3417663d57eefe21051ac033415f3364e90351a3
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
sheetalm [Tue, 26 Dec 2017 05:15:35 +0000 (10:45 +0530)]
Fixed sonar issues - Healer
Add functional interface annotation. Corrected Copyright
Change-Id: Ia271a0c335756c8d4369d6921d43c9b9282bd412
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
Michael Lando [Mon, 25 Dec 2017 19:12:47 +0000 (21:12 +0200)]
fix licensing issues
in the project we are required to have a license text in the root dir.
we have it there and it references both AT&T and Amdocs.
other license were removed and and the text in the package json changed to onap.
Change-Id: I1584d3c56df3287d02f899d45f18ddc3f32d082c
Issue-ID: SDC-737
Signed-off-by: Michael Lando <ml636r@att.com>
Tal Gitelman [Sun, 24 Dec 2017 19:22:51 +0000 (21:22 +0200)]
fix VM grouping
ignoring fixed_ips value when consolidating VMs
Issue-ID: SDC-774
Change-Id: Icdd88af94ff0609f6efabf69b00ed09836270fff
Signed-off-by: talio <tali.orenbach@amdocs.com>
Michael Lando [Mon, 25 Dec 2017 18:07:37 +0000 (20:07 +0200)]
fix pom
Change-Id: I159f5de10d16d018d63c020115a5231716826c99
Issue-ID: SDC-777
Signed-off-by: Michael Lando <ml636r@att.com>
Yuli Shlosberg [Mon, 18 Dec 2017 13:06:12 +0000 (15:06 +0200)]
Kibana and import normative API fix
Change-Id: Ic365ed2122dc16f35b54a064166f4774650c9029
Issue-ID: SDC-265
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
talig [Mon, 25 Dec 2017 13:05:31 +0000 (15:05 +0200)]
Refactor list revisions api
Remove zusammen-api dependency in versioning-api, enhance version zusammen dao impl UT.
Issue-ID: SDC-779
Change-Id: Ic792462eac52f1f5129f92ce80d3deb641c90916
Signed-off-by: talig <talig@amdocs.com>
shrek2000 [Sun, 24 Dec 2017 06:55:14 +0000 (08:55 +0200)]
Import Export Tool add executors
Issue-ID: SDC-773
Change-Id: Id203b671e9af0b3478b75032111b73a509a9a5df
Signed-off-by: shrek2000 <orenkle@amdocs.com>
Tal Gitelman [Sun, 24 Dec 2017 19:22:51 +0000 (21:22 +0200)]
Align configuration files after 1802E sync
Change-Id: Ic25c0d6db92d82d52d9784ee8ec7065a710942ca
Issue-ID: SDC-764
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
Michael Lando [Sun, 24 Dec 2017 18:23:35 +0000 (20:23 +0200)]
soner enable fix
Change-Id: Ibcc38fd80f2cd3470db461fcc434760925a93a9b
Issue-ID: SDC-777
Signed-off-by: Michael Lando <ml636r@att.com>
siddharth0905 [Wed, 13 Dec 2017 12:06:42 +0000 (17:36 +0530)]
Fix sonar issues
Rearranged the code
Change-Id: Ic08659d8c56aec1a001a2e3e1de2f8e200a10a4e
Issue-ID: SDC-343
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:26:49 +0000 (10:56 +0530)]
Fixed sonar issues - NovaServerGroupResourceValid
Fixed all sonar issues
Change-Id: I4eb6f2923e9b2605e048d4b8ad720bf8bd05c6c9
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:33:21 +0000 (11:03 +0530)]
Fixed sonar issues - NovaServerResourceValidator
Fixed all sonar issues
Change-Id: I4ee3a6fdc33a3874ce36d32296ab508ee7089468
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Fri, 22 Dec 2017 05:24:34 +0000 (10:54 +0530)]
Fixed sonar issues - NeutronPortResourceValidator
Fixed all sonar issues
Change-Id: I15953126b263c5746551f024f5ff34ae5848eba8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:53:49 +0000 (17:23 +0530)]
Fixed sonar issues - SharedResourceGuideLineVal
Removed unused method parameters
Used isEmpty() to check whether the collection is empty or not
Change-Id: Id812b2fd4d9b16b399eb9edc0f41e5e0c5d54211
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 12:00:36 +0000 (17:30 +0530)]
Fixed sonar issues - YamlValidator
Removed unused logger
Removed useless parentheses
Change-Id: Ia804c7c461690172f67d610df0bfa46c17525ae8
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:41:11 +0000 (17:11 +0530)]
Fixed sonar issues - HeatValidator
Refactored code to not nest more than 3 if/for/while/switch/try statements
and fixed other sonar violations
Change-Id: I0bcef3c45a894c9e1da9a16ad82b6f5140c789ce
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:23:52 +0000 (16:53 +0530)]
Fixed sonar issues - YamlValidatorUtil
Added private constructor to hide the implicit public one
Change-Id: Iaedd9c5fe8f55025af6b26a41837da2c6e75a5fc
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:29:11 +0000 (16:59 +0530)]
Fixed sonar issues - ForbiddenResourceGuideLineVal
Added license, removed Removed unnecessary cast to Logger
Change-Id: Icf1cac7841e26224573820addd85f3497ee5ae3d
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
mojahidi [Wed, 13 Dec 2017 11:17:59 +0000 (16:47 +0530)]
Fixed sonar issues - ContrailValidator
Removed unnecessary cast to Logger
Removed unused method parameters
Change-Id: I766e6333f8309b83d0725c1c6d25109fb81d47f7
Issue-ID: SDC-343
Signed-off-by: mojahidi <mojahidul.islam@amdocs.com>
sheetalm [Wed, 13 Dec 2017 11:15:34 +0000 (16:45 +0530)]
Fixed sonar issues - ServiceTemplateEntity
Add override annotations to methods. Remove no arg default constructor
Corrected Copyright. Not fixing duplicate code violation since same
code block exists but for different entities
Change-Id: Ib776e280fb7e67100ac75f3312ad0c19dc709d46
Issue-ID: SDC-343
Signed-off-by: sheetalm <sheetal.mudholkar@amdocs.com>
Code Review / sdc.git / log