Bartek Grzybowski [Thu, 14 May 2020 14:38:54 +0000 (07:38 -0700)]
Leverage internal shell runner in bootstrap mode
Use native python modules for file operations
Change-Id: I1ca505f9a891c722c2aace118536fa470bf50b35
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 14 May 2020 12:52:40 +0000 (05:52 -0700)]
Add internal method for shell runner in MassPnfSim module
Since now if module is called in 'debug' mode shell script
is run with trace.
Change-Id: I7bddf6c0583c4b56d4a0c3b5eeb6a78af561891f
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Fri, 15 May 2020 13:23:38 +0000 (06:23 -0700)]
Fix ftp dir permission in sftp-server container
Container entrypoint descendant script in atmoz/sftp:alpine image
is changing mount binded ftp dir owner to 'root' which makes
removing it by 'clean' action not possible hence adding o+w
permission for it.
Change-Id: I0d9339db80c4cd8e31c4368ac63741c531a626fa
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Fri, 15 May 2020 07:57:25 +0000 (00:57 -0700)]
Make the maven image build an independent step
This improves testability as in CI the image build
is done by relevant CI runner from provided POM file
so building from script is redundant.
Updated doc in regard on how to build the image locally.
Change-Id: I7666bc638996c855fed139ee46fcc80379a02f3b
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
mrichomme [Tue, 12 May 2020 06:31:16 +0000 (08:31 +0200)]
Finalize INFO.yaml
Issue-ID: INT-1587
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: Ic386d025fd2b2e9c798a027bb5590c919a850ae3
Bartek Grzybowski [Tue, 12 May 2020 14:52:13 +0000 (07:52 -0700)]
Get and kill ROP_file_creator.sh childs as well
Change-Id: I07393a0f62535563586278d2e8bc8fd6bd9380db
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Mon, 11 May 2020 13:00:00 +0000 (06:00 -0700)]
Get the routine name to call with getattr
Each subcommand has a corresponding method in
MassPnfSim class hence it can be called directly
by it's name.
Change-Id: Id7139a5f96cceac89559bd68d89085130703f4bd
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Mon, 11 May 2020 12:38:08 +0000 (05:38 -0700)]
Move CLI options processing to module level
Change-Id: Ie4c379480e2c641285507173387a770db63458f0
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
colvert [Mon, 11 May 2020 15:50:36 +0000 (17:50 +0200)]
Update INFO.yaml
add new committers:
- Pawel Wieczorek
- Andreas Geissler
- Krzysztof Kuzmicki
Issue-ID: INT-1587
Change-Id: I30f7edd3bf6387ee6e7baa49059c884f589deee6
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Bartek Grzybowski [Mon, 11 May 2020 11:51:37 +0000 (04:51 -0700)]
Improve code testability
A module is created with specific class methods
to perform particular simulator services' lifecycle
operations.
Change-Id: I467360ab304a00f049bf53c3958e42f445f2d75b
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Fri, 8 May 2020 13:26:02 +0000 (06:26 -0700)]
Allow importing the script as module
Improves testability (TBD)
Change-Id: I0c4845f85d14b49b4702270ffad537a19c1c7df7
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Fri, 8 May 2020 11:39:22 +0000 (04:39 -0700)]
Rework input parameters handling
Main input options were turned into subcommands
for improved CLI user experience.
Input parameters handling and validation logic was
moved out of the code to argparse native facilities.
Updated the doc around script usage details.
Change-Id: Ifaa2a0e49f2a0b5b677020307dc74942c422bbe1
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
zhaoliping123 [Fri, 8 May 2020 10:33:20 +0000 (18:33 +0800)]
update vCPE local case
Issue-ID: INT-1355
Change-Id: I3172f1aacebc7f226472dac1259d35c50f520473
Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
Pawel Wieczorek [Fri, 8 May 2020 11:44:30 +0000 (13:44 +0200)]
Add missing dependency for port scanning
Issue-ID: SECCOM-261
Change-Id: Id4d14cf0997310b7e039fe3f5e18ea72a4f3d71c
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Wed, 22 Apr 2020 15:41:29 +0000 (17:41 +0200)]
Use correct nmap filters
Both closed and filtered ports should be droppped from scan results to
maintain compatibility with "check_for_nonssl_endpoints.sh" script.
Issue-ID: SECCOM-261
Change-Id: Ic422bebf6e46bcc42a3e5198e7702bb8b901287f
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Thu, 30 Apr 2020 15:04:51 +0000 (17:04 +0200)]
Exclude code location from code base URL
Python method str.format allows easy templating using substitutions
identified by braces ('{' and '}'). Using two levels of nested
substitutions can be achieved by doubling braces ("{{" and "}}").
Hound configuration creator script was supposed to use two levels of
nested substitutions and still leave braced components within the
templated string for further substitution by the Hound tool. This would
require using multitude of braces which would decrease readability
significantly.
This is why code location template is appended to the code base URL at
the latest.
If there will be need for more levels of nested templates, this code
shall be further refactored to use only named fields, str.format_map()
(available in Python 3.2+) and SafeDict, e.g.
>>> class SafeDict(dict):
... def __missing__(self, key):
... return '{' + key + '}'
...
which would leave braced components within the processed template in
case given key is missing.
Issue-ID: ONAPARC-579
Change-Id: I420d076867aa891edb2a945a8cd58e168c892ac3
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Bartek Grzybowski [Thu, 7 May 2020 11:28:13 +0000 (04:28 -0700)]
Refactor simulator instances IP setting logic
Change-Id: I5bd36b364cd033d0d468c81f345be9255e7adb85
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Wed, 6 May 2020 12:56:20 +0000 (05:56 -0700)]
Fix services IP addresses naming
Use formatted string literals to make the code more
readable.
Change-Id: I712f887d73c29aacc5766052835f377a63e9eb06
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Wed, 6 May 2020 11:42:18 +0000 (04:42 -0700)]
Drop superfluous variables and type casts
Change-Id: Ic8e9eab90c537584b2c771bdeb59c0b43deb992e
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Wed, 6 May 2020 10:37:23 +0000 (03:37 -0700)]
Supress ANSI escape sequences when terminal not detected
This prevents obscured output when redirecting output to
a file descriptor.
Change-Id: Ie56b6f65b1d2adffc69d3f75a9c8f98c0444faa8
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Lukasz Rajewski [Wed, 29 Apr 2020 16:19:38 +0000 (18:19 +0200)]
Fixed vFWDT do after modifications in OOF for policy
Modified description of procedure to upload polcies
used for TD procedure and OOF.
Change-Id: I6e3760f2d2308a36388971e66280df3d3d35f224
Issue-ID: INT-1277
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
jhh [Thu, 7 May 2020 14:02:58 +0000 (09:02 -0500)]
Add policy and sdc staging images overrides
Issue-ID: INT-1585
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia2682bc293ea403b56d3f4d27d6a1c219e6e90eb
Bartek Grzybowski [Tue, 5 May 2020 15:54:37 +0000 (08:54 -0700)]
Make script verbosity adjustible
Adds '--verbose' option and leverages 'logging' module
facilities.
Change-Id: I9b079c476949788678167afb1ed115ad4490d99c
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Tue, 5 May 2020 11:27:25 +0000 (04:27 -0700)]
Add input opts description in usage synopsis
Change-Id: I43b1c47509afef0f25176e244ab2f6f565afbc3b
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Tue, 5 May 2020 10:54:01 +0000 (03:54 -0700)]
Leverage ArgumentParser facilities for input options validation
The hassle of casting and validating input options values is moved
from the script logic directly into the ArgumentParser's object
instantiation.
Change-Id: I79ed80286d1219f841d496538acdc50d2113d723
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Tue, 5 May 2020 10:50:38 +0000 (03:50 -0700)]
Add helper functions for input options validation
Change-Id: I0c8cd452fbf740f3b1c7988bf7aa7341a747c75e
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 30 Apr 2020 14:11:59 +0000 (07:11 -0700)]
Rephrase the argparse arguments help messages
Show usage if no option provided.
Change-Id: I1ed01464f4b689e6b716887e7719e8de6c0f1e42
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 30 Apr 2020 14:05:24 +0000 (07:05 -0700)]
Kill the 'sleep' process as well
ROP_file_creator.sh spawns 'sleep' cmd as a child
hence it needs to be killed as well on clean up.
Change-Id: Ic2007e710b6efa0028ebd239f26b7eff6a9e04ea
Issue-ID: INT-1577
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
ebo [Tue, 28 Apr 2020 23:18:17 +0000 (00:18 +0100)]
pnf-sw-upgrade: fix lock-protected update of yang module
The update must be scoped by a lock on yang module
Other changes:
- 'action' field no longer deleted; handling CREATED/MODIFIED events on
this field
- Configurable delay on timed-transitions via SWUG_TIMED_TRANSITION_TO
environment variable
Issue-ID: INT-1516
Change-Id: I22fb7b558ae371b6cff487633eae606f8fe535e1
Signed-off-by: ebo <eliezio.oliveira@est.tech>
zhaoliping123 [Thu, 30 Apr 2020 02:12:26 +0000 (10:12 +0800)]
update the integration doc for vCPE
Issue-ID: VFC-1668
Change-Id: Id66215e9b12a5aa5ac8d99ab734bd51c0bb3b1fc
Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
mrichomme [Thu, 30 Apr 2020 07:10:49 +0000 (09:10 +0200)]
Add csa as binary in .gitattributes
Issue-ID: INT-1572
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: If307c3028372fc729aa848ff8d2b4042442aa313
Signed-off-by: mrichomme <morgan.richomme@orange.com>
zhaoliping123 [Wed, 29 Apr 2020 11:38:08 +0000 (19:38 +0800)]
update the integration doc for vCPE
Issue-ID: VFC-1668
Change-Id: I5fc41873f7a31e4c67669ea8bb07b674bc434cec
Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
zhaoliping123 [Fri, 24 Apr 2020 10:11:45 +0000 (18:11 +0800)]
update docs_vCPE_tosca_local.rst
Issue-ID: INT-1285
Change-Id: I6a365b56207ae3d21e8a6601f1110914d841160c
Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
Lukasz Rajewski [Mon, 27 Apr 2020 19:30:24 +0000 (21:30 +0200)]
Documentation for vFW In-Place Upgrade with TD
The documentation for vFW Traffic Distributino use case
evolves to vFW InPlace Upgrade with TD one. There is
changed description of the use case purpose, the workflow,
the configuration procedure and information about the
way of testing.
Change-Id: I1e68d46871864b4e65df553355b3a11d86b4c9cb
Issue-ID: INT-1277
Signed-off-by: Lukasz Rajewski <lukasz.rajewski@orange.com>
mrichomme [Mon, 27 Apr 2020 08:10:20 +0000 (10:10 +0200)]
Exclude VFC-redis from xfail list
Issue-ID: INT-1564
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: I32d9e25e4d4d0bfab7fdfa5979db266a0826604c
Signed-off-by: mrichomme <morgan.richomme@orange.com>
stark, steven [Tue, 21 Apr 2020 22:28:13 +0000 (15:28 -0700)]
[INT] updating aks install w/ master pass
- Also updating openstack cli to py3 to fix import issues
Issue-ID: INT-1557
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I99cbc68614e0fcc8fd0572fd7c44c7cd431b215b
zhaoliping123 [Wed, 22 Apr 2020 03:52:56 +0000 (11:52 +0800)]
Add vcpe tosca local mode case
- fix json errors
- fix not related rst error
(due to a broken link as jira.opnfv.org is no more responding)
Issue-ID: INT-1285
Change-Id: I733a491c4204334fc532abcf9dbbdc2226900d5b
Signed-off-by: zhaoliping123 <zhaoliping@chinamobile.com>
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Bartek Grzybowski [Mon, 20 Apr 2020 13:41:04 +0000 (06:41 -0700)]
Leverage pytest parametrize mark in test_rest_api_endpoints
Change-Id: Ia29f79227e21e623489a7b340496f18def5f7a52
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Mon, 20 Apr 2020 12:21:20 +0000 (05:21 -0700)]
Leverage pytest parametrize mark in test_bad_prefix test
Change-Id: I0c0ea8612e0f0ac6b2198dc78908bd604f5ad61c
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Mon, 20 Apr 2020 11:39:43 +0000 (04:39 -0700)]
Leverage pytest parametrize mark in test_bad_moi_class test
Change-Id: I7218c5ca61669197d1e79189e841b0062524c02d
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Mon, 20 Apr 2020 11:01:10 +0000 (04:01 -0700)]
Refactor test_unauthorized() to leverage pytest parametrize mark
Change-Id: I52079b276332c0bf2ffcea047ab8129066aff185
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Marco Platania [Mon, 20 Apr 2020 13:06:34 +0000 (09:06 -0400)]
Resize CLAMP picture
Issue-ID: INT-1536
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: I27a213493377c4af80f914f3d8983b6d37ee6da1
ebo [Sun, 19 Apr 2020 00:33:21 +0000 (01:33 +0100)]
netconf-pnp-simulator: fix sysrepod crash on TLS reconfig
The crash was caused by:
- the '--permanent' option while updating the ietf-keystore by
sysrepocfg
- missing some Yang modules on sysrepo installation
Other changes:
1. Added TLS integration tests, including reconfiguration
2. reconfigure-*.sh are now synchronous, only returnig after restart is
completed
Issue-ID: INT-1516
Change-Id: Iddc03fc968aaab60931596045437ba0c78448b08
Signed-off-by: ebo <eliezio.oliveira@est.tech>
Marco Platania [Thu, 16 Apr 2020 20:09:55 +0000 (16:09 -0400)]
Fix link in RST file for Scale Out doc
Issue-ID: INT-1536
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: Ic16b339332033cd487cf19458464c1dc86c61d65
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Bartek Grzybowski [Thu, 16 Apr 2020 11:11:07 +0000 (04:11 -0700)]
Add test to verify bad API prefix handling by the service
Functional test for verifying that the service handles
bad API prefix in URI string properly and returns appropriate
response to the client.
Change-Id: I5e5e8a9dcd6fe05bd2b4536790d16e825aa21679
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 16 Apr 2020 11:04:12 +0000 (04:04 -0700)]
Add test to verify bad MOI handling by the service
Functional test for verifying that the service handles
bad MOI class in URI string properly and returns appropriate
response to the client.
Change-Id: I606aaba5c400f81e8142a34f250bc249251feaf7
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 16 Apr 2020 10:55:21 +0000 (03:55 -0700)]
Add test to verify unauthorized requests
Functional test for verifying that the service forbids
API access with proper http code and message should
the client provide wrong auth credentials.
Change-Id: I78d5f050e99c23fd7116468ff007078b3cd56987
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 16 Apr 2020 10:28:14 +0000 (03:28 -0700)]
Fix invalid prefix check handling
Should the URI prefix length in the request be incorrect
and not contain two "/" the service would fail with "empty
response" on client side due to unhandled "list index
out of range" in the server process while trying to get
the idName from pathlist[4] which throws IndexError.
Prefix validation, id and class variable assignment are
wrapped up in try-except clause to evaluate the prefix check
correctly, catch the exception and return appropriate response
to the client.
Change-Id: If6333228fbdd3a8075ade55436c3ca9bb8a97caa
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Thu, 16 Apr 2020 08:35:48 +0000 (01:35 -0700)]
Return http 404 for wrong prefix, not 401
The correct http code for wrong REST API url should
be http "404 Not Found", not "401 Unauthorized".
Change-Id: I78710fcd4c43926dbba3227c4099bf6239095f19
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Wed, 15 Apr 2020 11:48:16 +0000 (04:48 -0700)]
Move tests to their own directory
File layout was also restructured for better
readability.
Change-Id: Id1cba755127319c45ec50b08d12daa543c8c9ae5
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Wed, 15 Apr 2020 11:06:39 +0000 (04:06 -0700)]
Add tox runner for pytest in prov-mns-provider
Pytest setup as entrypoint to gating job in CI.
Change-Id: If052af0f7c8272844f644cb3789dbc3a8451c629
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Tue, 14 Apr 2020 15:49:19 +0000 (08:49 -0700)]
Extend unit tests for provisioning management service
This adds additional unit tests for the service provider for
PATCH and DELETE request methods.
Change-Id: If0cce9c713f2999c859910661308c24ac68f04d6
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartek Grzybowski [Tue, 14 Apr 2020 14:59:00 +0000 (07:59 -0700)]
Add unit tests for provisioning management service
This adds pytest based unit tests for the service provider.
Testing PUT and GET requests is covered within this patch.
Change-Id: Id9bcb870b032c6fce64985a5fd501bbd44031f50
Issue-ID: INT-1529
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
mrichomme [Mon, 13 Apr 2020 16:46:35 +0000 (18:46 +0200)]
Fix rst errors
- Modify the linter to use sphinx linters (no coala bean)
- Fix all broken links
- fix minor rst issue
- Add regex in ignore link (for ONAP URL and frankfurt doc)
The rst target defined in tox will execute 3 steps:
- local build of the documentation
- check of the url
Note 1: for the moment the Warning have not been turned into Error
Note 2: frankfurt exeption shall be removed when frankfurt branch is available
Issue-ID: INT-1523
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: I6d7ad9d293a1b5c01f05a021d9a6f3767d04e62f
Signed-off-by: mrichomme <morgan.richomme@orange.com>
ebo [Sat, 11 Apr 2020 00:34:47 +0000 (01:34 +0100)]
netconf-pnp-simulator: enable NETCONF send/recv message logging
to aid troubleshooting integration with OpenDaylight
- Add more integration tests
- Defaults to generic subscriber
Issue-ID: INT-1516
Change-Id: Ib5bbf4cdbba6cdfee901f6c07dfa195a21cd8bbb
Signed-off-by: ebo <eliezio.oliveira@est.tech>
Bartek Grzybowski [Tue, 14 Apr 2020 09:17:56 +0000 (11:17 +0200)]
Upgrade netconf-pnp-simulator image tag to 2.8.2
Change-Id: I430b3c8743d103f5e4bb6396a151495cc31843d6
Issue-ID: INT-1508
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
mrichomme [Fri, 10 Apr 2020 16:22:59 +0000 (18:22 +0200)]
Fix integration markdown errors for linter
Issue-ID: INT-1523
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: I2be0865395b12e1f277834b0c096f5d183cb5056
Signed-off-by: mrichomme <morgan.richomme@orange.com>
ebo [Fri, 10 Apr 2020 20:17:17 +0000 (21:17 +0100)]
netconf-pnp-simulator: normalized image reference
Required change for the forthcoming fix on tox execution in
ci-management/jjb/integration/integration-docker.yaml
Issue-ID: INT-1124
Change-Id: I70c3351e5cf691a9eaeb7b49ec276d825016e0fa
Signed-off-by: ebo <eliezio.oliveira@est.tech>
ebo [Fri, 10 Apr 2020 17:51:59 +0000 (18:51 +0100)]
netconf-pnp-simulator: fix invalid ref to libssh v0.8.8
This version was upgraded to 0.8.9 on 2020-04-09.
Fortunately the new 0.9.4 fixes the bug that was forcing us to use
the old 0.8.x
Issue-ID: INT-1124
Change-Id: I6dacac8925af047d2e5342a76da6eb221074ddd9
Signed-off-by: ebo <eliezio.oliveira@est.tech>
mrichomme [Thu, 9 Apr 2020 16:38:07 +0000 (18:38 +0200)]
WIP: Add rst and md linters in tox
Issue-ID: INT-1523
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: Ifcce4fa5985df52fd66414f5842f50e21a79006a
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Dongho Kim [Thu, 9 Apr 2020 17:52:13 +0000 (10:52 -0700)]
Update A1 Adaptor section to user guide
Change-Id: I6b1d1173bcb2c9e190584445fde561b204e8664c
Signed-off-by: Dongho Kim <dk5913@att.com>
Issue-ID: INT-1503
mrichomme [Fri, 10 Apr 2020 07:44:09 +0000 (09:44 +0200)]
remove CLI from https xfail list
Even if CLI got a NO GO for frankfurt, docker update is planned
to fix security issues for frankfurt
As a consequence, CLI must be removed from the xfail list
Issue-ID: INT-1480
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: I78dccd2bdabe05515ff8ab64d30e9e5d6f97e74b
ebo [Wed, 8 Apr 2020 11:32:14 +0000 (12:32 +0100)]
Update pnf-sw-upgrade module to latest engine v2.8.1
- Using loguru to follow new recommend standard
- Renamed Yang model filename to comply with
https://tools.ietf.org/html/rfc6020#section-5.2
- Renamed initialization data to reflect the target datastore
Issue-ID: INT-1516
Signed-off-by: ebo <eliezio.oliveira@est.tech>
Change-Id: Ifde9e832b6a308dc918e3a84e03bfd43ad0f9b63
Aric Gardner [Thu, 9 Apr 2020 19:26:09 +0000 (12:26 -0700)]
Automation adds docs_postman.rst
Issue-ID: CIMAN-376
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I253073cc5d5a589b4225a489906588cedd8c49e3
Bartek Grzybowski [Thu, 9 Apr 2020 09:07:21 +0000 (11:07 +0200)]
Remove orphaned entry for pnfsimulator from Coala config
Change-Id: Ib506dbc82e86ec02f8b1b118c3b9dfcf3209e7c2
Issue-ID: INT-1517
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Bartosz Gardziejewski [Wed, 8 Apr 2020 07:47:06 +0000 (09:47 +0200)]
Remove old PNF simulator
Issue-ID: INT-1517
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
Change-Id: I235b0fdf12b265a256c371126e218826e74a9133
LF Jenkins CI [Tue, 7 Apr 2020 20:22:01 +0000 (20:22 +0000)]
Automation adds release-notes.rst
Add _release_notes hook to allow automation.
Fix non valid release notes characters in content.
Issue-ID: CIMAN-376
Change-Id: If2f0b5ae09d97a282d9acfd3c32971148d674a79
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
LF Jenkins CI [Tue, 7 Apr 2020 06:45:04 +0000 (06:45 +0000)]
Automation adds index.rst
Issue-ID: CIMAN-376
Change-Id: I1d2fc58d6f559471fffeb23c398d9903923d2eeb
Signed-off-by: lf-jobbuilder <releng+lf-jobbuilder@linuxfoundation.org>
ebo [Fri, 3 Apr 2020 14:24:15 +0000 (15:24 +0100)]
netconf-pnp-simulator: convenient TLS and SSH configuration
- Simple SSH and TLS configuration. Instead of specific Netopeer2
XML configuration files, the user only needs to provide:
For SSH: id_XXX.pub
For TLS: server_key.pem, server_cert.pem, and ca.pem
- SSH and TLS can be reconfigured at runtime by running
/opt/bin/reconfigure-ssh.sh and /opt/bin/reconfigure-tls.sh respectively
- Improved log readability by using zlog (on C applications) and loguru
for Python
See the updated documentation under ../docs for more information.
Issue-ID: INT-1516
Change-Id: I21052d2524f0610c6197875a544113cce1a02787
Signed-off-by: ebo <eliezio.oliveira@est.tech>
Bartek Grzybowski [Mon, 6 Apr 2020 12:39:13 +0000 (05:39 -0700)]
Remove deprecated options from virtualenv invocation
--no-site-packages and --distribute are marked DEPRECATED
and retained only for backward compatibility so removing.
Change-Id: I3cc66b5c09363d5b982537cc28b8f66609743121
Issue-ID: INT-1508
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
wangyaoguang [Wed, 1 Apr 2020 13:12:21 +0000 (13:12 +0000)]
Add docs for PNF Software upgrade
It contains documentation for two sub-scenarios of PNF Software upgrade,
enhancement on PNF SW upgrade using ansible and with netconf/yang interface with EM.
Issue-ID: INT-1209
Signed-off-by: wangyaoguang <sunshine.wang@huawei.com>
Change-Id: I6e1ad2464d9f0d607d5f7f14d8fb1c51afc90814
Marco Platania [Thu, 2 Apr 2020 13:46:23 +0000 (09:46 -0400)]
Update SO and VID docker version
Issue-ID: INT-1462
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: I49d3fc837e58c9e2f8b879c04c84317e8bd320ba
wangyaoguang [Thu, 2 Apr 2020 07:57:30 +0000 (07:57 +0000)]
add docs for 5G NRM Configuration
Documentation for 5G NRM CM
Issue-ID: INT-1514
Signed-off-by: wangyaoguang <sunshine.wang@huawei.com>
Change-Id: I56b579abaf18897961b1eefa4aa4b8490979bf87
Bartek Grzybowski [Thu, 2 Apr 2020 11:14:06 +0000 (13:14 +0200)]
Upgrade netconf-pnp-simulator tag to 2.6.2 for netconf-pnp-pmsh
Tag 2.6.1 is no longer available.
Change-Id: I5a2cb51d21b4c6d75aff387e87976ede184a92b2
Issue-ID: INT-1508
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Marco Platania [Wed, 1 Apr 2020 13:41:06 +0000 (09:41 -0400)]
Update SDC and Portal docker image version
Issue-ID: INT-1462
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: Ib50de36def25dd4b4330c8a5bcccf453b767efe8
Bartek Grzybowski [Wed, 1 Apr 2020 12:09:26 +0000 (14:09 +0200)]
Upgrade netconf-pnp-simulator tag to 2.6.2 for ems-netconf-swm
Tag 2.6.1 is no longer available.
Change-Id: Ia2ce3f2d1d25e5f941cd2b49ed213445960e8a04
Issue-ID: INT-1508
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
Krzysztof Opasiak [Tue, 31 Mar 2020 13:21:02 +0000 (15:21 +0200)]
Grant a waiver for SO 30277
As discussed during SECCOM call on 31.03.2020 SO team pushed hard to
finialize AAF integration in F but failed due to AAF issues.
Per TSC decision they should be granted a waiver as a project which
has been impacted by AAF
Issue-ID: OJSI-138
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I46028f2d3de80f5ca7dc274cf6af26000b766f32
mrichomme [Thu, 19 Mar 2020 18:02:41 +0000 (19:02 +0100)]
fix integration doc warning
Issue-ID: INT-1490
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Change-Id: I9153da660ae469c0bd3ed51cfebd912b6e4b9bf2
Signed-off-by: mrichomme <morgan.richomme@orange.com>
Pérez Caparrós David, INI-ONE-MBL-MEE [Thu, 26 Mar 2020 11:17:50 +0000 (12:17 +0100)]
Update BBS use case documentation
BBS use case documentation needs additional updates in Frankfurt release
Issue-ID: INT-1444
Signed-off-by: Pérez Caparrós David, INI-ONE-MBL-MEE <David.PerezCaparros@swisscom.com>
Change-Id: I5d44898f4e7d7d628181a0140b7b13d8b57a8170
Marco Platania [Wed, 25 Mar 2020 15:44:09 +0000 (11:44 -0400)]
Set SKIP_LINT=TRUE to speed up installation
Issue-ID: OOM-2335
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: I803781947a9fe84e153cdbd6f94d9f21b8bcdb6f
DarraghEgan [Thu, 19 Mar 2020 15:46:57 +0000 (15:46 +0000)]
[INT-1450] : Documentation of PNF Software Upgrade
This contains documentation for PNF Software Upgrade
using Ansible protocol with EM
Issue-ID: INT-1450
Signed-off-by: Darragh Egan <darragh.egan@est.tech>
Change-Id: Ib5385e690c9f6cff7fc2b2251181054dacba777f
DarraghEgan [Thu, 19 Mar 2020 15:53:54 +0000 (15:53 +0000)]
[INT-1450] : Documentation of PNF Software Upgrade
This contains documentation for PNF Software Upgrade
using Netconf/Yang interface with EM
Issue-ID: INT-1450
Signed-off-by: Darragh Egan <darragh.egan@est.tech>
Change-Id: I8a225b5a4b08de2004ff327148fadfff8976c5de
Bartek Grzybowski [Wed, 25 Mar 2020 10:25:29 +0000 (11:25 +0100)]
Add 'build' target for 'sslendpoints' project
To follow a common protocol of testing Golang based
applications in CI we need a 'build' target for doing
a local (non-docker) build to verify 'go build' routine.
It's however not added to "all" target as that one already
references docker based build by default.
Change-Id: I2e380ef09a1ae18456d7288f853d085617149338
Issue-ID: SECCOM-261
Signed-off-by: Bartek Grzybowski <b.grzybowski@partner.samsung.com>
andreasgeissler [Fri, 13 Mar 2020 14:13:35 +0000 (15:13 +0100)]
corrected the hardcoded DB pod-names
Issue-ID: INT-1484
Signed-off-by: andreasgeissler <andreas-geissler@telekom.de>
Change-Id: I7f1670a79db751087f722a1196e2de23448f7a2a
Pawel Wieczorek [Wed, 18 Mar 2020 15:32:45 +0000 (16:32 +0100)]
Reduce cyclomatic complexity
Moving CSV data conversion and "expected failure" filtering away from
main function made testing these features easier. Utility behaviour
remained unchanged.
Issue-ID: SECCOM-261
Change-Id: I4cabfc7b352434c84a613c02f44af3c9630be970
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Wed, 18 Mar 2020 11:38:30 +0000 (12:38 +0100)]
Add "expected failure" support to non-SSL NodePort scanner
This patch makes scanner compatible with its shell predecessor. The same
"expected failure" list format is used i.e.
# Comment line; will be ignored
SERVICE1 NODEPORT1
SERVICE2 NODEPORT2
Single space character is used as a field separator.
Issue-ID: SECCOM-261
Change-Id: Ieedd4e98a83ffe242c695133fdf7342e17efa9a2
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Fri, 13 Mar 2020 13:14:55 +0000 (14:14 +0100)]
Run port scan
Issue-ID: SECCOM-261
Change-Id: I465282a8793191c45d288284a127e80e1fecf513
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Thu, 12 Mar 2020 17:39:03 +0000 (18:39 +0100)]
Add IP addresses filtering
Each node might be described with 3 types of addresses [1]. Some
providers also use node annotations [2] for assigned addresses.
This patch filters out all IP addresses from nodes list. External IPs
take precedence over internal ones. The first address on the extracted
slice will be later used to run the scan on.
This behaviour could be later modified to e.g. loop over all extracted
IP addresses (if scan fails).
[1] https://kubernetes.io/docs/concepts/architecture/nodes/#addresses
[2] https://github.com/rancher/rke/blob/master/k8s/node.go#L18
Issue-ID: SECCOM-261
Change-Id: Ifd094447f778da378dfe1aee765f552b6ebd669f
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Mon, 23 Mar 2020 15:02:04 +0000 (16:02 +0100)]
Add temporary "make" target for automated testing compatibility
Utility "sslendpoints" and related packages make use of idiomatic Go
testing commands, i.e. go test [./...]. Thanks to Go Modules [1] nothing
else is needed to run internal tests for this tool.
Unfortunately it's not the case for all Go-based Integration tools. In
order to use a single automated verification script in CI additional
"make" target is required. It will provide temporary compatibility layer
with utilities setting up test environment on their own with "make test"
target.
This patch should be reverted upon removal of such cases (currently:
after dropping "../k8s/check" tool in favour of Aquasec solution).
[1] https://blog.golang.org/using-go-modules (see "Adding a dependency"
test execution explanation)
Issue-ID: INT-1498
Change-Id: I14c83f7f193c7688590366db988ff02c13c036a4
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Tue, 25 Feb 2020 12:36:59 +0000 (13:36 +0100)]
Add NodePorts filtering with development environment basis
This patch has not made "sslendpoints" fully compatible with
"check_for_nonssl_endpoints.sh" script yet. It sets up basic development
environment for Golang-based checkers, though.
Tool output will be added to the README after reaching full
compatibility with previous (script) version.
Development environment brought by this patch is heavily based on:
https://github.com/SamsungSLAV/boruta
Issue-ID: SECCOM-261
Change-Id: I8f035b63bea13785c40971ede5fdbbc9b6810168
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Fri, 7 Feb 2020 11:59:32 +0000 (12:59 +0100)]
Increase verifiability of security checks
This patch introduces a series of patches that will provide tools which
will succeed current security check scripts. Its two main reasons are:
* increasing tools verifiability by providing internal tests,
* improving "expected failure" support by suppressing carefully selected
set of special cases.
Each tool will use following directory structure (generated with
"tree -a --charset=ascii" command):
.
`-- check_module
|-- Dockerfile
|-- .dockerignore
|-- .gitignore
|-- go.mod
|-- main.go
|-- Makefile
|-- README
|-- README.rst -> README
`-- submodule
|-- submodule.go
`-- submodule_test.go
This will allow using Go Modules mechanism within its limitations [1]
for "non-go-get-able modules" [2][3][4] - also in case of separating
code into several modules used by multiple "check modules", e.g.
.
|-- common
| |-- common.go
| |-- common_test.go
| `-- go.mod
`-- check_module
|-- go.mod
`-- ...
It would require migration from separate Dockerfiles to a single one
(multi-stage), though.
Provided Makefiles are intended to simplify local development
(Docker-less building) and container images preparation. READMEs clarify
utility requirements and usage - file without extension is for VCS
reference, symlink for proper syntax rendering.
[1] https://github.com/golang/go/wiki/Modules#is-it-possible-to-add-a-module-to-a-multi-module-repository
[2] https://github.com/golang/go/wiki/Modules#can-i-work-entirely-outside-of-vcs-on-my-local-filesystem
[3] https://github.com/golang/go/issues/26645#issuecomment-
408572701
[4] https://www.dim13.org/go-get-cgit
Issue-ID: SECCOM-261
Change-Id: I48eeeda66bd5570d249e96e101e431e6bab75cb3
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
jhh [Thu, 19 Mar 2020 21:31:13 +0000 (16:31 -0500)]
misnaming of pap component
Issue-ID: POLICY-2296
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I3addd7de51fa2ca4b1e76e95a9f0e91d1e1ca3e9
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Huang Cheng [Tue, 3 Mar 2020 09:01:58 +0000 (09:01 +0000)]
Add the provisioning management service provider for 5G NRM CM
Issue-ID: INT-1387
Signed-off-by: Huang Cheng <duke.huangcheng@huawei.com>
Change-Id: I23bda3ec2a31569d4857b2f16b9a607c64abd9f0
Enbo Wang [Thu, 12 Mar 2020 08:49:42 +0000 (16:49 +0800)]
Add script and patch to build CBA file to support PNF SW upgrade
Change-Id: I8b0155a0a6022d7b6d172c1b46d1b7d189fcbe8a
Issue-ID: INT-1210
Signed-off-by: Enbo Wang <wangenbo@huawei.com>
Tomasz Golabek [Fri, 20 Mar 2020 10:49:04 +0000 (11:49 +0100)]
Set of fixes for pnfsimulator startup
* v0.7.7 of netopeer used
* SSLAuthenticationHelper marked as primary bean to avoid duplicated-bean exception
* spring props properly mounted into container
Change-Id: Ib6bb32f32a7f60786901ffbf592b1a26b5cb1cbf
Issue-ID: INT-1320
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
DarraghEgan [Fri, 13 Mar 2020 16:47:55 +0000 (16:47 +0000)]
[INT-1450] : Documentation of PNF Software Upgrade
This contains documentation for PNF Software Upgrade
with direct Netconf/Yang interface with PNF
Issue-ID: INT-1450
Signed-off-by: Darragh Egan <darragh.egan@est.tech>
Change-Id: I58acec3baed757bdc8cad2e2588c560f31c9025c
Pawel Wieczorek [Thu, 19 Mar 2020 10:18:06 +0000 (11:18 +0100)]
Add services with waiver to expected failures list for non-SSL endpoints tests
Issue-ID: INT-1480
Change-Id: Iabd7932e0eb8f8981d064aee0f4d8c44df65a379
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Pawel Wieczorek [Thu, 19 Mar 2020 10:14:18 +0000 (11:14 +0100)]
Filter out only open non-SSL ports
This patch ignores closed and filtered ports from scan results. It is
intended to keep "expected failure" list minimal.
Issue-ID: INT-1480
Change-Id: Idb93cf4e19284bc121aa45ea950d28405c29e222
Signed-off-by: Pawel Wieczorek <p.wieczorek2@samsung.com>
Yaoguang Wang [Thu, 12 Mar 2020 01:39:59 +0000 (09:39 +0800)]
EMS simulator extension to support netconf interaction with CDS
Issue-ID: INT-1211
Signed-off-by: Yaoguang Wang <sunshine.wang@huawei.com>
Change-Id: I5a7724e6cbfab81eeb3299c88f995c3cf9ea71ec
Marco Platania [Fri, 13 Mar 2020 14:34:37 +0000 (10:34 -0400)]
Update image versions in integration override
Issue-ID: INT-1462
Signed-off-by: Marco Platania <platania@research.att.com>
Change-Id: Ib14e88d854bc36c7ca16997a1f26d232bcd97ce4