vid.git
4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Mon, 2 Sep 2019 12:54:07 +0000 (12:54 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Mon, 2 Sep 2019 12:54:04 +0000 (12:54 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Mon, 2 Sep 2019 12:54:00 +0000 (12:54 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoimprove test to verify also serialization 51/94751/1
Eylon Malin [Mon, 2 Sep 2019 11:56:13 +0000 (14:56 +0300)]
improve test to verify also serialization

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Iaff42459fc9bd7d843b21af6d710afc9a194680c

4 years agoadd UT for MsoController.testActivateFabricConfiguration 47/94747/1
Eylon Malin [Mon, 2 Sep 2019 11:29:47 +0000 (14:29 +0300)]
add UT for MsoController.testActivateFabricConfiguration

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Iddecbfef0378a559a34501e15911b350ec0766a0

4 years agoAdd a semicolon at the end of this statement 16/94616/2
anushadasari [Thu, 29 Aug 2019 15:54:47 +0000 (21:24 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: I64c97eaf1877016fe79e6e31caf620f8c99363df
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement 12/94612/2
anushadasari [Thu, 29 Aug 2019 15:27:40 +0000 (20:57 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: If02076cca1cde742aae6e499bc29e92a1aa9b2b6
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement 59/94659/2
anushadasari [Fri, 30 Aug 2019 07:14:01 +0000 (12:44 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: Icfb0b3ce96d9f0137bdd9445173dd31e27e13305
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoRevert "add some UT for MsoBusinessLogicImpl" 41/94741/1
Eylon Malin [Mon, 2 Sep 2019 08:53:54 +0000 (11:53 +0300)]
Revert "add some UT for MsoBusinessLogicImpl"

This reverts commit b2805ebd910ecf9cc49597a52bd8f6e6b18f1d31
Reason for revert: duplicated tests. These scenarios already covered
by another methods in this class.

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I645b770d853dc39947222de5b8332d3e9fd23087

4 years agoMerge "add some UT for MsoBusinessLogicImpl"
Ittay Stern [Sun, 1 Sep 2019 15:29:00 +0000 (15:29 +0000)]
Merge "add some UT for MsoBusinessLogicImpl"

4 years agoFix "old-csars" test: csarWithVnfWithVfModuleInModel 22/94722/3
Eylon Malin [Sun, 1 Sep 2019 11:39:35 +0000 (14:39 +0300)]
Fix "old-csars" test: csarWithVnfWithVfModuleInModel

Issue-ID: VID-378
Change-Id: Icde5058772379f2d48477c05c986f4fe8a30f446
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoadd some UT for MsoBusinessLogicImpl 31/94731/2
Eylon Malin [Sun, 1 Sep 2019 14:26:56 +0000 (17:26 +0300)]
add some UT for MsoBusinessLogicImpl

Add UT for: deleteSvcInstance, deleteVnf, deleteVfModule
Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I838c69ae4d0209fe8d62ada98e06dcc1817a4d88

4 years agoadd UT for NCF model 30/94730/1
Eylon Malin [Sun, 1 Sep 2019 14:08:59 +0000 (17:08 +0300)]
add UT for NCF model

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I4f9eaa8a12770d7afb9b51633e70ff799f670b70

4 years agoadd getNewestModelVersionByInvariant to controller and service 28/94728/2
Eylon Malin [Sun, 1 Sep 2019 13:24:41 +0000 (16:24 +0300)]
add getNewestModelVersionByInvariant to controller and service

Also add testGetActiveNetworkList UT
Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I97c2ae029272aba915d5f9699bccff0eb9d49329
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agohandle non OK response from SDC while getting model 24/94724/1
Eylon Malin [Sun, 1 Sep 2019 12:02:06 +0000 (15:02 +0300)]
handle non OK response from SDC while getting model

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Idc6e587abb24fbec65ed159db7008e50abee2581

4 years agoMerge "add ut getServiceToscaModel rethrow Exception"
Ittay Stern [Fri, 30 Aug 2019 03:19:16 +0000 (03:19 +0000)]
Merge "add ut getServiceToscaModel rethrow Exception"

4 years agoMerge "edit of macro services in new view edit screen"
Amichai Hemli [Thu, 29 Aug 2019 15:37:50 +0000 (15:37 +0000)]
Merge "edit of macro services in new view edit screen"

4 years agoadd ut getServiceToscaModel rethrow Exception 96/94596/1
Eylon Malin [Thu, 29 Aug 2019 14:19:33 +0000 (17:19 +0300)]
add ut getServiceToscaModel rethrow Exception

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ia8a649a281cbc687bbec4f25e6bd67e1681276bc

4 years agoedit of macro services in new view edit screen 83/94583/1
Eylon Malin [Thu, 29 Aug 2019 12:55:20 +0000 (15:55 +0300)]
edit of macro services in new view edit screen

Fix Vid Notion Builder behavior according -
all macro non transport services should open the new view edit screen
Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icd45fcbfcb4bf8928f44f73fb3ddd84ac1f1d341

4 years agoAdd a semicolon at the end of this statement 01/94401/2
anushadasari [Wed, 28 Aug 2019 06:23:15 +0000 (11:53 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: I4d324d96d28a3796b971b83997d72a64ed161ce8
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Thu, 29 Aug 2019 12:14:40 +0000 (12:14 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoMerge "Add a semicolon at the end of this statement."
Ittay Stern [Thu, 29 Aug 2019 12:14:35 +0000 (12:14 +0000)]
Merge "Add a semicolon at the end of this statement."

4 years agoAdd a semicolon at the end of this statement 03/94403/2
anushadasari [Wed, 28 Aug 2019 06:56:19 +0000 (12:26 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: If9e0bba384cd1345e4674e5e06085ba8feb78e39
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement. 04/94404/2
anushadasari [Wed, 28 Aug 2019 07:02:14 +0000 (12:32 +0530)]
Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: I9a80b3c9fd3102f508a33581f57499dba33b51fd
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoadd UT to ToscaParserImpl and fix little bug 77/94577/1
Eylon Malin [Thu, 29 Aug 2019 11:47:01 +0000 (14:47 +0300)]
add UT to ToscaParserImpl and fix little bug

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I5ea0f09c2898c3a7e1db60d37dde754138a86121
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoadd AAITreeNodeUtilsTest 09/94509/2
Eylon Malin [Thu, 29 Aug 2019 09:38:45 +0000 (12:38 +0300)]
add AAITreeNodeUtilsTest

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I74dc26492196c4907e1aae208944c412869eef4e
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agofix url and payload for getting latest model 99/94499/1
Eylon Malin [Thu, 29 Aug 2019 08:40:46 +0000 (11:40 +0300)]
fix url and payload for getting latest model

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I5b2dc7df0202838898ab060a71c144f69a54900f

4 years agoFix legacy region in resume vfModule 35/94435/2 5.0.1
Eylon Malin [Wed, 28 Aug 2019 13:27:42 +0000 (16:27 +0300)]
Fix legacy region in resume vfModule

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Idad1357d8de234ad54716d8d51ac846a426a5258
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Fix resume vfModule"
Ittay Stern [Wed, 28 Aug 2019 11:49:18 +0000 (11:49 +0000)]
Merge "Fix resume vfModule"

4 years agoMerge "Pass optionId in msoParameterList, letting late deconstruction of owner+region"
Amichai Hemli [Wed, 28 Aug 2019 11:34:13 +0000 (11:34 +0000)]
Merge "Pass optionId in msoParameterList, letting late deconstruction of owner+region"

4 years agoFix resume vfModule 26/94426/2
Eylon Malin [Wed, 28 Aug 2019 11:22:10 +0000 (14:22 +0300)]
Fix resume vfModule

Get from AAI lcpCloudRegion and tenantList even when there is homing
data for vfModule, for make resume popup compatible with creationService

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ia57e8e020d2f5373c2b3239b6020a12030deef07

4 years agoChange out-of-the-box config to work on dev's environment 07/94407/1
Ittay Stern [Wed, 28 Aug 2019 07:28:35 +0000 (10:28 +0300)]
Change out-of-the-box config to work on dev's environment

Issue-ID: VID-564

Change-Id: Id9aceb416f7404229a7df1f7ad0caf07882e2051
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoPass optionId in msoParameterList, letting late deconstruction of owner+region 02/94402/1
Ittay Stern [Wed, 28 Aug 2019 06:47:02 +0000 (09:47 +0300)]
Pass optionId in msoParameterList, letting late deconstruction of owner+region

Issue-ID: VID-378

Change-Id: I234bdd6c693c66621f187bb4e7ededd2c0324cac
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Get log-checking remote server by EELF_LOG_CHECKER property"
Amichai Hemli [Tue, 27 Aug 2019 13:17:36 +0000 (13:17 +0000)]
Merge "Get log-checking remote server by EELF_LOG_CHECKER property"

4 years agoGet Sonar report Kotlin, by specifying path to load jacoco xml report 32/94332/1
Ittay Stern [Tue, 27 Aug 2019 09:22:05 +0000 (12:22 +0300)]
Get Sonar report Kotlin, by specifying path to load jacoco xml report

Sonar can't load Kotlin coverage from binary report; see
https://jira.sonarsource.com/browse/MMF-1362

Issue-ID: VID-599

Change-Id: I7ffab337acb83847b3f29f835e25f13ec9daae6c
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoGet log-checking remote server by EELF_LOG_CHECKER property 85/94285/3
Ittay Stern [Mon, 26 Aug 2019 14:18:53 +0000 (17:18 +0300)]
Get log-checking remote server by EELF_LOG_CHECKER property

Issue-ID: VID-378
Change-Id: I393fbd78d6ce17f81676ad95a5b9dab58b828d50
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoget cloudOptionId from getHomingData 25/94325/1
Alexey Sandler [Tue, 27 Aug 2019 06:08:53 +0000 (09:08 +0300)]
get cloudOptionId from getHomingData

Issue-ID: VID-378
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: Ifa5cb0a827161f62b104bf18605531a2ebb29494

4 years agoMerge "Immediately return this expression instead of assigning it to the temporary...
Ittay Stern [Tue, 27 Aug 2019 05:51:51 +0000 (05:51 +0000)]
Merge "Immediately return this expression instead of assigning it to the temporary variable "responseWrapper2""

4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Tue, 27 Aug 2019 03:01:12 +0000 (03:01 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoMerge "Log request-id even when no HttpServletRequest param or no user-session"
Amichai Hemli [Mon, 26 Aug 2019 19:33:07 +0000 (19:33 +0000)]
Merge "Log request-id even when no HttpServletRequest param or no user-session"

4 years agoMerge "Add a semicolon at the end of this statement"
Ittay Stern [Mon, 26 Aug 2019 17:53:47 +0000 (17:53 +0000)]
Merge "Add a semicolon at the end of this statement"

4 years agoMerge "Immediately return this expression instead of assigning it to the temporary...
Ittay Stern [Mon, 26 Aug 2019 17:51:45 +0000 (17:51 +0000)]
Merge "Immediately return this expression instead of assigning it to the temporary variable "exceptionResponse""

4 years agoMerge "Add semicolon at the end of this statement"
Ittay Stern [Mon, 26 Aug 2019 17:48:53 +0000 (17:48 +0000)]
Merge "Add  semicolon at the end of this statement"

4 years agoMerge "Move this variables to comply with Java Code Conventions."
Ittay Stern [Mon, 26 Aug 2019 17:48:21 +0000 (17:48 +0000)]
Merge "Move this variables to comply with Java Code Conventions."

4 years agoLog request-id even when no HttpServletRequest param or no user-session 96/94296/1
Ittay Stern [Mon, 26 Aug 2019 17:39:37 +0000 (20:39 +0300)]
Log request-id even when no HttpServletRequest param or no user-session

1. Catch controllers under org.onap.vid.controller.open.
2. Get HttpServletRequest from Spring's context, if needed.
3. Fix the way SetRequestBasedDefaultsIntoGlobalLoggingContext is used.

Change-Id: Iecd46dc10a458bc20d4b3e0bd72ecae37e3218cf
Issue-ID: VID-598
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Testfix: Expect 4 additional TOSCA `Input` fields"
Amichai Hemli [Mon, 26 Aug 2019 17:25:00 +0000 (17:25 +0000)]
Merge "Testfix: Expect 4 additional TOSCA `Input` fields"

4 years agoChange out-of-the-box config to work on dev's environment 91/94291/1
Ittay Stern [Mon, 26 Aug 2019 15:47:58 +0000 (18:47 +0300)]
Change out-of-the-box config to work on dev's environment

Add missing scheduler local configs.

Change-Id: I4d6a9d2c8deeb53b797a81ca101268740fcda6c3
Issue-ID: VID-564
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMake Scheduler's client more Gennerics-tolerant 90/94290/1
Ittay Stern [Mon, 26 Aug 2019 15:46:32 +0000 (18:46 +0300)]
Make Scheduler's client more Gennerics-tolerant

1. Use t.getClass, instead of new TypeReference<T>. The latter it not
   behaving as expected on run-time.

2. Store the raw response in restObject.setRaw (just because we can)

Change-Id: Ic7087af18ded212447cb67334a9e373759f4da1f
Issue-ID: VID-378
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoTestfix: Expect 4 additional TOSCA `Input` fields 87/94287/1
Ittay Stern [Mon, 26 Aug 2019 14:49:49 +0000 (17:49 +0300)]
Testfix: Expect 4 additional TOSCA `Input` fields

org.onap.vid.asdc.beans.tosca.Input was added with:
 - templateCustomizationUUID
 - templateInvariantUUID
 - templateName
 - templateUUID

This resolves getServiceModelWithGroupsAndCheckMinMaxInitialParams()

Change-Id: I57471f8f7e2560914aa0087101e57cad36868d6d
Issue-ID: VID-378
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoImmediately return this expression instead of assigning it to the temporary variable... 73/94273/1
Thugutla sailakshmi [Mon, 26 Aug 2019 12:26:01 +0000 (17:56 +0530)]
Immediately return this expression instead of assigning it to the temporary variable "responseWrapper2"

return the expression

Issue-ID: VID-561
Change-Id: I2a036a8181601c6cb6c5fd498c631ce9e5f5cbdb
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement 70/94270/1
anushadasari [Mon, 26 Aug 2019 11:34:58 +0000 (17:04 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-597
Change-Id: Ibe8ce68b67f4c48adfab0a382487e308093cdd01
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "AaiController tests"
Wojciech Sliwka [Mon, 26 Aug 2019 11:25:13 +0000 (11:25 +0000)]
Merge "AaiController tests"

4 years agoAaiController tests 44/94044/2
Michal Kabaj [Wed, 21 Aug 2019 13:07:05 +0000 (15:07 +0200)]
AaiController tests

- improved existing testcases by including spring integration
- added new testcases

Change-Id: I64abbd91b9c9fc7cdc27ca25f90954b29f065096
Issue-ID: VID-478
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
4 years agoMerge "new documentation to instantiate service, including Andreas comments Issue...
Ittay Stern [Mon, 26 Aug 2019 07:44:16 +0000 (07:44 +0000)]
Merge "new documentation to instantiate service, including Andreas comments Issue-ID: VID-575"

4 years agoImmediately return this expression instead of assigning it to the temporary variable... 56/94256/1
Thugutla sailakshmi [Sun, 25 Aug 2019 16:57:24 +0000 (22:27 +0530)]
Immediately return this expression instead of assigning it to the temporary variable "exceptionResponse"

return the expression

Issue-ID: VID-561
Change-Id: Ie06a589a74438df8dac525c5d8380beb948dc48e
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement 52/94252/1
anushadasari [Sun, 25 Aug 2019 15:20:45 +0000 (20:50 +0530)]
Add a semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-595
Change-Id: I44ebdf2ef1f58c2f0ef4db5fb3d72f69034e1d06
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoAdd semicolon at the end of this statement 51/94251/1
anushadasari [Sun, 25 Aug 2019 15:11:02 +0000 (20:41 +0530)]
Add  semicolon at the end of this statement

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-595
Change-Id: I7895047b2ae64e3fcca479bb26f45d1a0bd097ac
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "Allow plugging-in any provided LoginStrategy"
Amichai Hemli [Sun, 25 Aug 2019 12:02:01 +0000 (12:02 +0000)]
Merge "Allow plugging-in any provided LoginStrategy"

4 years agoFix to vf-module-homing-data-action controller to retrieve the cloudRegionId 25/94125/4
Alexey Sandler [Thu, 22 Aug 2019 12:16:48 +0000 (15:16 +0300)]
Fix to vf-module-homing-data-action controller to retrieve the cloudRegionId

Issue-ID: VID-378
Change-Id: I6042e72c9ebb8508b822df276da1b8549501042c
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoAllow plugging-in any provided LoginStrategy 50/94250/3
Ittay Stern [Sun, 25 Aug 2019 10:02:27 +0000 (13:02 +0300)]
Allow plugging-in any provided LoginStrategy

Support dynamic loading of provided implementations of PORTAL SDK's 
`org.onap.portalsdk.core.auth.LoginStrategy` interface.

VID will load the class defined by `login.strategy.classname`
configuration parameter. Default will keep current ONAP's dev login.

Change-Id: I956a1f3376455211398769f3193703129b779871
Issue-ID: VID-594
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agonew documentation to instantiate service, including Andreas comments 51/93751/2
Rene_Robert [Wed, 14 Aug 2019 13:49:28 +0000 (15:49 +0200)]
new documentation to instantiate service, including Andreas comments
Issue-ID: VID-575

Change-Id: Ie61bb00ce2252c93d6628bd665609864122cc108
Signed-off-by: Rene ROBERT <rene.robert@orange.com>
4 years agoMerge "Begin release notes for El Alto Early Drop"
Amichai Hemli [Thu, 22 Aug 2019 18:27:02 +0000 (18:27 +0000)]
Merge "Begin release notes for El Alto Early Drop"

4 years agoMove this variable to comply with Java Code Conventions 75/94075/3
Thugutla sailakshmi [Thu, 22 Aug 2019 07:30:57 +0000 (13:00 +0530)]
Move this variable to comply with Java Code Conventions

Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Ibf8099258145a2ae591cd0acce9bbe75b592eccd
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMerge "Add a semicolon at the end of this statement."
Ittay Stern [Thu, 22 Aug 2019 16:19:03 +0000 (16:19 +0000)]
Merge "Add a semicolon at the end of this statement."

4 years agoMerge "extract constant in MsoBusinessLogicImplTest"
Ittay Stern [Thu, 22 Aug 2019 16:14:16 +0000 (16:14 +0000)]
Merge "extract constant in MsoBusinessLogicImplTest"

4 years agoMerge "Move this variable to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:09:03 +0000 (16:09 +0000)]
Merge "Move this variable to comply with Java Code Conventions"

4 years agoMerge "Move this constructor to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:05:37 +0000 (16:05 +0000)]
Merge "Move this constructor to comply with Java Code Conventions"

4 years agoMerge "Move this constructor to comply with Java Code Conventions"
Ittay Stern [Thu, 22 Aug 2019 16:04:05 +0000 (16:04 +0000)]
Merge "Move this constructor to comply with Java Code Conventions"

4 years agoextract constant in MsoBusinessLogicImplTest 32/94132/1
Eylon Malin [Thu, 22 Aug 2019 14:40:14 +0000 (17:40 +0300)]
extract constant in MsoBusinessLogicImplTest

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I49a50f0762b2db8bcab06340a6407a0ee7970c86

4 years agoMerge "make scheduler client tolerance to error messages"
Amichai Hemli [Thu, 22 Aug 2019 13:50:23 +0000 (13:50 +0000)]
Merge "make scheduler client tolerance to error messages"

4 years agomake scheduler client tolerance to error messages 06/94106/2
Eylon Malin [Thu, 22 Aug 2019 12:22:17 +0000 (15:22 +0300)]
make scheduler client tolerance to error messages

Read response from scheduler as String save them as raw,
and only then parse them

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I38ed8f211b2c111b57741254cb5e90317fefdc7d
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "probe mso by retrieving empty list of request status"
Amichai Hemli [Thu, 22 Aug 2019 13:12:17 +0000 (13:12 +0000)]
Merge "probe mso by retrieving empty list of request status"

4 years agoprobe mso by retrieving empty list of request status 91/94091/2
Eylon Malin [Thu, 22 Aug 2019 09:26:41 +0000 (12:26 +0300)]
probe mso by retrieving empty list of request status

Mso probe component use getRawOrchestrationRequestsByFilter
which return HttpResponseWithRequestInfo

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icee95af8dbe26296e9fc110170fb758e5133984c
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoAdd MsoController deletion tests 99/94099/1
kurczews [Thu, 22 Aug 2019 10:35:04 +0000 (12:35 +0200)]
Add MsoController deletion tests

Change-Id: I534fb06e7bf742f2fe6931e5b6f279f499aeed08
Issue-ID: VID-470
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
4 years agoMove this constructor to comply with Java Code Conventions 85/94085/1
Thugutla sailakshmi [Thu, 22 Aug 2019 07:55:44 +0000 (13:25 +0530)]
Move this constructor to comply with Java Code Conventions

Move this constructor to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I50e166bebe331db6b1e46f06c156791fa41b500b
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this constructor to comply with Java Code Conventions 79/94079/1
Thugutla sailakshmi [Thu, 22 Aug 2019 07:40:45 +0000 (13:10 +0530)]
Move this constructor to comply with Java Code Conventions

Move this constructor to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I3641f897f191dc8717bf65fefd4fd2c699f7195b
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variable to comply with Java Code Conventions 32/94032/2
Thugutla sailakshmi [Wed, 21 Aug 2019 08:57:29 +0000 (14:27 +0530)]
Move this variable to comply with Java Code Conventions

Move this variable to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: I01c4d3e2efc1ee23694da8d3e6770978d94e88c2
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement. 69/94069/1
anushadasari [Thu, 22 Aug 2019 06:52:50 +0000 (12:22 +0530)]
Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-583
Change-Id: I68d334ce5f7f427ebc3e49b5991fd989676d8c0e
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoBegin release notes for El Alto Early Drop 37/94037/1
Ittay Stern [Wed, 21 Aug 2019 11:21:45 +0000 (14:21 +0300)]
Begin release notes for El Alto Early Drop

Change-Id: Ifba726c82e8348d7744ffd3483380831d1888abf
Issue-ID: VID-553
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoprobe sdc by retrieving service model if uuid configured 27/93627/5
Eylon Malin [Thu, 15 Aug 2019 14:23:44 +0000 (17:23 +0300)]
probe sdc by retrieving service model if uuid configured

If system.properties has value for probe.sdc.model.uuid then usd
this value for retrieving service model
otherwise probe only sdc connectivity with sdc2/rest/healthCheck

Issue-ID: VID-378
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Icd1c31217e56a8c0cfa5c2f2bc5f11e0c8dd7ff8
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "merge 2 TestNg transformers"
Ittay Stern [Wed, 21 Aug 2019 10:01:21 +0000 (10:01 +0000)]
Merge "merge 2 TestNg transformers"

4 years agoMove this variables to comply with Java Code Conventions. 27/93927/3
Thugutla sailakshmi [Tue, 20 Aug 2019 07:27:44 +0000 (12:57 +0530)]
Move this variables to comply with Java Code Conventions.

Move this variables to comply with Java Code Conventions.

Issue-ID: VID-561
Change-Id: I67d79a485f60db1818d4c0c5053b87d8bd5b89d0
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMerge "Move this variables and constructors to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:57:21 +0000 (09:57 +0000)]
Merge "Move this variables and constructors to comply with Java Code Conventions"

4 years agoMerge changes from topics "VID-583", "VID-582"
Ittay Stern [Wed, 21 Aug 2019 09:06:00 +0000 (09:06 +0000)]
Merge changes from topics "VID-583", "VID-582"

* changes:
  Add a semicolon at the end of this statement.
  Unused Import

4 years agoMerge "Move this variables to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:02:57 +0000 (09:02 +0000)]
Merge "Move this variables  to comply with Java Code Conventions"

4 years agoMerge "Move this variables to comply with Java Code Conventions"
Ittay Stern [Wed, 21 Aug 2019 09:00:23 +0000 (09:00 +0000)]
Merge "Move this variables to comply with Java Code Conventions"

4 years agoMove this variables and constructors to comply with Java Code Conventions 30/93930/3
Thugutla sailakshmi [Tue, 20 Aug 2019 07:41:54 +0000 (13:11 +0530)]
Move this variables and constructors to comply with Java Code Conventions

Move this variables and constructors  to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Id8e4c00609ad17d624da82d8b73d14b5cb0639b1
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoMove this variables to comply with Java Code Conventions 24/94024/1
Thugutla sailakshmi [Wed, 21 Aug 2019 07:41:14 +0000 (13:11 +0530)]
Move this variables  to comply with Java Code Conventions

Move this variables  to comply with Java Code Conventions

Issue-ID: VID-581
Change-Id: I74728ee5234501ba3c2a8fe5ae889c1e9186f2dc
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoAdd a semicolon at the end of this statement. 23/94023/1
anushadasari [Wed, 21 Aug 2019 07:40:33 +0000 (13:10 +0530)]
Add a semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Issue-ID: VID-583
Change-Id: I73dbc757d62ef388d8935ef6aa25f08c3a82df8c
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMove this variables to comply with Java Code Conventions 26/93926/2
Thugutla sailakshmi [Tue, 20 Aug 2019 07:23:57 +0000 (12:53 +0530)]
Move this variables to comply with Java Code Conventions

Move this variables to comply with Java Code Conventions

Issue-ID: VID-561
Change-Id: Id618b3717658dcd44b17a5f85b0b87e7e8b71826
Signed-off-by: Thugutla sailakshmi <tsaila10@in.ibm.com>
4 years agoUnused Import 21/94021/1
anushadasari [Wed, 21 Aug 2019 07:27:30 +0000 (12:57 +0530)]
Unused Import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-582
Change-Id: Id79d2f2af4d69ded8e1c8da10fc67e4e7ea0f933
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge "Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java...
Ittay Stern [Wed, 21 Aug 2019 06:54:55 +0000 (06:54 +0000)]
Merge "Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code Conventions"

4 years agoMerge "Sonar Fix - HttpsAuthClient.java"
Ittay Stern [Wed, 21 Aug 2019 06:54:29 +0000 (06:54 +0000)]
Merge "Sonar Fix - HttpsAuthClient.java"

4 years agoMerge changes from topics "VID-580", "VID-579", "VID-578"
Ittay Stern [Wed, 21 Aug 2019 06:34:15 +0000 (06:34 +0000)]
Merge changes from topics "VID-580", "VID-579", "VID-578"

* changes:
  unused import
  Move the variable to comply with JCC.
  semicolon at the end of this statement.

4 years agomerge 2 TestNg transformers 23/93623/2
Eylon Malin [Thu, 15 Aug 2019 13:42:22 +0000 (16:42 +0300)]
merge 2 TestNg transformers

Testng probably don't behave well with 2 transformers that change same
thing. So I merge 2 transformers that skip tests to one transformer.
Issue-ID: VID-378

Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I569d421b853ed1e0dc2a5055dbaf8e5bba6db470
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agounused import 41/93941/1
anushadasari [Tue, 20 Aug 2019 09:30:49 +0000 (15:00 +0530)]
unused import

The imports part of a file should be handled by the Integrated Development Environment (IDE), not manually by the developer.
Unused and useless imports should not occur if that is the case.
Leaving them in reduces the code's readability, since their presence can be confusing.

Issue-ID: VID-580
Change-Id: I3ea680af37477b564d02fcc9b58956b3958d184d
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMove the variable to comply with JCC. 40/93940/1
anushadasari [Tue, 20 Aug 2019 09:12:19 +0000 (14:42 +0530)]
Move the variable to comply with JCC.

According to the Java Code Conventions as defined by Oracle, the members of a class or interface declaration should appear in the following order in the source files:
Class and instance variables
Constructors
Methods

Issue-ID: VID-579
Change-Id: Ie87b550a30df06eb2498565b719bd52b11d0c3f9
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agosemicolon at the end of this statement. 32/93932/1
anushadasari [Tue, 20 Aug 2019 07:59:19 +0000 (13:29 +0530)]
semicolon at the end of this statement.

In JavaScript, the semicolon (;) is optional as a statement separator, but omitting semicolons can be confusing, and lead to unexpected results because a semicolon is implicitly inserted at the end of each line.

Change-Id: Ia09e1bb1894da379f68cc39e83f955e66b957511
Issue-ID: VID-578
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoadding update about mounted certificates in rst file 63/93863/1
Bartosz Gardziejewski [Mon, 19 Aug 2019 11:47:19 +0000 (13:47 +0200)]
adding update about mounted certificates in rst file

Issue-ID: VID-494
Change-Id: I732a426975247448f05539d1a95c0b6c66ccf5a7
Signed-off-by: Bartosz Gardziejewski <bartosz.gardziejewski@nokia.com>
4 years agoSonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code... 64/93664/1
dinesha [Fri, 16 Aug 2019 06:50:19 +0000 (12:20 +0530)]
Sonar Fix - LeanCloudConfiguration.java - Move variable to comply with Java Code Conventions

Fixed sonar issus across the file

Issue-ID: VID-547
Change-Id: I3362cf34c3db506ab3359669045169fe761743ea
Signed-off-by: dinesha <dineshgs@in.ibm.com>