Rene_Robert [Thu, 22 Aug 2019 14:57:27 +0000 (16:57 +0200)]
url correction and improve API doc
Issue-ID: SO-2245
Signed-off-by: Rene_Robert <rene.robert@orange.com>
Change-Id: Ife95e64f0bed03e779f8ffef180f2a68ed0eb371
Lukasz Muszkieta [Thu, 22 Aug 2019 11:07:46 +0000 (11:07 +0000)]
Merge "Moved setNeutronNetworkId() call inside null check to prevent crash at outputs.get() call"
Lukasz Muszkieta [Thu, 22 Aug 2019 09:41:16 +0000 (09:41 +0000)]
Merge "Moved null check for outputs so that get() method call won't result in crash."
Arindam Mondal [Mon, 19 Aug 2019 02:24:37 +0000 (11:24 +0900)]
General sonar fixes
+) Use format specifier to log exception
++) remove unused import
Issue-ID: SO-2226
Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1
Signed-off-by: arindamm <arind.mondal@samsung.com>
Oleksandr Moliavko [Wed, 21 Aug 2019 06:55:13 +0000 (09:55 +0300)]
Added null check for latestStack to prevent crash
at method calls; moved latestStack declaration
according to comment by maintainer
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ic4bfeca94103f6c902808de39df752569580c066
Seshu Kumar M [Wed, 21 Aug 2019 13:26:49 +0000 (13:26 +0000)]
Merge "Javadoc and logging improvement"
Seshu Kumar M [Wed, 21 Aug 2019 13:24:58 +0000 (13:24 +0000)]
Merge "Added null check for httpResponse to prevent crash at throwing exception"
Oleksandr Moliavko [Tue, 20 Aug 2019 08:32:52 +0000 (11:32 +0300)]
Added null check for rootNode to prevent crash at
for loop.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5ec16f3d73982c89e2bf5b14758274f1d4dd7740
Oleksandr Moliavko [Mon, 19 Aug 2019 14:56:28 +0000 (17:56 +0300)]
Rewritten checks for status according to comments
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I6023a043e2cf532de330060973d23a402a742e36
Seshu Kumar M [Mon, 19 Aug 2019 11:38:40 +0000 (11:38 +0000)]
Merge "Solve the vnfc_instance_group_customization_id insertion failure problem"
k.kazak [Wed, 14 Aug 2019 08:18:31 +0000 (10:18 +0200)]
Close input streams via try-with-resources
DefaultDmaapPropertiesImpl: close FileInputStream after loading
ServicePluginFactory: close HttpClient if processing fails
close application.properties InputStream after loading
remove redundant catch block if behavior is the same
add logging of exception in finally block
BpmnInstaller: close csarFile if processing fails
Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c
Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308
Issue-ID: SO-2211
Signed-off-by: k.kazak <k.kazak@samsung.com>
Oleksandr Moliavko [Mon, 19 Aug 2019 07:54:42 +0000 (10:54 +0300)]
Added null check for heat to remove static
analyzer warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I71eb14adcc1227af4470853e6e1acdb631a7efe8
Steve Smokowski [Fri, 16 Aug 2019 13:59:29 +0000 (13:59 +0000)]
Merge "add junit coverage for SvnfmService"
Steve Smokowski [Fri, 16 Aug 2019 13:09:41 +0000 (13:09 +0000)]
Merge "Add retrieval of vmIds and vServerIds for APPC"
Steve Smokowski [Fri, 16 Aug 2019 13:08:37 +0000 (13:08 +0000)]
Merge "Add SO Same deployment id on deployed custom workflows"
Steve Smokowski [Fri, 16 Aug 2019 13:06:00 +0000 (13:06 +0000)]
Merge "Initial commit of validation framework to APIH"
Steve Smokowski [Fri, 16 Aug 2019 13:05:51 +0000 (13:05 +0000)]
Merge "asdc controller treat distributionid as requestid"
Steve Smokowski [Fri, 16 Aug 2019 13:05:39 +0000 (13:05 +0000)]
Merge "apih format statusdetail to return granular"
Oleksandr Moliavko [Fri, 16 Aug 2019 12:21:20 +0000 (15:21 +0300)]
Added null check for httpResponse to prevent crash
at throwing exception
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Iffbaaddea9c9bb1609ce2e0755f6f3ca49e0ad31
Oleksandr Moliavko [Wed, 14 Aug 2019 07:42:25 +0000 (10:42 +0300)]
Removed unused CSAR class.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb
Oleksandr Moliavko [Fri, 16 Aug 2019 06:53:30 +0000 (09:53 +0300)]
Replaced string concatenations in a loop with
StringBuffer appends to remove static analyzer
warning about inefficient string operations
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1
Lukasz Muszkieta [Fri, 16 Aug 2019 10:04:05 +0000 (10:04 +0000)]
Merge "Added check for empty processInstanceList"
Parshad Patel [Tue, 13 Aug 2019 04:38:06 +0000 (13:38 +0900)]
Sonar fix in MSOCommonBPMN
Either log or rethrow this exception
Remove this useless assignment to local variable "serviceInstance"
Remove the declaration of thrown exception which is a runtime exception
Move the string literal on the left side of this string comparison
Issue-ID: SO-1841
Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Manamohan [Fri, 16 Aug 2019 06:15:52 +0000 (11:45 +0530)]
Javadoc and logging improvement
Added Javadocs and logging for these classes.
Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
zm330 [Fri, 16 Aug 2019 03:29:04 +0000 (11:29 +0800)]
Solve the vnfc_instance_group_customization_id insertion failure problem
Change-Id: Iac9eea25895d9f048b00218b67db5d7bfb3efb58
Issue-ID: SO-2164
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
Smokowski, Steven [Fri, 16 Aug 2019 01:40:16 +0000 (21:40 -0400)]
Initial commit of validation framework to APIH
Move ListenerRunner to common location
Adjust request params name, update junit tests
Update validations to work properly
Properly escape period for the string split
Issue-ID: SO-2232
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
Plummer, Brittany [Tue, 13 Aug 2019 23:12:07 +0000 (19:12 -0400)]
Added check for empty processInstanceList
Added check for empty processInstanceList
Issue-ID: SO-2225
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
Bhatt, Prema [Thu, 15 Aug 2019 19:54:22 +0000 (15:54 -0400)]
asdc controller treat distributionid as requestid
Setting RequestId in MDC using DistributionID value in ASDC-controller
Setting RequestId in MDC using DistributionID value in ASDC-controller.
Cleaned up code.
Removing the log line as per the review comments.
Issue-ID: SO-2231
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I07880a80d479ad01411e0c5ece12d77722b8cb6c
Plummer, Brittany [Thu, 15 Aug 2019 19:48:49 +0000 (15:48 -0400)]
apih format statusdetail to return granular
Should return unchanged requestState on statusDetail queryParam
Formatted files with changes to fix build
Added enum validation for setting requestStatus
Updated test to send in "statusDetail"
Issue-ID: SO-2230
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
Bonkur, Venkat (vb8416) [Thu, 15 Aug 2019 04:07:09 +0000 (00:07 -0400)]
Add SO Same deployment id on deployed custom workflows
Added the change to call the DeploymentBuilder.deploy() method after
going through all the custom workflows. Thus all the workflows
deployed and they startup correctly.
Issue-ID: SO-2210
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ieaa5d1447405f75744d7c05bd8f7603c16edf5ea
Steve Smokowski [Thu, 15 Aug 2019 12:11:45 +0000 (12:11 +0000)]
Merge "- Updated vnfc instance groups to use the"
anjali.walsatwar [Mon, 12 Aug 2019 10:26:51 +0000 (15:56 +0530)]
public keyword removed for DoCreateServiceInstanceRollback.groovy
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: If2b6f5d1416042dd8ce88ae9d467ae24b00a1c55
Lukasz Muszkieta [Wed, 14 Aug 2019 10:27:45 +0000 (10:27 +0000)]
Merge "DoCreateVFCNetworkServiceInstance.groovy corrected"
Elena Kuleshov [Fri, 9 Aug 2019 22:21:32 +0000 (18:21 -0400)]
Add retrieval of vmIds and vServerIds for APPC
2nd take, resolving build issu - port retrieval of vmIds and vserverIds from groovy to java
Issue-ID: SO-2189
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic666a65336e40eb38ab91c0037b85236ec1eebb5
Merkel, Jeff [Tue, 13 Aug 2019 23:10:26 +0000 (19:10 -0400)]
- Updated vnfc instance groups to use the
- Updated vnfc instance groups to use the getEntity API.
Issue-ID: SO-2224
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I278aebe5174dfb52ad3db86957c262dca5eac359
Lukasz Muszkieta [Tue, 13 Aug 2019 14:42:41 +0000 (14:42 +0000)]
Merge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest classes"
Lukasz Muszkieta [Tue, 13 Aug 2019 14:41:31 +0000 (14:41 +0000)]
Merge "Place diamond op in place of type spec"
Lukasz Muszkieta [Tue, 13 Aug 2019 14:40:16 +0000 (14:40 +0000)]
Merge "Removed unused method setHPAParameters()"
Oleksandr Moliavko [Mon, 12 Aug 2019 06:56:10 +0000 (09:56 +0300)]
Removed unused CryptoHandler, ICryptoHandler and
CryptoHandlerTest classes
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I944ae9b49326257b6ddfe94687c3241e91af4de9
sindhu3672 [Mon, 12 Aug 2019 13:21:06 +0000 (18:51 +0530)]
Place diamond op in place of type spec
Place diamond op in place of type spec MSOCommonBPMN classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I133a9328f5c91c61af24a57a610d36c6d6622f66
Oleksandr Moliavko [Mon, 12 Aug 2019 13:49:20 +0000 (16:49 +0300)]
Removed unused method setHPAParameters()
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ic9de579495c1400bca233b679699ae857180520b
Lukasz Muszkieta [Tue, 13 Aug 2019 08:59:57 +0000 (08:59 +0000)]
Merge "Removed duplicate use of networkType field in String.format() call to prevent static analyzer warning"
Seshu Kumar M [Tue, 13 Aug 2019 08:40:29 +0000 (08:40 +0000)]
Merge "Change variable name-comply with regex"
Seshu Kumar M [Tue, 13 Aug 2019 08:39:59 +0000 (08:39 +0000)]
Merge "Change variable name-comply with regex"
subhash kumar singh [Tue, 13 Aug 2019 08:39:53 +0000 (08:39 +0000)]
Merge "update version for 1.5.1"
Lukasz Muszkieta [Tue, 13 Aug 2019 08:38:55 +0000 (08:38 +0000)]
Merge "Enhance variable name-comply with regex"
Oleksandr Moliavko [Tue, 13 Aug 2019 07:12:42 +0000 (10:12 +0300)]
Removed duplicate use of networkType field in
String.format() call to prevent static analyzer
warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I1e3ea352aac9a88172b683d267b2f3c804bb362b
Seshu Kumar M [Tue, 13 Aug 2019 05:28:24 +0000 (05:28 +0000)]
Merge "Modify variable name-comply with regex"
Seshu Kumar M [Tue, 13 Aug 2019 05:27:40 +0000 (05:27 +0000)]
Merge "Replace with equalsIgnoreCase"
Seshu Kumar M [Tue, 13 Aug 2019 05:26:19 +0000 (05:26 +0000)]
Merge "Use diamond op in place of type spec"
seshukm [Tue, 13 Aug 2019 04:40:01 +0000 (10:10 +0530)]
update version for 1.5.1
Issue-ID: SO-2223
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I972e6be75ce9ca38e3d08ac17a48af62f0aa2f05
sindhu3672 [Mon, 12 Aug 2019 11:37:55 +0000 (17:07 +0530)]
Enhance variable name-comply with regex
Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5
Lukasz Muszkieta [Mon, 12 Aug 2019 13:55:17 +0000 (13:55 +0000)]
Merge "Remove repeated conditional test in buildServiceErrorResponse"
Steve Smokowski [Mon, 12 Aug 2019 13:49:33 +0000 (13:49 +0000)]
Merge "query builder now handles more than just strings"
Steve Smokowski [Mon, 12 Aug 2019 13:49:24 +0000 (13:49 +0000)]
Merge "added in mapping of aggregate routes in"
Steve Smokowski [Mon, 12 Aug 2019 13:49:13 +0000 (13:49 +0000)]
Merge "health check now entirely config based"
Steve Smokowski [Mon, 12 Aug 2019 13:49:02 +0000 (13:49 +0000)]
Merge "All extendable enums should be serializable"
Lukasz Muszkieta [Mon, 12 Aug 2019 12:49:25 +0000 (12:49 +0000)]
Merge "Remove useless double assignment in PnfEventReadyDmaapClient.unregister"
sindhu3672 [Mon, 12 Aug 2019 11:28:40 +0000 (16:58 +0530)]
Replace with equalsIgnoreCase
Replace with equalsIgnoreCase bpmn ServicePluginFactory class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I2860546bb921a1b685f824beb0cd790e826435ad
Lukasz Muszkieta [Mon, 12 Aug 2019 10:41:04 +0000 (10:41 +0000)]
Merge "Sonar fix in mso-adapter-utils"
Seshu Kumar M [Mon, 12 Aug 2019 10:28:42 +0000 (10:28 +0000)]
Merge changes I2fead528,I2e9fd421,Ib67d7240
* changes:
DeleteVFCNSResource.groovy corrected
DeActivateSDNCNetworkResource.groovy corrected
DoCreateServiceInstance.groovy corrected
anjali.walsatwar [Mon, 12 Aug 2019 10:24:35 +0000 (15:54 +0530)]
DoCreateVFCNetworkServiceInstance.groovy corrected
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I537a9a5ef72823f9aec9504e0475eee970c04a1a
sindhu3672 [Mon, 12 Aug 2019 09:10:28 +0000 (14:40 +0530)]
Change variable name-comply with regex
Change variable name-comply with regex asdc controller and bpmn classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ib1e16b2df9c620f2f225424e003226996fbe99e1
sindhu3672 [Mon, 12 Aug 2019 10:08:59 +0000 (15:38 +0530)]
Change variable name-comply with regex
Change variable name-comply with regex asdc-controller & mso-api-handlers classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I709cbcacc32e57a8b9cf89a963321bfde3b08301
sindhu3672 [Mon, 12 Aug 2019 08:55:55 +0000 (14:25 +0530)]
Use diamond op in place of type spec
Use diamond op in place of type spec MSOCommonBPMN classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I8812392bbc6eac6d703ff7eeabf8e95806aab442
sindhu3672 [Mon, 12 Aug 2019 09:24:33 +0000 (14:54 +0530)]
Modify variable name-comply with regex
Modify variable name-comply with regex mso api handlers DuplicateRequestException class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ifbd69bffcfce08cc2e9c44817a02f9ddfe28aadc
anjali.walsatwar [Mon, 12 Aug 2019 09:13:56 +0000 (14:43 +0530)]
DeleteVFCNSResource.groovy corrected
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I2fead52822d107ad712624ba9a37c959eae8c077
Seshu Kumar M [Mon, 12 Aug 2019 08:50:43 +0000 (08:50 +0000)]
Merge "Replace type spec with diamond op"
anjali.walsatwar [Mon, 12 Aug 2019 08:45:45 +0000 (14:15 +0530)]
DeActivateSDNCNetworkResource.groovy corrected
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I2e9fd421f528ee147188f626817a5f3e68fa55fa
anjali.walsatwar [Mon, 12 Aug 2019 08:36:40 +0000 (14:06 +0530)]
DoCreateServiceInstance.groovy corrected
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: Ib67d724009c172aa86347853075b3cf7ee6be502
Seshu Kumar M [Mon, 12 Aug 2019 08:33:23 +0000 (08:33 +0000)]
Merge "fix sonar issue"
Seshu Kumar M [Mon, 12 Aug 2019 08:32:04 +0000 (08:32 +0000)]
Merge "Change collections size with isEmpty"
Seshu Kumar M [Mon, 12 Aug 2019 08:31:42 +0000 (08:31 +0000)]
Merge "Move string literal left side-avoid null pointer ex"
Seshu Kumar M [Mon, 12 Aug 2019 08:31:06 +0000 (08:31 +0000)]
Merge "Change string literal left side-avoid null pointer ex"
Seshu Kumar M [Mon, 12 Aug 2019 08:30:05 +0000 (08:30 +0000)]
Merge "Merge if stmts for code readability"
Lukasz Muszkieta [Mon, 12 Aug 2019 08:10:33 +0000 (08:10 +0000)]
Merge "DoCreateResources.groovy corrected"
Lukasz Muszkieta [Mon, 12 Aug 2019 08:07:45 +0000 (08:07 +0000)]
Merge "corrected CompareModelofE2EServiceInstance.groovy"
Parshad Patel [Mon, 12 Aug 2019 07:49:39 +0000 (16:49 +0900)]
Sonar fix in mso-adapter-utils
Either log or rethrow this exception
Remove this unused import
Make "workloadStatusReason" transient or serializable
Issue-ID: SO-1841
Change-Id: I01fe8ce059b5fde95d300d2d0e5b4a1a114c479a
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Lukasz Muszkieta [Mon, 12 Aug 2019 07:16:28 +0000 (07:16 +0000)]
Merge "Replace collections size with isEmpty"
sindhu3672 [Mon, 12 Aug 2019 07:01:22 +0000 (12:31 +0530)]
Change string literal left side-avoid null pointer ex
Change string literal left side so.adapters.vnfmadapter WebSecurityConfigImpl class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I8ba57bd9c3c548a35b90d9324f1d214985c3c539
sindhu3672 [Mon, 12 Aug 2019 06:39:09 +0000 (12:09 +0530)]
Move string literal left side-avoid null pointer ex
Move string literal left side so.adapters.vnfmadapter WebSecurityConfigImpl class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I6669a11bf95a41e3efa18d907f2b3f3eb3f3f1b3
anjali.walsatwar [Fri, 9 Aug 2019 10:18:11 +0000 (15:48 +0530)]
DoCreateResources.groovy corrected
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I1d4dc5370125a587b11cbf05b69fdaf8fcaa37aa
sindhu3672 [Mon, 12 Aug 2019 05:40:32 +0000 (11:10 +0530)]
Change collections size with isEmpty
Change collections size with isEmpty mso-adapter-utils class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I784a5839d003c42a9880287d304060cd9639f1b6
anjali.walsatwar [Fri, 9 Aug 2019 10:15:44 +0000 (15:45 +0530)]
corrected CompareModelofE2EServiceInstance.groovy
groovy file correction
Issue-ID: SO-2212
Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I42b005210df986b1a4f006982f9d89be54bffa7f
Seshu Kumar M [Sun, 11 Aug 2019 18:18:02 +0000 (18:18 +0000)]
Merge changes Ia52d9db2,Iab16430b
* changes:
Remove unused public access modifier
Add vfmodule support to e2e service instance
Seshu Kumar M [Sun, 11 Aug 2019 18:17:28 +0000 (18:17 +0000)]
Merge changes I045619a9,Iadffb2af,Ie97c560d
* changes:
Remove unwanted semicolon from groovy files
Remove unwanted semicolon
Removed unrequired semicolon from groovy
Benjamin, Max (mb388a) [Fri, 9 Aug 2019 20:22:17 +0000 (16:22 -0400)]
All extendable enums should be serializable
marking items as transient causes them to be lost
Issue-ID: SO-2217
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If66f9034b67f94c8122875ef915043525fb9bdb7
Benjamin, Max [Fri, 9 Aug 2019 17:29:22 +0000 (13:29 -0400)]
health check now entirely config based
health check now entirely config based
api handler now lists itself as an endpoint
updated robot test to verify new format
fixed formatting issues with modified files
updated test case to reflect new statuses
fixed duplicate bean issue with converter
ignore unit test that never worked
added missing class to context configuration
removed extraneous spaces from robot file
update robot files as well as fix compile issues
config format must be correct on startup
Issue-ID: SO-2216
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I86770922c7b7f36e4a4d59615f7336cda7cbe629
sindhu3672 [Fri, 9 Aug 2019 17:09:55 +0000 (22:39 +0530)]
Replace collections size with isEmpty
Replace collections size with isEmpty mso-adapter-utils class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Icf6fc86d9d6f02571938804d214b5b5bfca72698
sindhu3672 [Fri, 9 Aug 2019 16:17:34 +0000 (21:47 +0530)]
Replace type spec with diamond op
Replace type spec with diamond operator cloudify-client classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I074c6d28b387a425841f1e35964c336834aff5b4
sindhu3672 [Fri, 9 Aug 2019 15:38:06 +0000 (21:08 +0530)]
Merge if stmts for code readability
Merge if stmts for code readability asdc controller DeployActivitySpecs class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: If27dc7b6e28e4058c4132e7d8178b773cb9f065b
Artem Naluzhnyy [Fri, 9 Aug 2019 09:58:30 +0000 (11:58 +0200)]
Remove repeated conditional test in buildServiceErrorResponse
Coverity-scan: CID-203826
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I18d788e361b502e392f7f59ff6bc772dfee394bd
Artem Naluzhnyy [Fri, 9 Aug 2019 10:01:51 +0000 (12:01 +0200)]
Remove useless double assignment in PnfEventReadyDmaapClient.unregister
Coverity-scan: CID-211458
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I670bb1f5684b90f0d4d01542c77c882e3d4966e4
Lukasz Muszkieta [Fri, 9 Aug 2019 13:36:57 +0000 (13:36 +0000)]
Merge "Remove unused SDNCServiceRequest constructors"
subhash kumar singh [Fri, 9 Aug 2019 13:35:41 +0000 (13:35 +0000)]
Merge "removed unwanted public for ActivateSDNCNetworkResource.groovy"
subhash kumar singh [Fri, 9 Aug 2019 13:34:51 +0000 (13:34 +0000)]
Merge "fix sonar issue"
subhash kumar singh [Fri, 9 Aug 2019 13:30:52 +0000 (19:00 +0530)]
Remove unwanted semicolon from groovy files
Remove unwanted semicolon from groovy files.
Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: I045619a93597459d7ae5f656a880d36b4a46f001
subhash kumar singh [Fri, 9 Aug 2019 13:25:17 +0000 (18:55 +0530)]
Remove unwanted semicolon
Remove unwanted semicolon.
Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Iadffb2affff8597a8eb8258041b37cb8bf701f20
subhash kumar singh [Fri, 9 Aug 2019 13:14:43 +0000 (13:14 +0000)]
Merge changes I8e443077,I51a9106a,I54076323
* changes:
fix sonar issue
fix sonar issue
fix sonar issue
sarada prasad sahoo [Fri, 9 Aug 2019 12:58:54 +0000 (18:28 +0530)]
fix sonar issue
fix sonar issues
Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I841a50876aaf22e1fbc597029f270d243adf2613
Code Review / so.git / log