so.git
4 years agoMerge "Replaced constructor call with Boolean.valueOf() call to prevent static analyz...
Seshu Kumar M [Wed, 31 Jul 2019 12:57:32 +0000 (12:57 +0000)]
Merge "Replaced constructor call with Boolean.valueOf() call to prevent static analyzer warning about inefficient use of constructor"

4 years agoJavadoc and logging improvement 33/92333/2
Manamohan [Wed, 31 Jul 2019 09:55:44 +0000 (15:25 +0530)]
Javadoc and logging improvement

Added Javadocs for VnfAdapterCreateTasks and SDNCAssignTasks.

Change-Id: Ifb76e278eb90ba2d4644b649e91c1ffb15c55101
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
4 years agoReplaced constructor call with Boolean.valueOf() call 71/92271/1
Oleksandr Moliavko [Tue, 30 Jul 2019 13:18:31 +0000 (16:18 +0300)]
Replaced constructor call with Boolean.valueOf() call
to prevent static analyzer warning about inefficient
use of constructor

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Id5a883628726bdd0313a46ea4808a36eccf03c9a

4 years agoUse generic req mapping for CM requests 08/92308/1
Elena Kuleshov [Tue, 30 Jul 2019 09:40:39 +0000 (05:40 -0400)]
Use generic req mapping for CM requests

Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests.

Issue-ID: SO-2168
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed

4 years agoMerge "Added null check to heatStack.getOutputs() to prevent crash at get() call...
Seshu Kumar M [Tue, 30 Jul 2019 13:32:59 +0000 (13:32 +0000)]
Merge "Added null check to heatStack.getOutputs() to prevent crash at get() call; removed redundant null check to simplify the code"

4 years agoAdded null check to heatStack.getOutputs() 64/92264/2
Oleksandr Moliavko [Tue, 30 Jul 2019 10:30:40 +0000 (13:30 +0300)]
Added null check to heatStack.getOutputs()
to prevent crash at get() call; removed redundant
null check to simplify the code

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If9d8dcba3008cd7ebe60c17c08c71a07a6df9df4

4 years agoMerge "Replaced constructor calls with valueOf() method calls to remove static analyz...
Seshu Kumar M [Tue, 30 Jul 2019 11:56:25 +0000 (11:56 +0000)]
Merge "Replaced constructor calls with valueOf() method calls to remove static analyzer warnings about inefficient constructor calls"

4 years agoMerge "Replaced constructor call with valueOf() call to remove static analyzer warnin...
Seshu Kumar M [Tue, 30 Jul 2019 11:55:49 +0000 (11:55 +0000)]
Merge "Replaced constructor call with valueOf() call to remove static analyzer warning about inefficient use of constructor"

4 years agoMerge "Removed subscriber variable that was not actually used in any test (to remove...
Seshu Kumar M [Tue, 30 Jul 2019 11:55:12 +0000 (11:55 +0000)]
Merge "Removed subscriber variable that was not actually used in any test (to remove static analyzer warning)"

4 years agoMerge "commented out bad tests, will revisit"
Seshu Kumar M [Tue, 30 Jul 2019 11:53:12 +0000 (11:53 +0000)]
Merge "commented out bad tests, will revisit"

4 years agoMerge "apih allowing requests with the same requestid"
Seshu Kumar M [Tue, 30 Jul 2019 10:42:41 +0000 (10:42 +0000)]
Merge "apih allowing requests with the same requestid"

4 years agocommented out bad tests, will revisit 71/90871/2
DeWayne Filppi [Wed, 3 Jul 2019 23:45:02 +0000 (16:45 -0700)]
commented out bad tests, will revisit

Change-Id: I57e0e1378e743074b3fad3533756179776bfaf0b
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Issue-ID: SO-1836

4 years agoMerge "Sonar fix: CreateVfModuleRequest.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:05:10 +0000 (10:05 +0000)]
Merge "Sonar fix: CreateVfModuleRequest.java"

4 years agoMerge "Sonar fix: HealthStackAudit.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:02:28 +0000 (10:02 +0000)]
Merge "Sonar fix: HealthStackAudit.java"

4 years agoMerge "fix architecture.rst formatting"
Seshu Kumar M [Tue, 30 Jul 2019 10:01:31 +0000 (10:01 +0000)]
Merge "fix architecture.rst formatting"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Tue, 30 Jul 2019 10:00:45 +0000 (10:00 +0000)]
Merge "Javadoc and logging improvement"

4 years agoMerge "fix malformed tables in docs"
Seshu Kumar M [Tue, 30 Jul 2019 09:59:26 +0000 (09:59 +0000)]
Merge "fix malformed tables in docs"

4 years agoMerge "Sonar Fix: VduArtifact.java"
Seshu Kumar M [Tue, 30 Jul 2019 09:58:14 +0000 (09:58 +0000)]
Merge "Sonar Fix: VduArtifact.java"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Tue, 30 Jul 2019 09:57:48 +0000 (09:57 +0000)]
Merge "Javadoc and logging improvement"

4 years agoReplaced constructor calls with valueOf() method calls 48/92248/1
Oleksandr Moliavko [Tue, 30 Jul 2019 07:51:07 +0000 (10:51 +0300)]
Replaced constructor calls with valueOf() method calls
to remove static analyzer warnings about inefficient
constructor calls

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If5b0c9c3569759f738e01c0352e267ee8a995c5f

4 years agoReplaced constructor call with valueOf() call to 41/92241/1
Oleksandr Moliavko [Tue, 30 Jul 2019 06:04:41 +0000 (09:04 +0300)]
Replaced constructor call with valueOf() call to
remove static analyzer warning about inefficient
use of constructor

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5b6285aa8708b57bb54a90d38130a21b07c2b2c5

4 years agoMerge "repair vfcInstanceGroup order"
Seshu Kumar M [Tue, 30 Jul 2019 05:46:43 +0000 (05:46 +0000)]
Merge "repair vfcInstanceGroup order"

4 years agoRemoved subscriber variable that was not actually 40/92240/1
Oleksandr Moliavko [Tue, 30 Jul 2019 05:36:52 +0000 (08:36 +0300)]
Removed subscriber variable that was not actually
used in any test (to remove static analyzer
warning)

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I7665c3dcb85d5c0d80c0448e6ad5ff1ece5a0bef

4 years agoapih allowing requests with the same requestid 29/92229/2
Plummer, Brittany [Mon, 29 Jul 2019 18:33:20 +0000 (14:33 -0400)]
apih allowing requests with the same requestid

Updated filters to throw error on duplicate requestId
Added message indicating exception will be thrown
Added unit tests for requestIdFilters
Added access modifier in filter test
Updated CloudApiRequests for successful deletion when
InfraActiveRequest is deleted
Removed changes from CloudApiRequests bean
Updated repository to include deleteByRequestId
Removed unused import from cloudApiRequests
Removed deleteByRequestId from interface
Updated to change type of extended jparepository
Removed repository added for CloudApiRequests
Updated uri check to remove '/' from checked string
Updated returned on failing junit test
Updated access modifiers for logger and createRequestError

Issue-ID: SO-2166
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id0cee672567b15e0a3eb1acfbdfb967945494500

4 years agoMerge "Implement TLS for calls into VNFM adapter"
Steve Smokowski [Mon, 29 Jul 2019 14:11:55 +0000 (14:11 +0000)]
Merge "Implement TLS for calls into VNFM adapter"

4 years agoMerge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Mon, 29 Jul 2019 12:42:01 +0000 (12:42 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"

4 years agoMerge "Upgrade springboot.version from 2.0.5 to 2.1.5."
Steve Smokowski [Mon, 29 Jul 2019 12:39:09 +0000 (12:39 +0000)]
Merge "Upgrade springboot.version from 2.0.5 to 2.1.5."

4 years agoMerge "validate model info for existing service with"
Steve Smokowski [Mon, 29 Jul 2019 12:38:33 +0000 (12:38 +0000)]
Merge "validate model info for existing service with"

4 years agoMerge "Use BuildingBlockExecution for PauseForManualTasks"
Steve Smokowski [Mon, 29 Jul 2019 12:38:27 +0000 (12:38 +0000)]
Merge "Use BuildingBlockExecution for PauseForManualTasks"

4 years agoMerge "Add SpringClientFilter in ValetClient to autolog"
Steve Smokowski [Mon, 29 Jul 2019 12:38:12 +0000 (12:38 +0000)]
Merge "Add SpringClientFilter in ValetClient to autolog"

4 years agoMerge "set multi-stage flag in listener to log success"
Steve Smokowski [Mon, 29 Jul 2019 12:38:06 +0000 (12:38 +0000)]
Merge "set multi-stage flag in listener to log success"

4 years agoMerge "store heat env file sent to heat"
Steve Smokowski [Mon, 29 Jul 2019 12:37:40 +0000 (12:37 +0000)]
Merge "store heat env file sent to heat"

4 years agoVulnerability fixes in ServicePluginFactory 90/92190/1
r.bogacki [Mon, 29 Jul 2019 11:15:40 +0000 (13:15 +0200)]
Vulnerability fixes in ServicePluginFactory

Vulnerability fixes in ServicePluginFactory according to the Sonar.
-Made constants final.
-Changed access scopes from public to private.

Issue-ID: SDC-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2

4 years agoJavadoc and logging improvement 89/92189/1
SunilB [Mon, 29 Jul 2019 11:10:25 +0000 (16:40 +0530)]
Javadoc and logging improvement

Added Javadocs for SDNCQueryTasts and
SDNCVnfResources classes

Issue-ID: SO-2052
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: I79d7e6b8a82327caaa16c49a64df7b1a02dcbb03

4 years agorepair vfcInstanceGroup order 71/92171/1
zm330 [Mon, 29 Jul 2019 07:19:40 +0000 (15:19 +0800)]
repair vfcInstanceGroup order

Issue-ID: SO-2164
Change-Id: I827342692dc4e4241b22c6eb8dd455b2b9385fa8
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
4 years agoUpgrade springboot.version from 2.0.5 to 2.1.5. 17/92017/2
Sangalang, Felix [Thu, 25 Jul 2019 15:07:49 +0000 (10:07 -0500)]
Upgrade springboot.version from 2.0.5 to 2.1.5.

Upgrade springboot.version from 2.0.5 to 2.1.5.
Fixed APIHandler junit test cases with expected DB error messages.

Issue-ID: SO-2157
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0

4 years agovalidate model info for existing service with 32/92132/1
Mnushkin, Dmitry [Fri, 26 Jul 2019 17:17:12 +0000 (13:17 -0400)]
validate model info for existing service with

verify modelVersionId equals during SI AAI validation
correct SI name in junit test
update SI name in junit test comparison
add name/module id verifications for other objects
add back junit file after merge from remote
format jnit file after verify job failure
updated test input values for clarity
update name verifications with related ID values
adding junit for Configuration name verification
updated aai verify call, service dup error msg
removed aai depth 2 and refactored private test method
implement SI name verification with 3 additional fields
fix formatting comment line length limitation

Issue-ID: SO-2161
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I43f5cb0601dfa8b41f474615b639fce0572f5613

4 years agofix malformed tables in docs 25/92125/1
k.kazak [Fri, 26 Jul 2019 15:04:59 +0000 (17:04 +0200)]
fix malformed tables in docs

Fixed malformed tables in SO Interfaces documentation page

Change-Id: I77e4a272bbcc735da8c07dc45cf548787091e0a0
Issue-ID: SO-2152
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoMerge changes I3e363f64,I52ec2fc9
subhash kumar singh [Fri, 26 Jul 2019 12:13:00 +0000 (12:13 +0000)]
Merge changes I3e363f64,I52ec2fc9

* changes:
  include a bak folder for obsolete files
  updated the doc as per the request

4 years agoMerge "Fixed sonar issue in QueryServiceVnfs.java"
Seshu Kumar M [Fri, 26 Jul 2019 12:11:43 +0000 (12:11 +0000)]
Merge "Fixed sonar issue in QueryServiceVnfs.java"

4 years agoMerge "Fix the License issue inside the sample csar"
subhash kumar singh [Fri, 26 Jul 2019 12:10:24 +0000 (12:10 +0000)]
Merge "Fix the License issue inside the sample csar"

4 years agoMerge "Enhanced List Level flow with backward support"
Seshu Kumar M [Fri, 26 Jul 2019 12:10:09 +0000 (12:10 +0000)]
Merge "Enhanced List Level flow with backward support"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Fri, 26 Jul 2019 12:09:44 +0000 (12:09 +0000)]
Merge "Javadoc and logging improvement"

4 years agoMerge "fix image urls in docs"
Byung-Woo Jun [Fri, 26 Jul 2019 11:32:53 +0000 (11:32 +0000)]
Merge "fix image urls in docs"

4 years agoJavadoc and logging improvement 48/91948/2
Pooja03 [Fri, 26 Jul 2019 11:08:29 +0000 (16:38 +0530)]
Javadoc and logging improvement

Added Javadocs for four classes
AAIUpdateTasks,OrchestrationStatusValidator,AAICreateTasks ,BBInputSetup

Issue-ID: SO-2052
Signed-off-by: Pooja03 <pm00501616@techmahindra.com>
Change-Id: I048b42131449e151be91839e45f4d39864b3ec52

4 years agoEnhanced List Level flow with backward support 39/91839/5
sarada prasad sahoo [Mon, 22 Jul 2019 11:25:12 +0000 (16:55 +0530)]
Enhanced List Level flow with backward support

Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.

Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
4 years agoUse BuildingBlockExecution for PauseForManualTasks 11/92111/1
Elena Kuleshov [Fri, 26 Jul 2019 06:34:19 +0000 (02:34 -0400)]
Use BuildingBlockExecution for PauseForManualTasks

Fix variable settings and execution object usage for manual tasks.

Issue-ID: SO-2113
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I3fa24d70b46658ce5afcdc843d5482e157641112

4 years agoJavadoc and logging improvement 68/92068/2
SunilB [Fri, 26 Jul 2019 04:07:49 +0000 (09:37 +0530)]
Javadoc and logging improvement

Added Javadocs for VnfAdapterVfModuleResources and
VnfTopologyOperationRequestMapper classes

Issue-ID: SO-2052
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: Iec6addb415720f63c32b5ab99e63aefe0ef3235a

4 years agoMerge "update readme.md"
Byung-Woo Jun [Fri, 26 Jul 2019 00:29:36 +0000 (00:29 +0000)]
Merge "update readme.md"

4 years agoAdd SpringClientFilter in ValetClient to autolog 38/92038/1
Mcblain, Thomas [Thu, 25 Jul 2019 17:57:43 +0000 (13:57 -0400)]
Add SpringClientFilter in ValetClient to autolog

Add SpringClientFilter in ValetClient to autolog msgs
Modify to use our RestTemplateConfig for RestTemplate
Use Provider for thread-safe RestTemplate autowire

Issue-ID: SO-2160
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I02d1995ebd6d2c93477008feb13193d3c0b3cd05

4 years agoset multi-stage flag in listener to log success 34/92034/1
Benjamin, Max [Thu, 25 Jul 2019 17:36:18 +0000 (13:36 -0400)]
set multi-stage flag in listener to log success

fixed null pointer error when multistage not set

Issue-ID: SO-2159
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I1f2313d074bea404776877ef56607a814e46e514

4 years agostore heat env file sent to heat 18/92018/1
Gamboa, Gilbert [Thu, 25 Jul 2019 15:10:05 +0000 (11:10 -0400)]
store heat env file sent to heat

Initial commit, include heat environment info in cloud-api_requests.
Updated MSOHeatUtilsTest.saveStackTest unit test to assert
cloudApiRequests requestBody

Issue-ID: SO-2158
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I333cae7746459917ba5e64feb07db4f710b8d99b

4 years agofix image urls in docs 15/92015/1
Katsiaryna Kazak/ONAP (NC) /SRPOL/Engineer/삼성전자 [Thu, 25 Jul 2019 14:08:58 +0000 (16:08 +0200)]
fix image urls in docs

Corrected image URL for SO Install Docker documentation page
Corrected images URLs for SO Configure git & gerrit documentation page

Issue-ID: SO-2150, SO-2151
Signed-off-by: Katsiaryna Kazak <k.kazak@samsung.com>
Change-Id: Ib163c3159ae284f6c731795b0cbb53ed176ade11

4 years agoupdate readme.md 88/91888/2
Katsiaryna Kazak/ONAP (NC) /SRPOL/Engineer/삼성전자 [Tue, 23 Jul 2019 17:44:54 +0000 (19:44 +0200)]
update readme.md

Updated developer documentation in readme.md:
components, how to compile, format, build docker images,
images list, how to start them

Issue-ID: SO-2148
Signed-off-by: Katsiaryna Kazak <k.kazak@samsung.com>
Change-Id: Ib0e8e78af3e4497d8d9a6789c3af49f7025ba428

4 years agoMerge "Fix delete of generic neutron network"
Seshu Kumar M [Thu, 25 Jul 2019 09:41:15 +0000 (09:41 +0000)]
Merge "Fix delete of generic neutron network"

4 years agofix architecture.rst formatting 40/91940/3
k.kazak [Wed, 24 Jul 2019 12:28:09 +0000 (14:28 +0200)]
fix architecture.rst formatting

Fixed Warning message on SO Architecture page in documentation:
System Message: WARNING/2
(/home/docs/checkouts/readthedocs.org/user_builds/onap/checkouts/latest/docs/submodules/so.git/docs/architecture/architecture.rst, line 6)
Title underline too short.

Change-Id: Ibf019132e64d1fef3f62efe7a1ce0cbafac647a5
Issue-ID: SO-2146
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoFix delete of generic neutron network 71/91971/1
Eric Multanen [Thu, 25 Jul 2019 05:36:13 +0000 (22:36 -0700)]
Fix delete of generic neutron network

Delete of Generic Neutron network was not working.
Logic checking for association with vf-module appears to
have been reversed.

Change-Id: If541c1133322f75c70f86cd77d8bccd88b94f356
Issue-ID: SO-2082
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
4 years agoset multi-stage flag in listener to log success 60/91960/1
Mnushkin, Dmitry [Wed, 24 Jul 2019 16:44:16 +0000 (12:44 -0400)]
set multi-stage flag in listener to log success

set multi-stage flag in listener to log success msg
added post listener for requests db object

Issue-ID: SO-2153
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I4b27cbb69b983bd2f7c0d72c8ebb4d9c43201120

4 years agoMerge "Major Sonar fixes in InstanceManagement"
Steve Smokowski [Wed, 24 Jul 2019 15:02:34 +0000 (15:02 +0000)]
Merge "Major Sonar fixes in InstanceManagement"

4 years agoMerge "Removed not used loggers"
Steve Smokowski [Wed, 24 Jul 2019 15:02:17 +0000 (15:02 +0000)]
Merge "Removed not used loggers"

4 years agoMerge "Major Sonar fixes in E2EServiceInstances"
Steve Smokowski [Wed, 24 Jul 2019 15:00:37 +0000 (15:00 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"

4 years agoMerge "Major Sonar fixes"
Steve Smokowski [Wed, 24 Jul 2019 14:59:27 +0000 (14:59 +0000)]
Merge "Major Sonar fixes"

4 years agoMerge "enhance get orchestration request"
Steve Smokowski [Wed, 24 Jul 2019 14:59:12 +0000 (14:59 +0000)]
Merge "enhance get orchestration request"

4 years agoMerge "Update SO to handle Async VNF operations to SDNC"
Steve Smokowski [Wed, 24 Jul 2019 14:59:09 +0000 (14:59 +0000)]
Merge "Update SO to handle Async VNF operations to SDNC"

4 years agoinclude a bak folder for obsolete files 34/91934/1
seshukm [Wed, 24 Jul 2019 10:07:40 +0000 (15:37 +0530)]
include a bak folder for obsolete files

Issue-ID: SO-1230

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I3e363f6445f6f76b62f0ca1bf9467fd795db50e7

4 years agoupdated the doc as per the request 33/91933/1
seshukm [Wed, 24 Jul 2019 10:06:05 +0000 (15:36 +0530)]
updated the doc as per the request

Issue-ID: SO-1230

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I52ec2fc97abfd71b31a59fcb0416b0472e83d39c

4 years agoRemoved not used loggers 29/91929/1
r.bogacki [Wed, 24 Jul 2019 08:45:01 +0000 (10:45 +0200)]
Removed not used loggers

-Removed unnecessary loggers according to Sonar.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I05a0cc3187692fa17a6734d1c2a6be33d4b5ee34

4 years agoMajor Sonar fixes in InstanceManagement 16/91916/1
r.bogacki [Wed, 24 Jul 2019 07:06:26 +0000 (09:06 +0200)]
Major Sonar fixes in InstanceManagement

-Removed unnecessary code.
-Removed unused variables.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb

4 years agoMajor Sonar fixes in E2EServiceInstances 14/91914/1
r.bogacki [Wed, 24 Jul 2019 06:57:43 +0000 (08:57 +0200)]
Major Sonar fixes in E2EServiceInstances

-Removed unnecessary code.
-Removed unused variables.
-Introduced constants for repeating Strings.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4ac692849508178390796d149b2c3f2fddcd093b

4 years ago- Converted NetworkResource to use the parser 75/91875/1
Merkel, Jeff [Tue, 23 Jul 2019 15:43:21 +0000 (11:43 -0400)]
- Converted NetworkResource to use the parser

- Converted NetworkResource to use the parser getEntity method.
- run the formatting command so that it aligns correctly.

Issue-ID: SO-2147
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id6aa6c2967ec4014d6512851fa7dfff088946081

4 years agoMajor Sonar fixes 45/91845/1
r.bogacki [Tue, 23 Jul 2019 07:20:28 +0000 (09:20 +0200)]
Major Sonar fixes

Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
-Improved String comparisons in equals.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f

4 years agoMerge "Enhanced List Level flow with backward support"
Seshu Kumar M [Tue, 23 Jul 2019 05:30:31 +0000 (05:30 +0000)]
Merge "Enhanced List Level flow with backward support"

4 years agoImplement TLS for calls into VNFM adapter 15/91815/1
MichaelMorris [Mon, 22 Jul 2019 14:28:09 +0000 (14:28 +0000)]
Implement TLS for calls into VNFM adapter

Issue-ID: SO-2143
Change-Id: I2fcacab7aebc9a22b952d881b0bf2404e1638b37
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoenhance get orchestration request 11/91811/1
Plummer, Brittany [Mon, 22 Jul 2019 13:44:15 +0000 (08:44 -0500)]
enhance get orchestration request

Enhance get orchestration request to include workflow step
Began working on adding call for activity name
Added call to return activity information
Updated to return last task executed
Added last task executed info to returned string
Updated mocks to fix failing unit tests
Added responses for mocks to Camunda for process and activity history
Added tests to cover taskName changes
Began adding tests to cover changes to RequestHandlerUtils
Added more unit tests for activity lookup
Updated error messages for taskName
Moved properties to application.yaml file
Added unit tests to add more coverage to task retrieval
Moved Camunda calls to CamundaRequestHandler class
Removed unused imports from RequestHandlerUtils
Fixed formatting of tests and removed handler where not used
Removed CamundaRequestHandler from JerseyConfiguration
Added retryTemplate for camunda calls

Issue-ID: SO-2142
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a

4 years agoUpdate SO to handle Async VNF operations to SDNC 10/91810/1
Smokowski, Steven [Mon, 22 Jul 2019 13:42:42 +0000 (08:42 -0500)]
Update SO to handle Async VNF operations to SDNC

Update SO to handle Async VNF operations to SDNC

Issue-ID: SO-2141
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I20037306e9ce5b8df434511a46c0a3399e335c3d

4 years agoMerge "Added servicename to MDC so that it gets logged"
Steve Smokowski [Mon, 22 Jul 2019 13:17:29 +0000 (13:17 +0000)]
Merge "Added servicename to MDC so that it gets logged"

4 years agoVulnerability fixes in ServicePluginFactory 98/91798/1
r.bogacki [Mon, 22 Jul 2019 09:28:57 +0000 (11:28 +0200)]
Vulnerability fixes in ServicePluginFactory

Sonar vulnerability fixes in ServicePluginFactory:
-Added logger.

Issue-ID: SO-2139
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca

4 years agoAdded servicename to MDC so that it gets logged 97/91697/2
Boslet, Cory [Thu, 18 Jul 2019 20:20:38 +0000 (16:20 -0400)]
Added servicename to MDC so that it gets logged

Added servicename to MDC so that it gets logged and added enter and
exit markers.

Issue-ID: SO-2122
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead

4 years agoMerge "basic auth for so-monitoring"
Byung-Woo Jun [Fri, 19 Jul 2019 13:58:55 +0000 (13:58 +0000)]
Merge "basic auth for so-monitoring"

4 years agobasic auth for so-monitoring 94/90794/5
k.kazak [Fri, 19 Jul 2019 12:59:18 +0000 (14:59 +0200)]
basic auth for so-monitoring

Add basic auth for so-monitoring app
Issue submitted in pentest report

Change-Id: I8e826da9b9f66e893826fd9b40b3b26623b2ab8d
Issue-ID: OJSI-169
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoMerge "Set networkName value to the name from L3network"
Steve Smokowski [Fri, 19 Jul 2019 12:04:33 +0000 (12:04 +0000)]
Merge "Set networkName value to the name from L3network"

4 years agoFix the License issue inside the sample csar 35/91735/1
seshukm [Fri, 19 Jul 2019 11:11:56 +0000 (16:41 +0530)]
Fix the License issue inside the sample csar

Issue-ID: SO-2138

Change-Id: I0dd532abf983a248b60f91aea4a6fbd05e33daab
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
4 years agoSonar fix: HealthStackAudit.java 34/91734/1
Arundathi Patil [Fri, 19 Jul 2019 10:16:11 +0000 (15:46 +0530)]
Sonar fix: HealthStackAudit.java

Fixed sonar issues across this file

Issue-ID: SO-2137
Change-Id: I7650e1746bc3da5149310e6eb4b53f2ee98e3d9f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoSonar fix: CreateVfModuleRequest.java 32/91732/1
Arundathi Patil [Fri, 19 Jul 2019 10:11:10 +0000 (15:41 +0530)]
Sonar fix: CreateVfModuleRequest.java

Fixed sonar issues across this file

Issue-ID: SO-2135
Change-Id: I77071a51c7bda9e9eb44dbedab2b17576b69d608
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"
Steve Smokowski [Thu, 18 Jul 2019 20:41:44 +0000 (20:41 +0000)]
Merge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"

4 years agoMerge "Commented out updatedAttribute declaration to prevent static analyzer warning...
Steve Smokowski [Thu, 18 Jul 2019 20:41:30 +0000 (20:41 +0000)]
Merge "Commented out updatedAttribute declaration to prevent static analyzer warning about unused variable"

4 years agoMerge changes I5e72e1c6,I5e1cb624
Steve Smokowski [Thu, 18 Jul 2019 20:40:57 +0000 (20:40 +0000)]
Merge changes I5e72e1c6,I5e1cb624

* changes:
  Added null check for function param pFqdns to prevent crash at for loop.
  Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning

4 years agoMerge "Fix error updating request_processing_data"
Steve Smokowski [Thu, 18 Jul 2019 20:40:14 +0000 (20:40 +0000)]
Merge "Fix error updating request_processing_data"

4 years agoMerge "Remove duplicate name check in createAAITasks."
Steve Smokowski [Thu, 18 Jul 2019 20:40:04 +0000 (20:40 +0000)]
Merge "Remove duplicate name check in createAAITasks."

4 years agoSet networkName value to the name from L3network 00/91700/1
Kuleshov, Elena [Thu, 18 Jul 2019 20:40:01 +0000 (16:40 -0400)]
Set networkName value to the name from L3network

Set networkName value to the name from L3network object.
Add JUnit argument captures for naming creates
Fix formatting errors in the JUnit file.

Issue-ID: SO-2123
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ie4d2bd86f1a47bd5742aa7786dc9cba47fa11392

4 years agoRemoving application-local.yaml files 94/91694/1
Roy, Amresh [Thu, 18 Jul 2019 19:21:23 +0000 (14:21 -0500)]
Removing application-local.yaml files

Removing the application-local.yaml files because they're no longer
maintained or working.

Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359

4 years agoFix error updating request_processing_data 92/91692/1
Gamboa, Gilbert [Thu, 18 Jul 2019 18:37:21 +0000 (14:37 -0400)]
Fix error updating request_processing_data

Fix error when updating existing record in request_processing_data
table.
Use correct field name in the toString method in RequestProcessingData
bean class.
RequestDbClient.updateRequestProcessingData should include entity id in
the URI on the PUT request.
Add new Config class ExposeEntityIdResourceConfiguration to make
Spring data Rest return id in the response for RequestProcessingData.
Make spring-boot-starter-data-rest not optional dependency in
mso-requests-db-repositories
Added unit test for RequestDbClient.updateRequestProcessingData()
method.

Issue-ID: SO-2120
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I733be06185e5c19a0b7112918ce0a0f2abf861d7

4 years agoMerge "Implement TLS for calls from VNFM adapter to VNFM"
Steve Smokowski [Thu, 18 Jul 2019 18:22:15 +0000 (18:22 +0000)]
Merge "Implement TLS for calls from VNFM adapter to VNFM"

4 years agoRemove duplicate name check in createAAITasks. 81/91681/1
Gamboa, Gilbert [Thu, 18 Jul 2019 15:28:01 +0000 (11:28 -0400)]
Remove duplicate name check in createAAITasks.

Remove duplicate name check in createAAITasks. This hould be done prior
to status check in WorkflowAction or BBInputSetup.

Issue-ID: SO-2119
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I0d6d34476b1ab2b351314c9a23926f2fff0e4f89

4 years agoMerge "Commented out initialization of workflowResponse to prevent static analyzer...
Steve Smokowski [Thu, 18 Jul 2019 11:55:25 +0000 (11:55 +0000)]
Merge "Commented out initialization of workflowResponse to prevent static analyzer warning about workflowResponse never being set to anything but null."

4 years agoMerge "Fixes in WorkflowAction"
Steve Smokowski [Thu, 18 Jul 2019 11:53:25 +0000 (11:53 +0000)]
Merge "Fixes in WorkflowAction"

4 years agoMerge "Major Sonar fixes"
Steve Smokowski [Thu, 18 Jul 2019 11:53:09 +0000 (11:53 +0000)]
Merge "Major Sonar fixes"

4 years agoMerge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Thu, 18 Jul 2019 11:52:22 +0000 (11:52 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"

4 years agoMerge "Add requestContext to unassignVfModule tasks and"
Steve Smokowski [Thu, 18 Jul 2019 11:52:03 +0000 (11:52 +0000)]
Merge "Add requestContext to unassignVfModule tasks and"

4 years agoMerge "Add SO BPMN name for NAME in tbl workflow"
Steve Smokowski [Thu, 18 Jul 2019 11:51:52 +0000 (11:51 +0000)]
Merge "Add SO BPMN name for NAME in tbl workflow"