mpriyank [Mon, 13 May 2024 17:22:14 +0000 (18:22 +0100)]
Maven stage yaml for CPS 3.4.9
- maven stage yaml to release CPS 3.4.9
Issue-ID: CPS-2221
Change-Id: Ifc16ed01cc4d7928d5f9ec86ebe668ab26285584
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Daniel Hanrahan [Fri, 10 May 2024 13:22:05 +0000 (13:22 +0000)]
Merge "Ncmp out event for REJECTED scenario"
mpriyank [Thu, 9 May 2024 15:04:40 +0000 (16:04 +0100)]
Ncmp out event for REJECTED scenario
- Handling and publishing the event to client when dmi plugin rejects
applying the subscription
- test scenarios to support the same
Issue-ID: CPS-2214
Change-Id: I2ac6d125a7262a7428a962d81a26a33594b570d9
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
halil.cakal [Thu, 9 May 2024 14:24:46 +0000 (15:24 +0100)]
Fine tuning of the performance plots
- Fine tune some of the performance plots which are
not align to the limit
Issue-ID: CPS-2200
Change-Id: I925443aa74a4eb814728d0642db0951c76f86186
Signed-off-by: halil.cakal <halil.cakal@est.tech>
mpriyank [Thu, 9 May 2024 10:46:09 +0000 (11:46 +0100)]
Release note for cps-change-event toggle
- Release notes to enable and disable the toggle functionality
introduced.
- If the CPS change events are of no interest to them then they can be
disabled by the environment variable CPS_CHANGE_EVENT_NOTIFICATIONS_ENABLED
Issue-ID: CPS-2211
Change-Id: If2fddb6a499e24194b3eeca2ecdf99b8fb5ec687
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Tue, 7 May 2024 14:33:19 +0000 (15:33 +0100)]
Conditional cps change events
- introduced a parameter to control the cps core change event
notifications. we should be able to disable these notifications
without affecting other notification flows.
- fixed the LayeredArchitectureTest as we are accessing the Anchor model
in the events package now.
Issue-ID: CPS-2213
Change-Id: Id875925bc14de1cc6e8fa3193c0df470e09fe43f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Lee Anjella Macabuhay [Tue, 7 May 2024 09:57:09 +0000 (09:57 +0000)]
Merge "Schedule response to client"
Lee Anjella Macabuhay [Fri, 3 May 2024 14:55:32 +0000 (14:55 +0000)]
Merge "[BUG] Correctly parse observedTimestamp"
mpriyank [Fri, 3 May 2024 12:45:03 +0000 (13:45 +0100)]
[BUG] Correctly parse observedTimestamp
- Using the DateTimeUtility to parse the passed OffsetDateTime and using
it for conversion to string
- Moving to actual src/main/java from test side as it is to be used in
the prod code as well and only keeping the methods in use.
- Added test to fix the coverage issue
Issue-ID: CPS-2211
Change-Id: I2b4325bb77a6da7fd470986b1da293f455650375
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Fri, 3 May 2024 13:13:36 +0000 (13:13 +0000)]
Merge "Release notes is updated for error hanndling related to upgrade operation"
sourabh_sourabh [Fri, 3 May 2024 12:10:36 +0000 (13:10 +0100)]
Release notes is updated for error hanndling related to upgrade
operation
Issue-ID: CPS-2204
Change-Id: Iaa3f61c53e4120cdf19b7ad1c3313fc32f904866
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Thu, 2 May 2024 09:26:16 +0000 (10:26 +0100)]
Make NCMP integration tests use MockWebServer
Change from using MockRestServiceServer - which is only compatible
with RestTemplate - to MockWebServer, which will allow tests to work
using WebClient instead of RestTemplate.
Issue-ID: CPS-2183
Change-Id: I7494fe17cba6e92f7df81f0fd0185e1d2b5a5541
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
mpriyank [Fri, 3 May 2024 09:48:04 +0000 (10:48 +0100)]
Schedule response to client
- Scheduling sending the response by reading whatever is present in the
cache for subscription after a pre-configured time.
- Also added test validation for the same
Issue-ID: CPS-2209
Change-Id: Ifacb0b12734a0529e671b0b63836189a243e453c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Daniel Hanrahan [Thu, 2 May 2024 09:42:34 +0000 (09:42 +0000)]
Merge "Query operation path by alternate id"
sourabh_sourabh [Thu, 2 May 2024 09:08:04 +0000 (10:08 +0100)]
Handle error in case of upgrade operation
- Send an error response if cm handle not found for upgrade operation.
- Restrict upgrade operation if it is already in progress.
Issue-ID:CPS-2204
Change-Id: Iad63732c5b1d2215b06a09ddda1c0c604cd7648c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Priyank Maheshwari [Thu, 2 May 2024 08:58:44 +0000 (08:58 +0000)]
Merge "Add Notification support in cps core"
Daniel Hanrahan [Wed, 1 May 2024 13:45:20 +0000 (13:45 +0000)]
Merge "CM Subscription: Link method to publish to DMI in service layer"
danielhanrahan [Wed, 1 May 2024 12:53:00 +0000 (13:53 +0100)]
Bump CPS version
- bump cps to 3.4.9-SNAPSHOT
- also updated the release notes
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ifd7feb413baac30e3cbbdf2aeaac5fbb5ae2e463
danielhanrahan [Wed, 1 May 2024 12:22:56 +0000 (13:22 +0100)]
Container YAML for CPS 3.4.8
- added container yaml for cps 3.4.8
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Id6ef50ab413bb910fa6ea866964ffe01d90b9b29
danielhanrahan [Wed, 1 May 2024 11:43:16 +0000 (12:43 +0100)]
Maven stage yaml for 3.4.8
- added maven stage yaml to release CPS 3.4.8 version
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ic734ec947de86a30cf7b3f080a82c518403a4f5f
danielhanrahan [Wed, 1 May 2024 10:25:36 +0000 (11:25 +0100)]
Update OpenAPI docs for 3.4.8
Issue-ID: CPS-2205
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib520a55b099b7a89751dab7032cabeba19b6a934
emaclee [Tue, 30 Apr 2024 17:18:31 +0000 (18:18 +0100)]
CM Subscription: Link method to publish to DMI in service layer
- Add call to method to publish to DMI for create request
- Refactor calls to all Mappers to a single Mapper class handler
Issue-ID: CPS-2196
Change-Id: I6476f47684ea9a0f55a7d207c1931a0fef8aa672
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Fri, 26 Apr 2024 10:55:55 +0000 (11:55 +0100)]
Release notes update for 3.4.8
Add release notes updates for bug fix CPS-2190 (slow module search)
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I9c4500727640040593aacbd209c2d5ec6a86a315
Daniel Hanrahan [Tue, 30 Apr 2024 14:50:15 +0000 (14:50 +0000)]
Merge "[BUG]Defaults for cps and dmi user and pass"
Priyank Maheshwari [Tue, 30 Apr 2024 14:44:15 +0000 (14:44 +0000)]
Merge "CM Subscription: REfactor classes of producers and consumers"
mpriyank [Tue, 30 Apr 2024 09:14:26 +0000 (10:14 +0100)]
[BUG]Defaults for cps and dmi user and pass
- provided default values for DMI_USERNAME and DMI_PASSWORD which is
required to set when DMI_AUTH_ENABLED is true
- Also provided defaults for CPS_USERNAME and CPS_PASSWORD as its
been used in the logback xml file and if not provided then causes an
issue with the logger
Issue-ID: CPS-2194
Change-Id: I70fdbeca970556c7bd19f27c1b6b5123fd591283
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
sourabh_sourabh [Tue, 30 Apr 2024 12:19:11 +0000 (13:19 +0100)]
Reverted web client changes as it breaking CPS functionality:
1. Error handling not working
2. Unable to make dmi call as url appens extra "/"
Commit 1: Replace RestTemplate with WebClient in synchronous DMI calls
- added DmiWebClientConfiguration
- use WebClient in DmiRestClient
- fixed unit tests
- ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
- encode query params for DMI requests
Commit 2: Module sync task failing with WebClient
- added configurable buffer size
Commit 3: Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize
Issue-ID:CPS-989, CPS-2195, CPS-2198
Change-Id: I6c71ab2801b222708404f51bd60f2b3031ebf32e
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
rajesh.kumar [Fri, 23 Feb 2024 14:59:59 +0000 (20:29 +0530)]
Add Notification support in cps core
Add notification support using cloud events
Issue-ID:CPS-2068
Change-Id: I56c34400dc73c71b936a51260efd240223babacd
Signed-off-by: rajesh.kumar <rk00747546@techmahindra.com>
Daniel Hanrahan [Tue, 30 Apr 2024 09:15:24 +0000 (09:15 +0000)]
Merge "Ajust time limits for performance tests"
emaclee [Mon, 29 Apr 2024 09:30:20 +0000 (10:30 +0100)]
CM Subscription: REfactor classes of producers and consumers
Issue-ID: CPS-2196
Change-Id: I0b56f37a1b615b9615d6bd7005348733e1739a46
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
sourabh_sourabh [Mon, 29 Apr 2024 14:42:22 +0000 (15:42 +0100)]
Re-use ncmp.dmi.httpclient.maximumConnectionsTotal parameter
(as documented in RTD) to control webclient connection poolsize
Issue-ID: CPS-2198
Change-Id: Id441208c66433b2539adf83a0881c3c3c79d2b15
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Wed, 24 Apr 2024 11:29:53 +0000 (12:29 +0100)]
Query operation path by alternate id
- New method is written to find longest match for fdn path
- Introduced new exception for alternate id
Issue-ID: CPS-2142
Change-Id: Ifd048574db88586a2d37a3681034a083eb2b7691
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
halil.cakal [Mon, 29 Apr 2024 14:39:10 +0000 (15:39 +0100)]
Ajust time limits for performance tests
- new time limits adjusted for dedicated
physical cps-performance test-server
Issue-ID: CPS-2192
Change-Id: Ia258a8f7460b3fbe68e5b3b61bc918f7d394c1b1
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Daniel Hanrahan [Mon, 29 Apr 2024 10:52:08 +0000 (10:52 +0000)]
Merge "Module sync task failing with WebClient"
Priyank Maheshwari [Mon, 29 Apr 2024 10:21:46 +0000 (10:21 +0000)]
Merge "CM SUBSCRIPTION: Remove accepted and rejected cache entries"
leventecsanyi [Fri, 26 Apr 2024 11:35:32 +0000 (13:35 +0200)]
Module sync task failing with WebClient
- added configurable buffer size
Issue-ID: CPS-2195
Change-Id: I7cdb09856fd4d80134a91e54faa7e6600f3721dc
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
emaclee [Thu, 25 Apr 2024 12:01:06 +0000 (13:01 +0100)]
CM SUBSCRIPTION: Remove accepted and rejected cache entries
Issue-ID: CPS-2185
Change-Id: I01ba8e4f6e0e42a31ad5234ad468ac4625c2b0f3
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Fri, 26 Apr 2024 09:09:54 +0000 (10:09 +0100)]
Faster module searches (CPS-2190 #3)
This greatly improves performance of module searches by eliminating
unneeded SQL queries via Hibernate lazy fetching.
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie9e65017d0027366456f1741cc37b10679317b25
danielhanrahan [Thu, 25 Apr 2024 13:33:05 +0000 (14:33 +0100)]
[BUG] Remove slow validation check during module search (CPS-2190 #2)
The check for existing modules is extremely slow, being dependent on
the file sizes of the Yang modules being queries.
The validation check is also completely unnecessary, since it simply
ignores any exceptions and returns an empty set, which the main logic
does implicitly. (The Dataspace check is also not needed, as the NCMP
dataspace is guaranteed to exist.)
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I329c1f8aac3f50bda0333e6c9c686f47af2e009f
danielhanrahan [Wed, 24 Apr 2024 13:15:47 +0000 (14:15 +0100)]
Perf Test for Module Search is dependent on module size (CPS-2190 #1)
Add a new test showing that Yang module search is dependent on the
file size of the Yang modules being searched for.
Issue-ID: CPS-2190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I8fd28f4c91be11ef7428251397a887af17649015
leventecsanyi [Thu, 18 Apr 2024 14:30:29 +0000 (16:30 +0200)]
Replace RestTemplate with WebClient in synchronous DMI calls
- added DmiWebClientConfiguration
- use WebClient in DmiRestClient
- fixed unit tests
- ingnored failing NCMP related integration tests (related to WebClient, will be fixed in a future patch)
- encode query params for DMI requests
Issue-ID:CPS-989
Change-Id: I26434568f68266e95669a51c134978ddd197d802
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Priyank Maheshwari [Wed, 24 Apr 2024 16:22:49 +0000 (16:22 +0000)]
Merge "Reject create request with duplicated subscriptionId"
emaclee [Tue, 16 Apr 2024 08:56:59 +0000 (09:56 +0100)]
Reject create request with duplicated subscriptionId
Issue-ID: CPS-2184
Change-Id: I1bddb02239e6a2d3f47aa731eb24a9f1f64e63b5
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Signed-off-by: seanbeirne <sean.beirne@est.tech>
mpriyank [Wed, 24 Apr 2024 11:03:46 +0000 (12:03 +0100)]
NcmpCloudEventBuilder refactoring
- Builder named as NcmpEvent and we have specialised method to build the
NcmpEvent as cloud event now
- Introduced source as the builder default property
Issue-ID: CPS-2191
Change-Id: I51c571313091ce9a4d10f4e1af7423eee999cea8
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
danielhanrahan [Tue, 16 Apr 2024 21:04:44 +0000 (22:04 +0100)]
[BUG] Make failed async task report failure on Kafka topic
- In event of async task timeout, error code 102
(DMI_SERVICE_NOT_RESPONDING) is sent to client topic.
- In event of unexpected error (such as database unavailable),
error code 108 (UNKNOWN_ERROR) is sent to client topic.
- The default timeouts have been adjusted so that the task
timeout (60s) is longer than the HTTP and Database timeouts (30s),
so that expected codes are returned.
Issue-ID: CPS-2186
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I84c3447a625e084c445ab2f5c01e2b32a0c971ac
ToineSiebelink [Fri, 19 Apr 2024 09:25:01 +0000 (10:25 +0100)]
Temporary dsiable Operation Too Large Exception
- settign limit to 50000 to efftively disable it
- ericsson is not ready and wil infrom us when it can be enabled again
Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ib1a8308a20bd77fcba9c4c9fc94739d5dd731b1f
emaclee [Thu, 18 Apr 2024 09:43:05 +0000 (10:43 +0100)]
Fix build issue with subscription
Issue-ID: CPS-2164
Change-Id: I49a18df0927b5beff62a12f9bc2a2e8e486537c9
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Daniel Hanrahan [Wed, 17 Apr 2024 15:49:48 +0000 (15:49 +0000)]
Merge "Cm Subscription: Remove subscription method"
emaclee [Wed, 27 Mar 2024 12:46:39 +0000 (12:46 +0000)]
Cm Subscription: Remove subscription method
- method to remove a subscription Id from leaflist
- condition if subscription list is empty, remove subscription
all together
Issue-ID: CPS-2164
Change-Id: Id694f441f9675fa9a048e3b824e1f02fae73f87e
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Priyank Maheshwari [Fri, 12 Apr 2024 12:24:39 +0000 (12:24 +0000)]
Merge "Handle Subscription Response from DMI"
seanbeirne [Tue, 26 Mar 2024 10:28:17 +0000 (10:28 +0000)]
Handle Subscription Response from DMI
Issue-ID: CPS-1972
Change-Id: Idb8ad14f06e365707404d099a4581282d4a0add9
Signed-off-by: seanbeirne <sean.beirne@est.tech>
Toine Siebelink [Thu, 11 Apr 2024 10:09:42 +0000 (10:09 +0000)]
Merge "Update depcrecated method in KafaConfig"
ToineSiebelink [Wed, 10 Apr 2024 15:43:19 +0000 (16:43 +0100)]
Update depcrecated method in KafaConfig
Issue-ID: CPS-2179
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I882746a68f2d32f07fbcfeeac1f45b9dbbb8c62e
sourabh_sourabh [Tue, 2 Apr 2024 12:35:33 +0000 (13:35 +0100)]
Define a java based datastructure for DataJob and interface
- Defined java interface to handle datajob
- Defined all the modules needed to process data job request
- data jon response module id also defined
- dummy impl. of java interface
Issue-ID: CPS-2155
Change-Id: I20c7b621aa4bd40fe7758cb19b8720fc7cf5164c
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
ToineSiebelink [Tue, 9 Apr 2024 17:39:51 +0000 (18:39 +0100)]
Introduce and handle Operation Too Large Exception for batch operations
Issue-ID: CPS-2164
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Iec05d2013be4f971309f0e75d84dc5d0936eb8ef
ToineSiebelink [Tue, 9 Apr 2024 16:32:40 +0000 (17:32 +0100)]
Document new NCMP Status Code: 112, message too large
- Updated RTD
- Added new value to relevant Enum (although not used in our code)
Issue-ID: CPS-2178
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I4ba8c1622921919ae253a292d96307439ef20e2a
ToineSiebelink [Thu, 4 Apr 2024 15:02:52 +0000 (16:02 +0100)]
Add OpenSFF ScoreCard Action to GitHub
Issue-ID: CPS-2158
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Idf4f29756317591b616e776b750aca3340e428f1
Toine Siebelink [Thu, 4 Apr 2024 10:03:10 +0000 (10:03 +0000)]
Merge "Remove old committers from INFO.yaml"
Toine Siebelink [Thu, 4 Apr 2024 09:37:43 +0000 (09:37 +0000)]
Merge "Add integration tests of NCMP REST API"
ToineSiebelink [Thu, 4 Apr 2024 09:13:43 +0000 (10:13 +0100)]
Remove old committers from INFO.yaml
Issue-ID: CPS-1887
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ic147dc498307fa24ce5953ba39df0f4e3a2e6a13
Toine Siebelink [Thu, 4 Apr 2024 08:45:18 +0000 (08:45 +0000)]
Merge "Add moduleSetTag to the request towards dmi plugin"
Toine Siebelink [Thu, 4 Apr 2024 08:40:36 +0000 (08:40 +0000)]
Merge "Modify INFO.yaml for committer rights"
leventecsanyi [Tue, 2 Apr 2024 12:47:31 +0000 (14:47 +0200)]
Add moduleSetTag to the request towards dmi plugin
- mapping module set tag to DmiRequest
Issue-ID: CPS-2030
Change-Id: I487e48baf98919d3ff5e25d2428a065dd3a30335
Signed-off-by: leventecsanyi <levente.csanyi@est.tech>
Toine Siebelink [Thu, 4 Apr 2024 08:07:26 +0000 (08:07 +0000)]
Merge "[BUG] Mock DMI will respond to Health Checks during tests"
mpriyank [Fri, 29 Mar 2024 13:47:19 +0000 (13:47 +0000)]
Bump CPS version
- bump cps to 3.4.8-SNAPSHOT
- also updated the release notes
Issue-ID: CPS-2168
Change-Id: Iee7f1e2febbf28b0d5a2855d3128d9eb8bb3c490
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Fri, 29 Mar 2024 12:07:23 +0000 (12:07 +0000)]
Container YAML for CPS
- added container yaml for cps 3.4.7
Issue-ID: CPS-2168
Change-Id: Ieb3afc2eb7f62e20bedef28cd5da3a2e7731bfa0
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Fri, 29 Mar 2024 11:37:33 +0000 (11:37 +0000)]
Maven stage yaml for 3.4.7
- added maven stage yaml to release CPS 3.4.7 version
Issue-ID: CPS-2168
Change-Id: Id139fcf1c19acb2ffdd0a9e39066dc961158159b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
mpriyank [Fri, 29 Mar 2024 10:57:05 +0000 (10:57 +0000)]
Release notes for 3.4.7 CPS
- updated release notes for CPS 3.4.7 version
Issue-ID: CPS-2168
Change-Id: I3a6689234e63db301787d49a5c76063c0b6203ae
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Fri, 29 Mar 2024 10:22:51 +0000 (10:22 +0000)]
Merge "Uplift Spring boot 3.2.4"
emaclee [Sun, 24 Mar 2024 19:05:34 +0000 (19:05 +0000)]
Uplift Spring boot 3.2.4
- uplifted spring boot from 3.1.2 to 3.2.4
- removed redundant dependencies
- upgraded relevant dependencies
- use of @Bean(some_name) is give a specific bean name
- using @Bean(some_name) with @Qualifier so on the injection point to specify which bean to actually inject, this is used as we deal with multiple beans of the same type.
Issue-ID: CPS-2101
Change-Id: I64d5bf567b9eb03fb39034a46528d0160b332715
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
danielhanrahan [Thu, 28 Mar 2024 17:30:50 +0000 (17:30 +0000)]
Add integration tests of NCMP REST API
Add some tests using MockMvc of NCMP REST API:
- CM handle registration
- CM handle ID searches
- CM handle deregistration
Issue-ID: CPS-2033
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I493aca8c3f8c263f5a50f6a2c66e317b9a6e08aa
danielhanrahan [Tue, 26 Mar 2024 18:03:36 +0000 (18:03 +0000)]
[BUG] Mock DMI will respond to Health Checks during tests
Health Check for DMI is sometimes running during integration tests,
causing the mockDmiServer to fail due to unexpected Rest requests.
As a fix, the mock DMI will respond to health checks.
Issue-ID: CPS-2167
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ie4a0059583e66dfcc00e1aa998671a662ccf053a
danielhanrahan [Thu, 28 Mar 2024 16:29:56 +0000 (16:29 +0000)]
Modify INFO.yaml for committer rights
Issue-ID: CPS-1887
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ibe95eaf58679fc4c2d7486f1402d922d1264b450
Lee Anjella Macabuhay [Wed, 27 Mar 2024 16:26:42 +0000 (16:26 +0000)]
Merge "Scheduled task for Subscription Response"
emaclee [Wed, 27 Mar 2024 14:54:50 +0000 (14:54 +0000)]
Fix code smell
- change string to formatted
Issue-ID: CPS-475
Change-Id: I59271c63f244c4d6684b145b1afe2356668e6fd8
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
mpriyank [Thu, 14 Mar 2024 09:11:27 +0000 (09:11 +0000)]
Scheduled task for Subscription Response
- Need to send the response back to the client in max 30 secs
- Also have the capability to send the response right away
- Testware added for the same
- Also added code to cancel the scheduled task
- Added state for cancelling the task
Issue-ID: CPS-2140
Change-Id: I3ab321d8221cd8f697c26be46d2e63d89b360923
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Toine Siebelink [Tue, 26 Mar 2024 16:38:50 +0000 (16:38 +0000)]
Merge "Condense Liquibase steps"
david.mcweeney [Wed, 21 Feb 2024 09:51:29 +0000 (09:51 +0000)]
Condense Liquibase steps
Change-Id: I1493f49bb93c359df3ff7d4f928f9a94fb8b2604
Signed-off-by: david.mcweeney <david.mcweeney@est.tech>
Issue-ID: CPS-2061
Lee Anjella Macabuhay [Tue, 26 Mar 2024 10:42:15 +0000 (10:42 +0000)]
Merge "Code review cleanup for: Add kafka messaging support to integration test module"
halil.cakal [Fri, 22 Mar 2024 11:46:03 +0000 (11:46 +0000)]
Code review cleanup for: Add kafka messaging support to integration test module
- Address code review on commit which already merged
https://gerrit.onap.org/r/c/cps/+/137496
Issue-ID: CPS-2152
Change-Id: I7a46dd08c919227c37fdeacf4763d0ab364c88c1
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Priyank Maheshwari [Mon, 25 Mar 2024 15:28:54 +0000 (15:28 +0000)]
Merge "Save new cm notification subscription"
emaclee [Tue, 19 Mar 2024 12:43:51 +0000 (12:43 +0000)]
Save new cm notification subscription
Issue-ID: CPS-2043
Change-Id: If1c066a7d1c1f7e1c154714fe06f2566b727634c
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Toine Siebelink [Tue, 19 Mar 2024 17:02:00 +0000 (17:02 +0000)]
Merge "Add kafka messaging support to integration test module"
Toine Siebelink [Tue, 19 Mar 2024 16:13:04 +0000 (16:13 +0000)]
Merge "Update deployment docs for Postgres shared_buffers value"
halil.cakal [Mon, 11 Mar 2024 14:19:36 +0000 (14:19 +0000)]
Add kafka messaging support to integration test module
- add ncmp test using kafka to integration test suite
Issue-ID: CPS-2152
Change-Id: Ia486bbcf1590ecf3ec6cbc2f513b74d55e4d6a31
Signed-off-by: halil.cakal <halil.cakal@est.tech>
Priyank Maheshwari [Tue, 19 Mar 2024 15:42:26 +0000 (15:42 +0000)]
Merge "Fix SonarQube warnings"
danielhanrahan [Tue, 19 Mar 2024 15:28:32 +0000 (15:28 +0000)]
Update deployment docs for Postgres shared_buffers value
- update deployment.rst to include info on Postgres shared_buffers
Issue-ID: CPS-2156
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ia6e896e066227477a4824c03336de270800698d2
ToineSiebelink [Tue, 19 Mar 2024 10:42:07 +0000 (10:42 +0000)]
Fix SonarQube warnings
targetted:
- Introduced CmResourceAddress (name agreed with Daniel and Priyank)
- Extracted out private method in AltenateIdChecker to reduce complexity
side effects:
- use 'record' java feature as suggested by ItelliJ
- had to uprade spotbugs version to avoid incorrect warning on 'record' equeals method
- convention: added missing 'asserts' in affected testware
- my preference: removed a lot of unnecessary linebreaks in affected testware
- removed redunfant (variation) of a 'delegation' test
Issue-ID: CPS-475
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: Ie0c9d5ebc33196ae14ed6c226843095a2a040d1d
danielhanrahan [Thu, 14 Mar 2024 18:02:09 +0000 (18:02 +0000)]
Set Postgres shared_buffers in docker-compose
By default, Postgres uses value of 128MB for shared_buffers,
regardless of available memory. It is recommended to use
between 25% and 40% of memory for shared_buffers in Postgres.
Current value can be checked in SQL using 'SHOW shared_buffers'.
Issue-ID: CPS-2156
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ib20502f159f005ba941f39758555551f447d2b67
danielhanrahan [Fri, 15 Mar 2024 12:42:15 +0000 (12:42 +0000)]
Configure Hazelcast to have 1 backup to reduce memory
Currently Hazelcast is configured to have 3 synchronous backups
and 3 asynchronous backups. These are separate, meaning there will
be 7 copies in the cluster (1 original + 3 sync + 3 async backups).
Even if only 1 instance of CPS/NCMP is running, it will have 7 copies
in memory.
Given that CPS/NCMP is typically only deployed using 1 or 2 instances,
the settings are changed to 1 synchronous backup (same as Hazelcast's
default configuration). This change has been tested and shown to reduce
heap usage by around 100MB during 20K CM-handle registration.
Issue-ID: CPS-2146
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4a5f6d83bc35e2c13cfb32002e38dc365da34c8e
Sourabh Sourabh [Fri, 15 Mar 2024 10:13:55 +0000 (10:13 +0000)]
Merge "[Bug] Removing inner TaskExecutor to call DMI"
Toine Siebelink [Thu, 14 Mar 2024 15:17:57 +0000 (15:17 +0000)]
Merge "Performance tests of alternate-id/module-set-tag lookup"
mpriyank [Fri, 8 Mar 2024 12:50:53 +0000 (12:50 +0000)]
[Bug] Removing inner TaskExecutor to call DMI
- Removing TaskExecutor from cps-ncmp-service package as anyways the
call coming over from the cps-ncmp-rest layer is managed by a
different thread executor(CpsNcmpTaskExecutor)
- Provided 60secs timeout value.
- Spawning new thread from a different executor might not be needed
- Removing @Async from a non spring managed method as its of no use
Issue-ID: CPS-2150
Change-Id: Ic99632983aff2c40df81421d782cf98ec600fc41
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
JvD_Ericsson [Mon, 4 Mar 2024 16:23:25 +0000 (16:23 +0000)]
Modify lcm events to include dataProducerIdentifier and moduleSetTag (CPS-1964 3)
Issue-ID: CPS-2114
Change-Id: I52ae18fe849801706491742818b316df9f8cb554
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
JvD_Ericsson [Mon, 26 Feb 2024 13:45:47 +0000 (13:45 +0000)]
Modify the get cmHandle api to return dataProducerIdentifier, moduleSetTag, and alternateId (CPS-1964 2)
Issue-ID: CPS-2113
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I672e5c8408e77a5fa15d6fc2f41438aca705484c
JvD_Ericsson [Fri, 16 Feb 2024 09:30:45 +0000 (09:30 +0000)]
Provide support for data producer identifier during registration (CPS-1964 1)
- Added support for the dataProducerIdentifier to be added,
and updated from blank to something once
- The dataProducerIdentifier is persisted in the DB
Issue-ID: CPS-2105
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I1c230be8f9402154a761e8c2ba4d8a6331965b3c
danielhanrahan [Sun, 11 Feb 2024 16:30:44 +0000 (16:30 +0000)]
Performance tests of alternate-id/module-set-tag lookup
- Add some tests of CPS get/query operations comparing
look up of cm-handle id vs alternate-id
- Add test of querying all CM handles by module-set-tag
- Test accuracy is improved by performing warmup operations
(reported results are faster with more warmup iterations)
Issue-ID: CPS-2087
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4214e157ccf93f751c69b8a17d55f4185749ca90
mpriyank [Wed, 6 Mar 2024 11:54:17 +0000 (11:54 +0000)]
Mapper to form CmNotificationSubscriptionNcmpOutEvent
- mapper to be used in the subsequent patches
- test case to support the mapping of
CmNotificationSubscriptionNcmpOutEvent
Issue-ID: CPS-2147
Change-Id: I7f0be81941b774a27ddc343ed304a68c23796a60
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Priyank Maheshwari [Wed, 6 Mar 2024 15:23:44 +0000 (15:23 +0000)]
Merge "Advance DMI Stub to change module set (tags) used by cm handle"
Toine Siebelink [Wed, 6 Mar 2024 14:36:40 +0000 (14:36 +0000)]
Merge "Test of retry of failed module sync"