Tweak testTransaction

Remove startTransaction from testTransaction since it does
nothing functionally and causes exceptions which are logged.

Issue-ID: POLICY-369
Change-Id: Idd064b49e1d68832d14039870414626ca56c779b
Signed-off-by: Kevin McKiou <km097d@att.com>

Merge "Redundant code removal and hadrcoded strings"

Redundant code removal and hadrcoded strings

Issue-Id:POLICY-252
Change-Id: I839811ba15d0c478c83c03818087d3153b77ddb1
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>

Upgrade to release oparent version.

Following independent release and versioning process guidelines.

Issue-ID: POLICY-225
Change-Id: I3dad2abc5040255c9271c45eae99394dfd4208b5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Redundant code removal and hadrcoded strings

Issue-Id:POLICY-252
Change-Id: Ibf8b6790cbf9f65f1d3b3fc4476f686ff8981a10
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>

Remove sonar critical for public static

I think that making these private and using accessor functions
we can remove the sonar critical for them.

Issue-ID: POLICY-237
Change-Id: I4edbf909935fe17b0ef087b5cd0e384d78d104d6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Fix sonar critical for password

Focused on hard coded passwords. I believe they are only
used for JUnit tests so I moved them into a file for use.
If they still show up on sonar then I will move into a properties
file and/or mark as not going to fix.

Issue-ID: POLICY-237
Change-Id: I6fa561714091043a2ea5e2edfb0441c2dfc8b044
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Changed logger to slf4j

Changed all instances of Sys.out or PolicyLogger to
slf4j.

Issue-ID: POLICY-178
Change-Id: Ia91af1deb18a9b5c466f6f8a6c546c17c54e14ad
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Logging exceptions to clear sonar critical

Just logging the exceptions anyway and remove e.printstack since
that goes to stdout/stderr.

Issue-ID: POLICY-195
Change-Id: I60616bd6ce633e2fcae266bb37eb735c6e6bb4c4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Fix sonar critical associated with logging

Addressing the following sonar critical:
Use a logger to log this exception
Either log or rethrow this exception

It does not hurt to simply do these as well as clean out
lines of code that dump to Sys.out via e.printStackTrace.

Issue-ID: POLICY-195
Change-Id: Ibc328094a0653b7baa04778298e4a69955105ea3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Clean up unused imports and duplicate version"

Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: Iff23fa13f8b3500aa107447896eed07bfd0d5847
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Clean up unused imports and duplicate version

Seems oparent sets the version resulting in Eclipse generating warnings for the pom.
Also cleaned up unused imports.

Issue-ID: POLICY-216
Change-Id: I634025f67aa8847d1c2b6c76b0c8c09336886594
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Added license header to exception class

Included license header in IntegrityAuditException class since
it was accidentally omitted when class was originally created.

Issue-ID: POLICY-96
Change-Id: Idcb24e8c7fc6b5a17dc96b51c227be3e24be2bda
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Tweak Common Module JUnits

Patch 1: Tweaks Integrity-Audit JUnits to allow
at least some estimate of code coverage.  It was
not possible to enable all the tests as there are
threading issues when run in the JUnit environment.
Consequently, this is about 2/3 of the actual code
coverage. The estimate coverage is about 46%
Patch 2: Changes a persistence unit in DBDAOTest.
Patch 3: Adds tweaks to IntegrityMonitor JUnits. The
estimated state management code coverage is 70%.
Patch 4: Removed an IntegrityAudit test that failed
which reduced the estimated coverage to 45%

Issue-ID: POLICY-108
Change-Id: I693e56083c3ed66e020e82d5ac906ce29224bd58
Signed-off-by: Kevin McKiou <km097d@att.com>

Merge "Resolve major/critical issues in integrity-monitor"

Resolve major/critical issues in integrity-monitor

Resolved major and critical sonar issues in integrity-monitor
module.

Issue-ID: [POLICY-96]
Change-Id: If1da196134a73535668d42f429d647fc819ecaee
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

fix resource path bug from package renaming

Change-Id: I599fd087c803d062ed6fe1145bf0526fdd29d723
Issue-ID: POLICY-71
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Remove eclipse checkstyle warnings

Add this should remove Eclipse warnings:
Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (execution: check-style, phase: process-sources)

Issue-Id: POLICY-166
Change-Id: I6e83f05e4d034475d04d85e9b9fbf5f11a1969c7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Sonar cleanup for integrity-audit

Modified classes in integrity-audit module to resolve major sonar issues.

Issue-ID: [POLICY-96]
Change-Id: I5ef0abb8d2a3ea1ae93edc00363c4d2bea1747e2
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Merge "[POLICY-96] Resolved sonar blockers in im/ia."

Merge "[POLICY-149]policy-common integration with oparent"

[POLICY-96] Resolved sonar blockers in im/ia.

Resolved 7 sonar blockers in the integrity monitor and integrity audit
projects.

Change-Id: I7bba7619d3b71f7aebcc2642d07a64876ee7aea0
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

[POLICY-149]policy-common integration with oparent

Change-Id: I63ae06a4ed4d9f327a75da021d710da6616465c8
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>

[POLICY-98] Code cleanup for sonar issues.

Modified code in ECOMP-Logging to resolve critical/major sonar issues.
Not all issues were resolved as some guidance needs to be provided for
specific cases.

Restored config/policyLogger.properties file. It was modified by a junit
test.

Change-Id: I49fee98b2497d9d503d81bbbacbb1b416e1058a7
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Merge "[POLICY-134] Fixed bug in PolicyLogger."

[POLICY-134] Fixed bug in PolicyLogger.

PolicyLogger.info(Object arg0) calls itself recursively until it eventually
causes a stack overflow error.

Fix is to call debugLogger.info(MessageCodes, String) from within
PolicyLogger.info(Object).

Additionally, PolicyLogger.info(String arg0) was removed as
debugLogger.info(MessageCodes, String) can be called directly.

Change-Id: Id141027b544efa06b79f54a6726843b2a47481b9
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

[POLICY-71] forgot one onap-staging

Change-Id: If1edee2823e1edc83781b2e757364b62cb9b6d36
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-71] revert serverIDs

Change-Id: I9a9b2ba08d4570c1782914fbc087e9c0d6328ed2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-71] adding back site-manager

The error for merging is permissions issue. Helpdesk #43714

Change-Id: Ifc641b630b023defc56da42aa3359ad330361395
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-71] temp remove of site-manager

Change-Id: I2f5190eadbdd73683895f84f5a492bae536b6533
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-71] replace openecomp for policy-common

Change-Id: I3241f5d1f0234043b4dff718eda1ffdc48052276
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-81] Modified site-manager pom.xml to prevent superfluous warnings during maven build.

The addition of a <configuration> stub was added to the site-manager
pom.xml. The stub excludes the org.eclipse.persitence:javax.persistence
artifact from the uber-jar created by the maven-shade-plugin.
The artifact was a duplicate and maven was throwing an excessive
amount of warnings.

Change-Id: I1eaeeb569f67aea5578af68d277f44577a20b379
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

[POLICY-81] Code cleanup to eliminate the presence of warning messages in Eclipse.

Change-Id: Id98fdf0241487d56707ac91cde47975c91225f3c
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Merge "[POLICY-8] clean commons from sonar blockers"

[POLICY-105] Modifications to RefreshStateAudit

Made the refreshStateAudit configurable and changed the default interval to 10 minutes from 1 minute.  Added a check to fpCheck to check the state of the dependent before setting the opstate to disabled.

Added a refresh to the forwardprogressentity object in stateAudit() so that we are not reading stale timestamp data.

Change-Id: I394feca083fc1fb356d11b9f6886e566c31f248a
Signed-off-by: Kevin McKiou <km097d@att.com>

[POLICY-8] clean commons from sonar blockers

Change-Id: Ibcc238b21d6ff860a3df80e8bd570a14f5367b5d
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-8 POLICY-9] cleaning logging issues

A bit of a messy area to clean up without redoing.
This is an attempt to clean warnings and
being a little more friendly to the callers.

policy-9: sonar blocker with dereferencing null pointers
in flex logger.

policy-8: clean up other warnings from eclipse and sonar.

Change-Id: I7aa175673c22490909ae6b40a911a03931961ae3
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Batch submit

[ECOMPD2TD-000] Update version.properties for iter 41

[US866186 1707] Adding methods to IntegrityMonitor to support state
audit.

[US866186 1710] Made more progress on teh stateAudit method of
IntegritryMontor.  Completed all except the addition of properties.

[US866186 1710] Addition of
IntegrityMonitorProperties.STATE_AUDIT_INTERVAL_MS and logic to
stateAudit to determine whether or not to run

[US866186 1710] Created a JUnit for getAllForwardProgressEntity()
method and debugged and fixed it.

[US866186 1710] Making progress on the testStateAudit() JUnit.  Was able
to create forward progress entries and manually change the lastUpdated
date on an entry using a persistence update query.

[US866186 1710] First cut of stateAudit JUnit test.  Still need to test
more cases, but I got it working so far.

[US866186 1710] Completed the JUnit for stateAudit.  Added  5 new
scenarios.

Conflicts:

version.properties

Change-Id: I7b5622a27021cf01b5d916b75824d8e51b5252eb
Signed-off-by: Ralph Straubs <rs8887@att.com>

[POLICY-10] remove external repo

Change-Id: I9aa00159579aa49c7b9e20415f3f76bdec8b4e27
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Change name to show Policy Engine for sonar.

Change-Id: I03e282c1dc5f002cae2b862239f72afad23af0e6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Batch submit

[ECOMPD2TD-1073 1707] Removal of extra flush statements and addition
of rollbacks in catch blocks instead of commits.

[ECOMPD2TD-1073 1707] Adding some needed synchronized statements to
IntegrityMonitor.

[ECOMPD2TD-1159] - Loggers should be Serializable

By making loggers Serializable, they can be included in Drools
persistent data. 'EelfLogger' and 'SystemOutLogger' can do this
trivially, but 'Logger4J' needed some additional work, because it has a
non-serializable field 'log'.

[ECOMPD2TD-000] Fix versioning of org.openecomp.policy.* dependencies

[US866186 1707] First cut of stateCheck mod and non-working JUnit

[US866186 1707] Completed the coding for the task TA1998344 which adds
a check of forward progress for dependencies.

[US866186 1707] Completed updates to IntegrityMonitor.stateCheck and
IntegrityMonitorTest which includes addition of a JUnit for stateCheck
and control of the order of JUnit execution.

[US865296] ECOMP Policy Logging Compliance, add TargetEntity and
TargetServiceName, remove unit from ElapsedTime

[US865296] ECOMP Policy Logging Compliance, set audit log statuscode to
'COMPLETE' instead of N/A

[US865296] ECOMP Policy Logging Compliance, remove time unit (seconds
and milliseconds) from ElapsedTime for logging compliance

[US866186 1707] Cleaned up IntegrityAudit JUnit tests.

[US866186 1707] IntegrityMonitor JUnit clean up

[US866186 1707] Re-added missing classes that were erroneously deleted.

[US865296] - add get/setters and inits for required log fields

Change-Id: I76ef4606ed6832ed48eaca68e72839a05c8bc3a8
Signed-off-by: Ralph Straubs <rs8887@att.com>

Allow push on custom repo

Current configuration doesn't give the possibility to fully change
where the artifacts should be pushed. This blocks the possibility
to push artifacts to a custom repository outside of the LF

Change-Id: I0a0f02ec72c06ffe3d41d25538072c0db0e99317
Signed-off-by: Anaël Closson <ac2550@intl.att.com>

javadoc details

Change-Id: Ib9e96b7d388fbe6c2ce2564953fda735fb65042d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

update to ONAP

Change-Id: I193359ec88e361e3aee8316bca720f3ad5e80acb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

upgrade version.properties

Change-Id: Id7ce741e0217a36bb7b8bc65c0af4b2e9657857d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

upgrading to 1.1.0-SNAPSHOT

Change-Id: I33d11e370801ff9d0f21339ccf953d29c872ff09
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "weird version"

weird version

Change-Id: I822d994cbedb196e9e5e03e94039f044ab9489ca
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "change version to 1.0.0"

change version to 1.0.0

Change-Id: I5c99ec86ddeabb6e03685a98e87c1a42a685fd3c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

change version to 1.0.0

Change-Id: I305363f5296904aea9147717198e0ea8433d4de8
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

clean pom.xml fix 1.7 to 1.8

Change-Id: Id7332f7611f4247ba7df7a520aa22815275a1b30
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

cleaning up gitignore

Change-Id: Ie9b0398e4724a3cfea68203b13bc894245ee5b90
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

cleaning up gitignore

Change-Id: Ib5bb595e332561e2f70abf52a8f3ab72268640f9
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

adding back in unit tests with ignore

Change-Id: Ib81e9a63869b8a97b858d204e38637acd5483083
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

add staging and fix version

Change-Id: I2c12f6f9afc3bc6e41f887cc437cf819cbf93239
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Removing JUnit tests

Change-Id: I4df12acdca56955bc462c90b36791f7562be95ba
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

change javadoc to point to policy

Change-Id: Id4fd446f4fe74206cd4eb56111b85793bccc9526
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Added distribution configuration.

Change-Id: I26dacd01e863288d4d2675e183fad08575264ee5
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Initial OpenECOMP policy/common commit

Change-Id: I61cd29d6d8bf8702c1a66915895b519bf3484afa
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Initial empty repository