so.git
6 years agoAdding UT for SO-Catalog 23/17023/1
Seshu-Kumar-M [Tue, 3 Oct 2017 12:15:01 +0000 (17:45 +0530)]
Adding UT for SO-Catalog

IssueId: SO-172

Change-Id: I459ab18a5dccb3e773278db933f97b50f87d0e76
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
6 years agoAdding UT for MsoHeatUtils 21/17021/1
Seshu-Kumar-M [Tue, 3 Oct 2017 12:10:58 +0000 (17:40 +0530)]
Adding UT for MsoHeatUtils

IssueId: SO-173

Change-Id: If230456ab5ea9a9f0c7a1515c4662ec9b41126ff
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
6 years agoMerge "Removed commented lines"
Seshu Kumar M [Tue, 3 Oct 2017 09:47:28 +0000 (09:47 +0000)]
Merge "Removed commented lines"

6 years agoMerge "Reorder the modifiers and Removed unused imports"
Seshu Kumar M [Tue, 3 Oct 2017 09:47:12 +0000 (09:47 +0000)]
Merge "Reorder the modifiers and Removed unused imports"

6 years agoFixed so issues 91/16191/2
ramanjaneya [Thu, 28 Sep 2017 03:01:54 +0000 (08:31 +0530)]
Fixed so issues

Change-Id: I5bc9dc02ac81789dc0b113571c073e74d8cee609
Issue-Id:SO-118
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoRemoved commented lines 71/16171/2
ramanjaneya [Thu, 28 Sep 2017 02:27:52 +0000 (07:57 +0530)]
Removed commented lines

Change-Id: I80ecfce64650e4d9aec800898c7f98645f557d8a
Issue-Id:SO-118
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoReorder the modifiers and Removed unused imports 73/16173/2
ramanjaneya [Thu, 28 Sep 2017 02:34:23 +0000 (08:04 +0530)]
Reorder the modifiers and Removed unused imports

Change-Id: I9a2f1cf6ece783e64a31ac5927d234981e0f0461
Issue-Id:SO-118
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoMerge "Prevent JAXRS LinkageError"
Rob Daugherty [Tue, 3 Oct 2017 03:54:32 +0000 (03:54 +0000)]
Merge "Prevent JAXRS LinkageError"

6 years agoPrevent JAXRS LinkageError 65/16965/1
Arthur Martella [Tue, 3 Oct 2017 03:00:21 +0000 (23:00 -0400)]
Prevent JAXRS LinkageError

Pruning the inclusions in modules to prevent linkage errors during health check.

Change-Id: I7b3cb233d0eac2a0a41b15e608d3d295a73573e7
Issue-ID: SO-160
Signed-off-by: Arthur Martella <amartell@research.att.com>
6 years agoIncrease the wait for mariadb 97/16897/2
Determe, Sebastien (sd378r) [Mon, 2 Oct 2017 17:44:13 +0000 (19:44 +0200)]
Increase the wait for mariadb

Increase the number of polling done to verify that mariadb is up before
starting the mso container

Change-Id: I0fdab8aaa0f17078f9a94700e7918dd30aab3407
Issue-ID: SO-171
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
6 years agoDisable non-working integration tests 39/16939/1
Rob Daugherty [Mon, 2 Oct 2017 22:13:54 +0000 (18:13 -0400)]
Disable non-working integration tests

These will need to be fixed soon, but the first step is to
have a working environment again.

I am also removing obsolete versions of camunda sql scripts.

Change-Id: I5817be8a879505fa4f146d2e49b26a305ece356a
Issue: SO-171
Signed-off-by: Rob Daugherty <rd472p@att.com>
6 years agoFixes for Infrastructure module startup 05/16905/1
Arthur Martella [Mon, 2 Oct 2017 19:16:17 +0000 (15:16 -0400)]
Fixes for Infrastructure module startup

Excluding jersey-all from pom.xml and fixing broken bpmn file.

Change-Id: I466a593f08d20f6b37e367f3ccc67bd8a7165029
Issue-ID: SO-160
Signed-off-by: Arthur Martella <amartell@research.att.com>
6 years agoMerge "Added @Override annotation to method signature"
Seshu Kumar M [Mon, 2 Oct 2017 15:29:44 +0000 (15:29 +0000)]
Merge "Added @Override annotation to method signature"

6 years agoMerge "Deleted redundant code"
Seshu Kumar M [Mon, 2 Oct 2017 15:29:17 +0000 (15:29 +0000)]
Merge "Deleted redundant code"

6 years agoMerge "Fix major sonar issues"
Seshu Kumar M [Mon, 2 Oct 2017 15:28:22 +0000 (15:28 +0000)]
Merge "Fix major sonar issues"

6 years agoMerge "Added @Override annotation to method signature"
Seshu Kumar M [Mon, 2 Oct 2017 15:27:03 +0000 (15:27 +0000)]
Merge "Added @Override annotation to method signature"

6 years agoMerge "Fixed major sonar issues"
Seshu Kumar M [Mon, 2 Oct 2017 15:26:15 +0000 (15:26 +0000)]
Merge "Fixed major sonar issues"

6 years agoCatalog DB Adapter test cases 73/16873/1
Arthur Martella [Mon, 2 Oct 2017 15:03:02 +0000 (11:03 -0400)]
Catalog DB Adapter test cases

Adding new test cases for Catalog DB Adapter

Change-Id: I1e809e39a9e41a26e87d1f7690ee46f42bccc076
Issue-ID: SO-171
Signed-off-by: Arthur Martella <amartell@research.att.com>
6 years agoMerge "Fix the arquillian framework"
Seshu Kumar M [Mon, 2 Oct 2017 14:24:03 +0000 (14:24 +0000)]
Merge "Fix the arquillian framework"

6 years agoMerge "URL mismatch in mso.sdnc.properties"
Rob Daugherty [Mon, 2 Oct 2017 14:23:38 +0000 (14:23 +0000)]
Merge "URL mismatch in mso.sdnc.properties"

6 years agoMerge "HeatBridge integration with Orchestration, part 1"
Rob Daugherty [Mon, 2 Oct 2017 13:18:14 +0000 (13:18 +0000)]
Merge "HeatBridge integration with Orchestration, part 1"

6 years agoFix the arquillian framework 41/16841/1
Determe, Sebastien (sd378r) [Mon, 2 Oct 2017 11:09:14 +0000 (13:09 +0200)]
Fix the arquillian framework

Arquillian framework was broken due to bad dependency
used during ITS

Change-Id: I2c865b429af45511d778d11d77a16704b49fdef6
Issue-ID: SO-171
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
6 years agoURL mismatch in mso.sdnc.properties 57/16757/2
Rob Daugherty [Sun, 1 Oct 2017 11:52:45 +0000 (07:52 -0400)]
URL mismatch in mso.sdnc.properties

There was a mismatch between the "sdncurls" definitions in the
environment files (e.g. mso-docker.json) and the property file
template (mso.sdnc.properties).

This commit adds missing "sdncurls" to the arquillian unit test
environment.

Issue: SO-123
Change-Id: I538c9df71fec6e9368d4a984eb82f58ec3b0c545
Signed-off-by: Rob Daugherty <rd472p@att.com>
6 years agoMerge "Added private constructor"
Seshu Kumar M [Sat, 30 Sep 2017 17:06:18 +0000 (17:06 +0000)]
Merge "Added private constructor"

6 years agoMerge "Reorder modifiers"
Seshu Kumar M [Sat, 30 Sep 2017 09:41:16 +0000 (09:41 +0000)]
Merge "Reorder modifiers"

6 years agoMerge "Commenting for empty constructor"
Seshu Kumar M [Sat, 30 Sep 2017 09:40:46 +0000 (09:40 +0000)]
Merge "Commenting for empty constructor"

6 years agoMerge "Correcting naming format"
Seshu Kumar M [Sat, 30 Sep 2017 09:39:50 +0000 (09:39 +0000)]
Merge "Correcting naming format"

6 years agoMerge "Correcting naming format"
Seshu Kumar M [Sat, 30 Sep 2017 09:39:10 +0000 (09:39 +0000)]
Merge "Correcting naming format"

6 years agoAdded private constructor 09/15909/3
ramanjaneya [Wed, 27 Sep 2017 10:10:39 +0000 (15:40 +0530)]
Added private constructor

Issue-Id:SO-118
Change-Id: I07dec371e8b9665c1a147ba20b6dc311de6ce70a
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoCommenting for empty constructor 25/16225/2
Ankit-Huawei [Thu, 28 Sep 2017 05:55:21 +0000 (11:25 +0530)]
Commenting for empty constructor

SO-158

Change-Id: I1e67fff2c96efc6e79dca8facfd6f0b230c70cd4
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
6 years agoMerge "Replace with the diamnod operator"
Seshu Kumar M [Sat, 30 Sep 2017 08:15:37 +0000 (08:15 +0000)]
Merge "Replace with the diamnod operator"

6 years agoMerge "Removed unused variables"
Seshu Kumar M [Sat, 30 Sep 2017 08:14:32 +0000 (08:14 +0000)]
Merge "Removed unused variables"

6 years agoMerge "Removed unused variables"
Seshu Kumar M [Sat, 30 Sep 2017 08:13:55 +0000 (08:13 +0000)]
Merge "Removed unused variables"

6 years agoMerge "Replaced with Diamond symbol"
Seshu Kumar M [Sat, 30 Sep 2017 08:12:44 +0000 (08:12 +0000)]
Merge "Replaced with Diamond symbol"

6 years agoReorder modifiers 05/15805/3
ramanjaneya [Wed, 27 Sep 2017 06:35:13 +0000 (12:05 +0530)]
Reorder modifiers

Issue-Id:SO-118
Change-Id: I4221a5d246bf1274c3cd67a8255742f8a2c6582b
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoMerge "Added FunctionalInterface annotation"
Seshu Kumar M [Sat, 30 Sep 2017 08:11:17 +0000 (08:11 +0000)]
Merge "Added FunctionalInterface annotation"

6 years agoMerge "Repalced StringBuffer with StringBuilder"
Seshu Kumar M [Sat, 30 Sep 2017 08:09:04 +0000 (08:09 +0000)]
Merge "Repalced StringBuffer with StringBuilder"

6 years agoMerge "Replaced with Diamond symbol"
Seshu Kumar M [Sat, 30 Sep 2017 08:08:01 +0000 (08:08 +0000)]
Merge "Replaced with Diamond symbol"

6 years agoMerge "Replaced with Diamond symbol"
Seshu Kumar M [Sat, 30 Sep 2017 08:07:13 +0000 (08:07 +0000)]
Merge "Replaced with Diamond symbol"

6 years agoMerge "Fixed string literal comparision"
Seshu Kumar M [Sat, 30 Sep 2017 08:06:36 +0000 (08:06 +0000)]
Merge "Fixed string literal comparision"

6 years agoMerge "Fixed string literal comparision"
Seshu Kumar M [Sat, 30 Sep 2017 08:05:12 +0000 (08:05 +0000)]
Merge "Fixed string literal comparision"

6 years agoMerge "Fixed string literal comparision issue"
Seshu Kumar M [Sat, 30 Sep 2017 08:04:54 +0000 (08:04 +0000)]
Merge "Fixed string literal comparision issue"

6 years agoMerge "Added @Override annotation to method signature"
Seshu Kumar M [Sat, 30 Sep 2017 08:04:14 +0000 (08:04 +0000)]
Merge "Added @Override annotation to method signature"

6 years agoMerge "Fixed string literal comparision issue"
Seshu Kumar M [Sat, 30 Sep 2017 08:03:38 +0000 (08:03 +0000)]
Merge "Fixed string literal comparision issue"

6 years agoMerge "Removed unused import"
Seshu Kumar M [Sat, 30 Sep 2017 08:03:05 +0000 (08:03 +0000)]
Merge "Removed unused import"

6 years agoCorrecting naming format 15/16215/2
Ankit-Huawei [Thu, 28 Sep 2017 05:29:19 +0000 (10:59 +0530)]
Correcting naming format

SO-158

Change-Id: Ic7b789cf46cc2f31842b3d69f5ad52e8b4c63e31
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
6 years agoCorrecting naming format 13/16213/2
Ankit-Huawei [Thu, 28 Sep 2017 05:24:20 +0000 (10:54 +0530)]
Correcting naming format

SO-158

Change-Id: If322e1edf39e8a5fabf1926e4e73d74deefea90e
Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
6 years agoremove odl dependence temporary 07/16707/1
黄卓垚10112215 [Sat, 30 Sep 2017 01:45:45 +0000 (09:45 +0800)]
remove odl dependence temporary

Change-Id: I2d4348974badf6b4ecb255adb3ffa3b5c399d7e2
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
description: Remove odl dependence temporary for docker deployment, utill the issue is be solved. Before that time, yang decoder is unavailable.

6 years agoFix the SO build issues 13/16613/2
Determe, Sebastien (sd378r) [Fri, 29 Sep 2017 10:10:40 +0000 (12:10 +0200)]
Fix the SO build issues

Fix the AAI java package names that was still openecomp,
remove the variable for LF repositories due to Oparent, Fix the
jacoco to overwrite the oparent settings (fix test coverage)

Change-Id: I40b9b326e33ff27992a1bf2cc9d3094d338f8828
Issue-ID: SO-168
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
6 years agoMerge "Fix some major sonar issues"
Seshu Kumar M [Thu, 28 Sep 2017 13:18:38 +0000 (13:18 +0000)]
Merge "Fix some major sonar issues"

6 years agoMerge "Fix major Sonar issues"
Seshu Kumar M [Thu, 28 Sep 2017 13:18:01 +0000 (13:18 +0000)]
Merge "Fix major Sonar issues"

6 years agoMerge changes Ibc78f5be,Id1a6e6d2
Seshu Kumar M [Thu, 28 Sep 2017 13:14:07 +0000 (13:14 +0000)]
Merge changes Ibc78f5be,Id1a6e6d2

* changes:
  Fix code complexity
  Use diamond operator(<>)

6 years agoMerge "Removed unused imports"
Seshu Kumar M [Thu, 28 Sep 2017 13:07:15 +0000 (13:07 +0000)]
Merge "Removed unused imports"

6 years agoFixed Critical Sonar Issues 67/16267/2
seshukm [Thu, 28 Sep 2017 07:56:07 +0000 (13:26 +0530)]
Fixed Critical Sonar Issues
IssueId: SO-164

Change-Id: I87915bcdab1457c766d53157305e8e2b68a7b4d8
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
6 years agoMerge "Adding UT for E2E Service"
DeWayne Filppi [Thu, 28 Sep 2017 13:00:04 +0000 (13:00 +0000)]
Merge "Adding UT for E2E Service"

6 years agoMerge "service-topology-operation"
Seshu Kumar M [Thu, 28 Sep 2017 12:58:51 +0000 (12:58 +0000)]
Merge "service-topology-operation"

6 years agoMerge "Removed useless assignment to variables"
Seshu Kumar M [Thu, 28 Sep 2017 12:57:32 +0000 (12:57 +0000)]
Merge "Removed useless assignment to variables"

6 years agoMerge "Removed the unused variables"
Seshu Kumar M [Thu, 28 Sep 2017 12:57:15 +0000 (12:57 +0000)]
Merge "Removed the unused variables"

6 years agoMerge "Replaced with the diamnod operator"
Seshu Kumar M [Thu, 28 Sep 2017 12:56:55 +0000 (12:56 +0000)]
Merge "Replaced with the diamnod operator"

6 years agoAdding UT for E2E Service 73/16373/2
Seshu-Kumar-M [Thu, 28 Sep 2017 12:04:49 +0000 (17:34 +0530)]
Adding UT for E2E Service

IssueId: SO-50

Change-Id: I7fc39adb7a1d96022541189a6f7279b13bbb3b5e
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
6 years agoMerge "Removed useless assignment to local variables"
Seshu Kumar M [Thu, 28 Sep 2017 12:51:54 +0000 (12:51 +0000)]
Merge "Removed useless assignment to local variables"

6 years agoRemoved useless assignment to local variables 79/15079/3
rama-huawei [Mon, 25 Sep 2017 13:27:57 +0000 (18:57 +0530)]
Removed useless assignment to local variables

Issue-Id:SO-118

Change-Id: I29ec088aa52073f4e9df5503ede9f306c72e41d0
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoMerge "Add test cases for E2E service"
Rob Daugherty [Wed, 27 Sep 2017 15:53:56 +0000 (15:53 +0000)]
Merge "Add test cases for E2E service"

6 years agoMerge "Fixed Blocker issues. IssueId: SO-165"
Rob Daugherty [Wed, 27 Sep 2017 15:53:28 +0000 (15:53 +0000)]
Merge "Fixed Blocker issues. IssueId: SO-165"

6 years agoMerge "Fixed E2EService blocker SONAR IssueId: SO-118"
Rob Daugherty [Wed, 27 Sep 2017 15:53:22 +0000 (15:53 +0000)]
Merge "Fixed E2EService blocker SONAR IssueId: SO-118"

6 years agoMerge "Fixed string literal comparision issue"
Seshu Kumar M [Wed, 27 Sep 2017 15:27:25 +0000 (15:27 +0000)]
Merge "Fixed string literal comparision issue"

6 years agoMerge "Removed useless assignment to variables"
Seshu Kumar M [Wed, 27 Sep 2017 15:21:24 +0000 (15:21 +0000)]
Merge "Removed useless assignment to variables"

6 years agoMerge "Removed useless assignment to variables"
Seshu Kumar M [Wed, 27 Sep 2017 15:19:46 +0000 (15:19 +0000)]
Merge "Removed useless assignment to variables"

6 years agoMerge "Replace with Diamond symbol"
Seshu Kumar M [Wed, 27 Sep 2017 15:19:00 +0000 (15:19 +0000)]
Merge "Replace with Diamond symbol"

6 years agoMerge "Adding comments for empty constructor"
Seshu Kumar M [Wed, 27 Sep 2017 15:14:51 +0000 (15:14 +0000)]
Merge "Adding comments for empty constructor"

6 years agoMerge "Correcting varriable name"
Seshu Kumar M [Wed, 27 Sep 2017 15:11:20 +0000 (15:11 +0000)]
Merge "Correcting varriable name"

6 years agoservice-topology-operation 95/15995/1
黄卓垚10112215 [Wed, 27 Sep 2017 13:15:46 +0000 (21:15 +0800)]
service-topology-operation

Change-Id: I26b03516eb73689f806aa9ea5f1edcb22a1c4d84
Issue-ID: SO-88
Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
Discription: Network-topology-operation should work with Service-topology-operation. This commit is for the Service-topology-operation.

6 years agoRemoved useless assignment to variables 29/15929/3
rama-huawei [Wed, 27 Sep 2017 10:37:52 +0000 (16:07 +0530)]
Removed useless assignment to variables

Issue-Id:SO-118

Change-Id: I97cfd892ae5d13003b0b37509ac91be863dbd55e
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoFixed Blocker issues. 15/15915/2
seshukm [Wed, 27 Sep 2017 10:20:30 +0000 (15:50 +0530)]
Fixed Blocker issues.
IssueId: SO-165

Change-Id: I7c2520af9394ceb600a5a25fa9acfd095d872a1d
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
6 years agoRemoved the unused variables 25/15925/2
rama-huawei [Wed, 27 Sep 2017 10:31:12 +0000 (16:01 +0530)]
Removed the unused variables

Issue-Id:SO-118

Change-Id: I979370f8d3ffa0382856353aa189610d24dcd20c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoReplaced with the diamnod operator 17/15917/2
rama-huawei [Wed, 27 Sep 2017 10:22:13 +0000 (15:52 +0530)]
Replaced with the diamnod operator

Issue-Id:SO-118

Change-Id: Iaad28a363586cd8b42e86bd7e854faa9e716c59d
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoRemoved unused imports 99/15899/2
ramanjaneya [Wed, 27 Sep 2017 10:02:41 +0000 (15:32 +0530)]
Removed unused imports

Issue-Id:SO-118
Change-Id: I0c58455e74dd444e1cddae96cde7608fbed3e436
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoUpdate POM to inherit from oparent 11/15911/1
Rob Daugherty [Wed, 27 Sep 2017 10:11:26 +0000 (06:11 -0400)]
Update POM to inherit from oparent

Issue: SO-71
Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24
Signed-off-by: Rob Daugherty <rd472p@att.com>
6 years agoReplace with the diamnod operator 03/15903/1
rama-huawei [Wed, 27 Sep 2017 10:07:33 +0000 (15:37 +0530)]
Replace with the diamnod operator

Issue-Id:SO-118

Change-Id: I96a1fb659bafd204221c5ff8f3d0b680a36dba9d
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoRemoved unused variables 95/15895/1
rama-huawei [Wed, 27 Sep 2017 09:58:43 +0000 (15:28 +0530)]
Removed unused variables

Issue-Id:SO-118

Change-Id: I5db909a4c2bfb803c3d3647f30cfa4533c729148
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoRemoved unused variables 87/15887/1
rama-huawei [Wed, 27 Sep 2017 09:50:21 +0000 (15:20 +0530)]
Removed unused variables

Issue-Id:SO-118

Change-Id: I3f749777618e506efe4b83314e45574455639f7b
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoFixed E2EService blocker SONAR 19/15819/1
seshukm [Wed, 27 Sep 2017 07:06:45 +0000 (12:36 +0530)]
Fixed E2EService blocker SONAR
IssueId: SO-118

Change-Id: Ia2e6e0d3bbef4c80721991762876c9ed98043790
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
6 years agoAdded FunctionalInterface annotation 97/15797/2
ramanjaneya [Wed, 27 Sep 2017 06:25:38 +0000 (11:55 +0530)]
Added FunctionalInterface annotation

Issue-Id:SO-118
Change-Id: Idad9e0944c83fb64bebb19b9994444d2471ba4aa
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoReplaced with Diamond symbol 91/15791/3
ramanjaneya [Wed, 27 Sep 2017 05:42:18 +0000 (11:12 +0530)]
Replaced with Diamond symbol

Added Override annotation

Issue-Id:SO-118
Change-Id: I7b2dd323c4676001a6c7695ca10a490b72a7ccd1
Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com>
6 years agoRepalced StringBuffer with StringBuilder 93/15493/3
rama-huawei [Tue, 26 Sep 2017 12:16:40 +0000 (17:46 +0530)]
Repalced StringBuffer with StringBuilder

Issue-Id:SO-118

Change-Id: I7c69443dc5c17690605c4d1844823fd4307e9ccb
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoReplaced with Diamond symbol 89/15489/3
rama-huawei [Tue, 26 Sep 2017 12:02:07 +0000 (17:32 +0530)]
Replaced with Diamond symbol

Issue-Id:SO-118
Change-Id: I61310f341d86b765d0eff82ff758fcc4922b6576
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoReplaced with Diamond symbol 75/15475/2
rama-huawei [Tue, 26 Sep 2017 11:39:45 +0000 (17:09 +0530)]
Replaced with Diamond symbol

Issue-Id:SO-118
Change-Id: I744c8e8278157aefd001ebc27e35e77e115d3b71
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
6 years agoFixed string literal comparision issue 87/15487/2
shashikanth [Tue, 26 Sep 2017 11:57:15 +0000 (17:27 +0530)]
Fixed string literal comparision issue

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "GetLayer3ServiceDetailsRequest" string literal on the left side of this string comparison.

Issue-Id: APPC-186
Change-Id: I927555425a3a6294eee56f9c7377abc9f4a9ad05
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
6 years agoFixed string literal comparision 81/15481/2
shashikanth [Tue, 26 Sep 2017 11:45:00 +0000 (17:15 +0530)]
Fixed string literal comparision

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "true" string literal on the left side of this string comparison

Issue-Id: APPC-186
Change-Id: I1223f769c06673b9b4817f2cd3965b6bf429f0ef
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
6 years agoFixed string literal comparision 77/15477/2
shashikanth [Tue, 26 Sep 2017 11:39:34 +0000 (17:09 +0530)]
Fixed string literal comparision

Fix Blocker/Critical sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "true" string literal on the left side of this string comparison

Issue-Id: APPC-186
Change-Id: I1a62b36c344ebca1786245e3837a537182c60377
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
6 years agoFix some major sonar issues 45/15545/2
surya-huawei [Tue, 26 Sep 2017 13:04:28 +0000 (18:34 +0530)]
Fix some major sonar issues

*Use collection.isEmpty() instead of collection.size
*Remove unnecessary commented line
 This is done for increasing code readability
*Pass the string object directly
 Instead of wrapping the returned object and
 creating a new object, passing the object itself will save
 memory

Issue-Id: SO-118
Change-Id: I24c15e9270ec3422d35d3910a8aff9fcf8d632d9
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoFix major Sonar issues 37/15537/2
surya-huawei [Tue, 26 Sep 2017 12:55:40 +0000 (18:25 +0530)]
Fix major Sonar issues

*Use negation operator instead of converting
boolean operator
*Remove unused imports
 These changes are done to increase code readability

Issue-Id: SO-118
Change-Id: I8ec491217520edad95657f8cbb33d20149f64425
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoFix code complexity 15/15515/2
surya-huawei [Tue, 26 Sep 2017 12:35:12 +0000 (18:05 +0530)]
Fix code complexity

*Use equalsIgnoreCase instead of comparing on converted cases
 This is done to reduce the number of conversions
 and it's more simple and it internally performs
 null check as well
*Remove unused imports
 This is done to increase code readability

Issue-Id: SO-118
Change-Id: Ibc78f5be645db69695c12bca1fbd0282914e90eb
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoUse diamond operator(<>) 05/15505/2
surya-huawei [Tue, 26 Sep 2017 12:27:50 +0000 (17:57 +0530)]
Use diamond operator(<>)

Major Sonar Issue
*Replace type specification with diamond operator
This is done to reduce the verbosity of generics code

Issue-Id: SO-118
Change-Id: Id1a6e6d2e03f6f92a0e36b9326df61154c0ba910
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoMerge "Fix some major Sonar Issues"
Seshu Kumar M [Tue, 26 Sep 2017 20:43:51 +0000 (20:43 +0000)]
Merge "Fix some major Sonar Issues"

6 years agoMerge "Use try-with-resources"
Seshu Kumar M [Tue, 26 Sep 2017 20:41:58 +0000 (20:41 +0000)]
Merge "Use try-with-resources"

6 years agoHeatBridge integration with Orchestration, part 1 71/15571/1
Arthur Martella [Tue, 26 Sep 2017 04:06:34 +0000 (00:06 -0400)]
HeatBridge integration with Orchestration, part 1

Adding Heatbridge python code and call into SO.  Still needs configuration to be complete.

Change-Id: I4869217699d857e27579decce91e9c542ce7a449
Issue-ID: SO-1
Signed-off-by: Arthur Martella <amartell@research.att.com>
6 years agoSO Debug Env Setup Guide 65/15565/1
Seshu-Kumar-M [Tue, 26 Sep 2017 13:43:47 +0000 (19:13 +0530)]
SO Debug Env Setup Guide

Guide on how to setup the debug env
SO-81

Change-Id: I02b59540b59f84d1857a083a665b970af84ba124
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
6 years agoFixed major sonar issues 61/15561/1
shashikanth [Tue, 26 Sep 2017 13:32:24 +0000 (19:02 +0530)]
Fixed major sonar issues

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1132

Move the "vlan" string literal on the left side of this string comparison.

Issue-Id: APPC-186
Change-Id: If8f330c4a4f053bbee1064b325dc1cbe6bcd70ae
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
6 years agoFix major sonar issues 59/15559/1
shashikanth [Tue, 26 Sep 2017 13:24:26 +0000 (18:54 +0530)]
Fix major sonar issues

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161

Add the "@Override" annotation above this method signature

Issue-Id: APPC-186
Change-Id: I0a93e48f921c968ab9a43fc0599ba16d2349db40
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>