summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
surya-huawei [Fri, 22 Sep 2017 11:20:44 +0000 (16:50 +0530)]
Remove unnecessary constructs
*Remove unused imports
*Remove useless paranthesis
This is done as sometimes they can be misleading
*Replace type specification with diamond operator(<>)
This is done to reduce verbosity of generics code
Issue-Id: CCSDK-87
Change-Id: Ic356859939fe40cecec2e65c96d79cd6a655787e
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Bharat saraswal [Thu, 21 Sep 2017 12:55:09 +0000 (18:25 +0530)]
Resolved below sonar issues.
Method complextity.
Redudant code and varibales.
Exception handling.
Refacting of code.
Issue-Id:CCSDK-87
Change-Id: I757c6a6d3c403f81f725ad97a7759225d0709468
Signed-off-by: Bharat saraswal <bharat.saraswal@huawei.com>
surya-huawei [Thu, 21 Sep 2017 10:25:14 +0000 (15:55 +0530)]
Use Integer.toString for type conversion
*Used Integer.toString instead of implicit type conversion
This is done to make use of static and reduce cycles
*Removed one unused import
*Removed unnecessary parantheses
Sometimes useless parantheses can be misleading hence removed
Issue-Id: CCSDK-87
Change-Id: I23f56cb7c5a6dafa79f64d5cd8faa0994f0ff288
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Wed, 20 Sep 2017 20:01:37 +0000 (20:01 +0000)]
Merge "Some minor refinements in CCSDK SLI Northbound"
ramu.n [Wed, 20 Sep 2017 11:44:38 +0000 (17:14 +0530)]
Some minor refinements in CCSDK SLI Northbound
Fix few Critical/Major sonar issues in CCSDK SLI Northbound module
* Remove useless parentheses
* Remove useless assignment to local variable
* Use built-in logger method string formatting instead of string concatination
* code indentation
* Replace for loop with foreach
Change-Id: I9a2e3345f23feb2d96045ac714d8acc528de464b
Issue-Id: CCSDK-67
Signed-off-by: Ramu N <ramu.n@huawei.com>
surya-huawei [Wed, 20 Sep 2017 10:48:41 +0000 (16:18 +0530)]
Remove useless assigment to local variables
*Removed dead stores
This is done to avoid waste of resources
Issue-Id: CCSDK-87
Change-Id: Ie36255c6583792e2535000ee1bd5b2a3018632ff
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Tue, 19 Sep 2017 23:52:47 +0000 (23:52 +0000)]
Merge "Fix critical sonar issues"
Gaurav Agrawal [Tue, 19 Sep 2017 13:36:33 +0000 (19:06 +0530)]
Fix critical sonar issues
Fix critical sonar issues in CCSDK SLI Northbound by either logging or
rethrowing the exception
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=CRITICAL
Change-Id: I718f13b5801ea9d69b5c36f75b5387a0ae59cc6a
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Tue, 19 Sep 2017 10:02:16 +0000 (15:32 +0530)]
Fix Sonar Issues
few major issues in sli/northbound
*Remove unused imports
*Iterate over the "entrySet" instead of the "keySet"
*Replace the type specification with the diamond operator ("<>")
Issue-Id: CCSDK-87
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Change-Id: Ib2a6f97d3de759b937c1e2acd2e39312e88ad10b
Dan Timoney [Mon, 18 Sep 2017 20:02:55 +0000 (20:02 +0000)]
Merge "Replace deprecated APIs with newer one"
Gaurav Agrawal [Mon, 18 Sep 2017 13:07:49 +0000 (18:37 +0530)]
Replace deprecated API with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
Change-Id: I50195bf123052270edf3fd9f74af00262a01e650
Issue-Id: CCSDK-93
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Mon, 18 Sep 2017 09:24:37 +0000 (14:54 +0530)]
Replace deprecated APIs with newer one
Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
Change-Id: I3d5117e63083ce77553feb3d3f6d6265576da646
Issue-Id: CCSDK-93
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
surya-huawei [Sun, 17 Sep 2017 17:40:57 +0000 (23:10 +0530)]
Fix Sonar issue in sli/northbound module
One major issue
* move string literals to left side of
string comparison
Issue-Id: CCSDK-87
Change-Id: Ibd1146a8a12dccc56fb620fe5830efb545ac39a1
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Dan Timoney [Thu, 14 Sep 2017 19:59:25 +0000 (15:59 -0400)]
Use oparent-odlparent in sli/northbound
Update sli/northbound to use oparent-odlparent, used by latest version
of ccsdk odlparent-carbon-sr1 parent.
Change-Id: I77c4452d4af04d3dc4cd0892a9a0dab6c77016bc
Issue-ID: CCSDK-43
Signed-off-by: Dan Timoney <dtimoney@att.com>
surya-huawei [Thu, 14 Sep 2017 09:55:10 +0000 (15:25 +0530)]
Fix Sonar issues
few major issues in sli/northbound module
Issue-Id: CCSDK-87
Change-Id: I2c1a8b41266aae6941c5f2fdbb8b08ea91dde6ec
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
Ryan Goulding [Thu, 7 Sep 2017 19:21:05 +0000 (15:21 -0400)]
Fix SDNC service registration
Move the northbound to utilize Aries Blueprint instead of ODL's
configuration subsystem
Change-Id: I7388391d40912136176bb28b817157676f71557d
Issue-Id: SDNC-54
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Dan Timoney [Mon, 11 Sep 2017 15:21:41 +0000 (15:21 +0000)]
Merge "Fix few Blocker sonar issues"
Jessica Wagantall [Fri, 8 Sep 2017 20:17:30 +0000 (13:17 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: Iecfd1bf6a7937437728e5cf136b63c896da49b44
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Gaurav Agrawal [Fri, 8 Sep 2017 14:28:55 +0000 (19:58 +0530)]
Fix few Blocker sonar issues
Fix few Blocker sonar issues in CCSDK SLI Northbound
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=BLOCKER
Change-Id: I7229c7e2a0dabc0ff789b91ae413b9a15ef3cbad
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Gaurav Agrawal [Fri, 8 Sep 2017 13:58:18 +0000 (19:28 +0530)]
Fix few Blocker sonar issues
Fix few Blocker sonar issues in CCSDK SLI Northbound
https://sonar.onap.org/component_issues/index?id=org.onap.ccsdk.sli.northbound%3Accsdk-sli-northbound#resolved=false|severities=BLOCKER
Change-Id: I8a2f2e9f3bc5bc5c007076e42f77fbf5da1304ac
Issue-Id: CCSDK-67
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
Ryan Goulding [Thu, 7 Sep 2017 16:10:08 +0000 (12:10 -0400)]
Fix SDNC service registration
This change converts AsdcApiProvider and AsdcApiSliClient to utilize
Aries Blueprint for service instantiation instead of the ODL Config
Subsystem.
Change-Id: I5eaebe4c6e5b33fc8beb20b2cfe9acb6e8b6d808
Issue-Id: SDNC-54
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Dan Timoney [Wed, 6 Sep 2017 18:04:27 +0000 (14:04 -0400)]
Fix unimplemented createInstance
The createInstance() method in the provider yang-generated Module class
has a default implementation that throws an UnsupportedOperationException.
Replaced default implementation with correct code to create an instance
of the asdcApi and dataChange provider classes.
Change-Id: I1f2b199702a9094f6808ec077d6752c4c5c0c30d
Issue-ID: CCSDK-77
Signed-off-by: Dan Timoney <dtimoney@att.com>
Marcus G K Williams [Wed, 6 Sep 2017 01:19:11 +0000 (18:19 -0700)]
Fix staging variables for ccsdk/sli/northbound
Issue-Id: CCSDK-67
Change-Id: Ib5fe6cc5cb46e9d25cf66b6ab30e0d8b8654c426
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Marcus G K Williams [Fri, 1 Sep 2017 23:01:07 +0000 (16:01 -0700)]
Enable surefire unit testing
Issue-Id: CCSDK-67
Change-Id: If05df01e829a7a12ef00a1d778d918664635a48a
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Dan Timoney [Tue, 29 Aug 2017 12:52:32 +0000 (08:52 -0400)]
Cleanup artifactId for ccsdk/sli/northbound
ArtifactId for ccsdk/sli/northbound pom.xml should not be identical to that for
sdnc/northbound, otherwise import to Eclipse of both will be confusing.
Updated parent artifactId in module pom.xmls under ccsdk/sli/northbound
Change-Id: Ie1e1b7a1cd6bb7442a27ca083f37539cbc0497fb
Issue-ID: CCSDK-70
Signed-off-by: Dan Timoney <dtimoney@att.com>
Brian Freeman [Fri, 25 Aug 2017 17:16:00 +0000 (17:16 +0000)]
Fix to start script and annotation dependency
Change-Id: I38d4ffad440ea5866a398b8a6a7244d8bf156138
Signed-off-by: Brian Freeman <bf1936@att.com>
Issue-Id: SDNC-67
Dan Timoney [Tue, 15 Aug 2017 19:18:54 +0000 (15:18 -0400)]
Port sli/northbound to Carbon
Updated sli/northbound repo to compile against OpenDaylight Carbon SR1 release
Change-Id: I6aec68cf436e11f5fd5b7094eb5616536bead44f
Issue-ID: CCSDK-25
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 15 Aug 2017 18:10:37 +0000 (14:10 -0400)]
Refactor rest of sli/northbound
Update remainder of sli/northbound to replace references to openECOMP with references to ONAP
Change-Id: I2c321c9ec3f3138f3b7377ce1e0a8ff7e8f29bcc
Issue-ID: CCSDK-25
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Tue, 15 Aug 2017 13:46:03 +0000 (09:46 -0400)]
Refactor dataChange
Update dataChange to replace references to openECOMP with references to ONAP
Change-Id: I2d495dbc13e6dd38e0c975070969b07e796eb82f
Issue-ID: CCSDK-25
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Mon, 14 Aug 2017 20:06:52 +0000 (16:06 -0400)]
Refactor asdcApi
Refactor asdcApi to replace openecomp references with onap
Change-Id: Ic0d61ca75219a57331ba61908fba942a1c0dce7b
Issue-ID: CCSDK-25
Signed-off-by: Dan Timoney <dtimoney@att.com>
Dan Timoney [Wed, 19 Jul 2017 00:32:15 +0000 (20:32 -0400)]
[CCSDK-6] Populate seed code
Add seed code for sli/northbound repository
Update groupId to org.onap.ccsdk.sli.northbound
Update to use CCSDK version of sli core
Change-Id: Id3a154a53150a74f4b65060544e76f3e0cad932e
Signed-off-by: Dan Timoney <dtimoney@att.com>
Jessica Wagantall [Tue, 27 Jun 2017 21:35:55 +0000 (21:35 +0000)]
Initial empty repository
Code Review / ccsdk / sli / northbound.git / log