Merge "Incr State Mgmt Code Coverage"

Merge "Added junits to cover PUT/DELETE in RestManager"

Incr State Mgmt Code Coverage

Patch 1: Added JUnit tests to feature-state-management
to increase coverage. Estimated coverage is now 48%.
Patch 2: Trivial change to force a rebuild. Patch 3:
Tweaking the JUnit to try and account for the difference
between the LF environment and my local environment.
Patch 4: Something caused the policy endpoints JUnits
to fail - unrelated to these changes.  Made a trival
change to force a rebuild. Patch 5: Trivial change to
force rebuild. Patch 6: Minor changes in response to
Jorge Hernandez comments.

Issue-ID; POLICY-266
Change-Id: I7979c200ab18d5861ba20e0d5f23bd0083193daa
Signed-off-by: Kevin McKiou <km097d@att.com>

Added junits to cover PUT/DELETE in RestManager

Added some more junits that cover some of the PUT/DELETE methods
in the RestManager class. Not all are covered yet.

Issue-Id: POLICY-109
Change-Id: I7d7ac9656338c6ba0b3ffb76221fde5a90637236
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Added @Override method

Added diamond symbol on RHS
Removed useless parentheses

Issue-ID: POLICY-239
Change-Id: I1c3360a9c7242ff0ee23ab5599352d36bdf8ad9c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Added more junit coverage for RestManager class

More logic to GETTest which provides coverage for all
GET methods in RestManager class.

Issue-ID: POLICY-109
Change-Id: Ic5840b8baab73b1e3b440ca6f0b9909dd273c9fa
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Merge "Sonar Major"

Merge "Removed useless parentheses"

Merge "Added @Override method"

Merge "Added diamond symbol on RHS"

Merge "Removed useless parentheses"

Merge "Removed useless parentheses"

Merge "Removed useless parentheses"

Merge "Added junits to cover configuration classes"

Merge "Addition of Active-Standby Feature"

Merge "Added junit for policy-management"

Added junit for policy-management

Junits were added to cover the FileSystemPersistence
and RestManager classes

Patch 2: Merged some test functionality from FileSystemPersistenceTest
class into SystemPersistenceTest class. Deleted FileSystemPersistenceTest
class.

Issue-ID: POLICY-109
Change-Id: Ifd058b9988db30f6b5bc49ae54e5060c67f4ad5e
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Addition of Active-Standby Feature

Patch 1: Adds the active-standby feature to drools-pdp.
This feature provides the state control of the
drools-pdp nodes controlling failover with a site
and across sites. Patch 2: Resolve merge conflict in
packages/install/pom.xml and pom.xml. Patch 3: Resolved
comments from Pamela Dragosh and Jorge Hernandez.

Issue-ID: POLICY-156
Change-Id: I922b3d5d8a464006e9675924bcbc7409d68c08d5
Signed-off-by: Kevin McKiou <km097d@att.com>

Added junits to cover configuration classes

Added junits to cover DroolsConfiguration and ControllerConfiguration
classes.

Issue-Id: POLICY-262
Change-Id: Ie6cf4b15f8b08220a93b4469cc6fd4eda9299138
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Log exception

Logging as trace since it is an acceptable exception.

Change-Id: Ie93e60aeb95ece9b142c87f20eeb21ef56507dc4
Issue-ID: POLICY-261
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Removed useless parentheses

Added diamond symbol on RHS

Issue-ID: POLICY-239
Change-Id: I24c138703047308c2e28fef2180a0bb64400c1c9
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Added @Override method

Added diamond symbol on RHS
Removed useless parentheses

Issue-ID: POLICY-239
Change-Id: Ie20319a5a7298c70a18cc3773ec47f235dbdae41
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Added diamond symbol on RHS

Removed useless parentheses

Issue-ID: POLICY-239
Change-Id: Icad445f49cc619d71f71ef913f2592d5c7ebf29c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Removed useless parentheses

Added the diamond symbol on RHS side

Issue-ID: POLICY-239
Change-Id: I6f8516d4beedd94f4ff8801d51d368f436fe570c
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Removed useless parentheses

Added the diamond symbol on RHS side

Issue-ID: POLICY-239
Change-Id: Ie49d64124a3d314f0747f35e3627ec329338f0ff
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Removed useless parentheses

Added the "@Override" annotation

Issue-ID: POLICY-239
Change-Id: I9896f3130b5f8ecaa557d5386c0118e9a09008d2
Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>

Sonar Major

Removed Useless parenthesis

Change-Id: I366f85922c4d4d290b320e0b88678c805de59873
Issue-ID: POLICY-250
Signed-off-by: amshegokar <AS00500801@techmahindra.com>

load config files in ascending order by name

adding predictibility for environment and controller files
loading

Change-Id: Id02ddca75dd0dc8da658b64b84e77bef9e82b37c
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Adding JUnits for Configuration Classes

Also fixed some Sonar Major issues to help clean that up.

Issue-ID: POLICY-109
Change-Id: Ic8a0b8d97f2be1cc1f8e8e4e8b319c6117b231a4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

feature-state-management failing junits

because junit library is not part of the pom.

Change-Id: I4e8c12edfe2e91dcdb90200b8d4f37e35109f448
Issue-ID: POLICY-155
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "Fix sonar blocker/critical"

Add Junit tests to 'policy-core'

These tests focus on the following classes:
- PolicyContainer
- PolicySession
- PolicySessionFeatureAPI

'maven-invoker-plugin' was used to compile and install artifacts for
testing during the 'test-compile' phase. These aren't part of the
Maven project hierarchy, so they aren't visible to Sonar and SonarQube,
and they aren't deployed.

Change-Id: I67c122debbe5280f0153e7330248dc5d13c5b2c0
Issue-ID: POLICY-236
Signed-off-by: Ralph Straubs <rs8887@att.com>

Fix sonar blocker/critical

Also add back .gitignore
Sonar blocker for change condition always true. Easier to re-write
this using try-with-resources.
Use synchronized static method to set a static variable.
Don't use e.printStackTrace it causes sonar critical to log exception
Log the bytes read. Ideally I would re-write this using Java 8 NIO

Issue-ID: POLICY-195
Change-Id: I080d1ad4c8bea91f87c3eca109325700e1589558
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Added junit for feature-healthcheck"

Added junit for feature-healthcheck

Added a junit test increase coverage of the healthcheck feature.

Issue-ID: POLICY-227
Change-Id: I3f37e7fab15f2f3072b442b43b79b8241c61e306
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Merge "Addition of State Management Feature"

Fix sonar related to persistence-feature

Sonar blocker for catchable:
I am not sure why this is wrapped with an exception.
Changing try-catch to use Exception | LinkageError per Jorge/Ralph.

Sonar critical for logging exceptions.

Sonar critical for casting to Long and reinterrupting thread.

Change-Id: I44d46f005d9aa30c434c22e479034107055277ce
Issue-ID: POLICY-195
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Sonar Major

Move the string literal on the left side of this string comparison.

Change-Id: I8086a6fc1dc24719c3ffd3785a12c086ab453ae7
Issue-ID: POLICY-230
Signed-off-by: SwapnilPathak <SP00494485@techmahindra.com>

Addition of State Management Feature

Patch 1:This commit adds the feature to provide node state management.
There are also a couple of very minor cleanup items in
feature-session-persistence which came up during review and testing.
Patch 2: Cleaned up some logging statements and exceptions per
comments by Pam Dragosh. Patch 3: Clean up per comments from
Jorge Hernandez. Patch4: Added a default to ignoreErrors in
RepositoryAudit. Patch 5: Rebase.  Patch 6: Removed
api-state-management/.gitignore

Issue-ID: POLICY-155
Change-Id: I4fbfa33314d488ff46764931ca965f802b6a26d5
Signed-off-by: Kevin McKiou <km097d@att.com>

Merge "Eliminate hanging when updating Drools containers"

Eliminate hanging when updating Drools containers

'PolicyContainer.updateToVersion(...)' now hangs unless the Drools session
threads are stopped prior to the update. This wasn't an issue in the past,
and it isn't clear what causes it to happen now. It also happened in the
Junit tests I am currently working on.

In any case, the 'updateToVersion' method has now been changed to stop
the threads prior to an update attempt, do the update, and then restart
the threads.

Change-Id: I577a67c6e99a68bcbe3c2f476f93c0a72b93451a
Issue-ID: POLICY-234
Signed-off-by: Ralph Straubs <rs8887@att.com>

added "fetch timeout" backoff for UEB endpoints

this prevents high frequency fruitless attempts to connect to an
unreachable (perhaps temporarily) UEB server.

added additional management apis for noop endpoints.

bump versions of jackson parsers so through snakeyaml library
throughtransitive dependencies is bump up from 1.15 as it is
resolved in the classpath at runtime to > 1.17
otherwise causes incompatibilities with the one used in
controlloops under their own classloaders, as they expect 1.17.

Change-Id: I936348c4b93a2c409c22568868c44ed330dc18f7
Issue-ID: POLICY-119
Signed-off-by: Jorge Hernandez <jh1730@att.com>

wait until port is open in HttpClient junit tests

As a note, HttpServer tests have retries at the http level.

Hopefully this will resolve some timing issues and intermittent junits
failures in LF jenkins environment.

Issue-ID: POLICY-109
Change-Id: I44628b60d4912be5fc4639e0048791f5655bbd01
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "missing check for noop sinks"

Merge "Added junits for policy-util classes"

Added junits for policy-util classes

Added junits to increase coverage of the policy-util module.
Patch 1: Moved Parent and Child class to within ReflectionUtilTest class.

Issue-ID: POLICY-214
Change-Id: Ic5882c02a65ba1c924ec1381901a2a971fe72911
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

missing check for noop sinks

Change-Id: If7167415c361fad2478809ac6c41981beaadacd6
Issue-ID: POLICY-119
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: Ic266276a2cc9537897dba90b4887b38cd0efed4d
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>

Small change to please sonar

Added a 'Thread.currentThread().interrupt()' in a catch of the run method of TTControllerTask
at the direction of sonar.

Added dump of exception to logger.

Issue-ID: POLICY-213
Change-Id: I2bdd74eacedb6d1950c5c730430d7f723ce494bc
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Support environment configurations

This enables PDP-D to have knowledge of any installation
property or else configured via OS environment variable
or as an environment file.

This allows the user to query or set via REST API of programmatically
through PolicyEngine any environment variable.

It also provides a means to make data globally available to all
drools applications.

For example:

http://localhost:9696/policy/pdp/engine/environment> get
HTTP/1.1 200 OK
Content-Length: 749
Content-Type: application/json
Date: Wed, 06 Sep 2017 23:53:57 GMT
Server: Jetty(9.3.14.v20161028)

{
    "DCAE_SERVERS": "",
    "DCAE_TOPIC": "",
    "DMAAP_SERVERS": "",
    "ENGINE_MANAGEMENT_HOST": "0.0.0.0",
    "ENGINE_MANAGEMENT_PASSWORD": "",
    "ENGINE_MANAGEMENT_PORT": "9696",
    "ENGINE_MANAGEMENT_USER": "",
    "HEALTHCHECK_PASSWORD": "",
    "HEALTHCHECK_USER": "",
    "JAVA_HOME": "/usr/lib/jvm/java-8-oracle",
    "M2_HOME": "/usr/share/maven",
    "PAP_HOST": "",
    "PAP_PASSWORD": "",
    "PAP_USERNAME": "",
    "PDPD_CONFIGURATION_API_KEY": "",
    "PDPD_CONFIGURATION_API_SECRET": "",
    "PDPD_CONFIGURATION_CONSUMER_GROUP": "",
    "PDPD_CONFIGURATION_CONSUMER_INSTANCE": "",
    "PDPD_CONFIGURATION_PARTITION_KEY": "",
    "PDPD_CONFIGURATION_SERVERS": "",
    "PDPD_CONFIGURATION_TOPIC": "PDPD-CONFIGURATION",
    "PDP_HOST": "",
    "PDP_PASSWORD": "",
    "PDP_USERNAME": "",
    "POLICY_HOME": "/home/policy/snapshot",
    "SQL_HOST": "",
    "SQL_PASSWORD": "",
    "SQL_USER": ""
}

policy@newton:~/snapshot/config$ echo -n "http://one.com/aai" | http --verbose PUT :9696/policy/pdp/engine/environment/AAI_URL Content-Type:text/plain Accept:text/plain
PUT /policy/pdp/engine/environment/AAI_URL HTTP/1.1
Accept: text/plain
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 18
Content-Type: text/plain
Host: localhost:9696
User-Agent: HTTPie/0.9.2

http://one.com/aai

HTTP/1.1 200 OK
Content-Length: 0
Content-Type: text/plain
Date: Thu, 07 Sep 2017 00:05:05 GMT
Server: Jetty(9.3.14.v20161028)

policy@newton:~/snapshot/config$ echo -n "http://one.com/aai2" | http --verbose PUT :9696/policy/pdp/engine/environment/AAI_URL Content-Type:text/plain Accept:text/plain
PUT /policy/pdp/engine/environment/AAI_URL HTTP/1.1
Accept: text/plain
Accept-Encoding: gzip, deflate
Connection: keep-alive
Content-Length: 19
Content-Type: text/plain
Host: localhost:9696
User-Agent: HTTPie/0.9.2

http://one.com/aai2

HTTP/1.1 200 OK
Content-Length: 18
Content-Type: text/plain
Date: Thu, 07 Sep 2017 00:05:45 GMT
Server: Jetty(9.3.14.v20161028)

http://one.com/aai

policy@newton:~/snapshot/config$ http :9696/policy/pdp/engine/environment/AAI_URL

HTTP/1.1 200 OK
Content-Length: 19
Content-Type: application/json
Date: Thu, 07 Sep 2017 05:14:57 GMT
Server: Jetty(9.3.14.v20161028)

http://one.com/aai2

Change-Id: I1fcd610938af751977bb2db925b57b4e5b3f7ba4
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Added junit for test-transaction feature

Single junit was added for test-transaction feature.
Junit does not test full functionality of the feature,
but does test some of the peripheral methods.

Also fixed small indentation error in assemble_zip.xml.

Issue-ID: POLICY-198
Change-Id: Iad7a98be45eb8ef6701bf8381aa764d2dd1ca9c7
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

Support Utils Libraries for CL Lab Integration

There is a companion review in the drools-applications repo.

This also includes workarounds to the recent oparent dependency
introduction that breaks runtime (with the version-check-maven-plugin).

It manifested by loading control loops and failing to load some classes
due to different versions (in a lab environment).

The issue was that underlying drools libraries use 3.2.5 and oparent
has included a had dependency with transitive dependencies for some maven
libraries in 3.2.3 and lower version xml parsers.   Bottomoline, the
classpath at runtime was formed by the union of both, with some
libraries being resolved to the oparent one, and others to the drools
one.   These errors are very obscured to debug.

Additional clean up of dependencies versions and order of build
was introduced to avoid issues loading dependencies at runtime in a
lab environment (non-junit)..

Change-Id: If4f4201e08f7e6e1f3619f557434c1b2e23e47a5
Issue-ID: POLICY-162
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Added new test transaction feature

Added test transaction feature which is used to test the health
of policy controllers.

Issue-ID: POLICY-177
Change-Id: I9a966be73f040c01e208bffd1dd67e8d858c1d37
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>

junits in policy-management

- add additional junits for policy-management module
- allow for no configuration pdp-d start up.
- minor changes junits for policy-endpoints to avoid
  race conditions in jenkins environment, starting up, and
  shutting down servers.

Issue-ID: POLICY-109
Change-Id: Ibccefeb5d7cf762da27fe3282887df18d79db5df
Signed-off-by: Jorge Hernandez <jh1730@att.com>

rename scripts and clean up eclipse warnings

rename scripts to follow convention that executable scripts should not
have file extensions.

clean up some warnings in eclipse

Issue-ID: POLICY-162
Change-Id: I82be87925c3a8264381795535d33cee04924ae92
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Add access.log to jetty server

Added a single line to the code that creates the jetty server so that
it will log messages in access.log format.  Also added lines to various
logback.xml files to actually write the output from the jetty server
to the access.log.

Made some revisions per comments:
- removed spaces around parameters
- added "Out" suffix
- changed suffix of archived files
- changed size to 1MB

Modified logback*.xml files to include jetty "access log" content in
the already-existing network.log.

Issue-Id: POLICY-161
Change-Id: I3e3769c06a22aaffea0e09abbec3387cc62f246f
Signed-off-by: jrh3 <jrh3@att.com>

Add feature-session-persistence

This commit adds the feature-session-persistence module
which will persist drools session data to allow stateful
transactions which can persist across node restarts and
failovers. It also picks up recent changes to the master
branch to avoid merge conflicts.

Issue-ID: POLICY-133
Change-Id: Ifdcd8280ea6df07db79562f1b01fa90296a8b878
Signed-off-by: Kevin McKiou <km097d@att.com>

Adding changes to resolve pom.xml

Issue-ID: POLICY-175
Change-Id: I3be1db6fdc1e070aff98c99fa9089a946ef7d6a3
Signed-off-by: Viswanath KSP <viswanath.kumarskandpriya@verizon.com>

sonar criticals and some majors

Issue-ID: POLICY-114
Change-Id: I5fe12b6538379a4d018bb76173247fe53fba21d7
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Expand acces dependencies to ONAP repos.

Make public ONAP drools-applications repos at runtime or
during development testing to ensure that no dependencies
are missed, nor all of them need to be published in
the private nexus repository.

This will be benefitial at runtime and also during control
loop development as control loops archetypes could be
used from anywhere.

Change-Id: I787b5afaf5c525f83326e924d6b9bcf85f9a7662
Issue-ID: POLICY-159
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Remove MojoHaus Maven plug-in from pom file

Remove MojoHaus License Maven plug-in from main pom.xml file.

Issue-ID: POLICY-116
Change-Id: I3acfba5a998733006e04c8109ba9821c0c0c9573
Signed-off-by: Temoc Rodriguez <cr056n@att.com>

Merge "Fix "critical" Sonar issue"

add hibernate JPA libraries in base

To make feature development easier for DB-enabled features

Change-Id: I7f69ecfbbfb9eaac92f698bdb787ce881eec39f0
Issue-ID: POLICY-96
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Fix "critical" Sonar issue

Change-Id: I46e59d9a017722370cff4112250bcdfa0f0d0b23
Issue-ID: POLICY-160
Signed-off-by: Ralph Straubs <rs8887@att.com>

add persistence libraries in the installation base

to make db-enabled features to not worry about their
packaging in the copy-dependencies plugin in the
pom.xml

Change-Id: Ie20a61978f75d4dbe82ac7aba5f6d259fb412f22
Issue-ID: POLICY-96
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "Support of DB-enabled features"

Support of DB-enabled features

Isolation and data migration support overall and on a per
feature basis.

policy@drools:/opt/app/policy$ policy.sh status

[drools-pdp-controllers]
 L []: Policy Management (no pidfile) is NOT running
1 cron jobs installed.

[features]
name                 version         status
----                 -------         ------
eelf                 1.1.0           disabled
healthcheck          1.1.0           disabled
session-persistence  1.1.0           enabled

[migration]
session-persistence: upgrade out-of-sync: 0 -> 201702

policy@drools:/opt/app/policy$ features enable session-persistence
session-persistence: upgrade out-of-sync: 0 -> 201702

name                 version         status
----                 -------         ------
eelf                 1.1.0           disabled
healthcheck          1.1.0           disabled
session-persistence  1.1.0           enabled

policy@drools:/opt/app/policy$ db-migrator -s session-persistence -o upgrade
upgrade: 0 -> 201702

> upgrade 201701-blah.upgrade.sql
--------------
create table blah (a varchar(15), b varchar(20))
--------------

> upgrade 201702-blah2.upgrade.sql
--------------
create table blah2 (a varchar(15), b varchar(20))
--------------

session-persistence: OK: upgrade (201702)

policy@drools:/opt/app/policy$ db-migrator -s ALL -o report
+---------------------+---------+
| name                | version |
+---------------------+---------+
| session-persistence | 201702  |
+---------------------+---------+
+--------------------------+-----------+---------+---------------------+
| script                   | operation | success | atTime              |
+--------------------------+-----------+---------+---------------------+
| 201701-blah.upgrade.sql  | upgrade   | 1       | 2017-08-14 16:01:32 |
| 201702-blah2.upgrade.sql | upgrade   | 1       | 2017-08-14 16:01:32 |
+--------------------------+-----------+---------+---------------------+

policy@drools:/opt/app/policy$ features disable session-persistence

name                 version         status
----                 -------         ------
eelf                 1.1.0           disabled
healthcheck          1.1.0           disabled
session-persistence  1.1.0           disabled

policy@drools:/opt/app/policy$ db-migrator -s ALL -o downgrade
downgrade: 201702 -> 0

> downgrade 201702-blah2.downgrade.sql
--------------
drop table if exists blah2
--------------

> downgrade 201701-blah.downgrade.sql
--------------
drop table if exists blah
--------------

session-persistence: OK: downgrade (0)

policy@drools:/opt/app/policy$ db-migrator -s ALL -o report
+---------------------+---------+
| name                | version |
+---------------------+---------+
| session-persistence | 0       |
+---------------------+---------+
+----------------------------+-----------+---------+---------------------+
| script                     | operation | success | atTime              |
+----------------------------+-----------+---------+---------------------+
| 201701-blah.upgrade.sql    | upgrade   | 1       | 2017-08-14 16:01:32 |
| 201702-blah2.upgrade.sql   | upgrade   | 1       | 2017-08-14 16:01:32 |
| 201701-blah.downgrade.sql  | downgrade | 1       | 2017-08-14 16:13:49 |
| 201702-blah2.downgrade.sql | downgrade | 1       | 2017-08-14 16:13:49 |
+----------------------------+-----------+---------+---------------------+
session-persistence: OK @ 0

Change-Id: Ie185f5d7a8463cb349ac452d8c2b4b05928b3e56
Issue-ID: POLICY-96
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Remove eclipse checkstyle warnings

Add this should remove Eclipse warnings:
Plugin execution not covered by lifecycle configuration: org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (execution: check-style, phase: process-sources)

Issue-Id: POLICY-166
Change-Id: I609ebced831458e1fa56c57a30bceb3512c0dc7f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Add 'install' and 'uninstall' to 'features' script

Note that the 'install' option looks for a 'base.conf' script in the
current directory, as well as the '${POLICY_HOME}/config' directory.
The assumption is 'base.conf' is saved here when the initial DroolsPDP
install is complete.

Issue-ID: POLICY-163
Change-Id: I995c685ca8ff896f3d8a027324e30673075e0c1f
Signed-off-by: Ralph Straubs <rs8887@att.com>

Merge "placement of sql files during feature operations"

placement of sql files during feature operations

This commit only takes care of enabling disabling global visibility
of sql files on a per database basis, when a feature is enabled/disabled.

Performing the actual databases upgrade operations will be provided
in a subsequent commit.

Issue-ID: POLICY-66
Change-Id: Ia82e5ccb3a9f02e9d937ce4791fdca4204b8f9e8
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "[POLICY-151] drools-pdp integration with oparent"

[POLICY-151] drools-pdp integration with oparent

Change-Id: Id419034816ea047276484e20c5e211a3fba5ec7a
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>

[POLICY-114] fix some sonar criticals

Change-Id: Ic79b3d81ac814948ce3a956fe4c32b8a9b5c0009
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "[POLICY-66] healtcheck feature config and db prep"

[POLICY-66] healtcheck feature config and db prep

initial commit pre-intro of db support on per feature basis

Change-Id: Ie790764bc58f773da381ae88b6f7476fbd2af2e5
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-145] fix typo in features files

Change-Id: Idb9d40e5818dbd2b3f4633888df413ffc077c89d
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-72] forgot one onap-staging

Change-Id: Ib5c7ce30b31b03f3dfc2f914946e934a6b201cc2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-72] missed onap repo ids

Change-Id: Id71d2d0f551fa5404920a0ab5347db077eb53767
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-72] put back ecomp server ids.

Change-Id: I41df0afcf9c721c6a614027eb92e84d3c2c3aab5
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-72] replace openecomp for drools-pdp

Change-Id: I8aa8e32d3ba10f7c655b50e97aaf6865514d4777
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>

[POLICY-52] pdp-d: PolicyEngine junits

Change-Id: I8c85d75d7eddd7c959ed4cfb7167b58d9c7c9854
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "[POLICY-119] noop endpoint and refactoring"

[POLICY-119] noop endpoint and refactoring

noop endpoint was added to support communication between drools-applications
and policy-framework using the common "PolicyEngine.deliver(topic, message)"
mechanins.   The endpoint type will be noop.   This can be used for testing
sanity of any given drools-application from the framework.

An intial refactoring of the endpoints hierarchy was added too.

Change-Id: I62dbe75f511dd6215406fbd7cf0dd5a88bc1efc3
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-109] set up parent pom for sonar

Change-Id: I89ba6326d5f1bedcd072772945f547cb339456e9
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-66] policy.sh policy-management-controller

Explicit invokation of policy-management-controller in policy.sh
since it loops through scripts picks up others it shouldn't when
an operation is selected.
Benign but not stetic.

Change-Id: I140ca6b0501b3368e9eac0b3ddf947b59c74e426
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-66] consolidate script naming + location

consolidate scripting convention by all adopting not .sh for
bash scripts.  Location is under policy-management/src/main/server-gen/bin/
so they are inherited by lab installations that don't use the
packages directory.

Change-Id: Ibcbd4bffad38e87cb3b644deb768120b1a6b2cbb
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-8] clean pdp-d from sonar blockers

Change-Id: I25427a0505e2fdd2b0b939f652452cb4f9f07f02
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-52] enabled properties http junit test

will also take care of some race conditions seen in gerrit
triggered jenkin jobs as it brings up / tears down
http servers per junit test method.

Change-Id: I0b18073ebfaab3a6f0d08efee1edacd8d5d9e3ca
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-88] validation of query pre-execution

Change-Id: Ie02de9aca434c3d80b9e34126990e3b9995747bb
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-9] Mac .DS_Store is annoying

Change-Id: Id1acdd31cfabbaa24677c26fb65c79228a0a8093
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

[POLICY-66] self-contained features support

installation/enable/disable of self contained package features:

Feature 3rd party dependencies, configuration files, and
custom installation scripts do not need to be packaged within the policy
core base to be used.

Change-Id: I35a472e63bd0f9f7aa6cd0c112d41d2b4604a892
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-78] Upgrade Drools and Guava Versions

Change-Id: Iaa17e84c6d9ba45ec3703a70d932da873d0b45a9
Signed-off-by: Ralph Straubs <rs8887@att.com>

[POLICY-75] Problems with KieScanner

1) Change the 'PolicySession.DefaultThreadModel' thread so it
   continually calls 'fireUntilHalt' until it is explicitly stopped by
   the 'stop()' method. This allows it to restart after 'KieScanner'
   triggers an update.

2) Remove call to 'startScanner' in 'PolicyContainer' constructor --
   we saw at least one case where 'KieScanner' would repeatedly update
   the Drools container every 60 seconds.

Change-Id: I0d0e6c5650cef12ca00cf88f9b8cc52323bb6317
Signed-off-by: Ralph Straubs <rs8887@att.com>

[POLICY-66] rename of policy-healthcheck

using "feature-" naming convention.

Change-Id: I13d6b75750d369ed9e61f3c9c9408b31eac6bb2d
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-30] optional loadable eelf feature

for backwards compatibility purposes or if desired to
use EELF and common-framework (from policy-common) for
logging purposes in miscellaneous environments.   It supports
EELF/Common Framework style logging at the same time than
traditional logging.

This functionality is an optional loadable module.

policy-docker changes need to be made to optionally
unpack to make it active (in a different submission).

started marking feature projects with feature prefix in
project name to give a clear picture to the community which
modules are features vs. code base.

Change-Id: I5076c462409f03415ce54f0c9b5f50b78abb18f9
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-30] telemetry script

Change-Id: Iad43bf9c30de174527fb6a29c216dae6e3ea1a17
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-30] remove problematic layers

add configurability through telemetry API

Change-Id: I77ebde12a417d421b98646c32dc74824f4494c2e
Signed-off-by: Jorge Hernandez <jh1730@att.com>

[POLICY-21] PDP-D gets stuck during shutdown

The fix for this problem is included in the following enhancements:

1) Define a new nested interface 'PolicySession.ThreadModel', which makes
   it possible for features to control the thread or threads processing
   a 'KieSession'.

   The nested class 'PolicySession.DefaultThreadModel' implements the
   default version, which uses 'KieSession.fireUntilHalt()' instead of
   polling 'KieSession.fireAllRules()'.

   A new method 'selectThreadModel(PolicySession session)' has been added
   to 'PolicySessionFeatureAPI' to enable this selection.

2) Update thread names when 'KieContainer.updateToVersion(...)' is called

Change-Id: Ic48089fe5660501e2e3d42b87501697211a9d0fe
Signed-off-by: Ralph Straubs <rs8887@att.com>

[POLICY-8] cleaned up unused code

Change-Id: Ifebf67db574e1c4eadf9d50ca0f178ab7ddba033
Signed-off-by: Jorge Hernandez <jh1730@att.com>