so.git
4 years agoadd the NBI section to the instantiate flows 11/93011/1
seshukm [Thu, 8 Aug 2019 07:29:54 +0000 (12:59 +0530)]
add the NBI section to the instantiate flows

Issue-ID: SO-608

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I5567a89fa36aa85397a3472147e7848f44561a48

4 years agoMerge "Replace duplicated String literals"
Seshu Kumar M [Thu, 8 Aug 2019 07:25:06 +0000 (07:25 +0000)]
Merge "Replace duplicated String literals"

4 years agoMerge "Shift string literal to left side of equals(avoid null pointer ex)"
Seshu Kumar M [Thu, 8 Aug 2019 07:24:02 +0000 (07:24 +0000)]
Merge "Shift string literal to left side of equals(avoid null pointer ex)"

4 years agoMerge changes I00b02c80,Icf854fba,I41a7ea89,I3c9b75ba
subhash kumar singh [Thu, 8 Aug 2019 06:58:44 +0000 (06:58 +0000)]
Merge changes I00b02c80,Icf854fba,I41a7ea89,I3c9b75ba

* changes:
  add instantiation flow
  add pre_instantiation details
  add the information of the instantiate in dev guide
  correct the camunda modeler info Introduce the instantiate flow details

4 years agoMerge "Set suppressRollback variable for ActivityBBs"
Seshu Kumar M [Thu, 8 Aug 2019 06:11:13 +0000 (06:11 +0000)]
Merge "Set suppressRollback variable for ActivityBBs"

4 years agoShift string literal to left side of equals(avoid null pointer ex) 96/92996/1
sindhu3672 [Thu, 8 Aug 2019 06:10:48 +0000 (11:40 +0530)]
Shift string literal to left side of equals(avoid null pointer ex)

Avoid null pointer exception mso-openstack-adapters classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ie7099318a79162aed26ec3a8e4a013cece367736

4 years agoadd instantiation flow 94/92994/1
seshukm [Thu, 8 Aug 2019 05:58:35 +0000 (11:28 +0530)]
add instantiation flow

Issue-ID: SO-608

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I00b02c80c357ce5379d89769a3552e826ef257cc

4 years agoadd pre_instantiation details 93/92993/1
seshukm [Thu, 8 Aug 2019 05:57:27 +0000 (11:27 +0530)]
add pre_instantiation details

Issue-ID: SO-608

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: Icf854fba5ea3c94a0b320ed5fef6375a688b040f

4 years agoadd the information of the instantiate in dev guide 92/92992/1
seshukm [Thu, 8 Aug 2019 05:49:42 +0000 (11:19 +0530)]
add the information of the instantiate in dev guide

Issue-ID: SO-608

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I41a7ea89245da8be8e1a1e41138a662e9cce2ffa

4 years agoReplace duplicated String literals 83/92983/2
sindhu3672 [Wed, 7 Aug 2019 10:09:35 +0000 (15:39 +0530)]
Replace duplicated String literals

Replace duplicated String literals mso-openstack-adapters files

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I3089f407ffd01afbccaada81c2aef290299dfe32

4 years agocorrect the camunda modeler info 91/92991/1
seshukm [Thu, 8 Aug 2019 05:43:54 +0000 (11:13 +0530)]
correct the camunda modeler info
Introduce the instantiate flow details

Issue-ID: SO-608

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I3c9b75ba734b918d2ee57242944b4b087e9e5792

4 years agoAdd SO Message instead of Exception when vmIds are empty 33/92933/2
Bonkur, Venkat (vb8416) [Wed, 7 Aug 2019 17:47:54 +0000 (13:47 -0400)]
Add SO Message instead of Exception when vmIds are empty

Add the conditions to log messages instead of null pointer exception
when vmIds or vserverIds are not present.
Issue-ID: SO-2186
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I27dd8a5480cf5e2d8588cc71ca3bfefaf0e138cc

4 years agoMerge "updated delete payloads for bulk deletes"
Steve Smokowski [Wed, 7 Aug 2019 12:16:52 +0000 (12:16 +0000)]
Merge "updated delete payloads for bulk deletes"

4 years agoSet suppressRollback variable for ActivityBBs 06/92906/1
Elena Kuleshov [Tue, 6 Aug 2019 19:55:54 +0000 (15:55 -0400)]
Set suppressRollback variable for ActivityBBs

SuppressRollback variable needs to be true for ActivityBBs

Issue-ID: SO-2163
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I64754e9fc010b48eb8ee9b41fd0fe31c0fbb2592

4 years ago- Updated cvnfc's to use the getEntity API. 39/92839/1
Merkel, Jeff [Tue, 6 Aug 2019 19:56:30 +0000 (15:56 -0400)]
- Updated cvnfc's to use the getEntity API.

- Updated cvnfc's to use the getEntity API.

Issue-ID: SO-2202
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id367e82d655a838100d8f81f8b4f76303600b182

4 years agoupdated delete payloads for bulk deletes 38/92838/1
Benjamin, Max [Tue, 6 Aug 2019 19:54:51 +0000 (15:54 -0400)]
updated delete payloads for bulk deletes

updated delete payloads for bulk deletes
moved test-request.json to the correct location

Issue-ID: SO-2203
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8d9d4d0bbe45f32d4e07a1ba0128e627d3b27795

4 years agoAdded close() call for InputStream instance to 63/92763/1
Oleksandr Moliavko [Tue, 6 Aug 2019 08:59:56 +0000 (11:59 +0300)]
Added close() call for InputStream instance to
remove static analyzer warning about handle
leak in getMsoAaiPassword()

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I2be9cc72f78275a80c6f03d806bea2ad275f23b4

4 years agoMerge "Added null check for return value of getUpdateResInputObj(), to prevent crash...
Seshu Kumar M [Mon, 5 Aug 2019 12:07:54 +0000 (12:07 +0000)]
Merge "Added null check for return value of getUpdateResInputObj(), to prevent crash at call of toString() method"

4 years agoMerge "ModelInstanceName is required in SNIROHomingv2 to"
Seshu Kumar M [Mon, 5 Aug 2019 12:01:07 +0000 (12:01 +0000)]
Merge "ModelInstanceName is required in SNIROHomingv2 to"

4 years agoMerge "Added newToken null check to prevent crash at newToken.getValue() call"
Seshu Kumar M [Mon, 5 Aug 2019 11:58:27 +0000 (11:58 +0000)]
Merge "Added newToken null check to prevent crash at newToken.getValue() call"

4 years agoAdded null check for return value of 70/92670/1
Oleksandr Moliavko [Mon, 5 Aug 2019 11:21:10 +0000 (14:21 +0300)]
Added null check for return value of
getUpdateResInputObj(), to prevent crash at call
of toString() method

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ifa6c683885490fef7fcf08e2b32b2dc76ef776a6

4 years agoMerge "Removed addition of null value to string to prevent static analyzer warning"
Seshu Kumar M [Mon, 5 Aug 2019 05:13:36 +0000 (05:13 +0000)]
Merge "Removed addition of null value to string to prevent static analyzer warning"

4 years agoMerge "Fix Blocker Bug"
Seshu Kumar M [Mon, 5 Aug 2019 05:12:20 +0000 (05:12 +0000)]
Merge "Fix Blocker Bug"

4 years agoFix Blocker Bug - prevent from npe throwing 92/92592/1
Lukasz Muszkieta [Fri, 2 Aug 2019 16:59:12 +0000 (18:59 +0200)]
Fix Blocker Bug - prevent from npe throwing

Change-Id: Id6dd23c07f282ac7c7d3df3f612175d1bbf5a184
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoFix Blocker Bug 84/92584/1
Lukasz Muszkieta [Fri, 2 Aug 2019 15:36:37 +0000 (17:36 +0200)]
Fix Blocker Bug

Change-Id: I6be7c799896d32ffd20591ce9b8a0957d506b5c3
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoModelInstanceName is required in SNIROHomingv2 to 75/92575/1
Gamboa, Gilbert [Fri, 2 Aug 2019 14:11:17 +0000 (10:11 -0400)]
ModelInstanceName is required in SNIROHomingv2 to

ModelInstanceName is required in SNIROHomingv2 to build placement
demand. The source service does not have a modelInstanceName attribute,
we need to set it to the service proxy modelInstanceName.

Issue-ID: SO-2188
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I85c0940b17349c8dd5dc171954acf9f884ccff9f

4 years agoAdded newToken null check to prevent crash at 73/92573/1
Oleksandr Moliavko [Fri, 2 Aug 2019 13:08:18 +0000 (16:08 +0300)]
Added newToken null check to prevent crash at
newToken.getValue() call

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib338ec2d901fd68d5b04be4423088449546b7e31

4 years agoRemoved addition of null value to string to 68/92568/1
Oleksandr Moliavko [Fri, 2 Aug 2019 12:26:05 +0000 (15:26 +0300)]
Removed addition of null value to string to
prevent static analyzer warning

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ib9dbd55f3688e38688668828778653eadc04a836

4 years agoMerge "Use correct name and id for VNFUnsetClosedLoopDisabledFlagActivity"
Seshu Kumar M [Fri, 2 Aug 2019 07:09:32 +0000 (07:09 +0000)]
Merge "Use correct name and id for VNFUnsetClosedLoopDisabledFlagActivity"

4 years agoMerge "Fixed potential crashes due to null object dereference attempts in exception...
Seshu Kumar M [Fri, 2 Aug 2019 07:08:00 +0000 (07:08 +0000)]
Merge "Fixed potential crashes due to null object dereference attempts in exception handlers"

4 years agoMerge "General sonar fixes"
Seshu Kumar M [Fri, 2 Aug 2019 07:05:41 +0000 (07:05 +0000)]
Merge "General sonar fixes"

4 years agoMerge "Add oauth for calls from VNFM to VNFM adapter"
Seshu Kumar M [Fri, 2 Aug 2019 07:03:47 +0000 (07:03 +0000)]
Merge "Add oauth for calls from VNFM to VNFM adapter"

4 years agoMerge "Add SO Increase Action_category column width"
Seshu Kumar M [Fri, 2 Aug 2019 07:00:40 +0000 (07:00 +0000)]
Merge "Add SO Increase Action_category column width"

4 years agoMerge "Added null checks to prevent crashes at method calls"
Seshu Kumar M [Fri, 2 Aug 2019 06:59:14 +0000 (06:59 +0000)]
Merge "Added null checks to prevent crashes at method calls"

4 years agoMerge "Added null check for injectedVariables to prevent crash at call of injectedVar...
Seshu Kumar M [Fri, 2 Aug 2019 06:56:19 +0000 (06:56 +0000)]
Merge "Added null check for injectedVariables to prevent crash at call of injectedVariables.get()"

4 years agoGeneral sonar fixes 26/92526/1
Arindam Mondal [Fri, 2 Aug 2019 06:08:56 +0000 (15:08 +0900)]
General sonar fixes

+) Add logger to log exception
++) Format logger

Issue-ID: SO-2187
Change-Id: Id77271340070a61e7ce82822321d7e5b8b03f759
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
4 years agoMerge "Updatable to false to prevent setting fk to null"
Seshu Kumar M [Fri, 2 Aug 2019 05:45:09 +0000 (05:45 +0000)]
Merge "Updatable to false to prevent setting fk to null"

4 years agoAdd SO Increase Action_category column width 18/92518/1
Bonkur, Venkat (vb8416) [Fri, 2 Aug 2019 03:30:05 +0000 (23:30 -0400)]
Add SO Increase Action_category column width

Action_category column width in Controller_selection_category table
is increased to accommodate activity categories like
DistributeTrafficCheck which are longer than the column width.
Issue-ID: SO-2185
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ia5c813bfabfc95d4502c7ade4413672c64ad8ada

4 years agoAdd oauth for calls from VNFM to VNFM adapter 06/92506/1
MichaelMorris [Thu, 1 Aug 2019 21:57:24 +0000 (21:57 +0000)]
Add oauth for calls from VNFM to VNFM adapter

Change-Id: I6ff1f9ed130b8331f6a001d3dcb64b9dcfb30eb5
Issue-ID: SO-2180
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoMerge "Add oauth for calls from VNFM adapter to VNFM"
Byung-Woo Jun [Thu, 1 Aug 2019 17:47:33 +0000 (17:47 +0000)]
Merge "Add oauth for calls from VNFM adapter to VNFM"

4 years agoAdded null checks to prevent crashes at 74/92474/1
Oleksandr Moliavko [Thu, 1 Aug 2019 14:25:47 +0000 (17:25 +0300)]
Added null checks to prevent crashes at
method calls

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ie3b70aa59cf73ca6203d0f1aab1ed096af906050

4 years agoFixed potential crashes due to null object 53/92453/1
Oleksandr Moliavko [Thu, 1 Aug 2019 11:02:18 +0000 (14:02 +0300)]
Fixed potential crashes due to null object
dereference attempts in exception handlers

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I9882171b47b6442fa8ca12110d8ef23fc975347b

4 years agoHandle no pservers case on lock check 00/92500/1
Elena Kuleshov [Thu, 1 Aug 2019 07:13:04 +0000 (03:13 -0400)]
Handle no pservers case on lock check

Check for null return value from pservers query

Issue-ID: SO-2184
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I34c71601e694241a6d3cfefa8227200e715e2ed3

4 years agoAdded null check for injectedVariables to prevent 15/92215/2
Oleksandr Moliavko [Mon, 29 Jul 2019 15:13:55 +0000 (18:13 +0300)]
Added null check for injectedVariables to prevent
crash at call of injectedVariables.get()

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I1d05b32b0aa0c001c79e41576bc8b3435a9aae1f

4 years agoUse correct name and id for VNFUnsetClosedLoopDisabledFlagActivity 94/92494/1
Elena Kuleshov [Thu, 1 Aug 2019 05:47:58 +0000 (01:47 -0400)]
Use correct name and id for VNFUnsetClosedLoopDisabledFlagActivity

Set name and id for VNFUnsetClosedLoopDisabledFlagActivity to VNFUnsetClosedLoopDisabledFlagActivity

Issue-ID: SO-2183
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I401258b2db32c43566019a903a57ca61e30649e0

4 years agoMerge "Changed to set source service as model info"
Steve Smokowski [Wed, 31 Jul 2019 19:40:09 +0000 (19:40 +0000)]
Merge "Changed to set source service as model info"

4 years agoChanged to set source service as model info 74/92374/1
Boslet, Cory [Wed, 31 Jul 2019 15:23:30 +0000 (11:23 -0400)]
Changed to set source service as model info

Changed to set source service as model info for service proxy per sniro.
Updated junit test to account for source service change.

Issue-ID: SO-2179
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I43161f0109b62a895d5122a7b0aca0eea8694b16

4 years agoadded back missing method in groovy file 70/92370/1
Benjamin, Max (mb388a) [Wed, 31 Jul 2019 15:03:06 +0000 (11:03 -0400)]
added back missing method in groovy file

Need to bring back AbstractTaskProcessor.logWorkflowException()
method because this is being called from a number of groovy files.

Issue-ID: SO-2172
Change-Id: Id5dee85fcb48265955dde3d74f7c0f98300410f0
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
4 years agoUpdatable to false to prevent setting fk to null 59/92359/1
Plummer, Brittany [Wed, 31 Jul 2019 13:30:43 +0000 (08:30 -0500)]
Updatable to false to prevent setting fk to null

Updatable to false to prevent setting foreign key to null before delete

Issue-ID: SO-2178
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I9b9f94c0d0b56a61cd8b9c56e80e5a3ec4819a50

4 years agoAdd oauth for calls from VNFM adapter to VNFM 84/92284/4
MichaelMorris [Wed, 31 Jul 2019 13:28:48 +0000 (13:28 +0000)]
Add oauth for calls from VNFM adapter to VNFM

Change-Id: I0e6ba16bbeab457ec0c1985e345e26f544434667
Issue-ID: SO-2169
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoMerge "fix install SO docs"
Seshu Kumar M [Wed, 31 Jul 2019 12:58:31 +0000 (12:58 +0000)]
Merge "fix install SO docs"

4 years agoMerge "Replaced constructor call with Boolean.valueOf() call to prevent static analyz...
Seshu Kumar M [Wed, 31 Jul 2019 12:57:32 +0000 (12:57 +0000)]
Merge "Replaced constructor call with Boolean.valueOf() call to prevent static analyzer warning about inefficient use of constructor"

4 years agoJavadoc and logging improvement 33/92333/2
Manamohan [Wed, 31 Jul 2019 09:55:44 +0000 (15:25 +0530)]
Javadoc and logging improvement

Added Javadocs for VnfAdapterCreateTasks and SDNCAssignTasks.

Change-Id: Ifb76e278eb90ba2d4644b649e91c1ffb15c55101
Issue-ID: SO-2052
Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
4 years agoReplaced constructor call with Boolean.valueOf() call 71/92271/1
Oleksandr Moliavko [Tue, 30 Jul 2019 13:18:31 +0000 (16:18 +0300)]
Replaced constructor call with Boolean.valueOf() call
to prevent static analyzer warning about inefficient
use of constructor

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Id5a883628726bdd0313a46ea4808a36eccf03c9a

4 years agofix install SO docs 70/92270/1
k.kazak [Tue, 30 Jul 2019 12:04:37 +0000 (14:04 +0200)]
fix install SO docs

Fix warning in Install Configure SO doc
Fix image urls in Install Configure SO doc

Change-Id: I95cdb6898893d3a3ae3cbac430f5359e01a7500a
Issue-ID: SO-2149
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoMerge "apih allowing requests with the same requestid"
Seshu Kumar M [Tue, 30 Jul 2019 10:42:41 +0000 (10:42 +0000)]
Merge "apih allowing requests with the same requestid"

4 years agoMerge "Sonar fix: CreateVfModuleRequest.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:05:10 +0000 (10:05 +0000)]
Merge "Sonar fix: CreateVfModuleRequest.java"

4 years agoMerge "Sonar fix: HealthStackAudit.java"
Seshu Kumar M [Tue, 30 Jul 2019 10:02:28 +0000 (10:02 +0000)]
Merge "Sonar fix: HealthStackAudit.java"

4 years agoMerge "fix architecture.rst formatting"
Seshu Kumar M [Tue, 30 Jul 2019 10:01:31 +0000 (10:01 +0000)]
Merge "fix architecture.rst formatting"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Tue, 30 Jul 2019 10:00:45 +0000 (10:00 +0000)]
Merge "Javadoc and logging improvement"

4 years agoMerge "fix malformed tables in docs"
Seshu Kumar M [Tue, 30 Jul 2019 09:59:26 +0000 (09:59 +0000)]
Merge "fix malformed tables in docs"

4 years agoMerge "Sonar Fix: VduArtifact.java"
Seshu Kumar M [Tue, 30 Jul 2019 09:58:14 +0000 (09:58 +0000)]
Merge "Sonar Fix: VduArtifact.java"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Tue, 30 Jul 2019 09:57:48 +0000 (09:57 +0000)]
Merge "Javadoc and logging improvement"

4 years agoUse generic req mapping for CM requests 08/92308/1
Elena Kuleshov [Tue, 30 Jul 2019 09:40:39 +0000 (05:40 -0400)]
Use generic req mapping for CM requests

Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests.

Issue-ID: SO-2168
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed

4 years agoMerge "Added null check to heatStack.getOutputs() to prevent crash at get() call...
Seshu Kumar M [Tue, 30 Jul 2019 13:32:59 +0000 (13:32 +0000)]
Merge "Added null check to heatStack.getOutputs() to prevent crash at get() call; removed redundant null check to simplify the code"

4 years agoAdded null check to heatStack.getOutputs() 64/92264/2
Oleksandr Moliavko [Tue, 30 Jul 2019 10:30:40 +0000 (13:30 +0300)]
Added null check to heatStack.getOutputs()
to prevent crash at get() call; removed redundant
null check to simplify the code

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If9d8dcba3008cd7ebe60c17c08c71a07a6df9df4

4 years agoMerge "Replaced constructor calls with valueOf() method calls to remove static analyz...
Seshu Kumar M [Tue, 30 Jul 2019 11:56:25 +0000 (11:56 +0000)]
Merge "Replaced constructor calls with valueOf() method calls to remove static analyzer warnings about inefficient constructor calls"

4 years agoMerge "Replaced constructor call with valueOf() call to remove static analyzer warnin...
Seshu Kumar M [Tue, 30 Jul 2019 11:55:49 +0000 (11:55 +0000)]
Merge "Replaced constructor call with valueOf() call to remove static analyzer warning about inefficient use of constructor"

4 years agoMerge "Removed subscriber variable that was not actually used in any test (to remove...
Seshu Kumar M [Tue, 30 Jul 2019 11:55:12 +0000 (11:55 +0000)]
Merge "Removed subscriber variable that was not actually used in any test (to remove static analyzer warning)"

4 years agoMerge "commented out bad tests, will revisit"
Seshu Kumar M [Tue, 30 Jul 2019 11:53:12 +0000 (11:53 +0000)]
Merge "commented out bad tests, will revisit"

4 years agocommented out bad tests, will revisit 71/90871/2
DeWayne Filppi [Wed, 3 Jul 2019 23:45:02 +0000 (16:45 -0700)]
commented out bad tests, will revisit

Change-Id: I57e0e1378e743074b3fad3533756179776bfaf0b
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Issue-ID: SO-1836

4 years agoReplaced constructor calls with valueOf() method calls 48/92248/1
Oleksandr Moliavko [Tue, 30 Jul 2019 07:51:07 +0000 (10:51 +0300)]
Replaced constructor calls with valueOf() method calls
to remove static analyzer warnings about inefficient
constructor calls

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If5b0c9c3569759f738e01c0352e267ee8a995c5f

4 years agoReplaced constructor call with valueOf() call to 41/92241/1
Oleksandr Moliavko [Tue, 30 Jul 2019 06:04:41 +0000 (09:04 +0300)]
Replaced constructor call with valueOf() call to
remove static analyzer warning about inefficient
use of constructor

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5b6285aa8708b57bb54a90d38130a21b07c2b2c5

4 years agoMerge "repair vfcInstanceGroup order"
Seshu Kumar M [Tue, 30 Jul 2019 05:46:43 +0000 (05:46 +0000)]
Merge "repair vfcInstanceGroup order"

4 years agoRemoved subscriber variable that was not actually 40/92240/1
Oleksandr Moliavko [Tue, 30 Jul 2019 05:36:52 +0000 (08:36 +0300)]
Removed subscriber variable that was not actually
used in any test (to remove static analyzer
warning)

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I7665c3dcb85d5c0d80c0448e6ad5ff1ece5a0bef

4 years agoapih allowing requests with the same requestid 29/92229/2
Plummer, Brittany [Mon, 29 Jul 2019 18:33:20 +0000 (14:33 -0400)]
apih allowing requests with the same requestid

Updated filters to throw error on duplicate requestId
Added message indicating exception will be thrown
Added unit tests for requestIdFilters
Added access modifier in filter test
Updated CloudApiRequests for successful deletion when
InfraActiveRequest is deleted
Removed changes from CloudApiRequests bean
Updated repository to include deleteByRequestId
Removed unused import from cloudApiRequests
Removed deleteByRequestId from interface
Updated to change type of extended jparepository
Removed repository added for CloudApiRequests
Updated uri check to remove '/' from checked string
Updated returned on failing junit test
Updated access modifiers for logger and createRequestError

Issue-ID: SO-2166
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Id0cee672567b15e0a3eb1acfbdfb967945494500

4 years agoMerge "Implement TLS for calls into VNFM adapter"
Steve Smokowski [Mon, 29 Jul 2019 14:11:55 +0000 (14:11 +0000)]
Merge "Implement TLS for calls into VNFM adapter"

4 years agoMerge "Vulnerability fixes in ServicePluginFactory"
Steve Smokowski [Mon, 29 Jul 2019 12:42:01 +0000 (12:42 +0000)]
Merge "Vulnerability fixes in ServicePluginFactory"

4 years agoMerge "Upgrade springboot.version from 2.0.5 to 2.1.5."
Steve Smokowski [Mon, 29 Jul 2019 12:39:09 +0000 (12:39 +0000)]
Merge "Upgrade springboot.version from 2.0.5 to 2.1.5."

4 years agoMerge "validate model info for existing service with"
Steve Smokowski [Mon, 29 Jul 2019 12:38:33 +0000 (12:38 +0000)]
Merge "validate model info for existing service with"

4 years agoMerge "Use BuildingBlockExecution for PauseForManualTasks"
Steve Smokowski [Mon, 29 Jul 2019 12:38:27 +0000 (12:38 +0000)]
Merge "Use BuildingBlockExecution for PauseForManualTasks"

4 years agoMerge "Add SpringClientFilter in ValetClient to autolog"
Steve Smokowski [Mon, 29 Jul 2019 12:38:12 +0000 (12:38 +0000)]
Merge "Add SpringClientFilter in ValetClient to autolog"

4 years agoMerge "set multi-stage flag in listener to log success"
Steve Smokowski [Mon, 29 Jul 2019 12:38:06 +0000 (12:38 +0000)]
Merge "set multi-stage flag in listener to log success"

4 years agoMerge "store heat env file sent to heat"
Steve Smokowski [Mon, 29 Jul 2019 12:37:40 +0000 (12:37 +0000)]
Merge "store heat env file sent to heat"

4 years agoVulnerability fixes in ServicePluginFactory 90/92190/1
r.bogacki [Mon, 29 Jul 2019 11:15:40 +0000 (13:15 +0200)]
Vulnerability fixes in ServicePluginFactory

Vulnerability fixes in ServicePluginFactory according to the Sonar.
-Made constants final.
-Changed access scopes from public to private.

Issue-ID: SDC-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2

4 years agoJavadoc and logging improvement 89/92189/1
SunilB [Mon, 29 Jul 2019 11:10:25 +0000 (16:40 +0530)]
Javadoc and logging improvement

Added Javadocs for SDNCQueryTasts and
SDNCVnfResources classes

Issue-ID: SO-2052
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: I79d7e6b8a82327caaa16c49a64df7b1a02dcbb03

4 years agorepair vfcInstanceGroup order 71/92171/1
zm330 [Mon, 29 Jul 2019 07:19:40 +0000 (15:19 +0800)]
repair vfcInstanceGroup order

Issue-ID: SO-2164
Change-Id: I827342692dc4e4241b22c6eb8dd455b2b9385fa8
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
4 years agoUpgrade springboot.version from 2.0.5 to 2.1.5. 17/92017/2
Sangalang, Felix [Thu, 25 Jul 2019 15:07:49 +0000 (10:07 -0500)]
Upgrade springboot.version from 2.0.5 to 2.1.5.

Upgrade springboot.version from 2.0.5 to 2.1.5.
Fixed APIHandler junit test cases with expected DB error messages.

Issue-ID: SO-2157
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0

4 years agovalidate model info for existing service with 32/92132/1
Mnushkin, Dmitry [Fri, 26 Jul 2019 17:17:12 +0000 (13:17 -0400)]
validate model info for existing service with

verify modelVersionId equals during SI AAI validation
correct SI name in junit test
update SI name in junit test comparison
add name/module id verifications for other objects
add back junit file after merge from remote
format jnit file after verify job failure
updated test input values for clarity
update name verifications with related ID values
adding junit for Configuration name verification
updated aai verify call, service dup error msg
removed aai depth 2 and refactored private test method
implement SI name verification with 3 additional fields
fix formatting comment line length limitation

Issue-ID: SO-2161
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I43f5cb0601dfa8b41f474615b639fce0572f5613

4 years agofix malformed tables in docs 25/92125/1
k.kazak [Fri, 26 Jul 2019 15:04:59 +0000 (17:04 +0200)]
fix malformed tables in docs

Fixed malformed tables in SO Interfaces documentation page

Change-Id: I77e4a272bbcc735da8c07dc45cf548787091e0a0
Issue-ID: SO-2152
Signed-off-by: k.kazak <k.kazak@samsung.com>
4 years agoMerge changes I3e363f64,I52ec2fc9
subhash kumar singh [Fri, 26 Jul 2019 12:13:00 +0000 (12:13 +0000)]
Merge changes I3e363f64,I52ec2fc9

* changes:
  include a bak folder for obsolete files
  updated the doc as per the request

4 years agoMerge "Fixed sonar issue in QueryServiceVnfs.java"
Seshu Kumar M [Fri, 26 Jul 2019 12:11:43 +0000 (12:11 +0000)]
Merge "Fixed sonar issue in QueryServiceVnfs.java"

4 years agoMerge "Fix the License issue inside the sample csar"
subhash kumar singh [Fri, 26 Jul 2019 12:10:24 +0000 (12:10 +0000)]
Merge "Fix the License issue inside the sample csar"

4 years agoMerge "Enhanced List Level flow with backward support"
Seshu Kumar M [Fri, 26 Jul 2019 12:10:09 +0000 (12:10 +0000)]
Merge "Enhanced List Level flow with backward support"

4 years agoMerge "Javadoc and logging improvement"
Seshu Kumar M [Fri, 26 Jul 2019 12:09:44 +0000 (12:09 +0000)]
Merge "Javadoc and logging improvement"

4 years agoMerge "fix image urls in docs"
Byung-Woo Jun [Fri, 26 Jul 2019 11:32:53 +0000 (11:32 +0000)]
Merge "fix image urls in docs"

4 years agoJavadoc and logging improvement 48/91948/2
Pooja03 [Fri, 26 Jul 2019 11:08:29 +0000 (16:38 +0530)]
Javadoc and logging improvement

Added Javadocs for four classes
AAIUpdateTasks,OrchestrationStatusValidator,AAICreateTasks ,BBInputSetup

Issue-ID: SO-2052
Signed-off-by: Pooja03 <pm00501616@techmahindra.com>
Change-Id: I048b42131449e151be91839e45f4d39864b3ec52

4 years agoEnhanced List Level flow with backward support 39/91839/5
sarada prasad sahoo [Mon, 22 Jul 2019 11:25:12 +0000 (16:55 +0530)]
Enhanced List Level flow with backward support

Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.

Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
4 years agoUse BuildingBlockExecution for PauseForManualTasks 11/92111/1
Elena Kuleshov [Fri, 26 Jul 2019 06:34:19 +0000 (02:34 -0400)]
Use BuildingBlockExecution for PauseForManualTasks

Fix variable settings and execution object usage for manual tasks.

Issue-ID: SO-2113
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I3fa24d70b46658ce5afcdc843d5482e157641112

4 years agoJavadoc and logging improvement 68/92068/2
SunilB [Fri, 26 Jul 2019 04:07:49 +0000 (09:37 +0530)]
Javadoc and logging improvement

Added Javadocs for VnfAdapterVfModuleResources and
VnfTopologyOperationRequestMapper classes

Issue-ID: SO-2052
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: Iec6addb415720f63c32b5ab99e63aefe0ef3235a