so.git
4 years agoFixing ASDCRestInterface for CSIT to simulate SDC req 85/91385/1
waqas.ikram [Fri, 12 Jul 2019 16:51:59 +0000 (17:51 +0100)]
Fixing ASDCRestInterface for CSIT to simulate SDC req

Change-Id: I6331d08441b9bf1f621f56ec1b7d911851010e62
Issue-ID: SO-1948
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
4 years agoMerge "Sonar Fix: SDNCAdapterApplication.java"
Steve Smokowski [Thu, 11 Jul 2019 12:48:58 +0000 (12:48 +0000)]
Merge "Sonar Fix: SDNCAdapterApplication.java"

4 years agoMerge "Major Sonar fixes in E2EServiceInstances"
Lukasz Muszkieta [Wed, 10 Jul 2019 07:20:01 +0000 (07:20 +0000)]
Merge "Major Sonar fixes in E2EServiceInstances"

4 years agoSonar Fix: SDNCAdapterApplication.java 26/91126/1
Arundathi Patil [Wed, 10 Jul 2019 03:53:11 +0000 (09:23 +0530)]
Sonar Fix: SDNCAdapterApplication.java

Removed unused imports from the file

Issue-ID: SO-2103
Change-Id: Id126f5203789d866b340d86b55bbc616991afc99
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "Sonar fix in CreateInventoryTask.java"
Marcus Williams [Tue, 9 Jul 2019 19:36:38 +0000 (19:36 +0000)]
Merge "Sonar fix in CreateInventoryTask.java"

4 years agoMerge "Sonar fixes in ManualTasks"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:24:19 +0000 (17:24 +0000)]
Merge "Sonar fixes in ManualTasks"

4 years agoMerge "Sonar fixes in OrchestrationRequests"
Lukasz Muszkieta [Tue, 9 Jul 2019 17:22:41 +0000 (17:22 +0000)]
Merge "Sonar fixes in OrchestrationRequests"

4 years agoMajor Sonar fixes 87/91087/1
r.bogacki [Tue, 9 Jul 2019 12:10:53 +0000 (14:10 +0200)]
Major Sonar fixes

Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.

Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59

4 years agoSonar fixes in OrchestrationRequests 83/91083/1
r.bogacki [Tue, 9 Jul 2019 11:45:37 +0000 (13:45 +0200)]
Sonar fixes in OrchestrationRequests

Sonar fixes in OrchestrationRequests according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused variables.

Issue-ID: SO-2101
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5

4 years agoSonar fixes in ManualTasks 82/91082/1
r.bogacki [Tue, 9 Jul 2019 11:31:36 +0000 (13:31 +0200)]
Sonar fixes in ManualTasks

Code fixes in ManualTasks according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused imports.
-Removed unused variables.

Issue-ID: SO-2100
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0

4 years agoMajor Sonar fixes in E2EServiceInstances 80/91080/1
r.bogacki [Tue, 9 Jul 2019 11:05:34 +0000 (13:05 +0200)]
Major Sonar fixes in E2EServiceInstances

Major code fixes in E2EServiceInstances according to the Sonar analysis.
-Removed unnecessary code.
-Removed unnecessary method parameters.
-Removed unused variables.

Issue-ID: SO-2099
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d

4 years agoSonar fix in CreateInventoryTask.java 58/91058/1
Arundathi Patil [Tue, 9 Jul 2019 03:05:24 +0000 (08:35 +0530)]
Sonar fix in CreateInventoryTask.java

Fixed multiple sonar issues in this file

Issue-ID: SO-2098
Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agoMerge "remove unneeded code"
Steve Smokowski [Mon, 8 Jul 2019 15:27:43 +0000 (15:27 +0000)]
Merge "remove unneeded code"

4 years agoMerge "Added null check to prevent call of getVnfResources() method for null vf object"
Steve Smokowski [Mon, 8 Jul 2019 15:26:41 +0000 (15:26 +0000)]
Merge "Added null check to prevent call of getVnfResources() method for null vf object"

4 years agoMerge "Added null check for heatStack to prevent crash at getCanonicalName() call"
Steve Smokowski [Mon, 8 Jul 2019 14:19:14 +0000 (14:19 +0000)]
Merge "Added null check for heatStack to prevent crash at getCanonicalName() call"

4 years agoMerge "add junit coverage for VnfmHelper"
Steve Smokowski [Mon, 8 Jul 2019 14:18:29 +0000 (14:18 +0000)]
Merge "add junit coverage for VnfmHelper"

4 years agoMerge "Fixed sonar issue in QueryGroups.java"
Seshu Kumar M [Mon, 8 Jul 2019 13:03:04 +0000 (13:03 +0000)]
Merge "Fixed sonar issue in QueryGroups.java"

4 years agoFixed sonar issue in QueryGroups.java 75/90975/1
Arundathi Patil [Fri, 5 Jul 2019 17:13:42 +0000 (22:43 +0530)]
Fixed sonar issue in QueryGroups.java

Fixed sonar issues across this file

Issue-ID: SO-2096
Change-Id: Ib2b9fb5d12da2eb1f99562466c5a5d9039b0e50f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
4 years agomso will support new requeststate values 56/90956/1
Gamboa, Gilbert [Fri, 5 Jul 2019 14:30:58 +0000 (10:30 -0400)]
mso will support new requeststate values

Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED.
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED,
ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request
status in case rollback is not needed.
Variable rollbackTargetState needs to be returned to WorkflowAction flow
Variable rollbackTargetState needs to in to ExecuteBuildingBlock as
well. Add new RequestDb migration file to expand infra_active_requests
column request_status to 25 bytes to fit new request states.

Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197
Issue-ID: SO-2093
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoupdate bpmn to save extsystemerrorsource 55/90955/1
Plummer, Brittany [Fri, 5 Jul 2019 14:23:16 +0000 (10:23 -0400)]
update bpmn to save extsystemerrorsource

Added ext error source to workflow exception
Updated all lines that create this exception with source
Added unit tests and updated existing ones

Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb
Issue-ID: SO-2092
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoadd junit coverage for VnfmHelper 37/90937/1
Lukasz Muszkieta [Fri, 5 Jul 2019 10:20:32 +0000 (12:20 +0200)]
add junit coverage for VnfmHelper

Change-Id: I0db84333f1c5ffa09ec78f504a101b75343157a3
Issue-ID: SO-1576
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agofix global-jjb migration issue 05/90905/1
sarada prasad sahoo [Thu, 4 Jul 2019 12:57:00 +0000 (18:27 +0530)]
fix global-jjb migration issue

fix global-jjb migration issue
- VNFSDK, SO

Issue-ID: SO-1992
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I2e11f0c151c54151e526efdebf92f49621dc0f7f

4 years agoremove unneeded code 90/90890/1
Lukasz Muszkieta [Thu, 4 Jul 2019 10:59:01 +0000 (12:59 +0200)]
remove unneeded code

Change-Id: Ib7c692b2a7fd8bc5f40d6a4acba504948cc7fc1b
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agofix global-jjb migration issue 87/90887/1
sarada prasad sahoo [Thu, 4 Jul 2019 09:25:01 +0000 (14:55 +0530)]
fix global-jjb migration issue

fix global-jjb migration issue
- VNFSDK, SO

Issue-ID: SO-1992
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: Idaee5994614a9264e0b0edc57be6e529a343b807

4 years agoAdded null check to prevent call of getVnfResources() method 74/90774/1
Oleksandr Moliavko [Tue, 2 Jul 2019 11:30:18 +0000 (14:30 +0300)]
Added null check to prevent call of getVnfResources() method
for null vf object

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0c2ea5de5ed9ab55ad78f58f3a68241e7cb2d064

4 years agoAdded null check for heatStack to prevent crash at 62/90762/1
Oleksandr Moliavko [Tue, 2 Jul 2019 06:59:15 +0000 (09:59 +0300)]
Added null check for heatStack to prevent crash at
getCanonicalName() call

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Icf49b7db336002ad56769b221ec61101fac04fd5

4 years agoMerge "do not overwrite status message with rollback"
Steve Smokowski [Mon, 1 Jul 2019 17:41:52 +0000 (17:41 +0000)]
Merge "do not overwrite status message with rollback"

4 years agodo not overwrite status message with rollback 23/90723/1
Mnushkin, Dmitry [Mon, 1 Jul 2019 12:10:54 +0000 (08:10 -0400)]
do not overwrite status message with rollback

update rollback error for rollback and not original msg
run code formatting on updated files
add unit test for false value of isRollback flag

Change-Id: I25d8fb9771766461b1192e3758237dfc199787f8
Issue-ID: SO-2081
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agosupport new query param format 22/90722/1
Chan, Mercy [Mon, 1 Jul 2019 12:07:17 +0000 (08:07 -0400)]
support new query param format

- added format query parameter (optional), implemented logic to
populate requestStatus field based on whether or not format is present
moved request status constants to its own class visible globally.
- changed @requestParam to @QueryParam in GET endpoint
(OrchestrationRequests class. updated unit tests to call method being
tested directly rather than from another private function
- moved setting requestStatus to a separate method, also updated unit
tests to separate out each scenarion into its own method
- added unit test for when format=detail, corrected existing unit tests
to test result to be FAILED
- updated Status.java to include extra request status values; moved
Status class to common org.onap.so.constants package

Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260
Issue-ID: SO-2080
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoAdded check for null response to prevent crash at 08/90708/3
Oleksandr Moliavko [Mon, 1 Jul 2019 09:11:50 +0000 (12:11 +0300)]
Added check for null response to prevent crash at
response.getEntity() method call.

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Id796f4426f33cf419bbe5ed07500452ac0c7c775

4 years agoenhance workflowaction to handle resume func 33/90533/6
Mnushkin, Dmitry [Wed, 26 Jun 2019 15:14:28 +0000 (11:14 -0400)]
enhance workflowaction to handle resume func

init code for RESUME with junit passing
overwrite URI on resume op from original request

Change-Id: I1eee2bd66aa20804ba4a2834d269b5947565b9dc
Issue-ID: SO-2055
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "improved logging when no exception data is found"
Steve Smokowski [Thu, 27 Jun 2019 18:23:48 +0000 (18:23 +0000)]
Merge "improved logging when no exception data is found"

4 years agoMerge "Update failsafe dependency to 2.0.1"
Steve Smokowski [Thu, 27 Jun 2019 18:23:42 +0000 (18:23 +0000)]
Merge "Update failsafe dependency to 2.0.1"

4 years agoMerge "handle multiple cvnfc configs"
Steve Smokowski [Thu, 27 Jun 2019 18:23:37 +0000 (18:23 +0000)]
Merge "handle multiple cvnfc configs"

4 years agoMerge "add rollback ext system error source"
Steve Smokowski [Thu, 27 Jun 2019 18:23:31 +0000 (18:23 +0000)]
Merge "add rollback ext system error source"

4 years agoimproved logging when no exception data is found 38/90538/2
Benjamin, Max [Wed, 26 Jun 2019 15:35:00 +0000 (11:35 -0400)]
improved logging when no exception data is found

improved logging when no exception data is found

Change-Id: I4f6298652ad474119cd1ebc58a927d532ea3e6be
Issue-ID: SO-2068
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoUpdate failsafe dependency to 2.0.1 36/90536/2
Benjamin, Max [Wed, 26 Jun 2019 15:26:55 +0000 (11:26 -0400)]
Update failsafe dependency to 2.0.1

Updated calls to failsafe 2.0.1 API

Change-Id: I2c86ca02d56a07262e330ee5f8f088d1a1f5b4a7
Issue-ID: SO-2057
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agohandle multiple cvnfc configs 35/90535/2
Merkel, Jeff [Wed, 26 Jun 2019 15:23:02 +0000 (11:23 -0400)]
handle multiple cvnfc configs

- Handle multiple cvnfc configs with the same model uuid.
- Update CvnfcConfigurationCustomization to a List from a Set

Change-Id: I8c026510d813ebb6294a9cedd39d4d4b8f4b9dcf
Issue-ID: SO-2056
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoadd rollback ext system error source 28/90528/2
Plummer, Brittany [Wed, 26 Jun 2019 14:58:22 +0000 (10:58 -0400)]
add rollback ext system error source

Added rollbackExtSystemErrorSource column and updated GET
orchestrationRequests response
Added missing columns from requestDb to schema.sql

Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a
Issue-ID: SO-2054
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoFix macro delete instance bug. 27/90527/2
Gamboa, Gilbert [Wed, 26 Jun 2019 14:53:51 +0000 (10:53 -0400)]
Fix macro delete instance bug.

Fix macro delete instance bug. vf-modules not being sorted correctly
because isbaseboolean field is not being set.

Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47
Issue-ID: SO-2053
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoChanged dependency back to 1.3.0 92/90592/1
Benjamin, Max (mb388a) [Thu, 27 Jun 2019 12:59:30 +0000 (08:59 -0400)]
Changed dependency back to 1.3.0

sdc-distribution-client changed back to 1.3.0

Change-Id: I53fd206c16bdb9c22976b6b671784841923b5295
Issue-ID: SO-2078
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"
Steve Smokowski [Wed, 26 Jun 2019 12:59:48 +0000 (12:59 +0000)]
Merge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"

4 years agoMerge "Security updates for maven dependencies"
Steve Smokowski [Wed, 26 Jun 2019 12:59:43 +0000 (12:59 +0000)]
Merge "Security updates for maven dependencies"

4 years agoMerge "Updated path to match AID for resume requests"
Steve Smokowski [Wed, 26 Jun 2019 12:59:36 +0000 (12:59 +0000)]
Merge "Updated path to match AID for resume requests"

4 years agoMerge "Moved code inside IF checking for null ptr to prevent crash"
Steve Smokowski [Wed, 26 Jun 2019 12:59:31 +0000 (12:59 +0000)]
Merge "Moved code inside IF checking for null ptr to prevent crash"

4 years agoMerge "Sonar fixes in MsoVnfAdapterAsyncImpl"
Steve Smokowski [Wed, 26 Jun 2019 12:59:24 +0000 (12:59 +0000)]
Merge "Sonar fixes in MsoVnfAdapterAsyncImpl"

4 years agoMerge "Sonar fixes and improvements"
Steve Smokowski [Wed, 26 Jun 2019 12:59:18 +0000 (12:59 +0000)]
Merge "Sonar fixes and improvements"

4 years agoMerge remote-tracking branch 'origin/dublin' into 'origin/master' 81/90481/1
Benjamin, Max (mb388a) [Tue, 25 Jun 2019 19:52:39 +0000 (15:52 -0400)]
Merge remote-tracking branch 'origin/dublin' into 'origin/master'

Change-Id: I2b91332563d9c7b0f469c9e45a35cc1376465c5e
Issue-ID: SO-2058
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMoved code inside IF checking for null ptr to prevent crash 56/90456/1
Oleksandr Moliavko [Tue, 25 Jun 2019 14:02:53 +0000 (17:02 +0300)]
Moved code inside IF checking for null ptr to prevent crash

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ie759b98828f39fba00ccdb7edcd7fc28e83ea50e

4 years agoProcess workflow artifacts last 06/90406/1
Elena Kuleshov [Mon, 24 Jun 2019 18:05:26 +0000 (14:05 -0400)]
Process workflow artifacts last

Workflow artifacts need to be processed last, check for existence of VNF resource

Issue-ID: SO-2045
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: Ia46a6ecaef905287ce837c04b389ab2a13d3f24e

4 years agoSonar fixes in MsoVnfAdapterAsyncImpl 81/90381/1
r.bogacki [Mon, 24 Jun 2019 13:12:56 +0000 (15:12 +0200)]
Sonar fixes in MsoVnfAdapterAsyncImpl

General fixes and improvements according to the Sonar analysis.
-Removed unnecessary code.

Issue-ID: SO-1220
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0f9ab1fe490975e4eefa31afd5bf09616f4de3f2

4 years agoSonar fixes and improvements 78/90378/1
r.bogacki [Mon, 24 Jun 2019 12:56:31 +0000 (14:56 +0200)]
Sonar fixes and improvements

General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary code.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596

4 years agoadd junit coverage for InstantiateOperationProgressor 46/90146/4
Lukasz Muszkieta [Wed, 19 Jun 2019 09:49:09 +0000 (11:49 +0200)]
add junit coverage for InstantiateOperationProgressor

Change-Id: I90c6ee50276073c4c974fa1b1e1079762706853a
Issue-ID: SO-1576
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoUpdated path to match AID for resume requests 12/90312/2
Plummer, Brittany [Fri, 21 Jun 2019 14:44:38 +0000 (10:44 -0400)]
Updated path to match AID for resume requests

Updated path to match AID for resume requests

Change-Id: I0035360f206882e602265500dcd54036b3e69ea2
Issue-ID: SO-2042
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoSecurity updates for maven dependencies 13/90313/1
Sangalang, Felix [Fri, 21 Jun 2019 14:46:38 +0000 (10:46 -0400)]
Security updates for maven dependencies

Update commons-collections version to 3.2.2.
Updated distribution client version to 1.4.0.
Update commons-fileupload to version 1.4.
Update commons-codec to version 1.12.

Change-Id: I4ab794e3aef7300c30088e5197092fd30231c4af
Issue-ID: SO-2043
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoupdate the SO release notes 49/90149/4
seshukm [Wed, 19 Jun 2019 10:28:56 +0000 (15:58 +0530)]
update the SO release notes

Issue-ID: SO-2010

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I7fc46c2dbdfc5ee7e79aca86f8148b9f43743d5c

4 years agofix jenkins build 89/90289/2
Lukasz Muszkieta [Fri, 21 Jun 2019 10:00:24 +0000 (12:00 +0200)]
fix jenkins build

format AbstractRestHandler.java file

Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3
Issue-ID: SO-2044
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
4 years agoMerge "Sonar fix too many method param"
Steve Smokowski [Thu, 20 Jun 2019 12:10:31 +0000 (12:10 +0000)]
Merge "Sonar fix too many method param"

4 years agoMerge "nullpointer in vnfadaptervfmoduleobjectmapper"
Steve Smokowski [Thu, 20 Jun 2019 12:09:59 +0000 (12:09 +0000)]
Merge "nullpointer in vnfadaptervfmoduleobjectmapper"

4 years agoMerge "support no payload for alacarte deletes"
Steve Smokowski [Thu, 20 Jun 2019 12:09:53 +0000 (12:09 +0000)]
Merge "support no payload for alacarte deletes"

4 years agoMerge "pass request-id to adapter call to match search"
Steve Smokowski [Thu, 20 Jun 2019 12:09:43 +0000 (12:09 +0000)]
Merge "pass request-id to adapter call to match search"

4 years agoMerge "NPE when setting instanceName"
Steve Smokowski [Thu, 20 Jun 2019 12:09:30 +0000 (12:09 +0000)]
Merge "NPE when setting instanceName"

4 years agoMerge "Use Regex to find the name on failure scenario"
Steve Smokowski [Thu, 20 Jun 2019 12:09:25 +0000 (12:09 +0000)]
Merge "Use Regex to find the name on failure scenario"

4 years agoMerge "update apih to accept new uri parameter"
Steve Smokowski [Thu, 20 Jun 2019 12:09:07 +0000 (12:09 +0000)]
Merge "update apih to accept new uri parameter"

4 years agochanged hikari dependency to java based one 77/90177/1
Benjamin, Max (mb388a) [Wed, 19 Jun 2019 18:16:52 +0000 (14:16 -0400)]
changed hikari dependency to java based one

clojure dependency used by accident, replaced with HikariCP

Change-Id: I25b9f75d8be061fb3ac3d7737e9a58883a801425
Issue-ID: SO-2038
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoupdate SO release notes path for dublin 39/90139/1
sarada prasad sahoo [Wed, 19 Jun 2019 06:46:46 +0000 (12:16 +0530)]
update SO release notes path for dublin

update SO release notes path for dublin

Change-Id: I2637374b813264a125049b0ab224bb5c84ebda8e
Issue-ID: SO-1992
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
4 years agoMerge "update the relaese notes"
Seshu Kumar M [Wed, 19 Jun 2019 05:01:04 +0000 (05:01 +0000)]
Merge "update the relaese notes"

4 years agoUse Regex to find the name on failure scenario 30/90130/1
Smokowski, Steven [Tue, 18 Jun 2019 21:46:20 +0000 (17:46 -0400)]
Use Regex to find the name on failure scenario

Use Regex to find the keypair name on failure scenario

Change-Id: Ibf2167283d90407def7750fab4538f5443e57092
Issue-ID: SO-2037
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoupdate apih to accept new uri parameter 28/90128/1
Chan, Mercy [Tue, 18 Jun 2019 21:44:22 +0000 (17:44 -0400)]
update apih to accept new uri parameter

added extSystemErrorSource queryparam flag to getOrchestrationRequest
endpoint.
added junit tests for the protected method that maps
external system error source to request object being returned.
added junit tests to test mapExtSystemErrorSourceToRequest method with
extSystemErrorSource flag

Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f
Issue-ID: SO-2035
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoNPE when setting instanceName 27/90127/1
Plummer, Brittany [Tue, 18 Jun 2019 21:43:21 +0000 (17:43 -0400)]
NPE when setting instanceName

Added null check to fix NPE when setting instanceName
Added check for null instanceName for vfModule

Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b
Issue-ID: SO-2034
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agopass request-id to adapter call to match search 26/90126/1
Mnushkin, Dmitry [Tue, 18 Jun 2019 21:42:25 +0000 (17:42 -0400)]
pass request-id to adapter call to match search

pass mso-request-id to adapter call to match search

Change-Id: Ie9e4f8559fd9153d503ad5913838d7c5d175e7bd
Issue-ID: SO-2033
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agosupport no payload for alacarte deletes 21/90121/2
Smokowski, Steven [Tue, 18 Jun 2019 21:04:18 +0000 (17:04 -0400)]
support no payload for alacarte deletes

Swap to using HTTP Enumerations rather than ints
Add Unit Tests to Service Instances endpoint
Add Vnf Tests remove Abstract class
Clean up usage of abstract classes
Fix volume and module bean wiring issues
Add logic to find create request if cloud not in AAI
Updated network to take in version pathparam
Additonal refactor of the endpoints
Add missing license headers to all files
Clean up public variable usage, move to protected

Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d
Issue-ID: SO-2032
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agonullpointer in vnfadaptervfmoduleobjectmapper 10/90110/1
Bhatt, Prema [Tue, 18 Jun 2019 19:13:35 +0000 (15:13 -0400)]
nullpointer in vnfadaptervfmoduleobjectmapper

Added code block to throw exception when we get a 'Name' wthout a
'Value' tag in the SDNC vf-module-topology. Right now we are seeing
oam0_net_id is missing a value tag. Added Unit test to test this code
change.

Change-Id: I765d5a4eb9d351b7613d4c3561a2a5dbe37e4781
Issue-ID: SO-2031
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoVNFM adapter handle getOperation after VNF delete 05/90105/1
MichaelMorris [Tue, 18 Jun 2019 17:58:42 +0000 (17:58 +0000)]
VNFM adapter handle getOperation after VNF delete

Change-Id: Iaa8d792f5660b1caf16d081779c14799d827a544
Issue-ID: SO-2030
Signed-off-by: MichaelMorris <michael.morris@est.tech>
4 years agoMerge "Changes related to eviction of connections"
Steve Smokowski [Tue, 18 Jun 2019 15:26:10 +0000 (15:26 +0000)]
Merge "Changes related to eviction of connections"

4 years agoMerge "Added Retry in rainy day macro for ConfigDelpoyVnfBB for vDNS CDS use case"
Steve Smokowski [Tue, 18 Jun 2019 15:11:36 +0000 (15:11 +0000)]
Merge "Added Retry in rainy day macro for ConfigDelpoyVnfBB for vDNS CDS use case"

4 years agoFixing NullPointerException thrown by EtsiVnfDeleteBB 87/90087/1
waqas.ikram [Tue, 18 Jun 2019 13:25:25 +0000 (13:25 +0000)]
Fixing NullPointerException thrown by EtsiVnfDeleteBB

Change-Id: I219989c25f05c94d01c7c697425da93997114216
Issue-ID: SO-2029
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
4 years agoMerge "Fix sonar issue in asdc-controller"
Steve Smokowski [Tue, 18 Jun 2019 12:16:04 +0000 (12:16 +0000)]
Merge "Fix sonar issue in asdc-controller"

4 years agoupdate the relaese notes 79/90079/1
seshukm [Tue, 18 Jun 2019 11:59:23 +0000 (17:29 +0530)]
update the relaese notes

Issue-ID: SO-1992

Change-Id: I07169b2083661601308edf79dae205685bd45266
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
4 years agoFix sonar issue in asdc-controller 14/89214/2
Parshad Patel [Tue, 4 Jun 2019 07:59:41 +0000 (16:59 +0900)]
Fix sonar issue in asdc-controller

Fix Either log or rethrow this exception

Issue-ID: SO-1841
Change-Id: I2a333d94b040b7bf4ac646fc6f729874eb0fe054
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
4 years agoFixed critical Sonar bugs 94/89994/4
r.bogacki [Mon, 17 Jun 2019 09:51:42 +0000 (11:51 +0200)]
Fixed critical Sonar bugs

Fixed critical bugs according to the Sonar analysis.
-Fixed possible NPE.
-Fixed wrong comparison.
-Removed unused variables.

Issue-ID: SO-2025
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689

4 years agoAdded Retry in rainy day macro for ConfigDelpoyVnfBB for vDNS CDS use case 01/90001/3
Abdelmuhaimen Seaudi [Mon, 17 Jun 2019 10:42:05 +0000 (10:42 +0000)]
Added Retry in rainy day macro for ConfigDelpoyVnfBB for vDNS CDS use case

Issue-ID: SO-2026

Signed-off-by: Abdelmuhaimen Seaudi <abdelmuhaimen.seaudi@orange.com>
Change-Id: I43689eb6a63843be3a181080173265ed1eda6e9a

4 years agoChanges related to eviction of connections 21/90021/1
Benjamin, Max (mb388a) [Mon, 17 Jun 2019 14:51:08 +0000 (10:51 -0400)]
Changes related to eviction of connections

These are changes related to ASDC controller for evicting database
connection pool when ip address changes
Included other appllications such as requestDB, CatalogDB, API Handler,
BPMN, OpenstackAdapter etc

Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe
Issue-ID: SO-2018
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "Fix sonar issues in mso-openstack-adapters"
Steve Smokowski [Mon, 17 Jun 2019 12:53:57 +0000 (12:53 +0000)]
Merge "Fix sonar issues in mso-openstack-adapters"

4 years agoMerge "Sonar fixes and improvements"
Steve Smokowski [Mon, 17 Jun 2019 12:53:39 +0000 (12:53 +0000)]
Merge "Sonar fixes and improvements"

4 years agoMerge "Validate ServiceInstance name using createNodesUri"
Steve Smokowski [Mon, 17 Jun 2019 12:52:12 +0000 (12:52 +0000)]
Merge "Validate ServiceInstance name using createNodesUri"

4 years agoSonar fixes and improvements 66/89666/4
r.bogacki [Tue, 11 Jun 2019 06:48:21 +0000 (08:48 +0200)]
Sonar fixes and improvements

General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Improvements in diamond operators.
-Removed unnecessary code.

Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9345b6ab0f4027b17e1bebf0b6657394c13dc298

4 years agoImprovements in MsoVnfAdapterImpl 36/89736/2
r.bogacki [Wed, 12 Jun 2019 08:46:14 +0000 (10:46 +0200)]
Improvements in MsoVnfAdapterImpl

Improvements in MsoVnfAdapterImpl according to the Sonar analyses.
-Removed unnecessary code.
-Fixed imports.
-Extracted constants.

Issue-ID: SO-2011
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c

4 years agoValidate ServiceInstance name using createNodesUri 54/89954/1
Sangalang, Felix [Sun, 16 Jun 2019 16:00:36 +0000 (12:00 -0400)]
Validate ServiceInstance name using createNodesUri

Validate ServiceInstance name using createNodesUri.

Change-Id: I5194dd933dc98064888250bc9a38e6ee9716fc01
Issue-ID: SO-2024
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoMerge "Validate names before writing to A&AI"
Max Benjamin [Sat, 15 Jun 2019 14:08:46 +0000 (14:08 +0000)]
Merge "Validate names before writing to A&AI"

4 years agoMerge "update multi stage code to accurately skip bbs"
Max Benjamin [Sat, 15 Jun 2019 14:08:41 +0000 (14:08 +0000)]
Merge "update multi stage code to accurately skip bbs"

4 years agoMerge "dmaap client using wrong auth property"
Max Benjamin [Sat, 15 Jun 2019 14:08:37 +0000 (14:08 +0000)]
Merge "dmaap client using wrong auth property"

4 years agoMerge "support async operation for vf module operations"
Steve Smokowski [Fri, 14 Jun 2019 20:09:16 +0000 (20:09 +0000)]
Merge "support async operation for vf module operations"

4 years agoMerge "add is_data_internal column to request db"
Max Benjamin [Fri, 14 Jun 2019 19:55:16 +0000 (19:55 +0000)]
Merge "add is_data_internal column to request db"

4 years agoMerge "use count format and limit one for exists"
Max Benjamin [Fri, 14 Jun 2019 19:55:06 +0000 (19:55 +0000)]
Merge "use count format and limit one for exists"

4 years agoMerge "adapter client will not retry on openstack failure"
Max Benjamin [Fri, 14 Jun 2019 19:55:02 +0000 (19:55 +0000)]
Merge "adapter client will not retry on openstack failure"

4 years agoadd is_data_internal column to request db 22/89922/1
Mnushkin, Dmitry [Fri, 14 Jun 2019 18:46:49 +0000 (14:46 -0400)]
add is_data_internal column to request db

add is_data_internal column to request processing data
Use Boolean type in java bean to be mapped by hibernate

Change-Id: I40a96f80114e02a2ced17efb47e45718dfd2ee7c
Issue-ID: SO-2023
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agoValidate names before writing to A&AI 20/89920/1
Sangalang, Felix [Fri, 14 Jun 2019 18:45:16 +0000 (14:45 -0400)]
Validate names before writing to A&AI

Validate name for InstanceGroup, Configuration and Network.

Change-Id: I494749e17a40c6c0cdd51dd28d9c9bca371410ac
Issue-ID: SO-2022
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agomso to validate the name uniqueness in A&AI 19/89919/1
Gamboa, Gilbert [Fri, 14 Jun 2019 18:15:54 +0000 (14:15 -0400)]
mso to validate the name uniqueness in A&AI

Need to change query by name using nodes query to make sure names are
globally unique.
Added new Exception type for duplicate A&AI object names.
Added tests for AAIVfModulResources.

Change-Id: I71558d0881d7060819f5f807fe58779be6edfa6f
Issue-ID: SO-2020
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
4 years agofix delete stack error not propogating 91/89891/2
Smokowski, Steven [Fri, 14 Jun 2019 13:12:10 +0000 (09:12 -0400)]
fix delete stack error not propogating

Update logic to properly format rollback error messages

Change-Id: I66ad4fd78758661be297810f393e6da759daa17b
Issue-ID: SO-2014
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>