jhh [Mon, 15 Apr 2019 23:15:30 +0000 (18:15 -0500)]
One year cert with new component names
Change-Id: Ia3025f2a0eada4f53623bb45d5849ceddf368925
Issue-ID: POLICY-1580
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
liamfallon [Mon, 15 Apr 2019 15:31:55 +0000 (15:31 +0000)]
Fix security problem with Zookeeper
Issue-ID: POLICY-1540
Change-Id: I5c549a1dffb21b54c81a44ba69ca49cb24732558
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Thu, 11 Apr 2019 16:56:29 +0000 (16:56 +0000)]
Changes for packaging services-onappf and some refactoring
1) Added the code for packaging PDP-A.
2) Updating the package names.
3) Updating the dependencies in services-onappf. Some dependencies can
be removed as they are brought in while packaging.
4) Some other minor changes.
Change-Id: Idf62d7854f3435806a9e8aa975138fbfd45e3ea8
Issue-ID: POLICY-1632
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
liamfallon [Wed, 10 Apr 2019 16:18:43 +0000 (16:18 +0000)]
Remove hibernate from apex
Issue-ID: POLICY-1368
Change-Id: I67f448fc9d89eef4829cd6f999f5c21ac8ebff12
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Wed, 10 Apr 2019 14:46:18 +0000 (14:46 +0000)]
Merge "Some changes and bug fixes for PdpMessage handling"
liamfallon [Wed, 10 Apr 2019 12:52:37 +0000 (12:52 +0000)]
Fix Kafka partiion support in APEX
The kafka producer property ‘partitioner.class’ should be configurable via
the EngineConfig.json file so that a specialized or custom Kafka partitioner
can be used.
Issue-ID: POLICY-1627
Change-Id: Ic36ccdf3d244ab932b58c3e2ae1cd668249726c5
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Tue, 9 Apr 2019 20:48:32 +0000 (20:48 +0000)]
Some changes and bug fixes for PdpMessage handling
1) Updating pom file of services-onappf to fix dependency related
issues.
2) Some changes to accomodate recent updates.
3) Fix for some issues identified during testing.
Change-Id: I8150ed9858902ebbe12321a793770df3fdc7e773
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
a.sreekumar [Mon, 8 Apr 2019 12:38:21 +0000 (12:38 +0000)]
Changes to handle PdpUpdate and PdpStateChange messages
1) Adding listeners and handlers for PdpUpdate messages.
2) Adding listeners and handlers for PdpStateChange messages.
3) Some changes to accomodate recent changes in the models.
4) Test cases.
Change-Id: I66644d94fd2a242738d9b0f78e5d0ece76342057
Issue-ID: POLICY-1453
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
a.sreekumar [Tue, 2 Apr 2019 09:09:51 +0000 (09:09 +0000)]
Changes to send pdp status messages
1) Adding handlers to create and send pdp status messages from apex-pdp.
2) Changes to read initial pdp status parameters from configuration
file.
3) Adding test cases.
Change-Id: Id2d1caa8abc124865a9ef8fbfe4d9f751e4491b5
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
Liam Fallon [Mon, 1 Apr 2019 00:35:11 +0000 (00:35 +0000)]
Merge "Change vCPE example to use POJOs"
liamfallon [Mon, 8 Oct 2018 12:36:31 +0000 (13:36 +0100)]
Change vCPE example to use POJOs
This review uses POJOs rather than Avro schema to unmarshal
and marshal events from and to DMaaP.
The POJO classes for interacting with DMaaP have been moved into
a common policy module.
This review is now ready for full review (finally!).
Issue-ID: POLICY-954
Change-Id: Ibb89d8af5b9006821e6a0a756e16bbe3815af15a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Signed-off-by: liamfallon <liam.fallon@est.tech>
Signed-off-by: Liam Fallon <liam.fallon@est.tech>
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Tue, 26 Mar 2019 13:54:45 +0000 (13:54 +0000)]
Adding services-onappf module to apex-pdp
1) Adding services-onappf module to apex-pdp.
2) Following the code base from policy/pap to build the module.
3) Currently PAP is using property & configuration file for bootstrap.
Continuing the same in this module as well.
4) Adding relevant test cases.
Change-Id: Id9740ea60ae3ecbd88e5d6d3586ee0dde1054cca
Issue-ID: POLICY-1452
Signed-off-by: a.sreekumar <ajith.sreekumar@est.tech>
liamfallon [Tue, 19 Mar 2019 12:52:20 +0000 (12:52 +0000)]
Fix checkstyle/Sonar issues on juint/sonar fixes
Recent changes to increase code coverage and fox Sonar bugs have
introduced checkstyle and further Sonar issues. This review
cleans those up.
Issue-ID: POLICY-1523
Change-Id: I829217ef77d52e57f9713cfeee5b122e1f25efbc
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 19 Mar 2019 01:16:38 +0000 (01:16 +0000)]
Use Assertions class from policy-common
Change import line in all classes that use
the Assertions class, there are a lot of them.
Issue-ID: POLICY-1264
Change-Id: I8480264be4e36348b3fc63acf1bc36e9c9dd250b
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Sun, 17 Mar 2019 05:43:21 +0000 (00:43 -0500)]
Add NSS libraries to images
Alpine OpenJDK was updated 2 days ago (3/14), this
upgrade seems to break java applications that depend on libnss*.so
OS libraries, which seem are no longer installed with the jdk.
Added some other libraries to aid when debugging.
Change-Id: I80ba6a4e145f107219f4380da1cb90ede5ccc056
Issue-ID: POLICY-1604
Signed-off-by: Jorge Hernandez <jorge.hernandez-herrero@att.com>
Jessica Wagantall [Fri, 15 Mar 2019 20:53:25 +0000 (13:53 -0700)]
Update INFO.yaml file
Update missing information blocks and
indentation to pass verify job.
Change-Id: I65eddd59fb920f656f20e696968e69c1bdf8e3df
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Jorge Hernandez [Thu, 14 Mar 2019 13:50:23 +0000 (13:50 +0000)]
Merge "reduce too many method param"
Arindam Mondal [Mon, 11 Mar 2019 06:40:58 +0000 (15:40 +0900)]
reduce too many method param
Issue-ID: POLICY-1535
Change-Id: Ia6f699d315ebd214257dc64d559a0ac4685307f5
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Parshad Patel [Mon, 11 Mar 2019 07:55:06 +0000 (16:55 +0900)]
Fix sonar code smell issues in apex-pdp
Fix method has more than 7 parameters issues
Issue-ID: POLICY-1535
Change-Id: I12d995e323bbdbe3762c903fcb116dfe81bf7b54
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Liam Fallon [Fri, 8 Mar 2019 13:49:51 +0000 (13:49 +0000)]
Merge "Increase test coverage for plugins-event-carrier"
Parshad Patel [Fri, 8 Mar 2019 08:09:57 +0000 (17:09 +0900)]
Increase test coverage for plugins-event-carrier
Add basic JUnit test cases for plugins-event-carrier-restserver
Issue-ID: POLICY-1513
Change-Id: I36e41bd05be71c44eb9e94350f4614437b0d205b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Thu, 7 Mar 2019 15:06:23 +0000 (15:06 +0000)]
Merge "Increase test coverage for plugins-executor-js"
Liam Fallon [Wed, 6 Mar 2019 13:58:47 +0000 (13:58 +0000)]
Merge "Increase test coverage for plugins-event"
Hengye [Wed, 6 Mar 2019 05:14:13 +0000 (05:14 +0000)]
Increase test coverage for plugins-executor-js
Add junit test cases into apex-pdp/plugins/plugins-executor-javascript
Issue-ID: POLICY-1523
Change-Id: Ie8017be2f7507fdb641a4020e13152c656cadf04
Signed-off-by: Hengye <yehui.wang@est.tech>
Parshad Patel [Wed, 27 Feb 2019 01:37:57 +0000 (10:37 +0900)]
Increase test coverage for plugins-event
Add JUnit test cases for plugins-event-carrier-websocket
Issue-ID: POLICY-1513
Change-Id: I5f2a8dacfff4c14cf4a24e9258b5a551cecc1489
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Pamela Dragosh [Fri, 1 Mar 2019 13:13:00 +0000 (13:13 +0000)]
Merge "Increase test coverage for plugins-executor-mvel"
Pamela Dragosh [Fri, 1 Mar 2019 13:12:11 +0000 (13:12 +0000)]
Merge "Increase test coverage for plugins-executor-jruby"
Pamela Dragosh [Fri, 1 Mar 2019 12:56:58 +0000 (12:56 +0000)]
Merge "Use Alpine as base docker image"
Pamela Dragosh [Thu, 28 Feb 2019 19:27:27 +0000 (19:27 +0000)]
Merge "Increase test coverage for plugins-executor-jython"
Jorge Hernandez [Thu, 28 Feb 2019 17:49:41 +0000 (17:49 +0000)]
Merge "Fix checkstyle problems on sonar fix"
Liam Fallon [Thu, 28 Feb 2019 17:09:18 +0000 (17:09 +0000)]
Merge "Update INFO.yaml Liam's email"
Pamela Dragosh [Thu, 28 Feb 2019 15:31:19 +0000 (10:31 -0500)]
Update INFO.yaml Liam's email
est.tech
Issue-ID: POLICY-1556
Change-Id: I1088e64016a15161ec979bf8de1af35835fa3c83
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Tue, 26 Feb 2019 14:39:32 +0000 (14:39 +0000)]
Fix checkstyle problems on sonar fix
A sonar fix brought in some minor checkstyle issues. This
review fixes those.
Issue-ID: POLICY-1535
Change-Id: I4f9d66ffc0a4fcc8901d7e18bfb21a1d1cf135b7
Signed-off-by: liamfallon <liam.fallon@est.tech>
Hengye [Thu, 28 Feb 2019 08:03:50 +0000 (08:03 +0000)]
Use Alpine as base docker image
change docker base image from ubuntu 16.04 to Alpine 3.9
Issue-ID: POLICY-1555
Change-Id: Ia21f5e8185bd26f4b04276eed204ac358f655a59
Signed-off-by: Hengye <yehui.wang@est.tech>
ning.xi [Thu, 28 Feb 2019 03:01:19 +0000 (03:01 +0000)]
Increase test coverage for plugins-executor-jython
Add junit test cases into apex-pdp/plugins/plugins-executor-jython
Issue-ID: POLICY-1523
Change-Id: I2545a9cefc6b4b9a53200b98081ddd8bc8274b40
Signed-off-by: ning.xi <ning.xi@est.tech>
shaoqiu [Thu, 28 Feb 2019 02:56:02 +0000 (02:56 +0000)]
Increase test coverage for plugins-executor-jruby
Add junit test cases into apex-pdp/plugins/plugins-executor-jruby
Issue-ID: POLICY-1523
Change-Id: I2ed06a69cf991d744aa5c4c69f605fdf1dca6524
Signed-off-by: shaoqiu <tim.huang@est.tech>
Hengye [Thu, 28 Feb 2019 02:32:56 +0000 (02:32 +0000)]
Increase test coverage for plugins-executor-mvel
Add junit test cases into apex-pdp/plugins/plugins-executor-mvel
Issue-ID: POLICY-1523
Change-Id: I74d47974a326c7fbd53a0b7d88262ef1dbd54c8c
Signed-off-by: Hengye <yehui.wang@est.tech>
Jorge Hernandez [Wed, 27 Feb 2019 14:55:59 +0000 (14:55 +0000)]
Merge "Fix sonar code smell"
Jorge Hernandez [Tue, 26 Feb 2019 19:20:22 +0000 (19:20 +0000)]
Merge "Increase test coverage for plugins-event"
Parshad Patel [Tue, 26 Feb 2019 02:06:52 +0000 (11:06 +0900)]
Increase test coverage for plugins-event
Add basic JUnit test cases for plugins-event-carrier-jms
Issue-ID: POLICY-1513
Change-Id: I68fa36bc988745108014f47a57fc02bc2ceed0c7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Pamela Dragosh [Mon, 25 Feb 2019 20:03:28 +0000 (20:03 +0000)]
Merge "sonar:reduce number of method param"
Arindam Mondal [Wed, 20 Feb 2019 07:28:26 +0000 (16:28 +0900)]
sonar:reduce number of method param
Changes done according to sonar recommendation.
Issue-ID: POLICY-1535
Change-Id: I57a608e4db1b67959cbabe23e7fe0b1aa91e30cd
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
liamfallon [Sat, 23 Feb 2019 20:01:28 +0000 (20:01 +0000)]
Fix checkstyle errors on tests
Issue-ID: POLICY-1513
Change-Id: Id61df043adf398a0493916f6116ff5858c60fb29
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 22 Feb 2019 17:30:59 +0000 (17:30 +0000)]
Change versions of Zookeeper and C3P0
This review changes the versions of Zookeeper and C3P0 to
resolve security issues.
It also merges the context test utils module into the context test because that
module was misplaced and put an incompatible Zookeeper dependency in the
APEX context module.
Issue-ID: POLICY-1540
Change-Id: I86048ae1fc8b818611f423d6fd1f4a9fcc3f76f9
Signed-off-by: liamfallon <liam.fallon@est.tech>
Hengye [Thu, 21 Feb 2019 09:24:25 +0000 (09:24 +0000)]
correct a typo in doc APEX User Manual
Issue-ID: POLICY-1523
Change-Id: I44675a5119170ab724926ba08a3bfceefda31b57
Signed-off-by: Hengye <yehui.wang@est.tech>
Parshad Patel [Wed, 20 Feb 2019 02:38:16 +0000 (11:38 +0900)]
Increase test coverage for apex-pdp/plugins
Add basic JUnit test cases for plugins-event-carrier-kafka
Issue-ID: POLICY-1513
Change-Id: I009547115705496a850a9609416cdf71f52fb936
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Arindam Mondal [Mon, 18 Feb 2019 09:27:51 +0000 (18:27 +0900)]
Fix sonar code smell
Issue-ID: POLICY-1523
Change-Id: I24f9fe5811bb93597efe79c98572c5249e74026c
Signed-off-by: arindamm <arind.mondal@samsung.com>
liamfallon [Tue, 5 Feb 2019 17:37:24 +0000 (17:37 +0000)]
Fix bug with Apex rejecting HTTP 2xx responses
APEX rejects all HTTP responses except 200. This change accepts
any HTTP 2xx response code as a valid response.
Issue-ID: POLICY-1289
Change-Id: Ief681ba4dac1ef3ff5f257dd931569bd2274d017
Signed-off-by: liamfallon <liam.fallon@est.tech>
ramverma [Fri, 18 Jan 2019 15:17:12 +0000 (15:17 +0000)]
Fix version warning in apex pom
Change-Id: Ia3b7fa204fb8564b679a4416fcc0f70fa0a9a54f
Issue-ID: POLICY-1074
Signed-off-by: ramverma <ram.krishna.verma@est.tech>
liamfallon [Tue, 15 Jan 2019 15:54:45 +0000 (15:54 +0000)]
Fix crashing unit tests in Apex
Issue-ID: POLICY-1403
Change-Id: Ie9d2cc46f3daf4d6b2eb2774a8be8c35e0c45754
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 15 Jan 2019 10:59:15 +0000 (10:59 +0000)]
Update comment to check Sonar build issue
Issue-ID: POLICY-1403
Change-Id: I87ebf85dbbe8544e38666e8e793a8e1cbbcfc7c6
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Fri, 11 Jan 2019 10:51:50 +0000 (10:51 +0000)]
Use parent version of Eclipselink
Issue-ID: POLICY-1360
Change-Id: I33d8cef3f5d273c0c2a93ecda321205316aea6de
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 9 Jan 2019 13:30:23 +0000 (14:30 +0100)]
Fix context clearing on model upgrade
Existing context is cleared when a model upgrade is carried out
on an Apex PDP. The clear() method is called in error on the
Apex engine during the upgrade.
This change also has some small updates to the DecisionMaker example,
which is used to test this feature.
Issue-ID: POLICY-1395
Change-Id: I547a3a60712d1572d9daadf5eab4afcae2a5c321
Signed-off-by: liamfallon <liam.fallon@est.tech>
Parshad Patel [Wed, 26 Dec 2018 05:54:59 +0000 (14:54 +0900)]
Rename test classes in apex-pdp/services
Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I951f4e30736144010d69a0fb3b9181f7fee76013
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Liam Fallon [Fri, 21 Dec 2018 17:26:57 +0000 (17:26 +0000)]
Merge "Rename test classes in apex-pdp/model,core"
Parshad Patel [Fri, 21 Dec 2018 06:36:35 +0000 (15:36 +0900)]
Rename test classes in apex-pdp/model,core
Make test classes name consitence by adding 'Test' at end of junit test classes and adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I6cb8d09799d7abd1b50ead1edbc4986649ad4ba7
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Thu, 20 Dec 2018 14:27:09 +0000 (14:27 +0000)]
Merge "Add SSL keystore/truststore to Apex package"
liamfallon [Wed, 19 Dec 2018 18:29:05 +0000 (18:29 +0000)]
Add SSL keystore/truststore to Apex package
Issue-ID: POLICY-1222
Change-Id: I4409b88d1a9439492f9aac6c3b971bae7dc04b19
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 19 Dec 2018 17:48:47 +0000 (17:48 +0000)]
Add example policy for HTTPS
Added an example of how to configure HTTPS for an Apex policy.
Issue-ID: POLICY-1222
Change-Id: Iea8a8accac32f6d25c64a8324e202ad5e6221c7a
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Wed, 19 Dec 2018 14:13:57 +0000 (14:13 +0000)]
Merge "Add Java property parameters for HTTPS"
liamfallon [Tue, 18 Dec 2018 17:18:45 +0000 (17:18 +0000)]
Add Java property parameters for HTTPS
Issue-ID: POLICY-1222
Change-Id: I4a683cf2f52e7f1d28164954f84d0744b5ca7e9c
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 18 Dec 2018 11:40:39 +0000 (11:40 +0000)]
Remove unused @throws warnings
Previous checkstyle fixes rationalised the
exceptions thrown by methods, however the javadoc
comments were not updated. This review updates them.
Issue-ID: POLICY-1263
Change-Id: I2746f30e76018ec4d0f1e74a6a415979b7874329
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sat, 15 Dec 2018 09:47:58 +0000 (09:47 +0000)]
Fix sonar test renaming issues
Renaming tests introduced Sonar issues:
- Tests where coverage was <80% flagged as they are new code
- Support test classes with names ending in "Test" flagged
becasue they did not contain test cases
Issue-ID: POLICY-1263
Change-Id: I17a4b27b2952a4978fab1c76579a013478b60ae1
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 11 Dec 2018 20:58:57 +0000 (20:58 +0000)]
Add period after inheritDoc
Issue-ID: POLICY-1074
Change-Id: I88dc888b2a374b38499241f578a36dd116e2b85b
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Tue, 11 Dec 2018 15:50:07 +0000 (15:50 +0000)]
Merge "Remove unused parameter from test data"
liamfallon [Sat, 8 Dec 2018 11:31:30 +0000 (11:31 +0000)]
Remove unused parameter from test data
The "restRequestTimeout" parameter is not used in the current
version of Apex, it was replaced by the "requestorTimeout" paramter.
However, the parameter remained in the JSON data files.
Also updated to improve output of messages during unit test.
This review also sets the Jersey injection dependendy scope to "test"
Issue-ID: POLICY-1074
Change-Id: I75f495f571c8101310bd1eaec01a305318346cd9
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Tue, 11 Dec 2018 00:32:30 +0000 (00:32 +0000)]
Merge "Support HTTP headers in REST Client"
liamfallon [Fri, 7 Dec 2018 22:28:49 +0000 (22:28 +0000)]
Fix checkstyle issues
Some minor line length and formatting checkstyle warnings fixed.
Change-Id: Ib92069bbdb444560083e6d0dbf5d16a3ab824d82
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sat, 8 Dec 2018 11:27:17 +0000 (11:27 +0000)]
Support HTTP headers in REST Client
Fixed REST client plugin to supprot HTTP headers and add unit
test to plugin.
Change-Id: I6a71ab7f83ed2126b8600bb5e586f971dbdacdc0
Issue-ID: POLICY-1222
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Thu, 6 Dec 2018 16:33:15 +0000 (16:33 +0000)]
Merge "Fix bugs in context flushing"
Jorge Hernandez [Thu, 6 Dec 2018 14:42:18 +0000 (14:42 +0000)]
Merge "Support HTTP headers in REST Requestor"
liamfallon [Wed, 5 Dec 2018 17:38:40 +0000 (17:38 +0000)]
Fix bugs in context flushing
The context flushing support in the context distributor can throw a
concurrent exception when a lot of context is active and a flush takes
place. This fix introduces proper synchronized access to the album maps.
In addition, there was an incorrect cast in the call to the persist() method
of the persistor.
Change-Id: I6594ffed83a0b34251a0c5c7893d4abb17437fd4
Issue-ID: POLICY-1380
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 4 Dec 2018 22:36:39 +0000 (22:36 +0000)]
Support HTTP headers in REST Requestor
Change-Id: Iea4211e7d3324f5ea6244f45c91241a4067d8d33
Issue-ID: POLICY-1222
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Mon, 3 Dec 2018 22:48:10 +0000 (22:48 +0000)]
Add unit test for Java executor
Code coverage in the Apex-PDP plugins is very low. JUnit coverage will be
increased for the Plugins over the Dublin design timeline.
Issue-ID: POLICY-1379
Change-Id: Ie70ab5a9be650818cb330ec5be2a89a5db6153c5
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jorge Hernandez [Mon, 3 Dec 2018 19:41:57 +0000 (19:41 +0000)]
Merge "Fix checkstyle/sonar issues"
Pamela Dragosh [Mon, 3 Dec 2018 15:25:38 +0000 (15:25 +0000)]
Merge "Rename test classes in apex-pdp"
liamfallon [Mon, 3 Dec 2018 14:35:21 +0000 (14:35 +0000)]
Fix checkstyle/sonar issues
Remove unused imports
Add @FunctionalInterface annotation
Reduce the complexity of some methods
Change-Id: If519c31b113233361fbb935121fe6494263ac957
Issue-ID: POLICY-1074
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Sun, 2 Dec 2018 19:35:23 +0000 (19:35 +0000)]
Use Parent Eclipselink
Issue-ID: POLICY-1360
Change-Id: I99a9e7bf60590fd0da5d7ba001e8ab322623fee6
Signed-off-by: liamfallon <liam.fallon@est.tech>
Parshad Patel [Fri, 30 Nov 2018 11:15:11 +0000 (20:15 +0900)]
Rename test classes in apex-pdp
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: I1dc1a7f174660a90664ebdcff2ea79ed30aa465c
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Thu, 29 Nov 2018 15:56:19 +0000 (15:56 +0000)]
Merge "Fixing issues in apex documents"
ramverma [Thu, 29 Nov 2018 13:47:30 +0000 (13:47 +0000)]
Fixing issues in apex documents
Change-Id: Ibc07c20fa8ac1018443a3c061613fdaecc5efb83
Issue-ID: POLICY-1280
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Pamela Dragosh [Thu, 29 Nov 2018 14:16:14 +0000 (14:16 +0000)]
Merge "Rename test classes in apex-pdp/model/basic-model"
Parshad Patel [Wed, 28 Nov 2018 07:53:33 +0000 (16:53 +0900)]
Rename test classes in apex-pdp/model/basic-model
Make test classes name consitence by adding 'Support' or 'Dummy' at start of util or dummy type of test classes
Issue-ID: POLICY-1263
Change-Id: Ia90e0ea73af16f6cde37692e98f1c4afc408dd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Jorge Hernandez [Mon, 26 Nov 2018 17:15:31 +0000 (17:15 +0000)]
Merge "Fix sonar issue cli codegen"
Krishnakumar Jinka [Sat, 24 Nov 2018 17:53:57 +0000 (02:53 +0900)]
Fix sonar issue cli codegen
Modify CodeGeneratorCliEditor to use param object for sonar issue fix
Add javadoc for the method addEventDecl Method. Modify meth
declaration. Run formatter
Issue-ID: POLICY-1251
Change-Id: I4f95e868c047f54dff9cf991e8f4f60e8954c788
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
Pamela Dragosh [Fri, 23 Nov 2018 19:46:05 +0000 (14:46 -0500)]
Create label for architecture to ref
Creating a label so other documentation in the architecture
section can reference this PDP engine documentation.
Issue-ID: POLICY-1163
Change-Id: Ida9caba405e36675f65843b1d49e79175634fa02
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
liamfallon [Tue, 20 Nov 2018 15:59:50 +0000 (15:59 +0000)]
Refactor Apex benchmark tests
Apex performance tests are refactored and reorganised
to be all in the one place and to be coherent.
A test REST server that can generate events in batches
is introduced and this can be configured to respond to REST
calls from Apex with various batch sizes that can be varied
for performance tests.
Actual performance tests are added for the various executors
in Apex.
Change-Id: I692b41e1e4451e821a618c64dead5cc8e9685d08
Issue-ID: POLICY-812
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Parshad Patel [Tue, 20 Nov 2018 05:46:45 +0000 (14:46 +0900)]
Rename test classes in apex-pdp
Make test classes name consistence under auth, model, plugins, testsuits, tools projects
Issue-ID: POLICY-1263
Change-Id: I49ec9a9f5b457d6381e693de2c04ec0268ad1b02
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Parshad Patel [Fri, 16 Nov 2018 11:59:14 +0000 (20:59 +0900)]
Rename test classes in apex-pdp
Make test classes name consistence by putting 'Test' at end
Issue-ID: POLICY-1263
Change-Id: I0179388d84826e698276a1995dd8173a40b5fd2b
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
liamfallon [Thu, 15 Nov 2018 22:07:45 +0000 (22:07 +0000)]
Fix timing and move tests
The timings on the REST test are too short and time out on ONAP Jenkins
The tests of the Apex service and Apex model upgrade are not
benchmark tests so are moved to Integration.
Issue-ID: POLICY-1251
Change-Id: I2672d01042b33fe0cce5223005295e3b1aa26e7a
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 15 Nov 2018 15:43:17 +0000 (15:43 +0000)]
Fix checkstyle warnings in AxState/Codegen
Recent checkins introduced some very minor checkstyle warnings, this
review fixes those.
Change-Id: Ie7784ad22a748017e1647be0e23dc9d3fe100cf0
Issue-ID: POLICY-1251
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jorge Hernandez [Thu, 15 Nov 2018 14:36:02 +0000 (14:36 +0000)]
Merge "Use param obj for contxt album decln"
Jorge Hernandez [Thu, 15 Nov 2018 14:35:08 +0000 (14:35 +0000)]
Merge "Refactored Asynchronous tests to integration"
liamfallon [Wed, 14 Nov 2018 17:01:39 +0000 (17:01 +0000)]
Refactored Asynchronous tests to integration
Moved the tests of asynchronous and synchronous inputs and outputs
for Apex from benchmark tests to integration tests which is where
they should be. Also the tests were amended to use the common
integration test data.
Change-Id: Id2d098b0a7d70c50dbb4547b0386cc7bcf6245a9
Issue-ID: POLICY-954
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
kris.jinka [Thu, 15 Nov 2018 02:26:38 +0000 (11:26 +0900)]
Use param obj for contxt album decln
Modify code generator cli editor to use param object
for the sonar issue fix
Issue-ID: POLICY-1251
Change-Id: I3efbdbe2ce7c16702508b9f1f36ecbb9b1e12856
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
kris.jinka [Tue, 13 Nov 2018 01:45:42 +0000 (10:45 +0900)]
Use param obj for policymodel AxState
Define AxStateParams object for parameters input
Fix sonar issue about more than 7 parameters in method
Modify the builder approach as suggested in review
Issue-ID: POLICY-1251
Change-Id: Ic11b8cc2a4aed5394c5450fed4f0702c4ad9eda4
Signed-off-by: kris.jinka <kris.jinka@samsung.com>
liamfallon [Sat, 10 Nov 2018 00:39:12 +0000 (00:39 +0000)]
Clean up eclipse and document warnings
Parent versions in some POMs only called on the test profile
were incorrect
Warnings in Eclipse on POM including from outside its project
are fixed
Some checkstyle fixes
Some javadoc warnings fixed
Issue-ID: POLICY-954
Change-Id: I640bc842dc79a9fa580015abb9a76c84a7845efe
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Tue, 6 Nov 2018 12:02:46 +0000 (12:02 +0000)]
Refactor unit test data
There were many copies of test policies and examples
strewn through the Apex unit tests. This change cleans
up the unit tests so that a single version of all example
policies is used in all tests.
Also added a new relative file root command line parameter
to Apex to allow the root of relative paths in configuration
files to be set.
Apologies for the size of this review but unfortunately
all of this must be done in one shot.
Issue-ID: POLICY-1252
Change-Id: Ibbb18fbf18e3897a1c61301d0a65e62bc643a0e9
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Thu, 1 Nov 2018 14:59:21 +0000 (14:59 +0000)]
Upgrade Jython for security, add doc warning
Upgrading Jython to use a full release version. This will probably
noit remove security problem but upgrades Jython to the most popular
version.
A warning is added telling developers to check extra pcakages in the
Jython plugin documentation.
Issue-ID: POLICY-1065
Change-Id: I83275204c1905bd48dd5ea58e98dcbbd9c47195f
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
liamfallon [Wed, 31 Oct 2018 16:35:54 +0000 (16:35 +0000)]
Set new master version for Dublin
Issue-ID: POLICY-1232
Change-Id: If43c40e9e13bd9387e2b6ee876717f8413a17e34
Signed-off-by: liamfallon <liam.fallon@ericsson.com>