summary |
shortlog | log |
commit |
commitdiff |
review |
tree
first ⋅ prev ⋅ next
Tony Hansen [Mon, 5 Feb 2018 20:35:15 +0000 (20:35 +0000)]
Merge "sonar Major issues"
Tony Hansen [Mon, 5 Feb 2018 20:32:05 +0000 (20:32 +0000)]
Merge "sonar Major Using @Override annotation"
Tony Hansen [Mon, 5 Feb 2018 20:31:28 +0000 (20:31 +0000)]
Merge "sonar Major Using @Override annotation"
Tony Hansen [Mon, 5 Feb 2018 20:26:01 +0000 (20:26 +0000)]
Merge "Sonar Major fix"
Tony Hansen [Mon, 5 Feb 2018 20:25:03 +0000 (20:25 +0000)]
Merge "Sonar Major fix"
Snigdha Sucharita Patra [Mon, 5 Feb 2018 14:43:52 +0000 (20:13 +0530)]
sonar Major issues
Replace these toUpperCase()/toLowerCase() and equals() calls with a single equalsIgnoreCase() call
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServiceTypesApiServiceImpl.java
Line No:162
Change-Id: I2d3514753229c9c7a3c9fc005d26d55451f90603
Issue-ID: DCAEGEN2-303
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 5 Feb 2018 14:01:39 +0000 (19:31 +0530)]
sonar Major Using @Override annotation
Add the @Override annotation above this method signature
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServicesDAO.java
Line No-40
Change-Id: Ic1036c33e8de4ba994e3b3f81d1a70eab3a5e576
Issue-ID: DCAEGEN2-299
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Mon, 5 Feb 2018 06:27:48 +0000 (11:57 +0530)]
Sonar Major fix
Remove useless parentheses in DcaeServicesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=_me_%2CPooja03
Location:DcaeServicesApiServiceImpl.java:L214
Change-Id: I69cfc51a0e42516564c821ec5a0610c4cb3e7242
Issue-ID: DCAEGEN2-301
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Fri, 2 Feb 2018 09:42:07 +0000 (15:12 +0530)]
Sonar Major fix
Remove useless parentheses in DcaeServicesApiServiceImpl.java
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|assignees=_me_%2CPooja03
Location:DcaeServicesApiServiceImpl.java:L139
Change-Id: I60ab8364871ffc2263e3ef94b0861c831171b756
Issue-ID: DCAEGEN2-298
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Snigdha Sucharita Patra [Thu, 1 Feb 2018 10:53:54 +0000 (16:23 +0530)]
sonar Major Using @Override annotation
Add the @Override annotation above this method signature
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/DCAEServicesComponentsMapsDAO.java
Line No-42
Change-Id: I22a4e6f437986386fb3d3312466b0e9098704ffd
Issue-ID: DCAEGEN2-295
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Pooja03 [Thu, 1 Feb 2018 10:41:11 +0000 (16:11 +0530)]
Sonar Major fix
resourcePath variable is already a string, there's no need to call toString method
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#severities=MAJOR|resolved=false|rules=squid%3AS1858
Change-Id: I5470b33aed3c8fd487c4d3687ee6f1d2de77abeb
Location:DatabusControllerClient.java:L51
Issue-ID: DCAEGEN2-296
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Thu, 1 Feb 2018 06:40:13 +0000 (12:10 +0530)]
Sonar Major fix
Adding the @Override annotation above checkIfTableExists method signature in DCAEServiceComponentsDAO.java
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|assignees=_me_%2CPooja03
Location:DCAEServiceComponentsDAO.java:L39
Issue-ID: DCAEGEN2-288
Change-Id: I74eca3cb3d8b3d528ce462b1c0a8eda1ad574552
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Wed, 31 Jan 2018 05:46:33 +0000 (11:16 +0530)]
Sonar Major fix
Adding the @Override annotation above the createTable method signature in DCAEServiceComponentsDAO.java
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR|rules=squid%3AS1161
Location:DCAEServiceComponentsDAO.java:L43
Change-Id: Ieca7421d424827f82dd662f8d5a097d8198a2dbe
Issue-ID: DCAEGEN2-289
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Lusheng Ji [Mon, 29 Jan 2018 18:27:00 +0000 (18:27 +0000)]
Merge "Sonar Major fix"
Lusheng Ji [Mon, 29 Jan 2018 18:26:53 +0000 (18:26 +0000)]
Merge "Sonar Major fix"
Pooja03 [Mon, 29 Jan 2018 12:16:34 +0000 (17:46 +0530)]
Sonar Major fix
Remove the unused context local variable
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=MAJOR
Location:Bootstrap.java:L46
Change-Id: I3c59b7bc590fb9ba5e894e0dc584fc9d0026e209
Issue-ID: DCAEGEN2-285
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Pooja03 [Mon, 29 Jan 2018 11:56:22 +0000 (17:26 +0530)]
Sonar Major fix
Replace the type specification in this constructor call with the diamond operator
Sonar Link:https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL%2CMAJOR
Location:DcaeServiceTypesApiServiceImpl.java:L96
Change-Id: If36e27e862ee2d8db4c2f2b9def49afa88cf9632
Issue-ID: DCAEGEN2-284
Signed-off-by: Pooja03 <PM00501616@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 09:37:52 +0000 (15:07 +0530)]
sonar critical for Exception handling
Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/exceptions/mappers/DBIExceptionMapper.java
Line No-62
Change-Id: Id74f81284ac81e1f5e64b5549afc66cead7a8597
Issue-ID: DCAEGEN2-210
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 09:03:42 +0000 (14:33 +0530)]
sonar critical throw a dedicated exception
Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java
Line No-143
Change-Id: I52ecbd360bff6efa8906623ae7345ef694491d6b
Issue-ID: DCAEGEN2-215
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Snigdha Sucharita Patra [Mon, 29 Jan 2018 06:16:37 +0000 (11:46 +0530)]
sonar critical throw a dedicated exception
Define and throw a dedicated exception instead of using a generic one
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/org/onap/dcae/inventory/daos/InventoryDAOManager.java
Line No-134
Change-Id: I94f4d39fd55dc11c1459971074944fc2ff589cae
Issue-ID: DCAEGEN2-214
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Lusheng Ji [Wed, 24 Jan 2018 13:58:44 +0000 (13:58 +0000)]
Merge "sonar critical for Exception handling"
Tony Hansen [Tue, 23 Jan 2018 14:04:53 +0000 (14:04 +0000)]
Merge "sonar critical for Exception handling"
Snigdha Sucharita Patra [Tue, 23 Jan 2018 03:43:52 +0000 (09:13 +0530)]
sonar critical for Exception handling
Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/component_issues/index?id=org.onap.dcaegen2.platform%3Ainventory-api#severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Line No-118
Change-Id: I98ebe37fa928cb9fdbbaf841987902f9fe3fb693
Issue-ID: DCAEGEN2-216
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
Michael Hwang [Fri, 19 Jan 2018 15:43:43 +0000 (10:43 -0500)]
Change package from openecomp to onap
Change-Id: I2a79eb123e5fbb6a6c2f0e72030d6781fbbd7513
Issue-ID: DCAEGEN2-225
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Snigdha Sucharita Patra [Fri, 19 Jan 2018 07:56:18 +0000 (13:26 +0530)]
sonar critical for Exception handling
Either log or rethrow this exception
Sonar Link:
https://sonar.onap.org/component_issues?id=org.onap.dcaegen2.platform%3Ainventory-api#resolved=false|severities=CRITICAL|assignees=Snigdha503415
Location:
src/main/java/io/swagger/api/impl/DcaeServicesApiServiceImpl.java
Line No-104
Change-Id: I6c93a308b0e069cd13d59387efc99340e408a7d2
Issue-ID: DCAEGEN2-209
Signed-off-by: Snigdha Sucharita Patra <sp00503415@techmahindra.com>
libujacob [Fri, 5 Jan 2018 10:19:56 +0000 (15:49 +0530)]
Add private constructor in all static member class
Add @override annotation to overridden functions
Issue-ID: DCAEGEN2-207
Change-Id: I7bf8ad7afec645cbe28fceaaa8f4c04001a0ef6a
Signed-off-by: libujacob <libu.jacob@huawei.com>
Jessica Wagantall [Fri, 17 Nov 2017 19:48:55 +0000 (11:48 -0800)]
Bump minor version
Bump minor version in preparation for Amsterdam
branching.
Change-Id: Ifcef9d089eb8e806ca04195fc53e399f55b5a1b4
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Michael Hwang [Mon, 2 Oct 2017 23:40:06 +0000 (19:40 -0400)]
Add more unit tests
Change-Id: Ib8e586a5aa7d31756751776015bbb76f68a0cafc
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Tue, 26 Sep 2017 21:50:21 +0000 (17:50 -0400)]
Add more unit tests
Change-Id: I514389aa3d154a35505d833fd4ae0155f07b7f67
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Jessica Wagantall [Wed, 20 Sep 2017 22:25:29 +0000 (15:25 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: If9a204312b480a8f911b1e195926e62540361e31
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Michael Hwang [Tue, 19 Sep 2017 21:28:07 +0000 (17:28 -0400)]
Get unit tests working
Including fixing of broken test
Change-Id: Ie5fa6a2c4bd59b7552480899616590c7944e5aa4
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Tue, 19 Sep 2017 17:56:52 +0000 (13:56 -0400)]
Try to use the hidden settings.xml for Docker push
The Docker authentication info is in the settings.xml
Change-Id: I23cc52f9de36d0b74f21de90874cafc13d9670e5
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Mon, 18 Sep 2017 21:09:35 +0000 (17:09 -0400)]
Remove the mapping of docker executions
The corresponding jjb has been changed to explicitly call the docker
execution operations.
Change-Id: I186b104c8ee65837f20978a5aefdd467bc624d31
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Thu, 14 Sep 2017 19:10:24 +0000 (15:10 -0400)]
Change deploy goal to push Docker image
Also remove distribution section which is now in oparent
Change-Id: I0573672c11fa6eaf7f7d974e7d6c21759bac1cb3
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Michael Hwang [Thu, 14 Sep 2017 18:42:52 +0000 (14:42 -0400)]
Make updates to pom to work with oparent and jjb
Change-Id: Id8dc78bde28861a6dd548a20840d638ad00c1ac9
Issue-Id: DCAEGEN2-60
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Vijay Venkatesh Kumar [Tue, 12 Sep 2017 19:08:43 +0000 (19:08 +0000)]
Merge "Remove the now banned license plugin"
Michael Hwang [Tue, 12 Sep 2017 18:46:25 +0000 (14:46 -0400)]
Remove the now banned license plugin
Change-Id: I79514bc7eb8546e12a4d6428e61fb18fffe87c98
Issue-Id: DCAEGEN2-25
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Jessica Wagantall [Fri, 8 Sep 2017 20:04:03 +0000 (13:04 -0700)]
Cleanup project's name in Sonar
The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.
Change-Id: If5f3051f78b40ca3d325c4fec7cb408f9a88b9d6
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Lusheng Ji [Tue, 29 Aug 2017 14:17:12 +0000 (14:17 +0000)]
Update LICENSE.txt
Issue-Id: DCAEGEN2-86
Change-Id: I5bd8fe2773d7a8c5f45c1269c8fbbd70a9d40e21
Signed-off-by: Lusheng Ji <lji@research.att.com>
Michael Hwang [Tue, 14 Feb 2017 15:10:16 +0000 (15:10 +0000)]
Make first commit
Transferring from original dcae project
Issue-Id: DCAEGEN2-45
Change-Id: If8500f4a120ec2d27a714c8917f163beb57ee64c
Signed-off-by: Michael Hwang <mhwang@research.att.com>
Jessica Wagantall [Wed, 28 Jun 2017 01:21:48 +0000 (01:21 +0000)]
Initial empty repository
Code Review / dcaegen2 / platform / inventory-api.git / log