so.git
5 years agoMerge "Sonar fix NullPointerException"
Seshu Kumar M [Thu, 2 May 2019 10:43:03 +0000 (10:43 +0000)]
Merge "Sonar fix NullPointerException"

5 years agoEnhanced logic for multilevel list input reading from UUI 84/86784/2
sarada prasad sahoo [Thu, 2 May 2019 05:22:46 +0000 (10:52 +0530)]
Enhanced logic for multilevel list input reading from UUI

Logic modified to support VF and VFC/group level user input reading
from the list and automatically incrementing/maintaining index of
list for fetching data from User input and map to service inputs.

Change-Id: I9faa7e9a689324e80c1e5123e0d4c2ebedd1bf76
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
5 years agoAdd Model Version Query 92/86692/1
Smokowski, Steven [Wed, 1 May 2019 01:00:08 +0000 (21:00 -0400)]
Add Model Version Query

Fix the sql migration version numbering to be proper
Fix marking test as private, mark public
Clean up public declarations to private
Fix schema.sql to have new column for unit test
Revert POM Change, add License, clean up comments
Fix bad spelling of method name issue
Update catalog db to support new rest endpoint
Update local query service and mappers
Localstaging of potential catalog db changes
Update logic to write overall distro status

Change-Id: I84d53b972ede3176c5af32d13444583a36606efa
Issue-ID: SO-1820
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoSonar fix NullPointerException 91/86591/1
Arindam Mondal [Tue, 30 Apr 2019 06:04:26 +0000 (15:04 +0900)]
Sonar fix NullPointerException

Issue-ID: SO-1829
Change-Id: I2b09733698391607989c2289b8c9f8ba5cdfabe4
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
5 years agoRemoved static fields from ASDCRestInterface 38/86538/1
Witold Ficio Kopel [Mon, 29 Apr 2019 14:51:05 +0000 (16:51 +0200)]
Removed static fields from ASDCRestInterface

Fix to Sonar issue - misuse of private static fields within class.
Refactored to local variables.

Issue-ID: SO-1490
Change-Id: I4e2f3dc5b5424198263bdfc0ff16ae123969db48
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
5 years agoMerge "VNFM simulator implementation for delete flow"
Steve Smokowski [Mon, 29 Apr 2019 13:36:05 +0000 (13:36 +0000)]
Merge "VNFM simulator implementation for delete flow"

5 years agoMerge "Fixed issues found in delete integration testing"
Steve Smokowski [Mon, 29 Apr 2019 13:36:00 +0000 (13:36 +0000)]
Merge "Fixed issues found in delete integration testing"

5 years agoMerge "Store Cloud Request in Database"
Steve Smokowski [Mon, 29 Apr 2019 13:35:51 +0000 (13:35 +0000)]
Merge "Store Cloud Request in Database"

5 years agoMerge "created new custom exception"
Steve Smokowski [Mon, 29 Apr 2019 13:35:45 +0000 (13:35 +0000)]
Merge "created new custom exception"

5 years agoVNFM simulator implementation for delete flow 05/86505/1
MichaelMorris [Mon, 29 Apr 2019 10:17:43 +0000 (10:17 +0000)]
VNFM simulator implementation for delete flow

Issue-ID: SO-1773
Change-Id: I14c8325dbb8fbdaebff7b7ec674fd0ddbb5930c3
Signed-off-by: MichaelMorris <michael.morris@est.tech>
5 years agoFixed issues found in delete integration testing 04/86504/1
MichaelMorris [Mon, 29 Apr 2019 10:16:49 +0000 (10:16 +0000)]
Fixed issues found in delete integration testing

Issue-ID: SO-1827
Change-Id: I73fdcad3d466634cea850e4df10291a66ec2aa61
Signed-off-by: MichaelMorris <michael.morris@est.tech>
5 years agoStore Cloud Request in Database 51/86451/2
Smokowski, Steven [Sat, 27 Apr 2019 01:10:25 +0000 (21:10 -0400)]
Store Cloud Request in Database

Store Cloud Request in Database, add to request service
Add query Param to Plural to include cloud data

Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32
Issue-ID: SO-1807
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Sonar comments fixed Removed commented lines/ Change static string litrals...
Seshu Kumar M [Sun, 28 Apr 2019 13:37:59 +0000 (13:37 +0000)]
Merge "Sonar comments fixed Removed commented lines/ Change static string litrals name according to the guidelines. Issue-ID: SO-1490"

5 years agoMerge "Sonar comments fixed Removed commented lines/ Change static string litrals...
Seshu Kumar M [Sun, 28 Apr 2019 13:35:55 +0000 (13:35 +0000)]
Merge "Sonar comments fixed Removed commented lines/ Change static string litrals name according to the guidelines. Issue-ID: SO-1490"

5 years agoAdd parsing for support of new CCVPN model 55/86455/1
subhash kumar singh [Sat, 27 Apr 2019 21:40:37 +0000 (03:10 +0530)]
Add parsing for support of new CCVPN model

Update the resource_list logic to create the resource as per new
CCVPN model.

e.g. new model UUI request to create the service with this input
     // [
        // { VFB1 : [GrpA1, GrA2, GrB1]},
        // { VFB2 : [GrpA1, GrB1]},
        // { VFA1 : [GrpC1]}
        // ]

should be converted to
// [
        // { VFA1 : [GrpA1, GrA2, GrB1]},
        // { VFA2 : [GrpA1, GrB1]},
        // { VFB1 : [GrpC1]}
        // ]

as per resource ordering.

Change-Id: I79a30d5080d2551eb7e1944cc4f25d5332d22d4f
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoEnhance resource sequence to add group 48/86448/2
subhash kumar singh [Sat, 27 Apr 2019 07:01:21 +0000 (12:31 +0530)]
Enhance resource sequence to add group

Enhance resource sequence to add group.

Change-Id: I9f7ad2a437cd66ba3b8382f3937b0b04752a184a
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoEnhanced Service decomposition to handle gruop 98/86398/9
subhash kumar singh [Fri, 26 Apr 2019 11:38:40 +0000 (17:08 +0530)]
Enhanced Service decomposition to handle gruop

Enhanced Service decomposition to handle gruop and vnfcs

Issue-ID: SO-1393
Change-Id: If28416e4776f2ff645abdd0d1059d28c9ca6e52f
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoSonar comments fixed 53/86353/2
Subhosree Pan [Fri, 26 Apr 2019 06:06:18 +0000 (06:06 +0000)]
Sonar comments fixed
Removed commented lines/ Change static string litrals name according to the guidelines.
Issue-ID: SO-1490

Change-Id: I77a0b2a5067d71ede2de8e090ed4d0b1fb61e219
Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
5 years agoSonar comments fixed 52/86352/2
Subhosree Pan [Thu, 25 Apr 2019 11:56:52 +0000 (11:56 +0000)]
Sonar comments fixed
Removed commented lines/ Change static string litrals name according to the guidelines.
Issue-ID: SO-1490

Change-Id: I4ffee97269f0f0bdcb23f5b297df8fddb0c133f1
Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
5 years agocomments updated 61/86261/2
Subhosree Pan [Thu, 25 Apr 2019 09:44:50 +0000 (09:44 +0000)]
comments updated
String constant added as per the guidance, commented out codes has been removed
Issue-ID: SO-1490

Change-Id: Ia7a531580eaafd80900200b1cf5122c1a8b9f511
Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
5 years agoMerge "Cleaned up DeleteVnfNotification"
Seshu Kumar M [Sat, 27 Apr 2019 07:00:11 +0000 (07:00 +0000)]
Merge "Cleaned up DeleteVnfNotification"

5 years agoMerge "JUnit tests for RequestsDBHelper"
Seshu Kumar M [Sat, 27 Apr 2019 06:59:54 +0000 (06:59 +0000)]
Merge "JUnit tests for RequestsDBHelper"

5 years agoMerge "VNFM simulator implementation for instantiate flow"
Seshu Kumar M [Sat, 27 Apr 2019 06:46:29 +0000 (06:46 +0000)]
Merge "VNFM simulator implementation for instantiate flow"

5 years agoMerge " Removed hardcoded values for PNF creation (cvlan, svlan, remoteId)"
Seshu Kumar M [Sat, 27 Apr 2019 06:45:10 +0000 (06:45 +0000)]
Merge " Removed hardcoded values for PNF creation (cvlan, svlan, remoteId)"

5 years agoMerge "Reorder modifiers. Reorder modifiers to complt with Java code specifications...
Seshu Kumar M [Sat, 27 Apr 2019 06:38:38 +0000 (06:38 +0000)]
Merge "Reorder modifiers. Reorder modifiers to complt with Java code specifications Issue-ID: SO-1490"

5 years agoMerge "Removed imports and defined a constant. Removed imports and defined constant...
Seshu Kumar M [Sat, 27 Apr 2019 06:37:45 +0000 (06:37 +0000)]
Merge "Removed imports and defined a constant. Removed imports and defined constant and combined exception in single catch block. Issue-ID: SO-1490"

5 years agocreated new custom exception 53/86453/1
Boslet, Cory [Sat, 27 Apr 2019 01:44:03 +0000 (21:44 -0400)]
created new custom exception

Added a new exception type for unexpected data results.

Change-Id: I5d0a0ab5e744cd507fe21a58f14cb5f91abff2bf
Issue-ID: SO-1819
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoCleaned up DeleteVnfNotification 83/86383/1
r.bogacki [Fri, 26 Apr 2019 10:37:14 +0000 (12:37 +0200)]
Cleaned up DeleteVnfNotification

Cleaned up DeleteVnfNotification according to Sonar analyses.
Removed unnecessary code.

Change-Id: If8e35d29edb85ad4905a9373f0a820b5f7f07b72
Issue-ID: SO-1817
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agoRemoved JsonIgnore for resourceInput 68/86368/2
subhash kumar singh [Fri, 26 Apr 2019 09:09:55 +0000 (14:39 +0530)]
Removed JsonIgnore for resourceInput

Removed JsonIgnore for resourceinput, it was earlier made @jsonIgnore
to fix mapping (SO-1358).

Change-Id: I7eb7160be220d445bec396d4c5eb3fd913e66f9e
Issue-ID: SO-1816
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoJUnit tests for RequestsDBHelper 71/86371/2
r.bogacki [Fri, 26 Apr 2019 09:32:10 +0000 (11:32 +0200)]
JUnit tests for RequestsDBHelper

Increased junit tests coverage according to Sonar analyses.

Change-Id: I66a513d664122c1a37e64dc6eca533590b16d48c
Issue-ID: SO-1692
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years ago Removed hardcoded values for PNF creation (cvlan, svlan, remoteId) 67/86267/2
marios.iakovidis [Thu, 25 Apr 2019 10:15:41 +0000 (13:15 +0300)]
 Removed hardcoded values for PNF creation (cvlan, svlan, remoteId)

Change-Id: Ie4a63dd06279713c9f13062a09b44eb0e7f2e6bc
Issue-ID: SO-1815
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
5 years agoVNFM simulator implementation for instantiate flow 66/86366/1
Lathish [Fri, 26 Apr 2019 08:46:13 +0000 (08:46 +0000)]
VNFM simulator implementation for instantiate flow

Issue-ID: SO-1773
Change-Id: I710fe6905d650df29f7550f4eafde2f672301bc4
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
5 years agoReorder modifiers. 61/86361/1
h00397475 [Fri, 26 Apr 2019 08:19:03 +0000 (13:49 +0530)]
Reorder modifiers.
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490

Change-Id: Ic7d2700347b79e0c155f84d3ca1175dda1edb6f8
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Enhancement for query"
Seshu Kumar M [Fri, 26 Apr 2019 07:05:17 +0000 (07:05 +0000)]
Merge "Enhancement for query"

5 years agoMerge "Removed generic type from right triangle. Removed generic type from right...
Seshu Kumar M [Fri, 26 Apr 2019 06:24:03 +0000 (06:24 +0000)]
Merge "Removed generic type from right triangle. Removed generic type from right triangle which is not recommended after java 7 Issue-ID: SO-1490"

5 years agoMerge "Define constant in place of literals Constants are declared and used in place...
Seshu Kumar M [Fri, 26 Apr 2019 06:23:44 +0000 (06:23 +0000)]
Merge "Define constant in place of literals Constants are declared and used in place of literals Issue-ID: SO-1490"

5 years agoMerge "Removal of unused variables and replace type specification. Removal of unused...
Seshu Kumar M [Fri, 26 Apr 2019 06:23:08 +0000 (06:23 +0000)]
Merge "Removal of unused variables and replace type specification. Removal of unused local variables. Replace type specifications with diamond operator as per guide lines. Issue-ID: SO-1490"

5 years agoMerge "Fixed issues found in integration testing"
Seshu Kumar M [Fri, 26 Apr 2019 06:22:34 +0000 (06:22 +0000)]
Merge "Fixed issues found in integration testing"

5 years agoMerge "Removed unused imports and rearranged variables Removed unused imports and...
Seshu Kumar M [Fri, 26 Apr 2019 06:18:46 +0000 (06:18 +0000)]
Merge "Removed unused imports and rearranged variables Removed unused imports and moved variables to comply with Java Code Conventions. Issue-ID: SO-1490"

5 years agoEnhancement for query 40/85940/19
subhash kumar singh [Sat, 20 Apr 2019 10:11:18 +0000 (15:41 +0530)]
Enhancement for query

Enhancemenv for query to include group and vnfccustomization.

{
    "serviceResources": {
        "modelInfo": {
            "modelName": "NSService",
            "modelUuid": "0bad8c92-7d22-49f0-b092-b64e6ca564a7",
            "modelInvariantUuid": "69161960-515b-4bf3-91f1-313b813f5e1d",
            "modelVersion": "1.0"
        },
        "serviceType": "",
        "serviceRole": "",
        "environmentContext": "General_Revenue-Bearing",
        "resourceOrder": "NF",
        "workloadContext": "Production",
        "serviceVnfs": [
            {
                "modelInfo": {
                    "modelName": "",
                    "modelUuid": "123",
                    "modelInvariantUuid": "",
                    "modelVersion": "",
                    "modelCustomizationUuid": "1234",
                    "modelInstanceName": "test"
                },
                "toscaNodeType": "",
                "nfFunction": "",
                "nfType": "",
                "nfRole": "",
                "nfNamingCode": "",
                "multiStageDesign": "",
                "resourceInput": "",
                "vfModules": [],
                "groups": [
                    {
                        "modelInfo": {
                            "modelName": "test",
                            "modelUuid": "11",
                            "modelInvariantUuid": "11",
                            "modelVersion": "2"
                        },
                        "vnfcs": [
                            {
                                "modelInfo": {
                                    "modelName": "xfs",
                                    "modelUuid": "22",
                                    "modelInvariantUuid": "2222",
                                    "modelVersion": "22222",
                                    "modelCustomizationUuid": "2222"
                                }
                            }
                        ]
                    }
                ]
            }
        ],
        "serviceNetworks": [],
        "serviceAllottedResources": []
    }
}

Issue-ID: SO-1393
Change-Id: Iee7f79337f73276f857d6d42b5b2416e4e8f4536
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
5 years agoRemoved imports and defined a constant. 55/86355/1
NITIN KAWA [Fri, 26 Apr 2019 06:07:05 +0000 (06:07 +0000)]
Removed imports and defined a constant.
Removed imports and defined constant and combined exception in single
catch block.
Issue-ID: SO-1490

Change-Id: Iefeb59de5b5e32b06908e62ba24a1bc00892ce1d
Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
5 years agoMerge changes Iea43b256,Ibabb3f5e,I65623121
subhash kumar singh [Fri, 26 Apr 2019 05:17:15 +0000 (05:17 +0000)]
Merge changes Iea43b256,Ibabb3f5e,I65623121

* changes:
  update the interface flows in SO
  Fix the FAQ page location
  update SO release notes in readthedocs

5 years agoRemoved unused imports and rearranged variables 48/86348/1
NITIN KAWA [Fri, 26 Apr 2019 04:47:43 +0000 (04:47 +0000)]
Removed unused imports and rearranged variables
Removed unused imports and moved variables to comply with Java Code Conventions.
Issue-ID: SO-1490

Change-Id: Iabf605fde63638244c2c4fd52e4787863512ee57
Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
5 years agoMerge "Reorder modifiers. Reorder modifiers to complt with Java code specifications...
Seshu Kumar M [Thu, 25 Apr 2019 14:58:16 +0000 (14:58 +0000)]
Merge "Reorder modifiers. Reorder modifiers to complt with Java code specifications Issue-ID: SO-1490"

5 years agoMerge "Reorder java modifiers. Reorder modifiers to complt with Java code specificati...
Seshu Kumar M [Thu, 25 Apr 2019 14:54:39 +0000 (14:54 +0000)]
Merge "Reorder java modifiers. Reorder modifiers to complt with Java code specifications Issue-ID: SO-1490"

5 years agoMerge "Reorder modifiers. Reorder modifiers to complt with Java code specifications...
Seshu Kumar M [Thu, 25 Apr 2019 14:49:42 +0000 (14:49 +0000)]
Merge "Reorder modifiers. Reorder modifiers to complt with Java code specifications Issue-ID: SO-1490"

5 years agoupdate the interface flows in SO 02/86302/1
seshukm [Thu, 25 Apr 2019 14:37:11 +0000 (20:07 +0530)]
update the interface flows in SO

Issue-ID: SO-675

Change-Id: Iea43b256422af69e6dcbbdb9282a125a6bfef0e8
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoFix the FAQ page location 95/86295/1
seshukm [Thu, 25 Apr 2019 13:43:48 +0000 (19:13 +0530)]
Fix the FAQ page location

Issue-ID: SO-675

Change-Id: Ibabb3f5e2c381f6bd7772aaed50a44e556460815
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoupdate SO release notes in readthedocs 94/86294/1
seshukm [Thu, 25 Apr 2019 13:39:32 +0000 (19:09 +0530)]
update SO release notes in readthedocs

Issue-ID: SO-675

Change-Id: I65623121b952ad88d48c196fc45d05fae28de4b1
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
5 years agoReorder modifiers. 91/86291/1
h00397475 [Thu, 25 Apr 2019 13:30:55 +0000 (19:00 +0530)]
Reorder modifiers.
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490

Change-Id: I5d5e0d0520c5a5c1e90033df3d185ce95a01ca0d
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoReorder java modifiers. 82/86282/1
h00397475 [Thu, 25 Apr 2019 12:48:36 +0000 (18:18 +0530)]
Reorder java modifiers.
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490

Change-Id: Idcd8c8dcd2a664310007d3e965700363672cbea3
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoReorder modifiers. 78/86278/1
h00397475 [Thu, 25 Apr 2019 12:24:20 +0000 (17:54 +0530)]
Reorder modifiers.
Reorder modifiers to complt with Java code specifications
Issue-ID: SO-1490

Change-Id: Ic8adde29c0bc8b3d039e3f0f1c8837f53dd10aee
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Sniro BB now supports sole service proxies"
Steve Smokowski [Thu, 25 Apr 2019 12:04:33 +0000 (12:04 +0000)]
Merge "Sniro BB now supports sole service proxies"

5 years agoMerge "Add SO update config file -application.yaml file"
Steve Smokowski [Thu, 25 Apr 2019 12:04:24 +0000 (12:04 +0000)]
Merge "Add SO update config file -application.yaml file"

5 years agoRemoval of unused variables and replace type specification. 73/86273/1
h00397475 [Thu, 25 Apr 2019 12:01:25 +0000 (17:31 +0530)]
Removal of unused variables and replace type specification.
Removal of unused local variables. Replace type specifications with diamond operator as per guide lines.
Issue-ID: SO-1490

Change-Id: I728287427c0f6f9e8289fb0dfa8e906856c774ff
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoFixed issues found in integration testing 55/86255/2
MichaelMorris [Thu, 25 Apr 2019 11:31:45 +0000 (11:31 +0000)]
Fixed issues found in integration testing

Issue-ID: SO-1814
Change-Id: Ica6929e10cb40d535657eefc9786090af996ba32
Signed-off-by: MichaelMorris <michael.morris@est.tech>
5 years agoMerge "add resourceInput in vnfc Issue-ID: SO-1393"
Yan Yang [Thu, 25 Apr 2019 11:29:19 +0000 (11:29 +0000)]
Merge "add resourceInput in vnfc Issue-ID: SO-1393"

5 years agoDefine constant in place of literals 64/86264/1
h00397475 [Thu, 25 Apr 2019 10:26:53 +0000 (15:56 +0530)]
Define constant in place of literals
Constants are declared and used in place of literals
Issue-ID: SO-1490

Change-Id: I8891e3aad24b29b4c951d995df0192437304d06e
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoRemoved generic type from right triangle. 63/86263/1
NITIN KAWA [Thu, 25 Apr 2019 10:05:21 +0000 (10:05 +0000)]
Removed generic type from right triangle.
Removed generic type from right triangle which is not recommended after
java 7
Issue-ID: SO-1490

Change-Id: I350be426a47e83246d248e8c31c786740bded1d9
Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
5 years agoMerge "String literal to be on the left side of string compariosion."
Seshu Kumar M [Thu, 25 Apr 2019 10:02:39 +0000 (10:02 +0000)]
Merge "String literal to be on the left side of string compariosion."

5 years agoMerge "SDNCRestClient - sonar fixes"
Seshu Kumar M [Thu, 25 Apr 2019 10:01:38 +0000 (10:01 +0000)]
Merge "SDNCRestClient - sonar fixes"

5 years agoMerge "MsoVnfAdapterImpl - sonar fix"
Seshu Kumar M [Thu, 25 Apr 2019 10:00:22 +0000 (10:00 +0000)]
Merge "MsoVnfAdapterImpl - sonar fix"

5 years agoString literal to be on the left side of string compariosion. 54/86254/1
h00397475 [Thu, 25 Apr 2019 09:07:50 +0000 (14:37 +0530)]
String literal to be on the left side of string compariosion.

String literal should be on the left side of string comparision as per guidelines.

Issue-ID: SO-1490

Change-Id: I294cbbb2fe7dae9c68b7b20e9b3a0d1d75824ba0
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoRemoval of unused local variables. 39/86239/1
NITIN KAWA [Thu, 25 Apr 2019 07:00:31 +0000 (07:00 +0000)]
Removal of unused local variables.
Removed useless assignment to local variables and reordered the modifiers
as per java language specification.
Issue-ID: SO-1490

Change-Id: I43f25854d60cd25fb472618e21f2c1c91bc1c457
Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
5 years agoAdd SO update config file -application.yaml file 04/86204/1
Bonkur, Venkat (vb8416) [Wed, 24 Apr 2019 20:43:15 +0000 (16:43 -0400)]
Add SO update config file -application.yaml file

Added to Dublin branch- update the catalog-db-adapter -application.yaml file
Remove the below line for flyway so that repeatable scripts are run.
 repeatableSqlMigrationPrefix: RATT
Issue-ID: SO-1804
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I54bd6d178d9f4c6854421f099bf393599d46d58f

5 years agoMsoVnfAdapterImpl - sonar fix 99/86199/1
Driptaroop Das [Wed, 24 Apr 2019 20:26:39 +0000 (01:56 +0530)]
MsoVnfAdapterImpl - sonar fix

MsoVnfAdapterImpl - sonar fix

Issue-ID: SO-1811
Change-Id: Ic3bebd30e4f65b9ba5732c43cfd8baf0050e3b7b
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoSDNCRestClient - sonar fixes 97/86197/1
Driptaroop Das [Wed, 24 Apr 2019 20:17:36 +0000 (01:47 +0530)]
SDNCRestClient - sonar fixes

SDNCRestClient - sonar fixes

Issue-ID: SO-1811
Change-Id: I7348e35a325c523648696a2321d873f481a0b36d
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoMerge "Remove the literal boolean values."
Seshu Kumar M [Wed, 24 Apr 2019 16:23:39 +0000 (16:23 +0000)]
Merge "Remove the literal boolean values."

5 years agoMerge "Define constant in place of literals"
Seshu Kumar M [Wed, 24 Apr 2019 16:17:48 +0000 (16:17 +0000)]
Merge "Define constant in place of literals"

5 years agoMerge "Define constant in place of repeating literals."
Seshu Kumar M [Wed, 24 Apr 2019 16:14:40 +0000 (16:14 +0000)]
Merge "Define constant in place of repeating literals."

5 years agoMerge "removal of unused file imports. removal of unused file imports. Issue-ID:...
Seshu Kumar M [Wed, 24 Apr 2019 16:12:42 +0000 (16:12 +0000)]
Merge "removal of unused file imports. removal of unused file imports. Issue-ID: SO-1490"

5 years agoMerge "Replace literals with constants. Replace repeated string literals with constan...
Seshu Kumar M [Wed, 24 Apr 2019 16:11:54 +0000 (16:11 +0000)]
Merge "Replace literals with constants. Replace repeated string literals with constants as per guidelines. Issue-ID: SO-1490"

5 years agoMerge "Change static string litral. Change static string litrals name according to...
Seshu Kumar M [Wed, 24 Apr 2019 16:10:10 +0000 (16:10 +0000)]
Merge "Change static string litral. Change static string litrals name according to the guidelines. Issue-ID: SO-1490"

5 years agoMerge "Configuration object status to Inventoried"
Seshu Kumar M [Wed, 24 Apr 2019 16:08:21 +0000 (16:08 +0000)]
Merge "Configuration object status to Inventoried"

5 years agoConfiguration object status to Inventoried 58/86158/1
Benjamin, Max (mb388a) [Mon, 22 Apr 2019 00:28:38 +0000 (20:28 -0400)]
Configuration object status to Inventoried

Set initial OrchestrationStatus of Configuration object to Inventoried
After Assign call, we need to set the configuration orchestration status
to Assigned

Change-Id: I4abaeb18d1d220b2bdd03269b3b5a2aba478bf64
Issue-ID: SO-1796
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRemoval of unused local variables. 27/86127/2
NITIN KAWA [Wed, 24 Apr 2019 08:43:56 +0000 (08:43 +0000)]
Removal of unused local variables.
Removal of unused local guidelines as per guidelines.
Issue-ID: SO-1490

Change-Id: I54df34d24a88b5cf7a4e3f0a222ff334b85ebe83
Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
5 years agoChange static string litral. 26/86126/1
h00397475 [Wed, 24 Apr 2019 08:39:10 +0000 (14:09 +0530)]
Change static string litral.
Change static string litrals name according to the guidelines.
Issue-ID: SO-1490

Change-Id: Iadabb204c5615f3bc559076999429bc0b9f615f6
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoReplace literals with constants. 18/86118/1
h00397475 [Wed, 24 Apr 2019 06:48:41 +0000 (12:18 +0530)]
Replace literals with constants.
Replace repeated string literals with constants as per guidelines.
Issue-ID: SO-1490

Change-Id: Iffd4f5349f5e5c11daeb2ec76a75125c38a3e867
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoremoval of unused file imports. 16/86116/1
Subhosree Pan [Wed, 24 Apr 2019 06:04:54 +0000 (06:04 +0000)]
removal of unused file imports.
removal of unused file imports.
Issue-ID: SO-1490

Change-Id: I35c09f25f363c7da276beece4fff854f8f42a2f8
Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
5 years agoadd resourceInput in vnfc 36/86036/2
zm330 [Tue, 23 Apr 2019 10:08:56 +0000 (18:08 +0800)]
add resourceInput in vnfc
Issue-ID: SO-1393

Change-Id: I643f49df545bef92f0f0e931f7b7ce1a5dbc21c0
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
5 years agoRemove the literal boolean values. 92/86092/1
Driptaroop Das [Tue, 23 Apr 2019 20:20:41 +0000 (01:50 +0530)]
Remove the literal boolean values.

Remove the literal boolean values.

Issue-ID: SO-1811
Change-Id: Iaa565b92cce2b6c8eddb77aff93491014cb7d7a3
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
5 years agoSniro BB now supports sole service proxies 68/85268/2
Benjamin, Max (mb388a) [Sun, 14 Apr 2019 13:21:10 +0000 (09:21 -0400)]
Sniro BB now supports sole service proxies

Enhanced sniro BB to account for sole service proxies to support 1908.

Change-Id: I4bf57c7c43de755be03d2284cde321d182255ceb
Issue-ID: SO-1790
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoDefine constant in place of repeating literals. 50/86050/1
h00397475 [Tue, 23 Apr 2019 13:03:39 +0000 (18:33 +0530)]
Define constant in place of repeating literals.

Constant is defined and used further instead of using the same literal.

Issue-ID: SO-1490

Change-Id: Icabbd5074d8fb72643b8b73eba78d11507eefe1a
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Define constants in place of repeated literals Defined constants to avoid...
Seshu Kumar M [Tue, 23 Apr 2019 13:02:39 +0000 (13:02 +0000)]
Merge "Define constants in place of repeated literals Defined constants to avoid repeated use of literals Issue-ID: SO-1490 bash: c: command not found"

5 years agoDefine constant in place of literals 45/86045/1
h00397475 [Tue, 23 Apr 2019 12:39:17 +0000 (18:09 +0530)]
Define constant in place of literals

Constants are declared and used in place of literals

Issue-ID: SO-1490

Change-Id: I674b250fa3e141deea5c4b6c43d6fa94733f0b67
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Define constant for String literal"
Seshu Kumar M [Tue, 23 Apr 2019 11:50:45 +0000 (11:50 +0000)]
Merge "Define constant for String literal"

5 years agoMerge "Remove unused private field and replace repeated string with constants."
Seshu Kumar M [Tue, 23 Apr 2019 11:49:26 +0000 (11:49 +0000)]
Merge "Remove unused private field and replace repeated string with constants."

5 years agoMerge "Define constant in place of repeated literals."
Seshu Kumar M [Tue, 23 Apr 2019 11:48:38 +0000 (11:48 +0000)]
Merge "Define constant in place of repeated literals."

5 years agoMerge "Fix issue where null variable causes task to not" into dublin
Steve Smokowski [Tue, 23 Apr 2019 11:34:52 +0000 (11:34 +0000)]
Merge "Fix issue where null variable causes task to not" into dublin

5 years agoDefine constants in place of repeated literals 40/86040/1
h00397475 [Tue, 23 Apr 2019 10:55:42 +0000 (16:25 +0530)]
Define constants in place of repeated literals
Defined constants to avoid repeated use of literals
Issue-ID: SO-1490
bash: c: command not found

Change-Id: I6e3808fc462c9c87f5cfbe81f39aad3187b49930
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Declare constant for String literal"
Seshu Kumar M [Tue, 23 Apr 2019 10:42:12 +0000 (10:42 +0000)]
Merge "Declare constant for String literal"

5 years agoMerge "Reorder modifiers to comply with java standards"
Seshu Kumar M [Tue, 23 Apr 2019 10:26:38 +0000 (10:26 +0000)]
Merge "Reorder modifiers to comply with java standards"

5 years agoMerge "Shift constructor to comply with coding standards"
Seshu Kumar M [Tue, 23 Apr 2019 10:21:50 +0000 (10:21 +0000)]
Merge "Shift constructor to comply with coding standards"

5 years agoDefine constant in place of repeated literals. 37/86037/1
h00397475 [Tue, 23 Apr 2019 10:21:36 +0000 (15:51 +0530)]
Define constant in place of repeated literals.

Defined a constant instead of repeatedly using literals.

Issue-ID: SO-1490

Change-Id: I4fc4eddeebf42436d6198ba92d7c8bfa8f3394b0
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Moved base client to new location" into dublin
subhash kumar singh [Tue, 23 Apr 2019 10:21:27 +0000 (10:21 +0000)]
Merge "Moved base client to new location" into dublin

5 years agoMerge "Remove unused imports"
Seshu Kumar M [Tue, 23 Apr 2019 10:21:23 +0000 (10:21 +0000)]
Merge "Remove unused imports"

5 years agoMerge "Move variable,constructor to comply with standard"
Seshu Kumar M [Tue, 23 Apr 2019 10:13:41 +0000 (10:13 +0000)]
Merge "Move variable,constructor to comply with standard"

5 years agoRemove unused private field and replace repeated string with constants. 35/86035/1
h00397475 [Tue, 23 Apr 2019 09:59:12 +0000 (15:29 +0530)]
Remove unused private field and replace repeated string with constants.

Remove unused private field and replace repeated string with constants.

Change-Id: I2e68cfb5e7d83e626cb2e274b7ea2989352f2867
Issue-ID: SO-1490
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
5 years agoMerge "Remove unused variables from class file. Remove unused local variables from...
Seshu Kumar M [Tue, 23 Apr 2019 09:52:36 +0000 (09:52 +0000)]
Merge "Remove unused variables from class file. Remove unused local variables from class files. Issue-ID: SO-1490"

5 years agoMerge "Move String literal to left-hand side of equals"
Seshu Kumar M [Tue, 23 Apr 2019 09:51:49 +0000 (09:51 +0000)]
Merge "Move String literal to left-hand side of equals"