SP00501638 [Mon, 12 Mar 2018 10:33:05 +0000 (16:03 +0530)]
Sonar Major
Move the GUARD_BL_YAML string literal on the left side of this string comparison
DecisionPolicyController.java:L208
Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
Line Number:208
Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba
Issue-ID: POLICY-689
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
Pamela Dragosh [Tue, 13 Mar 2018 12:08:36 +0000 (12:08 +0000)]
Merge "Sonar Major"
Manamohan Satapathy [Tue, 13 Mar 2018 08:59:51 +0000 (14:29 +0530)]
Policy:Blocker
Use try-with-resources to close this JarFile:L264 L265
Issue-ID: POLICY-683
Link: https://sonar.onap.org/issues?myIssues=true&open=AWF91iwf8TZzbCgU6arv&resolved=false
Location:ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java
Change-Id: Ie9adb5b50dbb61c923bf73fa107fd19366f24304
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
SP00501638 [Tue, 13 Mar 2018 06:43:15 +0000 (12:13 +0530)]
Sonar Blocker
Use try-with-resources or close this BufferedWriter in a finally clause
FirewallConfigPolicy.java:107
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWF91ixe8TZzbCgU6ar2&resolved=false&severities=BLOCKER
Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicy.java
Change-Id: I0ab8bf61fb9a6eb32ebdb5fccb66a67a8ac36b77
Issue-ID: POLICY-687
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
SP00501638 [Tue, 13 Mar 2018 05:52:15 +0000 (11:22 +0530)]
Sonar Major
Merge this if statement with the enclosing one
CreateBrmsParamPolicy.java:L218
Sonar Link:
hhttps://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AV2blOqK5bp_wwmIUQqX&resolved=false&severities=MAJOR
Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsParamPolicy.java
Change-Id: I0f9885a2491735878d688a2c812afd15a052f481
Issue-ID: POLICY-686
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
rb7147 [Tue, 13 Mar 2018 04:13:25 +0000 (00:13 -0400)]
Fixed the SDK Junits and cleaned unused code
Moved file tmp object from try resources block. due to not closing the
stream the inputstream read by xacmlpolicyscanner ended with premature
file error.
Cleaned unused code.
Issue-ID: POLICY-584
Change-Id: I92c4d000d94a144736d9ac46db384785a7512593
Signed-off-by: rb7147 <rb7147@att.com>
SP00501638 [Mon, 12 Mar 2018 05:42:40 +0000 (11:12 +0530)]
Sonar Major
Move the null string literal on the left side of this string comparison
CreateFirewallController.java:L347
Sonar Link:
https://sonar.onap.org/project/issues?id=org.onap.policy.engine%3APolicyEngineSuite&myIssues=true&open=AWBFphN0-08if2a6vI7H&resolved=false&severities=MAJOR
Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java
Change-Id: I744a66f3622fb7db0933c7c7dabc520e859cff4d
Issue-ID: POLICY-685
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
bobbymander [Fri, 9 Mar 2018 20:46:58 +0000 (15:46 -0500)]
JUnit additions for BRMSGW
Issue-ID: POLICY-598
Change-Id: I90bee429a303b6fbc27272f3a1aa38d89d473e50
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 9 Mar 2018 20:34:42 +0000 (20:34 +0000)]
Merge "Use org.onap.aaf dependencies"
Jorge Hernandez [Fri, 9 Mar 2018 20:33:39 +0000 (20:33 +0000)]
Merge "Fix brmsgw regex handling for dependecies"
Pamela Dragosh [Fri, 9 Mar 2018 18:17:56 +0000 (13:17 -0500)]
Use org.onap.aaf dependencies
Move from github version to the onap version.
Issue-ID: POLICY-568
Change-Id: I30f91b07cb690e50e829c14725c1bf05a1f4200b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Fri, 9 Mar 2018 18:06:13 +0000 (18:06 +0000)]
Merge "Junits for ONAP-PDP module"
pa834y [Fri, 9 Mar 2018 17:13:30 +0000 (12:13 -0500)]
Fix brmsgw regex handling for dependecies
Issue-ID: POLICY-684
Change-Id: I3a8fbbaebf4fdfcd097edcc367e06ef8807aa3bc
Signed-off-by: pa834y <pa834y@att.com>
Pamela Dragosh [Fri, 9 Mar 2018 17:01:58 +0000 (17:01 +0000)]
Merge "JUnit additions for PAP-REST"
Jorge Hernandez [Fri, 9 Mar 2018 16:12:01 +0000 (16:12 +0000)]
Merge "ClientEndpoint needs to be instantiabe"
Jorge Hernandez [Fri, 9 Mar 2018 16:11:08 +0000 (16:11 +0000)]
Merge "Policy:Blocker"
Magnusen, Drew (dm741q) [Thu, 8 Mar 2018 18:34:11 +0000 (12:34 -0600)]
Junits for ONAP-PDP module
Added coverage for the FindAction class.
Issue-ID: POLICY-601
Change-Id: Id7fc2a75de65ff6182f662d2330095cd371d2c7e
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
bobbymander [Fri, 9 Mar 2018 15:55:51 +0000 (10:55 -0500)]
JUnit additions for PAP-REST
Issue-ID: POLICY-600
Change-Id: Id705865614faf42dfc604b1b88066122614f866c
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 9 Mar 2018 15:26:40 +0000 (15:26 +0000)]
Merge "Sonar Major"
Jorge Hernandez [Fri, 9 Mar 2018 15:25:41 +0000 (15:25 +0000)]
Merge "JUnit additions for PDP-REST,ONAP-SDK-APP"
Pamela Dragosh [Fri, 9 Mar 2018 14:20:46 +0000 (14:20 +0000)]
Merge "Change default log location per logging guidelines"
Pamela Dragosh [Fri, 9 Mar 2018 11:49:53 +0000 (11:49 +0000)]
Merge "Sonar Major"
SP00501638 [Fri, 9 Mar 2018 06:10:44 +0000 (11:40 +0530)]
Sonar Major
Remove this useless assignment to local variable temp
CreateNewMicroServiceModel.java:L195
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOqq5bp_wwmIUQr6&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java
Change-Id: Icdd79502962e1173d83bca442d2d739b058932ba
Issue-ID: POLICY-682
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
pa834y [Thu, 8 Mar 2018 21:21:54 +0000 (16:21 -0500)]
ClientEndpoint needs to be instantiabe
Issue-ID: POLICY-660
Change-Id: I0d377eb9d500218933217faeb224929548da0e5a
Signed-off-by: pa834y <pa834y@att.com>
bobbymander [Thu, 8 Mar 2018 19:44:49 +0000 (14:44 -0500)]
JUnit additions for PDP-REST,ONAP-SDK-APP
Issue-ID: POLICY-602
Change-Id: I354415df7292656d60ce573fb5b004f5de25899a
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Thu, 8 Mar 2018 19:36:08 +0000 (19:36 +0000)]
Merge "JUnit additions for BRMS,POLICY-SDK-APP"
Jorge Hernandez [Thu, 8 Mar 2018 19:32:54 +0000 (19:32 +0000)]
Merge "Sonar Major"
Jorge Hernandez [Thu, 8 Mar 2018 19:02:37 +0000 (13:02 -0600)]
Change default log location per logging guidelines
Change-Id: Ib45bbede0330c6bf5dd6461b2642321d8fdb49ad
Issue-ID: POLICY-554
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Pamela Dragosh [Thu, 8 Mar 2018 17:56:21 +0000 (17:56 +0000)]
Merge "configurable logs dir and creation as root"
mmis [Thu, 8 Mar 2018 12:22:17 +0000 (12:22 +0000)]
Remove filtering from packages/docker/pom
Filtering should not be applied in the maven-resources-plugin execution as
this incorecttly modifes the scripts copied by this plugin
Issue-ID: POLICY-652
Change-Id: I92c73af6830f81ee3fbcdda68333a67378ce08a2
Signed-off-by: mmis <michael.morris@ericsson.com>
bobbymander [Thu, 8 Mar 2018 12:15:14 +0000 (07:15 -0500)]
JUnit additions for BRMS,POLICY-SDK-APP
Issue-ID: POLICY-598
Change-Id: Ic3d9ca2a5f6c29f772bd747612d6c7caeb15eb7f
Signed-off-by: bobbymander <bobby.mander@att.com>
SP00501638 [Thu, 8 Mar 2018 10:03:13 +0000 (15:33 +0530)]
Sonar Major
Remove this useless assignment to local variable em
PolicyDBDao.java:L361
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOr_5bp_wwmIUQxy&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java
Change-Id: I2ef3046c1902768589db51127aaf320f94342a9c
Issue-ID: POLICY-679
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
SP00501638 [Thu, 8 Mar 2018 09:40:07 +0000 (15:10 +0530)]
Sonar Major
Remove this useless assignment to local variable xMessage
ElkConnectorImpl.java:L169
Sonar Link:
https://sonar.onap.org/issues?assignees=swapnalipode&open=AV2blOwt5bp_wwmIUREc&resolved=false
Location:
src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnectorImpl.java
Change-Id: Ia397ffa7cb93b8c1ce8f5f02a09685656c74ddc0
Issue-ID: POLICY-678
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
Jorge Hernandez [Thu, 8 Mar 2018 06:57:11 +0000 (06:57 +0000)]
Merge "Change ng-click to ng-change"
Jorge Hernandez [Thu, 8 Mar 2018 06:56:16 +0000 (06:56 +0000)]
Merge "JUnit additions for BRMS,API"
Manamohan Satapathy [Thu, 8 Mar 2018 06:51:51 +0000 (12:21 +0530)]
Policy:Blocker
Use try-with-resources or close this FileOutputStream in a finally clause.:L574 L575
Issue-ID: POLICY-656
Link: https://sonar.onap.org/issues?myIssues=true&resolved=false
Location:BRMSGateway\src\main\java\org\onap\policy\brmsInterface\BRMSPush.java
Change-Id: Id9ce5e5505bb3c622652cd7ff1e844519c9c786f
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
Jorge Hernandez [Thu, 8 Mar 2018 06:43:53 +0000 (00:43 -0600)]
configurable logs dir and creation as root
Change-Id: I9d5d1dcf97e8951c2c8a700b301bcc33410dd839
Issue-ID: POLICY-562
Signed-off-by: Jorge Hernandez <jh1730@att.com>
Pamela Dragosh [Wed, 7 Mar 2018 17:08:22 +0000 (17:08 +0000)]
Merge "Copy files for docker image in packages/docker/pom"
Wang,Frank(gw1218) [Tue, 6 Mar 2018 22:15:39 +0000 (16:15 -0600)]
Change ng-click to ng-change
The ng-click on MS version dropbox triggered event function even for the
same MS version and called the event function again after selected
a different version.
Issue-ID: POLICY-655
Change-Id: I4e007f08e574ddd7899f0fde133bda2cac1be7d5
Signed-off-by: guangxingwang <gw1218@att.com>
Signed-off-by: Wang, Frank(gw1218) <gw1218@att.com>
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>
Pamela Dragosh [Wed, 7 Mar 2018 14:16:13 +0000 (14:16 +0000)]
Merge "Clean up pom.xml and fix CLM"
bobbymander [Wed, 7 Mar 2018 12:15:08 +0000 (07:15 -0500)]
JUnit additions for BRMS,API
Issue-ID: POLICY-598
Change-Id: I6a41d510d95afd8538e7775fe12d6e07771dd307
Signed-off-by: bobbymander <bobby.mander@att.com>
mmis [Tue, 6 Mar 2018 16:36:00 +0000 (16:36 +0000)]
Copy files for docker image in packages/docker/pom
Copying the files in the pom removes the need to do the copying in various
locations the docker build is executed from and allows the docker image be
built without building the entire repo (as the install.zip can be pulled
from nexus)
Issue-ID: POLICY-652
Change-Id: I90498f7e0c00e63381d746f80f937b31b3f7199d
Signed-off-by: mmis <michael.morris@ericsson.com>
Jorge Hernandez [Tue, 6 Mar 2018 22:55:25 +0000 (22:55 +0000)]
Merge "PolicyApiUtils junits"
Jorge Hernandez [Tue, 6 Mar 2018 22:54:21 +0000 (22:54 +0000)]
Merge "JUnit workaround for PAP-REST, sonar bug"
Jorge Hernandez [Tue, 6 Mar 2018 22:52:03 +0000 (22:52 +0000)]
Merge "Add new constructor"
Magnusen, Drew (dm741q) [Thu, 1 Mar 2018 22:01:20 +0000 (16:01 -0600)]
PolicyApiUtils junits
Added some junits for the PolicyApiUtils class.
Issue-ID: POLICY-602
Change-Id: I393b636021c18d2406341f7fd8246fd342ab6f11
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
Determe, Sebastien (sd378r) [Tue, 6 Mar 2018 13:44:41 +0000 (14:44 +0100)]
Add new constructor
Add a new constructor to PolicyEngine to support Properties parameters
instead of a file.
Issue-ID: CLAMP-136
Change-Id: Id82a736cac8ac5603ff3627a9ce2ac5af4197a45
Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
bobbymander [Tue, 6 Mar 2018 14:53:30 +0000 (09:53 -0500)]
JUnit workaround for PAP-REST, sonar bug
Issue-ID: POLICY-600
Change-Id: I9d4d986b0703c67f65b67eedabca8d0d56965f2d
Signed-off-by: bobbymander <bobby.mander@att.com>
rb7147 [Tue, 6 Mar 2018 03:59:30 +0000 (22:59 -0500)]
Added Junits for POLICY-SDK-APP
Issue-ID: POLICY-600
Change-Id: Ib96b7ccede0fa09e71f02ff073c89682e9aa7089
Signed-off-by: rb7147 <rb7147@att.com>
Jorge Hernandez [Tue, 6 Mar 2018 02:37:08 +0000 (02:37 +0000)]
Merge "Remove auto generated rule to the drl"
Pamela Dragosh [Tue, 6 Mar 2018 01:36:59 +0000 (01:36 +0000)]
Merge "JUnit additions for PAP-REST"
Pamela Dragosh [Tue, 6 Mar 2018 01:34:18 +0000 (20:34 -0500)]
Clean up pom.xml and fix CLM
This has some cleanup for overriding managed dependencies, a
duplicate entry for mariadb, unnecessary inclusion of older
EELF library, an upgrade of swagger tools to fix a security
issue and lastly an override of a depedency to clear a
security issue.
Issue-ID: POLICY-507
Change-Id: I8767f6edc37551c559010d96d350afdd5961f13d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
bobbymander [Mon, 5 Mar 2018 19:56:44 +0000 (14:56 -0500)]
JUnit additions for PAP-REST
Issue-ID: POLICY-600
Change-Id: I59117fff52a2cd37c1260aafaae4ebe922053202
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Mon, 5 Mar 2018 19:52:50 +0000 (19:52 +0000)]
Merge "Upgrade commons-collection for security fix"
Jorge Hernandez [Mon, 5 Mar 2018 19:52:18 +0000 (19:52 +0000)]
Merge "Upgrade dmaap client with security fix"
Jorge Hernandez [Mon, 5 Mar 2018 18:23:34 +0000 (18:23 +0000)]
Merge "Update Dockerfile and docker_*.sh"
mmis [Mon, 5 Mar 2018 13:45:40 +0000 (13:45 +0000)]
Update Dockerfile and docker_*.sh
Correction to previous commit "Move docker_*.sh scripts into
policy/engine" as attempt to build docker image will result in failure to
pull the policy-base image from nexus
The policy-base and policy-os images are removed in favour of including
the contents of those images directly in the policy-pe image
Issue-ID: POLICY-624
Change-Id: Ie4a12407d4cb5a1d663cd11136c282a53f496ca3
Signed-off-by: mmis <michael.morris@ericsson.com>
pa834y [Fri, 2 Mar 2018 22:14:47 +0000 (17:14 -0500)]
Remove auto generated rule to the drl
Issue-ID: POLICY-488
Change-Id: Id6915407a6f030b77ae2d18ad3665af9d0feb34b
Signed-off-by: pa834y <pa834y@att.com>
Pamela Dragosh [Mon, 5 Mar 2018 15:25:41 +0000 (10:25 -0500)]
Upgrade commons-collection for security fix
Force use of 3.2.2 to clear security issue for commons
collections.
Issue-ID: POLICY-507
Change-Id: Id9ac1e07b90dfb6594cde5ba4cec4e3867f43a76
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
bobbymander [Mon, 5 Mar 2018 14:05:13 +0000 (09:05 -0500)]
JUnit addition/fix for PAP-REST
Issue-ID: POLICY-600
Change-Id: I342bc97f85739f73b0dac6aaea19f6f4b2ded470
Signed-off-by: bobbymander <bobby.mander@att.com>
Pamela Dragosh [Fri, 2 Mar 2018 20:28:58 +0000 (15:28 -0500)]
Upgrade dmaap client with security fix
Dmaap removed security issues.
Issue-ID: POLICY-618
Change-Id: Ied6051dd5eaec204a6d7806460410c3a3083c462
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 5 Mar 2018 01:59:45 +0000 (01:59 +0000)]
Merge "JUnit additions for SDK-APP"
bobbymander [Fri, 2 Mar 2018 19:29:37 +0000 (14:29 -0500)]
JUnit additions for SDK-APP
Issue-ID: POLICY-604
Change-Id: Ide34e02942a473c626b4f074113d235a3fdfccba
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 2 Mar 2018 19:17:18 +0000 (19:17 +0000)]
Merge "Move docker_*.sh scripts into policy/engine"
mmis [Thu, 1 Mar 2018 16:50:11 +0000 (16:50 +0000)]
Move docker_*.sh scripts into policy/engine
Add files for building policy-pe docker image
Issue-ID: POLICY-614
Change-Id: Id3e999e652c7c7c6092eb9bde76709cfa1c06c7b
Signed-off-by: mmis <michael.morris@ericsson.com>
bobbymander [Fri, 2 Mar 2018 15:17:28 +0000 (10:17 -0500)]
JUnit remove one flaky test for now
Issue-ID: POLICY-600
Change-Id: I8b32cb3658e9a145a6493639787abc0145a04991
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 2 Mar 2018 14:11:01 +0000 (14:11 +0000)]
Merge "Remove CLM issues with commons-collections"
Jorge Hernandez [Fri, 2 Mar 2018 01:47:18 +0000 (01:47 +0000)]
Merge "JUnit additions for PAP-REST,API"
Jorge Hernandez [Fri, 2 Mar 2018 01:46:48 +0000 (01:46 +0000)]
Merge "Added Junits for ONAP-SDK-APP"
Pamela Dragosh [Thu, 1 Mar 2018 23:00:06 +0000 (18:00 -0500)]
Remove CLM issues with commons-collections
We know that we are not configuring an LDAP PIP in our
use of the XACML open source. The LDAP implementation
uses Apache Velocity, which uses a very old version
of commons-collections that has security issues. So
we can exclude commons-collections from the build.
Issue-ID: POLICY-507
Change-Id: I735eae4fe507ad016d9b0b49e67536415edb9820
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 1 Mar 2018 20:12:03 +0000 (20:12 +0000)]
Merge "Added Junits for Policy PAP-REST"
bobbymander [Thu, 1 Mar 2018 19:59:12 +0000 (14:59 -0500)]
JUnit additions for PAP-REST,API
Issue-ID: POLICY-600
Change-Id: I68020230d370950c0323a544910ad54015e1a08a
Signed-off-by: bobbymander <bobby.mander@att.com>
rb7147 [Thu, 1 Mar 2018 19:51:58 +0000 (14:51 -0500)]
Added Junits for ONAP-SDK-APP
Issue-ID: POLICY-604
Change-Id: Ice9264ff38d51c5801cfeedcf7169cc26ca780f5
Signed-off-by: rb7147 <rb7147@att.com>
Michael Mokry [Thu, 1 Mar 2018 19:35:37 +0000 (13:35 -0600)]
Adding fix for BRMSGW issue
This should fix the issue with the BRMSGW getting notification to create
the rules jar
Change-Id: Ie575a0b4717c999b8ab9deecc667ceaba99e7327
Issue-ID: POLICY-660
Signed-off-by: Michael Mokry <mm117s@att.com>
rb7147 [Wed, 28 Feb 2018 19:23:12 +0000 (14:23 -0500)]
Added Junits for Policy PAP-REST
Issue-ID: POLICY-600
Change-Id: Icb67ac587e614f663416b3ea0a03ca6e5b02c621
Signed-off-by: rb7147 <rb7147@att.com>
Jorge Hernandez [Thu, 1 Mar 2018 16:36:15 +0000 (16:36 +0000)]
Merge "JUnit additions for PAP-REST,REST,XACML"
bobbymander [Wed, 28 Feb 2018 21:31:24 +0000 (16:31 -0500)]
JUnit additions for PAP-REST,REST,XACML
Issue-ID: POLICY-603
Change-Id: I78c5e302c474613cbb22a80e0d931b4f47dd3b63
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Thu, 1 Mar 2018 05:02:34 +0000 (05:02 +0000)]
Merge "More junits for PDP-REST"
Jorge Hernandez [Wed, 28 Feb 2018 16:48:35 +0000 (16:48 +0000)]
Merge "JUnit additions for ONAP-PAP-REST"
Jorge Hernandez [Wed, 28 Feb 2018 16:46:59 +0000 (16:46 +0000)]
Merge "Added Junits for Policy PAP-REST"
Magnusen, Drew (dm741q) [Tue, 27 Feb 2018 20:47:22 +0000 (14:47 -0600)]
More junits for PDP-REST
More junits for the org.onap.policy.pdp.rest.impl/jmx packages.
Issue-ID: POLICY-602
Change-Id: I2af2fc3280314a8d6c1e9c352eda042c7fea7932
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
bobbymander [Wed, 28 Feb 2018 13:58:56 +0000 (08:58 -0500)]
JUnit additions for ONAP-PAP-REST
Issue-ID: POLICY-600
Change-Id: I6e458335b04b88146d88fea2f6fd908779d842fc
Signed-off-by: bobbymander <bobby.mander@att.com>
Pamela Dragosh [Wed, 28 Feb 2018 12:18:17 +0000 (12:18 +0000)]
Merge "remove mariadb superuser sql statements"
Jorge Hernandez [Tue, 27 Feb 2018 21:56:08 +0000 (21:56 +0000)]
Merge "JUnit additions for XACML,REST,POLICY-SDK"
Jorge Hernandez [Tue, 27 Feb 2018 21:14:14 +0000 (15:14 -0600)]
remove mariadb superuser sql statements
PE installation as part of data upgrade invokes
"set global" statements that are typically used
by priviledged accounts as the "root" mariadb user.
As part of the effort to clean up the mariadb docker install,
only permissions to a regular mariadb user (policy_user by default)
are given in 3 databases: onap_sdk, log, and support.
This account cannot do changes outside those.
In any case the usage of the global timeouts is questionable.
We should keep an eye if there's any potential bad side effect,
and correct it if it doesn't. It's preferable to keep
"policy_user" with a restricted set of privileges, instead
of being a superuser (otherwise can plainly user the root account).
Change-Id: I17b1a6a2cb62a319464e1db4b3aafbc1dbf20d78
Issue-ID: POLICY-650
Signed-off-by: Jorge Hernandez <jh1730@att.com>
rb7147 [Tue, 27 Feb 2018 17:09:16 +0000 (12:09 -0500)]
Added Junits for Policy PAP-REST
Issue-ID: POLICY-600
Change-Id: I1d42a3a880c9d81115d48794a77fadb89562e136
Signed-off-by: rb7147 <rb7147@att.com>
Pamela Dragosh [Tue, 27 Feb 2018 19:58:51 +0000 (19:58 +0000)]
Merge "Add Junit to policy/engine LogParser package"
Pamela Dragosh [Tue, 27 Feb 2018 19:57:34 +0000 (19:57 +0000)]
Merge "Policy:Major"
bobbymander [Tue, 27 Feb 2018 18:51:51 +0000 (13:51 -0500)]
JUnit additions for XACML,REST,POLICY-SDK
Issue-ID: POLICY-584
Change-Id: I4bb91b18122c7f61bb71b1a9e39d51cd65af70bd
Signed-off-by: bobbymander <bobby.mander@att.com>
rb7147 [Mon, 26 Feb 2018 23:04:46 +0000 (18:04 -0500)]
Code Clean Up for Policy PAP-REST
Cleaned the duplicate code for all dictionary controllers and created
Utils class.
Issue-ID: POLICY-600
Change-Id: I65b8574d9f667758407515a5c55bc28f636be477
Signed-off-by: rb7147 <rb7147@att.com>
Manamohan Satapathy [Tue, 27 Feb 2018 10:49:19 +0000 (16:19 +0530)]
Policy:Major
Local variables should not shadow class field:L992 L1719
Issue-ID: POLICY-649
Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL
Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java
Change-Id: I1d038829867c7d019473909650946a9539b5e736
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
ramverma [Tue, 27 Feb 2018 09:55:18 +0000 (09:55 +0000)]
Add Junit to policy/engine LogParser package
Test cases to improve the coverage of LogParser to 72%
Change-Id: Idbf9dbbc7254d2ba4d6953852d7847b5070dd4d4
Issue-ID: POLICY-599
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Pamela Dragosh [Mon, 26 Feb 2018 20:17:36 +0000 (20:17 +0000)]
Merge "Added junits to increase coverage"
MAGNUSEN [Mon, 26 Feb 2018 15:19:16 +0000 (09:19 -0600)]
Added junits to increase coverage
This commit adds some junits which touch several classes in the
notifications package in the ONAP-PDP-REST project.
Issue-ID: POLICY-602
Change-Id: Ie99ddd03841d4063aba64781bf08a38d2a25f0ed
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
bobbymander [Mon, 26 Feb 2018 18:11:34 +0000 (13:11 -0500)]
JUnit additions for BRMS,PDP-REST,REST
Issue-ID: POLICY-598
Change-Id: I397ed925bdb43a4b2f7a94cc4692b6506f650ede
Signed-off-by: bobbymander <bobby.mander@att.com>
bobbymander [Fri, 23 Feb 2018 19:14:15 +0000 (14:14 -0500)]
JUnit additions for PDP,PDP-REST
Issue-ID: POLICY-600
Change-Id: Ia5584011cbd42b9b49953d714efbeb5956b9b295
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 23 Feb 2018 19:48:14 +0000 (19:48 +0000)]
Merge "Fix Fortify Issue - External Entity Injection"
Jorge Hernandez [Fri, 23 Feb 2018 19:43:52 +0000 (19:43 +0000)]
Merge "Add JUnit tests policy/engine PolicyEngineAPI"
guangxingwang [Thu, 22 Feb 2018 21:13:17 +0000 (15:13 -0600)]
Fix Fortify Issue - External Entity Injection
Fix Fortify Issue by setting secure process of factory as true
Issue-ID: POLICY-551
Change-Id: I46890d2664d0ae9ed9540ba830d0f4b27136a6e9
Signed-off-by: guangxingwang <gw1218@att.com>
waqas.ikram [Fri, 23 Feb 2018 11:17:30 +0000 (11:17 +0000)]
Add JUnit tests policy/engine PolicyEngineAPI
Change-Id: I8d7a76836759b042c83349c2b875fb77085b531c
Issue-ID: POLICY-606
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>