emaclee [Mon, 4 Jul 2022 21:49:41 +0000 (22:49 +0100)]
Move persistence methods from NCMPproperty handler
Issue-ID: CPS-1117
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: If6a0c620970a2a34a601267c6610f85e4bc07f60
emaclee [Tue, 28 Jun 2022 12:13:21 +0000 (13:13 +0100)]
Move persistence related methods
-created new method in inventory persistence service for getting module
references
Issue-ID: CPS-1117
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ic1f3c180a62a7211e19982d8f3570829db58370e
Toine Siebelink [Mon, 4 Jul 2022 11:18:17 +0000 (11:18 +0000)]
Merge "Fix: cps-ncmp-rest-stub implement new methods"
lukegleeson [Mon, 4 Jul 2022 09:09:35 +0000 (10:09 +0100)]
Fix: cps-ncmp-rest-stub implement new methods
Override getModuleDefinitionsByCmHandleId
Override getModuleReferencesByCmHandle
Issue-ID: CPS-1094
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I3e4f91602f338e6f22eaf89212cf31a1e7af0c33
Joseph Keenan [Mon, 4 Jul 2022 09:11:58 +0000 (09:11 +0000)]
Merge "Simplified 'External' lock reason Mapping"
lukegleeson [Tue, 28 Jun 2022 11:15:33 +0000 (12:15 +0100)]
Simplified 'External' lock reason Mapping
Refactored LOCKED_MISBEHAVING -> LOCKED_MODULE_SYNC_FAILED
CompositeStateMapper will change internal reason LOCKED_MODULE_SYNC_FAILED to external reason LOCKED_MISBEHAVING for client payloads
Changed openapi description of lock-reason to reflect only enum currently available LOCKED_MISBEHAVING
Issue-ID: CPS-1099
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I9cda45f6c30b94684ee1c8ad0c49e35a3a824d52
Joseph Keenan [Mon, 4 Jul 2022 05:59:03 +0000 (05:59 +0000)]
Merge "Add Logging to specify next retry"
DylanB95EST [Fri, 1 Jul 2022 15:38:14 +0000 (16:38 +0100)]
Add Logging to specify next retry
Adding logging to specify the next time in minutes
until the retry mechanism will attempt to unlock
the cm handle if it is not yet ready to be unlocked
Issue-ID: CPS-1076
Change-Id: Ic2b011966c779f13ad8380ebfd7d4b4354e6b3e1
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Fri, 1 Jul 2022 15:59:33 +0000 (15:59 +0000)]
Merge "Modify Unit test for module definition"
emaclee [Fri, 1 Jul 2022 15:42:27 +0000 (16:42 +0100)]
Modify Unit test for module definition
Issue-ID: CPS-1064
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I9f17d95ba6fb2c7be5a10b1612bcc8db69f8a64d
Toine Siebelink [Fri, 1 Jul 2022 15:40:56 +0000 (15:40 +0000)]
Merge "cps-ncmp-rest-stub can not be compiled and executed"
Toine Siebelink [Fri, 1 Jul 2022 09:54:52 +0000 (09:54 +0000)]
Merge "use separated get methods for every cmHandle instead of one "get all" query"
puthuparambil.aditya [Mon, 27 Jun 2022 15:11:36 +0000 (16:11 +0100)]
cps-ncmp-rest-stub can not be compiled and executed
Issue-ID: CPS-1094
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I2cd010e0bbe140198db22cf1f62cc8b0b9c80729
kissand [Thu, 30 Jun 2022 10:14:56 +0000 (12:14 +0200)]
use separated get methods for every cmHandle instead of one "get all"
query
Issue-ID: CPS-1085
Change-Id: Ifac152f606b25b7a7d143315dba6d73698ef914e
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Fri, 1 Jul 2022 08:08:14 +0000 (08:08 +0000)]
Merge "Allow Module Re-Sync"
lukegleeson [Mon, 27 Jun 2022 15:26:21 +0000 (16:26 +0100)]
Allow Module Re-Sync
Allows the Resync of an already synced CmHandle
Currently: Advised -(create schemaset)-> Ready -(manual write)-> Advised -> Locked as schemaset for cmhandle already exists
With this: Advised -(create schemaset)-> Ready -(manual write)-> Advised -(delete schemaset, create schemaset)-> Ready
Included some logging
Renamed ModuleSyncSpec -> ModuleSyncWatchdogSpec to match class
Issue-ID: CPS-1045
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I408fbea698b7926dbf5d0cddc74acf1b00235b1f
sourabh_sourabh [Wed, 29 Jun 2022 11:36:40 +0000 (12:36 +0100)]
Composite state transition code change
- Code cannge to set datastore to Unsynchronized when state moves from advice to ready
- if resource data is not available or there is any issue while reading
data from simulator then state will be set to synchronized else remain
unsynchronized.
- Handle serialization failure on empty bean.
Issue-ID: CPS-1000
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ie51a787770da649e00aaefc00341756f92f9fa83
emaclee [Fri, 17 Jun 2022 16:42:56 +0000 (17:42 +0100)]
Add method to get YANG module sources for CM handle
- part of this commit includes renaming the enum SyncState to
DataStoreSyncState
Issue-ID: CPS-1064
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I6bf419141a1b33f09871946445cdfff422c8c354
Joseph Keenan [Thu, 30 Jun 2022 10:06:53 +0000 (10:06 +0000)]
Merge "Fix performance degradation bug"
Toine Siebelink [Thu, 30 Jun 2022 08:55:31 +0000 (08:55 +0000)]
Merge "Retry Module-Sync based on from last failure"
Toine Siebelink [Thu, 30 Jun 2022 08:43:50 +0000 (08:43 +0000)]
Merge "Kafka consumer can not be turned off"
JosephKeenan [Thu, 16 Jun 2022 15:19:09 +0000 (16:19 +0100)]
Kafka consumer can not be turned off
-NOTE: Build will fail until docker-compose version issues on build
server are fixed
--Ticket raised https://jira.linuxfoundation.org/plugins/servlet/theme/portal/2/IT-24219
-added flag for async
-added response if async is triggered without being enabled & associated test
-modified to use one global flag for notifications
Issue-ID: CPS-1088
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Change-Id: If9d988b4dcb71bf37c1b1bf9464090782708ffc2
kissand [Tue, 28 Jun 2022 15:08:33 +0000 (16:08 +0100)]
Fix performance degradation bug
- do NOT use cpsPath query for gettign individual CM Handles
- change order of queries for more efficency (property query first)
Issue-ID: CPS-1085
Change-Id: Ia3bdf4f0d245a2b128557352685d2aa17c1f939c
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
lukegleeson [Thu, 2 Jun 2022 09:56:43 +0000 (10:56 +0100)]
Get cm-handle state endpoint
Added new get cm-handle state endpoint
Refactored RestOutputCmHandleState to CmHandleCompositeState
Created new RestOutputCmHandleCompositeState OpenApi object
^This is done so that we get '"state: {" at the start of JSON response
Refactored RestOutputCmHandleStateMapper to CmHandleStateMapper
Added more detailed composite state to get cmHandleDetails endpoint tests
Rebased code
Code rebased on top of 129658: Unable to change state from LOCKED to ADVISED | https://gerrit.onap.org/r/c/cps/+/129658 which fixes output error
Issue-ID: CPS-1019
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I361117c98c256a4aa578c13d21926bc6d7876a15
DylanB95EST [Mon, 20 Jun 2022 12:45:19 +0000 (13:45 +0100)]
Retry Module-Sync based on from last failure
Retry algorithm for module-sync based on last failure
Poll Lock Reason, check if lock has surpassed minimum time
based on last update time and lock reason
Issue-ID: CPS-1076
Change-Id: Ifbbabd2b403f88f1bbe3fae3f125b1e9cb2091aa
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
sourabh_sourabh [Mon, 27 Jun 2022 13:08:03 +0000 (14:08 +0100)]
Unable to change state from LOCKED to ADVISED
-Refactor Cm Handle Registration to deal with null
pointer during Module Sync Retry
-Add Last Update Time to cm handle registration
-Add Fetch Descendants Option as paramater
for get misbehaving locked cm handles
-Fixes issue when state that goes to advised
after retry mechanism won't be retried again
Issue-ID: CPS-1097
Change-Id: Iffe1cef3479a796ea5c78b293a0bd24a86d13efd
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Joseph Keenan [Mon, 27 Jun 2022 10:08:47 +0000 (10:08 +0000)]
Merge "Introducing DELETING and DELETED Cmhandle State"
mpriyank [Thu, 23 Jun 2022 14:14:31 +0000 (15:14 +0100)]
Remove operation from NcmpEvent
- Remove operation field from NcmpEvent schema as it is not required
- Code refactoring corresponding to removal of operation field
- Fixed test cases around it
- UPCOMING: Some sort of state machine to handle the event publishing
Issue-ID: CPS-1100
Change-Id: Ib89b86bd1408de2808b01d37a48ee44a2601f83d
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
lukegleeson [Thu, 23 Jun 2022 11:33:24 +0000 (12:33 +0100)]
Introducing DELETING and DELETED Cmhandle State
Issue-ID: CPS-1101
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: I527b47cd98150a753c0d7ba89332a52b414b6834
sourabh_sourabh [Mon, 20 Jun 2022 14:57:24 +0000 (15:57 +0100)]
Data Sync Watchdog Process
- Get all the Cm Handles state in READY and Operational datastores sync state in UNSYNCHRONIZED
- Get a random Cm Handle
- Get the first resource data from the node
- Save the data in Cps Db
- Update the Operational datastores sync state to SYNCHRONIZED
Issue-ID: CPS-1052
Issue-ID: CPS-1053
Issue-ID: CPS-1054
Change-Id: I9a20391ef30e6d56c4d789a92b8bf42cd3756c62
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Joseph Keenan [Wed, 22 Jun 2022 09:16:56 +0000 (09:16 +0000)]
Merge "Eliminate cmhandle-properties tag"
Toine Siebelink [Tue, 21 Jun 2022 17:03:26 +0000 (17:03 +0000)]
Merge "Quick fix for performance degradation bug"
mpriyank [Tue, 21 Jun 2022 15:31:23 +0000 (16:31 +0100)]
Eliminate cmhandle-properties tag
- Eliminate the cmhandle-properties tag in case of DELETE operation
- Fixed Test cases corresponding to that
Issue-ID: CPS-1098
Change-Id: Icd5e08403e0b101baf682f5e558c36ee4ebfd5c3
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Joseph Keenan [Tue, 21 Jun 2022 09:30:08 +0000 (09:30 +0000)]
Merge "Publish LCM Events"
Toine Siebelink [Tue, 21 Jun 2022 09:21:59 +0000 (09:21 +0000)]
Merge "Exclude CM-Handles that are not in state 'READY'"
mpriyank [Wed, 15 Jun 2022 13:40:50 +0000 (14:40 +0100)]
Publish LCM Events
- Publish LCM Create Event when watchdog process moves the cmHandle state from
ADVISED to READY
- Publish LCM Update Event when public properties are updated, no event
when DMI propertis are updated
- Publish LCM Delete Event when a cmHandle is been removed
- Related test scenarios update
- See User Story CPS-1034 for related sub-tasks
Issue-ID: CPS-1090
Change-Id: I70d81fde7c80794ea13a10cd1f235a7012b20b3c
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Joseph Keenan [Fri, 17 Jun 2022 10:25:36 +0000 (10:25 +0000)]
Merge "Fix release notes"
kissand [Wed, 15 Jun 2022 11:48:07 +0000 (13:48 +0200)]
Quick fix for performance degradation bug
Issue-ID: CPS-1085
Change-Id: I15715ef37909d4e2fe2f1f80e621a21c8037fbd0
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Joseph Keenan [Thu, 16 Jun 2022 08:51:08 +0000 (08:51 +0000)]
Merge "Fix sonar code smells"
Joseph Keenan [Wed, 15 Jun 2022 15:32:19 +0000 (15:32 +0000)]
Merge "Retry CM-Handles that are LOCKED, Failed-to-Sync"
puthuparambil.aditya [Fri, 27 May 2022 09:59:19 +0000 (10:59 +0100)]
Retry CM-Handles that are LOCKED, Failed-to-Sync
Watchdog added to fetched locked cm handles by Lock reason
and operation sync state
Tests updated
Issue-ID: CPS-878
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I0ecc519e93b097ec3d309db7f686fb23a0fc59b2
Bruno Sakoto [Wed, 15 Jun 2022 11:57:42 +0000 (07:57 -0400)]
Fix release notes
* Add missing 3.0.1 for Jakarta
* Review 3.1.0 for Kohn (not released yet)
Issue-ID: CPS-1087
Change-Id: Id0ba8246935edff100fb952e9955f462d2313a7e
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
mpriyank [Fri, 10 Jun 2022 11:09:20 +0000 (12:09 +0100)]
NcmpEvent creation and Mapping
- Mapping class to create header and event payload based on type of
operation i.e CREATE, UPDATE and DELETE.
- Service class to get CmHandle public properties, create event and
delegate request to event publisher.
- Modification in NcmpEvent schema json to mark field as String instead
of URI
- Test scenarios
- UPCOMING: Call the service method from relevant code to actually
publish the event.
Issue-ID: CPS-1037
Change-Id: I6bb7de4b27e602c4d8ee6a5528a866e5f7e8799a
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
JosephKeenan [Mon, 13 Jun 2022 09:04:05 +0000 (10:04 +0100)]
Exclude CM-Handles that are not in state 'READY'
Exclude CM-Handles which are not in state ready from ncmp operations
Issue-ID: CPS-877
Change-Id: I59783c860091d99e328cec9ccafb34c09b277753
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
kissand [Mon, 13 Jun 2022 08:55:49 +0000 (10:55 +0200)]
Fix sonar code smells
- https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYFC3OguDZ5Vb3SQMOU1
Issue-ID: CPS-1016
Change-Id: Ic8fdae78337da1ff2c239ae2dfae67e23e88a4bb
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Thu, 9 Jun 2022 16:51:03 +0000 (16:51 +0000)]
Merge "PoC Contract Stubs NCMP Rest Endpoints"
Toine Siebelink [Thu, 9 Jun 2022 16:08:18 +0000 (16:08 +0000)]
Merge "Handle errors during cm handle search"
kissand [Thu, 2 Jun 2022 14:26:23 +0000 (16:26 +0200)]
Handle errors during cm handle search
Issue-ID: CPS-1067
Change-Id: Iadc3413a29f9a455e658ec5bcaffc4881b7f7684
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Thu, 9 Jun 2022 13:05:54 +0000 (13:05 +0000)]
Merge "Fix sonar code smells"
ToineSiebelink [Wed, 8 Jun 2022 11:04:48 +0000 (12:04 +0100)]
Remove Model Sync From Registration
Decouple the model sync from registration process
Sync now only happens during the watchdog process
Cm Handles are persisted in state ADVISED when
registartion is successful
Issue-ID: CPS-876
Change-Id: Ia3353a0ab1c65a9db553e09138d5690d4f915727
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
sourabh_sourabh [Thu, 9 Jun 2022 10:34:31 +0000 (11:34 +0100)]
Override timers advised-modules-sync sleep-time-ms
- Override timers advised-modules-sync sleep-time-ms from docker compose
for CSIT test
Issue-ID: CPS-876
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I2cbc76c03cd5907e2d3bf28b38dbf8209eaaddbd
emaclee [Tue, 7 Jun 2022 17:32:29 +0000 (18:32 +0100)]
Fix sonar code smells
- Remove useless curly braces around statement
(https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYD_5_HLFWip2-KRhcLs)
- Define a constant
(https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&id=onap_cps&open=AYEj9y6sq272EuFEMiu-)
Issue-ID: CPS-475
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Ib430fac481b29dba8725ed0dac4da3daa56a3984
Toine Siebelink [Thu, 9 Jun 2022 08:57:56 +0000 (08:57 +0000)]
Merge "Ncmp Producer Setup"
Toine Siebelink [Wed, 8 Jun 2022 10:03:11 +0000 (10:03 +0000)]
Merge "Merge 2 'query' end points in NCMP"
kissand [Thu, 12 May 2022 13:59:18 +0000 (15:59 +0200)]
Merge 2 'query' end points in NCMP
- merge two endpoint for a same backend
- use xPath query instead of sql query
- modify searches endpoint to return a cmHandle object with all public
properties
- handle old (deprecated) queries
- handle public property queries
- create useful examples
- use more verbose error messages
- simplify openapi yamls
- create new query service
- change second endpoint name to a better matched name
- modify legacy tests with new requirements
- create new tests for the new scenarios
Issue-ID: CPS-1016
Change-Id: I7476e9dbd510ec93b5b48ce85d477ecb2dadffff
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
mpriyank [Thu, 2 Jun 2022 10:27:55 +0000 (11:27 +0100)]
Ncmp Producer Setup
- Ncmp Kafka Publisher setup
- Test scenarios
- Refactored existing test class which were using kafka producer and
consumer properties to use from common MessageSpec
- Upcoming : Implementation Proposal and Actual logic to publish the
correct event
Issue-ID: CPS-1035
Change-Id: I93ae392e8c4e4c85d88ca7858332e79b59e85535
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
puthuparambil.aditya [Thu, 12 May 2022 15:31:00 +0000 (16:31 +0100)]
PoC Contract Stubs NCMP Rest Endpoints
Stubs defined for cmHandleSearch and passthrough operational
Issue-ID: CPS-919
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I4fd7bee8fa70ed237f74c721068ffa39817d5c7a
Toine Siebelink [Fri, 3 Jun 2022 08:11:25 +0000 (08:11 +0000)]
Merge "CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle registration"
sourabh_sourabh [Thu, 2 Jun 2022 12:54:09 +0000 (13:54 +0100)]
CPS-1020 : DuplicatedYangResourceException error at parallel cmHandle registration
- @EnableRetry is added into application.
- Added retry count into log to add more information about retry.
Issue-ID: CPS-1020
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I00c58ef17a8c066f98711c1cf8e5e5cb5f22974b
Toine Siebelink [Thu, 2 Jun 2022 11:30:34 +0000 (11:30 +0000)]
Merge "Add module name to cps core output"
Toine Siebelink [Thu, 2 Jun 2022 09:05:44 +0000 (09:05 +0000)]
Merge "NcmpEvent creation for ModuleSync"
emaclee [Tue, 24 May 2022 10:51:19 +0000 (11:51 +0100)]
Add module name to cps core output
- add withModuleName method
- add getNodeIdentifierWithPrefix method
- add unit test in DataMapUtilsSpec
- add unit test in DataNodeBuilderSpec
- fix all existing unit tests
Issue-ID: CPS-870
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: I51b70fa2dd3381eef9500b4339d4922c017e3000
mpriyank [Wed, 25 May 2022 11:25:48 +0000 (12:25 +0100)]
NcmpEvent creation for ModuleSync
- NcmpEvent schema creation which will be published when module sync is
completed
- Added cmHandleId in the event payload and made eventCorrelationId as
optional
- Upcoming : NcmpEvent publisher code and mapping of the events
Issue-ID: CPS-1036
Change-Id: I7731e6e6a4a8f718967ce68cc6ae0e411eb8c12b
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Toine Siebelink [Wed, 1 Jun 2022 14:39:39 +0000 (14:39 +0000)]
Merge "Module Sync Lock State implementation"
DylanB95EST [Thu, 19 May 2022 13:09:58 +0000 (14:09 +0100)]
Module Sync Lock State implementation
Implementation of Lock state for module sync watchdog
Cm Handle state is locked if any exception is found
during sync process
Make changes around READY state method in line with the
new schema set
Add last updated time to composite state
Remove running datastore references as this is being done
at a later time
Issue-ID: CPS-875
Change-Id: I6bd159faefef2fa84dbf536c292ff0a132793381
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Wed, 1 Jun 2022 13:19:14 +0000 (13:19 +0000)]
Merge "DMI-NCMP Asynchronously Publish Response Event to Client Topic"
mpriyank [Thu, 26 May 2022 19:25:40 +0000 (20:25 +0100)]
Fixing CompositeState mapping
- Mapper null check
- NcmpServiceCmHandle mapping for the new composite state
- Added global parameter for jackson to include only NON_NULL attributes
in the response
Issue-ID: CPS-1066
Change-Id: I1924fef45345c77873f9c788baa701311e72bea7
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
sourabh_sourabh [Mon, 30 May 2022 12:20:47 +0000 (13:20 +0100)]
DMI-NCMP Asynchronously Publish Response Event to Client Topic
- [NCMP] Added Unit Tests for NcmpAsyncRequestResponseEventMapper.java
Issue-ID: CPS-830
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I64dad7f0bb9b64e1864f19db5a5d74922dc6a83b
Joseph Keenan [Wed, 1 Jun 2022 08:41:24 +0000 (08:41 +0000)]
Merge "Handle RestTemplate Error handling so NCMP cna report correct server status"
ToineSiebelink [Fri, 27 May 2022 09:58:52 +0000 (10:58 +0100)]
Handle RestTemplate Error handling so NCMP cna report correct server status
- Moved resposne handling to DmRestClient
- Clean up incorrect/redundant tests in CmProxyDataServiceImplSpec
Issue-ID: CPS-1056
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Change-Id: I78ba87d6af7255d85758893cfef237d75227875a
Joseph Keenan [Thu, 26 May 2022 10:37:28 +0000 (10:37 +0000)]
Merge "CompositeStateBuilder added for building the compositeState"
puthuparambil.aditya [Wed, 25 May 2022 14:29:59 +0000 (15:29 +0100)]
CompositeStateBuilder added for building the compositeState
Added composite state to YangModelCmHandleRetriever
Issue-ID: CPS-878
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I8bdea55c0a8e27a906e24fc367dedf81c9b3501c
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
JosephKeenan [Tue, 24 May 2022 17:59:25 +0000 (18:59 +0100)]
Async request response NCMP -> Client
-Added consumer for DMI events and producer for forwarding to client
-Added schemas for events
-Updated tests
-Added new module for ncmp events
-Used mapstruct for event mapping
Issue-ID: CPS-830
Change-Id: I096d08af9d69092cf8651e11eaa00ce441fc3605
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
Signed-off-by: ToineSiebelink <toine.siebelink@est.tech>
Signed-off-by: JosephKeenan <joseph.keenan@est.tech>
mpriyank [Fri, 20 May 2022 14:25:15 +0000 (15:25 +0100)]
Enhanced response with Complex State in API
- Introduced RestOutputCmHandleState in API specs of
retrieveCmHandleDetailsById
- Mapper to map CompositeState to RestOutputCmHandleState
- Enhanced existing test cases and introduced new one to test the
mapping result
Issue-ID: CPS-1047
Change-Id: I34fa198287e5d920bc0cea312ee4e368f3be2b90
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
Toine Siebelink [Fri, 20 May 2022 15:57:00 +0000 (15:57 +0000)]
Merge "Get cm-handle public properties endpoint"
lukegleeson [Fri, 6 May 2022 11:02:42 +0000 (12:02 +0100)]
Get cm-handle public properties endpoint
Added RestOuputCmHandlePublicProperties OpenApi Object
Added Get cm-handle public properties endpoint
Added rest and service layer functionality for endpoint with tests
Fixed Copyright Checker violations
Issue-ID: CPS-1018
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Ifc13cde350a49f6ba705a09e31853dc9c73be168
Joseph Keenan [Fri, 20 May 2022 08:40:21 +0000 (08:40 +0000)]
Merge "URI is not absolute when service name is not set"
Toine Siebelink [Thu, 19 May 2022 13:28:02 +0000 (13:28 +0000)]
Merge "Composite State to handle dmi-reg YANG updates"
mpriyank [Mon, 16 May 2022 16:14:25 +0000 (17:14 +0100)]
Composite State to handle dmi-reg YANG updates
- Introduce CompositeState object which handles change in updated YANG for dmi-registry
- Used Builder pattern as some of the fields are optional
- Removed the abstract ready method from CmHandleState which was used as
state machine
- Fixed few test cases
Issue-ID: CPS-1042
Change-Id: I8aaf6f819c66b3a9d30c5e8f0a0007f9528b247f
Signed-off-by: mpriyank <priyank.maheshwari@est.tech>
DylanB95EST [Thu, 19 May 2022 10:00:18 +0000 (11:00 +0100)]
URI is not absolute when service name is not set
BUG - URI is not absolute exception when dmi-service-name
is not set in the database, due to null String
Has now been set to null value
Issue-ID: CPS-1043
Change-Id: If48c34d8caee302a1849555755960dccfd26ab7a
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
DylanB95EST [Mon, 16 May 2022 09:45:56 +0000 (10:45 +0100)]
Remove NCMP tag from properties
We have decided to remove the NCMP tag from properties
and will add it later as part of our release process for
KOHN.
Issue-ID: CPS-875
Change-Id: I7282c3c11879f2252c8a1b193df17f3f4bb1cf14
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Fri, 13 May 2022 08:03:43 +0000 (08:03 +0000)]
Merge "Watchdog-process that syncs 'ADVISED' CM Handles"
DylanB95EST [Thu, 5 May 2022 10:53:12 +0000 (11:53 +0100)]
Watchdog-process that syncs 'ADVISED' CM Handles
- Sync and Create Schema Set during
module sync watchdog process.
- Add a cm handle state transition machine to handle
state changes for a cm handle during watchdog
which syncs module service.
Issue-ID: CPS-875
Change-Id: I3b178f5693cb7ac30577dd81cdc82b462555389a
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Joseph Keenan [Thu, 12 May 2022 10:45:47 +0000 (10:45 +0000)]
Merge "Add graceful shutdown for Session Manager"
emaclee [Fri, 6 May 2022 09:36:29 +0000 (10:36 +0100)]
Add graceful shutdown for Session Manager
Introduce singleton session manager
Add unit test for session manager
Issue-Id: CPS-898
Signed-off-by: emaclee <lee.anjella.macabuhay@est.tech>
Change-Id: Iaf91f1aa6c1ebfe0ab907e7f7d80a01e940a0fdd
Toine Siebelink [Wed, 11 May 2022 15:22:33 +0000 (15:22 +0000)]
Merge "Update DMI Registry yang to support DataStoreSyncState"
Lathish [Tue, 10 May 2022 09:41:05 +0000 (10:41 +0100)]
Update DMI Registry yang to support DataStoreSyncState
- Added dmi-registry@2022-05-10 yang to support DataStoreSyncState
- Added changelog 14 to add the dmi-registry
Issue-ID: CPS-1014
Change-Id: I910d2496a359fdf2441e172ca270036272d31dc6
Signed-off-by: Lathish <lathishbabu.ganesan@est.tech>
DylanB95EST [Fri, 6 May 2022 09:43:58 +0000 (10:43 +0100)]
Watchdog Process-Make Configurable
Make time configurable for the watchdog process.
Add documentation outlining this.
Issue-ID: CPS-875
Change-Id: I1307c82d02789097efda1ba981eb1fd36c9efc38
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
Toine Siebelink [Tue, 10 May 2022 14:29:54 +0000 (14:29 +0000)]
Merge "Add ncmp tag to application yaml"
Toine Siebelink [Tue, 10 May 2022 14:08:37 +0000 (14:08 +0000)]
Merge "Improve Local Running of CSIT Tests"
lukegleeson [Tue, 10 May 2022 12:38:32 +0000 (13:38 +0100)]
Improve Local Running of CSIT Tests
Issue-ID: CPS-734
Signed-off-by: lukegleeson <luke.gleeson@est.tech>
Change-Id: Iff92f43dc69cdaf3e1e78551f68ecfb08bde4b93
DylanB95EST [Mon, 9 May 2022 16:03:52 +0000 (17:03 +0100)]
Add ncmp tag to application yaml
Add an NCMP tag to Application.yml to store
NCMP related propeties
Issue-ID: CPS-875
Change-Id: I2bce3d765ae69cc2a4bb52a472eea7cae745fd2c
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>
sourabh_sourabh [Fri, 6 May 2022 10:31:54 +0000 (11:31 +0100)]
Security Logging Fields
- Made logging.format value case insensitive for consistency as we did same change for cps-temporal, ncmp-dmi-plugin and oom.
Issue-ID: CPS-986
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: I085a3777e8f4cf9e6b62e40d05672ce455916a85
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
sourabh_sourabh [Fri, 22 Apr 2022 21:47:41 +0000 (22:47 +0100)]
Security Logging Fields
- logback core and encoder dependencies are added.
- New appender is added to log JSON format content on console.
Issue-ID: CPS-986
Signed-off-by: sourabh_sourabh <sourabh.sourabh@est.tech>
Change-Id: Ia72b27f306019fa259b3d6de4c5399f0ae734076
Joseph Keenan [Tue, 3 May 2022 11:39:31 +0000 (11:39 +0000)]
Merge "Fix sonar code smells"
Joseph Keenan [Tue, 3 May 2022 08:53:36 +0000 (08:53 +0000)]
Merge "Watchdog-process that changes CM Handles state"
kissand [Mon, 2 May 2022 08:42:30 +0000 (10:42 +0200)]
Fix sonar code smells
* Increase code coverage in DataNodeBuilder
Issue-ID: CPS-475
Change-Id: I00a3b1c81911c1ccd3db810eec2f2989946809c5
Signed-off-by: kissand <andras.zoltan.kiss@est.tech>
Toine Siebelink [Tue, 3 May 2022 08:16:24 +0000 (08:16 +0000)]
Merge "Updated the documentation with limitation of leaf condition"
Toine Siebelink [Fri, 29 Apr 2022 15:33:04 +0000 (15:33 +0000)]
Merge "[STRIMZI] Add strimzi kafka notes"
DylanB95EST [Wed, 20 Apr 2022 09:35:11 +0000 (10:35 +0100)]
Watchdog-process that changes CM Handles state
Add a fixed delay scheduler to switch cm-handles found in an ADVISED
state to a READY state
Scheduler currently runs every 30 seconds
Will only update a single cm-handle at a time
Queries CM-Handle with Advised States Only using CPS Path.
Will choose cm handle at random
Issue-ID: CPS-875
Change-Id: Ie1b49c89a0350d20e14748a65f9c1d260d8502d2
Signed-off-by: DylanB95EST <dylan.byrne@est.tech>