vid.git
4 years agoincrease maxOpenedInstantiationRequests from 20 to 200 70/99170/1
Amichai Hemli [Wed, 4 Dec 2019 20:27:34 +0000 (22:27 +0200)]
increase maxOpenedInstantiationRequests from 20 to 200

Issue-ID: VID-724
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: If01c950f6b3a72b681cb6067e101466524d92cd2

4 years agoCreate function that convert rollbackOnFailure value from String to Boolean 58/99158/2
Alexey Sandler [Wed, 4 Dec 2019 15:48:06 +0000 (17:48 +0200)]
Create function that convert rollbackOnFailure value from String to Boolean

Issue-ID: VID-724
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: Ia3738a146d0b57e961e097c6b6e70e525c46a397

4 years agoAdding Template button to new service instance + cypress test + filter 99/98999/6
Yoav Schneiderman [Tue, 3 Dec 2019 10:55:39 +0000 (12:55 +0200)]
Adding Template button to new service instance + cypress test + filter

Issue-ID: VID-724
Change-Id: Ie69a32dd6b74de57fd747a92935c1ce5edb86351
Signed-off-by: Yoav Schneiderman <yoav.schneiderman@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Extract subscriber-name only when it is not defined"
Ittay Stern [Wed, 4 Dec 2019 15:08:37 +0000 (15:08 +0000)]
Merge "Extract subscriber-name only when it is not defined"

4 years agoMerge "document FLAG_2004_INSTANTIATION_STATUS_FILTER"
Ittay Stern [Wed, 4 Dec 2019 15:02:11 +0000 (15:02 +0000)]
Merge "document FLAG_2004_INSTANTIATION_STATUS_FILTER"

4 years agoExtract subscriber-name only when it is not defined 45/99145/2
Alexey Sandler [Wed, 4 Dec 2019 14:10:34 +0000 (16:10 +0200)]
Extract subscriber-name only when it is not defined

This solves the Recreate issue when subscriber-name is already
provided by the template, but Redux is not populated with
`service.subscribers`.

Issue-ID: VID-724

Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: Id3bfd705015270352aef674d2119fc77838a3ddb
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
4 years agodocument FLAG_2004_INSTANTIATION_STATUS_FILTER 43/99143/1
Eylon Malin [Wed, 4 Dec 2019 13:16:07 +0000 (15:16 +0200)]
document FLAG_2004_INSTANTIATION_STATUS_FILTER

Issue-ID: VID-724
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I7da35c0676f74b36deb1f60620ff5b7b6cab2e85

4 years agoSink all Async-Jobs logging to same debug.log 77/99077/5
Ittay Stern [Tue, 3 Dec 2019 18:38:44 +0000 (20:38 +0200)]
Sink all Async-Jobs logging to same debug.log

Error events are _replicated_ to error.log

Main incentive is to have all JobWorker, ResourceCommand
and MsoResultHandlerService logging the job life-cycle on
same page.

Issue-ID: VID-253
Change-Id: I862b408d71767ca3d5e6da3071bbae751261587e
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agomake sure request id is unique per each async job execution 32/99132/1
Eylon Malin [Wed, 4 Dec 2019 10:22:20 +0000 (12:22 +0200)]
make sure request id is unique per each async job execution

Issue-ID: VID-253
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I1e7e98876c6557ff18a9e1646d7b815ed9af830d

4 years agoimprove test deployTwoServicesGetServicesFilterByModelId 24/99124/1
Eylon Malin [Wed, 4 Dec 2019 08:30:09 +0000 (10:30 +0200)]
improve test deployTwoServicesGetServicesFilterByModelId

Issue-ID: VID-724

Test validate that only expected jobIds are in service info list +
always mute jobs att the end of the test

Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I3cfa35ae5f31cf72dcf8b4ac3e250f9473080693

4 years agoDrawing Board RECREATE will use a new route that retrieves a template 49/99049/4
Alexey Sandler [Tue, 3 Dec 2019 11:04:42 +0000 (13:04 +0200)]
Drawing Board RECREATE will use a new route that retrieves a template

Use endpoint "templateTopology" instead of "bulkForRetry"

Issue-ID: VID-724

Change-Id: Ic92971e29d1f78768aeb82158ce424ff31bfbbb0
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
4 years agoMerge "free text filter in instantiationStatus Page"
Ittay Stern [Tue, 3 Dec 2019 15:33:43 +0000 (15:33 +0000)]
Merge "free text filter in instantiationStatus Page"

4 years agofree text filter in instantiationStatus Page 02/99002/8
Eylon Malin [Tue, 3 Dec 2019 10:12:38 +0000 (12:12 +0200)]
free text filter in instantiationStatus Page

Issue-ID: VID-724
Change-Id: I5f363ecc66ff1f1fef9c9d75a12a9c43403aa905
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agodisable npm progress-bar by npmrc file instead of mvn goal 22/99022/1
Amichai Hemli [Mon, 2 Dec 2019 16:53:56 +0000 (18:53 +0200)]
disable npm progress-bar by npmrc file instead of mvn goal

Issue-ID: VID-724
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: I2c1261b24bba3e16dd858e3dd77c9b0a188e310c

4 years agoMerge "FE getServicesJobInfo can filter by serviceModelId"
Amichai Hemli [Mon, 2 Dec 2019 14:08:18 +0000 (14:08 +0000)]
Merge "FE getServicesJobInfo can filter by serviceModelId"

4 years agoMerge "add more test scenarios for filter serviceInfo by service model id"
Ittay Stern [Mon, 2 Dec 2019 11:20:36 +0000 (11:20 +0000)]
Merge "add more test scenarios for filter serviceInfo by service model id"

4 years agoMerge "Add query param option for filtering services info by service model id"
Ittay Stern [Mon, 2 Dec 2019 11:19:33 +0000 (11:19 +0000)]
Merge "Add query param option for filtering services info by service model id"

4 years agoFE getServicesJobInfo can filter by serviceModelId 95/98995/2
Eylon Malin [Mon, 2 Dec 2019 08:55:37 +0000 (10:55 +0200)]
FE getServicesJobInfo can filter by serviceModelId

Issue-ID: VID-724
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I3acff0f47810825d90b91dbeaaedcdd348c7d733

4 years agoAdd query param option for filtering services info by service model id 89/98989/4
Sara Weiss [Mon, 2 Dec 2019 07:05:58 +0000 (09:05 +0200)]
Add query param option for filtering services info by service model id

Issue-ID: VID-724
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Change-Id: I72c78dd3c0e156688092ce4ac3793bc3e8c37352

4 years agoadd more test scenarios for filter serviceInfo by service model id 91/98991/1
Eylon Malin [Mon, 2 Dec 2019 07:34:40 +0000 (09:34 +0200)]
add more test scenarios for filter serviceInfo by service model id

Issue-ID: VID-724
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I24daba11da26a39ee366d1353459c530f0ebfafc

4 years agoAPI to get template-topology by job id 90/98990/1
Ittay Stern [Mon, 2 Dec 2019 07:22:42 +0000 (09:22 +0200)]
API to get template-topology by job id

..../vid/asyncInstantiation/templateTopology/{jobId}

Issue-ID: VID-724

Change-Id: I5704951a595293d10ed6ae09c0113e1cac5b5788
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoCypress to drive recreation from templates 83/98983/2
Ittay Stern [Sun, 1 Dec 2019 17:38:32 +0000 (19:38 +0200)]
Cypress to drive recreation from templates

A new route "RECREATE" allows the half-way between RETRY and CREATE: It
is "retry" because historic topology is loaded. It is "create" because
a new instance is created upon "Deploy".

Following commits should modify business-code, so that:

- The expectedPostAsyncInstantiation assertion pass;

- User is navigated the Instantiation-Status page;

- The template topology will be from a designated endpoint
  "templateTopology", instead of "bulkForRetry";

- Consider the hack in `templates__instance_template.json`, where action
  is "None_Create" instead of "Create" to workaround a state-oriented
  problem in the method `extractServiceFields()`.

Issue-ID: VID-724

Change-Id: I0fc282b506a05b8161f3b3f96959493d3843c7f9
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Add filter for serviceInfo by service model id"
Ittay Stern [Sun, 1 Dec 2019 14:18:41 +0000 (14:18 +0000)]
Merge "Add filter for serviceInfo by service model id"

4 years agoMerge changes Ia06b7afe,I31b646b4
Ittay Stern [Sun, 1 Dec 2019 13:14:49 +0000 (13:14 +0000)]
Merge changes Ia06b7afe,I31b646b4

* changes:
  remove FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD
  remove FLAG_DEFAULT_VNF

4 years agoAdd filter for serviceInfo by service model id 82/98982/4
Sara Weiss [Sun, 1 Dec 2019 12:46:47 +0000 (14:46 +0200)]
Add filter for serviceInfo by service model id

Issue-ID: VID-724
Change-Id: Icdb35b4fa95acb0d40f2921f3d3de0a037858e08
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
4 years agoremove FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD 46/98946/2
Eylon Malin [Thu, 28 Nov 2019 14:46:01 +0000 (16:46 +0200)]
remove FLAG_SETTING_DEFAULTS_IN_DRAWING_BOARD

Issue-ID: VID-721
Change-Id: Ia06b7afe0cc2aa6f906f56802dc537f6fec283d0
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoupgrade some 3rd parties dependencies 37/98937/3
Eylon Malin [Thu, 28 Nov 2019 13:35:16 +0000 (15:35 +0200)]
upgrade some 3rd parties dependencies

Issue-ID: VID-705
Change-Id: Idd72448ed1b2f033005ff8031856efe06f67cdf4
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoremove FLAG_DEFAULT_VNF 41/98941/1
Eylon Malin [Thu, 28 Nov 2019 14:33:12 +0000 (16:33 +0200)]
remove FLAG_DEFAULT_VNF

Issue-ID: VID-721
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I31b646b4dd5a81c4904a77c0386e27137a76a9fd

4 years agoadding testing to multi select service. 40/98940/1
Yoav Schneiderman [Thu, 28 Nov 2019 14:25:05 +0000 (16:25 +0200)]
adding testing to multi select service.
Issue-ID: VID-722

Signed-off-by: Yoav Schneiderman <yoav.schneiderman@intl.att.com>
Change-Id: Ieb4ddb06a76f3d85b8227574ea519abedad85a09

4 years agoremove FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE 23/98923/2
Eylon Malin [Thu, 28 Nov 2019 08:53:54 +0000 (10:53 +0200)]
remove FLAG_1810_CR_SOFT_DELETE_ALACARTE_VF_MODULE

Issue-ID: VID-721
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I80e3f8edbc187acaf13fdcc089ba15da33dc0ec5

4 years agoMerge "fix some methods signature to be more TypeScript"
Ittay Stern [Thu, 28 Nov 2019 08:10:58 +0000 (08:10 +0000)]
Merge "fix some methods signature to be more TypeScript"

4 years agoMerge "BE unit tests for supplementaryFileParams in vf module upgrade"
Ittay Stern [Thu, 28 Nov 2019 08:10:42 +0000 (08:10 +0000)]
Merge "BE unit tests for supplementaryFileParams in vf module upgrade"

4 years agofix some methods signature to be more TypeScript 19/98919/1
Eylon Malin [Thu, 28 Nov 2019 07:53:16 +0000 (09:53 +0200)]
fix some methods signature to be more TypeScript

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I50225f014abf0717b779f15f22a2185f1f92650b

4 years agoBE unit tests for supplementaryFileParams in vf module upgrade 18/98918/1
Eylon Malin [Thu, 28 Nov 2019 07:29:41 +0000 (09:29 +0200)]
BE unit tests for supplementaryFileParams in vf module upgrade

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ic2da23ab699d5b0d218b3bb1f0c0f7f936b0902e

4 years agoupdate supplementaryFileContent at onSubmit of VfModule upgrade 15/98915/2
Eylon Malin [Wed, 27 Nov 2019 12:25:54 +0000 (14:25 +0200)]
update supplementaryFileContent at onSubmit of VfModule upgrade

Issue-ID: VID-603
Change-Id: I7fac657454de7a6d3674708c956eb099c11ad2ea
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoOperationalEnvironment improvements 88/98688/3
Michal Kabaj [Wed, 20 Nov 2019 20:38:54 +0000 (21:38 +0100)]
OperationalEnvironment improvements

-added new unit test to AaiControllerTest
-OperationalEnvironment and List are now immutable
-builder improvements
-removed redundant test

Issue-ID: VID-706
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Change-Id: I2cf0d0b124458b9306637614b3d26c85c780ca4d
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
4 years agoMerge "Quick fix for the expected class type in test"
Ittay Stern [Wed, 27 Nov 2019 14:23:27 +0000 (14:23 +0000)]
Merge "Quick fix for the expected class type in test"

4 years agoQuick fix for the expected class type in test 95/98895/1
Amir Skalka [Wed, 27 Nov 2019 13:13:01 +0000 (15:13 +0200)]
Quick fix for the expected class type in test

Issue-ID: VID-723
Signed-off-by: Amir Skalka <amir.skalka@intl.att.com>
Change-Id: I067241eb531c448b38ad37f75f0ff77457c9f069

4 years agoadd sdnc checkbox to vfm upgrade modal 93/98893/3
Alexey Sandler [Tue, 26 Nov 2019 19:44:18 +0000 (21:44 +0200)]
add sdnc checkbox to vfm upgrade modal

Issue-ID: VID-603
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: Ic297486bc343419415bf3736ebb56944e72bf8b8
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
4 years agouse mergeObjectByPathAction for update VfModule properties upon upgrade 89/98889/2
Eylon Malin [Wed, 27 Nov 2019 10:08:01 +0000 (12:08 +0200)]
use mergeObjectByPathAction for update VfModule properties upon upgrade

Issue-ID: VID-603
Change-Id: Icdec60aa0e0522e5af394184c5f700ed2d493e4e
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "add reducer action that can merge any object by path"
Amichai Hemli [Wed, 27 Nov 2019 10:57:50 +0000 (10:57 +0000)]
Merge "add reducer action that can merge any object by path"

4 years agoMerge "move SDN-C pre-load controller to basic control generator"
Amichai Hemli [Wed, 27 Nov 2019 10:15:30 +0000 (10:15 +0000)]
Merge "move SDN-C pre-load controller to basic control generator"

4 years agoadd reducer action that can merge any object by path 80/98880/1
Eylon Malin [Wed, 27 Nov 2019 08:19:27 +0000 (10:19 +0200)]
add reducer action that can merge any object by path

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ib34ed65d2ebb1f1dc1780205e4a60ab8515c8334

4 years agoDon't assert host:port on SDC ProbeApiTest 79/98879/1
Ittay Stern [Wed, 27 Nov 2019 07:59:50 +0000 (09:59 +0200)]
Don't assert host:port on SDC ProbeApiTest

Undo Make ProbeApiTest expectation to follow tests' Simulator config

Issue-ID: VID-647

Change-Id: I6a6a487835be5865d2b5fed185939ea2ab79a880
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agomove SDN-C pre-load controller to basic control generator 77/98877/2
Alexey Sandler [Tue, 26 Nov 2019 10:18:32 +0000 (12:18 +0200)]
move SDN-C pre-load controller to basic control generator

Issue-ID: VID-603
Change-Id: I2b70ab8e2437a8be3a8b3e37e9baa1bdd70cd0e5
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
4 years agoupgrade cypress to 3.6.1 67/98867/1
Eylon Malin [Tue, 26 Nov 2019 19:27:08 +0000 (21:27 +0200)]
upgrade cypress to 3.6.1

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ief1114e24fe5b7a0975a1414ad5059a0d3812a88

4 years agoMerge "Make ProbeApiTest expectation to follow tests' Simulator config"
Ittay Stern [Tue, 26 Nov 2019 17:17:03 +0000 (17:17 +0000)]
Merge "Make ProbeApiTest expectation to follow tests' Simulator config"

4 years agoimprove debug logging format 00/98400/5
Amichai Hemli [Thu, 14 Nov 2019 09:28:03 +0000 (11:28 +0200)]
improve debug logging format

Issue-ID: VID-646
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
Change-Id: Ifa9105455dabdfad3179c36b516fe9833e0e6e60
Signed-off-by: Amichai Hemli <amichai.hemli@intl.att.com>
4 years agoMake ProbeApiTest expectation to follow tests' Simulator config 63/98863/1
Ittay Stern [Tue, 26 Nov 2019 17:02:29 +0000 (19:02 +0200)]
Make ProbeApiTest expectation to follow tests' Simulator config

Issue-ID: VID-647

Change-Id: I56f9106403c31e545d00caaf2fe6d5df2f375843
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMake LoggerFormatTest run last 60/98860/2
Ittay Stern [Tue, 26 Nov 2019 15:23:49 +0000 (17:23 +0200)]
Make LoggerFormatTest run last

Issue-ID: VID-647
Change-Id: Ia9989555d3fbdfe222410be59c8a581be32974e0
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "Allow platform multi-selection for VNF in modern UI"
Ittay Stern [Tue, 26 Nov 2019 15:20:24 +0000 (15:20 +0000)]
Merge "Allow platform multi-selection for VNF in modern UI"

4 years agoextract VfModulePopupServiceBase 54/98854/1
Eylon Malin [Tue, 26 Nov 2019 12:15:11 +0000 (14:15 +0200)]
extract VfModulePopupServiceBase

Issue-ID: VID-603

Make VfModulePopuopService and VfModuleUpgradePopupService inherit from
same base class

Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ie91aa4ef2afb0d7d807c0dd56944bd4e1777b8d0

4 years agoMerge "Replace vfmodule: add retainVolumeGroup to new upgrade modal"
Ittay Stern [Tue, 26 Nov 2019 11:55:57 +0000 (11:55 +0000)]
Merge "Replace vfmodule: add retainVolumeGroup to new upgrade modal"

4 years agoAllow platform multi-selection for VNF in modern UI 72/98672/10
Yoav Schneiderman [Wed, 20 Nov 2019 14:50:45 +0000 (16:50 +0200)]
Allow platform multi-selection for VNF in modern UI

Issue-ID: VID-722
Change-Id: Id87f59fff128e277d9158b83f3908754375c8b01
Signed-off-by: Yoav Schneiderman <yoav.schneiderman@intl.att.com>
Signed-off-by: Einat Vinouze <einat.vinouze@intl.att.com>
4 years agoReplace vfmodule: add retainVolumeGroup to new upgrade modal 44/98844/2
Sara Weiss [Tue, 26 Nov 2019 09:46:42 +0000 (11:46 +0200)]
Replace vfmodule: add retainVolumeGroup to new upgrade modal

Issue-ID: VID-603
Change-Id: I1994d4464172613294198e21a77f31b752211888
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoCheckMinMaxInitialParams test ignore viewEditUI 41/98841/1
Eylon Malin [Tue, 26 Nov 2019 09:02:43 +0000 (11:02 +0200)]
CheckMinMaxInitialParams test ignore viewEditUI

Issue-ID: VID-705
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I8fdde158d6f094b30c210d78233360380f73f48c

4 years agoMerge "Extract concatSupplementaryFile out of VFM controller"
Ittay Stern [Tue, 26 Nov 2019 08:50:23 +0000 (08:50 +0000)]
Merge "Extract concatSupplementaryFile out of VFM controller"

4 years agoMerge "Extract getSupplementaryFile out of VFM controller"
Ittay Stern [Tue, 26 Nov 2019 08:49:59 +0000 (08:49 +0000)]
Merge "Extract getSupplementaryFile out of VFM controller"

4 years agoExtract concatSupplementaryFile out of VFM controller 38/98838/1
Eylon Malin [Tue, 26 Nov 2019 08:18:03 +0000 (10:18 +0200)]
Extract concatSupplementaryFile out of VFM controller

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I7522442e5ae3109ac1abeca1f82b2a980a10e30d

4 years agoExtract getSupplementaryFile out of VFM controller 11/98811/2
Amir Skalka [Mon, 25 Nov 2019 14:36:55 +0000 (16:36 +0200)]
Extract getSupplementaryFile out of VFM controller

Issue-ID: VID-603
Change-Id: I8ccc2e3cdc79faded73f5811fee99cc78c8ebd47
Signed-off-by: Amir Skalka <amir.skalka@intl.att.com>
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "identify macro services without instantiation type in BE by feature flag"
Ittay Stern [Mon, 25 Nov 2019 14:04:02 +0000 (14:04 +0000)]
Merge "identify macro services without instantiation type in BE by feature flag"

4 years agoidentify macro services without instantiation type in BE by feature flag 06/98706/5
Eylon Malin [Thu, 21 Nov 2019 10:01:58 +0000 (12:01 +0200)]
identify macro services without instantiation type in BE by feature flag

Issue-ID: VID-705
Change-Id: Ia618f91133cdecbd35eac4346496a6ff38a3753e
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "remove EMPTY_DRAWING_BOARD_TEST feature flag"
Ittay Stern [Mon, 25 Nov 2019 12:43:11 +0000 (12:43 +0000)]
Merge "remove EMPTY_DRAWING_BOARD_TEST feature flag"

4 years agoMerge "assert vfModule action after undo upgrade"
Ittay Stern [Mon, 25 Nov 2019 12:34:14 +0000 (12:34 +0000)]
Merge "assert vfModule action after undo upgrade"

4 years agoassert vfModule action after undo upgrade 09/98809/1
Eylon Malin [Mon, 25 Nov 2019 12:07:15 +0000 (14:07 +0200)]
assert vfModule action after undo upgrade

Issue-ID: VID-603
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I58a30738793f25fd4f0d8efb48f13fed510d895d

4 years agoupgrade vfModule retainAssignments true by default. 08/98808/1
Yoav Schneiderman [Mon, 25 Nov 2019 11:47:12 +0000 (13:47 +0200)]
upgrade vfModule retainAssignments true by default.

Issue-ID: VID-603
Signed-off-by: Yoav Schneiderman <yoav.schneiderman@intl.att.com>
Change-Id: I9f8761b756968dcc91ab1cae998d47fa74ecccd0

4 years agoVfModule upgrade: popup with retain-assignments checkbox 21/98721/4
Yoav Schneiderman [Thu, 21 Nov 2019 14:17:55 +0000 (16:17 +0200)]
VfModule upgrade: popup with retain-assignments checkbox

Also:
 - undo upgrade -> remove field
 - cancel on popup works

Issue-ID: VID-603
Change-Id: I47106ce4d042c777b56699d8c5c5e1e99f856a5e
Signed-off-by: Yoav Schneiderman <yoav.schneiderman@intl.att.com>
4 years agoMerge "Replace vfmodule: expect optional retainAssignments param"
Amichai Hemli [Mon, 25 Nov 2019 08:45:29 +0000 (08:45 +0000)]
Merge "Replace vfmodule: expect optional retainAssignments param"

4 years agoMerge "Migrating VfModuleOrVolumeGroupRequestDetails it to Kotlin; avoid the inner...
Amichai Hemli [Mon, 25 Nov 2019 08:44:42 +0000 (08:44 +0000)]
Merge "Migrating VfModuleOrVolumeGroupRequestDetails it to Kotlin; avoid the inner static classes"

4 years agoMerge "VfModule and VolumeGroup RequestParameters: introduce objects hierarchy"
Amichai Hemli [Mon, 25 Nov 2019 08:44:19 +0000 (08:44 +0000)]
Merge "VfModule and VolumeGroup RequestParameters: introduce objects hierarchy"

4 years agoremove EMPTY_DRAWING_BOARD_TEST feature flag 02/98802/1
Eylon Malin [Mon, 25 Nov 2019 08:30:23 +0000 (10:30 +0200)]
remove EMPTY_DRAWING_BOARD_TEST feature flag

Issue-ID: VID-721
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ib3106fb17c97602e2d5d6de8c9a5756e4d231902

4 years agoReplace vfmodule: expect optional retainAssignments param 94/98794/2
Ittay Stern [Sun, 24 Nov 2019 16:13:17 +0000 (18:13 +0200)]
Replace vfmodule: expect optional retainAssignments param

Issue-ID: VID-603
Change-Id: Ifda72845f2c5b473bba7ac64deab8d4b0f11ef10
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge this if statement with the enclosing one. 92/98092/2
anushadasari [Thu, 7 Nov 2019 07:27:11 +0000 (12:57 +0530)]
Merge this if statement with the enclosing one.

Merging collapsible if statements increases the code's readability

Issue-ID: VID-699
Change-Id: I2c030f36a60957ff63a35de05d3032abe9fed4d9
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge this if statement with the enclosing one. 90/98090/2
anushadasari [Thu, 7 Nov 2019 07:22:51 +0000 (12:52 +0530)]
Merge this if statement with the enclosing one.

Merging collapsible if statements increases the code's readability.

Issue-ID: VID-699
Change-Id: I9460c6b621815339f873761c0e7ba0bf9c479578
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMerge this if statement with the nested one 87/98087/2
anushadasari [Thu, 7 Nov 2019 07:18:23 +0000 (12:48 +0530)]
Merge this if statement with the nested one

Merging collapsible if statements increases the code's readability.

Issue-ID: VID-699
Change-Id: Icb52f1e1fcaec6ebfec3711c32c4cfcca9582af6
Signed-off-by: anushadasari <danush10@in.ibm.com>
4 years agoMigrating VfModuleOrVolumeGroupRequestDetails it to Kotlin; avoid the inner static... 93/98793/2
Ittay Stern [Sun, 24 Nov 2019 15:52:56 +0000 (17:52 +0200)]
Migrating VfModuleOrVolumeGroupRequestDetails it to Kotlin; avoid the inner static classes

Issue-ID: VID-603
Change-Id: I8ae786d2e0e67300cd6118d41b48ba8483b922f0
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoVfModule and VolumeGroup RequestParameters: introduce objects hierarchy 85/98785/3
Ittay Stern [Sun, 24 Nov 2019 08:51:11 +0000 (10:51 +0200)]
VfModule and VolumeGroup RequestParameters: introduce objects hierarchy

-- RequestParametersVfModuleOrVolumeGroup
   +-- RequestParametersVfModuleOrVolumeGroupInstantiation
   +-- RequestParametersVfModuleUpgrade

Change-Id: I97ef46c7cf66936685e030a73b42d4deac7403b5
Issue-ID: VID-603
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoremove CREATE_INSTANCE_TEST feature flag 84/98784/4
Eylon Malin [Sun, 24 Nov 2019 08:15:02 +0000 (10:15 +0200)]
remove CREATE_INSTANCE_TEST feature flag

Issue-ID: VID-721
Change-Id: Id956a0b5b840c5e76cc1f6f7ea33a7d00f5670c3
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "Replace vfmodule: expect optional retainVolumeGroups param"
Ittay Stern [Thu, 21 Nov 2019 14:37:58 +0000 (14:37 +0000)]
Merge "Replace vfmodule: expect optional retainVolumeGroups param"

4 years agoReplace vfmodule: expect optional retainVolumeGroups param 12/98712/2
Sara Weiss [Thu, 21 Nov 2019 12:50:12 +0000 (14:50 +0200)]
Replace vfmodule: expect optional retainVolumeGroups param

Issue-ID: VID-603
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
Change-Id: I392d1e70a7f423128221b2f7a7fc0f8449d8e268

4 years agoVidNotionBuilder can use configuration file to identify macro services 97/98697/4
Eylon Malin [Thu, 21 Nov 2019 07:31:36 +0000 (09:31 +0200)]
VidNotionBuilder can use configuration file to identify macro services

Issue-ID: VID-701
Change-Id: I23c89ed500d6d1663b07fa909b16eda30e63e36c
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoMerge "a-la-carte services e2e test - add more 2 VfModules"
Ittay Stern [Thu, 21 Nov 2019 02:54:11 +0000 (02:54 +0000)]
Merge "a-la-carte services e2e test - add more 2 VfModules"

4 years agoa-la-carte services e2e test - add more 2 VfModules 69/98669/2
Eylon Malin [Wed, 20 Nov 2019 14:16:41 +0000 (16:16 +0200)]
a-la-carte services e2e test - add more 2 VfModules

Issue-ID: VID-701
Change-Id: I644ff412d1bff60842793e3839f66bf5007cb32b
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
4 years agoReplace vfmodule: opens an popup 65/98665/3
Sara Weiss [Wed, 20 Nov 2019 12:50:33 +0000 (14:50 +0200)]
Replace vfmodule: opens an popup

Issue-ID: VID-603
Change-Id: I7d7524f75bfb8d6ef949a4f069591c4097d470b4
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agoMerge "add FLAG_2002_VFM_UPGRADE_ADDITIONAL_OPTIONS"
Ittay Stern [Wed, 20 Nov 2019 15:53:30 +0000 (15:53 +0000)]
Merge "add FLAG_2002_VFM_UPGRADE_ADDITIONAL_OPTIONS"

4 years agoadd FLAG_2002_VFM_UPGRADE_ADDITIONAL_OPTIONS 01/98601/3
Alexey Sandler [Tue, 19 Nov 2019 14:12:18 +0000 (16:12 +0200)]
add FLAG_2002_VFM_UPGRADE_ADDITIONAL_OPTIONS

Issue-ID: VID-649
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: I0a9ba9422c27360a7de11c7496af70e4aba0e38e
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
4 years agofix is a-la-carte cross modern UI 48/98648/1
Eylon Malin [Wed, 20 Nov 2019 08:41:18 +0000 (10:41 +0200)]
fix is a-la-carte cross modern UI

Issue-ID: VID-701
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I6248382d71e6cec54104d42d95b0130d51404410

4 years agoMerge "a-la-carte services new instantiation ui selenium test"
Ittay Stern [Tue, 19 Nov 2019 16:08:53 +0000 (16:08 +0000)]
Merge "a-la-carte services new instantiation ui selenium test"

4 years agoa-la-carte services new instantiation ui selenium test 63/98363/10
Eylon Malin [Wed, 13 Nov 2019 14:41:33 +0000 (16:41 +0200)]
a-la-carte services new instantiation ui selenium test

Issue-ID: VID-701

Change-Id: I72f5245493d0ad3e3cc4447617c4b6a011bfd41c
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agodelete flag FLAG_1911_INSTANTIATION_ORDER_BUTTON_IN_ASYNC_ALACARTE 90/98590/1
Alexey Sandler [Tue, 19 Nov 2019 10:12:02 +0000 (12:12 +0200)]
delete flag FLAG_1911_INSTANTIATION_ORDER_BUTTON_IN_ASYNC_ALACARTE

Issue-ID: VID-646
Signed-off-by: Alexey Sandler <alexey.sandler@intl.att.com>
Change-Id: I828f40fe908dc9608527934f3e6aae32b7d70b96

4 years agoMerge "when automatically add aLaCarte VfModule, rollbackOnFailure is true"
Ittay Stern [Mon, 18 Nov 2019 17:38:03 +0000 (17:38 +0000)]
Merge "when automatically add aLaCarte VfModule, rollbackOnFailure is true"

4 years agoAdjust NewServiceInstanceTest by new logic + revert state-check in getDefaultVolumeGr... 04/98504/3
Amir Skalka [Mon, 18 Nov 2019 08:29:49 +0000 (10:29 +0200)]
Adjust NewServiceInstanceTest by new logic + revert state-check in getDefaultVolumeGroupName

* Change expected behaviour of tests to match new
business of VG naming process; See shouldVGNameBeVisible() in
vfModule.control.generator.ts

* Fix Cypress tests `volume group should change on instance`.

Issue-ID: VID-700
Change-Id: I18faf49a4a31f4b8f389dbcda53c55a1a8066c90
Signed-off-by: Amir Skalka <amir.skalka@intl.att.com>
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agowhen automatically add aLaCarte VfModule, rollbackOnFailure is true 96/98496/1
Eylon Malin [Mon, 18 Nov 2019 11:01:43 +0000 (13:01 +0200)]
when automatically add aLaCarte VfModule, rollbackOnFailure is true

Issue-ID: VID-701
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ide9d3436a9ba281fb4b02ae308da00bd4a121108

4 years agoMerge "Modify code to take care of missing scenario in US 832"
Ittay Stern [Thu, 14 Nov 2019 13:57:11 +0000 (13:57 +0000)]
Merge "Modify code to take care of missing scenario in US 832"

4 years agoModify code to take care of missing scenario in US 832 61/98061/8
Amir Skalka [Wed, 6 Nov 2019 16:19:16 +0000 (18:19 +0200)]
Modify code to take care of missing scenario in US 832

Take under consideration the instance type (Macro/Alacarte)
when determining visibility over UI and default value.
Refactor tests to include more params to anticipate the visibility
and default value.

Issue-ID: VID-700
Signed-off-by: Amir Skalka <amir.skalka@intl.att.com>
Change-Id: I8dfa2e13fed3f5f863cc979970afc2ac66dbd82f

4 years agoAPI test ordering for mso vfModules requests 05/98405/2
Sara Weiss [Thu, 14 Nov 2019 12:23:16 +0000 (14:23 +0200)]
API test ordering for mso vfModules requests

Issue-ID: VID-253
Signed-off-by: Sara Weiss <sara.weiss@intl.att.com>
Change-Id: I9a8594eab3f8e4eacaf503c23f04d1db6b101f90

4 years agoMerge "isALaCarte in modern UI is false only if instantiationType is Macro"
Ittay Stern [Wed, 13 Nov 2019 15:47:40 +0000 (15:47 +0000)]
Merge "isALaCarte in modern UI is false only if instantiationType is Macro"

4 years agoisALaCarte in modern UI is false only if instantiationType is Macro 58/98358/3
Eylon Malin [Wed, 13 Nov 2019 13:54:35 +0000 (15:54 +0200)]
isALaCarte in modern UI is false only if instantiationType is Macro

Issue-ID: VID-701
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: Ie75b1717ffbc856f0c46de954e70b1e047f3cffb

4 years agoRetry Simulator's DB queries upon failure 64/98364/1
Ittay Stern [Wed, 13 Nov 2019 15:06:13 +0000 (17:06 +0200)]
Retry Simulator's DB queries upon failure

In tests env, sometimes DB drops unused connections with error:
java.sql.SQLNonTransientConnectionException: (conn=3439) Connection reset

Issue-ID: VID-647

Change-Id: If8211db653d4b3b3efc4edbe8b3ad6d3dd7d65e2
Signed-off-by: Ittay Stern <ittay.stern@att.com>
4 years agofix browse sdc with macro instantiation type to use unique IDs 56/98356/1
Eylon Malin [Wed, 13 Nov 2019 13:11:15 +0000 (15:11 +0200)]
fix browse sdc with macro instantiation type to use unique IDs

Issue-ID: VID-701
Signed-off-by: Eylon Malin <eylon.malin@intl.att.com>
Change-Id: I6760450d2069495a06e5178f1a51c269e78da22e