Rob Daugherty [Wed, 14 Mar 2018 06:07:32 +0000 (02:07 -0400)]
AT&T 1712 and 1802 release code
This is code from AT&T's 1712 and 1802 releases.
Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04
Issue-ID: SO-425
Signed-off-by: Rob Daugherty <rd472p@att.com>
Seshu Kumar M [Wed, 14 Mar 2018 03:56:16 +0000 (03:56 +0000)]
Merge "Change the copyright to 2018"
Yulian Han [Mon, 12 Mar 2018 11:59:53 +0000 (19:59 +0800)]
Change the copyright to 2018
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f0641c8
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
Seshu Kumar M [Tue, 13 Mar 2018 23:59:46 +0000 (23:59 +0000)]
Merge "Fixed parent reference"
Seshu Kumar M [Tue, 13 Mar 2018 14:32:25 +0000 (14:32 +0000)]
Merge "Add Create SDNC Resource Create Groovy script"
Seshu Kumar M [Tue, 13 Mar 2018 12:57:35 +0000 (12:57 +0000)]
Merge "Unit test coverage"
Seshu Kumar M [Tue, 13 Mar 2018 12:56:05 +0000 (12:56 +0000)]
Merge "Adding Junit"
Seshu Kumar M [Tue, 13 Mar 2018 12:55:42 +0000 (12:55 +0000)]
Merge "Adding Junit"
dfilppi [Tue, 13 Mar 2018 12:05:27 +0000 (12:05 +0000)]
Fixed parent reference
Change-Id: I2d7b0d6025789c0ff60495630f59ed3b70c99510
Issue-ID: SO-448
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
subhash kumar singh [Tue, 13 Mar 2018 09:33:18 +0000 (09:33 +0000)]
Update license for ResourceRequest
Update license for ResourceRequest.
Change-Id: Icb17226758d85368fa8a4de3a6c76332253cdab8
Issue-ID: SO-453
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Chuanyu Chen [Tue, 13 Mar 2018 09:11:30 +0000 (09:11 +0000)]
Merge "Rename vfc ns workflow groovy class name"
c00149107 [Tue, 13 Mar 2018 08:55:41 +0000 (16:55 +0800)]
Add Create SDNC Resource Create Groovy script
Add Create SDNC Resource Create Groovy script
Change-Id: If416a1e40479c51c499c8697ec35a1ab07a1544c
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Chuanyu Chen [Tue, 13 Mar 2018 08:50:58 +0000 (08:50 +0000)]
Merge "Add update e2e Instance subprocess bpmn"
AS00465059 [Tue, 13 Mar 2018 08:44:20 +0000 (14:14 +0530)]
Adding Junit
Adding Junit for:
1.TenantAlreadyExists.java
2.TenantException.java
3.TenantExceptionBean.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-tenant-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Ftenant%2Fexceptions
Change-Id: I314ac62dd18876b0ae08380848a22a26850c9cbe
Issue-ID: SO-475
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
Yulian Han [Mon, 12 Mar 2018 11:59:53 +0000 (19:59 +0800)]
Add update e2e Instance subprocess bpmn
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f0641c7
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
Sumapriya [Tue, 13 Mar 2018 07:05:34 +0000 (12:35 +0530)]
Adding Junit
Adding Junit for:
VfRollback.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-vnf-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fvnf%2FVfRollback.java
Change-Id: I3d17c9f745081386be50441f5565518289bcfe36
Issue-ID: SO-473
Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
c00149107 [Tue, 13 Mar 2018 06:43:50 +0000 (14:43 +0800)]
Rename vfc ns workflow groovy class name
Rename vfc ns workflow groovy class name
Change-Id: Ic021f34515bb30c8785595d19807fbf2ef3025f5
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
sanchitap [Tue, 13 Mar 2018 06:39:24 +0000 (12:09 +0530)]
Unit test coverage
Unit test coverage for
1.RequestInformation.java
2.SDNCEvent.java
Sonar link:
https://sonar.onap.org/code?id=org.onap.so%3Aadapters&selected=org.onap.so.adapters%3Amso-adapters-rest-interface%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdncrest
Change-Id: I9ed76cac33bad1739df441c8f9e0ad77d738e1d6
Issue-ID: SO-467
Signed-off-by: sanchitap <sanchita@techmahindra.com>
Seshu Kumar M [Tue, 13 Mar 2018 05:28:40 +0000 (05:28 +0000)]
Merge "Remove redundant type cast"
Seshu Kumar M [Tue, 13 Mar 2018 05:16:38 +0000 (05:16 +0000)]
Merge "junit adding and refactor for CloudConfig"
Seshu Kumar M [Tue, 13 Mar 2018 05:16:10 +0000 (05:16 +0000)]
Merge "Remove trailing spaces from property files"
Seshu Kumar M [Tue, 13 Mar 2018 05:15:12 +0000 (05:15 +0000)]
Merge "Fix a potentional bug String comparison using !="
Seshu Kumar M [Mon, 12 Mar 2018 14:17:19 +0000 (14:17 +0000)]
Merge "Add SDNC Resource Create Call Common Recipe"
Seshu Kumar M [Mon, 12 Mar 2018 14:15:47 +0000 (14:15 +0000)]
Merge "Adding Junit"
Seshu Kumar M [Mon, 12 Mar 2018 14:15:37 +0000 (14:15 +0000)]
Merge "Adding Junit"
Seshu Kumar M [Mon, 12 Mar 2018 14:12:00 +0000 (14:12 +0000)]
Merge changes I9b4fc5b0,I2a4216c5
* changes:
Adding Junit
Adding Junit
Seshu Kumar M [Mon, 12 Mar 2018 14:08:52 +0000 (14:08 +0000)]
Merge "modify update e2e Instance groovy"
Seshu Kumar M [Mon, 12 Mar 2018 13:59:58 +0000 (13:59 +0000)]
Merge "Fix urls for collecting CSAR info"
subhash kumar singh [Mon, 12 Mar 2018 13:09:26 +0000 (13:09 +0000)]
Fix urls for collecting CSAR info
Fix url for collecting CSAR info from catalogdb.
Change-Id: Ib887e7b733610ac3dfb5388a56c11ad5d477c321
Issue-ID: SO-453
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Lukasz Muszkieta [Wed, 7 Mar 2018 09:18:39 +0000 (10:18 +0100)]
junit adding and refactor for CloudConfig
Change-Id: I3b98e6f8633347970be70e7b93680ec8ed4daacc
Issue-ID: SO-430
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
Yulian Han [Mon, 12 Mar 2018 11:59:53 +0000 (19:59 +0800)]
modify update e2e Instance groovy
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f0641c6
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
AS00465059 [Mon, 12 Mar 2018 10:09:19 +0000 (15:39 +0530)]
Adding Junit
Junit for SDNCResponse.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fimpl%2FSDNCResponse.java
Change-Id: I9b4fc5b0f414ddf8a7229299d482ea0cc51aa21f
Issue-ID: SO-473
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
AS00465059 [Mon, 12 Mar 2018 10:06:35 +0000 (15:36 +0530)]
Adding Junit
Junit for:
1.SDNCServiceError.java
2.SDNCServiceRequest.java
3.SDNCServiceResponse.java
4.ServiceInformation.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapters-rest-interface%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdncrest
Change-Id: I2a4216c509cf0164ad669d391c9af0bbe6a80f25
Issue-ID: SO-470
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
Chuanyu Chen [Mon, 12 Mar 2018 09:56:51 +0000 (09:56 +0000)]
Merge "Rename the default recipe for VFC NS"
c00149107 [Mon, 12 Mar 2018 08:50:02 +0000 (16:50 +0800)]
Add SDNC Resource Create Call Common Recipe
Add SDNC Resource Create Call Common Recipe update
Change-Id: If65289a17748c214b3636ddf0680bddb43171338
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Chuanyu Chen [Mon, 12 Mar 2018 08:39:41 +0000 (08:39 +0000)]
Merge "add main updateInstance flow groovy"
Chuanyu Chen [Mon, 12 Mar 2018 08:39:32 +0000 (08:39 +0000)]
Merge "delete useless method in main updateInstance flow"
c00149107 [Mon, 12 Mar 2018 08:35:42 +0000 (16:35 +0800)]
Rename the default recipe for VFC NS
Rename the default recipe for VFC NS
Change-Id: I55c6cacec69962e4e530ab76518cde59966305de
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Seshu Kumar M [Mon, 12 Mar 2018 08:05:04 +0000 (08:05 +0000)]
Merge changes I5a320c60,I3fbd868e
* changes:
Remove unnecessary simicolon from all java classes
private is redundant for enum constructors
Seshu Kumar M [Mon, 12 Mar 2018 08:04:55 +0000 (08:04 +0000)]
Merge "Swap Optional.isPresent with functional expression"
Chuanyu Chen [Mon, 12 Mar 2018 07:45:19 +0000 (07:45 +0000)]
Merge "Combine the design and runtime parameter"
Yulian Han [Mon, 12 Mar 2018 06:56:06 +0000 (14:56 +0800)]
add main updateInstance flow groovy
Change-Id: Idaa55084f5ecb0dd3636c231cebc14fa5f0641c3
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
Yulian Han [Mon, 12 Mar 2018 06:48:59 +0000 (14:48 +0800)]
delete useless method in main updateInstance flow
Change-Id: Idaa55084f5ecb0dd3636c231cebc14fa5f0641c2
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
subhash kumar singh [Wed, 7 Mar 2018 14:03:28 +0000 (14:03 +0000)]
Combine the design and runtime parameter
Combine designand run time paramters.
Change-Id: Ide61cb14697f137e73308b29b721cedb1bd3e13e
Issue-ID: SO-453
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Chuanyu Chen [Mon, 12 Mar 2018 06:11:45 +0000 (06:11 +0000)]
Merge "Update the VFC NS resource recipe"
c00149107 [Mon, 12 Mar 2018 03:58:22 +0000 (11:58 +0800)]
Update the VFC NS resource recipe
Update the VFC NS resource recipe
Change-Id: Ib5fcd95ac1b0f977c8104e722e57d29becc370bc
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
AS00465059 [Mon, 12 Mar 2018 03:51:23 +0000 (09:21 +0530)]
Adding Junit
Junit for CloudSite.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.so%3Aadapters&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fcloud%2FCloudSite.java
Change-Id: Ic5229c7e0d1226f2edd85715312ef78b5ecb364e
Issue-ID: SO-468
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
AS00465059 [Mon, 12 Mar 2018 03:48:39 +0000 (09:18 +0530)]
Adding Junit
Junit for:
1.MsoTenant.java
2.NetworkRollback.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fopenstack%2Fbeans
Change-Id: Idd9202ff8de43c31d624854877ea29d556d5a31b
Issue-ID: SO-469
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
Yulian Han [Mon, 12 Mar 2018 02:08:59 +0000 (10:08 +0800)]
add main updateInstance bpmn flow
Change-Id: Idaa55084f5ecb0dd3636c231cebc14fa5f0641c4
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
Seshu Kumar M [Sat, 10 Mar 2018 13:18:32 +0000 (13:18 +0000)]
Merge "Remove redundant intValue"
Munir Ahmad [Sat, 10 Mar 2018 00:49:54 +0000 (19:49 -0500)]
Remove redundant type cast
Change-Id: Ie00d5ec5a4677c99a9a689bf18a85055902f6384
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 01:06:57 +0000 (20:06 -0500)]
Remove unnecessary simicolon from all java classes
Change-Id: I5a320c606ea3e0c47efa6d84e8b0cc1ab40f3b70
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 01:03:17 +0000 (20:03 -0500)]
private is redundant for enum constructors
Change-Id: I3fbd868e83651111a6bce6c268ed4d7cf84c3fd5
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:59:34 +0000 (19:59 -0500)]
Swap Optional.isPresent with functional expression
Change-Id: Id4b724b189f98c89e3e038b154990a95733e0624
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:40:52 +0000 (19:40 -0500)]
Remove trailing spaces from property files
Change-Id: I2b7fdfb8121eaddcb618af2117f534c27766feee
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:38:02 +0000 (19:38 -0500)]
Fix a potentional bug String comparison using !=
Change-Id: If4e3199dfb0210085e97997133a3cec83d6d99e5
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:30:52 +0000 (19:30 -0500)]
Simplify boolean expressions in groovy
Change-Id: I8dc254337f5975c2af6a2de74f20eff919993cf2
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:19:35 +0000 (19:19 -0500)]
Replace String concatination with chained append
Change-Id: I7780265c1744b3677718461c1f3013465e83535f
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 10 Mar 2018 00:02:20 +0000 (19:02 -0500)]
Remove redundant intValue
Change-Id: Iecc0cd25f0c8ecd2c8dc9b4d9b09c66a6394cb83
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Rob Daugherty [Fri, 9 Mar 2018 22:57:28 +0000 (22:57 +0000)]
Merge "Pom parents fixed in aria build."
Rob Daugherty [Fri, 9 Mar 2018 22:34:02 +0000 (22:34 +0000)]
Merge "Update resource recipe parameter prepare logic"
Rob Daugherty [Fri, 9 Mar 2018 22:19:07 +0000 (22:19 +0000)]
Merge "Fix some Sonar Blockers in workflow/serviceTask"
Rob Daugherty [Fri, 9 Mar 2018 22:15:44 +0000 (22:15 +0000)]
Merge "Collapse catch clauses where applicable"
dfilppi [Fri, 9 Mar 2018 20:34:30 +0000 (20:34 +0000)]
Pom parents fixed in aria build.
Change-Id: Idaf76197b8542dcebb5b242204d076c55892228c
Issue-ID: SO-448
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Rob Daugherty [Fri, 9 Mar 2018 20:02:18 +0000 (15:02 -0500)]
Revert Reduce log noise/warnings
This reverts commit
327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e.
It is seriously impeding our ability complete the promised merge of AT&T
1802 code.
While I'm all for coding standards, if we are serious about using spaces
instead of tabs, then I think we need to (1) agree with the community when
this will happen, (2) do consistently in all files, and (3) enforce it.
Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff
Issue-ID: SO-368
Signed-off-by: Rob Daugherty <rd472p@att.com>
Munir Ahmad [Fri, 9 Mar 2018 13:20:47 +0000 (08:20 -0500)]
Collapse catch clauses where applicable
Change-Id: Idf9546b9d59bf23547bac4aa4f0fbee4f97a0255
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Fri, 9 Mar 2018 13:32:57 +0000 (08:32 -0500)]
Remove redundant groupId inherited from parent
Change-Id: If1df4b792fca2a127e169e393268d63ef31d9ed1
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Seshu Kumar M [Fri, 9 Mar 2018 10:00:26 +0000 (10:00 +0000)]
Merge "Reduce log noise/warnings format to conventions"
c00149107 [Fri, 9 Mar 2018 08:54:28 +0000 (16:54 +0800)]
Update resource recipe parameter prepare logic
Update resource recipe parameter prepare logic
Change-Id: Iefb4964f059a92e3df4000627b8b404174bfb804
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Chuanyu Chen [Fri, 9 Mar 2018 08:17:35 +0000 (08:17 +0000)]
Merge "Support resource generic workflow Inputs"
c00149107 [Fri, 9 Mar 2018 06:22:14 +0000 (14:22 +0800)]
Support resource generic workflow Inputs
Support resource generic workflow Inputs
Change-Id: I1a627a573b13d12319459dc45839efbfd3cc3acc
Issue-ID: SO-452
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
Seshu Kumar M [Fri, 9 Mar 2018 06:03:03 +0000 (06:03 +0000)]
Merge "Sonar:Critical"
Shashank Kumar Shankar [Mon, 5 Mar 2018 22:35:40 +0000 (14:35 -0800)]
Fix some Sonar Blockers in workflow/serviceTask
Some files in which the sonar code fixes are done:
https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3AMSOInfrastructureBPMN%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fbpmn%2Finfrastructure%2Fworkflow%2FserviceTask
Change-Id: I6c25c6553008c8cea53b11a71dbe89c28b3bb441
Issue-ID: SO-455
Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
Marcus G K Williams [Thu, 8 Mar 2018 02:17:22 +0000 (18:17 -0800)]
Reduce log noise/warnings format to conventions
Reduce build log warnings by formatting tests
to ONAP code conventions (removing tabs etc.)
Issue-ID: SO-368
Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
Seshu Kumar M [Thu, 8 Mar 2018 07:50:00 +0000 (07:50 +0000)]
Merge "Replace explicit type with diamond notation"
Seshu Kumar M [Thu, 8 Mar 2018 07:49:24 +0000 (07:49 +0000)]
Merge "Make use of contains instead of indexOf"
Seshu Kumar M [Thu, 8 Mar 2018 07:48:44 +0000 (07:48 +0000)]
Merge "Remove redundant String constructor calls"
Seshu Kumar M [Thu, 8 Mar 2018 07:39:08 +0000 (07:39 +0000)]
Merge "Swap StringBuilder with string where makes sense"
Seshu Kumar M [Thu, 8 Mar 2018 07:37:54 +0000 (07:37 +0000)]
Merge "Remove redundant declaration of extending object"
Seshu Kumar M [Thu, 8 Mar 2018 07:36:44 +0000 (07:36 +0000)]
Merge "Remove unused code"
Seshu Kumar M [Thu, 8 Mar 2018 07:07:58 +0000 (07:07 +0000)]
Merge "Make use of try with resource"
Seshu Kumar M [Thu, 8 Mar 2018 07:06:56 +0000 (07:06 +0000)]
Merge "Make use of lambda"
Seshu Kumar M [Thu, 8 Mar 2018 06:54:51 +0000 (06:54 +0000)]
Merge "Swap Collection.sort with list.sort"
Seshu Kumar M [Thu, 8 Mar 2018 06:46:29 +0000 (06:46 +0000)]
Merge "Swap if statement with switch"
Munir Ahmad [Thu, 8 Mar 2018 00:06:52 +0000 (19:06 -0500)]
Replace explicit type with diamond notation
Change-Id: Ibcd42f05c7850e536759207a4d316396956da05b
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Thu, 8 Mar 2018 00:08:43 +0000 (19:08 -0500)]
Make use of contains instead of indexOf
Change-Id: Ia695d6aed572c611ed8ead494a86c78558e848e3
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Thu, 8 Mar 2018 00:13:15 +0000 (19:13 -0500)]
Remove redundant String constructor calls
Change-Id: Ie84464ad849100faad1aefcd41175766e8c17ad4
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Thu, 8 Mar 2018 00:21:48 +0000 (19:21 -0500)]
Swap StringBuilder with string where makes sense
Change-Id: I3faaa90d97e936b0d86282db5958e1048460ee81
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Thu, 8 Mar 2018 00:25:20 +0000 (19:25 -0500)]
Remove redundant declaration of extending object
Change-Id: Iee7e4fc93dd82cab27986335560a41000851c33d
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Thu, 8 Mar 2018 00:01:10 +0000 (19:01 -0500)]
Make use of try with resource
Change-Id: Ib3e7ac5f1febc3d7b0da3adc2eb191c41a7473a6
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 7 Mar 2018 23:59:13 +0000 (18:59 -0500)]
Make use of lambda
Change-Id: I482b874a3e7e686068450c7b5ddf45e2b8ae0d47
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Wed, 7 Mar 2018 23:55:19 +0000 (18:55 -0500)]
Swap Collection.sort with list.sort
Change-Id: Id56bcc3ad3696b5068b9465e9951f211ac467cb3
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Munir Ahmad [Sat, 3 Mar 2018 01:33:43 +0000 (20:33 -0500)]
Remove unused code
Change-Id: I504f083d6055ea348f3a3547aba9d3de0611cd20
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Rob Daugherty [Wed, 7 Mar 2018 18:51:28 +0000 (18:51 +0000)]
Merge "Swap indexOf with contains"
Rob Daugherty [Wed, 7 Mar 2018 18:49:18 +0000 (18:49 +0000)]
Merge "modify bug for UT case"
Rob Daugherty [Wed, 7 Mar 2018 18:48:37 +0000 (18:48 +0000)]
Merge "Store NB Create req. userParam - Customer_Location"
Rob Daugherty [Wed, 7 Mar 2018 18:45:32 +0000 (18:45 +0000)]
Merge "Remove redundant catch clause"
Rob Daugherty [Wed, 7 Mar 2018 18:32:31 +0000 (18:32 +0000)]
Merge "Fix javadoc"
subhash kumar singh [Wed, 7 Mar 2018 11:42:21 +0000 (11:42 +0000)]
Fix Aria compilation issue
Disable Aria from pom file to stop build fail.
Issue-ID: SO-448
Change-Id: I071eb8fda068fd53db5d6f57ccb8f1c0c5f0d74f
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Munir Ahmad [Sat, 3 Mar 2018 01:06:26 +0000 (20:06 -0500)]
Swap indexOf with contains
Change-Id: I609d307acf504ea7ff25ed3327a3d4e0e4686755
Issue-ID: SO-437
Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
Code Review / so.git / log