so.git
5 years agoadded back in so monitoring to parent pom 33/79033/1
Kalkere Ramesh, Sharan (sk720x) [Fri, 22 Feb 2019 19:05:16 +0000 (14:05 -0500)]
added back in so monitoring to parent pom

Fix startup of catalog, request, bpmn and openstack

Change-Id: I7ef86a8ba81625cc0bdda35c3dcdf12b37ef2821
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
5 years agoMerge "assignvfmodulebb must send use-preload"
Steve Smokowski [Fri, 22 Feb 2019 15:14:25 +0000 (15:14 +0000)]
Merge "assignvfmodulebb must send use-preload"

5 years agoMerge "Fix for when Customization already exists"
Steve Smokowski [Fri, 22 Feb 2019 15:14:20 +0000 (15:14 +0000)]
Merge "Fix for when Customization already exists"

5 years agoMerge "fix potential nullpointer from sonar"
Steve Smokowski [Fri, 22 Feb 2019 15:13:58 +0000 (15:13 +0000)]
Merge "fix potential nullpointer from sonar"

5 years agoMerge "Change interface name to be more suitable"
Lukasz Muszkieta [Fri, 22 Feb 2019 14:05:42 +0000 (14:05 +0000)]
Merge "Change interface name to be more suitable"

5 years agofix potential nullpointer from sonar 93/78993/1
k.kazak [Fri, 22 Feb 2019 08:00:16 +0000 (09:00 +0100)]
fix potential nullpointer from sonar

MsoMulticloudUtils: multicloudClient may be null
throw MsoException if it is null (instead of NullPointer)
removed unnecessary StackInfo object creation
using format specifiers for a logger instead of String concatenation
removed else block to make the code easier to read
Added tests for the method

Change-Id: I80d2e0ba2ef2d20c488cdfcf103d9cfa5784ab65
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoupdated base yamls to properly connect to DB 81/78981/1
Kalkere Ramesh, Sharan (sk720x) [Thu, 21 Feb 2019 23:34:56 +0000 (18:34 -0500)]
updated base yamls to properly connect to DB

Fix startup of catalog, request, bpmn and openstack

Change-Id: I83dcd17d03c71301610ab2c8bbeb30142cc14303
Issue-ID: SO-1558
Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
5 years agoMerge "remove unneeded code"
Steve Smokowski [Thu, 21 Feb 2019 16:43:01 +0000 (16:43 +0000)]
Merge "remove unneeded code"

5 years agoremove unneeded code 40/78940/1
Lukasz Muszkieta [Thu, 21 Feb 2019 15:23:29 +0000 (16:23 +0100)]
remove unneeded code

Change-Id: Ib1a62a8cf3a0335bf163ca2634c86e95d2a258b8
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoMerge "Fixed major Sonar issues in ServicePluginFactory"
Steve Smokowski [Thu, 21 Feb 2019 13:28:45 +0000 (13:28 +0000)]
Merge "Fixed major Sonar issues in ServicePluginFactory"

5 years agoMerge "Updated as per review comments"
Steve Smokowski [Thu, 21 Feb 2019 13:27:29 +0000 (13:27 +0000)]
Merge "Updated as per review comments"

5 years agoChange interface name to be more suitable 20/78920/1
Lukasz Muszkieta [Thu, 21 Feb 2019 12:28:55 +0000 (13:28 +0100)]
Change interface name to be more suitable

Change-Id: Ifb4f6bc7f3e18974e9a11a17d474ad989c043673
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoFixed major Sonar issues in ServicePluginFactory 05/78905/1
r.bogacki [Thu, 21 Feb 2019 10:01:22 +0000 (11:01 +0100)]
Fixed major Sonar issues in ServicePluginFactory

Removed not used variable.
Removed unnecessary castings.
Cleaned diamond operators.
Removed commented out block of code.

Change-Id: I0adca822f6dcb9efaa1ea96c9ff9092a7a2baa84
Issue-ID: SO-1552
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agoUpdated as per review comments 88/78888/1
Prema Bhatt [Thu, 21 Feb 2019 00:50:10 +0000 (16:50 -0800)]
Updated as per review comments

This git review replaces https://gerrit.onap.org/r/#/c/78430/. As I had
some issues updating the existing git review, I'm creating a new one.

Issue-ID: SO-1391
Change-Id: Ida3f94ad7e2249a30a99d67a071930323ba743b5
Signed-off-by: Prema Bhatt <pb6115@att.com>
5 years agoContinue to separate AAIClient into GraphInventory 83/78883/2
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:53:01 +0000 (16:53 -0500)]
Continue to separate AAIClient into GraphInventory

added narad specific relationship implementation
add mapper to narad rest client
wrapper now returns correct relationships type
equals now longer only works on AAIUris

Change-Id: I12325f76ae08659ffe744a56f5e6b6d54196b054
Issue-ID: SO-1541
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix for when Customization already exists 81/78881/1
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:50:13 +0000 (16:50 -0500)]
Fix for when Customization already exists

- When the Customization already exists associate the new
NetworkResource with it.

Change-Id: Ia4d89a04d020dd2f2ba4a2f2d330bda9bff6da14
Issue-ID: SO-1540
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoassignvfmodulebb must send use-preload 80/78880/1
Benjamin, Max (mb388a) [Wed, 20 Feb 2019 21:48:49 +0000 (16:48 -0500)]
assignvfmodulebb must send use-preload

Corrections to JUnit data to account for usePreload usage.
Resurrect usage of usePreload value and pass fromPreload to SDNC.

Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3
Issue-ID: SO-1539
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Fixed possible NPE in WorkflowAction"
Steve Smokowski [Wed, 20 Feb 2019 16:48:32 +0000 (16:48 +0000)]
Merge "Fixed possible NPE in WorkflowAction"

5 years agoMerge "fix sonar blocker try-with-resources"
Steve Smokowski [Wed, 20 Feb 2019 16:48:07 +0000 (16:48 +0000)]
Merge "fix sonar blocker try-with-resources"

5 years agoMerge "Cleaned up Sonar issues in AuditStackServiceData"
Steve Smokowski [Wed, 20 Feb 2019 15:12:40 +0000 (15:12 +0000)]
Merge "Cleaned up Sonar issues in AuditStackServiceData"

5 years agoCleaned up Sonar issues in AuditStackServiceData 44/78844/1
r.bogacki [Wed, 20 Feb 2019 14:03:48 +0000 (15:03 +0100)]
Cleaned up Sonar issues in AuditStackServiceData

Removed unnecessary imports.
Removed unnecessary cast to "String".

Change-Id: I8b14b0f53860edb656b38914941c44003a625037
Issue-ID: SO-1537
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agoFixed possible NPE in WorkflowAction 05/78805/4
r.bogacki [Tue, 19 Feb 2019 14:03:41 +0000 (15:03 +0100)]
Fixed possible NPE in WorkflowAction

NullPointerException could be thrown
in case when resource == null.

Change-Id: I1f78e4733187f3086ac1915d2bfb098fb8c4aabd
Issue-ID: SO-1530
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agoMerge "Create Pre Building Block validator"
Steve Smokowski [Wed, 20 Feb 2019 13:13:45 +0000 (13:13 +0000)]
Merge "Create Pre Building Block validator"

5 years agoMerge "flowvaldiator will allow more flexible filtering"
Steve Smokowski [Wed, 20 Feb 2019 13:13:38 +0000 (13:13 +0000)]
Merge "flowvaldiator will allow more flexible filtering"

5 years agoMerge "Update to set correct cvnfc code"
Steve Smokowski [Wed, 20 Feb 2019 13:13:32 +0000 (13:13 +0000)]
Merge "Update to set correct cvnfc code"

5 years agoCreate Pre Building Block validator 87/78787/2
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 23:00:41 +0000 (18:00 -0500)]
Create Pre Building Block validator

Use Flowvalidator shouldRunFor method to check if flow needs to be
validated.
Create Pre Building Block validator to check if cloud-region
orchestration-disabled is true

Change-Id: I2f1dca16c97505292d9b99f7e206713e4963261f
Issue-ID: SO-1534
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoflowvaldiator will allow more flexible filtering 86/78786/1
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:55:41 +0000 (17:55 -0500)]
flowvaldiator will allow more flexible filtering

fixed unit tests that reference forItems()
forItems is now shouldRunFor allowing more flexibility

Change-Id: I497f3a2899ae4df555e781c7c85a238e657fcba8
Issue-ID: SO-1533
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoUpdate to set correct cvnfc code 85/78785/1
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:51:14 +0000 (17:51 -0500)]
Update to set correct cvnfc code

- Update testcase naming code to oamfw for testCvnfc.
- Update to set correct cvnfc nfc_function and nfc_naming_code

Change-Id: I13eca10d4d76a24753eca99e3f6ff96d0cc408f4
Issue-ID: SO-1532
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdded the conversion of decrypted value 84/78784/1
Benjamin, Max (mb388a) [Tue, 19 Feb 2019 22:48:46 +0000 (17:48 -0500)]
Added the conversion of decrypted value

Added jUnit test for the conversion of decrypted value to Basic
Base64Binary.
Added the conversion of decrypted value as Basic Base64Binary.

Change-Id: I361cbe3dac61df2728c9f58c314a21b3cc764a9f
Issue-ID: SO-1531
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Validate inputs for pnf association"
Lukasz Muszkieta [Tue, 19 Feb 2019 15:42:21 +0000 (15:42 +0000)]
Merge "Validate inputs for pnf association"

5 years agofix sonar blocker try-with-resources 63/78763/1
k.kazak [Tue, 19 Feb 2019 14:39:56 +0000 (15:39 +0100)]
fix sonar blocker try-with-resources

BpmnInstaller: use try-with-resources in containsWorkflows
remove unnecessary type casting to ZipEntry
BpmnInstallerTest: add tests for containsWorkflows
fix test for installBpmn (was silently failing with file not found)

Change-Id: I3122bcd19204bf498fe1a9b10630076e2df9d70b
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoMerge "fix sonar potential nullpointer"
Steve Smokowski [Tue, 19 Feb 2019 13:27:46 +0000 (13:27 +0000)]
Merge "fix sonar potential nullpointer"

5 years agofix sonar potential nullpointer 34/78734/1
k.kazak [Tue, 19 Feb 2019 08:06:56 +0000 (09:06 +0100)]
fix sonar potential nullpointer

AppcRunTasks: fix potential null pointer if vnf = null
AppcRunTasksTest: add tests for this case and the method itself

Change-Id: I63b37670541ef5ff31b03b0336d990677b753fc5
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoset version when using constructor 91/78691/1
Benjamin, Max (mb388a) [Mon, 18 Feb 2019 17:50:57 +0000 (12:50 -0500)]
set version when using constructor

set version when using constructor

Change-Id: Iaa7c74c8189eb4c607f25fe3f1660c08e80b2586
Issue-ID: SO-1529
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "fix sonar critical bug"
Steve Smokowski [Mon, 18 Feb 2019 13:29:06 +0000 (13:29 +0000)]
Merge "fix sonar critical bug"

5 years agoMerge "fix critical sonar bugs"
Steve Smokowski [Mon, 18 Feb 2019 13:28:05 +0000 (13:28 +0000)]
Merge "fix critical sonar bugs"

5 years agoValidate inputs for pnf association 33/75733/6
Joanna Jeremicz [Thu, 10 Jan 2019 08:22:46 +0000 (09:22 +0100)]
Validate inputs for pnf association

Issue-ID: SO-1274
Change-Id: I3fdb66ef4bd259bef46c6f092d7d142b6cb5d9dc
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
5 years agoUse APIH credentials in 'mso.db.auth' 02/78602/1
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 22:49:16 +0000 (17:49 -0500)]
Use APIH credentials in 'mso.db.auth'

Updated to use methods: env.getRequiredProperty() and msoLogger.error().
Added the msoKey and the CryptoUtils.decrypt() code, and used
"mso.camundaAuth".
Used APIH credentials in 'mso.db.auth' as source instead of
'mso.camundaAuth' (need decrypt code by CryptoUtils).

Change-Id: I66c9d96db8137c1d9a5b56aa33d14587cbaa7b9e
Issue-ID: SO-1517
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofix sonar critical bug 71/78571/1
k.kazak [Fri, 15 Feb 2019 16:27:08 +0000 (17:27 +0100)]
fix sonar critical bug

MsoHeatUtils: remove unnecessary heatClient check for null
1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309
2. heatClient is never null: method creates a new object or throws Exception
MsoHeatUtilsTest: added tests for getHeatClient and createStack methods
BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them
StubOpenStack: added stubs for getStack and unsuccessful authorization
removed unused imports

Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2
Issue-ID: SO-1516
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoMerge "query clients now set their expected object"
Steve Smokowski [Fri, 15 Feb 2019 14:23:49 +0000 (14:23 +0000)]
Merge "query clients now set their expected object"

5 years agoMerge "fix issue where we attempt audit with no servers"
Steve Smokowski [Fri, 15 Feb 2019 12:40:24 +0000 (12:40 +0000)]
Merge "fix issue where we attempt audit with no servers"

5 years agoMerge "updated camunda springboot version"
Steve Smokowski [Fri, 15 Feb 2019 12:40:15 +0000 (12:40 +0000)]
Merge "updated camunda springboot version"

5 years agoMerge "Process query of Network Policies from A&AI"
Steve Smokowski [Fri, 15 Feb 2019 12:39:02 +0000 (12:39 +0000)]
Merge "Process query of Network Policies from A&AI"

5 years agoMerge "extract subinterface_network_quantity from policy"
Steve Smokowski [Fri, 15 Feb 2019 12:38:58 +0000 (12:38 +0000)]
Merge "extract subinterface_network_quantity from policy"

5 years agoquery clients now set their expected object 34/78534/1
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:59:07 +0000 (19:59 -0500)]
query clients now set their expected object

unit test is using the wrong number of keys for aai uri
query clients now set their expected object for method

Change-Id: I622c76cee0e9d47be35a78156267bf1c22cbf404
Issue-ID: SO-1514
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofix issue where we attempt audit with no servers 33/78533/1
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:54:00 +0000 (19:54 -0500)]
fix issue where we attempt audit with no servers

fix issue where we attempt audit with no servers

Change-Id: I47f76121c616bf65a5f8be73910adcc0d7088bdb
Issue-ID: SO-1513
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoupdated camunda springboot version 32/78532/1
Benjamin, Max (mb388a) [Fri, 15 Feb 2019 00:52:29 +0000 (19:52 -0500)]
updated camunda springboot version

Added required unimplemented methods to classes

Change-Id: I1ab6333582f2f09c6c363786c8168fdf54936bf8
Issue-ID: SO-1512
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoProcess query of Network Policies from A&AI 28/78528/1
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:14:00 +0000 (18:14 -0500)]
Process query of Network Policies from A&AI

Process query of Network Policies from A&AI as a NetworkPolicies object.

Change-Id: I01b4c00e3732a5518ddc21d08740c0684de86d5e
Issue-ID: SO-1511
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoextract subinterface_network_quantity from policy 27/78527/1
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:12:24 +0000 (18:12 -0500)]
extract subinterface_network_quantity from policy

- Removed duplicate code that was causing a NumberFormatException
- Changed name from crTarget to policyNetworkCollection
- Added code to check we are setting the quantity on the correct
NetworkCollection
- Added code to extract the subinterface_network_quantity from the
nodeTemplate policy

Change-Id: Id12fa0241f16bfd4467209f08af5068d57b2d049
Issue-ID: SO-1510
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoalways increment gCurrentSequence 26/78526/1
Benjamin, Max (mb388a) [Thu, 14 Feb 2019 23:10:29 +0000 (18:10 -0500)]
always increment gCurrentSequence

always increment gCurrentSequence to properly interact with retry and
rollback logic

Change-Id: I7e99973682f93f891c8d35a4f3699ba17a05bc15
Issue-ID: SO-1509
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "fix fields not set correctly in Fabric Policy dist"
Marcus Williams [Thu, 14 Feb 2019 20:02:18 +0000 (20:02 +0000)]
Merge "fix fields not set correctly in Fabric Policy dist"

5 years agoMerge "cloud config migration from openstack to catdb"
Steve Smokowski [Thu, 14 Feb 2019 16:34:28 +0000 (16:34 +0000)]
Merge "cloud config migration from openstack to catdb"

5 years agoMerge "fix major sonar bug"
Steve Smokowski [Thu, 14 Feb 2019 16:33:22 +0000 (16:33 +0000)]
Merge "fix major sonar bug"

5 years agoMerge "fixed CandidateType json serialization"
Steve Smokowski [Thu, 14 Feb 2019 16:32:40 +0000 (16:32 +0000)]
Merge "fixed CandidateType json serialization"

5 years agoMerge "add new functionality to aai client"
Steve Smokowski [Thu, 14 Feb 2019 16:32:33 +0000 (16:32 +0000)]
Merge "add new functionality to aai client"

5 years agoMerge "workflow action should read config for max retries"
Steve Smokowski [Thu, 14 Feb 2019 16:32:24 +0000 (16:32 +0000)]
Merge "workflow action should read config for max retries"

5 years agoMerge "Update Working with SO Docker Documentation"
Steve Smokowski [Thu, 14 Feb 2019 16:32:13 +0000 (16:32 +0000)]
Merge "Update Working with SO Docker Documentation"

5 years agoMerge "Remove un-needed cacheing layer for OS Clients"
Steve Smokowski [Thu, 14 Feb 2019 16:31:37 +0000 (16:31 +0000)]
Merge "Remove un-needed cacheing layer for OS Clients"

5 years agoMerge "Strip off TenantId from self link url"
Steve Smokowski [Thu, 14 Feb 2019 13:14:09 +0000 (13:14 +0000)]
Merge "Strip off TenantId from self link url"

5 years agofix critical sonar bugs 91/78391/3
k.kazak [Thu, 14 Feb 2019 08:20:50 +0000 (09:20 +0100)]
fix critical sonar bugs

Restore interrupted state when InterruptedException is thrown in SDNCRestClient
Added test for this case
Replaced formatting anchor with text empty object in GraphInventoryResultWrapper
Escaped anchor is also considered as bug by sonar
Case is already covered in AAIResultWrapperTest
Marked comparison of the same object as false positive in EqualsAndHashCodeTester
Added clearer comment to this comparison

Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f
Issue-ID: SO-1492
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoStrip off TenantId from self link url 99/78399/2
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 15:18:48 +0000 (10:18 -0500)]
Strip off TenantId from self link url

Strip off TenantId from self link url

Change-Id: I58ac9fe693059eb8cb93d85fb88604cb9c0a0db2
Issue-ID: SO-1502
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofixed CandidateType json serialization 12/78412/1
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 16:44:35 +0000 (11:44 -0500)]
fixed CandidateType json serialization

fixed CandidateType json serialization

Change-Id: Icafa5884db5424167c7fac08ad6aae5781bdafa5
Issue-ID: SO-1503
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "Associate PNF instance with Service"
Lukasz Muszkieta [Wed, 13 Feb 2019 16:39:49 +0000 (16:39 +0000)]
Merge "Associate PNF instance with Service"

5 years agoworkflow action should read config for max retries 00/78400/1
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 15:19:40 +0000 (10:19 -0500)]
workflow action should read config for max retries

workflow action should also read config for max retries

Change-Id: Ib0617b59ca95df7c82fb2ab54895c9c83586f02f
Issue-ID: SO-1504
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoadd new functionality to aai client 98/78398/1
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 15:06:03 +0000 (10:06 -0500)]
add new functionality to aai client

Remove only the first occurrence of parentUri from uriTemplate.
add createIfNotExists to transaction clients
moved classes to generic GraphInventory location
removed unused interfaces from graphinventory client
refactored all graph inventory clients

Change-Id: I2b946674ff92c44d33fff2f327e96655ed5c0195
Issue-ID: SO-1501
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRemove un-needed cacheing layer for OS Clients 95/78395/1
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 15:01:47 +0000 (10:01 -0500)]
Remove un-needed cacheing layer for OS Clients

Remove un-needed cacheing layer for OS Clients

Change-Id: I7fbb6e23a3c34f65286202ec4dad1fb051991cf0
Issue-ID: SO-1500
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agofix fields not set correctly in Fabric Policy dist 94/78394/1
Benjamin, Max (mb388a) [Wed, 13 Feb 2019 14:58:59 +0000 (09:58 -0500)]
fix fields not set correctly in Fabric Policy dist

- Added a null check for vfModuleMemberName.
- Added some extra logging to show the VF members and cvnfc template
name
- Updated to fix fields not set correctly in Fabric Policy
distributions.

Change-Id: Iaef2114a910ad10ff788b2178953883b0c5269da
Issue-ID: SO-1499
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoUpdate Working with SO Docker Documentation 93/78393/1
mohamed waly [Wed, 13 Feb 2019 14:42:45 +0000 (14:42 +0000)]
Update Working with SO Docker Documentation

patch description: Update Working with SO Docker
documentation for casablanca release.

Change-Id: If7a4601e83e0ca83f99a9f74e1f282abc3854bdd
Issue-ID: SO-1505
Signed-off-by: mohamed waly <mohamed.waly@orange.com>
5 years agoMerge "Fixed possible NPE in ResourceRequestBuilder"
Steve Smokowski [Wed, 13 Feb 2019 14:01:53 +0000 (14:01 +0000)]
Merge "Fixed possible NPE in ResourceRequestBuilder"

5 years agoMerge "use encrypted auth for dmaap"
Steve Smokowski [Wed, 13 Feb 2019 14:01:02 +0000 (14:01 +0000)]
Merge "use encrypted auth for dmaap"

5 years agoAssociate PNF instance with Service 62/75862/4
Lukasz Muszkieta [Wed, 16 Jan 2019 10:29:46 +0000 (11:29 +0100)]
Associate PNF instance with Service

Change-Id: I19e25e0daae042b30138bbfc074b0e651b8b1c01
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agoFixed possible NPE in ResourceRequestBuilder 81/78281/4
r.bogacki [Tue, 12 Feb 2019 10:41:29 +0000 (11:41 +0100)]
Fixed possible NPE in ResourceRequestBuilder

According to Sonar current implementation could cause
NullPointerException.
Added JUnit test.

Change-Id: I840c018bed346d85e2042c7308bdd27197f50b46
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
5 years agofix major sonar bug 25/78225/3
k.kazak [Tue, 12 Feb 2019 14:22:29 +0000 (15:22 +0100)]
fix major sonar bug

Removed useless 'instanceof' operator as it always resolves as true
Replaced it with checking for null
Removed unused imports
Added information about modifications on the top
Added junit tests for the method

Change-Id: I7a902ad2852e0ed0d507a6309857a1bab74921de
Issue-ID: SO-1491
Signed-off-by: k.kazak <k.kazak@samsung.com>
5 years agoMerge "Add Pagination and sorting"
Steve Smokowski [Tue, 12 Feb 2019 13:00:16 +0000 (13:00 +0000)]
Merge "Add Pagination and sorting"

5 years agoMerge "Add junit tests for AdapterRestClient"
Steve Smokowski [Mon, 11 Feb 2019 22:12:16 +0000 (22:12 +0000)]
Merge "Add junit tests for AdapterRestClient"

5 years agoMerge "Fix for asdc service."
Steve Smokowski [Mon, 11 Feb 2019 22:12:06 +0000 (22:12 +0000)]
Merge "Fix for asdc service."

5 years agoMerge "Fix unmarshalling errors"
Steve Smokowski [Mon, 11 Feb 2019 22:12:00 +0000 (22:12 +0000)]
Merge "Fix unmarshalling errors"

5 years agoMerge "made max retries configurable via mso config"
Steve Smokowski [Mon, 11 Feb 2019 22:11:53 +0000 (22:11 +0000)]
Merge "made max retries configurable via mso config"

5 years agomade max retries configurable via mso config 51/78251/1
Benjamin, Max (mb388a) [Mon, 11 Feb 2019 20:08:59 +0000 (15:08 -0500)]
made max retries configurable via mso config

fixed an error with the wrong variable being printed
made max retries configurable via mso config

Change-Id: Iec6d209ec2868200ec5956e269b6a048d7619307
Issue-ID: SO-1495
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix for asdc service. 50/78250/1
Benjamin, Max (mb388a) [Mon, 11 Feb 2019 20:06:33 +0000 (15:06 -0500)]
Fix for asdc service.

Removed exception statements and added assert statements
Updated to make sure duplicate config resources aren't getting added
to the service.

Change-Id: Ic05421711622492e09bc83d8cc126300362ea119
Issue-ID: SO-1496
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoFix unmarshalling errors 49/78249/1
Benjamin, Max (mb388a) [Mon, 11 Feb 2019 20:05:27 +0000 (15:05 -0500)]
Fix unmarshalling errors

add data assertion to network update unit test
Fix unmarshalling errors on updateNetworkResp and err

Change-Id: Iddc13514198b3c89718b1b953a06cec6db190269
Issue-ID: SO-1494
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agorestructured a&ai client 48/78248/1
Benjamin, Max (mb388a) [Mon, 11 Feb 2019 19:56:03 +0000 (14:56 -0500)]
restructured a&ai client

made generics a bit safer and updated groovy tests

Change-Id: I6d7a2567cd9bf795e0cfa4914a7674a4ed5f50c4
Issue-ID: SO-1493
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoAdd Pagination and sorting 39/78139/2
Andrei_Barcovschi [Fri, 8 Feb 2019 03:13:29 +0000 (03:13 +0000)]
Add Pagination and sorting

Change-Id: I1374472395a5a2af712c5f06c756c013de08bd27
Issue-ID: SO-1406
Signed-off-by: Andrei_Barcovschi <andrei.barcovschi@ericsson.com>
5 years agoMerge "added license headers to various java files"
Steve Smokowski [Mon, 11 Feb 2019 13:09:07 +0000 (13:09 +0000)]
Merge "added license headers to various java files"

5 years agoMerge "fix cvnfc bean and repository access"
Steve Smokowski [Mon, 11 Feb 2019 13:08:59 +0000 (13:08 +0000)]
Merge "fix cvnfc bean and repository access"

5 years agoMerge "Increase long poll DMaaP timeout value to 60"
Steve Smokowski [Mon, 11 Feb 2019 13:08:50 +0000 (13:08 +0000)]
Merge "Increase long poll DMaaP timeout value to 60"

5 years agoMerge "Remove resources that are not neutron networks"
Steve Smokowski [Mon, 11 Feb 2019 13:08:42 +0000 (13:08 +0000)]
Merge "Remove resources that are not neutron networks"

5 years agofix cvnfc bean and repository access 64/78164/1
Benjamin, Max (mb388a) [Fri, 8 Feb 2019 22:51:38 +0000 (17:51 -0500)]
fix cvnfc bean and repository access

update repository id field type for
fix cvnfc bean and repository access

Change-Id: Ic4785387ffdbb544e649d9e7be40aed5e0ab9502
Issue-ID: SO-1489
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoIncrease long poll DMaaP timeout value to 60 63/78163/1
Benjamin, Max (mb388a) [Fri, 8 Feb 2019 22:47:52 +0000 (17:47 -0500)]
Increase long poll DMaaP timeout value to 60

Corrected a JUnit to include updated timeout value.
Increase long poll DMaaP timeout value to 60 seconds

Change-Id: I22a6f17bc694b17b14f25c7dccd6b57d89d0c2b7
Issue-ID: SO-1488
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoadded license headers to various java files 62/78162/1
Benjamin, Max (mb388a) [Fri, 8 Feb 2019 22:46:52 +0000 (17:46 -0500)]
added license headers to various java files

added license headers to various java files

Change-Id: Icd93ba2943f9ab9a4298a7bf91a1b2e92f700e7a
Issue-ID: SO-1487
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoRemove resources that are not neutron networks 60/78160/1
Benjamin, Max (mb388a) [Fri, 8 Feb 2019 22:40:25 +0000 (17:40 -0500)]
Remove resources that are not neutron networks

Remove resources that are not neutron networks

Change-Id: Ie136895f95273e53f86201fe3b58a12fa27c8fe6
Issue-ID: SO-1486
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoadd DSL endpoint support to A&AI Client 59/78159/1
Benjamin, Max (mb388a) [Fri, 8 Feb 2019 22:39:18 +0000 (17:39 -0500)]
add DSL endpoint support to A&AI Client

add DSL endpoint support to A&AI Client

Change-Id: I4e5772354d1d79a343bfac78b4a10ca0c00e3edf
Issue-ID: SO-1485
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "provide correct custIds"
Steve Smokowski [Fri, 8 Feb 2019 15:21:47 +0000 (15:21 +0000)]
Merge "provide correct custIds"

5 years agoMerge "populate modelinfovfmodule from catalog db"
Steve Smokowski [Fri, 8 Feb 2019 15:21:39 +0000 (15:21 +0000)]
Merge "populate modelinfovfmodule from catalog db"

5 years agoAdd junit tests for AdapterRestClient 14/78114/1
Lukasz Muszkieta [Fri, 8 Feb 2019 13:14:12 +0000 (14:14 +0100)]
Add junit tests for AdapterRestClient

Change-Id: Ieb92404710b716c40762365965852dc9a00947c2
Issue-ID: SO-1480
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agomso is not updating the vip in aai for the vnf 96/78096/1
Benjamin, Max (mb388a) [Thu, 7 Feb 2019 22:25:53 +0000 (17:25 -0500)]
mso is not updating the vip in aai for the vnf

Update JUnits for multiple invocation argument verifications
Implement delete mechanism for network policies and vnf adapter params
in AAI.
Fix a JUnit for getNetworkPolicy().
Implement creation of network policies and setting of
openstack-provided params for vf module in AAI
CreateNetworkPolicies in AAI functionality update
Add the plumbing for create network policy in AAI.
Enable VnfAdapterBB to return fqdn and management ip info

Change-Id: Id34fe088846a52dbafaf3e7c754bebada05f1bf1
Issue-ID: SO-1478
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "store raw distribution notification in db"
Steve Smokowski [Thu, 7 Feb 2019 11:14:32 +0000 (11:14 +0000)]
Merge "store raw distribution notification in db"

5 years agostore raw distribution notification in db 25/78025/1
Benjamin, Max (mb388a) [Thu, 7 Feb 2019 02:17:24 +0000 (21:17 -0500)]
store raw distribution notification in db

updated the test case to verify ASDC notification sent is the same as
one persisted in the DB and verified it
updated the test case to verify ASDC notification sent is the same as
one persisted in the DB
Added unit test case for WatchdogServiceModVerIdLookup changes
Updated test resources schema.sql and data.sql to include changes to
watchdog_service_mod_ver_id_lookup table
Added length to consumer id column with WatchdogServiceModVerIdLookup
class
ASDC Controller has been enhanced to include the notification message
and consumer id as part of existing table
watchdog_service_mod_ver_id_lookup.

Change-Id: Iee805761ffc16f456d068c44b53804a7febc7933
Issue-ID: SO-1475
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoimprove vf module logic 24/78024/1
Benjamin, Max (mb388a) [Thu, 7 Feb 2019 02:16:05 +0000 (21:16 -0500)]
improve vf module logic

remove vf module from list when calculating index

Change-Id: I4b88a679eb79bfac6f25a26b10671cca4cf3c48d
Issue-ID: SO-1476
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
5 years agoMerge "logic to handle null values for vf module index"
Steve Smokowski [Wed, 6 Feb 2019 12:05:32 +0000 (12:05 +0000)]
Merge "logic to handle null values for vf module index"