so.git
5 years agoMerge "asdc controller treat distributionid as requestid"
Steve Smokowski [Fri, 16 Aug 2019 13:05:51 +0000 (13:05 +0000)]
Merge "asdc controller treat distributionid as requestid"

5 years agoMerge "apih format statusdetail to return granular"
Steve Smokowski [Fri, 16 Aug 2019 13:05:39 +0000 (13:05 +0000)]
Merge "apih format statusdetail to return granular"

5 years agoRemoved unused CSAR class. 19/93619/3
Oleksandr Moliavko [Wed, 14 Aug 2019 07:42:25 +0000 (10:42 +0300)]
Removed unused CSAR class.

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb

5 years agoReplaced string concatenations in a loop with 63/93663/2
Oleksandr Moliavko [Fri, 16 Aug 2019 06:53:30 +0000 (09:53 +0300)]
Replaced string concatenations in a loop with
StringBuffer appends to remove static analyzer
warning about inefficient string operations

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1

5 years agoMerge "Added check for empty processInstanceList"
Lukasz Muszkieta [Fri, 16 Aug 2019 10:04:05 +0000 (10:04 +0000)]
Merge "Added check for empty processInstanceList"

5 years agoSonar fix in MSOCommonBPMN 81/93381/4
Parshad Patel [Tue, 13 Aug 2019 04:38:06 +0000 (13:38 +0900)]
Sonar fix in MSOCommonBPMN

Either log or rethrow this exception
Remove this useless assignment to local variable "serviceInstance"
Remove the declaration of thrown exception  which is a runtime exception
Move the string literal on the left side of this string comparison

Issue-ID: SO-1841
Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
5 years agoAdded check for empty processInstanceList 04/93504/3
Plummer, Brittany [Tue, 13 Aug 2019 23:12:07 +0000 (19:12 -0400)]
Added check for empty processInstanceList

Added check for empty processInstanceList

Issue-ID: SO-2225
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558

5 years agoasdc controller treat distributionid as requestid 37/93637/1
Bhatt, Prema [Thu, 15 Aug 2019 19:54:22 +0000 (15:54 -0400)]
asdc controller treat distributionid as requestid

Setting RequestId in MDC using DistributionID value in ASDC-controller
Setting RequestId in MDC using DistributionID value in ASDC-controller.
Cleaned up code.
Removing the log line as per the review comments.

Issue-ID: SO-2231
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I07880a80d479ad01411e0c5ece12d77722b8cb6c

5 years agoapih format statusdetail to return granular 36/93636/1
Plummer, Brittany [Thu, 15 Aug 2019 19:48:49 +0000 (15:48 -0400)]
apih format statusdetail to return granular

Should return unchanged requestState on statusDetail queryParam
Formatted files with changes to fix build
Added enum validation for setting requestStatus
Updated test to send in "statusDetail"

Issue-ID: SO-2230
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295

5 years agoMerge "- Updated vnfc instance groups to use the"
Steve Smokowski [Thu, 15 Aug 2019 12:11:45 +0000 (12:11 +0000)]
Merge "- Updated vnfc instance groups to use the"

5 years agopublic keyword removed for DoCreateServiceInstanceRollback.groovy 25/93325/2
anjali.walsatwar [Mon, 12 Aug 2019 10:26:51 +0000 (15:56 +0530)]
public keyword removed for DoCreateServiceInstanceRollback.groovy

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: If2b6f5d1416042dd8ce88ae9d467ae24b00a1c55

5 years agoMerge "DoCreateVFCNetworkServiceInstance.groovy corrected"
Lukasz Muszkieta [Wed, 14 Aug 2019 10:27:45 +0000 (10:27 +0000)]
Merge "DoCreateVFCNetworkServiceInstance.groovy corrected"

5 years ago- Updated vnfc instance groups to use the 03/93503/1
Merkel, Jeff [Tue, 13 Aug 2019 23:10:26 +0000 (19:10 -0400)]
- Updated vnfc instance groups to use the

- Updated vnfc instance groups to use the getEntity API.

Issue-ID: SO-2224
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I278aebe5174dfb52ad3db86957c262dca5eac359

5 years agoMerge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest classes"
Lukasz Muszkieta [Tue, 13 Aug 2019 14:42:41 +0000 (14:42 +0000)]
Merge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest classes"

5 years agoMerge "Place diamond op in place of type spec"
Lukasz Muszkieta [Tue, 13 Aug 2019 14:41:31 +0000 (14:41 +0000)]
Merge "Place diamond op in place of type spec"

5 years agoMerge "Removed unused method setHPAParameters()"
Lukasz Muszkieta [Tue, 13 Aug 2019 14:40:16 +0000 (14:40 +0000)]
Merge "Removed unused method setHPAParameters()"

5 years agoRemoved unused CryptoHandler, ICryptoHandler and 99/93299/2
Oleksandr Moliavko [Mon, 12 Aug 2019 06:56:10 +0000 (09:56 +0300)]
Removed unused CryptoHandler, ICryptoHandler and
CryptoHandlerTest classes

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I944ae9b49326257b6ddfe94687c3241e91af4de9

5 years agoPlace diamond op in place of type spec 41/93341/2
sindhu3672 [Mon, 12 Aug 2019 13:21:06 +0000 (18:51 +0530)]
Place diamond op in place of type spec

Place diamond op in place of type spec MSOCommonBPMN classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I133a9328f5c91c61af24a57a610d36c6d6622f66

5 years agoRemoved unused method setHPAParameters() 44/93344/2
Oleksandr Moliavko [Mon, 12 Aug 2019 13:49:20 +0000 (16:49 +0300)]
Removed unused method setHPAParameters()

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Ic9de579495c1400bca233b679699ae857180520b

5 years agoMerge "Removed duplicate use of networkType field in String.format() call to prevent...
Lukasz Muszkieta [Tue, 13 Aug 2019 08:59:57 +0000 (08:59 +0000)]
Merge "Removed duplicate use of networkType field in String.format() call to prevent static analyzer warning"

5 years agoMerge "Change variable name-comply with regex"
Seshu Kumar M [Tue, 13 Aug 2019 08:40:29 +0000 (08:40 +0000)]
Merge "Change variable name-comply with regex"

5 years agoMerge "Change variable name-comply with regex"
Seshu Kumar M [Tue, 13 Aug 2019 08:39:59 +0000 (08:39 +0000)]
Merge "Change variable name-comply with regex"

5 years agoMerge "update version for 1.5.1"
subhash kumar singh [Tue, 13 Aug 2019 08:39:53 +0000 (08:39 +0000)]
Merge "update version for 1.5.1"

5 years agoMerge "Enhance variable name-comply with regex"
Lukasz Muszkieta [Tue, 13 Aug 2019 08:38:55 +0000 (08:38 +0000)]
Merge "Enhance variable name-comply with regex"

5 years agoRemoved duplicate use of networkType field in 83/93383/1
Oleksandr Moliavko [Tue, 13 Aug 2019 07:12:42 +0000 (10:12 +0300)]
Removed duplicate use of networkType field in
String.format() call to prevent static analyzer
warning

Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I1e3ea352aac9a88172b683d267b2f3c804bb362b

5 years agoMerge "Modify variable name-comply with regex"
Seshu Kumar M [Tue, 13 Aug 2019 05:28:24 +0000 (05:28 +0000)]
Merge "Modify variable name-comply with regex"

5 years agoMerge "Replace with equalsIgnoreCase"
Seshu Kumar M [Tue, 13 Aug 2019 05:27:40 +0000 (05:27 +0000)]
Merge "Replace with equalsIgnoreCase"

5 years agoMerge "Use diamond op in place of type spec"
Seshu Kumar M [Tue, 13 Aug 2019 05:26:19 +0000 (05:26 +0000)]
Merge "Use diamond op in place of type spec"

5 years agoupdate version for 1.5.1 80/93380/1
seshukm [Tue, 13 Aug 2019 04:40:01 +0000 (10:10 +0530)]
update version for 1.5.1

Issue-ID: SO-2223

Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
Change-Id: I972e6be75ce9ca38e3d08ac17a48af62f0aa2f05

5 years agoEnhance variable name-comply with regex 34/93334/2
sindhu3672 [Mon, 12 Aug 2019 11:37:55 +0000 (17:07 +0530)]
Enhance variable name-comply with regex

Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5

5 years agoMerge "Remove repeated conditional test in ​buildServiceErrorResponse"
Lukasz Muszkieta [Mon, 12 Aug 2019 13:55:17 +0000 (13:55 +0000)]
Merge "Remove repeated conditional test in ​buildServiceErrorResponse"

5 years agoMerge "query builder now handles more than just strings"
Steve Smokowski [Mon, 12 Aug 2019 13:49:33 +0000 (13:49 +0000)]
Merge "query builder now handles more than just strings"

5 years agoMerge "added in mapping of aggregate routes in"
Steve Smokowski [Mon, 12 Aug 2019 13:49:24 +0000 (13:49 +0000)]
Merge "added in mapping of aggregate routes in"

5 years agoMerge "health check now entirely config based"
Steve Smokowski [Mon, 12 Aug 2019 13:49:13 +0000 (13:49 +0000)]
Merge "health check now entirely config based"

5 years agoMerge "All extendable enums should be serializable"
Steve Smokowski [Mon, 12 Aug 2019 13:49:02 +0000 (13:49 +0000)]
Merge "All extendable enums should be serializable"

5 years agoMerge "Remove useless double assignment in PnfEventReadyDmaapClient.​unregister"
Lukasz Muszkieta [Mon, 12 Aug 2019 12:49:25 +0000 (12:49 +0000)]
Merge "Remove useless double assignment in PnfEventReadyDmaapClient.​unregister"

5 years agoReplace with equalsIgnoreCase 33/93333/1
sindhu3672 [Mon, 12 Aug 2019 11:28:40 +0000 (16:58 +0530)]
Replace with equalsIgnoreCase

Replace with equalsIgnoreCase bpmn ServicePluginFactory class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I2860546bb921a1b685f824beb0cd790e826435ad

5 years agoMerge "Sonar fix in mso-adapter-utils"
Lukasz Muszkieta [Mon, 12 Aug 2019 10:41:04 +0000 (10:41 +0000)]
Merge "Sonar fix in mso-adapter-utils"

5 years agoMerge changes I2fead528,I2e9fd421,Ib67d7240
Seshu Kumar M [Mon, 12 Aug 2019 10:28:42 +0000 (10:28 +0000)]
Merge changes I2fead528,I2e9fd421,Ib67d7240

* changes:
  DeleteVFCNSResource.groovy corrected
  DeActivateSDNCNetworkResource.groovy  corrected
  DoCreateServiceInstance.groovy corrected

5 years agoDoCreateVFCNetworkServiceInstance.groovy corrected 22/93322/1
anjali.walsatwar [Mon, 12 Aug 2019 10:24:35 +0000 (15:54 +0530)]
DoCreateVFCNetworkServiceInstance.groovy corrected

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I537a9a5ef72823f9aec9504e0475eee970c04a1a

5 years agoChange variable name-comply with regex 09/93309/2
sindhu3672 [Mon, 12 Aug 2019 09:10:28 +0000 (14:40 +0530)]
Change variable name-comply with regex

Change variable name-comply with regex asdc controller and bpmn classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ib1e16b2df9c620f2f225424e003226996fbe99e1

5 years agoChange variable name-comply with regex 16/93316/1
sindhu3672 [Mon, 12 Aug 2019 10:08:59 +0000 (15:38 +0530)]
Change variable name-comply with regex

Change variable name-comply with regex asdc-controller & mso-api-handlers classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I709cbcacc32e57a8b9cf89a963321bfde3b08301

5 years agoUse diamond op in place of type spec 06/93306/2
sindhu3672 [Mon, 12 Aug 2019 08:55:55 +0000 (14:25 +0530)]
Use diamond op in place of type spec

Use diamond op in place of type spec MSOCommonBPMN classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I8812392bbc6eac6d703ff7eeabf8e95806aab442

5 years agoModify variable name-comply with regex 11/93311/1
sindhu3672 [Mon, 12 Aug 2019 09:24:33 +0000 (14:54 +0530)]
Modify variable name-comply with regex

Modify variable name-comply with regex mso api handlers DuplicateRequestException class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ifbd69bffcfce08cc2e9c44817a02f9ddfe28aadc

5 years agoDeleteVFCNSResource.groovy corrected 10/93310/1
anjali.walsatwar [Mon, 12 Aug 2019 09:13:56 +0000 (14:43 +0530)]
DeleteVFCNSResource.groovy corrected

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I2fead52822d107ad712624ba9a37c959eae8c077

5 years agoMerge "Replace type spec with diamond op"
Seshu Kumar M [Mon, 12 Aug 2019 08:50:43 +0000 (08:50 +0000)]
Merge "Replace type spec with diamond op"

5 years agoDeActivateSDNCNetworkResource.groovy corrected 05/93305/1
anjali.walsatwar [Mon, 12 Aug 2019 08:45:45 +0000 (14:15 +0530)]
DeActivateSDNCNetworkResource.groovy  corrected

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I2e9fd421f528ee147188f626817a5f3e68fa55fa

5 years agoDoCreateServiceInstance.groovy corrected 03/93303/1
anjali.walsatwar [Mon, 12 Aug 2019 08:36:40 +0000 (14:06 +0530)]
DoCreateServiceInstance.groovy corrected

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: Ib67d724009c172aa86347853075b3cf7ee6be502

5 years agoMerge "fix sonar issue"
Seshu Kumar M [Mon, 12 Aug 2019 08:33:23 +0000 (08:33 +0000)]
Merge "fix sonar issue"

5 years agoMerge "Change collections size with isEmpty"
Seshu Kumar M [Mon, 12 Aug 2019 08:32:04 +0000 (08:32 +0000)]
Merge "Change collections size with isEmpty"

5 years agoMerge "Move string literal left side-avoid null pointer ex"
Seshu Kumar M [Mon, 12 Aug 2019 08:31:42 +0000 (08:31 +0000)]
Merge "Move string literal left side-avoid null pointer ex"

5 years agoMerge "Change string literal left side-avoid null pointer ex"
Seshu Kumar M [Mon, 12 Aug 2019 08:31:06 +0000 (08:31 +0000)]
Merge "Change string literal left side-avoid null pointer ex"

5 years agoMerge "Merge if stmts for code readability"
Seshu Kumar M [Mon, 12 Aug 2019 08:30:05 +0000 (08:30 +0000)]
Merge "Merge if stmts for code readability"

5 years agoMerge "DoCreateResources.groovy corrected"
Lukasz Muszkieta [Mon, 12 Aug 2019 08:10:33 +0000 (08:10 +0000)]
Merge "DoCreateResources.groovy corrected"

5 years agoMerge "corrected CompareModelofE2EServiceInstance.groovy"
Lukasz Muszkieta [Mon, 12 Aug 2019 08:07:45 +0000 (08:07 +0000)]
Merge "corrected CompareModelofE2EServiceInstance.groovy"

5 years agoSonar fix in mso-adapter-utils 02/93302/1
Parshad Patel [Mon, 12 Aug 2019 07:49:39 +0000 (16:49 +0900)]
Sonar fix in mso-adapter-utils

Either log or rethrow this exception
Remove this unused import
Make "workloadStatusReason" transient or serializable

Issue-ID: SO-1841
Change-Id: I01fe8ce059b5fde95d300d2d0e5b4a1a114c479a
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
5 years agoMerge "Replace collections size with isEmpty"
Lukasz Muszkieta [Mon, 12 Aug 2019 07:16:28 +0000 (07:16 +0000)]
Merge "Replace collections size with isEmpty"

5 years agoChange string literal left side-avoid null pointer ex 01/93301/1
sindhu3672 [Mon, 12 Aug 2019 07:01:22 +0000 (12:31 +0530)]
Change string literal left side-avoid null pointer ex

Change string literal left side so.adapters.vnfmadapter WebSecurityConfigImpl class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I8ba57bd9c3c548a35b90d9324f1d214985c3c539

5 years agoMove string literal left side-avoid null pointer ex 96/93296/1
sindhu3672 [Mon, 12 Aug 2019 06:39:09 +0000 (12:09 +0530)]
Move string literal left side-avoid null pointer ex

Move string literal left side so.adapters.vnfmadapter WebSecurityConfigImpl class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I6669a11bf95a41e3efa18d907f2b3f3eb3f3f1b3

5 years agoDoCreateResources.groovy corrected 82/93182/5
anjali.walsatwar [Fri, 9 Aug 2019 10:18:11 +0000 (15:48 +0530)]
DoCreateResources.groovy corrected

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I1d4dc5370125a587b11cbf05b69fdaf8fcaa37aa

5 years agoChange collections size with isEmpty 88/93288/1
sindhu3672 [Mon, 12 Aug 2019 05:40:32 +0000 (11:10 +0530)]
Change collections size with isEmpty

Change collections size with isEmpty mso-adapter-utils class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I784a5839d003c42a9880287d304060cd9639f1b6

5 years agocorrected CompareModelofE2EServiceInstance.groovy 78/93178/3
anjali.walsatwar [Fri, 9 Aug 2019 10:15:44 +0000 (15:45 +0530)]
corrected CompareModelofE2EServiceInstance.groovy

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I42b005210df986b1a4f006982f9d89be54bffa7f

5 years agoMerge changes Ia52d9db2,Iab16430b
Seshu Kumar M [Sun, 11 Aug 2019 18:18:02 +0000 (18:18 +0000)]
Merge changes Ia52d9db2,Iab16430b

* changes:
  Remove unused public access modifier
  Add vfmodule support to e2e service instance

5 years agoMerge changes I045619a9,Iadffb2af,Ie97c560d
Seshu Kumar M [Sun, 11 Aug 2019 18:17:28 +0000 (18:17 +0000)]
Merge changes I045619a9,Iadffb2af,Ie97c560d

* changes:
  Remove unwanted semicolon from groovy files
  Remove unwanted semicolon
  Removed unrequired semicolon from groovy

5 years agoAll extendable enums should be serializable 48/93248/1
Benjamin, Max (mb388a) [Fri, 9 Aug 2019 20:22:17 +0000 (16:22 -0400)]
All extendable enums should be serializable

marking items as transient causes them to be lost

Issue-ID: SO-2217
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: If66f9034b67f94c8122875ef915043525fb9bdb7

5 years agohealth check now entirely config based 36/93236/2
Benjamin, Max [Fri, 9 Aug 2019 17:29:22 +0000 (13:29 -0400)]
health check now entirely config based

health check now entirely config based
api handler now lists itself as an endpoint
updated robot test to verify new format
fixed formatting issues with modified files
updated test case to reflect new statuses
fixed duplicate bean issue with converter
ignore unit test that never worked
added missing class to context configuration
removed extraneous spaces from robot file
update robot files as well as fix compile issues
config format must be correct on startup

Issue-ID: SO-2216
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I86770922c7b7f36e4a4d59615f7336cda7cbe629

5 years agoReplace collections size with isEmpty 35/93235/1
sindhu3672 [Fri, 9 Aug 2019 17:09:55 +0000 (22:39 +0530)]
Replace collections size with isEmpty

Replace collections size with isEmpty mso-adapter-utils class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Icf6fc86d9d6f02571938804d214b5b5bfca72698

5 years agoReplace type spec with diamond op 32/93232/1
sindhu3672 [Fri, 9 Aug 2019 16:17:34 +0000 (21:47 +0530)]
Replace type spec with diamond op

Replace type spec with diamond operator cloudify-client classes

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I074c6d28b387a425841f1e35964c336834aff5b4

5 years agoMerge if stmts for code readability 30/93230/1
sindhu3672 [Fri, 9 Aug 2019 15:38:06 +0000 (21:08 +0530)]
Merge if stmts for code readability

Merge if stmts for code readability asdc controller DeployActivitySpecs class

Issue-ID: SO-2187

Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: If27dc7b6e28e4058c4132e7d8178b773cb9f065b

5 years agoRemove repeated conditional test in ​buildServiceErrorResponse 79/93179/2
Artem Naluzhnyy [Fri, 9 Aug 2019 09:58:30 +0000 (11:58 +0200)]
Remove repeated conditional test in ​buildServiceErrorResponse

Coverity-scan: CID-203826
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I18d788e361b502e392f7f59ff6bc772dfee394bd

5 years agoRemove useless double assignment in PnfEventReadyDmaapClient.​unregister 80/93180/2
Artem Naluzhnyy [Fri, 9 Aug 2019 10:01:51 +0000 (12:01 +0200)]
Remove useless double assignment in PnfEventReadyDmaapClient.​unregister

Coverity-scan: CID-211458
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I670bb1f5684b90f0d4d01542c77c882e3d4966e4

5 years agoMerge "Remove unused SDNCServiceRequest constructors"
Lukasz Muszkieta [Fri, 9 Aug 2019 13:36:57 +0000 (13:36 +0000)]
Merge "Remove unused SDNCServiceRequest constructors"

5 years agoMerge "removed unwanted public for ActivateSDNCNetworkResource.groovy"
subhash kumar singh [Fri, 9 Aug 2019 13:35:41 +0000 (13:35 +0000)]
Merge "removed unwanted public for ActivateSDNCNetworkResource.groovy"

5 years agoMerge "fix sonar issue"
subhash kumar singh [Fri, 9 Aug 2019 13:34:51 +0000 (13:34 +0000)]
Merge "fix sonar issue"

5 years agoRemove unwanted semicolon from groovy files 24/93224/1
subhash kumar singh [Fri, 9 Aug 2019 13:30:52 +0000 (19:00 +0530)]
Remove unwanted semicolon from groovy files

Remove unwanted semicolon from groovy files.

Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: I045619a93597459d7ae5f656a880d36b4a46f001

5 years agoRemove unwanted semicolon 23/93223/1
subhash kumar singh [Fri, 9 Aug 2019 13:25:17 +0000 (18:55 +0530)]
Remove unwanted semicolon

Remove unwanted semicolon.

Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Iadffb2affff8597a8eb8258041b37cb8bf701f20

5 years agoMerge changes I8e443077,I51a9106a,I54076323
subhash kumar singh [Fri, 9 Aug 2019 13:14:43 +0000 (13:14 +0000)]
Merge changes I8e443077,I51a9106a,I54076323

* changes:
  fix sonar issue
  fix sonar issue
  fix sonar issue

5 years agofix sonar issue 16/93216/1
sarada prasad sahoo [Fri, 9 Aug 2019 12:58:54 +0000 (18:28 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I841a50876aaf22e1fbc597029f270d243adf2613

5 years agoquery builder now handles more than just strings 14/93214/1
Benjamin, Max [Fri, 9 Aug 2019 12:53:50 +0000 (08:53 -0400)]
query builder now handles more than just strings

query builder now handles more than just strings

Issue-ID: SO-2215
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ib138d96cf8578a0e3055120f9c3e036c690e7eae

5 years agofix sonar issue 12/93212/1
sarada prasad sahoo [Fri, 9 Aug 2019 12:43:39 +0000 (18:13 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I5049d25904c3abfdaccd84a3356c14f47be4bc57

5 years agoRemove unused SDNCServiceRequest constructors 68/93168/2
Artem Naluzhnyy [Fri, 9 Aug 2019 09:22:46 +0000 (11:22 +0200)]
Remove unused SDNCServiceRequest constructors

Coverity-scan: CID-211570
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: Id73831f5ef51bdea2e24c40c10d744df662b50ad

5 years agoadded in mapping of aggregate routes in 10/93210/1
Kalkere Ramesh, Sharan [Fri, 9 Aug 2019 12:29:21 +0000 (08:29 -0400)]
added in mapping of aggregate routes in

added in mapping of aggregate routes in bbinputsetup

Issue-ID: SO-2214
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I56048eb78eb06800ec5b9c290493d502ef7435d0

5 years agoMerge "remove not used BaseTask class"
Steve Smokowski [Fri, 9 Aug 2019 12:28:21 +0000 (12:28 +0000)]
Merge "remove not used BaseTask class"

5 years agoMerge "Terminate workflow on Abort handling code"
Steve Smokowski [Fri, 9 Aug 2019 12:28:05 +0000 (12:28 +0000)]
Merge "Terminate workflow on Abort handling code"

5 years agoMerge "Add SO re-name the migration sql for version conflict"
Steve Smokowski [Fri, 9 Aug 2019 12:27:34 +0000 (12:27 +0000)]
Merge "Add SO re-name the migration sql for version conflict"

5 years agoMerge "add rainy day handling with SERVICE_ROLE and type"
Steve Smokowski [Fri, 9 Aug 2019 12:27:07 +0000 (12:27 +0000)]
Merge "add rainy day handling with SERVICE_ROLE and type"

5 years agofix sonar issue 05/93205/1
sarada prasad sahoo [Fri, 9 Aug 2019 12:20:27 +0000 (17:50 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I8e443077864d758149bb5f62bc5dc5f718c29204

5 years agofix sonar issue 02/93202/1
sarada prasad sahoo [Fri, 9 Aug 2019 12:05:14 +0000 (17:35 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I51a9106ad99e7bb101c3d6c9a33603ac202d7cb6

5 years agoRemoved unrequired semicolon from groovy 98/93198/1
subhash kumar singh [Fri, 9 Aug 2019 11:28:37 +0000 (16:58 +0530)]
Removed unrequired semicolon from groovy

Removed unrequired semicolon from groovy.

Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Ie97c560db89dcd15d424c11473a312e9d684cbd8

5 years agoremoved unwanted public for ActivateSDNCNetworkResource.groovy 77/93177/2
anjali.walsatwar [Fri, 9 Aug 2019 10:10:21 +0000 (15:40 +0530)]
removed unwanted public for ActivateSDNCNetworkResource.groovy

groovy file correction

Issue-ID: SO-2212

Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com>
Change-Id: I5f3adeb10b4f551f515144696695834a32493e97

5 years agoRemove unused public access modifier 93/93193/1
subhash kumar singh [Fri, 9 Aug 2019 10:53:00 +0000 (16:23 +0530)]
Remove unused public access modifier

Remove unused public access modifier.

Issue-ID: SO-2212
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Ia52d9db2dc9b6500954f516cf456240f4b9e1bf0

5 years agofix sonar issue 88/93188/1
sarada prasad sahoo [Fri, 9 Aug 2019 10:39:45 +0000 (16:09 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I5407632386d75a239a4847e763159e60c3008ded

5 years agoAdd vfmodule support to e2e service instance 86/93186/1
subhash.kumar.singh [Fri, 9 Aug 2019 09:14:50 +0000 (14:44 +0530)]
Add vfmodule support to e2e service instance

Parse vfmodule to add to resource instance list.

Issue-ID: SO-2213
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
Change-Id: Iab16430b498e505cd89a0ba4c12cfd2f88b9a982

5 years agoTerminate workflow on Abort handling code 31/93131/1
Elena Kuleshov [Thu, 8 Aug 2019 21:35:56 +0000 (17:35 -0400)]
Terminate workflow on Abort handling code

Throw WorkflowException to terminate the custom workflow when Abort handling code is returned, add constant names for variables

Issue-ID: SO-2171
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I29a5ede2503f42ff28486318e0239eb6beeb4271

5 years agoadd rainy day handling with SERVICE_ROLE and type 41/92941/2
Mnushkin, Dmitry [Wed, 7 Aug 2019 19:01:02 +0000 (15:01 -0400)]
add rainy day handling with SERVICE_ROLE and type

add rainy day handling with SERVICE_ROLE and type

Issue-ID: SO-2205
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: Ib85ccd787d4c8b210abb983e1f114da3d36be2b6

5 years agoAdd SO re-name the migration sql for version conflict 08/93108/1
Bonkur, Venkat (vb8416) [Thu, 8 Aug 2019 16:41:12 +0000 (12:41 -0400)]
Add SO re-name the migration sql for version conflict

Rename the version from V6.1 to V6.3 for
V6.1__AlterColumnActionCategoryControllerSelectionCategory.sql
There is another script with same version in the att ecomp.
Issue-ID: SO-2209
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ia7e527419dfe149f8cbdd9d0748768f8b7bc9904

5 years agofix sonar issue 06/93106/1
sarada prasad sahoo [Thu, 8 Aug 2019 15:28:14 +0000 (20:58 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I137e40866ccbfb634b430ea56028fac87cc6b2bc

5 years agoremove not used BaseTask class 97/93097/1
Lukasz Muszkieta [Thu, 8 Aug 2019 14:45:42 +0000 (16:45 +0200)]
remove not used BaseTask class

BaseTask class serves only as JavaDelegate implementation provider, should be removed

Change-Id: I46f56cb850d12e4ef395db9429297d05f3a51b37
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
5 years agofix sonar issue 96/93096/1
sarada prasad sahoo [Thu, 8 Aug 2019 14:42:16 +0000 (20:12 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: Ia0bb25c9fc10364fddde10d38675540d0c539227

5 years agofix sonar issue 86/93086/1
sarada prasad sahoo [Thu, 8 Aug 2019 13:58:30 +0000 (19:28 +0530)]
fix sonar issue

fix sonar issues

Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: I79db093a27165fd5d54dfab1c1d25749bf6df533